50dcbdeec6
fix(files_sharing): adjust rate limit share creation to 20 over 10 minutes
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-04-15 10:32:47 +07:00
338ab64365
fix(files_sharing): rate limit share creation 10 times per 10 minutes
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-15 08:45:25 +07:00
70218dc0a4
fix(files_sharing): fix share creation error handling
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-09 14:52:42 +07:00
a39bee57d9
fix: Fix download activity for folders
...
Remove duplicate activity publishing from share controller download,
listen to BeforeZipCreatedEvent to publish activity for folders, and
cache folders activity to avoid sending activity for each file in the
folder.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +07:00
00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +07:00
34251c4375
fix(lookup-server): do not query data by default
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +07:00
7e6608d119
fix(files_sharing): Also list deleted team shares
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-20 14:32:22 +07:00
c19ce403f3
fix(files_sharing): block downloading if needed
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-18 11:58:12 +07:00
64863c9d46
chore: Apply new rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:46:42 +07:00
ed5b7ae161
chore: re-apply current rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:45:33 +07:00
a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +07:00
8178797eb5
refactor: Remove some deprecated containers and exceptions
...
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-06 12:15:31 +07:00
73dc0f0f19
fix(sharing): Ensure download restrictions are not dropped
...
When a user receives a share with share-permissions but also with
download restrictions (hide download or the modern download permission attribute),
then re-shares of that share must always also include those restrictions.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-04 15:39:14 +07:00
253f4345f1
fix(files_sharing): Respect permissions passed when creating link shares
...
Given:
User creates a link or email share with permissions=4 (create only = file drop).
Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.
Solution:
Respect what the user is requesting, create a file drop share.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 16:40:50 +07:00
305e1bb260
fix: Ensure `label` is always a string
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-26 20:41:31 +07:00
d9a7124592
Merge pull request #49898 from nextcloud/fix/noid/no-emails-for-user-shares
...
fix(sharing): send share emails for internal users too
2025-01-16 18:50:30 +07:00
0eb39d7b9c
feat(sharing): Respect admin custom tokens setting
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 +07:00
beffb26266
feat(sharing): Fetch a unique generated token
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:49:19 +07:00
f92875cf6a
feat(sharing): Allow updating share token
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:49:19 +07:00
4dfa02c29d
fix(files_sharing): Handle null userId
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-13 15:19:54 +07:00
236e084fbb
fix(sharing): send share emails for internal users too
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2025-01-13 14:13:02 +07:00
085d4c9364
refactor(OpenAPI): Adjust scopes to match previous behavior
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-06 14:30:40 +07:00
5581f0c7bf
chore: remove legacy action to test remote endpoint
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-11-29 11:14:37 +07:00
ae1c3b372e
chore: stricter access to testremote endpoint
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-11-28 11:22:15 +07:00
beea8854ca
feat(files_sharing): Allow users with share permission to manage shares on IShareOwnerlessMount
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
b658ab7a86
fix(files_sharing): Remove duplicate link/email edit share logic
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
f44a192613
fix(files_sharing): Fix error messages from password policy
...
Exceptions thrown from password_policy may bubble up in share creation
or update when a password is used. Their message is meant to be shown
to the user. This always the case for HintException so we catch that
instead of the subclass GenericShareException.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-11-19 09:40:26 +07:00
77114fb327
fix(OpenAPI): Adjust array syntax to avoid ambiguities
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-05 09:58:11 +07:00
c84c256261
fix: Adjust preview for view-only shares
...
Previously there was a different behavior for public shares (link-shares) and internal shares,
if the user disabled the view permission.
The legacy UI for public shares simply "disabled" the context menu and hided all download actions.
With Nextcloud 31 all share types use the consistent permissions attributes,
which simplifies code, but caused a regression: Images can no longer been viewed.
Because on 30 and before the attribute was not set, previews for view-only files
were still allowed. Now with 31 we need a new way to allow "viewing" shares.
So this is allowing previews for those files, but only for internal usage.
This is done by settin a special header, which only works with custom requests,
and not by opening the URL directly.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-28 15:52:27 +07:00
aacb3ddc1e
fix(files_sharing): Cleanup error messages
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-28 09:07:41 +07:00
227b8462d8
refactor(ShareApiController): Check for null and empty strings with empty()
...
Proactive measure to avoid warnings in higher php versions as well possible type errors
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-10-24 18:37:42 +07:00
e2d2a17810
fix(ShareAPI): Send mails for mail shares by default
...
It looks like, the frontend it needs to provide the `sendMail` param
for the backend to decide wether mails would be sent.
Our UI does not have that at the moment so it should default to sending
emails always for mail shares.
Not exactly sure how this was handled earlier but this is a good starting point.
Resolves : https://github.com/nextcloud/server/issues/48012
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-10-24 14:41:07 +07:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:40:25 +07:00
e9d590674d
feat(files_sharing): Make `ShareController` download route use the DAV `ZipFolderPlugin`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 13:18:34 +07:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
bb37954abb
fix(files_sharing): adjust permissions from custom edit and delete check methods
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-11 13:17:42 +07:00
c43353d6e6
fix: Display 'Leave share' instead of 'Delete'
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-09-06 13:50:52 +07:00
1d16bc47ff
fix(files_sharing): Handle download permission the same way for public and internal shares
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
8af7ecb257
chore: adjust code to adhere to coding standard
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:23:38 +07:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
dd58e5290f
feat: Use new password context in sharing API
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-22 19:16:55 +07:00
f0b658014a
Merge pull request #47070 from nextcloud/circToTeam
...
fix(share): Rename Circle to Team
2024-08-06 23:25:47 +07:00
db28aa8cd1
fix(files_sharing): show proper share not found error message
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-06 16:25:10 +07:00
6002566d92
fix(share): Rename Circle to Team
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-08-06 14:48:07 +07:00
b6e3009e12
Merge pull request #47043 from nextcloud/fix/noid/ignore-root-on-inherited-shares
...
fix(inherited-shares): ignore top root folder
2024-08-06 11:08:17 +07:00
712965daa1
fix(files_sharing): filter out invalid shareWith in sharee API
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-05 20:36:45 +07:00
6c4b0dba77
fix(inherited-shares): ignore top root folder
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-08-05 13:40:53 +07:00
9128a23af1
refactor(files_sharing): Replace security annotations with respective attributes
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-27 22:42:51 +07:00
43ca07809d
fix(files_sharing): file request creation permissions and link copy display
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-18 19:47:11 +07:00
John Molakvoæ
skjnldsv
Côme Chilliet
Ferdinand Thiessen
nfebe
Anna
Christopher Ng
provokateurin
Benjamin Gaussorgues
Marcel Klehr
Daniel Kesselberg
Andy Scherzinger
Git'Fellow
Maxence Lange