sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(files_sharing): file request creation permissions and link copy display 

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
pull/46589/head
skjnldsv 2024-07-16 20:39:28 +07:00
parent fec615c140
commit 43ca07809d
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
apps/files_sharing/lib/Controller/ShareAPIController.php
Unescape Escape View File

@ -596,8 +596,10 @@ class ShareAPIController extends OCSController {
throw new OCSNotFoundException($this->l->t('Invalid permissions'));
}
// Shares always require read permissions
$permissions |= Constants::PERMISSION_READ;
// Shares always require read permissions OR create permissions
if (($permissions & Constants::PERMISSION_READ) === 0 && ($permissions & Constants::PERMISSION_CREATE) === 0) {
$permissions |= Constants::PERMISSION_READ;
}
if ($node instanceof \OCP\Files\File) {
// Single file shares should never have delete or create permissions

4
apps/files_sharing/src/components/SharingEntryLink.vue
Unescape Escape View File

@ -25,8 +25,8 @@
</div>
<!-- clipboard -->
<NcActions v-if="share && !isEmailShareType && share.token" ref="copyButton" class="sharing-entry__copy">
<NcActionButton :title="copyLinkTooltip"
<NcActions v-if="share && (!isEmailShareType || isFileRequest) && share.token" ref="copyButton" class="sharing-entry__copy">
<NcActionButton :title="copyLinkTooltip"
:aria-label="copyLinkTooltip"
@click.prevent="copyLink">
<template #icon>