c988d782eb
Merge pull request #39331 from nextcloud/feature/openapi/core
...
core: Add OpenAPI spec
2023-07-13 15:36:51 +07:00
1be836273d
core: Add OpenAPI spec
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-13 07:24:15 +07:00
faf2b2339d
test(settings): Users table
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-07-12 21:35:55 +07:00
8faa1a4fe7
fix(acceptance): UsersSettingsContext
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-07-12 21:35:55 +07:00
48e47c6a46
fix: also run phpunit on `apps/theming/css` modified files
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-07-12 09:25:39 +07:00
2c6f32cb28
feat(request): Allow to match the client version with the IRequest::USER_AGENT_* regex
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-11 07:35:50 +07:00
bf2dcd67f3
LLM OCP API: Change Tests to use EventDispatcher mock
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
d56286b8ac
LLM OCP API: s/getAvailableTasks/getAvailableTaskClasses/
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
c568c4a464
Add test for task cleanup
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
20cb9935ca
Fix tests
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
ebc7631544
Add preliminary tests
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
05aa39d777
Fix event names of 2FA related typed events
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-03 14:25:01 +07:00
97683a5b66
fix(settings): Migrate away from deprecated `NcPopoverMenu`
...
* Replace popover menu with `NcActions`
* Deduplicate user actions code between `UserRow` and `UserRowSimple`
* Fix user action to cover whole row heigh to prevent dropdown from shining through the actions
* Fix user action popover to be overlayed by current edited row actions
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-06-30 11:38:11 +07:00
b0001c6010
Add template types to responses
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-06-30 09:33:29 +07:00
5e81a9e53d
fix: Add cypress test for changing password in the users list
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-06-29 00:08:21 +07:00
3fba4c5529
Replace plain input fields with NcTextField fields and NcMultiSelect fields with NcSelect fields
...
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-06-28 21:53:12 +07:00
ec6728d710
feat(HTTPClient): Provide wrapped access to Guzzle's asyncRequest()
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-27 15:53:57 +07:00
9751303182
Merge pull request #38679 from nextcloud/feat/add-spec-to-preview-fetched-event
...
feat: add width, height, crop and mode to BeforePreviewFetchedEvent
2023-06-26 13:53:27 +07:00
783f1b9a2a
Merge pull request #38775 from fsamapoor/constructor_property_promotion_in_core_command_part9
...
Uses PHP8's constructor property promotion in core/Command and /
2023-06-26 10:38:06 +07:00
f7183c9dcf
Merge pull request #38958 from nextcloud/enh/noid/use-getsystemvalue-mailer
...
use getsystemvalue-functions in Mailer.php
2023-06-26 10:23:29 +07:00
fd0e2f711a
Fixes testcase error.
...
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-24 23:14:23 +07:00
17515995fa
Merge pull request #38625 from nextcloud/fix/noid/querysearchehelper-narrow-type
...
fix: expect interface, not a specific implementation
2023-06-24 00:13:43 +07:00
1cb81ae625
try to fix tests
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-06-23 17:12:45 +07:00
440f882322
feat: add width, height, crop and mode to BeforePreviewFetchedEvent
...
user_usage_report keeps a counter for files read.
The app uses
- OC_Filesystem::read hook
- Event listener (the legacy one) for IPreview::EVENT
Request for previews do not trigger the hook, hence the additional event listener.
The thumbnails for a list or grid view should not count, so we need the width and height.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-23 16:27:35 +07:00
a3fe1adb03
Merge pull request #38917 from nextcloud/bugfix/talk-9558/plural-issue-with-some-language-locale-combinations
...
fix(l10n): Fix plural issue with different locale and language
2023-06-22 09:17:48 +07:00
84ff000767
enh(a11y): New user modal
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-06-21 11:12:40 +07:00
f6ac874dbf
chore: ugly type juggling
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 16:53:20 +07:00
f8e697ce4d
feat: prepare jest upgrade and ts testing
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 09:08:04 +07:00
ab8205fd35
fix(l10n): Fix plural issue with different locale and language
...
We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-21 07:14:56 +07:00
7f4651637a
Allow stdClass in XML responses
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-06-13 11:44:47 +07:00
08a3f37695
chore(appframework)!: Drop \OCP\AppFramework\Http\EmptyContentSecurityPolicy::allowInlineScript
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-12 10:03:59 +07:00
ffa30ce89b
Merge pull request #38524 from nextcloud/chore/app/clear-unused-cache-key
...
chore(app): Do not clear unused cache key
2023-06-05 17:48:44 +07:00
a2afc7b6a9
refactor: migrate OC_EventSource to dependency injection
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-03 21:42:51 +07:00
6d076c1ee9
fix(dispatcher): Migrate to OCP event dispatcher before symfony/event-dispatcher upgrade
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-02 08:08:24 +07:00
e76d525a43
chore: Drop \OC_App::getAppInfo
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:27 +07:00
cf6e2fa1b7
chore: Drop \OC_App::getAppVersion
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:26 +07:00
315f7f286f
chore: Drop app code checker test data
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-31 14:57:57 +07:00
3d1acca1f3
chore(app): Do not clear unused cache key
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-30 17:48:20 +07:00
94e1a429e5
Revert "Fix table view"
...
This reverts commit cb852ef6
2023-05-25 11:49:24 +07:00
3d2d1c171e
Merge pull request #37758 from nextcloud/redis-atomic
...
redis: use atomic operations everywhere
2023-05-19 23:29:24 +07:00
48521d67e1
Merge pull request #38143 from nextcloud/fix/generated-avatars-cache
...
Fix generated avatars cache
2023-05-16 11:37:49 +07:00
5e02def3f4
Merge pull request #38274 from nextcloud/bugfix/noid/reach-max-delay-in-afterController
...
fix(middleware): Also abort the request when reaching max delay in af…
2023-05-16 11:07:04 +07:00
2a19753cf7
Clear generated avatar caches
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-05-15 18:18:21 +07:00
3a6bc7aba2
fix(middleware): Also abort the request when reaching max delay in afterController
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:20:19 +07:00
33385d7ecb
fix(tests): Adjust unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:12:14 +07:00
174c226c28
Merge pull request #38207 from nextcloud/fix/jsresourcelocator-l10n-handling
2023-05-12 10:47:46 +07:00
31c01fa3da
fix(JSResourceLocator): Handle missing translations silently
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-05-11 18:22:24 +07:00
cb852ef63b
Fix table view
...
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-05-11 16:36:37 +07:00
db02684008
Merge pull request #37691 from nextcloud/object-store-background-scan
2023-05-11 08:15:41 +07:00
c6cee282b3
redis: move lua scripts to class and add type hints
...
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-05-10 17:37:02 +07:00
2ea41dab93
repair -1 folder sizes for object store background scan
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-10 19:33:26 +07:00
904fdf3aa3
Merge pull request #37838 from nextcloud/event-logger-http
...
log performance events for http requests
2023-05-09 17:15:27 +07:00
b91957e3df
fix(dav): Abort requests with 429 instead of waiting
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-03 22:43:36 +07:00
7fcf42ad3f
Merge pull request #38024 from nextcloud/fix/fix-32bits-ci
...
Fix 32bits ci
2023-05-03 10:34:04 +07:00
ef87dfc478
Merge pull request #33106 from nextcloud/feature/update-expire-date
...
Update expire_date column of table comments
2023-05-03 10:26:28 +07:00
e252182d80
Put back file cleanups, and remove dead code in tests/lib/Template/JSResourceLocatorTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 16:24:28 +07:00
adf743b141
Remove the array_pop failing tests on 32bit CI
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 16:09:37 +07:00
10296ba7e5
Fix tests, and fix Group::searchUsers to avoid duplicates
...
Also went back to searchUsers indexing the array by uid as it was the
previous behavior and the IGroup phpdoc does not say anything about the
keys.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 11:35:41 +07:00
e7ab30f5d8
log performance events for http requests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-28 15:37:57 +07:00
b6c17c6ce7
Clear up return types
...
usersInGroup index by int for BC, searchInGroup index by uid (string).
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:00:45 +07:00
35dc223500
Optimize retrieving display name when searching for users in a group
...
This is recurrent scenario that we are searching for users and then for
each users we fetch the displayName. This is inefficient, so instead try
to do one query to fetch everything (e.g. Database backend) or use the
already existing DisplayNameCache helper.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-04-27 11:57:45 +07:00
5ed6722dd2
Cover expire_date with unit tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-04-26 13:21:08 +07:00
75f17b6094
Merge pull request #37905 from nextcloud/techdebt/noid/add-attributes-for-remaining-security-annotations
...
feat(security): Add PHP \Attribute for remaining security annotations
2023-04-25 17:13:53 +07:00
ecb8b55c5c
feat(security): Add PHP \Attribute for remaining security annotations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-25 14:50:32 +07:00
7250f54ca3
Merge pull request #37835 from nextcloud/feat/background-allow-parallel-runs
...
feat(BackgroundJobs): Allow preventing parallel runs for a job class
2023-04-25 12:10:43 +07:00
06d6cf4ebc
JobListTest: Fix JobList constructor call
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-24 19:07:13 +07:00
6148c5e0a1
Update tests/lib/BackgroundJob/DummyJobList.php
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-24 12:35:52 +07:00
89c3c31402
feat(ratelimit): Add Attributes support to rate limit middleware
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-24 12:24:48 +07:00
a0c722ad69
Run cs:Fix
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
5608b50778
Fix BackgroundJob tests
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
281c8047b6
JobListTest: clearJobsList before testHasReservedJobs
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
56cb5d1d13
fix(tests): Remove duplicated method
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
1296f3612e
test(BackgroundJobs): Add tests for allowParallelRuns and hasReservedJobs
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
b294edad80
Merge branch 'master' into enh/type-iconfig-getter-calls
...
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-04-20 16:52:38 +07:00
b62c49f1e0
Merge pull request #37795 from nextcloud/techdebt/noid/improve-ci
...
fix(CI): Disable unstable test until someone can have a look at it
2023-04-18 21:07:38 +07:00
2c0cfd3772
feat(app-framework): Add native argument types for middleware
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-04-18 17:15:05 +07:00
6ac8052896
fix(CI): Disable unstable test until someone can have a look at it
...
Passes locally 100% and on CI 50% of the time
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-18 13:59:35 +07:00
8fe22ebf60
Merge pull request #36617 from nextcloud/update/psr-container
...
chore: Update PSR container to 2.0.2
2023-04-18 11:40:12 +07:00
d9c81f56ad
tests: Adapt node related unit tests mocks to required root view
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-17 23:46:52 +07:00
160bd75d0a
fix: Use proper path when creating node instances
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-17 23:46:52 +07:00
dc9d8c42bb
fix: Adjust console formatter code to match with Symfony type hints
...
Symfony has added type hints on the `OutputFormatterInterface`,
so we must adjust our type hints to match with Symfony.
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-04-17 18:35:10 +07:00
384a1d34a8
adapt test to new workflow
...
getDirectoryListing should return all files
getFile is not called anymore
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
0375c9866c
add test to verify redis lua script hashes
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-17 16:18:48 +07:00
b153340b62
Add type hints for mappers
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-07 09:49:42 +07:00
5b3900e849
fix(tests): acceptance
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-04-06 15:43:30 +07:00
1ac7a3f107
Merge pull request #37595 from jtrees/add-some-tests-to-lost-controller
...
Add some tests for input trimming in LostController.php
2023-04-06 11:12:52 +07:00
8d5165e8dc
Adapt tests to config value typing
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 17:42:14 +07:00
a4032a3800
Add some tests for input trimming in LostController.php
...
Signed-off-by: Joshua Trees <me@jtrees.io>
2023-04-05 12:15:38 +07:00
8f550398c4
Merge pull request #36836 from nextcloud/fix/view-type-cleanup
...
Tidy up typing in OC\Files\View
2023-04-05 10:14:55 +07:00
d9f8522003
Fix types for reading and writing config values
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +07:00
131f481a67
fix(initial-state): Log an error when initial-state can not be JSON encoded
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-04 10:54:12 +07:00
7ab44b2d28
Merge pull request #37146 from nextcloud/artonge/feat/migrate_metadata_to_value
...
Migrate metadata JSON column to new value TEXT column
2023-04-04 10:23:54 +07:00
c5339fa336
Merge pull request #37542 from nextcloud/bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing
...
feat(security): Allow to opt-out of ratelimit protection, e.g. for te…
2023-04-03 14:19:41 +07:00
1a6709cf43
Migrate metadata as JSON to value as STRING
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-03 14:06:28 +07:00
4393b96542
Remove unused method getLocalFolder
...
It’s not used and not in any OCP interface/class.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:34 +07:00
966a3e6963
Tidy up typing in OC\Files\View
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:33 +07:00
454281af03
feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-03 09:06:45 +07:00
997c2a2a79
fix DBAL exception handling in setValues
...
This seems to be a left over after abstracting DBAL. Nowadays,
IQueryBuilder::executeStatement() only throws a \OCP\DB\Exception, where
previously original DBAL exceptions where thrown. These are now wrapped,
the orignal classes are now mapped to a reason.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-31 17:01:17 +07:00
4f8e916585
Add label for logo link
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-03-29 13:36:45 +07:00
346054f854
Fix tests
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-03-28 09:41:04 +07:00
8b4d49cf50
Merge pull request #36057 from nextcloud/feat/esm-js-scripts
2023-03-22 09:17:28 +07:00
633ea018af
Fix BackgroundCleanupJobTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:21:44 +07:00
bfc37afed3
Merge pull request #36928 from nextcloud/techdebt/noid/bruteforce-protection-attribute
...
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
2023-03-16 19:33:13 +07:00
a30d7c51d3
Merge pull request #37227 from nextcloud/h1-dav-brute-force-protection
...
chore: use local variable for remote address
2023-03-15 15:11:53 +07:00
37cfccabc1
unit tests for Manager::invalidateTokensOfUser
...
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2023-03-14 17:13:30 +07:00
71328107da
Merge pull request #37029 from nextcloud/fix/chunk-objectids-in-systemtagobjectmapper
...
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
2023-03-13 22:10:47 +07:00
9b1d7794a8
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
...
This avoids crashing on Oracle with more than 1000 objects
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-13 17:36:10 +07:00
f1751c4428
Introduced app enable/disable/update typed events
...
OCP\App\ManagerEvent is depreciated since 22 without a replacement
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-03-13 11:52:57 +07:00
39c1b6f49f
chore(tests): add tests for handleLoginFailed
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-03-10 18:04:39 +07:00
2b49861679
Add a debug message when throttling without defining
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-08 12:09:22 +07:00
e839eb9b5c
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-08 12:09:22 +07:00
b4f51fe728
fix(CI): Fix acceptance test password field selector after @nextcloud/vue lib update
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-07 09:34:47 +07:00
c297f8ee96
feat(appframework): ⌚ Make ITimeFactory extend \PSR\Clock\ClockInterface
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-03 15:37:13 +07:00
de64c96a67
Merge pull request #36941 from nextcloud/bugfix/prevent-error-with-oracle-database
...
Split the comments ids by chunks
2023-03-03 12:37:15 +07:00
289fadfd50
Merge pull request #36803 from nextcloud/fix/sqlite-comments
...
[db]: Remove not supported column comments for SQLite
2023-03-02 12:10:19 +07:00
e9295f739e
Split the comments ids by chunks
...
Split the comments ids by chunks to prevent error with Oracle database
that can't do a query with more than 1000 parameters.
https://github.com/nextcloud/spreed/issues/8287
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-03-01 13:08:17 +07:00
0b966ab200
Merge pull request #36471 from nextcloud/fix/theming-keep-images
2023-03-01 09:54:49 +07:00
1785a80754
tests(db): Add test case to ensure column comments work
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-28 10:39:13 +07:00
4f7d77406d
Fix SystemTagManagerTest#createTag test
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 14:40:33 +07:00
889caf4632
Update tests/lib/SystemTag/SystemTagManagerTest.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 14:22:41 +07:00
8151b1b8b0
fix(SystemTagManager): Truncate overlong tag names
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 12:55:10 +07:00
b642137c65
feat(OC/Template): Add `type="module"` for ES6 scripts
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +07:00
00e041b907
feat(template): Allow `JSResourceLocator` to find ES6 scripts
...
Enable module js (ES6) support on the `JSResourceLocator`.
This changes `JSResourceLocator` to look for `.mjs` files first
to allow applications to provide a fallback `.js` for older Nextcloud versions.
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +07:00
98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call"
2023-02-21 07:36:43 +07:00
61b9ba28e4
Add webp and large jpg test assets
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-20 13:11:19 +07:00
614981ae9a
feat(directediting): Allow opening by file id
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-20 12:16:34 +07:00
5d4efb4d5f
Do not set up filesystem on every call
...
Also remove old Oc_FileChunking logis that produced GC- collectable chunks
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-02-17 19:18:37 +07:00
47bc024885
Revert the token scope to not end up with storing the user used in the session
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 10:18:18 +07:00
90d2cb09b1
Merge pull request #36396 from nextcloud/fix/cors
2023-02-17 09:42:08 +07:00
f655f83c84
fix(CORS): CORS should only be bypassed on `PublicPage` if not logged in to prevent CSRF attack vectors
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-16 22:55:18 +07:00
98b998a2de
Merge pull request #36735 from nextcloud/fix/32635/fix-vcf-contacts
...
fix the contacts-menu vcf-contact avatars
2023-02-16 14:01:19 +07:00
b38d2daede
fix the contacts-menu vcf-contact avatars
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-15 23:16:43 +07:00
5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow"
...
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240
Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-15 20:16:51 +07:00
a705132c8d
Merge pull request #36656 from nextcloud/route-instrumentation
2023-02-14 10:12:19 +07:00
b911da3e1e
DI for Router
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-13 22:51:14 +07:00
936f634069
Merge pull request #36643 from nextcloud/fs-setup-instrimuntion
...
more filesystem setup performance instrumentation
2023-02-13 14:37:57 +07:00
91d5f6a826
more filesystem setup performance instrumentation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-10 11:11:13 +07:00
c77998209f
Port user menu to Vue
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-02-09 17:54:59 +07:00
a81d8ecef5
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-09 16:15:47 +07:00
08802ad13f
Merge pull request #36566 from nextcloud/mount-find-by-numeric-id
2023-02-08 20:04:57 +07:00
dcfc96f0cc
Merge pull request #36417 from nextcloud/fix/psr-container
...
Make the container fully fulfill PSR container interface
2023-02-07 20:38:19 +07:00
9f3dbb699a
fix tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-07 15:50:10 +07:00
892e6c642a
Skip buggy tests for 32bits CI
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:33 +07:00
77c8c9c805
Improve error output on failed Router test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:31 +07:00
94ecae4ade
Add helper to cast to int|float, fix MemoryInfo on 32bits
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
0f8c34cdc6
Fix filesize return type error in ViewTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
5cfab229db
Improve test failure output for RouterTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
2d8e696c24
Add apcu and ffmpeg to have less skipped tests
...
Also exclude test groups which rely on a service
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:28 +07:00
59578817f5
Merge pull request #36489 from nextcloud/bugfix/noid/brute-force-protection-password-reset
...
Add bruteforce protection to password reset page
2023-02-06 22:12:25 +07:00
ba8a50c059
fix: Throw `NotFoundExceptionInterface` to fulfill PSR container interface if class not found
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-06 14:16:35 +07:00
875e6cf7e6
fix(CI): Adjust expected result
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-06 11:26:38 +07:00
88d116ba84
fix(client-login-flow): Handle missing stateToken gracefully
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-02-06 09:42:15 +07:00
47880b143d
Remove failing test that works with mocks only anyway
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-02 18:06:31 +07:00
dde5c46a3e
Migrate to Symfony Mailer
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-02 10:30:06 +07:00
1a655e88d9
use php8.0 images
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-01-31 15:44:12 +07:00
c246edece6
tests(oci): Test where statement on longtext column
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
test: try with just passing the type to eq which should also cast
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-01-31 11:57:54 +07:00
2f3007205d
Merge pull request #35160 from nextcloud/artonge/feat/version_naming_backend
...
Allow to name a version
2023-01-30 10:40:49 +07:00
959e2aaa17
fix(tests): Fix method name in unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-30 09:12:50 +07:00
20e00cdf17
feat(app-framework): Add UseSession attribute to replace annotation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-27 09:40:35 +07:00
8d9af3e262
feat(app-framework): Add support for global middlewares
...
This allows apps to register middlewares that always register, not just
for the app's own requests
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-26 11:54:28 +07:00
d8b479752d
Fix hookconnector tests
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
907ff68bfc
perf(app-framework): Make the app middleware registration lazy
...
Before this patch, app middlewares were registered on the dispatcher for
every app loaded in a Nextcloud process. With the patch, only
middlewares belonging to the same app of a dispatcher instance are
loaded.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-25 09:27:24 +07:00
0236c9e8cd
Port files sharing selector
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-24 17:40:17 +07:00
003cc2b45a
Fix tests failures (number of calls differed with last rebase)
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-24 09:38:20 +07:00
a23cd7b961
Fix a bunch of deprecation in the phpunit for core
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-01-24 09:34:09 +07:00
1c099c7f17
Fix broken user:setting command unit test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-23 07:01:22 +07:00
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
89dbc629ff
Fix integrity check
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-20 11:22:11 +07:00
de68fc6347
Update test file for mimetypes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:11 +07:00
b22b6431d2
Fix gzip mimetype mapping
...
PHP now detects it as application/gzip and not application/x-gzip anymore
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:11 +07:00
7ebbb6b2ca
Remove workarounds specific to 7.4
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:08 +07:00
1e2441ff6b
Disable unreliable acceptance tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-19 09:21:33 +07:00
20fcfb5739
feat(app framework)!: Inject services into controller methods
...
Usually Nextcloud DI goes through constructor injection. This has the
implication that each instance of a class builds the full DI tree. That
is the injected services, their services, etc. Occasionally there is a
service that is only needed for one controller method. Then the DI tree
is build regardless if used or not.
If services are injected into the method, we only build the DI tree if
that method gets executed.
This is also how Laravel allows injection.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-18 14:00:38 +07:00
f22101d421
Fix login loop if login CSRF fails and user is not logged in
...
If CSRF fails but the user is logged in that they probably logged in in
another tab. This is fine. We can just redirect.
If CSRF fails and the user is also not logged in then something is
fishy. E.g. because Nextcloud contantly regenrates the session and the
CSRF token and the user is stuck in an endless login loop.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-18 09:39:17 +07:00
dbfe7b1816
Merge pull request #36073 from nextcloud/fix/fix-background-job-list
...
Use a Generator for job list to fix background-job:list command
2023-01-16 11:10:10 +07:00
f6aa5224c4
Focus trap contacts menu with NcHeaderMenu port
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-13 23:19:28 +07:00
238e9cf3a8
feat(CI): Enforce colored output for acceptance tests on drone CI
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-13 11:31:13 +07:00
d74044f634
Fix API breakage by using a new method instead
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-12 17:18:59 +07:00
75fca38e66
Fix BackgroundJob list tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-12 11:40:18 +07:00
7271ec7acf
spaces are allowed in userids
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-01-10 13:25:27 +07:00
42d9e087fb
Remove unused legacy ajax/list.php in files app
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-01-09 15:18:37 +07:00
18164ae516
Merge pull request #33898 from nextcloud/fix/authtoken-password-update
...
PublickKeyTokenProvider: Fix password update routine with password hash
2023-01-05 08:01:47 +07:00
97e33c2bd4
Fix unit tests of the ActionProviderStore
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-04 16:17:43 +07:00
8eca26012f
Show local time in avatar menu
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-04 11:09:58 +07:00
adfe367106
PublickKeyTokenProvider: Fix password update routine with password hash
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-01-04 08:30:53 +07:00
4dc0957164
refactor AutoSubmittedValue to Headers\AutoSubmitted and adding
...
header name to constants
Signed-off-by: Bennet Becker <dev@bennet.cc>
2023-01-03 15:15:35 +07:00
411467af57
fix static-analysis error and formatting code
...
Signed-off-by: Bennet Becker <dev@bennet.cc>
2022-12-23 21:48:52 +07:00
c1c6d215c7
fix getAutoSubmitted return type and adding unit tests
...
Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
2022-12-23 19:26:49 +07:00
bfb3b2af9f
increase preview_max_memory and make it easier to debug
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2022-12-22 09:52:46 +07:00
e2285acd04
Update behat and friends
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-12-21 15:27:59 +07:00
7dcd6eb561
Merge branch 'master' into add-scim-json-support
...
Signed-off-by: Stanimir Bozhilov <stanimir.bozhilov.1998@gmail.com>
2022-12-19 09:07:38 +07:00
ae6fe874ed
Merge pull request #35780 from nextcloud/fix/http-dispatcher-double-parameter-cast
...
Fix missing cast of double controller parameters
2022-12-16 16:18:35 +07:00
6737deabbf
Merge pull request #35784 from nextcloud/chore/strict-login-controller
...
Make the LoginController strict
2022-12-16 16:16:31 +07:00
138deec333
chore: Make the LoginController strict
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-15 10:52:28 +07:00
b6dd1a1d7b
fix(app framework): Fix missing cast of double controller parameters
...
``settype`` allows 'double' as alias of 'float'.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-15 09:33:52 +07:00
81f2857f34
check if params given to API are really an array
...
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-15 13:45:22 +07:00
fb2fb0d2d5
Revert "Copy to clipboard with button instead of link"
...
This reverts commit 4ffc022c8b
2022-12-14 00:57:57 +07:00
2f7a1fca5f
Merge pull request #34477 from nextcloud/bugfix/noid/sharee-recommendations-show-group-id
...
Show group name instead of group id as recommendation
2022-12-09 22:39:28 +07:00
4bcaeb6c2c
Drop 3rdparty root since it is unused and adjust tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 23:55:32 +07:00
306d7829b5
Cache available languages locally
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 22:32:06 +07:00
Robin Appelman
jld3103
Christopher Ng
John Molakvoæ
Joas Schilling
Marcel Klehr
Ferdinand Thiessen
julia.kirschenheuter
Daniel
Côme Chilliet
Simon L
Faraz Samapoor
Arthur Schiwon
Joas Schilling
Christoph Wurst
John Molakvoæ
Varun Patil
Côme Chilliet
Carl Schwan
Vitor Mattos
Julius Härtl
Ferdinand Thiessen
Glandos
Joshua Trees
Louis
Louis Chemineau
Git'Fellow
Artur Neumann
Thomas Citharel
Anna Larch
MichaIng
Maxence Lange
Vincent Petry
Bennet Becker
Bennet Becker
Stanimir Bozhilov