Commit Graph

6893 Commits (d949fce1d524ee7c050fbb7cdca800b0723350ec)

Author SHA1 Message Date
Joas Schilling ccb01b19a0
fix(sqlite): Remove some old SQLite cheats
- Doctrine correctly forces integer for autoincrement by now
- Doctrine correctly maintains integer types by now

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:27 +07:00
Joas Schilling 160298c556
fix(mysql): Remove custom MySQL workaround from 2015
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:25 +07:00
Joas Schilling b202b139dd
fix(postgres): Remove old Postgres 9.4 workaround
Postgres 10 is the minimum in the meantime
and doctrine/dbal fixed this in 2.6.0 already
ref https://github.com/doctrine/dbal/pull/2614

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:25 +07:00
Joas Schilling ad839dbb0a
fix(sqlite): Remove no longer required autoincrement fix
- I installed current master and exported the schema as SQL
- Then I went to this branch, removed the content of the run() method (so made it no-op)
- I installed again and exported the schema as SQL
- The files are exactly the same, so whatever we tried to fix was fixed since 2015 in doctrine dbal

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:25 +07:00
Julien Veyssier 807f173dec
make oauth2 authorization code expire after 10 minutes
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-10-05 14:24:02 +07:00
Christoph Wurst 0e64ec6550
chore: Install phpunit via vendor bin
This means we can all run the same version. And when switching to
stableX it can pull the corresponding version too. Also local dev envs
and CI run the same phpunit.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-10-02 11:33:14 +07:00
Christoph Wurst 04ecc2a6a9
feat(backgroundjob): Schedule job after <timestamp>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-09-29 10:29:40 +07:00
julia.kirschenheuter 5693092053 Split list to navigation for the left sidebar
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-09-28 18:18:40 +07:00
Côme Chilliet c9ed1e981b
Merge pull request #40617 from nextcloud/enh/allow-user-to-set-apporder
Read apporder from configuration value
2023-09-28 10:55:52 +07:00
Faraz Samapoor c322224650 Refactors tests/app.php to improve readaibility.
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-09-27 09:10:47 +07:00
Côme Chilliet b11eb9e6d6
Fix and extend NavigationManagerTest.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-26 16:21:22 +07:00
Côme Chilliet 2d28e8110f
Fix and extend tests for AppManager::getDefaultAppForUser
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-26 14:59:05 +07:00
Joas Schilling 0956b493b6
fix(phonenumber): Use the newly introduced API to limit 3rdparty lib usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-09-25 15:54:21 +07:00
Daniel Kesselberg 97a024f035 chore(3rdparty): remove opis/closure
- We are using laravel/serializable-closure for a while now.
- The package was there for compatibility reasons but does not play nice with PHP 8.1.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-22 17:16:20 +07:00
Joas Schilling 5e7b41086d
feat(CI): Allow apps to test with PHPUnit10
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-09-21 21:32:15 +07:00
Robin Appelman b11ca34bbd
Merge pull request #40499 from nextcloud/known-mtime-wrapper
add wrapper for external storage to ensure we don't get an mtime that is lower than we know it is
2023-09-21 18:33:15 +07:00
Daniel Kesselberg 18af7cc86b test: add test for cache mount provider
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-20 15:42:23 +07:00
Robin Appelman ccf8843d9f apply known mtime wrapper for external storages
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-19 13:58:35 +07:00
Robin Appelman 5bf34979fe add wrapper to ensure we don't get an mtime that is lower than we know it is
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-19 13:58:15 +07:00
John Molakvoæ (skjnldsv) ef1abd958c
fix(systemtags): fix capabilities and sidebar + tag visibility
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2023-09-18 16:44:28 +07:00
Côme Chilliet 0c421975bd Remove last calls to deprecated at matcher in tests/Core
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-18 10:21:21 +07:00
Côme Chilliet b36fb96984
Merge pull request #40419 from nextcloud/fix/remove-at-matcher-in-installer-test
Remove deprecated at matcher in tests/lib/InstallerTest.php
2023-09-18 09:45:58 +07:00
Lucas Azevedo 03ece129bf
refactor(f2v): Migrate unread comments action to the new FileAction API
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
2023-09-16 14:08:47 +07:00
Côme Chilliet e24007b530
Remove deprecated at matcher in tests/lib/InstallerTest.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-14 12:52:05 +07:00
Julius Härtl 7f958e81d3
fix: Pass parent to NonExistingFile instances
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-09-13 10:28:28 +07:00
Daniel Kesselberg f8f985602b
test: add tests for dns pin middleware
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-12 14:04:23 +07:00
Côme Chilliet 4f1e5bc8fd
Merge pull request #32912 from nextcloud/group-backend-batch-method
Add batch methods in user backends
2023-09-11 11:11:00 +07:00
Julius Härtl 938a558078
Merge pull request #39226 from shdehnavi/null_coalescing_conversion_tests 2023-09-09 09:51:17 +07:00
Côme Chilliet 8549ea4025
Merge pull request #40216 from nextcloud/print-log-message-when-version-could-not-be-got-from-updater-server
Print log message when version could not be got from updater server
2023-09-07 09:33:06 +07:00
Daniel Calviño Sánchez 9a179c391e Print log message when version could not be got from updater server
This could help to diagnose why the updater server could not be reached,
as well as other subtler issues like requests taking too long if the
updater server was tried to be connected to as a "side effect" (for
example, when the "updatenotification" app boots).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-09-06 05:43:21 +07:00
julia.kirschenheuter 8b6029564e Create right table view
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-09-05 16:46:46 +07:00
Carl Schwan 3270b7f12e
Add batch methods in user backends
This allows for faster group search with significantly less DB traffic

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-09-05 16:56:47 +07:00
Côme Chilliet 637cafcf35
Fix ContactsManagerTest adressbook mocks having a null key
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-05 09:20:26 +07:00
Robin Appelman 64f62f7cfd
Merge pull request #39863 from nextcloud/sharing-mask-wrapper
move share permission logic to storage wrapper
2023-09-04 14:05:14 +07:00
Simon L 489a57e9a3
Merge pull request #39707 from nextcloud/bugfix/39706/local-ext-storage-unavailable-mode 2023-09-04 12:05:36 +07:00
John Molakvoæ (skjnldsv) f828dce597
Fix sharing creation insert and get
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2023-09-02 10:25:24 +07:00
Robin Appelman e704470c79
update tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-31 22:37:10 +07:00
Benjamin Gaussorgues 303dadfaa9
sharebymail: remove ILogger and upgrade to PHP 8 syntax
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-08-30 18:36:29 +07:00
Daniel Kesselberg eab46bdfe6
feat: add switch to disable dns pinning
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-29 18:03:54 +07:00
Vincent Petry 8d1a3daa3f Allow ext storage Local to go unavailable
Whenever an external storage of type Local points at a non-existing
directory, process this as a StorageNotAvailable instead of returning
404.

This makes desktop clients ignore the folder instead of deleting it when
it becomes unavailable.

The code change was limited to external storages to avoid issues during
setup and with the default home storage.
Signed-off-by: Vincent Petry <pvince81@yahoo.fr>
2023-08-29 11:04:31 +07:00
Joas Schilling 6f520f2304
Merge pull request #40026 from lhsazevedo/auth-token-commands
feat: Add auth token list and delete commands
2023-08-29 08:57:07 +07:00
Lucas Azevedo 79bc6ba06c Merge branch 'master' into auth-token-commands 2023-08-28 12:25:01 +07:00
Joas Schilling 25309bcb45
techdebt(DI): Use public IThrottler interface which exists since Nextcloud 25
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-28 15:50:45 +07:00
Git'Fellow 066f6ef16c Stop sending deprecated Pragma header
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-08-28 15:11:22 +07:00
Côme Chilliet fd0de0a2d1 Fix tests, add test for the new feature
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-28 09:40:12 +07:00
Ferdinand Thiessen bd37607fc0 chore: Remove unused FilePickerContext from behat tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-26 20:56:09 +07:00
Lucas Azevedo 771a7b92cc Add tests for occ user:auth-tokens:delete
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
2023-08-25 02:27:41 +07:00
Joas Schilling 124588d4a6
fix: Make bypass function public API
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:40:24 +07:00
Joas Schilling fd9b2d488e
feat: Expose if the own IP is allowed to bypass bruteforce protection
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:36:04 +07:00
Joas Schilling a95800c647
feat(security): Add a bruteforce protection backend base on memcache
Similar to the ratelimit backend

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:36:03 +07:00
Jérôme Herbinet 2ace681a2a
Download and enable all
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Download and enable all

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

npm run build

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
2023-08-18 22:51:12 +07:00
Robin Appelman b6c3507aa0 only determine quota_include_external_storage once for quota wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-18 14:25:28 +07:00
John Molakvoæ 74c2f61cbd
chore: remove outdated acceptance tests
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-17 19:55:36 +07:00
John Molakvoæ 266fb31180
fix(tests): preview phpunit
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-17 18:58:21 +07:00
John Molakvoæ 998b3a2581
feat(f2v): migrate Files
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-17 18:56:37 +07:00
Hamid Dehnavi 271e63e41c Convert isset ternary to null coalescing operator
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-08-17 01:36:50 +07:00
Robin Appelman e73889a240 cleanup di for share permissions wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-16 15:25:05 +07:00
Ferdinand Thiessen 5b37d6d9ff tests: Add test for CacheEntry getters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-16 14:00:21 +07:00
Côme Chilliet f57c12b14e
Fix various deprecation warnings in tests on PHP 8.3
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-14 18:13:12 +07:00
Côme Chilliet ee756579a7
Fix setting static property in tests on PHP 8.3
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-14 16:27:56 +07:00
Joas Schilling 9fb08f506f
Merge pull request #38082 from nextcloud/allow-wasm-unsafe-eval-in-csp
Allow "wasm-unsafe-eval" in CSP
2023-08-11 14:04:49 +07:00
Daniel Calviño Sánchez 41f2d912d2 Allow "wasm-unsafe-eval" in CSP
If a page has a Content Security Policy header and the `script-src` (or
`default-src`) directive does not contain neither `wasm-unsafe-eval` nor
`unsafe-eval` loading and executing WebAssembly is blocked in the page
(although it is still possible to load and execute WebAssembly in a
worker thread).

Although the Nextcloud classes to manage the CSP already supported
allowing `unsafe-eval` this affects not only WebAssembly, but also the
`eval` operation in JavaScript.

To make possible to allow WebAssembly execution without allowing
JavaScript `eval` this commit adds support for allowing
`wasm-unsafe-eval`.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-08-10 02:38:41 +07:00
Daniel Kesselberg d56e2aad74 test: remove broken steps from files acceptance test
The acceptance tests using the recent view fail since the vue migration.

`And I open the details view for "welcome.txt"`

Is looking for a row in the filelist with a span having the class nametext, matching the file name "welcome.txt" and button inside having the class action-menu.

The markup for the files list looks very different after the vue migration and therefor the test is failing.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-09 20:58:29 +07:00
Julien Veyssier f099aa2714
Merge branch 'master' into fix/llm-migration-not-executed 2023-08-07 13:26:39 +07:00
Marcel Klehr f62711d2ae Fix TextProcessing test for 32bit
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-08-07 12:03:11 +07:00
Joas Schilling 3bd8f8c1db
Merge pull request #39705 from nextcloud/fix/noid/adjust-integrity-test-for-updated-mime-mappings
fix: adjust test for font icon
2023-08-04 10:42:08 +07:00
Joas Schilling 44b4c16a09
Merge pull request #39605 from nextcloud/bugfix/noid/final-events-cleanup
fix!: Final round of moving to IEventDispatcher
2023-08-04 10:39:57 +07:00
Daniel Kesselberg e0c8d58dd1
fix: adjust test for font icon
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-04 00:01:25 +07:00
Daniel Kesselberg 0098af3b98
fix: missing argument for TextProcessing Manager
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-03 00:33:00 +07:00
Ferdinand Thiessen e457572f6b fix: Acceptance tests adjusted to find new style sidebar tabs
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-02 15:21:34 +07:00
John Molakvoæ 38480fda3c
feat(files_external): migrate to vue
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-01 16:38:06 +07:00
Joas Schilling b9e2f494a1
chore!: Remove legacy SymfonyAdapter
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:22 +07:00
Joas Schilling cebf93d4d2
fix: Remove legacy dispatcher from share manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
Joas Schilling 8ad94cbfda
feat!: Migrate unShare events to typed events
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
Joas Schilling 44b810bfbd
feat!: Migrate Sharing events to typed events
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:19 +07:00
Joas Schilling 68fc9b48c2
feat!: Migrate AccountManager event to typed event
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:19 +07:00
Marcel Klehr 7e790a3297 JobTest: Remove outdated tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-28 11:12:32 +07:00
Marcel Klehr 3d8fd2d99e cs:fix
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-28 11:12:32 +07:00
Marcel Klehr 449a731375 Add test for ParallelAwareJob
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-28 11:12:32 +07:00
Joas Schilling 030e8d8916
fix: Align doc type with creation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 23:13:38 +07:00
Joas Schilling 80f79e170d
fix!: Remove symfony EventDispatcherInterface from Group
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 23:13:37 +07:00
Joas Schilling ad12a740cb
fix!: Remove symfony EventDispatcherInterface from User
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 23:13:37 +07:00
Joas Schilling 6b7221756c
Merge pull request #39571 from nextcloud/bugfix/noid/move-lib-to-IEventDispatcher
Move lib/ events to IEventDispatcher where possible
2023-07-27 18:59:42 +07:00
Daniel Kesselberg 68eecca4d4 chore: update expected results for CLDR 42
Punic 3.8.0 / CLDR 42 added a narrow no-break space unicode character for the time formats and a new default pattern for datetime.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-27 13:57:02 +07:00
Daniel Kesselberg 06248cda0a chore: update expected timezone from GMT+0 to UTC
Punic 3.2.0 added support for timezone translations and returns UTC instead of GMT+0 now.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-27 13:57:02 +07:00
Joas Schilling c67c067ee7
fix: Move Sharing events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:53 +07:00
Joas Schilling 44a0a62107
fix: Move Node HookConnecter events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:53 +07:00
Joas Schilling 6953e14580
fix: Move SystemTags events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +07:00
Joas Schilling dac31ad101
fix!: Remove legacy event dispatching Symfony's GenericEvent from 2FA Manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +07:00
Joas Schilling 1b387bb341
fix!: Remove legacy event dispatching Symfony's GenericEvent from AdditionalScripts
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +07:00
Joas Schilling 5bb6a7804f
fix: Move AppManager events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:51 +07:00
Joas Schilling 4f7de8ed60
fix!: Remove legacy event dispatching Symfony's GenericEvent
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:51 +07:00
Joas Schilling 7548e62181
Merge pull request #39506 from nextcloud/techdebt/39488/ensure-index-name-uniqueness
feat(db): Ensure that index names are unique across the database
2023-07-24 14:44:37 +07:00
Joas Schilling b80692d323
fix(tests): Adjust unit tests to outline the schema is checked twice now
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-21 12:17:36 +07:00
Marcel Klehr 7c80d66ee5
Merge pull request #38854 from nextcloud/enh/llm-api 2023-07-21 11:20:31 +07:00
Benjamin Gaussorgues e9b8a34cce
Merge pull request #39264 from nextcloud/feat/add-instance-category
Add instance category while checking new updates
2023-07-21 11:04:32 +07:00
Benjamin Gaussorgues 31f1354777
Add instance category while checking new updates
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-07-18 15:39:23 +07:00
Ferdinand Thiessen 3b057600d0 fix: Correctly add `module` content type to script tags when scripts with versions are used
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-07-18 13:10:37 +07:00
Marcel Klehr ffe27ce14c Massive refactoring: Turn LanguageModel OCP API into TextProcessing API
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-14 16:00:31 +07:00
Joas Schilling d5ee076017
Merge pull request #39329 from nextcloud/feat/phpunit-for-css-generated-file
fix: also run phpunit on `apps/theming/css` modified files
2023-07-13 17:58:26 +07:00