adfe367106
PublickKeyTokenProvider: Fix password update routine with password hash
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-01-04 08:30:53 +07:00
4dc0957164
refactor AutoSubmittedValue to Headers\AutoSubmitted and adding
...
header name to constants
Signed-off-by: Bennet Becker <dev@bennet.cc>
2023-01-03 15:15:35 +07:00
411467af57
fix static-analysis error and formatting code
...
Signed-off-by: Bennet Becker <dev@bennet.cc>
2022-12-23 21:48:52 +07:00
c1c6d215c7
fix getAutoSubmitted return type and adding unit tests
...
Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
2022-12-23 19:26:49 +07:00
bfb3b2af9f
increase preview_max_memory and make it easier to debug
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2022-12-22 09:52:46 +07:00
e2285acd04
Update behat and friends
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-12-21 15:27:59 +07:00
7dcd6eb561
Merge branch 'master' into add-scim-json-support
...
Signed-off-by: Stanimir Bozhilov <stanimir.bozhilov.1998@gmail.com>
2022-12-19 09:07:38 +07:00
ae6fe874ed
Merge pull request #35780 from nextcloud/fix/http-dispatcher-double-parameter-cast
...
Fix missing cast of double controller parameters
2022-12-16 16:18:35 +07:00
6737deabbf
Merge pull request #35784 from nextcloud/chore/strict-login-controller
...
Make the LoginController strict
2022-12-16 16:16:31 +07:00
138deec333
chore: Make the LoginController strict
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-15 10:52:28 +07:00
b6dd1a1d7b
fix(app framework): Fix missing cast of double controller parameters
...
``settype`` allows 'double' as alias of 'float'.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-15 09:33:52 +07:00
81f2857f34
check if params given to API are really an array
...
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-15 13:45:22 +07:00
fb2fb0d2d5
Revert "Copy to clipboard with button instead of link"
...
This reverts commit 4ffc022c8b
2022-12-14 00:57:57 +07:00
2f7a1fca5f
Merge pull request #34477 from nextcloud/bugfix/noid/sharee-recommendations-show-group-id
...
Show group name instead of group id as recommendation
2022-12-09 22:39:28 +07:00
4bcaeb6c2c
Drop 3rdparty root since it is unused and adjust tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 23:55:32 +07:00
306d7829b5
Cache available languages locally
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 22:32:06 +07:00
87e638b1f8
Merge pull request #35649 from nextcloud/bugfix/object-storage-master-key-enc
...
Update the unencrypted file size when closing streams
2022-12-07 22:03:13 +07:00
3c8fb59fa4
Merge pull request #35620 from nextcloud/fix/fix-calendar-imip-tests
2022-12-07 20:39:41 +07:00
59ae6e9dd6
Also update the unencrypted size of files when creating them with empty content
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 19:12:06 +07:00
4a3f3beb0b
use bruteforce protection on all methods wrapped by PublicShareMiddleware
...
if an invalid token is provided or when share password is wrong
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2022-12-07 13:24:50 +07:00
7cf1dec842
Fix errors in calendar tests saying function handleIMipMessage does not exists on ICreateFromString
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-06 13:52:13 +07:00
1821712615
Merge pull request #35596 from nextcloud/fix/move-to-ocp-timedjob
...
Use TimedJob from OCP instead of OC
2022-12-06 12:14:43 +07:00
ee06261b82
Fix codestyle in modified files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-05 16:08:40 +07:00
30560d3165
Merge branch 'master' into tests/fix-phpunit-warnings
...
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2022-12-05 12:03:39 +07:00
578648a062
Adapt tests to new job constructors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-05 10:41:13 +07:00
a4d0700bf2
Fix test image default quality
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2022-12-04 14:51:33 +07:00
a869259e41
More theming cypress tests and some fixes
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-29 11:26:27 +07:00
7c4ceb444c
Add group display name cache
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-11-28 11:52:55 +07:00
4ffc022c8b
Copy to clipboard with button instead of link
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-24 23:50:54 +07:00
20da3d081e
Add label to sharing search field
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-23 02:04:18 +07:00
e35bcc9381
Fix tests
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 10:06:19 +07:00
d1f2e5e967
Increase the fair-use push limit to 1.000 users
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-18 15:39:23 +07:00
d27a39271e
getAppValue expects string
...
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2022-11-17 08:03:05 +07:00
0f3150cff7
Tests adjustement
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2022-11-16 11:01:32 +07:00
68363f6944
Fix some more problems with tests under PHP 8.2
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 16:02:24 +07:00
324126888e
Add Union types for properties in tests/lib/Encryption/Keys/StorageTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 09:29:35 +07:00
0f7e56b3b3
Fix syntax in VerificationTokenTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 09:25:56 +07:00
c79a6b3f62
Fix errors from PHP 8.2 testing
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 17:08:21 +07:00
70e2217d1c
Fix dynamic properties and other problems in tests for PHP 8.2
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 16:14:35 +07:00
4bf1f4e484
Merge pull request #35093 from nextcloud/nickvergessen-patch-1
...
Run integration tests on 3rdparty bump
2022-11-14 09:45:55 +07:00
9dd0d0ba57
Run integration tests on 3rdparty bump
...
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2022-11-11 07:54:26 +07:00
9d0e79f10d
Fix PublicKeyTokenProviderTest import and mock
...
* IDBConnection import missing
* Atomic doesn't need a mock
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-10 15:40:35 +07:00
908b7aa70a
Attempt to fix CalendarImpl tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-09 16:37:34 +07:00
2a684f6741
Fix some phpunit test warnings
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-09 16:37:34 +07:00
f9e9cd270d
Limit-number-of-concurrent-preview-generations
...
Signed-off-by: Bowen Ding <dbw9580@live.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-11-05 16:03:01 +07:00
5c4a66f0c1
Merge pull request #34775 from nextcloud/bugfix/noid/mailer-set-to
...
Do not throw errors when invalid setTo email is provided
2022-11-04 18:24:55 +07:00
fd036f774f
Do not throw errors when invalid setTo email is provided
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-03 16:59:12 +07:00
2e83a21cd2
Merge pull request #34678 from pulsejet/patch-jpeg
...
Interlace all output JPEG
2022-11-03 16:11:03 +07:00
8a2e52e7f8
Merge pull request #34330 from nextcloud/fix/fix-contacts-test-php8
...
Fix ContactsStoreTests under PHP 8.2
2022-11-03 14:55:06 +07:00
ac92d00da8
Merge pull request #32565 from nextcloud/chore/modernize-error-handler
...
Modernize the error handler
2022-11-03 14:42:51 +07:00
052dcdebe8
Refactor the ErrorHandler into a dynamic class
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-02 09:49:37 +07:00
8aea25b5b9
Add remote host validation API
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-10-31 16:13:28 +07:00
4a2bbc7af9
Rewrite admin theming in Vue
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-28 00:18:47 +07:00
d007088cf5
Merge pull request #34847 from nextcloud/refactor/local-address-checker-method-capitalization
...
Rename LocalAddressChecker methods to lower case
2022-10-27 15:57:58 +07:00
07e94eca6f
Emit typed event when preview is requested
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-27 14:31:33 +07:00
d4b9b010b0
Rename LocalAddressChecker methods to lower case
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-10-27 13:24:28 +07:00
0d9c1510ca
Fix ContactsStoreTests under PHP 8.2
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-26 20:03:49 +07:00
3357c8e783
test disabling write check
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-10-26 18:45:59 +07:00
aec8dce61a
Merge pull request #34788 from nextcloud/bugfix/noid/preview-attributes
2022-10-26 15:11:01 +07:00
298d2b9b58
Skip general login with email for non-valid addresses and LDAP
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-26 12:30:25 +07:00
48917e718e
Interlace all output JPEG
...
Progressive images are both smaller and faster to load.
Signed-off-by: Varun Patil <radialapps@gmail.com>
2022-10-25 09:40:20 +07:00
8629d8e44f
Check share attributes on preview endpoints
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-25 11:35:31 +07:00
11108e8032
Revert "fix external storages access"
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-10-23 22:36:34 +07:00
304c1b9b61
Merge pull request #33087 from nextcloud/fix/30282/external-storages
...
fix external storages access
2022-10-23 10:42:46 +07:00
2d98cd1daf
Add config and fix selenium
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-19 10:04:51 +07:00
1cb0c2ac52
Fix LostController test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-18 14:49:02 +07:00
c671466422
Merge pull request #34379 from nextcloud/fix/transactional-session-token-renewal
...
Run session token renewals in a database transaction
2022-10-18 11:19:33 +07:00
d29332469a
Merge pull request #34609 from nextcloud/enh/noid/always-enable-theming
...
set theming app to alwaysEnabled
2022-10-18 10:13:56 +07:00
c5922e67d3
Run session token renewals in a database transaction
...
The session token renewal does
1) Read the old token
2) Write a new token
3) Delete the old token
If two processes succeed to read the old token there can be two new tokens because
the queries were not run in a transaction. This is particularly problematic on
clustered DBs where 1) would go to a read node and 2) and 3) go to a write node.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-10-18 08:28:22 +07:00
1d17a0843a
set theming app to alwaysEnabled
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-10-17 17:51:39 +07:00
9919116716
Merge pull request #31499 from nextcloud/bugfix/empty-secret
...
Add fallback routines for empty secret cases
2022-10-17 16:02:58 +07:00
d77e832223
Fix tests
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-14 16:18:40 +07:00
b28757fddc
Merge pull request #34437 from nextcloud/feat/theming-default-system-value
...
Use default system primary
2022-10-13 19:57:28 +07:00
db831359d3
Allow to pick custom colour
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-10-13 12:13:39 +07:00
799f660df0
Make CI green again
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-13 11:13:13 +07:00
e674087ebf
Adjust unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-12 16:03:57 +07:00
60ee874485
Remove long depreated AppFramework/Db/Mapper
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2022-10-10 08:18:32 +07:00
7d024bc337
Merge pull request #32635 from andyxheli/patch-3
...
Fix User profile picture when performing the search
2022-10-05 10:36:43 +07:00
7044191eb6
Use brand color for background only and keep accessible color as color primary
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-05 06:19:08 +07:00
ae6a7c88a0
Update ContactsStoreTest.php
...
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
2022-10-03 09:17:27 +07:00
ca958de7e9
Merge pull request #33566 from nextcloud/fopen-not-found-rescan
...
trigger a rescan when trying to fopen a file that exists in cache but not on disk
2022-10-01 21:47:26 +07:00
a4c2aeef45
Merge pull request #34329 from nextcloud/fix/cleanup-long-time-deprecated-stuff
...
Remove some constants and functions which have been long deprecated
2022-10-01 17:55:31 +07:00
910c774b35
Merge pull request #34038 from nextcloud/fix/migrate-TagMapper-to-QBMapper
...
Migrate TagMapper to QBMapper instead of deprecated Mapper
2022-09-30 16:46:42 +07:00
4123eeeaa3
Fix ContactsManagerTest test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-30 13:20:04 +07:00
5347fb02dc
Remove some constants and functions which have been long deprecated
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-30 13:20:03 +07:00
92a5a8f075
Cleanup tags and Share component
...
- Port to LoggerInterface
- Use IDBConnection and IQueryBuilder instead of raw SQL and OC_DB
- Use IEventListener instead of hooks
- Remove the now unused OC_DB and OC_DB_StatementWrapper legacy utils
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-29 15:15:28 +07:00
1de0b10751
add test for trying to fopen a file which no longer exists on disk
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-29 10:27:32 +07:00
295d03869e
Fix various theming bugs
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-28 17:12:56 +07:00
de23ff38ff
Move avatar clearing in the background
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-26 15:26:31 +07:00
46c10c77e1
Fix the JSON content type regex to match all MIME types
...
Signed-off-by: Stanimir Bozhilov <stanimir@audriga.com>
2022-09-26 11:51:44 +07:00
a133a8a9d7
remove getDefaultInstallationBundle
...
- because all apps are shipped now it was returning an empty result
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-22 15:11:39 +07:00
a7af25e1d9
remove InstallCoreBundle repair step
...
- core bundle was empty and thus removed
- all former apps installed this way are shipped
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-22 13:24:06 +07:00
759eaee5ed
remove Core Bundle
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-22 13:20:37 +07:00
f7d51a39cf
Add unit tests for application/scim+json content type
...
Signed-off-by: Stanimir Bozhilov <stanimir@audriga.com>
2022-09-20 16:19:05 +07:00
31117fa7c7
Fix tests for nested v4 in v6
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-20 12:46:22 +07:00
c083f77e4e
Harden tests for local IP detection in URLs
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-20 12:14:33 +07:00
4efd0be525
Inform ServerTest that TagMapper now uses QBMapper
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-19 10:01:49 +07:00
d39f047af2
Merge pull request #34072 from nextcloud/enh/noid/default-enabled-2
...
set defaultEnabled in shipped.json
2022-09-15 22:03:12 +07:00
d8961ed10f
fix using FSEEK_END with SeekableHttpStream to get file size
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-15 17:23:16 +07:00
1998ac7b06
Increase timeout for apps management
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-09-15 17:11:14 +07:00
da01494a37
Add accessibility entry in user menu
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-09-14 15:05:35 +07:00
bc9a488046
Update avatars on update
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-09 14:23:41 +07:00
eac54c4660
Merge pull request #33788 from nextcloud/improve-recent
...
Improve getting recent files performance
2022-09-08 16:19:41 +07:00
c77cc80fcc
Merge pull request #33906 from nextcloud/fix/fix-calendar-tests-getTimestamp
...
Fix Calendar tests mocking a non-existant method.
2022-09-08 12:42:03 +07:00
e3a52ce13e
Fix iMIP tests
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-09-08 02:26:46 +07:00
417f46e467
Merge pull request #33600 from nextcloud/lazy-quota
...
get quota for user only when needed
2022-09-07 18:10:33 +07:00
43d1aa38df
More cleaning up of the login component
...
- Move css in scopped vue components
- Port to NcNoteCard all the warning messages
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-06 15:20:29 +07:00
98c525a91a
Fix trying to use MockBuilder instead of Mock
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-06 09:05:36 +07:00
0b37d89893
Fix Calendar tests mocking a non-existant method.
...
There is no ITimeFactory::getTimestamp method, only getTime
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-05 18:09:49 +07:00
67551f379f
Filter out old files when trying to get recent files
...
Only do so when asking for less than 100 files and having an offset
equal to 0.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-05 12:53:32 +07:00
6132b6a4ae
Merge pull request #33790 from nextcloud/Valdnet-patch-2
...
l10n: Spelling unification
2022-09-02 17:01:52 +07:00
b31c92e6f5
fix tests
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-09-02 16:07:13 +07:00
bd91c56539
get quota for user only when needed
...
always apply the wrapper but have the wrapper get the quota lazily only when an operation where quota is applied is performed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-01 19:32:24 +07:00
92925233ec
Maximize browser window before running the tests
...
By the default the browser window is not maximized, but opened with a
size of 1050x978px. In the Files app, when the navigation bar and the
side bar are both open, with the previous design that width caused the
file name to be very very narrow, but still clickable. However, with the
updated design the file name is too narrow and no longer clickable,
which breaks several acceptance tests that descend into subfolders. To
solve that now the browser window is maximized before running the tests,
which makes the window wide enough (1360px) to show the file name and
make it clickable.
This commit also removes a step to close the sidebar that was recently
added to address the problem mentioned above in a previous pull request.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-09-01 14:15:43 +07:00
76b0947022
Wait for the new user form to be visible
...
Before it was checked if the new user form was visible, but it was not
waited for it. It seems that it can happen that the new user form is in
the DOM, and therefore found, but not visible yet when the tests run,
which caused them to (randomly) fail. Due to that now it is explicitly
waited until it is visible, rather than assuming that it is visible as
soon as it appears in the DOM.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-09-01 14:15:43 +07:00
6dac33ee56
Adjust theming acceptance tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-09-01 14:15:43 +07:00
3ae439710e
Merge pull request #33764 from nextcloud/cloudid-cache
...
cache cloud id data in CloudIdManager
2022-09-01 13:27:12 +07:00
67ecd72972
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-31 20:54:39 +07:00
b0f6ca0e0d
Merge pull request #33756 from nextcloud/enh/noid/admin-settings-directly
...
add a way to open the admin settings overview directly
2022-08-31 17:56:11 +07:00
1626a56dda
adjusts tests for CloudIdManager
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-31 15:47:00 +07:00
0c90474296
add a better icon for personal settings
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-08-31 15:37:48 +07:00
17ee17cdbf
fix tests
...
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-08-31 14:35:13 +07:00
ac2d885899
Adjust acceptance tests to changes in app menu
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-08-31 12:57:16 +07:00
f56ecf9242
Merge pull request #33640 from nextcloud/fix/fix-symfony-event-typing
...
Port Repair and Migrator events to IEventDispatcher
2022-08-30 14:47:05 +07:00
6f80fe6ada
Remove deprecated at matcher from tests/lib
...
Only 15 warnings left in there
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-29 16:36:40 +07:00
791e021455
Remove deprecated at matcher in Updater/VersionCheckTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-29 15:11:18 +07:00
e5731b3c30
Fix BackgroundRepairTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:15:48 +07:00
5d313da709
Fix RepairTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:15:48 +07:00
a83a8f0dde
Migrate Migrator::executeSql to OCP\EventDispatcher\Event
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:13:47 +07:00
2911dffd5e
Merge pull request #33516 from nextcloud/update-nextcloud-vue-6.0.0-beta.2
...
Bump @nextcloud/vue to 6.0.0-beta.4 and related
2022-08-25 13:29:36 +07:00
9b5569ff74
Merge pull request #33668 from nextcloud/tests/fix-session-middleware
...
Fix SessionMiddlewareTest and cover new case with reopening
2022-08-25 11:00:35 +07:00
ede9ac2a75
Adjust acceptance test selectors
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-25 09:54:44 +07:00
83b1415906
Only pass parent if paths match
...
As the user folder might be initialized by the root from two levels
down the hierarchy, passing this as a parent only works if the path matches
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-24 22:20:32 +07:00
b2d6435737
Avoid extra query for the parent node if we can pass it along
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-24 22:20:32 +07:00
bd7ab89d2a
Merge pull request #33593 from nextcloud/improve-binary-caching
...
Move findBinaryFinder and isFunctionEnabled away from OC_Helper
2022-08-24 13:09:55 +07:00
64a7489958
Fix SessionMiddlewareTest and cover new case with reopening
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-24 10:36:57 +07:00
9b8ca9ad1f
Move findBinaryFinder and isFunctionEnabled away from OC_Helper
...
findBinaryFinder is now a service that is still private but with some
minor optimization (remove the hasKey check).
isFunctionEnabled is now in OCP\Util
Both function are still keep but all internal usage in nextcloud/server
were migrated to the new usage, so that we can remove it in 26
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-23 19:44:04 +07:00
b888c61463
Merge pull request #33047 from nextcloud/fix/ijob-logger-deprecated
...
Deprecated ILogger from IJob
2022-08-23 16:55:42 +07:00
4ca4b02793
Support iMIP invitations from Mail
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-08-22 22:10:12 +07:00
a2d145734a
Merge pull request #33565 from nextcloud/debt/remove_todo_push_service_fairuse
...
Remove time check in isFairUseOfFreePushService
2022-08-17 14:14:03 +07:00
312b719acf
Merge pull request #32943 from nextcloud/unencrypted-size-revert-interface-changes
...
Revert interface changes from "store unencrypted size in the unencrypted_size column"
2022-08-17 11:36:16 +07:00
227c766f16
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-17 11:25:18 +07:00
2360d880fa
Merge pull request #33540 from nextcloud/mount-provider-migration
...
fix updating cached mounts that didn't have their mount provider set previously
2022-08-17 10:41:31 +07:00
082432e01c
Merge pull request #33551 from nextcloud/scanner-dont-update-same-size
...
don't update the folder size if we know it hasn't changed
2022-08-17 09:21:30 +07:00
1850d0ae96
cleanup scannertest a bit
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-16 13:56:51 +07:00
1374cbee3e
store unencrypted size in the unencrypted_size column
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-16 13:54:26 +07:00
887952b4f4
add tests for cached mount provider migration
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-16 13:47:43 +07:00
5e375d9092
Revert "store unencrypted size in the unencrypted_size column"
...
This reverts commit 8238582e59
2022-08-16 12:07:14 +07:00
6e0123a1d0
Revert "add case statement to sql function builder"
...
This reverts commit 2a68819a67
2022-08-16 12:07:13 +07:00
51b9847fad
Merge branch 'master' into display-name-cache-public
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-15 15:28:30 +07:00
d95557e429
Merge pull request #33415 from nextcloud/fix/integration-test-notif
...
Fix integration tests
2022-08-08 17:06:57 +07:00
f8b13ecd60
Merge pull request #32363 from nextcloud/cleanup/remove-long-deprecated-classes
...
Remove OCP\App and OCP\BackgroundJob
2022-08-08 17:05:11 +07:00
49334e4d9c
Fix many tests and warnings
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-08 17:03:51 +07:00
48d9c4d2b0
Port existing server code to new interface
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-08 17:03:19 +07:00
cbd5cef2cc
Merge pull request #33398 from nextcloud/enh/noid/sensitive-methods-apps
...
allow apps to specify methods carrying sensitive parameters
2022-08-05 14:09:55 +07:00
7e7dcdaf17
Merge pull request #33435 from nextcloud/fix/remove-at-matchers-in-tests
...
Remove at matchers from tests in oauth2 and tests/Test
2022-08-04 09:58:26 +07:00
09362eaeaa
Support specifying IPv6 proxies in CIDR notation
...
Previously, it was not possible to use CIDR notation for IPv6 proxies
in the trusted_proxies parameter of config.php [1]. This patch adds
support for that.
[1]: https://docs.nextcloud.com/server/24/admin_manual/configuration_server/reverse_proxy_configuration.html#defining-trusted-proxies
Signed-off-by: Simon Leiner <simon@leiner.me>
2022-08-02 17:36:47 +07:00
9475cc02b2
Merge pull request #32958 from nextcloud/fix/noid/permission-update-allow-public-uploads
2022-08-02 16:49:27 +07:00
539162ba8b
Remove at matchers from tests in:
...
* apps/oauth2
* tests/Test/Repair/Owncloud
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-02 15:27:52 +07:00
acc68e9f93
fix share manager tests
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-08-02 01:35:10 +07:00
cb271b759e
Fix dynamic property creations in test files
...
This fixes warnings in PHP 8.2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-01 15:07:53 +07:00
a24ed79f85
Fix integration tests
...
The html tags changed in the notification apps, adapt selector to the
new state
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-01 12:38:19 +07:00
458c2fa297
Remove OCP\App and OCP\BackgroundJob
...
Both deprecated since NC 23
IAppManager is the replacement for OCP\App unfortunately it can't be
dependency injected in classes used by the installed otherwise the
database connection is initialised too early
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-01 09:46:40 +07:00
f74e89bde5
Merge pull request #32482 from nextcloud/enh/noid/share-attributes
...
Add share attributes + prevent download permission
2022-08-01 09:44:31 +07:00
952acd4d27
Merge pull request #33225 from nextcloud/fix/handle-one-time-passwords
...
Handle one time password better
2022-07-29 12:26:52 +07:00
6941c91531
add unit test for ExceptionSerializer
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-29 12:07:41 +07:00
03b1791cca
Fix share attribute related tests + code style
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
a95c19e14b
Add share attributes + prevent download permission
...
Makes it possible to store download permission
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
702445ba3b
Handle one time password better
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-28 14:26:25 +07:00
253118298d
Redesign guest pages for better accessibility
...
- Use white box and put content on it
- Improve focus indicator
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-27 10:43:21 +07:00
525cf58735
Adjust acceptance tests to changes in sharing tab
...
The name of the user shared with is now marked with a "span" rather than
with "h5".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-07-26 15:13:18 +07:00
b4353c4651
Merge pull request #33320 from nextcloud/bugfix/noid/remove-files-duplicate-dom-ids
...
Replace files app ids to classes
2022-07-26 12:21:13 +07:00
7615536977
Merge pull request #33031 from nextcloud/fix/improve-local-ip-detection
...
Improve local IP detection
2022-07-26 11:39:32 +07:00
bb2557c389
Replace files app ids to classes
...
Replaced ids to classes for the following:
- #filestable -> .files-filestable
- #fileList -> .files-fileList
- #controls -> .files-controls
- #emptycontent -> .emptyfilelist.emptycontent
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-26 10:19:19 +07:00
bbe15b4b43
Merge pull request #33129 from nextcloud/fix-reading-blob-as-resources
...
Fix reading blob data as resource
2022-07-25 17:56:03 +07:00
7a0648757a
Delete comments that expired now
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-07-25 11:30:20 +07:00
1d30fb7852
Fix reading blob data as resource
...
PostgreSQL returns data as resource when using IQueryBuilder::PARAM_LOB
(which is used for QBMapper).
Previously we just converted this resource using settype, which produced
things like "Resource id #14" instead of the actual resource data.
Now we read the stream correctly if the returned data is a resource
See context at #22472
Fixes #22439
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-07-25 09:45:47 +07:00
b3b6f2d581
fix Controller tests
...
- added pageTitle in code was missing in expectations
- fixed warnings of superflouos parameter
- fixed wrong type of mock
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-22 22:15:41 +07:00
6c3c7a5e4d
Merge pull request #32981 from nextcloud/typing/carl/simplefs
...
Add typing to SimpleFS
2022-07-18 12:34:11 +07:00
19a36b58a6
Add typing to SimpleFS
...
- Fix putContent sometimes return a bool and sometimes nothing
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-14 17:20:51 +07:00
d5c23dbb9f
Move CappedMemoryCache to OCP
...
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-14 15:54:31 +07:00
c20d34b2ca
Merge pull request #32552 from nextcloud/enh/improve-job-handling-commands
...
Improve job handling through occ
2022-07-12 16:04:57 +07:00
0386f4270b
Fix DummyJobList typing
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-12 14:27:02 +07:00
c5ffd7ce32
Use Symfony IpUtils to check for local IP ranges
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-12 12:09:05 +07:00
16b5e6bc7f
Merge pull request #32973 from nextcloud/cleanup/avatar-code
...
Cleanup avatar related code
2022-07-11 11:56:39 +07:00
50a7f612d9
Fix DummyJobList class used by tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
74ebb72622
Merge pull request #33110 from nextcloud/feat/handle-onetime-password-large
...
Handle one time password and very large passwords
2022-07-08 19:54:05 +07:00
ec5cbdeb7f
Make Color class public
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-05 14:44:44 +07:00
1c23c029af
Handler large passwords
...
For passwords bigger than 250 characters, use a bigger key since the
performance impact is minor (around one second to encrypt the password).
For passwords bigger than 470 characters, give up earlier and throw
exeception recommanding admin to either enable the previously enabled
configuration or use smaller passwords.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-05 11:37:14 +07:00
cdf3b60555
Handle one time passwords
...
This adds an option to disable storing passwords in the database. This
might be desirable when using single use token as passwords or very
large passwords.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-05 11:25:44 +07:00
2ad53742f2
fix external storages access
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-07-01 22:52:10 +07:00
d722a0c12a
Adjust fake manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-01 16:38:58 +07:00
198224bf7a
Allow to expire comments of multiple objects with one call
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-01 15:59:29 +07:00
d6e35dfe2c
use blueprint from repo
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-30 15:52:33 +07:00
64bff27c99
Merge pull request #32960 from nextcloud/fix/avoid-using-undeclared-properties
...
Fix PHP 8.2 warnings about undeclared properties
2022-06-28 12:05:16 +07:00
0fe7064fc4
Merge pull request #32998 from nextcloud/fix/setting_name
...
Rename setting name to reduce its length
2022-06-27 11:58:54 +07:00
347ca20f4e
Rename setting name to reduce its length
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-27 11:04:17 +07:00
4722baf970
Merge pull request #32863 from nextcloud/feature/add-comments-expire-date
...
Add comments expire date
2022-06-24 10:28:13 +07:00
812016d626
Cleanup avatar related code
...
- Move event listener to new event handling
- Add typing almost everywhere
- Fix inconsistent interface parameter
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-22 16:11:42 +07:00
cf5452e633
Merge pull request #32242 from nextcloud/fix-logging-data-array
...
Fix logging data context to file
2022-06-21 18:49:08 +07:00
1bd5222224
Fix PHP 8.2 warnings about undeclared properties
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-21 16:17:52 +07:00
53eafc0cb7
Merge pull request #32868 from nextcloud/fix/replace-opis-closure-by-laravel-fork
...
Replace opis/closure by laravel/serializable-closure
2022-06-21 12:21:32 +07:00
fd8f2aff09
Merge pull request #32901 from nextcloud/fix/remove-at-matcher-in-lib-tests
...
Remove at matcher uses in tests/lib
2022-06-21 11:45:00 +07:00
95f0cb2a2a
Add a test about unserializing data from opis/closure serialization
...
We need to be able to unserialize data from before upgrade.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-20 17:34:29 +07:00
3be1217c04
Follow the most common pattern used in project
...
```
git grep strval|wc -l
32
git grep "(string)"|wc -l
481
```
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-06-20 11:46:13 +07:00
6a1510f8ee
Remove some more at matchers in tests/lib
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-20 10:53:06 +07:00
c1f054a9e0
Fix email shares not being shown to other users
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2022-06-17 17:31:26 +07:00
8b2b5946e6
make placeholder a const for reuse
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:38:29 +07:00
891c10d09d
fix overwriting original vars when logging
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:36:58 +07:00
09a5947a6d
add serializer test
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:36:58 +07:00
c7e1c36362
Remove at matcher uses in tests/lib
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-16 17:43:17 +07:00
c59b0c2ff7
Add comments expire date
...
https://github.com/nextcloud/spreed/pull/7327
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-06-15 11:58:29 +07:00
ad10cd5f65
Merge pull request #32813 from nextcloud/debt/noid/check-for-3rdparty-updates
...
Run php tests when 3rdparty changed
2022-06-14 12:34:55 +07:00
4f230877e9
Merge pull request #32853 from nextcloud/fix/update-acceptance-composer-lock
...
Update dependencies in acceptance tests composer.lock
2022-06-13 13:55:47 +07:00
8809de1eef
Merge pull request #31966 from nextcloud/unencrypted-size
...
store unencrypted size in the unencrypted_size column
2022-06-13 11:55:37 +07:00
5cce1b92ff
Update dependencies in acceptance tests composer.lock
...
It should allow to run them on PHP>=8.0 with a recent phpunit.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-13 10:24:42 +07:00
abe5ff3654
Make LostController use IInitialState and LoggerInterface
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-10 16:41:41 +07:00
6283d14fa6
Modernize the LostControllerTest test
...
Remove some depreciated at() calls
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-10 16:41:41 +07:00
44e13848a1
Add password reset typed events
...
These hooks are only used in the Encryption app from what I can see.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-10 16:41:41 +07:00
17a12bf617
Run php tests when 3rdparty changed
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-06-10 14:20:43 +07:00
6e3d668436
Keep non default protocol in cloud id
...
When there is no protocol on the cloud id, we assume it's https://
But this means that when an http:// server currently sends an OCM
invite to another server, the protocol is striped and the remote
instance will try to talk back to https:// which might not be available.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-09 15:23:05 +07:00
e76d8bb901
Merge pull request #32697 from nextcloud/fix/get-avatar-authz
2022-06-08 16:27:31 +07:00
7c50dd888e
Test all scopes
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-07 23:57:21 +07:00
7455cd9dd7
Fix get avatar authorization
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-07 23:57:21 +07:00
50ed84fe17
Simlify tests for integrity check on modified mimetype lists
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-06-07 21:54:27 +07:00
8238582e59
store unencrypted size in the unencrypted_size column
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-02 16:07:00 +07:00
2a68819a67
add case statement to sql function builder
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-02 15:52:12 +07:00
b212e8dcc9
Add unit tests for encryption's isSystemWideMountPoint
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-06-01 18:10:59 +07:00
0726271504
Merge pull request #32371 from nextcloud/fix-31952
...
More meaningfull message when a public authenticated share's password is wrong or has expired.
2022-06-01 09:04:11 +07:00
4a790fedf0
More meaningfull message when a public authenticated share's password is wrong or has expired
...
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
2022-05-31 17:26:58 +07:00
699f259c45
Merge pull request #32667 from nextcloud/followup/32655/fix-tests
...
Fix unit tests
2022-05-31 11:30:51 +07:00
279e06a80f
Merge pull request #32587 from nextcloud/bugfix/noid/improve-jsconfighelper
...
Improve JSConfigHelper code quality a bit
2022-05-31 10:29:30 +07:00
c2af3667dc
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-31 10:23:52 +07:00
3901a93c72
Use JSON_THROW_ON_ERROR instead of custom error handling
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-05-30 19:17:49 +07:00
0886437f2c
Merge pull request #32591 from nextcloud/fix/node-test
...
Fix node tests ci
2022-05-30 17:00:27 +07:00
1164c762eb
Merge pull request #31948 from nextcloud/core-cleanup-74
...
Update core to PHP 7.4 standard
2022-05-30 14:37:37 +07:00
f9efc410fa
Restore old behaviour of sending flase for not found apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-30 12:41:35 +07:00
623293c2dd
Fix node tests ci
...
- Update jest snapshot
- Fix importing 3rdparty vue components
- Disable temporarely tests using nextcloud-vue/Button
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-30 10:54:45 +07:00
8951f069fe
Require a recent phpunit version in integration and acceptance
...
Otherwise build with PHP>8 will fail as PHPUnit 6 does not support it
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-24 18:54:29 +07:00
8d599c3410
Merge pull request #32378 from nextcloud/fix/psalm-userbackend
...
Fix psalm issues related to the user backend
2022-05-23 11:41:21 +07:00
b70c6a128f
Update core to PHP 7.4 standard
...
- Typed properties
- Port to LoggerInterface
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 22:18:06 +07:00
9ec0cb0a90
Fix psalm issues related to the user backend
...
- Reflect the actual return value returned by the implementation in the
the interface. E.g. IUser|bool -> IUser|false
- Remove $hasLoggedIn parameter from private countUser implementation.
Replace the two call with the equivalent countSeenUser
- getBackend is nuallable, add this to the interface
- Use backend interface to make psalm happy about call to undefined
methods. Also helps with getting rid at some point of the old
implementActions
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 17:14:58 +07:00
18dd460720
Merge pull request #26813 from nextcloud/feature/files-search-tags
...
Files: Extend search to also cover tags
2022-05-18 10:58:02 +07:00
6d6662ec68
expose displayname cache trough a public interface
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-05-18 03:47:34 +07:00
f755ee0868
Files: Extend search to also cover tags
...
fixes #326
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2022-05-17 21:05:09 +07:00
4d26a9afa0
Allow to tweak default scopes for accounts
...
Close #6582
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-16 22:54:51 +07:00
07f17d01cc
Merge pull request #32306 from nextcloud/fix/migrate-phpunit-configuration
...
Migrate phpunit configuration to new format
2022-05-16 20:44:00 +07:00
fd576b568c
Merge pull request #32305 from nextcloud/bugfix/32302/fix-browser-agent-trimming
...
Fix user agent trimming on installation
2022-05-16 11:20:46 +07:00
6084d691b0
Merge pull request #32375 from nextcloud/bugfix/noid/show-user-account-on-grant-loginflow-step
...
Show user account on grant loginflow step
2022-05-16 11:18:22 +07:00
40b9769d4d
Extend tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-16 10:33:30 +07:00
85758a4f70
Merge pull request #31662 from nextcloud/modernize-contactmenu
2022-05-13 20:14:31 +07:00
b8a7ab9941
Fix jsunit
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-13 16:13:01 +07:00
9a9409e315
Remove SCSSCacher
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-13 16:10:45 +07:00
9fcf531154
Merge pull request #30863 from nextcloud/performance/saving-user-profile-info
...
Minor optimizations for saving user personal information
2022-05-13 12:56:39 +07:00
fe33e9c08c
Merge pull request #32250 from nextcloud/cleanup/cappedmemorycache
2022-05-13 08:27:28 +07:00
eef973e85b
Minor optimizations for saving user personal information
...
* Remove double hook: the OC_User::changeUser triggers an
OC\AccountManager::userUpdated and the app is already listening to this
signal in its Application definition
* Make createCard not check if an card exists if we already checked
previously. We also don't try to get the card if the user is disabled
as we don't use the card in this case
We this change we go from 100 DB requests to 80 DB requests when saving
an user email address.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
(cherry picked from commit c6fd482edf33214a9ad4787e4cac278f871fa7c8)
2022-05-12 21:02:52 +07:00
23771f0587
Merge pull request #32077 from nextcloud/cleanup/lock
...
Cleanup lock related code
2022-05-12 20:57:38 +07:00
232322fe06
Modernize contacts menu
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-12 18:31:59 +07:00
fcae6a68c3
Cleanup lock related code
...
- Port to QueryBuilder
- Improve the doc a bit
- Add type hinting
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-12 15:09:58 +07:00
ec6b83cc18
Add stricter psalm type for CappedMemoryCache
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-12 15:06:18 +07:00
01dbd22c9c
Validate requested length is random string generator
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-05-12 13:58:18 +07:00
3c6253f965
Remove old legacy SvgController and IconsCacher
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-10 23:24:07 +07:00
a953401999
Migrate phpunit configuration to new format
...
Fixes:
Warning: Your XML configuration validates against a deprecated schema.
Suggestion: Migrate your XML configuration using "--migrate-configuration"!
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-09 11:51:14 +07:00
7b3e2217de
Fix user agent trimming on installation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-09 08:36:34 +07:00
0284c0f717
Merge pull request #32276 from nextcloud/fix/ldap_error_handling
...
Do not dispatch postSetPassword when setPassword fails
2022-05-05 20:19:28 +07:00
7718c9776c
Merge pull request #32113 from nextcloud/bugfix/noid/fix-csp-merging-bools
...
Add CSP policy merge priority for booleans
2022-05-05 17:26:48 +07:00
8a2cf5bb68
Do not dispatch postSetPassword when setPassword fails
...
Also Improve error message when setPassword fails
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-05 17:21:23 +07:00
d3efd40a24
Merge pull request #32259 from nextcloud/adjust-acceptance-tests-to-changes-in-notifications-markup
...
Adjust acceptance tests to changes in notifications markup
2022-05-05 09:21:00 +07:00
24e25a6b64
Merge pull request #32249 from nextcloud/bugfix/noid/fix-missing-subline-info
...
Expose shareWithDisplayNameUnique also on autocomplete endpoint
2022-05-05 09:20:45 +07:00
3c451f8357
Adjust acceptance tests to changes in notifications markup
...
Since nextcloud/notifications#1178 each notification in the list is a
"<li>" rather than a "<div>".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-05-03 23:16:24 +07:00
290697b08f
Merge pull request #32220 from nextcloud/feature/add-tests-to-validate-emojis
...
Include more emoji chars to test and fixes after include it
2022-05-03 16:08:19 +07:00
6e4d721278
Expose shareWithDisplayNameUnique also on autocomplete endpoint
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-03 12:51:23 +07:00
1e7d924c61
Fix logging data context to file
...
It was only logged when an exception was provided or when using
logData (which is not being much used).
We make sure the interpolated parameters are not logged.
Only tested with file write logger, but shouldn't work differently.
Crash reporters always had the context.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-02 19:29:35 +07:00
459202d54c
Merge pull request #31752 from nextcloud/fix/remove-still-more-ilogger
...
Move away from deprecated ILogger
2022-05-02 10:15:10 +07:00
cefcd55994
Include more emoji chars to test and fixes after include it
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-04-29 14:00:57 +07:00
8184e356f4
Remove test for removed class SearchResultSorter
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-28 14:56:26 +07:00
902476fa20
Extract the EmojiService from user status and add an OCP interface
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-28 07:09:44 +07:00
a4cd9fd37c
Add a unit test for translation with trailing colon
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-26 11:05:19 +07:00
59e0402691
Merge pull request #32069 from nextcloud/cleanup/allconfig-sql
...
Cleanup AllConfig
2022-04-25 18:56:15 +07:00
0b27b9e658
Get not only time-sensitive next job from list but any
...
Before the change webcron used to select
**only** time-sensitive tasks.
Signed-off-by: Kirill Popov <kirill.s.popov@gmail.com>
2022-04-24 21:55:53 +07:00
8bbdd9ea0c
Cleanup AllConfig
...
- Port to QueryBuilder
- More typing when possible
- Import classes with 'use'
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-22 16:03:29 +07:00
05a33ad713
Fix acceptance
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 19:00:29 +07:00
3c75a99267
Phpunit
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 19:00:28 +07:00
efb432865f
Fix test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-20 13:08:31 +07:00
7817845538
Add a metadata service to store file metadata
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-13 14:06:29 +07:00
cd95fce105
Merge pull request #31932 from nextcloud/feat/ignore_second_dn
...
Add settings to ignore second display name in search
2022-04-13 09:52:38 +07:00
37f1c8640e
Add settings to ignore second display name in search
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-12 17:27:59 +07:00
d70d90702f
Merge pull request #31907 from nextcloud/enh/noid/tag-remote-as-globalscale
...
confirm user is internal to globalscale
2022-04-12 11:10:36 +07:00
10eafd70c8
confirm user is internal to globalscale
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2022-04-12 09:11:05 +07:00
c6a5c07041
Adds a "Request password" button to the public share authentication page for shares
...
of type TYPE_EMAIL, when the "video verification" checkbox isn't checked. Users accessing
non-anonymous public shares (TYPE_EMAIL shares) can now request a temporary password themselves.
- Creates a migration step for the files_sharing app to add the 'password_expiration_time'
attribute to the oc_shares table.
- Makes share temporary passwords' expiration time configurable via a system value.
- Adds a system config value to allow permanent share passwords
-Fixes a typo in a comment in apps/files_sharing/src/components/SharingEntryLink.vue
See https://github.com/nextcloud/server/issues/31005
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
2022-04-11 21:58:24 +07:00
151c800397
allow reusing known folder info when getting directory contents
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-06 14:40:34 +07:00
b8b4d247b4
Merge pull request #31194 from nextcloud/feat/allow-to-exclude-groups-from-password-enforcement
...
Allow to disable password policy enforcement for selected groups
2022-04-06 10:13:23 +07:00
a29251e02d
Allow to disable password policy enforcement for selected groups
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-05 17:04:17 +07:00
754603a04e
dont needlessly resolve path when getting internalPath/storage from Node
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-04 15:40:24 +07:00
135bdb3d58
Merge pull request #30823 from nextcloud/work/profiler
...
Built-in profiler
This adds the required API for collecting information about requests. This information
can then be displayed with the new 'profiler' app.
2022-04-04 12:56:37 +07:00
7d272c54d0
Add a built-in profiler inside Nextcloud
...
The webui is provided by a seperate application named profiler
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-04 10:28:26 +07:00
d3d53494d4
Merge pull request #31750 from nextcloud/fix/ci-should-fail-on-deprecation-warnings
...
Convert deprecation warnings to exception in phpunit
2022-04-01 14:11:41 +07:00
18c013d8fc
Add CSP policy merge priority for booleans
...
When two booleans conflict when merging CSP policies, true will win.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-01 13:56:34 +07:00
dd357d7f9b
Merge pull request #31679 from nextcloud/bugfix/noid/ensure-string-columns-to-be-maximum-of-4000
...
Ensure string column limit of 4.000 characters
2022-03-31 11:37:43 +07:00
cba4d85d9b
Convert deprecation warnings to exception in php unit
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-29 21:48:35 +07:00
576e4e8f2a
Merge pull request #31592 from nextcloud/fix/direct-arg-flow-v2
...
Add direct arg to login flow
2022-03-29 18:21:40 +07:00
765999f454
Merge pull request #31609 from nextcloud/fix/migrate-away-from-ilogger
...
Migrate from ILogger to LoggerInterface in lib/private
2022-03-29 09:39:38 +07:00
80388663af
Add direct arg to login flow
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Co-Authored-by: Carl Schwan <carl@carlschwan.eu>
2022-03-28 10:28:45 +07:00
129bae62d4
Ensure string column limit of 4.000 characters
...
https://docs.oracle.com/en/database/oracle/oracle-database/19/refrn/datatype-limits.html#GUID-963C79C9-9303-49FE-8F2D-C8AAF04D3095
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-25 12:44:51 +07:00
bfd09a0669
Avoid select with no FROM clause for Oracle in tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 20:35:02 +07:00
efebbacca4
Add octetLength and charLength to function builder, and tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 20:35:02 +07:00
3546cfba1c
Fix more ILogger related problems from tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:27 +07:00
1809386862
Fix codestyle
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:27 +07:00
61f7f13bd8
Migrate from ILogger to LoggerInterface where needed in the tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:26 +07:00
367be7c55f
Allow reactions also with other combined emojis
...
Honerful copying the EmojiService from UserStatus for now
I think this should be put into a decent place and then reused,
but I couldn't find somethin short term before beta1
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-24 15:13:09 +07:00
d683e0d3d1
Automatically cut the token name on the first level
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-23 21:38:53 +07:00
343476f54f
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-23 11:00:34 +07:00
89e293d3fd
Test disabled for now due to multiple reasons
...
see https://github.com/nextcloud/server/pull/31580#issuecomment-1069182234 for details
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-22 17:07:48 +07:00
0acd4b5f82
Merge pull request #31235 from nextcloud/techdebt/noid/extract-request-id
...
Extract request id handling to dedicated class so it can be injected without DB dependency
2022-03-22 12:08:45 +07:00
108abd77ed
Add profile default setting for admin
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 02:55:12 +07:00
1fc0b4320c
Add global profile toggle config
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 02:55:12 +07:00
2d9d0702f0
Add method to set all account properties from json
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-17 16:33:19 +07:00
a99d33c72d
Discard duplicate collection name from account serialization
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-17 04:27:39 +07:00
04a4562a01
Merge pull request #31513 from nextcloud/techdebt/noid/enforce-primary-keys
...
Enforce primary keys as they are required to be performant in MySQL c…
2022-03-15 10:53:11 +07:00
21f96308c4
Overwrite the channel
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 16:16:30 +07:00
01e2a26749
Fix unit tests
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-03-10 14:19:48 +07:00
1970d3dc9a
Add a test for primary keys
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 14:04:04 +07:00
bd03dd37be
Allow to set a strict-dynamic CSP through the API
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-03-09 15:10:27 +07:00
917c74e214
type fixes
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:16 +07:00
d81713e5c1
simplify setup of circular SetupManager<->Manager
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:09 +07:00
22875bf367
move logic to decide what to setup to setupmanager
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:03 +07:00
1c468129af
adjust tests to new fs setup
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:29:59 +07:00
8b22a463e9
Merge pull request #31266 from nextcloud/root-setup-mountprovider
...
move root mount setup to mountproviders
2022-03-04 13:44:05 +07:00
821a0dc875
Merge pull request #31387 from nextcloud/fix/common-main-core-script-order
2022-03-04 14:37:41 +07:00
58d516b509
Make sure common and main core scripts are loaded first
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-03-04 10:22:56 +07:00
a3f3ffe6a6
Update images in scripts to run local tests in Docker
...
PHP 7.3 support was dropped for Nextcloud 24. The Docker images are
updated to the same images used for integration and acceptance tests in
CI.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-03-03 19:53:26 +07:00
2dd96fe8da
Fix tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-28 11:24:41 +07:00
eede608c0e
Add event logging to app loading
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-28 11:24:41 +07:00
d08d0ebdda
skip localstorage dependend user test when not using local user storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-25 16:33:11 +07:00
8b7c8447a0
move root mount setup to mountproviders
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-24 17:21:42 +07:00
cfb7923e08
store mountprovider for each mount in the mounts table
...
this enabled more fine grained filesystem setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-23 18:02:33 +07:00
d078d53683
Fix tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-23 11:01:58 +07:00
cc6653e45c
Adjust and add unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-23 11:01:58 +07:00
cb252c5591
Add Transactional trait for atomic DB operations
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-17 09:58:41 +07:00
e485451eed
Add test
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-02-11 23:34:25 +07:00
2673775f6e
fix fs cache test user setup
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:28 +07:00
cd7a217c29
Merge pull request #31007 from nextcloud/enhancement/bootstrap-calendar-resource-room-backend-registration
...
Move calendar resource/room backend registration to IBootstrap
2022-02-09 10:25:03 +07:00
c58f8d6025
Merge pull request #30945 from nextcloud/techdebt/noid/background-job-time-windows
...
Background job time windows
2022-02-08 14:46:20 +07:00
6dd60b6d30
Only allow avatars in 64 and 512 pixel size
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-07 16:47:51 +07:00
b765f79368
Allow apps to specify if their background job can be delayed
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-07 13:54:54 +07:00
9a656e5b35
Move calendar resource/room backend registration to IBootstrap
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-07 12:51:42 +07:00
82f602e857
Merge pull request #30354 from nextcloud/enhancement/talk-api
...
Add a Talk API for OCP
2022-02-04 09:54:13 +07:00
2f2538a57a
Merge pull request #30888 from nextcloud/comments-interface
...
Update ICommentsManager with reaction methods
2022-02-04 09:38:04 +07:00
2c356d0852
Add a Talk API for OCP
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-04 08:53:18 +07:00
8ec7c5c8ae
Update ICommentsManager with reaction methods
...
Fix psalm errors
Reorder methods and remove return null
Use best pattern on docblock
Goals: update https://github.com/ChristophWurst/nextcloud_composer/ with reaction methods.
The script
https://github.com/ChristophWurst/nextcloud_composer/blob/master/build.sh
only get lib/public classes
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-02-03 12:52:18 +07:00
c712987878
send request id in response header
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-01 14:24:01 +07:00
e8c66d0f89
Merge pull request #30794 from nextcloud/techdebt/noid/allow-to-get-comments-with-verb
...
Allow to get comments with a given set of verbs
2022-01-28 16:41:42 +07:00
429380337f
Fix fake manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 14:02:34 +07:00
7bb01b6ccc
Refactor and fixes on tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:40:29 +07:00
b9f74584a1
Fix check after change from string to mb_string
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:41 +07:00
189f9f96ce
Limit the summary and sort it afterwards
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:39 +07:00
f7cd995612
Order the reaction summary, improvements on validations
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:39 +07:00
1ce894a50c
Disable reactions if database don't support utf8mb4
...
Fix column size
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:37 +07:00
52affa9ddd
Skip if dont support 4 bytes UTF8
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:07 +07:00
b6d9e0542d
Fix column size to work with Oracle. Add unit tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 +07:00
425b5cf081
Add unit tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 +07:00
afe5b6dd8a
Prevent query error when use subquery
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 +07:00
7619dceff4
Fix tests with email templates
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-18 20:56:50 +07:00
89d109a4d9
Merge pull request #30508 from nextcloud/fix/psaml-bin
...
Fix psalm not running
2022-01-13 09:51:04 +07:00
b1048864f0
Merge pull request #30600 from nextcloud/fix/30595/idn-email-share
...
Fix idn emails not working in shares
2022-01-13 09:24:26 +07:00
6312c0df69
Check style update
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 00:19:07 +07:00
2e1491771e
Merge pull request #30572 from nextcloud/fix/lint_warnings
...
Fix lint warnings
2022-01-12 15:48:36 +07:00
7ecb65f725
Add check before sending email that email address is valid
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-11 20:59:44 +07:00
2bc0749cb6
Merge pull request #30588 from nextcloud/bugfix/noid/fix-unset-scopes
2022-01-11 10:12:11 +07:00
14e57bf70a
Replace license information to SPDX expression
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:26:40 +07:00
c47406ad3c
Merge pull request #30291 from nextcloud/image-memory-limit
...
Prevent loading images that would require too much memory.
2022-01-11 13:35:56 +07:00
172be810b8
Fix test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-11 12:54:41 +07:00
d3d65e5c88
Prevent loading images that would require too much memory.
...
For most image formats, the header specifies the width/height.
PHP allocates an image object from that size, even if the actual
image data is much smaller. This image object size is not limited
by the limit configured in PHP.
The memory limit can be configured through "config.php" setting
"preview_max_memory" and defaults to 128 MBytes which should be
enough for most images without filling up all memory.
Signed-off-by: Joachim Bauch <bauch@struktur.de>
2022-01-11 11:44:38 +07:00
25ade6218a
Streamline reseting of private static properties
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 10:29:25 +07:00
92e60caa86
Revert "Streamline reseting of private static properties"
...
This reverts commit e50121d4c0
2022-01-10 18:42:07 +07:00
e50121d4c0
Streamline reseting of private static properties
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-10 17:34:48 +07:00
447cd553b6
Reset $scriptDeps in tests
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-08 10:15:48 +07:00
1261fa5384
Adapt test to new dist file layout
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-08 10:14:53 +07:00
55986382e8
Merge pull request #30378 from nextcloud/feature/accept-multiple-args-on-concat
...
Accept multipe args on concat
2022-01-07 12:16:46 +07:00
f732cf1b04
Unit tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-07 09:54:41 +07:00
19a3656fd9
Fix email verification
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-01-06 23:47:42 +07:00
773c407965
Merge pull request #29921 from nextcloud/feature/noid/allow-to-count-commments-with-multiple-verbs
...
Allow to count comments with multiple verbs
2022-01-05 13:44:07 +07:00
03abaaaee5
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-05 11:53:33 +07:00
977d8479e3
Merge pull request #30393 from nextcloud/feature/add-group-concat-aggregator-function
...
Add group_concat aggregator function
2022-01-04 17:34:37 +07:00
46ad6fa3c7
Add a test with integer
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-04 09:15:17 +07:00
43fa2d5c8c
Test with real data
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-03 21:43:51 +07:00
fb6a9f308d
Add unit test
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-03 21:41:38 +07:00
7b9fea85b6
Add unit test and orderBy parameter
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-03 12:45:00 +07:00
491bd6260c
Sort app scripts topologically by its dependencies
...
Implement a proper topological sorting algorithm. Based on the
implementation by https://github.com/marcj/topsort.php
Logs an error in case a circular dependency is detected.
Fixes : #30278
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-12-29 16:40:05 +07:00
61dd1d3d97
Pass username prefill through unauthenticated request redirects
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-12-29 11:52:31 +07:00
d73fe0ccd9
Merge pull request #29879 from nextcloud/bugfix/noid/sharing-enumeration-addressbooks
2021-12-21 08:11:04 +07:00
8dd119402a
Improve unit testing for Util::addScript() and Util::getScript()
...
Instead of checking for a predefined order of the scripts, test the
logic: core first, dependencies before their children, no duplicates and
all scripts still listed.
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-12-20 11:40:17 +07:00
ec4fff20e8
Avoid Deprecation warning from Zip tests on PHP 8.1
...
It is not allowed anymore to open an empty file as a new zip archive.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-16 09:58:40 +07:00
e053feb5db
Fix PHP deprecation warning in File/ViewTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-16 09:43:32 +07:00
2fe8042fff
Add integration tests for email completion
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-12-08 09:08:54 +07:00
791d57051a
Adapt tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-12-02 21:13:07 +07:00
6b3c703794
Merge pull request #29735 from nextcloud/background-scan-one-by-one
...
find users for background scan one by one
2021-12-02 17:09:43 +07:00
e95745c074
fix tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-12-02 17:43:16 +07:00
6d33d75be1
Remove unused imports
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-02 14:51:44 +07:00
617528312a
Fix last tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-02 10:39:49 +07:00
3e20cffc86
More test fixing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 22:38:57 +07:00
c6ae53096c
More test fixing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 22:17:19 +07:00
9f00179037
More unit test adjustments
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 21:40:14 +07:00
a8866b0253
Fix tests
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-12-01 19:53:24 +07:00
d384edc9c6
add method to shorten a string to given byte size to Utils
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-11-26 16:21:40 +07:00
fd487c1a43
Merge pull request #29432 from nextcloud/fix/support-php-8.1
...
Support PHP 8.1 - First batch
2021-11-23 15:41:20 +07:00
8b271b8a12
Fix tests and avoid PHP errors in them
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:29:01 +07:00
cd72045433
Make mock config return default value to fix warnings
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:29:00 +07:00
25fa0b8acd
Fix TempManager test errors about passing null to is_dir
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:29:00 +07:00
065531570d
Fix Encryption tests on PHP 8.1
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:59 +07:00
bb9c099e42
Fix FolderTest calls to Mountpoint constructor with wrong type
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:59 +07:00
3a1b3745eb
Fix DateTime constructor calls with null
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:58 +07:00
bc3acfc957
Fix test class names
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:57 +07:00
66bdda568a
Fix Guzzle function calls
...
Since 1.7.0 and 2.0 these functions are turned into static methods.
See https://github.com/guzzle/psr7#upgrading-from-function-api
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:57 +07:00
113756db30
Fix ArrayAccess and JsonSerializable return types
...
First round of modifications for PHP 8.1
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:56 +07:00
f01ad7b8d8
Improve normalizer detecting IPv4 inside of IPv6
...
The subnet for an IPv4 address inside of IPv6 is now returned in its
IPv4 form.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-22 16:46:25 +07:00
7e08a4ab15
Fix getting subnet of ipv4 mapped ipv6 addresses
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-22 14:10:11 +07:00
c42a890126
Merge pull request #29622 from nextcloud/feat/objectstore_multibucket-shift
...
Implement multibucket shift for ObjectStore
2021-11-19 17:26:44 +07:00
c92a0e4152
Normalize directory entries in Encoding wrapper
...
Directory entry file names are now normalized in getMetaData(),
getDirectoryContents() and opendir().
This makes the scanner work properly as it assumes pre-normalized names.
In case the names were not normalized, the scanner will now skip the
entries and display a warning when applicable.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-17 09:43:25 +07:00
e9b414fbe3
OC_Util: Add fallbacks to check if current locale is UTF8
...
Using escapeshellcmd to get current locale causes error
if the function is disabled.
Add fallbacks to prevent the error.
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-16 00:40:52 +07:00
25f15f86a9
Add check whether escapeshellcmd behaves the same as basename
...
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-15 18:33:50 +07:00
455bff5c17
Fix missing setlocale with php 8
...
When php version = 8, basename('§') does not bug even if LC_ALL is non-UTF-8 locale.
This cause OC_Util::isSetLocaleWorking() to skip setlocale("C.UTF-8").
Fix it by using escapeshellcmd instead of basename.
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-14 09:18:59 +07:00
265c2c125c
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-12 15:01:56 +07:00
6ab2feaa54
Implement multibucket shift for ObjectStore
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-11-11 15:09:28 +07:00
3b91e4cc48
Add unit test for share enumeration method
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 14:42:57 +07:00
fa036b2001
Move common logic to share manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 10:10:53 +07:00
95480f5a91
Merge pull request #29524 from nextcloud/bugfix/noid/fix-phpunit-warnings
...
Fix missing import of ILogger
2021-11-02 19:23:23 +07:00
f8463e1fc6
Fix missing import of ILogger
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-02 16:47:16 +07:00
58b6f35522
Enable Avatar tests as well for PHP>=8
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-28 17:49:32 +07:00
23a4e17bd1
Revert "Do not run image tests on php8"
...
This reverts commit d690f90928
2021-10-28 17:49:21 +07:00
c42f5bc5f6
Add an OCP for trusted domain helper
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-28 10:24:16 +07:00
f4e4a85fcf
Merge pull request #27440 from nextcloud/is-file-handle
2021-10-23 11:18:52 +07:00
a06001e085
Merge pull request #29363 from nextcloud/fair-use-push
2021-10-23 10:53:22 +07:00
d613b32045
add check isFairUseOfFreePushService on login
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2021-10-23 00:54:50 +07:00
b578a1e8b5
Fair use of push notifications
...
We want to keep offering our push notification service for free, but large
users overload our infrastructure. For this reason we have to rate-limit the
use of push notifications. If you need this feature, consider setting up your
own push server or using Nextcloud Enterprise.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-23 00:54:50 +07:00
e26d6f080b
fix populating account array with missing default values
...
- both $userData and $defaultUserData have numeric indices
- each element contains at least the name and other fields
- appending the missing data array is sufficient
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-10-22 23:05:43 +07:00
dae769d082
Update Tests
2021-10-22 12:16:11 +07:00
2be0eda47c
Merge pull request #29220 from nextcloud/s3-external-list
2021-10-22 12:06:05 +07:00
c98039c1df
Merge pull request #26725 from nextcloud/fix-federated-scope-not-shown-when-public-addressbook-upload-is-disabled
2021-10-22 11:52:56 +07:00
0a35937662
Merge pull request #26347 from J0WI/clean-path-regex
2021-10-22 11:42:30 +07:00
7e3b6e7088
Merge pull request #29344 from nextcloud/dependabot/composer/doctrine/dbal-3.1.3
2021-10-22 11:35:02 +07:00
7dd7256cfe
Prevent duplicate auth token activity updates
...
The auth token activity logic works as follows
* Read auth token
* Compare last activity time stamp to current time
* Update auth token activity if it's older than x seconds
This works fine in isolation but with concurrency that means that
occasionally the same token is read simultaneously by two processes and
both of these processes will trigger an update of the same row.
Affectively the second update doesn't add much value. It might set the
time stamp to the exact same time stamp or one a few seconds later. But
the last activity is no precise science, we don't need this accuracy.
This patch changes the UPDATE query to include the expected value in a
comparison with the current data. This results in an affected row when
the data in the DB still has an old time stamp, but won't affect a row
if the time stamp is (nearly) up to date.
This is a micro optimization and will possibly not show any significant
performance improvement. Yet in setups with a DB cluster it means that
the write node has to send fewer changes to the read nodes due to the
lower number of actual changes.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-22 09:32:22 +07:00
130ab63ca1
Bump doctrine/dbal from 3.0.0 to 3.1.3
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-22 09:03:45 +07:00
0bef570fe9
Merge pull request #29256 from nextcloud/fix/noid/harmonize-appstoreenabled-check
...
Fix appstoreenabled check
2021-10-21 12:42:14 +07:00
f24e8212c3
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-21 09:27:12 +07:00
7f1dc52a66
Change origin field to appId
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-20 14:47:28 +07:00
5e23800a95
Do not remove current user on findOne
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-10-20 11:53:45 +07:00
873e8e219c
Add appName to contactsmenu action API
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-10-20 11:53:45 +07:00
309354852f
Profile backend
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-10-19 04:59:35 +07:00
7215148a24
Add new account properties
...
- New properties
- Organisation
- Role
- Headline
- Biography
- Profile Enabled property
- Fix errors with building default account properties
- Fix L10N factory method `getLanguage` not public error
- Update tests
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-10-19 04:44:40 +07:00
294b218895
ci
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-15 15:35:12 +07:00
f7a4ff4d63
Merge pull request #27217 from nextcloud/techdebt/noid/make-debugging-a-cron-job-easier
2021-10-15 11:09:23 +07:00
b6a3ba136c
Merge pull request #29235 from nextcloud/feat/appstore/enterprise
2021-10-15 11:06:32 +07:00
67baaaaff9
Merge pull request #29231 from nextcloud/fix/calendar-providers-instances
...
Build instances of the calendar providers before using them
2021-10-14 19:29:34 +07:00
c75a12c154
Build instances of the calendar providers before using them
...
What we get from the registration context are only the class names. We
still have to load the classes before we can use them.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-14 16:06:51 +07:00
1f76423500
Send the subscription key to the appstore requests
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-10-14 14:48:45 +07:00
acbe4b46c3
Merge pull request #29157 from nextcloud/enh/opendocument
2021-10-14 12:58:34 +07:00
9cd9f4b4bc
Move queries to the joblist
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-14 09:57:16 +07:00
811d0cd1b5
Merge pull request #29135 from nextcloud/feat/appstore-filtering
...
Allow to filter apps from the appstore
2021-10-14 09:50:37 +07:00
a58d1e6b06
Add Public Calendar Provider
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-14 08:22:24 +07:00
2f38781c96
Fix integrity checker tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-13 18:10:37 +07:00
1a6bac5874
Allow to whitelist apps from the apsptore
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-10-13 11:13:33 +07:00
e163d199d8
Merge pull request #29015 from nextcloud/enhancement/l10n-factory-find-generic-language
...
Add L10n factory method for generic language heuristics
2021-10-13 10:58:07 +07:00
5b727fc7da
Add L10n factory method for generic language heuristics
...
The existing `findLanguage` method tries its best to find the best
language for the current users. For some tasks we don't want this but
rather determine the most generic language for *another* user, e.g. when
the current user trigger an email notifiaction to someone else. In this
case the current user's language is a bad guess in many multi-language
environments.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-13 09:57:21 +07:00
3487aeeb1f
Add integration tests for group
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-12 14:05:38 +07:00
9187e986e1
Merge pull request #28907 from nextcloud/bug/noid/close-stream-local
...
explicitly close source stream on local / encryption storage
2021-10-08 10:02:01 +07:00
9a569ff387
Merge pull request #29064 from nextcloud/feature/add_cache_to_local_integration_tests_container
...
Add caching for local run of integration and acceptance tests
2021-10-06 21:04:47 +07:00
b13ce08ac8
Add cache for local integration test container
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-10-06 13:33:47 +07:00
32dc976e0d
Fix app-files acceptance tests
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-10-06 10:09:14 +07:00
d68f028251
Merge pull request #27733 from PhrozenByte/enhancement/noid/IURLGenerator-linkToDefaultPageUrl
2021-10-05 13:06:59 +07:00
e6ab948949
Make AppsEnableTest and AppsDisableTest independet of the app version number
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-10-01 23:08:59 +07:00
04f1882386
Merge pull request #28189 from nextcloud/work/carl/admin-delegation
...
Implement Admin Delegation
2021-09-29 22:48:32 +07:00
6958d8005a
Add admin privilege delegation for admin settings
...
This makes it possible for selected groups to access some settings
pages.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-09-29 21:43:31 +07:00
a586739e17
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-09-29 10:02:21 +07:00
9161f6ca4a
Remove tests that just prove mocked calls and don't actually validate anything useful
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-09-27 14:24:48 +07:00
cab44b6311
Run oci tests against phpunit9/php8
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-09-27 14:24:05 +07:00
e60a829b42
explicitly close source stream on local storage
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-09-21 17:41:59 +07:00
cbe406ea3e
Bump @nextcloud/vue
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-09-16 18:12:00 +07:00
024881dbd3
Add email addresses to contacts menu
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-09-15 16:58:44 +07:00
a994ef0c4f
Merge pull request #28792 from nextcloud/fix/noid/lost-password-missing-prefix
...
fixes missing prefix to validate password reset token
2021-09-14 09:50:22 +07:00
0dcc5c0e9f
Merge pull request #28728 from nextcloud/add-database-backend-limiter
...
Add database ratelimiting backend
2021-09-13 13:07:37 +07:00
6857136f06
fixes missing prefix to validate password reset token
...
- also fixes the test which missed asserting the presence of it
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-10 19:06:50 +07:00
27865d03c0
use specific email getter where necessary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +07:00
4461b9e870
enable the user to set a primary (notification) email address (backend)
...
- specific getters and setters on IUser and implementation
- new notify_email field in provisioning API
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:04 +07:00
a20de15b43
add a job to clean up expired verification tokens
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 14:03:35 +07:00
aacaad2a3f
implement verification for additional mails
...
- mails added by (sub)admins are automatically verified
- provisioning_api controller as verification endpoint
- IAccountProperty gets a locallyVerified property
- IPropertyCollection gets a method to fetch an IAccountProperty by value
- an remove equivalent was already present
- AccountManager always initiates mail verification on update if necessary
- add core success template for arbitrary title and message
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 14:03:35 +07:00
19cc757531
move verification token logic out of lost password controller
...
- to make it reusable
- needed for local email verification
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 14:03:29 +07:00
c21a721fc1
Merge pull request #28725 from nextcloud/disallow-public-page-in-2fa-flow
...
Remove 2FA exemption from PublicPage annotation
2021-09-07 10:44:34 +07:00
19ad636373
Resolve absolute path in tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-06 21:26:27 +07:00
6337bb3f59
Adjust tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-06 17:46:02 +07:00
378cc922c4
Adjust logic to store period instead of current timestamp
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-06 17:31:36 +07:00
8da6a9bea9
Adjust tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-06 09:09:42 +07:00
3866f388b1
Refactor writeObject to only use MultipartUpload when required
...
Signed-off-by: Bernd Rederlechner <Bernd.Rederlechner@t-systems.com>
Co-authored-by: Julius Härtl <jus@bitgrid.net>
2021-08-20 17:02:25 +07:00
4b0e18ae1b
Merge pull request #27294 from pjft/patch-2
...
Update TwoFactorChallengeController.php
2021-08-19 12:40:40 +07:00
83b39d6111
Add missing scope to test
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-08-18 19:05:33 +07:00
7c76e85dde
Use IURLGenerator function to get value of `\OC::$WEBROOT` global
...
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-08-16 10:56:47 +07:00
11169c86f8
Tests update
2021-08-15 12:23:29 +07:00
67e6468b9e
Merge pull request #28220 from nextcloud/get-by-id-multiple-mounts-single-storage
2021-08-09 19:27:23 +07:00
a1d6189dfa
Fix UrlGeneratorTest
...
And again... 😒
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-08-05 13:55:35 +07:00
aa455e71d9
Merge branch 'master' into enhancement/noid/IURLGenerator-linkToDefaultPageUrl
2021-08-04 18:52:55 +07:00
b768cade2b
Fix UrlGeneratorTest
...
Again... 😒
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-08-04 18:52:53 +07:00
416d10f76c
refs #21045 add app config to disable unlimited quota and to set max quota
...
avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed
avoid getting/setting/displaying unlimited default quota if not allowed
implement tests for unlimited quota restrictions
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-29 19:31:36 +07:00
db7ffb0bf9
Merge pull request #28175 from nextcloud/jail-search-root
2021-07-29 09:27:53 +07:00
5c2e7c7d28
fix Folder->getById() when a single storage is mounted multiple times
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-07-28 17:21:04 +07:00
4d5e8bcb99
add test for searching within a "root jail"
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-07-28 17:11:12 +07:00
b31c08e536
Merge pull request #28075 from nextcloud/enh/noid/admin_audit-report-full-path
...
Admin Audit - Sharing: createShare - report the full path
2021-07-26 12:35:48 +07:00
858d846999
Let memory limit set in tests fit the used amount
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-22 17:05:29 +07:00
4570bb4f65
Admin Audit - Sharing: createShare - report the full path
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-22 14:20:05 +07:00
7179002600
Allow to get a local cloud id without going through the contacts manager
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-14 16:08:05 +07:00
11d21e5f5c
Add a unit test to check for casting a IQueryFunction
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-07-07 14:19:24 +07:00
415d704959
Merge pull request #27198 from nextcloud/tests/run-s3-tests
...
Run s3 tests again
2021-07-05 11:52:48 +07:00
1e5962ae98
Fix UrlGeneratorTest::testGetDefaultPageUrlWithDefaultApps()
...
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 16:39:26 +07:00
15a445f743
Move UtilTest::testDefaultApps() to UrlGeneratorTest
...
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 16:26:55 +07:00
e16bf707aa
Fix UtilTest::testDefaultApps()
...
Oh wow... This definitly was no best practice... 😒
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 16:00:29 +07:00
e478db9161
Deprecate RedirectToDefaultAppResponse
...
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 15:13:08 +07:00
55cabef723
Use minio for s3 tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-01 08:22:24 +07:00
b78f3a57d1
Migrate HintException to OCP
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 +07:00
0df68f0697
Remove unused imports
...
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-06-30 16:48:22 +07:00
12059eb65b
Add IUrlGenerator::linkToDefaultPageUrl()
...
Replaces the deprecated \OC_Util::getDefaultPageUrl() and makes this API public.
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-06-30 16:20:57 +07:00
3f44fd00e2
Run s3 tests again
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-30 14:30:04 +07:00
506227b509
adjust internal data handling logic to fix store and load
...
- format as stored previously in oc_accounts table is kept
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:48:01 +07:00
c7bf4295cc
adjust email verification checker
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:47:36 +07:00
3d6ffd3da2
adjust verification state updater method
...
- also fixes scope of internal methods
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:42:42 +07:00
af3fdbea7b
make AccountManager actually write multi value properties
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:12 +07:00
638c04d6e0
accounts event handler to use eventdispatcher, DI and Accounts API
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:11 +07:00
13818005a3
prov api reports additional emails on getUser
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:10 +07:00
a651dbd2c0
Fix app version check
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-25 11:49:32 +07:00
9ed379da22
Merge pull request #27635 from nextcloud/fix/datetime-constants
...
Fix usage of DateTime constants
2021-06-23 09:56:28 +07:00
6d5cfe0c66
Move DateTime::RFC2822 to DateTimeInterface::2822
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-23 15:30:43 +07:00
770881d5d6
Move DateTime::ATOM to DateTimeInterface::ATOM
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-23 15:28:07 +07:00
ee7a484284
Merge pull request #26346 from J0WI/clean-auth-regex
...
Cleaner removePassword regex
2021-06-23 11:20:19 +07:00
b1086e25bb
Add logging to 2FA failure
...
For security reasons, we may want to monitor failures of 2FA challenges in order to ban attackers who might try to access compromised accounts but are stopped by the 2FA challenge.
Right now, the only hindrance is rate-limiting, but it's probably not enough.
Added dependency injection.
Signed-off-by: pjft <paulo.j.tavares@gmail.com>
2021-06-21 20:43:12 +07:00
a94236483e
Let apps toggle an unread counter on app icons
...
Co-authored-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-16 17:12:56 +07:00
818fc95b03
Merge pull request #26571 from nextcloud/bugfix/noid/existing-link-no-reshare
...
Only allow removing existing shares that would not be allowed due to reshare restrictions
2021-06-16 15:26:12 +07:00
66e10718c6
split of query building bits from searchhelper
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:40 +07:00
f938daa6e4
update tests and fix some edge cases around new search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:36 +07:00
e198dc1b20
rework search api to allow searching on multiple caches at once
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:22 +07:00
964fd27666
Handle single action unshare
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-09 10:43:50 +07:00
89c534858e
Merge pull request #27414 from francoisfreitag/test-at-2
...
Rewrite LegacyHelperTest without $this->at()
2021-06-08 22:07:16 +07:00
745543d8c0
Merge pull request #27306 from nextcloud/enh/noid/set-local-domain-for-swiftmailer
...
Set local domain for swiftmailer
2021-06-08 15:43:39 +07:00
662ab937e0
Merge pull request #27189 from nextcloud/feat/26866/account-collection-properties
...
Extend Accounts with multivalue properties (PropertyCollection)
2021-06-08 14:25:18 +07:00
ff2382e5a4
CI: more flexible assertions
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-07 23:41:04 +07:00
21762a1e94
Rewrite LegacyHelperTest without $this->at()
...
The at() matcher has been deprecated. It will be removed in PHPUnit 10.
Please refactor your test to not rely on the order in which methods are
invoked.
Signed-off-by: François Freitag <mail@franek.fr>
2021-06-07 21:43:30 +07:00
92d19bd79b
Merge pull request #27374 from nextcloud/bugfix/noid/adjust-unit-tests
...
Bugfix/noid/adjust unit tests
2021-06-07 11:12:22 +07:00
70edda0342
Port dav calendar settings page to Vue.js
...
- Drop reliance on deprecated global jQuery object.
- Allow testing user interactions.
- Use newer technology stack.
---
Test user interactions with the groupware dav settings
Add infrastructure to test Vue components:
- Use recommended libraries:
- https://vuejs.org/v2/guide/testing.html#Recommendations
- Use jest-dom for robust assertions on the DOM state
- Use user-event to be more representative of user actions
- Code is transpiled by Jest, with the help of vue-jest.
Ignore test files for no-unpublished-import. Prevent ESLint from
flagging:
```
/home/runner/work/server/server/apps/dav/src/views/CalDavSettings.spec.js
Error: 1:24 error "@testing-library/vue" is not published node/no-unpublished-import
Error: 2:23 error "@testing-library/user-event" is not published node/no-unpublished-import
```
Signed-off-by: François Freitag <mail@franek.fr>
2021-06-05 11:22:25 +07:00
181aab416a
Fix warnings about logException
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-04 10:57:09 +07:00
44827e37c0
allow interacting with IAccountPropertyCollections
...
- in fact the API could be done in a nicer way and it might be possible to
work without IAccountPropertyCollection, but only with the
IAccountProperties.
- To keep it simple at first and not overengineer the blunt attempt is
followed
- If necessary helpful in the further cause of development adjustements or
extensions can be done quickly with this base
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:49 +07:00
0bade27479
add IAccountPropertyCollection with implementation
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:49 +07:00
afea57352b
update unit tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:49 +07:00
377514aad1
Escape filename in Content-Disposition
...
We should escape all occurences of ' and \ in here.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-02 19:22:17 +07:00
d0cf20cc51
Merge pull request #26792 from nextcloud/user-delete-cleanup-files
...
better cleanup of user files on user deletion
2021-06-02 17:02:00 +07:00
b29c3aa03f
Merge pull request #25658 from nextcloud/dav-respect-disallow-sharing-with-groups
...
Dav respect disallow sharing with groups
2021-06-01 12:07:29 +07:00
747325fc43
Set local domain for swiftmailer transport
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-05-31 15:04:00 +07:00
b0847abcc2
Rewrite requesttoken.spec.js with Jest
...
[Jest](https://jestjs.io/ ) is a test runner that focuses on simplicity.
It instruments babel to transform modules and test them.
Using Jest simplifies the existing configuration and allows dropping a
bunch of workarounds, as well as following the shared Babel
configuration for new code.
Signed-off-by: François Freitag <mail@franek.fr>
2021-05-30 10:44:34 +07:00
1c0d975654
Make dav respect disallowing sharing with groups
...
Closes #25390
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2021-05-26 11:19:59 +07:00
1b47886abb
Merge pull request #27035 from nextcloud/techdebt/26866/userscontroller-accountmanager-api
...
do not use private AccountManager in UsersController
2021-05-25 21:22:37 +07:00
726d01843e
Merge pull request #26600 from hosting-de/feature/occ-tags
...
Add commands to manage tags via OCC
2021-05-25 16:54:06 +07:00
847ed37afc
do not use private AccountManager in UsersController
...
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-25 14:35:38 +07:00
d606799ee2
Add commands to manage tags via OCC
...
list, add, delete, edit
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-05-25 11:29:32 +07:00
f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share
...
Add option to exclude groups from creating link shares
2021-05-21 15:35:39 +07:00
1627eb45bb
l10n: Fix test
2021-05-20 09:26:38 +07:00
35b910cf8e
Merge pull request #26322 from nextcloud/recent-search
...
Use file search for recent files and optimize getting share types
2021-05-18 09:44:08 +07:00
ee3dc57cbd
Merge pull request #26626 from J0WI/strict-security
...
Make Security module strict
2021-05-18 08:43:13 +07:00
0ab5b3e265
Merge pull request #26679 from nextcloud/bugfix/noid/fix-unauthorized-ocs-status-in-provisioning
...
Fix unauthorized OCS status in provisioning
2021-05-13 23:39:20 +07:00
b1dca57a1c
load share settings from the share manager in more places
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:28 +07:00
b6c6527705
Fix unauthorized OCS status in provisioning
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 08:16:07 +07:00
8413ed9475
allow to set valid scopes only in AccountProperty
...
the auto-fallback to v2-local is removed as well to react on wrong input
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 01:31:15 +07:00
6a5d89c1ac
Merge pull request #26758 from J0WI/more-strict
...
Some more strict_types
2021-04-28 09:28:19 +07:00
ed2d02d5f1
better cleanup of user files on user deletion
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-27 20:29:51 +07:00
99f0b10421
Merge pull request #26591 from nextcloud/techdebt/noid/less-ilogger
...
Less ILogger
2021-04-27 15:38:12 +07:00
48c50277a9
Merge pull request #26718 from nextcloud/bugfix/noid/fix-ratelimit-template
...
Fix ratelimit template
2021-04-27 15:18:02 +07:00
c52a026f55
Merge pull request #26572 from nextcloud/bugfix/noid/throw-401-when-authentication-is-provided-and-invalid
...
Throw "401 Unauthenticated" when authentication is provided but invalid
2021-04-27 14:37:28 +07:00
df47445c01
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +07:00
174f4dd043
Fix ratelimit template
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:55:34 +07:00
aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid
...
Validate the website field input to be a valid URL
2021-04-26 13:56:01 +07:00
8323cbb9e5
Use strict
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-26 12:45:12 +07:00
012f791c8f
Merge pull request #26375 from nextcloud/techdebt/noid/symfony-component-translation-pluralization-rules-is-deprecated
...
"Symfony\Component\Translation\PluralizationRules" is deprecated
2021-04-22 21:20:16 +07:00
d80cc76ee7
Validate the website field input to be a valid URL
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 16:34:13 +07:00
4ed296db9f
Fix Authentication test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 15:36:34 +07:00
3da956bcdc
Merge pull request #23529 from Simounet/feat/23397-settings-new-user-modal
...
Settings: new user row replaced by a modal
2021-04-21 16:38:46 +07:00
effb7dc8ba
set mimetype for objects uploaded to object storages
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-21 15:25:58 +07:00
45c3b2a478
Settings: new user row replaced by a modal
...
Signed-off-by: Simounet <contact@simounet.net>
2021-04-21 14:42:46 +07:00
0d5f4edc22
adjust tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-21 14:09:07 +07:00
d2ea068552
Merge pull request #26669 from nextcloud/nickvergessen-patch-1
...
Fix PHP CS
2021-04-21 14:07:17 +07:00
31d88209f7
Merge pull request #25991 from nextcloud/update-acceptance-tests-to-selenium3
2021-04-21 09:31:29 +07:00
2a11713337
Update CredentialsManagerTest.php
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-21 08:33:10 +07:00
9e8690d912
Merge pull request #26654 from nextcloud/bugfix/noid/fix-security-credentials-manager-test
...
Fix security credentials manager test
2021-04-20 22:03:52 +07:00
5ee9e1f784
Move 2FA registration to IBootstrap
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 21:01:16 +07:00
7f70f3e182
Fix support tests
...
2) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #0 (35, 15, 2, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist
3) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #1 (35, 45, 15, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist
4) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #2 (35, 45, 5, true)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist
5) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #3 (35, 45, 55, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist
Had to use the Database user backend, as using multiple interfaces is deprecated:
https://github.com/sebastianbergmann/phpunit/issues/3955
> This functionality should be deprecated as "having to use it" is almost always a symptom of bad design.
> More importantly, though, the support for the creation of test doubles that implement multiple interfaces
> resulted in code that is hard to maintain.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:36:15 +07:00
c6978bac80
Fix security credentials manager test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:04:24 +07:00
79ebc7f24c
Fix test by defining plurals
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:43 +07:00
5a514a9a41
Correctly replace all PHP placeholders with the parameters
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:05 +07:00
92ca49d21d
save a whitespace today
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 14:03:01 +07:00
f8d1ee5cfa
ignore mail shares of related remote share results
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 14:02:35 +07:00
ca7b37ce5a
Make Security module strict
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-19 17:31:12 +07:00
4b376a107b
Add automatic handling of "ElementNotInteractable" exceptions
...
In the WebDriver protocol, when a command fails because it can not
interact with the target element, an "element not interactable" error is
generated. It can be a transitive issue (for example, due to an
animation), so when the error is received the command should be tried
again, just like done, for example, with "ElementNotVisible" exceptions.
However, the last version of the "instaclick/php-webdriver" library
compatible with the Selenium Driver of Mink did not support yet that
WebDriver error. And even if Chrome is run using the old protocol an
unknown "element not interactable" error can be received anyway in some
cases. When an unknown error is received by the
"instaclick/php-webdriver" library it is thrown as a generic Exception
so, until the library can be updated, the message of generic exceptions
is checked and the command is retried if it matched.
For the time being "element not interactable" errors are handled like
"ElementNotVisible" exceptions; this may need to change once the error
is better understood.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-19 16:35:11 +07:00
751be29c73
Merge pull request #26555 from nextcloud/techdebt/noid/run-migrator-tests-on-OCI
...
Run migrator tests on OCI
2021-04-19 08:57:41 +07:00
9e1246eba5
Update acceptance tests to Selenium 3
...
The acceptance tests used the last Selenium 2 Docker container
available, which provides a rather old Firefox version (Firefox 47).
Nevertheless, despite some rendering issues, most things still worked as
expected due to the JavaScript files being built with support for older
browsers. However, now that support for Internet Explorer 11 and older
browsers will be dropped things could start to fail, so a newer browser
(and thus a newer Selenium version) should be used in the acceptance
tests.
Selenium has been standardized by the W3C, and the protocol to
communicate between the Selenium server and the browser has changed due
to that. Firefox >= 48 only supports the new W3C protocol, but the
Selenium driver for Mink does not support it yet.
The old protocol can still be used in recent Chromium/Chrome versions by
explicitly forcing it, so for the time being the acceptance tests will
need to be run on Chrome instead (although Firefox provides some
interesting features like the fake streams that would be needed to test
calls in Talk, so they should be moved again to Firefox once possible).
Finally, the default shm size of Docker is 64 MiB. This does not seem
enough to run newer Chrome releases and causes the browser to randomly
crash during the tests ("unknown error: session deleted because of page
crash" is shown in the logs). Due to this "disable-dev-shm-usage" needs
to be used so Chrome writes shared memory files into "/tmp" instead of
"/dev/shm" (the default shm size of Docker could have been increased
instead using "docker run --shm-size...", but that seems to be
problematic when the container is run in current Drone releases).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-16 20:00:15 +07:00
14b85f4eec
Replace carriage return with WebDriver "ENTER" constant
...
When the value is set in some input fields a carriage return was sent to
simulate pressing the enter key and thus confirming the input. However,
different browsers use different keys (Firefox uses "\r", but Chrome
uses "\n"), so the carriage return was replaced with the WebDriver
"ENTER" constant which is common to both browsers.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-16 20:00:15 +07:00
38b88422a8
Do not send "enter" key when not needed
...
Sending the "enter" key is not needed in those input fields that auto
save while the user is typing or when the focus is lost (which since
version 1.4.0 the Selenium driver for Mink is automatically done after
setting the value).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-16 20:00:15 +07:00
808e589035
Allow registering NotifierServices trough IBootstrap
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +07:00
1670d00452
Integer 0 is not stored as Null and therefor works
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-16 09:57:27 +07:00
8b4ecdcc88
Test that oracle throws on EmptyValues in a NotNull columns
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-16 09:57:27 +07:00
e88bad4b0a
Run migrator tests on OCI
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-16 09:57:27 +07:00
b5ffca00f7
Fix unit test
...
* Fix namespace
* Fix test
Was broken after https://github.com/nextcloud/server/pull/26529
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 09:47:52 +07:00
af61486aea
Separate settings for remote share expiration
...
Added separate settings for default and enforced expiration date for
remote shares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +07:00
789bb0d0ac
Merge pull request #26266 from nextcloud/future-proof-networking
...
Improve networking checks
2021-04-12 12:42:33 +07:00
e5a4236e68
Increase subnet matcher
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-07 12:28:59 +07:00
4b4971ab52
Merge pull request #24966 from nextcloud/jknockaert-patch-1
...
avoid fread on directories and unencrypted files
2021-04-06 13:45:10 +07:00
9dab851931
Adjust test
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:37:47 +07:00
5f3abffe6f
Improve networking checks
...
Whilst we currently state that SSRF is generally outside of our threat model, this is something where we should invest to improve this.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:37:47 +07:00
5fb909faa5
Merge pull request #24055 from nextcloud/bugfix/noid/enfore-no-notnull-for-boolean-to-store-false
...
Enforce no notnull for boolean to store false
2021-04-01 18:30:26 +07:00
37591f05dc
Get the parent directory before creating a file from a template
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:48:21 +07:00
f9d4fa2d38
Rename the method to match what it does
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:18 +07:00
3696ef5b96
Don't allow Notnull for boolean columns
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:17 +07:00
2212a67fbc
Merge pull request #25961 from nextcloud/enh/events/2fa_provider
...
Add real events for enabled 2fa providers for users
2021-03-30 23:13:36 +07:00
f3738eeff7
Merge pull request #25280 from nextcloud/explicit-file-permissions
...
Set umask before operations that create local files
2021-03-30 21:55:50 +07:00
be3ae9a44b
gracefully handle deleteFromSelf when share is already gone
...
- handling race conditions
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-30 12:59:40 +07:00
f216b9307a
Update Mink from 1.7.1 to 1.8.1 in acceptance tests
...
Since version 1.8.0 of Mink "Mink::getSession()" no longer starts the
session automatically (see https://github.com/minkphp/Mink/pull/705 ), so
it now needs to be explicitly started.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-30 08:35:16 +07:00
7625a87412
Update Selenium driver for Mink from 1.3.1 to 1.4.0 in acceptance tests
...
Since version 1.4.0 the Selenium driver for Mink uses again the element
on which the value was set (see
https://github.com/minkphp/MinkSelenium2Driver/pull/286 ). When creating
a new folder or renaming one sending a new line ("\r") caused the
element on which the value was set to be removed, so the element was no
longer attached to the DOM when the driver tried to use it again, and
thus a "StaleElementReference" exception was thrown.
Due to this now it is needed to explicitly click the confirm button when
creating a new folder. In the case of the renaming, on the other hand,
nothing else besides not sending the new line is needed, as the Selenium
driver now unfocuses the element (that is why it uses again the element
after setting the value) which triggers the renaming.
Besides that, the Selenium driver for Mink uses a library to simulate
certain events, bitovi/syn. In version 1.4.0 that library was updated to
version 0.0.3, which seems to somehow break pressing the "escape" key.
Due to this now the sharing menu has to be closed by pressing "enter" on
the share menu button instead.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-30 08:35:16 +07:00
223b36e851
Update Behat from 3.7.0 to 3.8.1 in acceptance tests
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-30 08:35:16 +07:00
b53f49b940
Update PHPUnit from 4.X to 6.X in acceptance tests
...
The PHPUnit update also required an update of "symfony/yaml", so besides
the changes needed for PHPUnit the "behat.yml" file also had to be
adjusted.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-30 08:35:15 +07:00
8d3fdf24c8
Merge pull request #26353 from nextcloud/techdebt/noid/make-testcase-class-compatible-with-phpunit-9.5
...
Make Testcase class compatible with phpunit-9.5
2021-03-29 10:47:37 +07:00
cd35a5c71d
Make Testcase class compatible with phpunit-9.5
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-29 09:43:08 +07:00
d58d6199d9
Cleaner normalizePath regex
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-03-27 21:29:28 +07:00
5f468c0248
Cleaner removePassword regex
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-03-27 18:42:58 +07:00
cc54f718f5
Add known user check in avatar when v2-private scope
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:10 +07:00
bb008be28a
Added PlaceholderAvatar with own cached images
...
When avatar scope is private, the PlaceholderAvatar is used to deliver a
placeholder avatar based on the user's initials.
This was implemented as a separate class for now to avoid messing with
the existing UserAvatar implementation and its generated vs
non-generated logic.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +07:00
b73df5846c
Add property scope tests for AccountManager
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +07:00
278a73789e
Map old account scope properties to new names
...
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +07:00
b81a1c1bdb
Add new v2-private account scope
...
Added new v2-private account manager scope that restricts the scope
further by excluding public link access.
Avatars with v2-private account scope are now showing the guest avatar
instead of the real avatar.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:05 +07:00
9fd29173cf
Merge pull request #26281 from hosting-de/fix/email
...
Change my email address
2021-03-26 09:59:35 +07:00
ab48d5e8cb
Cleanup unneeded code around database.xml
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-24 22:15:44 +07:00
e9ca59ef0a
Change my email address
...
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-24 15:13:56 +07:00
39a6d99526
Fix language codes test result order
...
Fixes issue with Oracle by enforcing the order of the results to check.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 10:26:06 +07:00
8b92776be4
Bring back forgotten tests
...
Remove "ocs-provider" test folder reference as it doesn't exist any
more.
Added back "Test" test subdir and fixed the tests inside.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 09:07:54 +07:00
95e03fba2d
Fix more controller tests in Core subdir
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 09:02:19 +07:00
9b8ca1697a
Fix more tests in the Core subdir
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-24 08:48:28 +07:00
c467f64848
Fix core tests command for app enabling/disabling
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-23 20:40:28 +07:00
e210e8e35a
Fix casing of core test folder
...
It seems Phpunit < 9 was case insensitive.
Fixed the phpunit config to target the correct name for the "Core" test
directory.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-23 18:12:46 +07:00
e5dc1a8085
Set umask before operations that create local files
...
this solves issues where "other php stuff" is messing with the umask
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 14:52:31 +07:00
1c074e7602
Merge pull request #26198 from nextcloud/unified-search-node
...
Handle limit offset and sorting in files search
2021-03-22 21:48:51 +07:00
268acd301d
Merge pull request #25529 from nextcloud/fix-non-lgc-glyphs-in-avatars-and-txt-file-previews
...
Fix non LGC glyphs in avatars and txt file previews
2021-03-22 21:06:22 +07:00
3c5cf825b3
Add real events for enabled 2fa providers for users
...
* Shiny new events
* Listener to still emit the old event
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-22 20:57:10 +07:00
15767643f2
Fix sharebymail tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:47 +07:00
f99876997a
Remove duplicated query for email shares
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 06:50:47 +07:00
bfe3712372
handle ordering in folder search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 16:07:54 +07:00
76170a58eb
Log and continue when failing to update encryption keys during for individual files
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-19 14:12:07 +07:00
feed42dd6d
folder filtering in sql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 13:41:00 +07:00
1286848731
Merge pull request #23718 from nextcloud/already-shared-error-message
...
expand 'path is already shared' error message
2021-03-19 13:39:22 +07:00
de713967c0
cleanup fileinfo creation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 13:35:37 +07:00
7bf5adb1fa
Merge pull request #26200 from nextcloud/bugfix/26197/fix-expiration-validation-confusion
...
Update user share must use correct expiration validation
2021-03-19 10:51:21 +07:00
bd229e7548
handle limit and offset in folder file search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 17:38:31 +07:00
50e374c12f
only require user to be set in a query that handles tags
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 17:16:28 +07:00
a9e3d2a10f
Update user share must use correct expiration validation
...
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.
To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-18 17:12:28 +07:00
9e3775618b
log full expection during repair step
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:17 +07:00
a2f3077ee8
Skip db migration simulation for core schema changes
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-17 21:08:22 +07:00
0d46fafd41
Merge pull request #26161 from nextcloud/bugfix/noid/improve-matching-of-phonebook-searches
...
Improve search results when only phonebook-matches can we autocompleted
2021-03-17 15:22:03 +07:00
cf434d5107
Also limit to user group in case enumeration is enabled for groups and phonenumbers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 11:20:30 +07:00
9a189bc710
Improve search results when only phonebook-matches can we autocompleted
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 09:51:31 +07:00
e559afb8d4
Merge pull request #25136 from nextcloud/cachejail-search-filter
...
do cachejail search filtering in sql
2021-03-15 17:45:30 +07:00
a550649708
expand 'path is already shared' error message
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 15:55:08 +07:00
32551b9ff7
Merge pull request #25722 from nextcloud/objectstore-copy-cross
...
apply object store copy optimization when 'cross storage' copy is wit…
2021-03-12 16:10:18 +07:00
a609074c18
Fix Test class name
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-12 08:53:43 +07:00
cf8f9c16df
Change label also in the acceptance tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 18:55:01 +07:00
5b53b6f977
Add a setting to restrict returning a full match unless in phonebook or same group
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:25:57 +07:00
236aa194e2
Restrict autocompletion also based on the phonebook known users
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +07:00
c87b1a50d9
apply object store copy optimization when 'cross storage' copy is within the same object store
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-09 20:31:27 +07:00
30e096f3f5
Allow overwriting isAuthenticated
...
* Some implementations might check for different things
* IT will not change how the current ones work
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-09 09:17:30 +07:00
2ddf3c9df0
Merge pull request #25990 from nextcloud/do-not-try-to-add-an-existing-user-again-in-acceptance-tests
...
Do not try to add an existing user again in acceptance tests
2021-03-08 10:18:46 +07:00
615721df82
Merge pull request #25925 from nextcloud/techdept/psalm/ActionProviderStore
...
Pimp ActionProviderStore
2021-03-08 09:20:45 +07:00
c51c3c771f
Remove unneeded steps to add already existing user
...
User "user1" is added when installing and configuring the server, so it
is already added in all tests.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-07 18:34:10 +07:00
0e6401933b
Fix acceptance test for searching just added users in contacts menu
...
User "user1" is added when installing and configuring the server, so it
is already added in all tests. As the test verifies that just added
users can be searched in the contacts menu a new user should be actually
added.
The test did not fail because it assumed that "user1" did not exist and
just checked that it existed after "adding" it, but not whether adding
it failed.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-07 18:27:45 +07:00
ee1f8104a0
Find directly the label instead of falling back to it
...
The input element is always hidden, so the check always ended falling
back to the label. Moreover, the label is the element that the user
interacts with, so it must be the one used.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:43 +07:00
7b6946d2d2
Assert also element visibility instead of just finding it
...
Although if the element could not be found an exception would be thrown
and the test aborted if an element is in the DOM but hidden it would be
found and the test would pass.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:43 +07:00
78faf0105d
Add explicit locator for "Enable all" bundle button
...
Instead of looking for the bundle button and then checking its value now
the expected value is included in the locator and the button is checked
similarly to other elements.
No "Disable all" locator was added as it was not currently needed
anywhere.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:43 +07:00
f87473e410
Find elements through the actor rather than the driver
...
"Actor::find" is a more robust way to look for elements, as it handles
some exceptions that may be thrown. Therefore, even if the elements are
not actually used and it is only checked whether they exist or not using
the actor is the preferred way when possible (and it also makes it
consistent with the rest of the acceptance tests).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:43 +07:00
6d145ea54a
Add locator for apps list
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:42 +07:00
4c23d24277
Fix identation
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:42 +07:00
bc084070c8
Fix delete user acceptance test
...
Adding some missing asserts showed that the "delete user" acceptance
test was silently failing, as the deletion was not being confirmed in
the dialog and thus the user was not being deleted.
The dialog button contains a single quote ("user0's"), so the XPath
expression had to be adjusted (it seems that it is not possible to
escape a single quote in a string enclosed in single quotes in XPath
1.0).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:29:54 +07:00
d5586ec437
Verify WaitFor::element... results with an assertion
...
WaitFor::element... calls only perform the waiting and return whether
the condition succeeded or not, but that result needs to be explicitly
checked to prevent further steps from being executed if the wait failed.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-05 22:06:05 +07:00
caa2246568
Add missing waits when finding elements in the acceptance tests
...
As no timeout was specified the elements were tried to be found just
once. This caused the steps to fail if the elements did not appear yet
in the page when they were tried to be found.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-05 22:06:05 +07:00
54cffefed4
Merge pull request #25660 from hosting-de/feature/add-backend-list-groups
...
Show group backends in occ group:list --info and group:info
2021-03-05 08:49:43 +07:00
f04a2ce19f
Pimp ActionProviderStore
...
* Fix paradoxale condition
* Add types
* Move away from ILogger
Makes psalm happy, and thus me happy
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 12:29:49 +07:00
7b9ca4f7c2
Add some typing to SharedStorage
...
Makes psalm a bit more happy.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 10:49:42 +07:00
5325c3002c
Merge pull request #25917 from nextcloud/techdept/kill_deprecated/ocp_api
...
Remove deprecated \OCP\API
2021-03-03 21:57:34 +07:00
cc744740b7
Remove deprecated \OCP\API
...
Time to remove this forgood now.
Remaining constant moved over
The world is a tiny bit better
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 20:54:32 +07:00
68ec18323d
Fix types in the Group Manager
...
Psalm found an issue. However the issue found was because of lying
docblocks. Fixed those and did some typing to make it all better.
For #25839
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 14:52:47 +07:00
ee06780029
Include additional scripts in Noto fonts
...
Generated avatars as well as text file previews are rendered using the
"core/fonts/NotoSans-Regular.ttf" font. The file was the standard hinted
"NotoSans-Regular.ttf" file from https://www.google.com/get/noto/ .
However that file does not cover some non LGC (Latin, Greek, Cyrillic)
scripts, like Arabic, Devanagari or Hebrew, to name a few.
Markdown file previews also use "core/fonts/NotoSans-Bold.ttf", which is
in the same situation as the regular one.
Due to limitations in the TTF format it is not possible to provide a
single file for each style that includes all Noto fonts. However, it is
possible to add more scripts to the standard "NotoSans-Regular.ttf" and
"NotoSans-Bold.ttf" files (although no CJK (Chinese, Japanese, Korean)
glyph can be included due to the aforementioned limitations).
This commit replaces the standard files with an extended version created
using the Noto Tools. The build script (as well as a patch for the Noto
Tools) is also included for reference and to be able to update the font
files in the future if needed.
Due to the additional scripts added the font files are now much larger,
although this does not seem to increase the time spent rendering LGC
scripts.
Note that the file for the bold style still contains less scripts than
the regular one, as not all scripts supported by Noto have a bold
weight.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-01 19:15:01 +07:00
2796ef80ff
Show group backends in occ group:list --info and group:info
...
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-01 16:02:08 +07:00
5026d2cca1
Merge pull request #25086 from nextcloud/dependabot/composer/nextcloud/coding-standard-0.5.0
...
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
2021-02-18 14:05:54 +07:00
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +07:00
6ed4aaeeea
Send emails on password reset to the displayname
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-18 12:38:43 +07:00
644e6df02e
Merge pull request #25440 from nextcloud/bugfix/noid/cache-the-user-backend-info-for-30s
...
Cache the user backend info for 5mins
2021-02-17 08:56:55 +07:00
b794fadbce
Merge pull request #25575 from k00ni/pr/add-tests-for-LoginFlowV2Service
...
Add tests for \OC\Core\Service\LoginFlowV2Service
2021-02-15 12:22:39 +07:00
645f83121e
Cache the user backend info for 300s
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-15 10:36:08 +07:00
24d4c3eeab
Merge pull request #25577 from nextcloud/enhancement/app-code-checker-noop
...
Make the app code checker a NOOP
2021-02-13 15:51:41 +07:00
330315f03e
refined name of getOpenSSLEncryptedAndPrivateKey
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-12 13:01:37 +07:00
0bc49d67cd
added unit tests for LoginFlowV2Service::createTokens
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-12 12:57:24 +07:00
883848b58a
Micro-optimize validation of empty email addresses
...
Then we don't have to construct any validators.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 15:15:38 +07:00
e618ea83b5
Make the app code checker a NOOP
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 11:46:02 +07:00
c755165dd4
added unit tests for LoginFlowV2Service::flowDone
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 10:45:47 +07:00
d5dea10517
Merge pull request #25378 from nextcloud/bugfix/noid/mention-match-improvements
...
Improve mention matches
2021-02-11 10:33:15 +07:00
d60dd8a208
added unit tests for LoginFlowV2Service::startLoginFlow
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 09:56:09 +07:00
f29748a5e1
added unit tests for LoginFlowV2Service::getByLoginToken
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 09:49:39 +07:00
b0a2278a7e
added unit tests for LoginFlowV2Service::poll
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 09:38:29 +07:00
7bacd710a1
Merge pull request #25460 from nextcloud/fix/apppassword/always_renew
...
Always renew apppasswords on login
2021-02-10 21:09:20 +07:00
cd457cc68b
Always renew apppasswords on login
...
Else you can end up that you renewed your password (LDAP for example).
But they still don't work because you did not use them before you logged
in.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 19:02:37 +07:00
2f26ff40e9
Merge pull request #25359 from nextcloud/enhancement/typed-service-registration
...
Type the service registration
2021-02-10 15:31:42 +07:00
aabd73912e
Type the service registration
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 09:44:24 +07:00
e4ca0c9fa0
Merge pull request #25548 from k00ni/pr/add-tests-for-LoginFlowV2Credentials
...
Added tests for OC\Core\Data\LoginFlowV2Credentials
2021-02-09 21:37:37 +07:00
a50c615d37
simplified tests
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:48:37 +07:00
a28705064b
fixed coding style issue
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:40:19 +07:00
b38a619212
added tests for OC\Core\Data\LoginFlowV2Credentials
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:25:37 +07:00
abc61a9f63
Fix the legacy dispatcher argument order
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 10:47:14 +07:00
86109f77e0
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +07:00
f6ddda8dad
Test the symfony adapter
...
To prevent regression in the future.
And make sure we always return an object …
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-05 12:14:47 +07:00
b68c3a5836
Add test for dbal exception wrapping
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-02-03 19:43:52 +07:00
d4a45b4cac
test: adjust expectation
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 19:32:12 +07:00
558f062ca6
add repair job for unencoded calendars
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 17:29:10 +07:00
7d9dceb1af
Add negative version comparison test for version suffixes
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-27 16:01:26 +07:00
b4f71ccf4d
Fix app fetcher php comparison to allow wider ranges
...
When app app specifies php 7.4 as upper limit we have to allow the
installation on php>7.4.0. The previous version check didn't do that.
This adjusts the regexes to discard any irrelevant suffix after the
three version numbers so that we can use more fine granular checks than
php's version_compare can do out of the box, like for php 7.4 we only
compare the major and minor version numbers and ignore the patch level.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-26 16:35:43 +07:00
e511a539b7
adjust tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:55:38 +07:00
5ae0be08b4
fix search in nested jails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:54 +07:00
27f9df2e87
fix cachjail searching for root
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:50 +07:00
a44aab11f7
do cachejail search filtering in sql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:46 +07:00
99d525eb36
Convert 2FA token type to string
...
The IConfig service is documented to handle its data as strings, hence
this changes the code a bit to ensure we store keys as string and
convert them back when reading.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 14:09:37 +07:00
d84e1f1951
Re-use fetched dependencies in lib/base.php
...
Reduces calls to DI container by reusing already fetched dependencies.
For status.php it went from 355 to 344.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-20 21:55:16 +07:00
0893bba369
Merge pull request #25153 from nextcloud/bugfix/noid/force-signature-verification-on-occ
...
Force signature verification of apps on occ
2021-01-19 09:35:52 +07:00
90c3013d40
Cleanup the constructor
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:50 +07:00
d6a1d8d3a1
Add "composer.lock" for acceptance tests to git
...
As "composer.lock" was not versioned the dependencies had to be resolved
everytime that the acceptance tests run, which took some precious time.
Besides that the dependency versions were also tightened for better
control.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-01-17 16:44:32 +07:00
f9ab7575e7
Merge pull request #25036 from nextcloud/fix/noid/limitied-allowed-items-db-in_2
...
respect DB restrictions on number of arguments in statements and queries
2021-01-14 11:36:42 +07:00
9b58a027e3
Allow installing/updating of apps again
...
The Guzzle API changed. We shall now use sink
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-12 10:51:41 +07:00
7cdc7adf59
Merge pull request #25038 from nextcloud/bugfix/noid/install-mysql8-with-php8
...
Don't try a transaction for the migrator on MySQL
2021-01-11 18:07:11 +07:00
2d34ca4143
Only rollback when not MySQL
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-11 16:11:02 +07:00
f9484d15cb
DB: warn on parameter number constraints
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-11 13:43:34 +07:00
c3cb288268
Bump scssphp/scssphp from 1.0.3 to 1.4.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-11 12:41:25 +07:00
f0c6cfde3a
Rollback failed transactions in TestCase.php to not break followup tests
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +07:00
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +07:00
261966ace5
Update EncryptionTest.php
2021-01-05 21:45:50 +07:00
664e74a82e
2nd attempt to fix tests
2021-01-05 20:41:02 +07:00
87c640193b
attemtp to fix test
2021-01-05 19:09:16 +07:00
98560c80ea
Properly handle result when copying with failure and throw in tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 09:20:35 +07:00
ee842f1c43
Fix writeStream mocking
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 09:20:35 +07:00
1bb81f8f11
jsunit: Remove warnings during test runs
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-29 08:42:34 +07:00
c7a320d880
jsunit: Run jsunit with chromium/puppeteer on github actions
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-29 08:42:27 +07:00
b981cb0718
Merge pull request #19942 from ACTom/add-mindmap-icon
...
Add mindmap type file icon
2020-12-28 10:13:38 +07:00
d9db6ae84e
Readd test getOnlyDefaultAliases()
...
Signed-off-by: ACTom <i@actom.me>
2020-12-28 13:59:10 +07:00
e0bafb7475
deleteChildren only returns array
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2020-12-23 11:00:47 +07:00
f37e150d1c
Merge pull request #24702 from nextcloud/enhancement/well-known-handler-api
...
Add well known handlers API
2020-12-18 13:34:04 +07:00
6995223b1e
Add well known handlers API
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 13:13:05 +07:00
d8ad4ef6b5
use a consistent default value for sharing.maxAutocompleteResults
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-15 11:53:39 +07:00
131fcac91e
Show unique displayname context in the sharing input
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:14:59 +07:00
ccd5ca5476
Merge pull request #23044 from nextcloud/migration-10.5
...
Handle owncloud migration to latest release
2020-12-10 14:32:13 +07:00
3c693db0ca
Merge pull request #24605 from nextcloud/enh/share-deck
...
Add deck share provider support
2020-12-10 14:30:08 +07:00
a0444bc69c
Merge pull request #24247 from nextcloud/bugfix/noid/ocm-providerId-string
2020-12-09 17:25:59 +07:00
85e6cbc87a
Extend dummy factory in tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 13:20:25 +07:00
9fe94f282f
Readd repair steps that are relevant when migrating from ownCloud
...
This reverts commit d9b1492e03
2020-12-09 12:13:35 +07:00
d04b7cf03d
Skip the test if Imagick is misconfigured
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-09 09:07:20 +07:00
86a3b7e7bf
Merge pull request #24486 from nextcloud/feature/noid/phone-number-validation
...
Phone number validation and search
2020-12-08 17:05:38 +07:00
4f927721b2
Add temporary test for migrating int to string
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-08 16:06:13 +07:00
6a7e849090
php cs fix
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +07:00
c02e6fcae2
fix appconfig tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +07:00
b668850aa1
Fix filesystem tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +07:00
a25b46f494
Make sure we can also run with escapedshell args
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +07:00
48679ae39f
Make sure we just check for the keys
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +07:00
d690f90928
Do not run image tests on php8
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +07:00
1670eabdb3
Do not run on php8
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +07:00
6b7731a852
Move to new phpunit
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +07:00
988ce1374c
Don't check on php8
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +07:00
c084008df2
Avatar fixes
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +07:00
9317e0f0f0
Fix test traits for phpunit 9
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +07:00
f0ca76aefb
Add and fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +07:00
da9462b482
Make code strict
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +07:00
3d315ec64f
Fix vsprint parameter
...
%2\$; is not valid. On php7 this is just ignored but on php8 it gives an
error. %2\$s; works.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-03 08:25:11 +07:00
c0a05c0412
Add notification for user limit
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 15:20:03 +07:00
d87705a894
Allow subscription to indicate that a userlimit is reached
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 15:20:03 +07:00
83a75c670b
Replace static call to Share::unshare with ShareManager->deleteShare in tests
...
And then cleanup all the code that is dead then...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-30 09:51:18 +07:00
2172432420
Merge pull request #23912 from nextcloud/objectstore-copy
...
use in objectstore copy
2020-11-25 16:09:26 +07:00
9d4848e863
use in objectstore copy
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-24 15:16:58 +07:00
16a78f535a
set the display name of federated sharees from addressbook
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-24 11:30:11 +07:00
efe644137d
[encryption] Remove dependency fetching inside the constructor and move them to method call parameters
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-22 22:35:02 +07:00
1b613c84e9
Merge pull request #24007 from nextcloud/select-distinct-multiple
...
allow selecting multiple columns with SELECT DISTINCT
2020-11-19 22:39:01 +07:00
d602aa1825
Merge pull request #24135 from medical-cloud/fix/23357-nextcloud-logo-in-email-notifications-is-misaligned-in-version-20
...
Fix nextcloud logo in email notifications misalignment
2020-11-19 10:48:18 +07:00
87ec4a0da3
Fix #23357
...
Signed-off-by: medcloud <42641918+medcloud@users.noreply.github.com>
2020-11-18 22:29:02 +07:00
66013f906d
Merge pull request #24189 from nextcloud/enh/csp/frame-ancestors
...
Set frame-ancestors to none if none are filled
2020-11-18 11:29:28 +07:00
9163790b7c
Set frame-ancestors to none if none are filled
...
frame-ancestors doesn't fall back to default-src. So when we apply a
very restricted CSP we should make sure to set it to 'none' and not
leave it empty.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-18 10:13:36 +07:00
72a9c35be3
Remove some IRouter methods
...
This is not the end. IRouter needs to burn.
But it is a start.
🎵 we didn't start the fire 🎵
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-17 14:08:20 +07:00
a61a757b85
allow selecting multiple columns with SELECT DISTINCT
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-16 15:45:17 +07:00
4d3cb1533e
Add unit tests for "validateExpirationDateInternal"
...
They were copied and adjusted as needed from the tests for
"validateExpirationDate".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 08:54:19 +07:00
baaaacd650
Add explicit time to test date for clarity
...
This shows in a clearer way that the expected expiration date is the
original one, but without time.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:34 +07:00
578b57837a
Add unit test for expiration date with date and with default
...
This adds back what was being actually tested in the unit test fixed in
the previous commit.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:34 +07:00
70018ddabf
Fix unit test for expiration date without date but with default
...
The expiration date was explicitly given, so it was not testing what it
should. Moreover, "link_defaultExpDays" needs to be mapped when testing
the default value (even if it will just fallback to the value of
"shareapi_expire_after_n_days").
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:32 +07:00
3a53c2b6e5
Fix unit test method name
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:31 +07:00
e997f0fa46
Fix unit test for verifying enforced valid expiration date.
...
The enforced expiration date was not actually enabled, as for that
"shareapi_default_expire_date" needs to be explicitly set to "yes".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:31 +07:00
8f1fff40e8
Fix unit test for verifying enforced expire date too far in the future
...
The test should fail if no exception was thrown, and no exception was
thrown due to a missing configuration parameter. However, the use of
"addToAssertionCount(1)" made the test pass even if no exception was
thrown and, therefore, to silently fail.
Now the missing configuration parameter was added and the test will fail
if the expected exception is not thrown.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:29 +07:00
ec92e82571
Add unit tests to enforce a relaxed default share expiration date
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:28 +07:00
4dbeab5cff
Remove wrong and misleading comment
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:26 +07:00
72f51422ec
Remove extra spaces
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:25 +07:00
7cfa2701b9
Fix typo in variable name
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:23 +07:00
Marcel Klehr
Bennet Becker
Bennet Becker
Simon L
Daniel Kesselberg
Stanimir Bozhilov
Vincent Petry
Christoph Wurst
Artur Neumann
Christopher Ng
Joas Schilling
Julius Härtl
Julien Veyssier
Côme Chilliet
Côme Chilliet
J0WI
John Molakvoæ
Anna Larch
Carl Schwan
Joas Schilling
John Molakvoæ
Git'Fellow
Christoph Wurst
Robin Appelman
Varun Patil
blizzz
Roeland Jago Douma
Andy Xheli
Stanimir Bozhilov
Daniel Calviño Sánchez
Louis
Simon Leiner
Julien Veyssier
Vitor Mattos
Thomas Citharel
Louis Chemineau
Richard Steinmetz
Pytal
Cyrille Bollu
Kirill Popov
Maxence Lange
Joachim Bauch
Jonas Meurer
Naoto Kobayashi
acsfer
Lukas Reschke
Bernd Rederlechner
Daniel Rudolf
Gary Kim
pjft
François Freitag
Morris Jobke
Johannes Leuker
Valdnet
Roeland Jago Douma
Simounet
dependabot-preview[bot]
Konrad Abicht
Jasper Knockaert
ACTom
medcloud