sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add missing waits when finding elements in the acceptance tests 

As no timeout was specified the elements were tried to be found just
once. This caused the steps to fail if the elements did not appear yet
in the page when they were tried to be found.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
pull/25975/head
Daniel Calviño Sánchez 2021-01-17 17:39:35 +07:00
parent b6e434f02a
commit caa2246568
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/acceptance/features/bootstrap/AppSettingsContext.php
Unescape Escape View File

@ -74,7 +74,7 @@ class AppSettingsContext implements Context, ActorAwareInterface {
* @Given I open the settings
*/
public function iOpenTheSettings() {
$this->actor->find(self::appSettingsOpenButton())->click();
$this->actor->find(self::appSettingsOpenButton(), 10)->click();
}
/**
@ -84,11 +84,11 @@ class AppSettingsContext implements Context, ActorAwareInterface {
$locator = self::CheckboxInTheSettings($id);
// If locator is not visible, fallback to label
if (!$this->actor->find(self::CheckboxInTheSettings($id))->isVisible()) {
if (!$this->actor->find(self::CheckboxInTheSettings($id), 10)->isVisible()) {
$locator = self::checkboxLabelInTheSettings($id);
}
$this->actor->find($locator)->click();
$this->actor->find($locator, 10)->click();
}
/**

2
tests/acceptance/features/bootstrap/AppsManagementContext.php
Unescape Escape View File

@ -209,7 +209,7 @@ class AppsManagementContext implements Context, ActorAwareInterface {
* @Given /^I see that the "([^"]*)" is disabled$/
*/
public function iSeeThatTheIsDisabled($bundle) {
PHPUnit\Framework\Assert::assertEquals('Enable all', $this->actor->find(self::bundleButton($bundle))->getValue());
PHPUnit\Framework\Assert::assertEquals('Enable all', $this->actor->find(self::bundleButton($bundle), 2)->getValue());
}
/**

6
tests/acceptance/features/bootstrap/UsersSettingsContext.php
Unescape Escape View File

@ -176,21 +176,21 @@ class UsersSettingsContext implements Context, ActorAwareInterface {
* @When I click the New user button
*/
public function iClickTheNewUserButton() {
$this->actor->find(self::newUserButton())->click();
$this->actor->find(self::newUserButton(), 10)->click();
}
/**
* @When I click the :action action in the :user actions menu
*/
public function iClickTheAction($action, $user) {
$this->actor->find(self::theAction($action, $user))->click();
$this->actor->find(self::theAction($action, $user), 10)->click();
}
/**
* @When I open the actions menu for the user :user
*/
public function iOpenTheActionsMenuOf($user) {
$this->actor->find(self::actionsMenuOf($user))->click();
$this->actor->find(self::actionsMenuOf($user), 10)->click();
}
/**