70ef0a8db7
fix: Remove calls to legacy callers in tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-16 11:47:38 +07:00
0243d23b8c
fix(tests): Remove calls to removed getMountProviderCollection from tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-16 10:49:03 +07:00
e4ed062d68
fix(RouteParser): bail out if method name contains hashtag
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 13:57:14 +07:00
63ba61487b
chore(AppFramework): Remove unused RouteConfig class and migrate tests to RouteParser
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 13:57:14 +07:00
cac44fd924
Merge pull request #52822 from nextcloud/feat/mime-names
2025-05-15 11:41:12 +07:00
5f9117b939
test: Fix coding standards
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 08:48:13 +07:00
437f380fd9
test: Fix most tests/lib/DB/QueryBuilder
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 08:25:01 +07:00
3e7db013c1
test: Fix non-static data providers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 08:25:01 +07:00
9621e451ba
test: Fix tests/lib/Files
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 08:25:00 +07:00
e0a1c84ebb
test: Make Archive test order independent
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 08:25:00 +07:00
2c74609e07
test: Fix tests/lib/[S-Z]*
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 08:24:59 +07:00
f474b5b3a9
test: Fix tests/lib/Security/
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 08:24:59 +07:00
c5cd7ef9b9
test: Fix tests/lib/[H-N]*
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 08:24:59 +07:00
3cc4410273
test: Fix tests/lib/[C-G]*
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 08:24:57 +07:00
720ab52e07
test: Fix tests/lib/App*
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 08:21:24 +07:00
5283e9a5e2
test: Cleanup tests/lib/Files/*
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 08:21:22 +07:00
53b116b8a5
test: Remove more withConsecutive
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 08:18:26 +07:00
24bc1d606e
feat(core): add human readable mimes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-14 22:55:06 +07:00
ae63945736
Merge pull request #52544 from nextcloud/chore/drop-deprecated-account-scopes
2025-05-14 22:15:01 +07:00
1b72ddd8c8
Merge pull request #52684 from nextcloud/bugfix/noid/last-insert-id-when-reconnecting
2025-05-14 19:44:30 +07:00
2cd491f491
Merge pull request #48560 from nextcloud/fix/migrate-encryption-away-from-hooks
...
feat(encryption): Migrate from hooks to events
2025-05-14 19:25:51 +07:00
1b273b8c2c
chore(IAccountManager): remove deprecated visibility constants
...
Those constants are not used anywhere anymore and are deprecated for
more than ten versions. So its time to cleanup the interface.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-14 19:15:24 +07:00
14f79829f3
Merge pull request #52775 from nextcloud/nested-jail-root
...
fix unjailedroot of nested jails if there are other wrappers in between
2025-05-14 17:36:55 +07:00
a53e15c971
fix: log requests exceeding the rate limiting
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-14 12:23:40 +07:00
7304756e03
test: Sort the reactions before comparing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-14 11:42:52 +07:00
a79b5dea7c
fix(encryption): Improve Update class and event listenening
...
to avoid back&forth between path and Node object
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
e35a8ed063
fix(tests): Disable encryption wrapper when it makes sense
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
21233b7e17
fix(tests): Remove Encryption disabling in ViewTest to avoid side effects
...
Adapt tests a bit to make them pass with Encryption wrapper registered
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
38f341c179
fix(tests): Unregister encryption modules in ViewTest to avoid side effects
...
It was clearing the hooks with the same results before
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
536ccf144c
feat(encryption): Migrate from hooks to events
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
fb615ef9f8
Merge pull request #52688 from nextcloud/feat/ocp-sanitize-filenames
...
feat(FilenameValidator): allow to sanitize filenames
2025-05-13 23:35:43 +07:00
0001c22668
test: add test for nested cache jail unjailedroot
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-13 18:29:00 +07:00
6cf1870322
feat(FilenameValidator): allow to sanitize filenames
...
Share the filename sanitizing with the OCP filename validator.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-13 14:14:17 +07:00
ebd80bc142
fix: check if properties exist before using them
...
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-05-12 15:44:07 +07:00
648745d524
Merge pull request #52634 from nextcloud/perf/share20/get-all-shares-in-folder
2025-05-08 16:24:21 +07:00
ae16a28758
perf(Share20): Add interface to query all shares in a folder without filtering by user
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-08 15:29:40 +07:00
1c518a291d
Merge pull request #52360 from nextcloud/artonge/fix/use_preview_api_for_blurhash_generation
2025-05-06 14:12:50 +07:00
867be352f3
fix(blurhash): Use preview API to generate the previews
...
This allows to benefit from all the checks done by the preview API.
This also use the newly introduced `cacheResult` argument to limit disk usage.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-05-05 11:13:31 +07:00
d46d2d1acf
test: Fix coding standards
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-05 10:09:22 +07:00
10424f248b
test(comments): Make Comments test result output properly readable
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-05 09:38:02 +07:00
c24f5fb256
test: Finish migrating tests/Core/ to PHPUnit 10 compatible code
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-02 16:47:42 +07:00
b77011a918
test: Prepare more tests for PHPUnit 10
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-30 09:18:01 +07:00
553870d30a
fix(navigation): Fix default app entry registered as closure
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-25 14:47:33 +07:00
d86189adc5
Merge pull request #52299 from nextcloud/refactor/preview-tests
...
refactor: Thumbnail Generator logging and tests
2025-04-24 09:50:11 +07:00
d980e69f74
refactor: Thumbnail Generator logging and tests
...
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-04-23 23:06:28 +07:00
743924ce4d
fix(federation): allows equal signs in federation id
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-04-22 13:03:56 +07:00
25bc18c6dc
Merge pull request #52221 from nextcloud/feat/no-issue/add-logging-preview-generation
...
feat: add logging to preview generation
2025-04-22 12:37:49 +07:00
8410d67fc7
Merge pull request #52224 from nextcloud/bugfix/noid/dont-break-when-checking-if-too-long-user-exists
...
fix(usermanager): Don't throw when checking if a too long user id is an existing user
2025-04-17 16:55:02 +07:00
6b89838cc2
feat: add logging to preview generation
...
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-04-17 14:24:18 +07:00
8f8c11ad4e
fix(mail): use matching text color for primary elements
...
when we use the default primary as background color we have to use the
default primary text color as well.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-17 11:51:46 +07:00
9f666c2b73
feat(ip): add configurable IPv6 subnet for BFP and throttling
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-04-17 08:12:03 +07:00
775ca882f3
fix(usermanager): Don't throw when checking if a too long user id is an existing user
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-16 17:47:28 +07:00
f8391e60ce
Merge pull request #51020 from nextcloud/artonge/fix/transfer_ownership
2025-04-14 16:14:45 +07:00
696e163ba2
Merge pull request #52086 from nextcloud/fix/cleanup-user-backends
...
Cleanup user backends related methods
2025-04-14 15:49:49 +07:00
9e0e53707f
Merge pull request #52085 from nextcloud/bugfix/noid/fix-cached-return-of-display-name
...
fix(federation): Fix returning "no display name" after cache result
2025-04-10 11:38:22 +07:00
0cf4f3cc71
fix: Replace all usages of OC_User backend method calls by IUserManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-10 11:29:21 +07:00
0a474e5ccd
Merge pull request #52050 from nextcloud/fix/noid/taskprocessing-appapi
...
fix(taskprocessing): use the event for AppAPI to get list of AI providers
2025-04-10 10:22:25 +07:00
d8744f84e8
fix(federation): Fix returning "no display name" after cache result
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-10 09:20:27 +07:00
70218dc0a4
fix(files_sharing): fix share creation error handling
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-09 14:52:42 +07:00
8357469557
Merge pull request #52070 from nextcloud/test/noid/improve-test-output
...
test: Improve comments manager test output in case of failure
2025-04-09 16:08:19 +07:00
c23ab0d1f7
fix(taskprocessing): use the event for AppAPI to get list of AI providers
...
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
2025-04-09 15:47:48 +07:00
e2cd436205
test: Improve comments manager test output in case of failure
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-09 13:49:16 +07:00
6a3c53def3
fix(federation): Don't load the addressbook when resolving a cloud ID
...
Instead we delay the lookup of the display name until it is actually used
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-09 10:52:03 +07:00
8358a7f769
Revert "refactor(RichObjectStrings): Only log error if key or value is not string in validator"
...
This reverts commit fd156d3408
2025-04-09 08:35:56 +07:00
dd32639fa9
Merge pull request #51838 from nextcloud/feat/cleanup-oc-util-methods
...
Mark all methods of OC_Util as deprecated
2025-04-08 21:47:31 +07:00
065a976bd5
Merge pull request #52014 from nextcloud/fix/fix-movie-preview-construct
...
fix(preview): Fix constructor parameter name and default value
2025-04-08 14:38:17 +07:00
fd156d3408
refactor(RichObjectStrings): Only log error if key or value is not string in validator
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-04-08 11:45:36 +07:00
c4021c8d38
feat(ip): use larger IPv6 range by default
...
Some providers assign `/48` IPv6 blocks instead of `/64` so it sounds safer
to use this mask by default.
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-04-08 10:08:28 +07:00
3ca690a9f3
fix(previews): Cleanup Movie provider code and remove deprecated static vars
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-08 09:53:02 +07:00
b2100484c0
fix: Remove some call and references to deprecated OC_Util class
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-07 17:05:54 +07:00
12d32ee2ea
Merge pull request #51836 from nextcloud/feat/cleanup-oc-util
...
chore(legacy): Remove deprecated OC_Util::addScript and functions depending on it
2025-04-03 12:26:57 +07:00
5003467f98
fix(session): Only mark sessions of permanent tokens as app passwords
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2025-04-03 10:08:15 +07:00
e467ea1c6a
chore(legacy): Remove deprecated OC_Util::addScript and functions depending on it
...
Deprecated since 24, currently unused.
Sadly not all related functions were officially marked as deprecated,
but all of them were unused.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-01 15:24:24 +07:00
8fdf2a7eae
fix: Transfer ownership with S3 as primary
...
When using S3 as primary storage, transferring ownership with the `--move` option fail with the following error:
`SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '8-45b963397aa40d4a0063e0d85e4fe7a1' for key 'fs_storage_path_hash'`
The `--move` option moves the entire home folder from one account to another.
The error means that the move failed because the destination folder already exist in `oc_filecache`.
- With S3 as primary storage, folders only exists as entries in `oc_filecache`.
- With S3 as primary storage, `moveFromStorage(...)` only moves the cache entry, as nothing needs to be moved on disk. This cache move does not delete potentially pre-existing destination folder.
- With Local storage, `moveFromStorage(...)` calls `rename(...)` which delete pre-existing folder.
- `transfer(...)`: 687a4d9ac7/apps/files/lib/Service/OwnershipTransferService.php (L112)687a4d9ac7/lib/private/Files/SetupManager.php (L261-L262)687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L91-L135)687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L635-L636)
2025-04-01 13:53:56 +07:00
e655ffeb43
Merge pull request #50768 from nextcloud/perf/cron/delay-timedjob-checking
...
perf(cron): Delay (re)checking timed jobs
2025-03-31 17:31:44 +07:00
aee2f2df55
Merge pull request #51768 from nextcloud/techdebt/noid/prepare-phpunit10
...
fix(phpunit10): Migrate away from PHPUnit at() calls
2025-03-31 16:04:41 +07:00
2395526e6c
perf(cron): Delay (re)checking timed jobs
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2025-03-31 13:21:29 +07:00
d5ad9b86ef
Merge pull request #51676 from nextcloud/fix/add-getappversions-replacement
...
Add OC_App::getAppVersions replacement in IAppManager
2025-03-31 10:51:00 +07:00
522be60ff0
fix(phpunit): Remove some more withConsecutive calls
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-03-31 09:43:22 +07:00
2de6d6b908
fix: add event status and participant status
...
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-03-28 03:48:48 +07:00
46f531adec
test: Adapt tests to properly use valid email addresses
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-26 11:51:52 +07:00
34d7a957e0
chore(tests): Adapt TemplateLayoutTest to constructor change
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 14:23:40 +07:00
248d21a2b9
Merge pull request #51490 from nextcloud/castUsersCountToInt
...
fix(database): Cast users count to integer
2025-03-25 12:57:34 +07:00
254dd85664
fix(IFilenameValidator): correctly handle case insensitivity
...
- forbidden names and forbidden base names are case **insensitive**
so we need to check all lowercase here.
- add test that config value is also read case insensitive.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-21 01:00:58 +07:00
18de9be0e2
fix(database): Cast users count to integer
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-03-20 12:00:57 +07:00
aac391d466
chore: Move template functions out of legacy folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +07:00
a83cae1a0e
fix: Remove multiple require_once calls for template functions
...
Only require them when include the template file instead
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +07:00
c9d9abd46e
fix(cardav): only show useres from enabled addressBooks in contacts menu
...
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2025-03-17 11:56:34 +07:00
3c698c6553
fix(RichObjectStrings): Make exception messages for invalid parameters more useful for debugging
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-12 14:52:32 +07:00
00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +07:00
34251c4375
fix(lookup-server): do not query data by default
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +07:00
eb597917f6
Merge pull request #51029 from nextcloud/fix/deprecate-oc-template-and-cleanup
...
fix: Deprecate OC_Template, add proper template manager instead
2025-03-10 16:20:45 +07:00
bb6b462690
Merge pull request #51130 from nextcloud/fix/credential-passwordless-auth
...
fix: Do not build encrypted password if there is none
2025-03-07 16:49:18 +07:00
7d64c63acf
chore: Adapt TemplateLayout tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +07:00
777cd941dc
fix: Do not build encrypted password if there is none
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-06 09:31:29 +07:00
2ef04bfb5d
Merge pull request #47686 from nextcloud/fix/move-email-logic-local-user-backend
...
fix: Move login via email logic to local backend
2025-03-04 18:21:57 +07:00
42d752f767
Merge pull request #51116 from nextcloud/enh/noid/nullable-range
...
feat(AppFramework): extend range check to optional parameters
2025-03-04 14:23:21 +07:00
3c4feff028
fix: Move login via email logic to local backend
...
Backends can decide which names they accept for login,
e.g. with user_ldap you can configure arbitrary login fields.
This was a hacky approach to allow login via email,
so instead this is now only handled by the local user backend.
This also fixes some other related problems:
Other logic relys on `backend::get()` which was not handling email,
so e.g. password policy could not block users logged in via email
if they use out-dated passwords.
Similar for other integrations, as the user backend was not consistent with
what is a login name and what not.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-03 18:02:07 +07:00
8acfc0f0f2
refactor(TempManager): Simplify and unify implementations and remove legacy behavior
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-03 11:11:12 +07:00
6594d7d96d
feat(AppFramework): extend range check to optional parameters
...
Now it also applies when a paramater is documtend with a pending |null,
but no further unionation is considered.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2025-02-27 19:49:04 +07:00
001b12c482
Merge pull request #50999 from nextcloud/fix/move-away-from-oc-app
...
fix: Replace OC_App calls by IAppManager
2025-02-27 18:33:47 +07:00
0a77ba99a2
feat: support migrating an instance to sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-25 17:52:40 +07:00
d189ed3dd9
fix: Remove incorrect `@throws` annotations and move away from OC_App
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-24 17:48:34 +07:00
e2a4649257
fix(tests): Adapt tests to appManager usage
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-24 17:48:34 +07:00
e3af27b280
refactor: convert sanitize account properties repair step to background job
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:16:28 +07:00
575222b5af
fix: Optimize repair step performance
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:16:28 +07:00
08d33a9f57
fix: validate account properties as a repair step
...
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:16:27 +07:00
ae2cc23658
fix: Change UserAgent to *cloud
...
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
2025-02-19 18:51:08 +07:00
ed9b47462f
Merge pull request #49648 from nextcloud/fix/clarify-app-manager-methods
...
Clarify app manager method names
2025-02-13 11:33:52 +07:00
f758f565d4
fix: Replace getInstalledApps calls with getEnabledApps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:20 +07:00
a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +07:00
3289cbcbd3
fix: Fix UserTest to return valid configuration values
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-10 14:52:18 +07:00
93c72f5675
Merge pull request #50660 from nextcloud/fix/mime-int
...
fix: make sure we process mime extensions as string
2025-02-06 16:13:27 +07:00
729cdf6818
fix(FediverseAction): Ensure valid fediverse links are generated
...
Harden also for existing values of the profile.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 11:58:24 +07:00
fbef47a5d7
fix(AccountManager): Sanitize social media handles
...
Ensure to only accept valid X and fediverse handles.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 11:58:24 +07:00
6baafd82b6
fix: make sure we process mime extensions as string
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-05 12:35:41 +07:00
b6c7c28585
fix: Exclude non accepted shares when computing access list
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-30 09:57:14 +07:00
b48ee2e924
fix: Harden files scanner for invalid null access
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:08:46 +07:00
0a0f56282a
fix(sharing): Move permission validation to share manager
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 16:40:50 +07:00
b70654aeed
Merge pull request #48581 from hammer065/fix/issue-35936
...
fix: Filter for folders in cleanup old preview job
2025-01-27 16:06:40 +07:00
c1655bcde7
fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-27 12:46:15 +07:00
8c309130cf
fix(preview): Filter for folders in cleanup old preview job
...
Fixes #35936 .
When running `OC\Preview\BackgroundCleanupJob`, the main iteration loop
in `run()` expects a folder, however, `getOldPreviewLocations()`
currently does not filter by mimetype and therefore can yield a
non-folder entry which causes an Exception when constructing the Folder
impl.
Filtering for `httpd/unix-directory`, as `getNewPreviewLocations()`
already does, fixes this issue.
Signed-off-by: Dario Mehlich <d.mehlich@gmail.com>
2025-01-27 10:16:08 +07:00
f33e9a96ae
Merge pull request #50273 from nextcloud/artonge/fix/metadata_field_search
...
fix: Metadata field search
2025-01-25 10:43:59 +07:00
b0d1f2c489
Merge pull request #50331 from nextcloud/fix/perf/cache-avilable-taskt-types
...
fix(taskprocessing): More caching
2025-01-25 09:11:05 +07:00
6f94ddc1d5
fix(taskprocessing): Fix tests
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-24 16:45:43 +07:00
eea91fa1ba
fix(TemplateLayout): `core` is not an app but the server itself
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-24 15:10:23 +07:00
31664b3edd
fix: Correctly return app id and app version for `core` styles and images
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-24 13:08:31 +07:00
dcb370ab62
Revert "fix(Share20\Manager): Ensure node is still accessible when checking share"
...
This reverts commit c2ca99e2f6
2025-01-24 09:41:14 +07:00
b4e3eff078
feat(systemtags): add setting to block non admin to create system tags
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-01-22 20:07:24 +07:00
79ca27f6a6
test: fix periodic `Test\Group\DatabaseTest::testSearchGroups` failure
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-22 10:53:03 +07:00
a635710117
fix: Metadata field search
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-20 14:41:55 +07:00
27ac8e0f78
Merge pull request #50214 from nextcloud/feat/show-time-diff-user
...
feat(contacts): Show time difference for users in different timezones
2025-01-20 14:39:00 +07:00
84f0fc88cc
feat(contacts): Show time difference for users in different timezones
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-16 18:10:04 +07:00
626bc7220b
Merge pull request #50171 from nextcloud/enh/limit-ldap-user-count
...
Limit ldap user count
2025-01-16 17:25:01 +07:00
42d997bcd7
test: Update tests
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 +07:00
db94aeb96e
chore(tests): Adapt tests to the countUsers refactor
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-14 16:34:15 +07:00
bd4a154d64
feat(lexicon): configurable default value
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-01-14 10:36:07 +07:00
7b2cb2e3bc
test: update test for mountpoint numeric storage id
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-13 18:09:29 +07:00
3dbdf3266c
feat(ocp): add calendar api to retrieve availability of attendees
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-13 10:12:31 +07:00
dd0f7f0bbf
Merge pull request #49888 from nextcloud/feat/ocp/meetings-api-requirements
...
feat(ocp): calendar event builder api
2025-01-08 11:48:53 +07:00
99e0867f0a
chore: Adapt tests to added constructor parameters
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-07 10:34:30 +07:00
80bc1c2d6c
feat(ocp): calendar event builder api
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-06 10:16:53 +07:00
16d0363937
fix: improve checks for moving shares/storages into other mounts
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-03 15:36:32 +07:00
a60f71bd93
Merge pull request #49727 from nextcloud/feat/make-tasks-types-toggleable
...
Feat: make taskprocessing task types toggleable
2024-12-18 20:08:28 +07:00
75e64e2942
fix: egt rid of unused variable
...
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +07:00
b1d1badcf0
test: add explicitly enabled task type unit test
...
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +07:00
129af480ac
test: add disabled task type unit test
...
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +07:00
13fefc4612
feat(Navigation): emit dedicated event for loading additional entries
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-12-18 12:50:11 +07:00
815991741d
fix(lexicon): renaming and minor fixes
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-12-13 11:08:20 +07:00
96586ba709
feat(config): implementation of lexicon
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-12-13 11:08:20 +07:00
365ff40929
fix(tests): Adapt ManagerTest to change in Exception class used
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-12 15:39:48 +07:00
cba556d641
Merge pull request #48612 from nextcloud/fix/activity-log-for-favorites-in-dav
...
add activity logging for favorites in dav
2024-12-12 15:18:47 +07:00
3baa91d842
Merge pull request #40394 from nextcloud/updater-change-mimetype-objectstore
2024-12-11 08:40:58 +07:00
adf8a454dd
feat(systemtags): add color support backend
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-06 10:19:42 +07:00
37199779de
fix: fix mimetype not being updated when changing file extention on object store
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-05 18:05:13 +07:00
8d953aeb8d
refactor(tags): move favorite event dispatching to tags.php
...
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
2024-12-03 20:56:36 +07:00
425e0c3660
test(View): Copy preserves content
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-03 18:29:32 +07:00
199b0bd4d9
fix(files): Correctly copy the cache information on copy operations
...
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-03 17:04:44 +07:00
dd101dd0f7
Merge pull request #49515 from nextcloud/bugfix/noid/boolean-false-in-multipart-form-data
...
fix(controller): Fix false booleans in multipart/form-data
2024-11-28 14:46:16 +07:00
1909b981a4
fix(controller): Fix false booleans in multipart/form-data
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-28 12:18:30 +07:00
379f575c25
Merge pull request #49493 from nextcloud/artonge/feat/pwd_confirmation_allow_set_period
2024-11-28 11:58:02 +07:00
512f3caf57
test:(PasswordConfirmationMiddleware): Fix constructor call
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-11-28 11:05:10 +07:00
1323e5bcb1
fix(migration): Decrypt ownCloud secrets v2
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-11-28 09:00:33 +07:00
c2ca99e2f6
fix(Share20\Manager): Ensure node is still accessible when checking share
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
c378e74017
feat(Share20\Manager): Return all shares on IShareOwnerlessMount
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
a978e0a806
fix(Share20\DefaultShareProvider): Return link shares in getSharesByPath()
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
f9cda54cbf
fix: Wrap partial cache entry in CacheEntry
...
Because it is returned here: 7b7d07c575/lib/private/Files/Cache/Cache.php (L136-L137)df95bf6ba8/lib/Mount/RootEntryCache.php (L23-L28)
2024-11-21 17:13:24 +07:00
e4c013d86d
feat(Mailer): add "null" SMTP transport mode
...
== Goal
Allow disabling mail delivery altogether.
== Usecase
If mails ought to be send by other means than rendering messages from
templates and sending them via SMTP-like protocols.
Example: listening to specific Nextcloud events and pass parameters to
a centralized (i.e. REST-based) API that sends e-mails.
Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
2024-11-19 11:32:39 +07:00
46d8a7333b
feat(Mailer): implement caching
...
Currently $this->instance is never set, so the code is no-op. This
brings back caching of the instance.
Caching broke with
be7db1573d
2024-11-19 11:32:39 +07:00
5b4f1904c0
feat(user-prefs): renaming to IUserConfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
6afc8552b7
feat(user-prefs): switching to NCU/
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
7c04818c5c
feat(user-prefs): iterator instead of array on search
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
e73513bdd1
fix(user-prefs): adding sensitive and indexed as flags
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
65e24f7def
feat(user-prefs): IUserPreferences
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
0718984bdf
Merge pull request #48675 from georglauterbach/master
...
DNS: do not query CNAME if A succeeded already
2024-11-14 11:43:32 +07:00
158299b3d7
fix(profile): make sure the app cannot be disabled as it was in core
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-14 10:25:10 +07:00
7ebeed45bd
feat: add iMip Request Handling
...
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-11-07 21:12:37 +07:00
b21c0265df
test: add some minimal testing for metadata storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-07 16:27:16 +07:00
c3c8b7e2a3
fix(richobjectstrings): Add missing placeholder validation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-06 21:31:41 +07:00
387cd8b771
fix: do not query CNAME if A succeeded already
...
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-11-06 20:21:38 +07:00
3c4290631b
Merge pull request #49039 from nextcloud/jtr/fix-ipv6-zone-ids-link-local
2024-11-06 09:17:52 +07:00
8fab143aa4
Merge pull request #48721 from nextcloud/feat/allow-getter-setter-decl-fors
2024-11-06 08:54:40 +07:00
5ea5b2de84
fix: Handle exception when clearing previously removed two factor tokens
...
If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 11:14:05 +07:00
381a2aa627
fix: Clear pending two factor tokens also from configuration
...
Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 11:14:04 +07:00
e885e4f13d
fix(tests): Add IpAddressClassifier v6 zone ID test
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-04 09:31:48 +07:00
97421fb143
fix(tests): Add RemoteAddress v6 zone ID test
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-04 09:30:21 +07:00
901496276b
Merge pull request #47425 from nextcloud/fix/avoid-invalid-share-on-transfer-ownership
...
fix: promote re-shares when deleting the parent share
2024-11-04 10:09:58 +07:00
79db082fe6
fix(users): improve recently active search
...
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 07:53:10 +07:00
e3e22e28c0
Merge pull request #47847 from nextcloud/fix-copying-or-moving-from-shared-groupfolders
2024-10-29 11:33:12 +07:00
d25a0a2896
Merge pull request #48915 from nextcloud/fix/encrypt-decrypt-password
2024-10-28 13:26:55 +07:00
86006368bf
Merge pull request #48912 from nextcloud/bugfix/exception-appscreenshot-notstring
...
fix(apps-store): Fix exception on generating preview url for installed app screenshot
2024-10-28 11:32:15 +07:00
a74ef8237d
fix: crypto type made not nullable and tests run using ICrypto
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 15:04:11 +07:00
5efb175665
Merge pull request #48614 from nextcloud/refactor/storage/constructors
2024-10-28 10:19:41 +07:00
220bd3422f
fix(appinfo): Make sure screenshot, author and category are always arrays
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-28 08:46:31 +07:00
505dfd65fd
fix: encrypt and store password, decrypt and retrieve the same
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 11:22:36 +07:00
0de4843b73
refactor(Storage): Align all Storage constructors
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-23 13:24:18 +07:00
54c3aa3f99
fix(entity): Fix mapping of old/sub-types to actually supported database types
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-23 09:22:05 +07:00
2ef74b9860
Merge pull request #47329 from nextcloud/feat/add-datetime-qbmapper-support
...
feat(AppFramework): Add full support for date / time / datetime columns
2024-10-18 19:05:08 +07:00
882f91605b
fix(comments): Add test for email mention
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-18 07:39:41 +07:00
db94e10af0
fix: Prevent breaking change in IQueryBuilder
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 18:31:44 +07:00
Côme Chilliet
Ferdinand Thiessen
provokateurin
John Molakvoæ
Joas Schilling
John Molakvoæ (skjnldsv)
Benjamin Gaussorgues
Côme Chilliet
Andy Scherzinger
Daniel Kesselberg
Robin Appelman
SebastianKrupinski
Kate
Louis
nfebe
Maxence Lange
Arthur Schiwon
Anna
Alexander Piskun
Joas Schilling
Christoph Wurst
Christoph Wurst
Julius Knorr
Git'Fellow
Hamza Mahjoubi
Johannes Endres
Dario Mehlich
Marcel Klehr
Josh
Christopher Ng
Richard Steinmetz
Jana Peper
grnd-alt
Thomas Lehmann
georglauterbach
Daniel Calviño Sánchez
yemkareems