bb0c50717c
Bye bye database.xml
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-24 20:04:12 +07:00
9e3775618b
log full expection during repair step
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:17 +07:00
cc744740b7
Remove deprecated \OCP\API
...
Time to remove this forgood now.
Remaining constant moved over
The world is a tiny bit better
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 20:54:32 +07:00
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +07:00
25f9203a70
Fix remaining #25359
...
As a wise man once said:
"I like PRs that pass tests before merging"
C. Wurst, Feb 9th 2021
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 15:41:25 +07:00
aabd73912e
Type the service registration
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 09:44:24 +07:00
4f90766ba3
Skip template picker if none available
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-28 12:00:20 +07:00
7e6d69d166
Add templatedirectory config value to let admins have their custom templates by default
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:20 +07:00
4974404774
files: Create files from template API
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 11:59:46 +07:00
6d4afca7ac
Add support for webp
...
Including handling in OC_Image
But also a preview provider
Of course only works if your php actually supports webp
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-19 20:17:10 +07:00
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +07:00
287c26bda3
Replace patchwork/utf8 with symfony-polyfill-*
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-07 21:22:41 +07:00
9ce3ea3368
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-30 14:07:05 +07:00
adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net
...
Unify links to php.net
2020-12-22 09:53:31 +07:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +07:00
a4b5312729
Do not include non-required scripts on the upgrade page
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-15 21:14:07 +07:00
8a8aa4f7dc
Add sanitizers for JSON output
...
Those functions set proper content-types that prevent rendering of
data. Therefore it's safe to mark them as sanitizers.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2020-12-11 21:23:11 +07:00
c8e0f3015f
Merge pull request #24398 from nextcloud/fix/do-not-update-incompatible-app
...
Do not update incompatible apps
2020-12-09 09:28:25 +07:00
7f61535a1a
GD images
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +07:00
cbb34af53f
Do not update incompatible apps
...
Previously there was no (platform) dependency check for an app that was
installed before. So Nextcloud happily upgraded an app that now requires
a php version newer than the current one. Which means in the lucky case
you see a failing upgrade due to the language incompatibility, or in the
unlucky case you see unexpected errors later in production.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-04 17:05:22 +07:00
c9cd633665
Fix the download of multiple files from the webUI
...
needed a setupFS call
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-03 13:20:01 +07:00
fd649afb1f
Remove the deprecated update.php
...
* It was documented as deprecated.
* The app code checker warned about it
* It's been three years
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-27 13:02:59 +07:00
f4c1512bb7
Fix typo in @deprecated PHPDoc tag
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-24 00:13:09 +07:00
032de4f333
Merge pull request #24269 from nextcloud/taint-specialize
...
Mark getAppPath as specialized taint
2020-11-22 13:39:46 +07:00
d25ca1976b
Mark getAppPath as specialized taint
...
Should remove some false positives.
https://psalm.dev/docs/security_analysis/avoiding_false_positives/
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2020-11-21 01:15:15 +07:00
98ddfdd1e8
Mark cleanAppId as sanitizer for include
...
Should remove a bunch of false positive code scanning results.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2020-11-21 00:57:25 +07:00
47ac8e0028
Add Psalm Taint Flow Analysis
...
This adds the Psalm Security Analysis, as described at
https://psalm.dev/docs/security_analysis/
It also adds a plugin for adding input into AppFramework.
The results can be viewed in the GitHub Security tab at
https://github.com/nextcloud/server/security/code-scanning
**Q&A:**
Q: Why do you not use the shipped Psalm version?
A: I do a lot of changes to the Psalm Taint behaviour. Using released
versions is not gonna get us the results we want.
Q: How do I improve false positives?
A: https://psalm.dev/docs/security_analysis/avoiding_false_positives/
Q: How do I add custom sources?
A: https://psalm.dev/docs/security_analysis/custom_taint_sources/
Q: We should run this on apps!
A: Yes.
Q: What will change in Psalm?
A: Quite some of the PHP core functions are not yet marked to propagate
the taint. This leads to results where the taint flow is lost. That's
something that I am currently working on.
Q: Why is the plugin MIT licensed?
A: Because its the first of its kind (based on GitHub Code Search) and
I want other people to copy it if they want to. Security is for all :)
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2020-11-20 23:12:00 +07:00
d0f738fd59
Merge pull request #24112 from nextcloud/bugfix/24099/setup-fs-before-query-storage-in-settings
...
Set up FS before querying storage info in settings
2020-11-16 11:46:22 +07:00
91a3e439cb
Don't throw on SHOW VERSION query
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-16 08:43:48 +07:00
2143f2bb82
Set up FS before querying storage info in settings
...
The personal info section of the personal settings is querying the
storage quota information. For this it requires the FS to be setup which
is not always guaranteed.
This fixes an issue where refreshing the settings page would cause it to
fail after Redis caches are full. It is likely that when Redis cache is
populated, some code path is initializing the FS, so it works so far.
But when the cache is populated, that code path is skipped so the FS is
not guaranteed to be setup...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-11-13 17:06:37 +07:00
f23c2162ad
Merge pull request #23993 from nextcloud/bugfix/noid/close-cursors
...
Don't leave cursors open
2020-11-10 15:15:03 +07:00
979b291a36
Show the full trace of an exception
...
Because often we catch the exception at some point and then the trace is
misleading. What's really interesting is the trace of the *previous*
exception.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-10 10:35:08 +07:00
8027dcbc6f
Don't leave cursors open when tests fail
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 12:28:17 +07:00
d8637c62e0
Reduce the getAppPath and autoloader calls
...
The getAppPath will always return the same data for the same appId. It
is actually already cached. However we do some cleanup of the appId
(again). Same for the autoloading it is actually already checked.
This just removes the unneeded calls. Which can add up if you have a lot
of incomming shares.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-07 17:24:41 +07:00
9981ffd784
Merge pull request #23922 from nextcloud/bugfix/noid/fix-query-type-detection
...
Improve query type detection
2020-11-06 22:18:14 +07:00
b70cf435a7
Merge pull request #23940 from nextcloud/enh/skip_already_loaded_apps
...
Skip already loaded apps in loadApps
2020-11-06 21:58:44 +07:00
0dece78617
Skip already loaded apps in loadApps
...
Otherwise you might end up calling a lot of functions unneeded.
And while the individual calls are cheap if you multiply them by 20k
they still get somewhat expensive.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 14:56:06 +07:00
a847aea19c
Deprecate OC_DB::prepare and OC_DB::executeAudited as they leak cursors
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 10:37:37 +07:00
3d2f71cfa9
Improve query type detection
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 08:38:56 +07:00
fc403135d1
Use lib instead if core as l10n module in OC_Files
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-27 15:37:57 +07:00
c1834bac7d
Only use index of mount point when it is there
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-21 13:37:56 +07:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +07:00
0dfdf3ee99
add mount point to quota warning message
...
makes it more clear to the user what the quota applies to
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-04 11:02:32 +07:00
68ce17e59b
Unify links to php.net
...
Update all links to https://www.php.net/
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-09-17 17:40:04 +07:00
46525f8639
Change 0 to null to properly encode image to BMP if the first pixel is black
...
Ref #22288
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-10 12:08:01 +07:00
c077c15875
show better quota warning for group folders and external storage
...
instead of showing the generic 'Your storage is full' message, better explain that it's the group folder/external storage that is full
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-25 16:05:16 +07:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +07:00
b09620651c
Don't use deprecated getIniWrapper() anymore
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-20 16:35:38 +07:00
4c6eb96471
Merge pull request #22280 from nextcloud/bugfix/noid/429-on-brute-force-maximum
...
Send "429 Too Many Requests" in case of brute force protection
2020-08-19 18:21:01 +07:00
e93bf71369
Fix the return type of OC_Template->fetchPage() to be string only
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 16:48:06 +07:00
27e7332a9c
Cast float/char to int to avoid invalid scalar argument warning
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:51:59 +07:00
6675528804
Merge pull request #22271 from nextcloud/phpdoc/22063/add-interface-method-and-phpdoc
...
Properly add new methods to interface and document in PHPDoc for getR…
2020-08-17 19:34:56 +07:00
d7f66c36ac
Fix "misplaced variables" warning of Psalm in PHPDoc statements
...
Ref #21787
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 17:46:57 +07:00
e47cfc9a54
Properly add new methods to interface and document in PHPDoc for getRootMounts()
...
Introduced in #22063 and was just forgotten.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 17:13:46 +07:00
438ac23e2a
Distribute preview folders in appdata in multibucket setup to multiple buckets
...
* introduces a new IRootMountProvider to register mount points inside the root storage
* adds a AppdataPreviewObjectStoreStorage to handle the split between preview folders and bucket number
Ref #22033
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-06 22:19:20 +07:00
61cc356e0b
Fix php cs check
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-05 17:03:39 +07:00
db86bea18c
Allow default app to be overwritten by user config
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-05 17:03:38 +07:00
e25bab98b7
Set Dashboard as default app
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-08-05 17:01:28 +07:00
6eced42b7a
Remove outdated legacy search scripts
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-04 20:56:22 +07:00
e0cc95f3aa
Allow user backends to specify a custom logout url
...
* Allows SSO backends to do a global logout
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-23 10:42:40 +07:00
9ae75a3ca9
Merge pull request #21850 from nextcloud/techdebt/noid/register-alternative-logins
...
Allow to register AlternativeLogin on RegistrationContext
2020-07-20 14:20:03 +07:00
49970639fa
Add constants for the magic strings of template rendering
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-16 15:47:28 +07:00
0dfcc132ca
Allow to register AlternativeLogin on RegistrationContext
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-16 14:20:24 +07:00
d9cc2f0213
Do not load app.php if Application implements IBootstrap
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-14 15:55:23 +07:00
9e88456768
Fix regression in return value of OC_Util::checkDataDirectoryPermissions due to #21761
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-09 09:29:44 +07:00
c7d9636e82
Kill another unneeded translation
...
We should only translate things when we actually need them.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-08 21:47:16 +07:00
76eb793f9b
Only translate if we need the string
...
This translation was done in each call. Over and over and over again.
All while it was probably not used in 99.99999% of the cases. A small
gain. But still.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-08 15:12:01 +07:00
d53e005458
Merge pull request #21360 from nextcloud/root-storage-prevent-scanning
...
prevent the root storage from accidentally scanning user folders
2020-07-02 21:07:16 +07:00
8e9726be5c
Log usages of the deprecated app.php file
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-30 09:43:40 +07:00
5bc8510b3b
Load the app.php before running apps' boot method
...
Some apps require the composer autoloader from app.php. If we run boot
before including that file, classes and functions from dependencies
won't be found.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-17 14:44:02 +07:00
69571fb536
Add dedicated API for apps' bootstrapping process
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-17 09:22:21 +07:00
e9b5514186
prevent the root storage from accidentally scanning user folders
...
while this scan *should* never be triggered, it's good to have some failsafe to ensure
that the users home contents don't end up getting scanned in the root storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-06-11 15:41:33 +07:00
71b2f94101
Fix the loading order of the js files_info and files_client
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-29 15:43:45 +07:00
97e9823787
Document \OC_App::getAllApps return type
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-28 20:37:24 +07:00
44d05bf356
Move core/js/files to webpack
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-22 20:28:31 +07:00
0556fe351a
Add a message to the log entry of an app being disabled
...
As an admin, it's always a surprise to see that an app got disabled. On
a busy server with many log entries, it's hard to locate the entry that
explains why Nextcloud disabled an app. Adding a message will make it
more obvious, allowing admins and developers to grep for the string.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-19 11:44:51 +07:00
0c35aaba29
Fix OC_Image new resize functions
...
Else the wrong mimetype might be set. Resulting in continious
regeneration of previews when browsing.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-02 21:57:34 +07:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +07:00
bb4dedb015
Provide the proper language to the mailer
...
Else we can't properly translate the footer in the recipients e-mail
language.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-16 09:04:13 +07:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +07:00
1584c9ae9c
Add visibility to all methods and position of static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +07:00
a7c8d26d31
Add visibility to all properties and move static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:48:31 +07:00
1762a409f9
Merge pull request #20422 from nextcloud/techdebt/format-control-structs-classes-methods
...
Format control structures, classes, methods and function
2020-04-10 16:38:23 +07:00
eba3726e1e
Merge pull request #19495 from nextcloud/preview-generate-batch
...
optimize batch generation of previews
2020-04-10 15:57:06 +07:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +07:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +07:00
008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
...
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +07:00
64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
...
Use php keywords in lowercase
2020-04-09 16:25:14 +07:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +07:00
42625a46be
Remove spaces after method or function call
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:05:56 +07:00
36b3bc8148
Use php keywords in lowercase
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +07:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +07:00
7d386872e5
optimize batch generation of previews
...
by allowing the generation of multiple previews at once we save on having to find, open and decode the max-preview for every preview of the same file
the main use case for this is the preview generator app (pr for that comming next)
in my local testing this saves about 25% of time when using the preview generator app
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-09 12:50:59 +07:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +07:00
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +07:00
1e086064f5
Move legacy classes from PSR0 to PSR4
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-07 08:48:00 +07:00
c1368b8696
Merge pull request #19781 from nextcloud/quota-include-external-dont-use-current-user
...
Dont always use the current users quota when calculating storage info
2020-04-01 12:24:21 +07:00
19ca921676
Merge pull request #20241 from nextcloud/fix/license-headers-19
...
Update the license headers for Nextcloud 19
2020-04-01 12:44:21 +07:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +07:00
58a192f05d
Update util.php
2020-03-28 16:17:21 +07:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +07:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +07:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +07:00
23eb0462e5
Use lowercase true, false and null constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 21:53:04 +07:00
5a574737ad
Only load required scripts on install page
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-11 14:20:30 +07:00
93411a2ea0
Dont always use the current users quota when calculating storage info
...
instead pass the quota as parameter.
Without this fix, when 'quota_include_external_storage' is enabled, the
webui will show the quota configured for the admin for every user
instead of the users quota
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-04 17:20:27 +07:00
df9edf0108
Allow to force register the namespace
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-01-13 15:15:50 +07:00
efcf246f07
Register the namespace after reading the new file
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-01-13 15:15:49 +07:00
1b46621cd3
Update license headers for 18
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-20 09:23:25 +07:00
af91efd315
when downloading from web, skip files that are not accessible
...
* avoids a 403, but enables download of resources that are not restricted
* single file downloads still cause 403
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-12-19 13:05:10 +07:00
9e5d6114d5
Use files node API for single file downloads
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-12-19 13:05:09 +07:00
723f017b12
Deprecate hooks, emitter and Symfony dispatcher mechanisms
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-11 10:04:36 +07:00
47bc0cc8a8
Do not disable authentication apps
...
For #18249
If an app encounters an error during loading of app.php the app is
normally disabled. However. We should make sure that this doesn't happen
for authentication apps (looking at your user_saml).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-12-10 12:02:16 +07:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +07:00
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +07:00
417fd12d3a
HTTPS link to https://en.wikipedia.org/wiki/Server-sent_events
...
prevents a redirect
2019-11-15 16:19:28 +07:00
af6c788efc
pass through ServerNotAvailableException on app init
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-14 17:20:14 +07:00
c0398e9a38
Merge pull request #17830 from nextcloud/global-quota-return-quota
...
actually return the quote when getting global storage info
2019-11-07 23:53:04 +07:00
f9bfd48e12
switch to Files Node API for zip generation
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-07 09:45:23 +07:00
5df98d7265
actually return the quote when getting global storage info
...
prevents 'undefined' index errors when 'include external storage in quota' is enabled
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-11-06 10:18:47 +07:00
e71f222082
Cleanup theming mess
...
* Do not do translations in the constructor. This gets called to early
so there is no user yet. Which means we can't obtain the locale. Which
means we store the wrong translation instance.
* Same for the theming app magic. Just use the parent call when needed.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-10-25 13:31:19 +07:00
a9c089064b
Deprecate TemplateManager
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-10-16 09:54:17 +07:00
ad7d13a87c
Print the error pages as error so we load less scripts and might be able to view it
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-09-16 19:38:43 +07:00
b3f663b8aa
Merge pull request #16859 from PhrozenByte/patch-1
...
Add IAppManager::getAppWebPath()
2019-09-09 12:20:27 +07:00
2d56664e35
Improve usage of IAppManager::getAppWebPath()
...
Deprecate \OC_App::getAppWebPath() and \OC_App::getAppPath()
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2019-09-05 18:35:40 +07:00
94eb77a535
Fix sanity checks #16963
...
Signed-off-by: Samuel CHEMLA <chemla.samuel@gmail.com>
2019-09-01 22:27:08 +07:00
92862c51f5
Always check via http and https whether htaccess is working
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-08-23 14:33:58 +07:00
810ee7d811
Make the auto-disabled list more broad
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-08-15 11:12:45 +07:00
d0409548c6
instead of upsert, fallback to default query on PgSQL <= 9.4
...
because there is no upsert yet
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-08-14 09:05:11 +07:00
1b074f48d8
Remove duplicated spaces
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2019-08-11 20:11:50 +07:00
3f2932c75a
Sort headers
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2019-08-11 20:11:50 +07:00
76cbd7db6e
Add X-Frame-Options header to .htaccess
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2019-08-11 20:11:49 +07:00
323f40a493
Merge pull request #16461 from nextcloud/fix/noid/pgsql-version
...
fixes the check for postgresql
2019-07-26 12:32:04 +07:00
8b1126e6d2
fixes the check for postgresql
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-07-18 18:34:10 +07:00
605d0874a4
Removes unused OC_API::register
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-07-18 11:27:09 +07:00
9d121985dc
Merge pull request #15540 from nextcloud/bugfix/noid/prevent-faulty-logs-from-nested-setupFS-calls
...
Prevent faulty logs from nested setupFS calls
2019-06-21 12:00:22 +07:00
7d1fc2b8e8
Fix missing login hook wih Apache/SAML
...
Without this patch the hook does not transport the information whether the login is
done with an app password or not. The suspicious login app requires the parameter
to function correctly, hence adding it will make suspicious login detection also possible
with SAML users.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-06-11 07:29:00 +07:00
22fa6421e5
Prevent faulty logs from nested setupFS calls
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-05-15 10:22:51 +07:00
361836675c
Show supported apps in app management
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-05-13 13:36:02 +07:00
f095bd1642
Use non-absolute logout URL to fix wrong URL in reverse proxy scenario
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-05-08 18:02:00 +07:00
3b1e16458d
Forbid eval on legacy responses
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-04-09 09:58:23 +07:00
769cb629ae
allow enforcing apps to ignore the max version
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-03-20 15:16:11 +07:00
c6a69ba925
Remove the upload and memory setting
...
* Remove unneeded private method phpFileSize()
* Bump autoloader
* Remove setUploadLimit tests
* Remove integrity check hacks for upload limit
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-04 12:14:22 +07:00
0c77cd21f9
Make sure maintenance mode is always casted to bool
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-02-22 08:25:41 +07:00
65964a537a
Move jquery.ocdialog.scss to bundle
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-14 13:38:24 +07:00
ea951136d1
Move jquery-ui-fixes to bundle
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-14 13:31:49 +07:00
a498b72dec
Move the contactsmenu handlebars templates to the bundle
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-04 10:56:52 +07:00
f1b0332920
Do not try to load js moved to bundle
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-01 10:39:47 +07:00
5fe151f7c4
Merge pull request #13927 from nextcloud/remove-dead-code
...
Don't call apc_delete_file and apc_clear_cache anymore
2019-02-01 10:17:55 +07:00
9104e028a3
Remove deleteFromOpcodeCache & clearOpcodeCache
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-01-30 17:36:14 +07:00
1638f89e89
Don't call apc_delete_file and apc_clear_cache anymore
...
There is no apc for PHP7+ so there is no need to check if exist.
accelerator_reset looks even more ancient.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-01-30 16:28:47 +07:00
a170bf80ec
Improve data directory write checking for NFS mounts
...
If `is_writable()` fails, fall back to logic that attempts to create a file
and then checks if it exists. If this check fails, an error occurs as it
did before.
Discussion on this solution was found here:
https://help.nextcloud.com/t/write-errors-for-nfs-mount/23328
Fixes #7124
Signed-off-by: Robert Dailey <rcdailey@gmail.com>
2019-01-24 20:39:52 +07:00
e3de4edc51
Urlencode the requesttoken
...
Followup of #13757
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-23 16:16:31 +07:00
ebd9f30d85
Request plain logout url
...
By requesting the plain logout url we allow it to be properly cached by
the caching router. We just add the requesttoken manually.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-23 14:06:03 +07:00
83068c39e5
Update select2, include css
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:02:01 +07:00
1e80259051
Remove core.js
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:02:00 +07:00
208788173d
Npmize (vendor) scripts
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:01:59 +07:00
5ee6e5b8c6
Use OC_Util::getVersion instead of getSystemValue
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-12-07 11:42:12 +07:00
6016d45ca9
Use version to generate docversion
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-12-07 11:42:12 +07:00
ea6ea7f4c3
PHP module is named mbstring
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-04 17:22:11 +07:00
79b8703f29
Set Referrer-Policy also in addSecurityHeaders()
...
Fix : #12689
Signed-off-by: Peter Kraume <peter.kraume@gmx.de>
2018-11-27 16:39:06 +07:00
1b85ef4bf2
Fix string doc type casing
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-11-15 11:57:05 +07:00
ea21aa3f7a
Use numeric placeholders if there are multiple, so that RTL languages can operate better
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-09 14:32:14 +07:00
db345e4c6d
Deprecate unused, private OC_Helper::linkToPublic
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-08 18:29:52 +07:00
7971ba5cc6
Merge pull request #10898 from nextcloud/feature/10684/default-logo-color-theme-colors
...
Switches the default logo color depending on the primary color
2018-10-08 10:33:22 +07:00
e0ed64366c
Merge pull request #11613 from nextcloud/add-missing-throw-statement
...
add missing throw statement to doc block
2018-10-04 16:28:08 +07:00
1d4a80f37d
add missing throw statement to doc block
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-04 15:23:07 +07:00
cdb3ffb293
Remove unused code in legacy classes
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-03 22:07:51 +07:00
d855c38e07
Moves the logo files to logo
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-10-02 08:37:54 +07:00
d4dec43f8f
Dont use find to lookup binaries
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-09-29 20:25:19 +07:00
c9e93b8084
Compile contactmenu handlebars templates
...
Fixes #11029
For https://github.com/orgs/nextcloud/projects/18
Ship the compiled handlebars templates. This makes it possible to have a
scricter CSP.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-27 20:33:58 +07:00
bb86a8ca36
add back-end as parameter to the pre-login hook
...
This is needed for the Global Scale setup to allow the master
node to perform different operations during login, depending
on the user management. Because in case of SAML, the authentication
at the idp happens at the master node.
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-09-14 17:23:06 +07:00
be9ab8b879
also catch exceptions when loading apps
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-24 17:16:54 +07:00
bfa49410a2
Drop support for xcache
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-08-12 17:14:08 +07:00
c74a5250e5
Check if HTTP_USER_AGENT is set before using it
...
Sentry reported some errors regarding this. Apparently not everybody
sets a user agent. If it is not set we assume this is not IE ;)
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-08 13:32:03 +07:00
7eb74186ef
Merge pull request #8380 from nextcloud/bugfix/noid/reenable-disabled-apps
...
Re-enable apps that got automatically disabled while updating
2018-07-25 11:37:10 +07:00
da0bdd1391
Design structure fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 16:09:13 +07:00
e0d9c43c95
Merge pull request #8188 from arnowelzel/master
...
Avoid error messages for restricted opcache API
2018-07-20 11:48:44 +07:00
a24cad1a1c
Fix accessibility invert
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-19 08:16:58 +07:00
478b95cc20
Try to not run into the white page of death and still log something in the web server error log
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-29 11:22:05 +07:00
b0a296e2e1
Do not use HTTP code OC_Response constants anymore
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-26 16:14:15 +07:00
79d9841bce
Replace hardcoded status headers with calls to http_response_code()
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-26 16:14:15 +07:00
1399f6bece
Server exception error pages by default with a 500 status code
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-26 11:44:24 +07:00
8c155cd51c
Server error/hint pages with a 500 error code to avoid it being seen instead of the actual resource
...
* found while reviewing #7205
* allow to specify a special status code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-26 11:44:24 +07:00
a34f70ce0a
Change status code when config is write protected
...
Add hint msg, you can make config file read only
If the config.php is not writable, print an error message: #6893
- set config writable
- or set option to keep it read only
Signed-off-by: Eric Masseran <rico.masseran@gmail.com>
2018-06-26 09:36:17 +07:00
4b49f810b7
Re-enable apps that got automatically disabled while updating
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-06-26 09:15:52 +07:00
8ebc3d90a0
Merge pull request #9518 from nextcloud/feature/5986/public_share_controller_middleware
...
Public share middleware & controller
2018-06-21 10:09:20 +07:00
71ce8f3107
Split css variables and fix url variables
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:17:06 +07:00
366981fba6
Move public preview endpoint over
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:37 +07:00
21441fad9b
Added new search standard
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-19 23:53:20 +07:00
e5f08620d4
Better design for core search, fixes and style to scss
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-19 23:53:19 +07:00
b4a7be20c8
Properly clear cache
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +07:00
1a034ce699
Implement update functionality
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-06-06 11:40:09 +07:00
f7b518fdbf
Get correct version of an app
...
Related to #8929
We should get the version of the app. Not of the appfolder. Else there
is no way to properly compare the versions.
Now note that installing in 1 go will still fail. But at least on the
next page load the new version will be properly detected.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-03 08:22:03 +07:00
db96b0bb0b
Make it possible to make external storages read only
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-01 15:18:56 +07:00
38a90130ce
move log constants to ILogger
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 10:45:52 +07:00
46d0d0cda1
fix appinfo parsing when a single localized option is provided
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-04-17 11:14:03 +07:00
90fdf83ca7
Use zip32 only if there are less than 65536 files
...
A zip32 file can contain, at most, 65535 files (and folders), so take
that constraint into account.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-06 15:59:30 +07:00
4a73f645e5
Use zip32 if possible
...
* OSX doesn't handle 64zip that well
* Some other implentations don't handle it perfectly either
* If the file is belog 4GiB (some overhead) => zip32
* This covers the 99% case I bet
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-06 15:59:30 +07:00
b2e34167eb
Merge pull request #8976 from nextcloud/dep_user_code
...
Remove deprecated functions from OCP\User
2018-03-28 08:23:57 +07:00
1e13b3a8fa
Merge pull request #8994 from nextcloud/deprecate-theme-sync-clients
...
Deprecate theme sync clients
2018-03-28 08:23:16 +07:00
cf4d27b115
Use customclient_* values by default and do not use them in custom themes anymore
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-26 19:26:36 +07:00
91cc44a4e6
Remove deprecated OC_Group_Backend
...
* Private class
* Has been deprecated since NC10
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 14:19:04 +07:00
7ebd96416c
Remove deprecated OCP\User::getDisplayname
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-25 20:42:03 +07:00
6c8caa1641
Remove deprecated \OCP\User::getUsers
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-25 20:33:24 +07:00
f843b7edfe
Merge pull request #8506 from nextcloud/use-appmanager
...
Use isInstalled of AppManger instead of reimplement it
2018-03-22 09:55:19 +07:00
78211a58e6
Remove unused methods of OC_Json
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 14:36:34 +07:00
514de5dfa1
Use isInstalled of AppManger instead of reimplement it
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 11:34:18 +07:00
68871caf3c
Remove unused private function
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 11:32:10 +07:00
7488218535
Merge pull request #8792 from nextcloud/cleanup-oc_response
...
Remove unused methods of OC_Response
2018-03-13 09:47:29 +07:00
53a899a1f5
Fix the HTTP 1.0 status code and properly detect 1.0 vs 1.1&2.0
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-13 09:22:26 +07:00
e758cfcdc8
Remove unused methods of OC_Response
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 18:42:30 +07:00
a1232f46ca
Remove unused methods and constants from legacy OC_API
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 18:03:25 +07:00
44289ff134
Use proper method to format absolute timestamp
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 15:16:52 +07:00
96a5752340
Remove unused $enableAppsCache in OC_App
...
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
2018-03-06 10:47:16 +07:00
55b9a5d886
Remove OC_App::disable method
...
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
2018-03-06 10:45:20 +07:00
539fdaea1e
Run repair steps on uninstall in all cases
...
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
2018-03-06 10:41:55 +07:00
0655df09d6
Pass template parameters to parent template
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-27 12:25:52 +07:00
4e6d98ea8c
Merge pull request #8424 from nextcloud/fix/update-app
...
Fix updating an app
2018-02-19 15:54:49 +07:00
1a8916af59
Fix updating an up
...
OC_App has been made strict recently and the updater code was not
compatible to this. This adds the array to string conversion of the
Nextcloud version and fixes a typo in OC_App (sstring -> string)
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-02-19 10:28:41 +07:00
70b1f510f2
Use normal header() calls instead of private method calls
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-19 09:40:25 +07:00
9b68f80c4b
Add remaining type hints, that were already okay
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 16:05:23 +07:00
9fcf185c7d
Always return a string in OC_App::getCurrentApp and no boolean
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 16:05:23 +07:00
e4077672e1
Use empty array as group list in OC_App::enable
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 16:05:23 +07:00
2e15c0d871
Refactor dependencies in setAppTypes
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 16:05:23 +07:00
9dc3b04802
Fix app version to be always string and neither array nor null
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 16:05:13 +07:00
edee243b27
OC_App::loadApps now only accepts an array as type list
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 15:27:43 +07:00
2a2833e30f
Migrate to short array syntax
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 15:18:34 +07:00
14bc9b1714
Merge pull request #8095 from nextcloud/webapps-capabilities
...
Expose navigation entries as API endpoint
2018-02-15 16:55:12 +07:00
f36e8313ff
Add throws annotation
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-15 12:23:49 +07:00
04053311ee
Properly encapsulate require_once for app.php
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-15 11:20:22 +07:00
ada5aed35e
Deprecate static methods and use Navigation manager
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-12 17:22:33 +07:00
864474b858
Move navigation processing to the NavigationManager
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-02-12 17:22:32 +07:00
e7c35d720d
Avoid error messages for restricted opcache API
2018-02-05 19:45:06 +07:00
c314a07e7f
Merge pull request #8134 from coliff/patch-2
...
Update iOS link to geo-detect & show correct store listing
2018-02-02 12:43:10 +07:00
18898383c5
Update defaults.php
2018-02-02 20:37:58 +07:00
cbbc6187c2
Update doc link version to 14
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-01 13:52:11 +07:00
efbdad2d0c
Remove OC_App::removeApp
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:15:12 +07:00
a68895e334
Remove OC_App::installApp since it is not used anymore
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:15:10 +07:00
19a0a9a4e7
Move getAppInfo and getAppVersion to IAppManager
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-31 14:13:15 +07:00
d971b104ed
Do not cache the settings/sections in the database anymore
...
This caused more troubles then it had benefits, especially
when an app got disabled or was removed without being disabled.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-29 15:47:37 +07:00
a661f043e1
Remove unneeded semicolon and parentheses
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 23:46:40 +07:00
4c38d1ed01
Merge pull request #8054 from nextcloud/substr-use-index
...
Use index based string access for substr with length of 1
2018-01-26 15:40:44 +07:00
9ff51aafc5
Use index based string access for substr with length of 1
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 13:38:34 +07:00
6bbea33133
Simplify ternary operator statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 12:36:25 +07:00
c1e4f9f305
Use type casting instead of *val() method
...
It should be up to 6x faster
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 11:35:42 +07:00
a7ad7cb08e
Merge pull request #8053 from nextcloud/simplify-substr
...
Use short for of substr to not need strlen()
2018-01-26 10:25:09 +07:00
0a56d2185e
Return value immediately instead of assigning to a one-time variable
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 00:02:03 +07:00
e6efa755c9
Use short for of substr to not need strlen()
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-25 22:23:48 +07:00
f0b7b2dedf
Merge pull request #7911 from nextcloud/improve-oc_image
...
Improve OC_Image code to not guess the type of input
2018-01-18 14:39:08 +07:00
Joas Schilling
Robin Appelman
Roeland Jago Douma
dependabot-preview[bot]
Christoph Wurst
John Molakvoæ (skjnldsv)
Julius Härtl
Roeland Jago Douma
Lukas Reschke
Joas Schilling
Morris Jobke
Christoph Wurst
Vincent Petry
J0WI
Jan C. Borchardt
John Molakvoæ
Arthur Schiwon
Christian Oliff
Daniel Rudolf
Samuel CHEMLA
Daniel Kesselberg
Robert Dailey
Peter Kraume
Bjoern Schiessle
Michael Weimann
Eric Masseran
Daniel Calviño Sánchez
Tobia De Koninck
Arno Welzel