ab29a67a32
Allow creating app passwords without validating the user's password again
...
Aparently the idea behind the command was exactly to do this.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-14 13:30:59 +07:00
db1c2a5375
Merge pull request #31511 from nextcloud/bugfix/noid/allow-installing-unstable-versions
...
Allow installing unstable app versions based on channel and with `--allow-unstable` just like on updates
2022-03-11 14:26:30 +07:00
a4111d4846
Allow installing unstable versions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 16:10:25 +07:00
50ccf7e2cf
Validate the password before generating an apptoken
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 15:52:01 +07:00
f98044ddce
Trigger an event to log an activity when an administrator generates an app password
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 15:25:22 +07:00
c1000fe344
Merge pull request #31304 from nextcloud/feature/dry_run_for_add_indices
...
Add --dry-run option for add-missing-* cmd
2022-02-28 09:59:40 +07:00
405c5eb813
Add --dry-run option for db:add-missing-* cmd
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-02-24 16:42:08 +07:00
db6927ee05
Improve performance when converting between DBs
...
Use a transaction when doing multiple inserts increase the writing
speed.
Ref: https://stackoverflow.com/a/68495887
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-16 18:28:06 +07:00
415294e345
Add index for direct editing cleanup job
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-07 09:25:27 +07:00
071ceff7e2
Fixes occ user:info when the user never logged in
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-27 16:33:24 +07:00
b0e6a10263
Use the new function in user:setting occ command
...
instead of direct database queries
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-24 11:16:44 +07:00
14c60b10d0
Merge pull request #30275 from nextcloud/bugfix/noid/add-version-of-disabled-apps-when-available
...
Add version of disabled apps when available
2022-01-14 11:59:25 +07:00
6312c0df69
Check style update
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 00:19:07 +07:00
aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-12 20:03:06 +07:00
ed84f07784
Add missing index for propertypath only queries against properties
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-12-23 15:51:50 +07:00
a376aa6c61
Add version of disabled apps when available
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-15 09:08:14 +07:00
5a766ef004
Allow to delete non-migrated previews instead of moving them
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-12-09 17:34:45 +07:00
536a812de4
Add an index for selecting the next job
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 23:57:40 +07:00
113756db30
Fix ArrayAccess and JsonSerializable return types
...
First round of modifications for PHP 8.1
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:56 +07:00
781ec814e6
Do not print verbose info about app updates if there are none
...
This is cosmetical but if you have a large number of apps installed then
you'll see a wall of text during the server and app upgrade when it
tries to update each app via the app store. In may cases nothing will be
updated. For those boring cases we can hide the verbose info, but show
when occ is run with -v. Any actual update will still print a few lines.
Those are the important ones for the admin.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-11-18 09:11:22 +07:00
5155f2b0c5
Merge pull request #28541 from nextcloud/path-prefix-index2
...
add a prefix index to filecache.path, attempt 2
2021-10-19 14:41:23 +07:00
0a812a1c09
Adjust namespace and print a message when the job was skipped
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-14 09:57:16 +07:00
9cd9f4b4bc
Move queries to the joblist
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-14 09:57:16 +07:00
e2a7482b49
Add a command to show info about a background job and force-execute it
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-14 09:57:16 +07:00
695326534c
disable path prefix index on postgresql for now
...
having the index work properly for the queries we need it for requires some additional options which dbal does not support at the momement.
to prevent making it harder to add the correct index later on we don't create the index for now on postgresql
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-08 18:39:22 +07:00
abd6b354ac
add a prefix index to filecache.path
...
The reason that `filecache.path` hasn't had an index added is the mysql limitation of ~1kb for indexeded fields,
which is to small for the `path`, however mysql supports indexing only the first N bytes of a column instead of the entire column,
allowing us to add an index even if the column is to long.
Because the index doesn't cover the entire column it can't be used in all situations where a normal index would be used, but it does cover the `path like 'folder/path/%'` queries that are used in various places.
Sqlite and Postgresql don't support prefix indexes, but they also don't have the 1kb limit and DBAL handles the differences in index creation.
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-08 18:38:25 +07:00
6502dfae34
add better index for finding unindexed paths
...
for the following query 'SELECT "path" FROM "oc_filecache" WHERE ("storage" = $storage) AND ("size" < 0) ORDER BY "fileid" DESC LIMIT 1;'
currently the database will in some cases decide to priorize the sort by fileid over the filter when picking what index to use, resulting in a much slower query.
by creating an index that allows first sorting by fileid and also filter by storage and size this case will be greatly sped up
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-07 16:11:49 +07:00
59174cfa7c
Merge pull request #28492 from nextcloud/bugfix/occ-status
...
Align occ status with status.php
2021-09-30 17:45:22 +07:00
27865d03c0
use specific email getter where necessary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +07:00
3b6be67719
Align occ status with status.php
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-08-26 22:36:26 +07:00
d201dc2c93
Add active user count to occ user:report
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-08-19 16:22:20 +07:00
edeb8a5739
Add storage info to `user:info` command
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-08-18 08:38:49 +07:00
5390d3194f
Make integrity commands verbose
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-07-08 21:21:57 +07:00
770881d5d6
Move DateTime::ATOM to DateTimeInterface::ATOM
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-23 15:28:07 +07:00
f40150b758
Fix typing error
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-06-21 14:14:37 +07:00
bf564e2a5a
Convert command option defaults to strings
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-09 13:25:31 +07:00
932a385c56
Merge pull request #27429 from nextcloud/bug/26085/wrong-data-add-order-by
...
Don't pass a column object to addOrderBy
2021-06-09 09:12:03 +07:00
11cacf63f8
Fix #26085
...
addOrderBy expects a order expression. For the migration scenario we have column objects. Column objects are not supported by quoteColumnName yet.
A column object as order expression is most likely an edgy thing when migration database information.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-06-08 16:30:44 +07:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
9c6b01abeb
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-02 17:49:32 +07:00
8b0ce8c8a1
Merge pull request #27099 from nextcloud/bugfix/noid/make-user-report-scale
2021-05-26 15:18:41 +07:00
f9b407d0c9
Make user:report command scale
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-26 11:33:09 +07:00
726d01843e
Merge pull request #26600 from hosting-de/feature/occ-tags
...
Add commands to manage tags via OCC
2021-05-25 16:54:06 +07:00
d606799ee2
Add commands to manage tags via OCC
...
list, add, delete, edit
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-05-25 11:29:32 +07:00
da21e86a07
use the UID as loginName and not the display name.
...
Otherwise the app password will not work for users with a display name different to the UID.
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2021-05-11 20:38:54 +07:00
167efa19d7
Fix psalm errors
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +07:00
df47445c01
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +07:00
14ee17e5c5
Revert "add a prefix index to filecache.path"
2021-04-08 10:09:13 +07:00
b9907df702
Merge pull request #26252 from Maxopoly/master
...
Add force option to app install command
2021-04-07 10:09:48 +07:00
9fd29173cf
Merge pull request #26281 from hosting-de/fix/email
...
Change my email address
2021-03-26 09:59:35 +07:00
3388758d04
Remove event listener to udpate events that are not present anymore
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-25 09:01:09 +07:00
ab48d5e8cb
Cleanup unneeded code around database.xml
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-24 22:15:44 +07:00
bb0c50717c
Bye bye database.xml
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-24 20:04:12 +07:00
e9ca59ef0a
Change my email address
...
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-24 15:13:56 +07:00
1f93721097
Add force option to app install command
...
Signed-off-by: Maxopoly <max@dermax.org>
2021-03-22 23:49:13 +07:00
268acd301d
Merge pull request #25529 from nextcloud/fix-non-lgc-glyphs-in-avatars-and-txt-file-previews
...
Fix non LGC glyphs in avatars and txt file previews
2021-03-22 21:06:22 +07:00
b28f0a0e94
add a prefix index to filecache.path
...
The reason that `filecache.path` hasn't had an index added is the mysql limitation of ~1kb for indexeded fields,
which is to small for the `path`, however mysql supports indexing only the first N bytes of a column instead of the entire column,
allowing us to add an index even if the column is to long.
Because the index doesn't cover the entire column it can't be used in all situations where a normal index would be used, but it does cover the `path like 'folder/path/%'` queries that are used in various places.
Sqlite and Postgresql don't support prefix indexes, but they also don't have the 1kb limit and DBAL handles the differences in index creation.
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 18:52:25 +07:00
9135a42781
make repair errors more visible
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:16 +07:00
244e13cd43
DB conversion: improve console output
...
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2021-03-17 14:35:40 +07:00
54cffefed4
Merge pull request #25660 from hosting-de/feature/add-backend-list-groups
...
Show group backends in occ group:list --info and group:info
2021-03-05 08:49:43 +07:00
5b0dc6dad0
Check command input
...
For #25839
We should check this else it crashed hard. Better to be gracefull.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 19:41:35 +07:00
9f96a47125
Add OCC command to reset rendered texts
...
The command is meant to be used when the fonts used to render texts
("core/fonts/NotoSans-Regular.ttf" and "core/fonts/NotoSans-Bold.ttf")
are changed (for example, to add support for other scripts). The avatar
and text file previews will be removed, so they will be generated again
with the updated font when needed.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-01 20:54:43 +07:00
2796ef80ff
Show group backends in occ group:list --info and group:info
...
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-01 16:02:08 +07:00
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +07:00
e618ea83b5
Make the app code checker a NOOP
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 11:46:02 +07:00
7ef7c3e3f2
Fix markup
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:51 +07:00
2e2a2eefd5
Add a warning when trying to run integrity:check-core on git
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:50 +07:00
f319660f60
Force run the verification of the signature on occ
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:50 +07:00
c1d4f8161b
Migrate internal classes to the OCP db col types
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +07:00
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +07:00
d0ac76a77c
Add more previous exceptions to database setup code
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-07 21:04:11 +07:00
f1921364d6
Print an exception trace for setup exceptions
...
Right now any setup error will just result in the exception message
being printed. In some cases this doesn't give any insights into what
went wrong. This adds some dedicated logic to print the exception trace
and any previous exceptions to the CLI.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-07 20:11:25 +07:00
40595f3ee0
Command: Add app password generation
...
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
2021-01-05 13:05:17 +07:00
9ce3ea3368
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-30 14:07:05 +07:00
bdbec28a8f
Make oc_files_trash.auto_id a bigint
...
Adjusted migration.
Added to occ command to update existing tables.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-23 17:50:50 +07:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +07:00
ccd5ca5476
Merge pull request #23044 from nextcloud/migration-10.5
...
Handle owncloud migration to latest release
2020-12-10 14:32:13 +07:00
c77e259cfe
Add missing index on oc_cards and rename if it previously existed
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 12:13:34 +07:00
8f6c2ec357
Move columns to bigint
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-08 16:05:53 +07:00
e25a62c69d
Merge pull request #24348 from hosting-de/feature/console-user-display-name
...
Wrap display_name similarly to email to allow changes via occ
2020-12-02 15:05:20 +07:00
7daef37813
Wrap display_name similarly to email to allow changes via occ
...
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2020-12-02 10:27:57 +07:00
fd649afb1f
Remove the deprecated update.php
...
* It was documented as deprecated.
* The app code checker warned about it
* It's been three years
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-27 13:02:59 +07:00
d5df033ede
Create primary keys on all tables and add a command to create the afterwards
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:36:27 +07:00
0f52e14a92
Merge pull request #23693 from nextcloud/bugfix/noid/import-cert-clarify
...
Clarify import cert command
2020-10-26 22:50:28 +07:00
e80bb9c09f
Clarify import cert command
...
Add hint that the certificate to be imported must be in PEM format (CRT
does not parse).
Improved error message to mention that the given path must be accessible
by the web server user.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-10-26 11:51:37 +07:00
3f691c52dc
Update ConvertFilecacheBigInt.php
2020-10-26 09:18:56 +07:00
600381f82a
Make the migration template typed
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-15 16:08:50 +07:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +07:00
634c051be6
add size index for filecache
...
improves performance of #23004
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-22 15:15:34 +07:00
24744dcaec
Migrate verbose messages to inline syntax of writeln()
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-17 16:30:33 +07:00
617b3f79fa
Show lock messages only in verbose mode
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-17 16:30:11 +07:00
faab3e733b
Allow to run occ preview:repair in parallel
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-17 16:03:34 +07:00
99c9423766
Remove @suppress SqlInjectionChecker
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 15:53:56 +07:00
0aa550c0ab
Fix tense of updater logs
...
Signed-off-by: Nils Wittenbrink <nilswittenbrink@web.de>
2020-09-10 15:17:59 +07:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +07:00
987f621173
Merge pull request #22331 from nextcloud/bugfix/noid/dont-use-deprecated-inigetwrapper
...
Don't use deprecated getIniWrapper() anymore
2020-08-20 19:45:47 +07:00
b09620651c
Don't use deprecated getIniWrapper() anymore
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-20 16:35:38 +07:00
5340ab3a75
New SSE key format
...
* Encrypt the keys with the instance secret
* Store them as json (so we can add other things if needed)
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-20 15:42:43 +07:00
fedf9c69d9
Use matching parameter names form interfaces and implementations
...
Found by Psalm 3.14.1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 18:16:35 +07:00
7506cbb1c4
Show disabled user count in occ user:report
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 09:31:41 +07:00
d7f66c36ac
Fix "misplaced variables" warning of Psalm in PHPDoc statements
...
Ref #21787
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 17:46:57 +07:00
9e962fb69f
Allow to update to nightly
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-07 13:51:39 +07:00
545f806666
Use array_filter instead
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-07 10:42:09 +07:00
d8734b3b93
Add occ preview:migrate to migrate previews from the old flat structure to a subfolder structure
...
* `php occ preview:repair` - a preview migration tool that moves existing previews into the new location introduced with #19214
* moves `appdata_INSTANCEID/previews/FILEID` to `appdata_INSTANCEID/previews/0/5/8/4/c/e/5/FILEID`
* migration tool can be stopped during migration via `CTRL+C` - it then finishes the current folder (with the previews of one file) and stops gracefully
* if a PHP memory limit is set in the `php.ini` then it will stop automatically once it has less than 25 MiB memory left (this is to avoid hard crashes in the middle of a migration)
* the tool can be used during operation - possible drawbacks:
* there is the chance of a race condition that a new preview is generated in the moment the folder is already migrated away - so the old folder with the newly cached preview is deleted and one cached preview needs to be re-generated
* there is the chance of a race condition during access of a preview while it is migrated to the other folder - then no preview can be shown and results in a 404 (as of now this is an accepted risk)
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-06 22:05:46 +07:00
0157e30ad4
Merge pull request #21599 from nextcloud/debt/noid/type-to-types
...
Replace TYPE with TYPES
2020-07-02 12:21:01 +07:00
87dd760a89
Replace TYPE with TYPES
...
As TYPE::* is deprecated.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-30 23:46:22 +07:00
ab21d69903
Add return value to all commands
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-26 14:54:51 +07:00
5f88380c44
Remove db prefix option from cli install command
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-05-26 14:10:39 +07:00
e57bca31ad
Merge pull request #20005 from joeried/occ-remove-bruteforce-attempts-by-ip
...
Implement occ command to reset bruteforce attemps from a given IP address
2020-05-25 14:04:18 +07:00
9c025134b3
Fix syntax
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-05-06 10:54:36 +07:00
6e28c2807b
Add index to properties table
...
Signed-off-by: Mario Danic <mario@lovelyhq.com>
2020-04-30 23:04:15 +07:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +07:00
6b62bef928
Display notice for already enabled apps
...
Signed-off-by: Sander Ruitenbeek <s.ruitenbeek@getgoing.nl>
Signed-off-by: Sander Ruitenbeek <s.ruitenbeek@getgoing.nl>
2020-04-24 16:30:45 +07:00
734c62bee0
Format code according to PSR2
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:56:50 +07:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +07:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +07:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +07:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +07:00
42625a46be
Remove spaces after method or function call
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:05:56 +07:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +07:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +07:00
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +07:00
bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id
...
Add optional comments reference_id
2020-04-02 11:34:21 +07:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +07:00
720dc4e93d
Add optional column oc_comments.reference_id
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-31 10:51:15 +07:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +07:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +07:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +07:00
5a33cb0b78
Register an address book with recent contacts
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 16:16:45 +07:00
0c38569c83
Implement occ command security:bruteforceattemps:reset-for-ip
...
Signed-off-by: Johannes Riedel <joeried@users.noreply.github.com>
2020-03-19 16:20:22 +07:00
0317c5b5c8
Correctly append the port to the host so it's written to the config correctly
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-05 13:58:37 +07:00
6127c288e8
Fix license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-13 14:23:49 +07:00
4defd0419a
Merge pull request #18576 from BernieO/bernieo-convertInteractive
...
enable option '--no-interaction' for db:convert-type
2020-01-07 15:54:06 +07:00
04aa4cf339
Fix typo in occ
...
Signed-off-by: Kim Brose <kim.brose@rwth-aachen.de>
2020-01-03 04:17:11 +07:00
6a017eb205
Introduce new variable with the default answer to allow option --no-interaction for command occ db:convert-type
...
Variable is set to true for --no-interaction and false otherwise
Signed-off-by: Bernhard Ostertag <bernieo.code@gmx.de>
2019-12-29 11:03:51 +07:00
fe0e47bf5e
enable option '--no-interaction' for db:convert-type
...
Signed-off-by: Bernhard Ostertag <bernieo.code@gmx.de>
2019-12-27 07:50:30 +07:00
1b46621cd3
Update license headers for 18
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-20 09:23:25 +07:00
3eee359d7f
Allow to force enable apps via CLI
...
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-13 13:06:12 +07:00
699f3a6817
Convert various columns in oc_mounts to bigint
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-12-09 14:13:18 +07:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +07:00
b1dffc5c2d
Merge pull request #17896 from nextcloud/fix/noid/consider-create-group-result
...
take group creation result into consideration
2019-11-25 17:16:40 +07:00
279c0cb2ed
Merge pull request #18098 from nextcloud/fix/migration_import_order
...
Fix the import order of new migrations
2019-11-25 14:11:09 +07:00
c7d5b8fc49
Merge pull request #18079 from nextcloud/fixes/phpcs
...
Some php-cs fixes
2019-11-25 14:07:00 +07:00
b4408e4245
fix and improve check of create group result
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-25 14:01:25 +07:00
7ff15c9756
fix documentation, get and createGroup may return null
...
* also have stricter checks in place
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-25 14:01:25 +07:00
20ec763337
Merge pull request #18027 from str0g/fix/14920/convert_type_boolean
...
Incorrect integer value: '' for column 'password_invalid' while migra…
2019-11-25 11:37:45 +07:00
f79d98e089
Fix the import order of new migrations
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-25 09:46:39 +07:00
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +07:00
decdb6b40f
Convert more columns to bigint
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-20 19:31:17 +07:00
23084558a6
Incorrect integer value: '' for column 'password_invalid' while migrating from pg to mysql #14920
...
Signed-off-by: Łukasz Buśko <busko.lukasz@pm.me>
2019-11-20 14:01:46 +07:00
d180a98714
Make it possible to broadcast events to (web) clients
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-10-28 13:58:13 +07:00
5d01850dce
Add detailed users listing in occ user:info command
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-17 10:38:53 +07:00
68cf47e947
Check and add index on principaluri for schedulingobjects table
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2019-10-08 10:25:56 +07:00
90e5850cc4
Add index on calendarid for calendarobject_props table
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2019-10-07 22:03:15 +07:00
62399c76e8
Allow group displaynames in the database backend ( #17221 )
...
Allow group displaynames in the database backend
2019-10-05 18:34:14 +07:00
2ad33bc06e
Add Fatal logging option
...
Signed-off-by: Tim Terhorst <mynamewastaken+gitlab@gmail.com>
2019-10-02 21:18:29 +07:00
b9f963225f
Do not allow to have an empty display name
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-09-27 14:29:57 +07:00
653628c8fb
Allow to set the group display name in the database backend
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-09-27 14:29:56 +07:00
5a03189ce7
Mimetype list integrity check should not fail if it's changed ( #15810 )
...
Mimetype list integrity check should not fail if it's changed
2019-07-07 20:01:58 +07:00
d814089c6a
Fix appid argument for integrity:check-app
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-06-25 14:53:12 +07:00
d8707c6945
Add function parameter typehint
...
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
2019-05-29 23:16:06 +07:00
d227f4d34c
Do not fail integrity check if mimetype list is changed
...
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
2019-05-29 22:43:23 +07:00
98047e8c1c
Stop decryption when maintenance mode is enabled, fixes #8311
...
Signed-off-by: Ruben Homs <ruben@homs.codes>
2019-05-21 09:24:50 +07:00
887c208f23
Fix #15042
2019-04-18 15:28:00 +07:00
592093079f
Deduplicate index names
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-27 13:32:59 +07:00
274658629d
Make sure all tables have named indexes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-27 13:32:59 +07:00
2cc4118629
Merge pull request #14066 from nextcloud/feature/noid/casted-system-values
...
Get typed system values
2019-02-22 11:54:20 +07:00
0c77cd21f9
Make sure maintenance mode is always casted to bool
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-02-22 08:25:41 +07:00
1d1068753f
Fix access to groupManager
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-20 18:05:21 +07:00
75b7d6ae4e
Add install logic for enable command
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-19 21:03:06 +07:00
03d3192638
Disable multiple apps at once
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-19 21:03:05 +07:00
08907ee3e9
Enable multiple apps at once
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-19 21:03:00 +07:00
0b58b0faf3
Do not run getRepairSteps in register_commands
...
getRepairSteps is quite expensive (because every repair step is
initialized and their dependencies are injected). Should not
call it during register.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-02-13 23:06:46 +07:00
8002779200
add support for boolean default
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
code cleaning
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
code cleaning
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2019-01-09 11:21:14 +07:00
16cc68a2fe
Add twofactor_providers_uid index
...
Fixes #12943
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-21 13:03:02 +07:00
17b2827bbf
Add setup check for pending bigint conversion
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-05 13:42:31 +07:00
f57e334f83
Fix bigint conversion on SQLite
...
* on SQLite primary keys can't be bigint - see https://stackoverflow.com/a/18835967/520507
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-05 00:35:09 +07:00
d3b4127164
Show columns to update in CLI interface
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-05 00:35:09 +07:00
bb352fb667
Use the defined func()->count() instead of manual counting
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-08 15:44:45 +07:00
4d20c4272f
Fix index names
...
* see #11527
2018-11-06 15:21:16 +07:00
8bfbefa117
Merge pull request #11053 from nextcloud/occ-app-update-command
...
occ app update command
2018-11-02 00:41:59 +07:00
290ede1292
Log exception in case an app update fails
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-01 17:13:42 +07:00
020a9add07
Add occ app:update command
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-01 17:13:12 +07:00
f5a1f4bc1b
Revert "Wait for cron to finish before running upgrade command"
...
This reverts commit 18e9631810
2018-11-01 15:23:40 +07:00
13fe7b6fc1
Merge pull request #11627 from nextcloud/feature/noid/cli-remove-app
...
Add occ app:remove CLI command
2018-10-30 00:35:45 +07:00
8177fdb0f6
Merge pull request #11765 from nextcloud/feature/mandatory-2fa-for-groups
...
Mandatory 2FA for groups
2018-10-15 10:58:05 +07:00
83e994c11f
Make it possible to enforce mandatory 2FA for groups
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-15 08:22:52 +07:00
ec2f02f4a0
Check if TTY is invalid in encryption:encrypt-all and encryption:decrypt-all
...
Signed-off-by: Evgeny Golyshev <eugulixes@gmail.com>
2018-10-14 15:06:14 +07:00
6a00521128
Use error styling for exception message
...
Signed-off-by: Patrik Kernstock <info@pkern.at>
2018-10-10 18:28:26 +07:00
4cd7cf86db
Using Throwable instead of Exception
...
Signed-off-by: Patrik Kernstock <info@pkern.at>
2018-10-10 17:32:50 +07:00
311de17730
Rename method to abortIfInterrupted
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-08 13:05:00 +07:00
14d802b8f3
Refactor method to throw exception instead of true/false
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-07 18:12:38 +07:00
1973556346
Log exception using ILogger
...
Signed-off-by: Patrik Kernstock <info@pkern.at>
2018-10-05 21:09:13 +07:00
f27ce6b5a0
Inject AppManager and Installer, check for shipped app prior removing
...
Signed-off-by: Patrik Kernstock <info@pkern.at>
2018-10-05 19:51:50 +07:00
f8771d3d81
Run uninstall tasks by default, added '--keep-data' parameter
...
Signed-off-by: Patrik Kernstock <info@pkern.at>
2018-10-05 12:49:34 +07:00
d9469a6b72
Add occ app:remove CLI command
...
Signed-off-by: Patrik Kernstock <info@pkern.at>
2018-10-05 03:08:03 +07:00
a4eb3ee508
Validate email in occ command
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-02 22:24:30 +07:00
6c805ec9ba
Add --admin-email to cli installer
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-02 22:24:30 +07:00
b82cbe04df
Add uid_owner and uid_initiator share tabe indices
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-01 23:59:36 +07:00
259c0ce11d
Add mandatory 2FA service/class
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-09-30 11:47:29 +07:00
Joas Schilling
Joas Schilling
Christoph Wurst
Louis Chemineau
Carl Schwan
Julius Härtl
Côme Chilliet
Vincent Petry
Christoph Wurst
John Molakvoæ
Robin Appelman
Arthur Schiwon
Daniel Kesselberg
Valdnet
John Molakvoæ
Morris Jobke
Johannes Leuker
Bjoern Schiessle
Roeland Jago Douma
Maxopoly
Simon Spannagel
Roeland Jago Douma
Daniel Calviño Sánchez
dependabot-preview[bot]
Sean Molenaar
timm2k
Nils Wittenbrink
Mario Danic
Sander Ruitenbeek
Johannes Riedel
Kim Brose
Bernhard Ostertag
Georg Ehrke
Łukasz Buśko
Thomas Citharel
Tim Terhorst
Xheni Myrtaj
Ruben Homs
Temtaime
Maxence Lange
Michael Gerber
Evgeny Golyshev
Patrik Kernstock