98ea74bb40
Merge pull request #38764 from fsamapoor/constructor_property_promotion_in_core_command_part2
...
Uses PHP8's constructor property promotion in core/Command/Db classes.
2023-06-19 17:27:10 +07:00
cda0f74e0b
Moves single constructor parameters to new lines.
...
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:27 +07:00
ea844ca5fb
Uses PHP8's constructor property promotion.
...
in core/Command/App, /Background, and /Broadcast classes.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:27 +07:00
d60bedfeee
Moves single constructor parameters to new lines.
...
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:22 +07:00
ec63264153
Uses PHP8's constructor property promotion in core/Command/Maintenance classes.
...
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:22 +07:00
1e8ec53b8c
Update core/Command/Db/ConvertType.php
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-19 12:55:15 +07:00
73d7c45ae1
Update core/Command/Db/ConvertFilecacheBigInt.php
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-19 12:55:15 +07:00
d34cafc58c
Update core/Command/Db/Migrations/MigrateCommand.php
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-19 12:55:15 +07:00
f1a19a10fc
Update core/Command/Db/Migrations/StatusCommand.php
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-19 12:55:15 +07:00
b5cbba7fc1
Uses PHP8's constructor property promotion in core/Command/Db classes.
...
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:15 +07:00
9dc4efc52a
Moves single constructor parameters to new lines.
...
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:10 +07:00
99f117146d
Uses PHP8's constructor property promotion in core/Command/User classes.
...
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:10 +07:00
095b43f396
feat: Add occ user:sync-account-data for updating oc_accounts information from user backends
...
This can be useful in cases where the state between user backend and
oc_accounts has become inconsistent.
Usually the account data is updated once the change on the user backend
is detected. Potential leftovers from older bugs
(https://github.com/nextcloud/user_saml/pull/582 ) might though never get
updated. This could lead to the contacts menu never showing the correct
display name. The contacts menu is read from the system address book,
which is only updated from oc_accounts.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-06-09 17:30:24 +07:00
cf6e2fa1b7
chore: Drop \OC_App::getAppVersion
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:26 +07:00
0fca8238dd
Merge pull request #37665 from fsamapoor/patch-2
...
Refactors Command/Encryption/Enable.php to improve code readability.
2023-05-23 20:56:18 +07:00
9d2d3d482b
Merge pull request #38148 from nextcloud/file-info-etag
...
also show file etag in file info
2023-05-11 13:21:48 +07:00
0048071438
Merge pull request #38069 from nextcloud/list-supported-db
2023-05-09 17:16:26 +07:00
cdcd6f2872
also show file etag in file info
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-09 14:56:37 +07:00
cd3e7fd1b0
list supported databases when provided db isn't supported
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-04 14:43:48 +07:00
5c31c35d40
add option to list all files instead of limiting
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-04 13:10:26 +07:00
2b4bd02be9
add command to summarize space usage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-04 13:10:25 +07:00
f7632f2fc4
Merge pull request #32866 from nextcloud/performance/searchInGroup-displayname-cache
...
Optimize retrieving display name when searching for users in a group
2023-05-02 16:42:09 +07:00
db43d90387
add new index in repair step instead of on-migrate
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-28 15:08:08 +07:00
876c162df8
Use the searchDisplayName recommended method in user:list
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 15:25:13 +07:00
6d9f785afb
Merge pull request #37622 from nextcloud/group-list-numeric-userid
...
fix output for group:list command with numeric user ids
2023-04-24 17:14:11 +07:00
c5dfa1cb79
validate that folder size sums to children
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-17 16:23:52 +07:00
60cf0c8f5f
add command for getting fileinfo for debugging
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-17 16:23:52 +07:00
8f4b20aaa1
Refactors core/Command/Encryption/Enable.php to improve code readability.
...
Improves the readability of the "execute" method by using early returns and reducing the code indentation.
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-04-11 09:29:44 +07:00
b89621e8da
fix output for group:list command with numeric user ids
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-06 16:31:39 +07:00
013eedabbd
add command to generate a preview for a file
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-03 17:30:57 +07:00
bda66f9fb6
Add parent index on filecache
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-03-20 15:02:23 +07:00
ff2c397c23
Merge pull request #36862 from nextcloud/bugfix/typo
...
Fix typo that added a letter to migration template
2023-02-26 22:22:33 +07:00
fd4c53f311
Fix typo that added a letter to migration template
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-02-25 12:48:22 +07:00
e0251ea24e
Fail the repair command when an error happened
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-23 16:57:52 +07:00
d00422b812
Fix computerFileSize when called with a string without unit
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:30 +07:00
5e18ffa89d
FIX: This fill finish -> This will finish
...
Signed-off-by: sodimel <corentin@244466666.xyz>
2023-01-26 21:05:01 +07:00
3f231d68d7
Merge pull request #36271 from nextcloud/fix/fix-codestyle
...
Fix codestyle using codesniffer
2023-01-20 15:26:17 +07:00
473c546b5c
Merge pull request #36264 from nextcloud/fix/occ/repair-command-comment-formatting
...
fix(occ): Fix comment formatting of maintenance:repair command
2023-01-20 13:12:43 +07:00
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
90b955b1e9
Attempt to fix errors in Repair command tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:09 +07:00
a8bad3a98f
fix(occ): Fix comment formatting of maintenance:repair command
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-20 10:00:41 +07:00
d42d8b79e0
Merge pull request #36162 from nextcloud/fix/php82/string-var-interpolation
...
fix(PHP8.2): Fix deprecated string interpolation syntax
2023-01-19 18:05:44 +07:00
a25645648e
Merge pull request #36123 from nextcloud/user-settings-normalize-uid
...
normalize userid in user:setting
2023-01-19 17:45:01 +07:00
2e66acfab8
fix(PHP8.2): Fix deprecated string interpolation syntax
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-19 13:10:02 +07:00
06a572ff55
Merge pull request #27492 from cyclops8456/feature/24301-remove-can-install-on-occ-maintenance-install
...
Remove the CAN_INSTALL file when occ maintenance:install is complete
2023-01-18 19:53:02 +07:00
975becb22e
normalize userid in user:setting
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-01-12 17:33:03 +07:00
d74044f634
Fix API breakage by using a new method instead
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-12 17:18:59 +07:00
679682c186
Use a Generator for job list to fix background-job:list command
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-10 18:20:31 +07:00
644df591b1
Rename canInstallExists method and add new method for removal
...
Rename canInstallExists to shouldRemoveCanInstallFile to cover removal of this file for non-git channels and logging any failure to remove it.
Add new method to detect if this file exists during web based installation.
Signed-off-by: Alex Harpin <development@landsofshadow.co.uk>
2023-01-10 11:59:06 +07:00
d5b52ddd21
Log a warning to CLI install command if CAN_INSTALL is not removed
...
Log a warning for the CLI install command if the CAN_INSTALL file still exists at the end of the installation. This matches the warning logged by the web installer.
Signed-off-by: Alex Harpin <development@landsofshadow.co.uk>
2023-01-10 11:59:06 +07:00
c8160a6150
Merge pull request #35873 from leegarrett/35830_lgarrett
...
Implement occ status command via return codes v2 (Fixes : #35704 )
2023-01-04 09:51:12 +07:00
2c1a811e27
No output by default when --exit-code is used
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-03 15:43:25 +07:00
8e1f742355
Print output also with status code
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-03 12:47:58 +07:00
fba906e34a
Implement occ status command via return codes ( Fixes : #35704 )
...
Running `./occ status -e` will produce any output. However, it will:
exit 0 during normal operation,
exit 1 when in maintenance mode,
exit 2 when `./occ upgrade` is needed.
Signed-off-by: Lee Garrett <lgarrett@rocketjump.eu>
2023-01-03 10:58:07 +07:00
9430899f16
Fix psalm issues related to signature changes from PHP 8.0
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-29 12:36:34 +07:00
1da6c21036
Show version from appinfo on occ app:list
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-11 14:45:11 +07:00
7dc8e6a014
fix repairing non user shares when repairing all shares
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 17:13:52 +07:00
b66779711f
split repairing into two stages to prevent long open transaction
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 17:13:44 +07:00
8012c85d3e
update shares directly in db
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 17:13:41 +07:00
1be1c23c05
More verbose output for repair share ownership cmd
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-08 17:13:37 +07:00
3d68a526e7
move share owner repair to occ command
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 17:13:33 +07:00
e4d3344076
Merge pull request #32859 from nextcloud/bug/31973/array-key-might-be-empty
...
Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39
2022-10-11 11:15:05 +07:00
aaf9b9c4fd
properly typehint generated migrations
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2022-10-09 21:26:16 +07:00
6ff58d30b4
Update ConvertFilecacheBigInt.php
...
Signed-off-by: timm2k <timm2k@gmx.de>
2022-09-14 10:15:16 +07:00
9a29025534
Parameter of RepairAdvanceEvent is actually an increment, not a step id
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:26:31 +07:00
652ab6da3f
Surround cli output with appropriate xml tags
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:18:53 +07:00
5cfdf9b9ee
Add void return types to callables
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:15:49 +07:00
a2a7150d6d
Migrate Repair events to OCP\EventDispatcher\Event
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:15:48 +07:00
a83a8f0dde
Migrate Migrator::executeSql to OCP\EventDispatcher\Event
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:13:47 +07:00
5aac997d44
Remove listeners of \OC\DB\Migrator::checkTable which is never emitted
...
See commit a2f3077ee8#24384
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:13:47 +07:00
4f260dce6e
Moving to string key for arguments of GenericEvent in Repair
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:13:46 +07:00
4ba30d40cf
Switch to string keys for argument of GenericEvent for OC\DB\Migrator
...
It seems checkTable is actually never dispatched?
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:13:46 +07:00
f8b13ecd60
Merge pull request #32363 from nextcloud/cleanup/remove-long-deprecated-classes
...
Remove OCP\App and OCP\BackgroundJob
2022-08-08 17:05:11 +07:00
047cc708d4
DB mounts table: Add index for mount_provider_class
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2022-08-01 14:27:34 +07:00
458c2fa297
Remove OCP\App and OCP\BackgroundJob
...
Both deprecated since NC 23
IAppManager is the replacement for OCP\App unfortunately it can't be
dependency injected in classes used by the installed otherwise the
database connection is initialised too early
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-01 09:46:40 +07:00
cc89da26c6
Fix background-job:execute command for QueuedJob instances
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
3920fc1ef2
Format the datetime for last run in ATOM format
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
0cc39d185c
Use symfony console table to render the job list properly
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
868d748dbf
Code cleaning of Background/ListCommand
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
3d01179907
Add command to list jobs
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
6f3ab2fc9b
Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-06-28 15:45:41 +07:00
fb8d54ef72
Fix undefined when no tags
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-06-28 15:44:08 +07:00
fbae6ffa98
Fix importing float value
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-23 12:08:42 +07:00
b70c6a128f
Update core to PHP 7.4 standard
...
- Typed properties
- Port to LoggerInterface
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 22:18:06 +07:00
106d5f9c5c
Merge pull request #32196 from nextcloud/bugfix/noid/fix-strict-comparison
...
Fix strict comparison
2022-05-02 08:19:10 +07:00
b865722ac0
Remove deprecated occ app:check-code command
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-28 15:08:01 +07:00
60801d8b1c
Fix strict comparison
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-27 20:31:40 +07:00
2ffcc08332
Fix type fixing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-25 16:49:23 +07:00
7ee982005a
Give hints on correct migration versioning
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-25 16:21:25 +07:00
7fbd93b2ad
Additional index on oc_preferences to make sure that gettingh values without a user filter is fast
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-04-19 12:37:36 +07:00
cfd2e8cc20
Allow to autocomplete user and group ids in commands
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-08 11:54:44 +07:00
835e28d0b2
Merge pull request #31661 from nextcloud/enh/user_ldap-add-command-to-unmap-groups
...
Add ldap:reset-group command to unmap groups from LDAP
2022-04-05 10:57:33 +07:00
498d3aea06
Merge pull request #31687 from nextcloud/enhancement/passwordless-app-passwords
...
Allow app passwords without login password for occ user:add-app-password
2022-04-04 11:46:17 +07:00
77bdad84c2
Add ldap:reset-group command to unmap groups from LDAP
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-01 12:18:02 +07:00
9191ca43ce
Merge pull request #31735 from nextcloud/fix/noid/mig-generator-copyright
...
migration generator also includes copyright section
2022-03-29 16:49:43 +07:00
765999f454
Merge pull request #31609 from nextcloud/fix/migrate-away-from-ilogger
...
Migrate from ILogger to LoggerInterface in lib/private
2022-03-29 09:39:38 +07:00
ee006563ae
migration generator also includes copyright section
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-03-28 15:35:17 +07:00
ea23523c70
Adapt more code to migration to LoggerInterface
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:25 +07:00
970fb7ce65
Don't create cards_abiduri it if already exists
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-03-24 10:42:22 +07:00
515235163c
Allow app passwords without login password for occ user:add-app-password
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-03-23 18:47:33 +07:00
Louis
Faraz Samapoor
Faraz Samapoor
Julius Härtl
Christoph Wurst
Arthur Schiwon
Robin Appelman
John Molakvoæ
Côme Chilliet
Côme Chilliet
Louis Chemineau
Joas Schilling
Vitor Mattos
Joas Schilling
sodimel
Christoph Wurst
Vincent Petry
Simon L
Alex Harpin
Lee Garrett
Roeland Jago Douma
timm2k
Carl Schwan
Marcel Klehr
Daniel Kesselberg