chore: Remove references to obsolete field ocsid in apps info.xml

It’s not even allowed by our xsd schema.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

lib/private/App/AppManager.php

@@ -994,11 +994,6 @@ class AppManager implements IAppManager {
 		\OC_App::setupBackgroundJobs($appData['background-jobs']);
 
 		//set remote/public handlers
-		if (array_key_exists('ocsid', $appData)) {
-			$this->config->setAppValue($appId, 'ocsid', $appData['ocsid']);
-		} elseif ($this->config->getAppValue($appId, 'ocsid') !== '') {
-			$this->config->deleteAppValue($appId, 'ocsid');
-		}
 		foreach ($appData['remote'] as $name => $path) {
 			$this->config->setAppValue('core', 'remote_' . $name, $appId . '/' . $path);
 		}

lib/private/Installer.php

@@ -613,9 +613,6 @@ class Installer {
 		OC_App::executeRepairSteps($app, $info['repair-steps']['install']);
 
 		$config->setAppValue($app, 'installed_version', $appManager->getAppVersion($app));
-		if (array_key_exists('ocsid', $info)) {
-			$config->setAppValue($app, 'ocsid', $info['ocsid']);
-		}
 
 		//set remote/public handlers
 		foreach ($info['remote'] as $name => $path) {

tests/data/app/expected-info.json

@@ -16,7 +16,6 @@
 		"admin": "admin-encryption"
 	},
 	"types": ["filesystem"],
-	"ocsid": "166047",
 	"dependencies": {
 		"php": {
 			"@attributes" : {

tests/data/app/invalid-info.xml

@@ -22,5 +22,4 @@
 	<types>
 		<filesystem/>
 	</types>
-	<ocsid>166047</ocsid>
 </info>

tests/data/app/valid-info.xml

@@ -22,7 +22,6 @@
 	<types>
 		<filesystem/>
 	</types>
-	<ocsid>166047</ocsid>
 	<dependencies>
 		<php min-version="5.4" max-version="5.5"/>
 		<database min-version="3.0">sqlite</database>