sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: Remove references to obsolete field ocsid in apps info.xml 

It’s not even allowed by our xsd schema.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
pull/53895/head
Côme Chilliet 2025-07-10 16:46:56 +07:00
parent 42c980e093
commit f5fac6476f
No known key found for this signature in database
GPG Key ID: A3E2F658B28C760A
5 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/private/App/AppManager.php
Unescape Escape View File

@ -994,11 +994,6 @@ class AppManager implements IAppManager {
\OC_App::setupBackgroundJobs($appData['background-jobs']); \OC_App::setupBackgroundJobs($appData['background-jobs']);
//set remote/public handlers //set remote/public handlers
if (array_key_exists('ocsid', $appData)) {
$this->config->setAppValue($appId, 'ocsid', $appData['ocsid']);
} elseif ($this->config->getAppValue($appId, 'ocsid') !== '') {
$this->config->deleteAppValue($appId, 'ocsid');
}
foreach ($appData['remote'] as $name => $path) { foreach ($appData['remote'] as $name => $path) {
$this->config->setAppValue('core', 'remote_' . $name, $appId . '/' . $path); $this->config->setAppValue('core', 'remote_' . $name, $appId . '/' . $path);
} }

3
lib/private/Installer.php
Unescape Escape View File

@ -613,9 +613,6 @@ class Installer {
OC_App::executeRepairSteps($app, $info['repair-steps']['install']); OC_App::executeRepairSteps($app, $info['repair-steps']['install']);
$config->setAppValue($app, 'installed_version', $appManager->getAppVersion($app)); $config->setAppValue($app, 'installed_version', $appManager->getAppVersion($app));
if (array_key_exists('ocsid', $info)) {
$config->setAppValue($app, 'ocsid', $info['ocsid']);
}
//set remote/public handlers //set remote/public handlers
foreach ($info['remote'] as $name => $path) { foreach ($info['remote'] as $name => $path) {

1
tests/data/app/expected-info.json
Unescape Escape View File

@ -16,7 +16,6 @@
"admin": "admin-encryption" "admin": "admin-encryption"
}, },
"types": ["filesystem"], "types": ["filesystem"],
"ocsid": "166047",
"dependencies": { "dependencies": {
"php": { "php": {
"@attributes" : { "@attributes" : {

1
tests/data/app/invalid-info.xml
Unescape Escape View File

@ -22,5 +22,4 @@
<types> <types>
<filesystem/> <filesystem/>
</types> </types>
<ocsid>166047</ocsid>
</info> </info>

1
tests/data/app/valid-info.xml
Unescape Escape View File

@ -22,7 +22,6 @@
<types> <types>
<filesystem/> <filesystem/>
</types> </types>
<ocsid>166047</ocsid>
<dependencies> <dependencies>
<php min-version="5.4" max-version="5.5"/> <php min-version="5.4" max-version="5.5"/>
<database min-version="3.0">sqlite</database> <database min-version="3.0">sqlite</database>