sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove superfluous ?> at the end of .php files (left out apps/*/templates)

remotes/origin/stable5
Jörn Friedrich Dreyer 2012-07-09 16:51:16 +07:00
parent b67199bb45
commit e59a1806cf
118 changed files with 41 additions and 249 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
apps/bookmarks/lib/bookmarks.php
Unescape Escape View File

@ -146,4 +146,3 @@ class OC_Bookmarks_Bookmarks{
return true;
}
}
?>

1
apps/contacts/ajax/addbook.php
Unescape Escape View File

@ -17,4 +17,3 @@ $tmpl = new OCP\Template('contacts', 'part.editaddressbook');
$tmpl->assign('new', true);
$tmpl->assign('addressbook', $book);
$tmpl->printPage();
?>

1
apps/contacts/ajax/categories/categoriesfor.php
Unescape Escape View File

@ -25,4 +25,3 @@ foreach($vcard->children as $property){
}
}
OCP\JSON::error(array('data' => array('message' => OC_Contacts_App::$l10n->t('Error setting checksum.'))));
?>

2
apps/contacts/ajax/categories/delete.php
Unescape Escape View File

@ -45,5 +45,3 @@ $catman->delete($categories, $cards);
debug('After delete: '.print_r($catman->categories(), true));
OC_Contacts_VCard::updateDataByID($cards);
OCP\JSON::success(array('data' => array('categories'=>$catman->categories())));
?>

2
apps/contacts/ajax/categories/list.php
Unescape Escape View File

@ -13,5 +13,3 @@ OCP\JSON::checkAppEnabled('contacts');
$categories = OC_Contacts_App::getCategories();
OCP\JSON::success(array('data' => array('categories'=>$categories)));
?>

2
apps/contacts/ajax/categories/rescan.php
Unescape Escape View File

@ -14,5 +14,3 @@ OC_Contacts_App::scanCategories();
$categories = OC_Contacts_App::getCategories();
OCP\JSON::success(array('data' => array('categories'=>$categories)));
?>

2
apps/contacts/ajax/currentphoto.php
Unescape Escape View File

@ -51,5 +51,3 @@ if( is_null($contact)) {
bailOut(OC_Contacts_App::$l10n->t('The loading photo is not valid.'));
}
}
?>

2
apps/contacts/ajax/editaddress.php
Unescape Escape View File

@ -39,5 +39,3 @@ $tmpl->assign('adr_types',$adr_types);
$page = $tmpl->fetchPage();
OCP\JSON::success(array('data' => array('page'=>$page, 'checksum'=>$checksum)));
?>

1
apps/contacts/ajax/editaddressbook.php
Unescape Escape View File

@ -14,4 +14,3 @@ $tmpl = new OCP\Template("contacts", "part.editaddressbook");
$tmpl->assign('new', false);
$tmpl->assign('addressbook', $addressbook);
$tmpl->printPage();
?>

2
apps/contacts/ajax/editname.php
Unescape Escape View File

@ -32,5 +32,3 @@ if($id) {
}
$page = $tmpl->fetchPage();
OCP\JSON::success(array('data' => array('page'=>$page)));
?>

1
apps/contacts/ajax/importaddressbook.php
Unescape Escape View File

@ -21,4 +21,3 @@ $tmpl->assign('uploadMaxFilesize', $maxUploadFilesize);
$tmpl->assign('requesttoken', $_SERVER['HTTP_REQUESTTOKEN']);
$tmpl->assign('uploadMaxHumanFilesize', OCP\Util::humanFileSize($maxUploadFilesize));
$tmpl->printpage();
?>

1
apps/contacts/ajax/importdialog.php
Unescape Escape View File

@ -13,4 +13,3 @@ $tmpl = new OCP\Template('contacts', 'part.import');
$tmpl->assign('path', $_POST['path']);
$tmpl->assign('filename', $_POST['filename']);
$tmpl->printpage();
?>

2
apps/contacts/ajax/oc_photo.php
Unescape Escape View File

@ -58,5 +58,3 @@ if(OC_Cache::set($tmpkey, $image->data(), 600)) {
} else {
bailOut('Couldn\'t save temporary image: '.$tmpkey);
}
?>

3
apps/contacts/ajax/uploadimport.php
Unescape Escape View File

@ -70,6 +70,3 @@ if(file_exists($file['tmp_name'])) {
} else {
bailOut('Temporary file: \''.$file['tmp_name'].'\' has gone AWOL?');
}
?>

1
apps/contacts/ajax/uploadphoto.php
Unescape Escape View File

@ -102,4 +102,3 @@ if(file_exists($file['tmp_name'])) {
} else {
bailOut('Temporary file: \''.$file['tmp_name'].'\' has gone AWOL?');
}
?>

1
apps/contacts/export.php
Unescape Escape View File

@ -32,4 +32,3 @@ if(isset($bookid)){
header('Content-Disposition: inline; filename=' . str_replace(' ', '_', $data['fullname']) . '.vcf');
echo $data['carddata'];
}
?>

2
apps/contacts/index.php
Unescape Escape View File

@ -73,5 +73,3 @@ $tmpl->assign('addressbooks', $addressbooks);
$tmpl->assign('details', $details );
$tmpl->assign('id',$id);
$tmpl->printPage();
?>

1
apps/contacts/settings.php
Unescape Escape View File

@ -4,4 +4,3 @@ $tmpl = new OCP\Template( 'contacts', 'settings');
$tmpl->assign('addressbooks', OC_Contacts_Addressbook::all(OCP\USER::getUser()), false);
return $tmpl->fetchPage();
?>

1
apps/external/ajax/setsites.php vendored
Unescape Escape View File

@ -23,4 +23,3 @@ else
OCP\Config::setAppValue('external', 'sites', json_encode($sites));
echo 'true';
?>

1
apps/external/index.php vendored
Unescape Escape View File

@ -40,4 +40,3 @@ if (isset($_GET['id'])) {
$tmpl->printPage();
}
}
?>

2
apps/external/lib/external.php vendored
Unescape Escape View File

@ -32,5 +32,3 @@ class OC_External {
}
}
?>

1
apps/external/settings.php vendored
Unescape Escape View File

@ -7,4 +7,3 @@ OCP\Util::addscript( "external", "admin" );
$tmpl = new OCP\Template( 'external', 'settings');
return $tmpl->fetchPage();
?>

2
apps/files/ajax/autocomplete.php
Unescape Escape View File

@ -52,5 +52,3 @@ if(OC_Filesystem::file_exists($base) and OC_Filesystem::is_dir($base)){
}
}
OCP\JSON::encodedPrint($files);
?>

2
apps/files/ajax/delete.php
Unescape Escape View File

@ -26,5 +26,3 @@ if($success) {
} else {
OCP\JSON::error(array("data" => array( "message" => "Could not delete:\n" . $filesWithError )));
}
?>

1
apps/files/ajax/download.php
Unescape Escape View File

@ -34,4 +34,3 @@ $files = $_GET["files"];
$dir = $_GET["dir"];
OC_Files::get($dir, $files, $_SERVER['REQUEST_METHOD'] == 'HEAD' ? true : false);
?>

2
apps/files/ajax/list.php
Unescape Escape View File

@ -42,5 +42,3 @@ $list->assign( "files", $files, false );
$data = array('files' => $list->fetchPage());
OCP\JSON::success(array('data' => $data));
?>

2
apps/files/ajax/mimeicon.php
Unescape Escape View File

@ -7,5 +7,3 @@ $RUNTIME_NOAPPS=false;
print OC_Helper::mimetypeIcon($_GET['mime']);
?>

2
apps/files/ajax/move.php
Unescape Escape View File

@ -17,5 +17,3 @@ if(OC_Files::move($dir,$file,$target,$file)){
}else{
OCP\JSON::error(array("data" => array( "message" => "Could not move $file" )));
}
?>

2
apps/files/ajax/rawlist.php
Unescape Escape View File

@ -22,5 +22,3 @@ foreach( OC_Files::getdirectorycontent( $dir, $mimetype ) as $i ){
}
OCP\JSON::success(array('data' => $files));
?>

2
apps/files/ajax/rename.php
Unescape Escape View File

@ -18,5 +18,3 @@ if( OC_Files::move( $dir, $file, $dir, $newname )) {
else{
OCP\JSON::error(array("data" => array( "message" => "Unable to rename file" )));
}
?>

2
apps/files/ajax/timezone.php
Unescape Escape View File

@ -3,4 +3,4 @@
// see lib/base.php for an example
//session_start();
$_SESSION['timezone'] = $_GET['time'];
?>

2
apps/files/ajax/upload.php
Unescape Escape View File

@ -60,5 +60,3 @@ if(strpos($dir,'..') === false){
}
OCP\JSON::error(array('data' => array('error' => $error, "file" => $fileName)));
?>

1
apps/files/download.php
Unescape Escape View File

@ -46,4 +46,3 @@ header('Content-Length: '.OC_Filesystem::filesize($filename));
@ob_end_clean();
OC_Filesystem::readfile( $filename );
?>

2
apps/files/index.php
Unescape Escape View File

@ -98,5 +98,3 @@ $tmpl->assign( 'uploadMaxFilesize', $maxUploadFilesize);
$tmpl->assign( 'uploadMaxHumanFilesize', OCP\Util::humanFileSize($maxUploadFilesize));
$tmpl->assign( 'allowZipDownload', intval(OCP\Config::getSystemValue('allowZipDownload', true)));
$tmpl->printPage();
?>

2
apps/files/settings.php
Unescape Escape View File

@ -56,5 +56,3 @@ $tmpl = new OCP\Template( "files", "index", "user" );
$tmpl->assign( 'files', $files );
$tmpl->assign( "breadcrumb", $breadcrumb );
$tmpl->printPage();
?>

2
apps/files_external/ajax/addMountPoint.php
Unescape Escape View File

@ -11,5 +11,3 @@ if ($_POST['isPersonal'] == 'true') {
$isPersonal = false;
}
OC_Mount_Config::addMountPoint($_POST['mountPoint'], $_POST['class'], $_POST['classOptions'], $_POST['mountType'], $_POST['applicable'], $isPersonal);
?>

2
apps/files_external/ajax/removeMountPoint.php
Unescape Escape View File

@ -11,5 +11,3 @@ if ($_POST['isPersonal'] == 'true') {
$isPersonal = false;
}
OC_Mount_Config::removeMountPoint($_POST['mountPoint'], $_POST['mountType'], $_POST['applicable'], $isPersonal);
?>

3
apps/files_external/tests/amazons3.php
Unescape Escape View File

@ -45,6 +45,3 @@ if (!is_array($config) or !isset($config['amazons3']) or !$config['amazons3']['r
}
}
}
?>

2
apps/files_imageviewer/appinfo/app.php
Unescape Escape View File

@ -4,5 +4,3 @@ OCP\Util::addscript( 'files_imageviewer', 'lightbox' );
OCP\Util::addscript('files_imageviewer', 'jquery.mousewheel-3.0.4.pack');
OCP\Util::addscript('files_imageviewer', 'jquery.fancybox-1.3.4.pack');
OCP\Util::addStyle( 'files_imageviewer', 'jquery.fancybox-1.3.4' );
?>

1
apps/files_pdfviewer/appinfo/app.php
Unescape Escape View File

@ -6,4 +6,3 @@ OCP\Util::addscript( 'files_pdfviewer', 'pdfjs/compatibility');
OCP\Util::addscript( 'files_pdfviewer', 'viewer');
OCP\Util::addscript( 'files_pdfviewer', 'pdfjs/build/pdf');
OCP\Util::addscript( 'files_pdfviewer', 'pdfjs/viewer');
?>

2
apps/files_sharing/ajax/email.php
Unescape Escape View File

@ -11,5 +11,3 @@ $link = $_POST['link'];
$text = $user.' shared the '.$type.' '.$_POST['file'].' with you. It is available for download here: '.$link;
$fromaddress = OCP\Config::getUserValue($user, 'settings', 'email', 'sharing-noreply@'.OCP\Util::getServerHost());
OC_Mail::send($_POST['toaddress'], $_POST['toaddress'], $subject, $text, $fromaddress, $user);
?>

2
apps/files_sharing/ajax/getitem.php
Unescape Escape View File

@ -64,5 +64,3 @@ while ($path != $userDirectory) {
}
OCP\JSON::success(array('data' => $item));
?>

2
apps/files_sharing/ajax/getstatuses.php
Unescape Escape View File

@ -20,5 +20,3 @@ if ($rows = OC_Share::getMySharedItems()) {
}
OCP\JSON::success(array('data' => $items));
?>

2
apps/files_sharing/ajax/setpermissions.php
Unescape Escape View File

@ -10,5 +10,3 @@ $permissions = $_POST['permissions'];
OC_Share::setPermissions($source, $uid_shared_with, $permissions);
OCP\JSON::success();
?>

2
apps/files_sharing/ajax/share.php
Unescape Escape View File

@ -35,5 +35,3 @@ foreach ($sources as $source) {
}
}
}
?>

2
apps/files_sharing/ajax/toggleresharing.php
Unescape Escape View File

@ -7,5 +7,3 @@ if ($_POST['resharing'] == true) {
} else {
OCP\Config::setAppValue('files_sharing', 'resharing', 'no');
}
?>

2
apps/files_sharing/ajax/unshare.php
Unescape Escape View File

@ -9,5 +9,3 @@ $uid_shared_with = $_POST['uid_shared_with'];
OC_Share::unshare($source, $uid_shared_with);
OCP\JSON::success();
?>

2
apps/files_sharing/ajax/userautocomplete.php
Unescape Escape View File

@ -28,5 +28,3 @@ $users[] = "</optgroup>";
$groups[] = "</optgroup>";
$users = array_merge($users, $groups);
OCP\JSON::encodedPrint($users);
?>

1
apps/files_sharing/get.php
Unescape Escape View File

@ -86,4 +86,3 @@ if (isset($_GET['token']) && $source = OC_Share::getSource($_GET['token'])) {
$tmpl->printPage();
die();
}
?>

2
apps/files_sharing/lib_share.php
Unescape Escape View File

@ -513,5 +513,3 @@ class OC_Share {
}
}
?>

2
apps/files_sharing/list.php
Unescape Escape View File

@ -33,5 +33,3 @@ OCP\Util::addscript("files_sharing", "list");
$tmpl = new OCP\Template("files_sharing", "list", "user");
$tmpl->assign("shared_items", OC_Share::getMySharedItems());
$tmpl->printPage();
?>

1
apps/files_texteditor/appinfo/app.php
Unescape Escape View File

@ -4,4 +4,3 @@ OCP\Util::addStyle( 'files_texteditor', 'DroidSansMono/stylesheet' );
OCP\Util::addStyle( 'files_texteditor', 'style' );
OCP\Util::addscript( 'files_texteditor', 'editor');
OCP\Util::addscript( 'files_texteditor', 'aceeditor/ace');
?>

2
apps/files_versions/ajax/togglesettings.php
Unescape Escape View File

@ -7,5 +7,3 @@ if (OCP\Config::getSystemValue('versions', 'true')=='true') {
} else {
OCP\Config::setSystemValue('versions', 'true');
}
?>

2
apps/files_versions/history.php
Unescape Escape View File

@ -71,5 +71,3 @@ if ( isset( $_GET['path'] ) ) {
}
$tmpl->printPage( );
?>

2
apps/files_versions/lib/hooks.php
Unescape Escape View File

@ -68,5 +68,3 @@ class Hooks {
}
}
?>

1
apps/files_versions/settings.php
Unescape Escape View File

@ -7,4 +7,3 @@ OCP\Util::addscript( 'files_versions', 'versions' );
$tmpl = new OCP\Template( 'files_versions', 'settings');
return $tmpl->fetchPage();
?>

2
apps/gallery/ajax/createAlbum.php
Unescape Escape View File

@ -28,5 +28,3 @@ OCP\JSON::checkAppEnabled('gallery');
OC_Gallery_Album::create(OCP\USER::getUser(), $_GET['album_name']);
OCP\JSON::success(array('name' => $_GET['album_name']));
?>

1
apps/gallery/ajax/galleryOp.php
Unescape Escape View File

@ -186,4 +186,3 @@ if ($_GET['operation']) {
OCP\JSON::error(array('cause' => 'Unknown operation'));
}
}
?>

1
apps/gallery/index.php
Unescape Escape View File

@ -103,4 +103,3 @@ $tmpl = new OCP\Template( 'gallery', 'index', 'user' );
$tmpl->assign('root', $root, false);
$tmpl->assign('tl', $tl, false);
$tmpl->printPage();
?>

2
apps/gallery/lib/hooks_handlers.php
Unescape Escape View File

@ -38,5 +38,3 @@ class OC_Gallery_Hooks_Handlers {
//TODO: implement this
}
}
?>

2
apps/gallery/lib/images_utils.php
Unescape Escape View File

@ -60,5 +60,3 @@ function CroppedThumbnail($imgSrc,$thumbnail_width,$thumbnail_height, $tgtImg, $
imagedestroy($process);
imagedestroy($myImage);
}
?>

1
apps/gallery/lib/managers.php
Unescape Escape View File

@ -111,4 +111,3 @@ class ThumbnailsManager {
private function __construct() {}
}
?>

2
apps/gallery/lib/tiles.php
Unescape Escape View File

@ -174,5 +174,3 @@ class TileStack extends TileBase {
private $tiles_array;
private $stack_name;
}
?>

2
apps/gallery/lib/tiles_test.php
Unescape Escape View File

@ -83,5 +83,3 @@ if ($ts->getCount() != 0) {
}
echo $tl->get();
?>

1
apps/media/ajax/api.php
Unescape Escape View File

@ -131,4 +131,3 @@ if($arguments['action']){
exit;
}
}
?>

1
apps/media/ajax/autoupdate.php
Unescape Escape View File

@ -35,4 +35,3 @@ $autoUpdate=(isset($_GET['autoupdate']) and $_GET['autoupdate']=='true');
OCP\Config::setUserValue(OCP\USER::getUser(),'media','autoupdate',(integer)$autoUpdate);
OCP\JSON::success(array('data' => $autoUpdate));
?>

2
apps/media/index.php
Unescape Escape View File

@ -40,5 +40,3 @@ OCP\App::setActiveNavigationEntry( 'media_index' );
$tmpl = new OCP\Template( 'media', 'music', 'user' );
$tmpl->printPage();
?>

2
apps/media/lib_ampache.php
Unescape Escape View File

@ -419,5 +419,3 @@ class OC_MEDIA_AMPACHE{
echo('</root>');
}
}
?>

2
apps/media/lib_collection.php
Unescape Escape View File

@ -387,5 +387,3 @@ class OC_MEDIA_COLLECTION{
$query->execute(array($newPath,$oldPath));
}
}
?>

1
apps/media/settings.php
Unescape Escape View File

@ -3,4 +3,3 @@
$tmpl = new OCP\Template( 'media', 'settings');
return $tmpl->fetchPage();
?>

1
apps/remoteStorage/settings.php
Unescape Escape View File

@ -4,4 +4,3 @@ require_once('lib_remoteStorage.php');
$tmpl = new OCP\Template( 'remoteStorage', 'settings');
return $tmpl->fetchPage();
?>

1
apps/user_migrate/appinfo/app.php
Unescape Escape View File

@ -31,4 +31,3 @@ $entry = array(
'href' => OCP\Util::linkTo( "user_migrate", "admin.php" ),
'name' => 'Import'
);
?>

1
apps/user_openid/phpmyid.php
Unescape Escape View File

@ -1705,4 +1705,3 @@ $run_mode = (isset($_REQUEST['openid_mode'])
debug("Run mode: $run_mode at: " . time());
debug($_REQUEST, 'Request params');
call_user_func($run_mode . '_mode');
?>

3
apps/user_openid/user.php
Unescape Escape View File

@ -45,6 +45,3 @@ if(!OCP\User::userExists($USERNAME)){
$IDENTITY=OCP\Util::linkToAbsolute( "user_openid", "user.php" ).'/'.$USERNAME;
require_once 'phpmyid.php';
?>

1
apps/user_webfinger/webfinger.php
Unescape Escape View File

@ -58,4 +58,3 @@ foreach($apps as $app) {
}
}
echo "]}";
?>

2
core/ajax/grouplist.php
Unescape Escape View File

@ -45,5 +45,3 @@ foreach( OC_Group::getGroups() as $i ){
}
OC_JSON::encodedPrint($groups);
?>

1
core/ajax/translations.php
Unescape Escape View File

@ -29,4 +29,3 @@ $app = $_POST["app"];
$l = OC_L10N::get( $app );
OC_JSON::success(array('data' => $l->getTranslations()));
?>

2
core/ajax/userlist.php
Unescape Escape View File

@ -44,5 +44,3 @@ foreach( OC_User::getUsers() as $i ){
}
OC_JSON::encodedPrint($users);
?>

2
core/ajax/validateuser.php
Unescape Escape View File

@ -36,5 +36,3 @@ if(!isset($_SERVER['PHP_AUTH_USER'])){
OC_JSON::encodedPrint(array("username" => $_SERVER["PHP_AUTH_USER"], "user_valid" => "false"));
}
}
?>

2
core/ajax/vcategories/add.php
Unescape Escape View File

@ -39,5 +39,3 @@ if($categories->hasCategory($category)) {
}
OC_JSON::success(array('data' => array('categories'=>$categories->categories())));
?>

2
core/ajax/vcategories/delete.php
Unescape Escape View File

@ -34,5 +34,3 @@ if(is_null($categories)) {
$vcategories = new OC_VCategories($app);
$vcategories->delete($categories);
OC_JSON::success(array('data' => array('categories'=>$vcategories->categories())));
?>

2
core/ajax/vcategories/edit.php
Unescape Escape View File

@ -31,5 +31,3 @@ $categories = $vcategories->categories();
debug(print_r($categories, true));
$tmpl->assign('categories',$categories);
$tmpl->printpage();
?>

1
core/strings.php
Unescape Escape View File

@ -7,4 +7,3 @@ $l->t("Users");
$l->t("Apps");
$l->t("Admin");
$l->t("Help");
?>

1
lib/MDB2/Driver/Function/sqlite3.php
Unescape Escape View File

@ -134,4 +134,3 @@ class MDB2_Driver_Function_sqlite3 extends MDB2_Driver_Function_Common
// }}}
}
?>

1
lib/MDB2/Driver/Manager/sqlite3.php
Unescape Escape View File

@ -1360,4 +1360,3 @@ class MDB2_Driver_Manager_sqlite3 extends MDB2_Driver_Manager_Common
// }}}
}
?>

2
lib/MDB2/Driver/sqlite3.php
Unescape Escape View File

@ -1332,5 +1332,3 @@ class MDB2_Statement_sqlite3 extends MDB2_Statement_Common
$this->free();
}
}
?>

3
lib/public/app.php
Unescape Escape View File

@ -158,6 +158,3 @@ class App {
}
?>

2
lib/public/config.php
Unescape Escape View File

@ -134,5 +134,3 @@ class Config {
}
?>

2
lib/public/db.php
Unescape Escape View File

@ -91,5 +91,3 @@ class DB {
}
?>

2
lib/public/files.php
Unescape Escape View File

@ -115,5 +115,3 @@ class Files {
}
?>

2
lib/public/json.php
Unescape Escape View File

@ -105,5 +105,3 @@ class JSON {
}
}
?>

2
lib/public/response.php
Unescape Escape View File

@ -105,5 +105,3 @@ class Response {
}
?>

3
lib/public/template.php
Unescape Escape View File

@ -104,6 +104,3 @@ function html_select_options($options, $selected, $params=array()) {
class Template extends \OC_Template {
}
?>

3
lib/public/user.php
Unescape Escape View File

@ -120,6 +120,3 @@ class User {
}
?>

2
lib/public/util.php
Unescape Escape View File

@ -321,5 +321,3 @@ class Util {
return(\OC_Helper::mb_str_replace($search, $replace, $subject, $encoding, $count));
}
}
?>

2
lib/setup.php
Unescape Escape View File

@ -380,5 +380,3 @@ class OC_Setup {
file_put_contents(OC_Config::getValue('datadirectory', OC::$SERVERROOT.'/data').'/index.html', '');
}
}
?>

1
lib/updater.php
Unescape Escape View File

@ -84,4 +84,3 @@ class OC_Updater{
}
}
?>

1
lib/vcategories.php
Unescape Escape View File

@ -223,4 +223,3 @@ class OC_VCategories {
}
}
?>

3
ocs/providers.php
Unescape Escape View File

@ -40,6 +40,3 @@ echo('
</provider>
</providers>
');
?>

2
ocs/v1.php
Unescape Escape View File

@ -24,5 +24,3 @@
require_once('../lib/base.php');
@ob_clean();
OC_OCS::handle();
?>

Some files were not shown because too many files have changed in this diff Show More