sascha
/
nextcloud-server
mirror of https://github.com/nextcloud/server.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

move whitspace check to user manager

remotes/origin/file-rename-activities
Vincent Chan 2016-02-03 14:09:15 +07:00
parent 879917f5f1
commit cc17ac9ff9
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/private/user/manager.php
Unescape Escape View File

@ -265,6 +265,10 @@ class Manager extends PublicEmitter implements IUserManager {
if (trim($uid) == '') { if (trim($uid) == '') {
throw new \Exception($l->t('A valid username must be provided')); throw new \Exception($l->t('A valid username must be provided'));
} }
// No whitespace at the beginning or at the end
if (strlen(trim($uid, "\t\n\r\0\x0B\xe2\x80\x8b")) !== strlen(trim($uid))) {
throw new \Exception($l->t('Username contains whitespace at the beginning or at the end'));
}
// No empty password // No empty password
if (trim($password) == '') { if (trim($password) == '') {
throw new \Exception($l->t('A valid password must be provided')); throw new \Exception($l->t('A valid password must be provided'));

6
settings/js/users/users.js
Unescape Escape View File

@ -776,12 +776,6 @@ $(document).ready(function () {
t('settings', 'Error creating user')); t('settings', 'Error creating user'));
return false; return false;
} }
if ($.trim(username).length !== username.length) {
OC.dialogs.alert(
t('settings', 'Username contains whitespace at the beginning or at the end'),
t('settings', 'Error creating user'));
return false;
}
if ($.trim(password) === '') { if ($.trim(password) === '') {
OC.dialogs.alert( OC.dialogs.alert(
t('settings', 'A valid password must be provided'), t('settings', 'A valid password must be provided'),