fix(ci): Update `node-test` workflow and drop unneeded `cypress:version` output

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
pull/45177/head
Ferdinand Thiessen 2024-05-03 20:23:46 +07:00
parent 5682456b14
commit 3d533d2f51
No known key found for this signature in database
GPG Key ID: 45FAE7268762B400
1 changed files with 30 additions and 26 deletions

@ -1,3 +1,11 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
#
# SPDX-FileCopyrightText: 2023-2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT
name: Node tests name: Node tests
on: on:
@ -5,6 +13,9 @@ on:
schedule: schedule:
- cron: "5 2 * * *" - cron: "5 2 * * *"
permissions:
contents: read
concurrency: concurrency:
group: node-tests-${{ github.head_ref || github.run_id }} group: node-tests-${{ github.head_ref || github.run_id }}
cancel-in-progress: true cancel-in-progress: true
@ -26,18 +37,18 @@ jobs:
- '.github/workflows/**' - '.github/workflows/**'
- '**/__tests__/**' - '**/__tests__/**'
- '**/__mocks__/**' - '**/__mocks__/**'
- '**/src/**' - 'apps/*/src/**'
- '**/appinfo/info.xml' - 'apps/*/appinfo/info.xml'
- 'core/src/**'
- 'package.json' - 'package.json'
- 'package-lock.json' - 'package-lock.json'
- 'tsconfig.json' - 'tsconfig.json'
- '**.js' - '**.js'
- '**.ts' - '**.ts'
- '**.vue' - '**.vue'
- '**.handlebars'
versions: versions:
runs-on: ubuntu-latest runs-on: ubuntu-latest-low
needs: changes needs: changes
if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }} if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }}
@ -48,14 +59,14 @@ jobs:
steps: steps:
- name: Checkout - name: Checkout
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
- name: Read package.json node and npm engines version - name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@8205673bab74a63eb9b8093402fd9e0e018663a1 uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions id: versions
with: with:
fallbackNode: '^20' fallbackNode: '^20'
fallbackNpm: '^9' fallbackNpm: '^10'
test: test:
runs-on: ubuntu-latest runs-on: ubuntu-latest
@ -69,27 +80,26 @@ jobs:
steps: steps:
- name: Checkout - name: Checkout
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
- name: Set up node ${{ needs.versions.outputs.nodeVersion }} - name: Set up node ${{ needs.versions.outputs.nodeVersion }}
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with: with:
node-version: ${{ needs.versions.outputs.nodeVersion }} node-version: ${{ needs.versions.outputs.nodeVersion }}
- name: Set up npm ${{ needs.versions.outputs.npmVersion }} - name: Set up npm ${{ needs.versions.outputs.npmVersion }}
run: npm i -g npm@"${{ needs.versions.outputs.npmVersion }}" run: npm i -g npm@"${{ needs.versions.outputs.npmVersion }}"
- name: Install dependencies - name: Install dependencies & build
run: npm ci run: |
npm ci
- name: Show cypress version npm run build --if-present
run: npm run cypress:version
- name: Test and process coverage - name: Test and process coverage
run: npm run test:coverage run: npm run test:coverage --if-present
- name: Collect coverage - name: Collect coverage
uses: codecov/codecov-action@c16abc29c95fcf9174b58eb7e1abf4c866893bc8 # v4.1.1 uses: codecov/codecov-action@5ecb98a3c6b747ed38dc09f787459979aebb39be # v4.3.1
with: with:
files: ./coverage/lcov.info files: ./coverage/lcov.info
@ -104,10 +114,10 @@ jobs:
steps: steps:
- name: Checkout - name: Checkout
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
- name: Set up node ${{ needs.versions.outputs.nodeVersion }} - name: Set up node ${{ needs.versions.outputs.nodeVersion }}
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with: with:
node-version: ${{ needs.versions.outputs.nodeVersion }} node-version: ${{ needs.versions.outputs.nodeVersion }}
@ -117,9 +127,6 @@ jobs:
- name: Install dependencies - name: Install dependencies
run: npm ci run: npm ci
- name: Show cypress version
run: npm run cypress:version
- name: Test - name: Test
run: npm run test:jsunit run: npm run test:jsunit
@ -135,10 +142,10 @@ jobs:
steps: steps:
- name: Checkout - name: Checkout
uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
- name: Set up node ${{ needs.versions.outputs.nodeVersion }} - name: Set up node ${{ needs.versions.outputs.nodeVersion }}
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with: with:
node-version: ${{ needs.versions.outputs.nodeVersion }} node-version: ${{ needs.versions.outputs.nodeVersion }}
@ -148,9 +155,6 @@ jobs:
- name: Install dependencies - name: Install dependencies
run: npm ci run: npm ci
- name: Show cypress version
run: npm run cypress:version
- name: Run compile - name: Run compile
run: ./build/compile-handlebars-templates.sh run: ./build/compile-handlebars-templates.sh