fix: respect storage indicator setting (#22596)

* fix: respect storage indicator size setting

* remove black bar on the bottom of the setting scaffold page

---------

Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
Co-authored-by: Alex <alex.tran1502@gmail.com>

mobile/lib/pages/common/settings.page.dart

@@ -141,14 +141,9 @@ class SettingsSubPage extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     context.locale;
-    return SafeArea(
+    return Scaffold(
-      bottom: true,
+      appBar: AppBar(centerTitle: false, title: Text(section.title).tr()),
-      top: false,
+      body: section.widget,
-      right: true,
-      child: Scaffold(
-        appBar: AppBar(centerTitle: false, title: Text(section.title).tr()),
-        body: section.widget,
-      ),
     );
   }
 }

mobile/lib/presentation/widgets/images/thumbnail_tile.widget.dart

@@ -16,7 +16,7 @@ class ThumbnailTile extends ConsumerWidget {
     this.asset, {
     this.size = kThumbnailResolution,
     this.fit = BoxFit.cover,
-    this.showStorageIndicator,
+    this.showStorageIndicator = false,
     this.lockSelection = false,
     this.heroOffset,
     super.key,
@@ -25,7 +25,7 @@ class ThumbnailTile extends ConsumerWidget {
   final BaseAsset? asset;
   final Size size;
   final BoxFit fit;
-  final bool? showStorageIndicator;
+  final bool showStorageIndicator;
   final bool lockSelection;
   final int? heroOffset;
 
@@ -55,7 +55,7 @@ class ThumbnailTile extends ConsumerWidget {
         : const BoxDecoration();
 
     final bool storageIndicator =
-        showStorageIndicator ?? ref.watch(settingsProvider.select((s) => s.get(Setting.showStorageIndicator)));
+        ref.watch(settingsProvider.select((s) => s.get(Setting.showStorageIndicator))) && showStorageIndicator;
 
     return Stack(
       children: [

mobile/lib/presentation/widgets/timeline/timeline.state.dart

@@ -14,7 +14,7 @@ class TimelineArgs {
   final double maxHeight;
   final double spacing;
   final int columnCount;
-  final bool? showStorageIndicator;
+  final bool showStorageIndicator;
   final bool withStack;
   final GroupAssetsBy? groupBy;
 
@@ -23,7 +23,7 @@ class TimelineArgs {
     required this.maxHeight,
     this.spacing = kTimelineSpacing,
     this.columnCount = kTimelineColumnCount,
-    this.showStorageIndicator,
+    this.showStorageIndicator = false,
     this.withStack = false,
     this.groupBy,
   });