sascha
/
gitea
mirror of https://github.com/go-gitea/gitea.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use yellow if an approved review is stale (#26312) 

By using a different color it's clear that the review isn't pointing to
the latest commit.

**Screenshots:**
Not stale review:

![image](https://github.com/go-gitea/gitea/assets/1135157/2901ad69-e0d8-4041-b760-277d02dafd45)
Stale review:

![image](https://github.com/go-gitea/gitea/assets/1135157/500b306e-a994-42d4-a2fd-1174774ba5ee)

fixes #26306
pull/26296/head^2
sebastian-sauer 2023-08-03 23:28:21 +07:00 committed by GitHub
parent d74c2228e3
commit 70647bd04c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
models/issues/review.go
Unescape Escape View File

@ -192,6 +192,9 @@ func (r *Review) LoadAttributes(ctx context.Context) (err error) {
func (r *Review) HTMLTypeColorName() string {
switch r.Type {
case ReviewTypeApprove:
if r.Stale {
return "yellow"
}
return "green"
case ReviewTypeComment:
return "grey"