sascha
/
difftastic
mirror of https://github.com/Wilfred/difftastic/
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix performance when splitting very long lines during display

empty_delimiters_heuristic
Wilfred Hughes 2024-07-20 23:36:15 +07:00
parent 9b6bc7486f
commit 1e8be4558b
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/display/style.rs
Unescape Escape View File

@ -92,7 +92,11 @@ fn split_string_by_width(s: &str, max_width: usize, tab_width: usize) -> Vec<(&s
let mut parts: Vec<(&str, usize)> = vec![]; let mut parts: Vec<(&str, usize)> = vec![];
let mut s = s; let mut s = s;
while width_respecting_tabs(s, tab_width) > max_width { // Optimisation: width_respecting_tabs() walks the whole string,
// which is slow when we have files with massive lines. `s.len()`
// is always lower than width_respecting_tabs(s), so check that
// first.
while s.len() > max_width || width_respecting_tabs(s, tab_width) > max_width {
let offset = byte_offset_for_width(s, max_width, tab_width); let offset = byte_offset_for_width(s, max_width, tab_width);
let part = substring_by_byte(s, 0, offset); let part = substring_by_byte(s, 0, offset);