refactor: 💡 add event data and remove redundant code

src/public/app/components/app_context.ts

@@ -23,6 +23,7 @@ import type { Attribute } from "../services/attribute_parser.js";
 import type NoteTreeWidget from "../widgets/note_tree.js";
 import type { default as NoteContext, GetTextEditorCallback } from "./note_context.js";
 import type TypeWidget from "../widgets/type_widgets/type_widget.js";
+import type EditableTextTypeWidget from "../widgets/type_widgets/editable_text.js";
 
 interface Layout {
     getRootWidget: (appContext: AppContext) => RootWidget;
@@ -131,10 +132,10 @@ export type CommandMappings = {
     protectSubtree: ContextMenuCommandData;
     unprotectSubtree: ContextMenuCommandData;
     openBulkActionsDialog:
-        | ContextMenuCommandData
+    | ContextMenuCommandData
-        | {
+    | {
-              selectedOrActiveNoteIds?: string[];
+        selectedOrActiveNoteIds?: string[];
-          };
+    };
     editBranchPrefix: ContextMenuCommandData;
     convertNoteToAttachment: ContextMenuCommandData;
     duplicateSubtree: ContextMenuCommandData;
@@ -361,6 +362,10 @@ type EventMappings = {
     relationMapResetZoomIn: { ntxId: string | null | undefined };
     relationMapResetZoomOut: { ntxId: string | null | undefined };
     activeNoteChangedEvent: {};
+    showAddLinkDialog: {
+        textTypeWidget: EditableTextTypeWidget;
+        text: string;
+    };
 };
 
 export type EventListener<T extends EventNames> = {

src/public/app/widgets/dialogs/about.ts

@@ -83,7 +83,7 @@ export default class AboutDialog extends BasicWidget {
         this.$dataDirectory = this.$widget.find(".data-directory");
     }
 
-    async refresh(): Promise<void> {
+    async refresh() {
         const appInfo = await server.get<AppInfo>("app-info");
 
         this.$appVersion.text(appInfo.appVersion);
@@ -109,7 +109,7 @@ export default class AboutDialog extends BasicWidget {
         }
     }
 
-    async openAboutDialogEvent(): Promise<void> {
+    async openAboutDialogEvent() {
         await this.refresh();
         utils.openDialog(this.$widget);
     }

src/public/app/widgets/dialogs/add_link.ts

@@ -5,6 +5,7 @@ import utils from "../../services/utils.js";
 import BasicWidget from "../basic_widget.js";
 import type { Suggestion } from "../../services/note_autocomplete.js";
 import type { default as TextTypeWidget } from "../type_widgets/editable_text.js";
+import type { EventData } from "../../components/app_context.js";
 
 const TPL = `
 <div class="add-link-dialog modal mx-auto" tabindex="-1" role="dialog">
@@ -94,7 +95,7 @@ export default class AddLinkDialog extends BasicWidget {
         });
     }
 
-    async showAddLinkDialogEvent({ textTypeWidget, text = "" }: { textTypeWidget: TextTypeWidget; text: string }) {
+    async showAddLinkDialogEvent({ textTypeWidget, text = "" }: EventData<"showAddLinkDialog">) {
         this.textTypeWidget = textTypeWidget;
 
         this.$addLinkTitleSettings.toggle(!this.textTypeWidget.hasSelection());