sascha
/
Notes
mirror of https://github.com/TriliumNext/Notes
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

adhere to convention, prefixing jquery objects with $ and dom not

pull/255/head
Tom 2022-05-09 15:15:07 +07:00
parent dc35df9f63
commit 6cae68288d
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/public/app/dialogs/note_revisions.js
Unescape Escape View File

@ -187,8 +187,8 @@ async function setContentPane() {
* maxWidth: 100% use full width of container but do not enlarge!
* height:auto to ensure that height scales with width
*/
const svgHtml = $(svg).css({maxWidth: "100%", height: "auto"});
$content.html($('<div>').append(svgHtml));
const $svgHtml = $(svg).css({maxWidth: "100%", height: "auto"});
$content.html($('<div>').append($svgHtml));
} catch(err) {
console.error("error parsing fullNoteRevision.content as JSON", fullNoteRevision.content, err);
$content.html($("<div>").text("Error parsing content. Please check console.error() for more details."));

8
src/public/app/widgets/type_widgets/canvas_note.js
Unescape Escape View File

@ -70,7 +70,7 @@ export default class ExcalidrawTypeWidget extends TypeWidget {
// will be overwritten
this.excalidrawRef;
this.$render;
this.$renderElement;
this.renderElement;
this.$widget;
this.reactHandlers; // used to control react state
@ -114,7 +114,7 @@ export default class ExcalidrawTypeWidget extends TypeWidget {
// this.contentSized();
this.$widget.toggleClass("full-height", true); // only add
this.$render = this.$widget.find('.canvas-note-render');
this.$renderElement = this.$render.get(0);
this.renderElement = this.$render.get(0);
// this.log("doRender", this.$widget);
libraryLoader
@ -125,8 +125,8 @@ export default class ExcalidrawTypeWidget extends TypeWidget {
const React = window.React;
const ReactDOM = window.ReactDOM;
ReactDOM.unmountComponentAtNode(this.$renderElement);
ReactDOM.render(React.createElement(this.ExcalidrawReactApp), this.$renderElement);
ReactDOM.unmountComponentAtNode(this.renderElement);
ReactDOM.render(React.createElement(this.ExcalidrawReactApp), this.renderElement);
})
return this.$widget;