Commit Graph

1252 Commits (fb901b0d93da99b0a49e963a6a35fd82b7051a98)

Author SHA1 Message Date
John Molakvoæ (skjnldsv) 215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
Arthur Schiwon 35d5395089
psalm happiness
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

psalm happiness

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-04 19:57:00 +07:00
Nextcloud-PR-Bot 4b011e35fa Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-06-02 05:11:38 +07:00
Nextcloud-PR-Bot 2ad2d1258b Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-06-01 05:12:19 +07:00
Christoph Wurst d6d8e9215c
Add a trashbin for calendars and calendar objects
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-31 07:49:19 +07:00
dependabot-preview[bot] a77e0f5bcc
[Security] Bump ws from 7.4.1 to 7.4.6 in /build
Bumps [ws](https://github.com/websockets/ws) from 7.4.1 to 7.4.6. **This update includes security fixes.**
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/compare/7.4.1...7.4.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-05-29 01:14:33 +07:00
Joas Schilling 3b6b4c8509
Add integration tests for the editable fields
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-27 14:56:22 +07:00
dependabot-preview[bot] a10fce002f
Bump jsdoc from 3.6.6 to 3.6.7 in /build
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.6 to 3.6.7.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.7/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.6...3.6.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-05-22 01:15:44 +07:00
Morris Jobke b1ad3faf14
Merge pull request #25679 from nextcloud/drop/ocp-user
Drop \OCP\User
2021-05-21 15:05:38 +07:00
Christoph Wurst 8196420063
Drop \OCP\User
Inlines and remaining usages and drops the deprecated public API.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-21 15:00:34 +07:00
szaimen 35d978c2fc Rename External storages to External storage
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-05-20 12:13:04 +07:00
Nextcloud-PR-Bot 42d3dcb147 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-05-19 04:12:09 +07:00
dependabot-preview[bot] 321f01e2c5
Merge pull request #26987 from nextcloud/dependabot/npm_and_yarn/build/node-sass-6.0.0 2021-05-18 08:21:20 +07:00
Morris Jobke 77a4368418
Merge pull request #26846 from nextcloud/followup/26572/reply-with-json-when-not-accepting-html
Reply with json when not accepting html on LoginException
2021-05-17 09:36:18 +07:00
dependabot-preview[bot] 53e03a8b4f
Bump node-sass from 5.0.0 to 6.0.0 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 5.0.0 to 6.0.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v5.0.0...v6.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-05-15 01:14:16 +07:00
Joas Schilling b6c6527705
Fix unauthorized OCS status in provisioning
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 08:16:07 +07:00
Joas Schilling a2d5d2d613
Reply with UNAUTHORIZED like on APIs when login exception was thrown
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 08:02:53 +07:00
dependabot-preview[bot] cc3654ce37
[Security] Bump hosted-git-info from 2.7.1 to 2.8.9 in /build
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.7.1 to 2.8.9. **This update includes a security fix.**
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](https://github.com/npm/hosted-git-info/compare/v2.7.1...v2.8.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-05-10 07:27:01 +07:00
Nextcloud-PR-Bot 87fa87f9fb Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-05-10 04:12:20 +07:00
dependabot-preview[bot] f2a2cc7c66
[Security] Bump lodash from 4.17.19 to 4.17.21 in /build
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21. **This update includes a security fix.**
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.19...4.17.21)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-05-06 17:52:36 +07:00
Nextcloud-PR-Bot 2b50f580d9 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-05-03 04:11:45 +07:00
Christoph Wurst 63eb3694e4
Exclusively use the typed calendar deletion events for DAV
We had both in places, but the old one isn't used anywhere outside this
app, so it's time to migrate the code.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-29 15:31:19 +07:00
Nextcloud-PR-Bot 6ce115cb2a Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-04-29 04:11:28 +07:00
Nextcloud-PR-Bot c5e99c3349 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-04-28 04:12:29 +07:00
kesselb d52ee8929c
Merge pull request #26776 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
2021-04-27 15:41:10 +07:00
Joas Schilling c52a026f55
Merge pull request #26572 from nextcloud/bugfix/noid/throw-401-when-authentication-is-provided-and-invalid
Throw "401 Unauthenticated" when authentication is provided but invalid
2021-04-27 14:37:28 +07:00
Nextcloud-PR-Bot 65d9ba620f Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-04-27 04:12:15 +07:00
Nextcloud-PR-Bot d6f3a6feb9 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-04-26 04:13:05 +07:00
Daniel Calviño Sánchez e2c4a174f2 Add integration tests for searching users in contacts menu
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:42 +07:00
Nextcloud-PR-Bot 797448d2b3 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-04-23 04:11:54 +07:00
Morris Jobke 012f791c8f
Merge pull request #26375 from nextcloud/techdebt/noid/symfony-component-translation-pluralization-rules-is-deprecated
"Symfony\Component\Translation\PluralizationRules" is deprecated
2021-04-22 21:20:16 +07:00
Joas Schilling 83e10b7a73
Adjust integration test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 15:43:57 +07:00
Nextcloud-PR-Bot 1ac183fb05 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-04-21 04:11:37 +07:00
Joas Schilling 2228b285c5
Only check translations insteda of the full file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:43 +07:00
Joas Schilling a4c6749b02
Add a check for the pipe character
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +07:00
John Molakvoæ (skjnldsv) cd8bfbe09c
Remove old unused handlebar systemtags template
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-04-09 14:43:40 +07:00
John Molakvoæ (skjnldsv) 91510d95f1
Add js files to license
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-31 12:17:18 +07:00
Nextcloud-PR-Bot aa7dd1839c Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-31 04:12:05 +07:00
dependabot-preview[bot] c7b83a8d4a
[Security] Bump y18n from 4.0.0 to 4.0.1 in /build
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. **This update includes a security fix.**
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-29 17:30:08 +07:00
Joas Schilling 602de272c0
Merge pull request #26243 from nextcloud/enh/noid/avatar-privacy-new-scope
Avatar privacy and new scope
2021-03-29 09:01:12 +07:00
Nextcloud-PR-Bot 3b5cb333e4 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-28 04:12:03 +07:00
Vincent Petry 98e4ac39bc
Int tests for provisioning API scopes
Added integration tests for the scope attributes in the provisioning
API.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:10 +07:00
Vincent Petry 5b7a94f84c
Update psalm-baseline for Avatar API quirks
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:10 +07:00
Nextcloud-PR-Bot 3319ed8aca Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-26 04:16:04 +07:00
Nextcloud-PR-Bot 80409b2181 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-24 04:10:58 +07:00
Nextcloud-PR-Bot 069af5931f Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-23 04:35:21 +07:00
Morris Jobke 268acd301d
Merge pull request #25529 from nextcloud/fix-non-lgc-glyphs-in-avatars-and-txt-file-previews
Fix non LGC glyphs in avatars and txt file previews
2021-03-22 21:06:22 +07:00
John Molakvoæ (skjnldsv) 15767643f2
Fix sharebymail tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:47 +07:00
John Molakvoæ (skjnldsv) a100186e5e
Sharing link & mail parity
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:45 +07:00
Morris Jobke 6401d88283
Merge pull request #25331 from nextcloud/fix-valid-storages-removed-when-cleaning-remote-storages
Fix valid storages removed when cleaning remote storages
2021-03-18 08:57:09 +07:00
Nextcloud-PR-Bot 3959313b2c Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-18 04:34:21 +07:00
John Molakvoæ (skjnldsv) 87d39375d8
Fix comments filesplugin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 14:45:29 +07:00
John Molakvoæ (skjnldsv) fb183b457c
Add eslint testing
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 13:03:38 +07:00
Nextcloud-PR-Bot 0baf262aba Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-12 04:34:04 +07:00
Joas Schilling 1683e0289b
Also execute the new tests on drone
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 19:10:24 +07:00
Joas Schilling 5b53b6f977
Add a setting to restrict returning a full match unless in phonebook or same group
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:25:57 +07:00
Joas Schilling a310a2adc7
Add integration tests for autocomplete/get (similar to sharees API)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:56 +07:00
Nextcloud-PR-Bot 4a915843ca Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-10 04:29:06 +07:00
Nextcloud-PR-Bot d49630e850 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-09 04:34:03 +07:00
Roeland Jago Douma c38069fab3 Update baseline
The rest we will just fix as we go

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 16:34:15 +07:00
Nextcloud-PR-Bot a0ac2dd80c Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-06 04:33:39 +07:00
dependabot-preview[bot] c1105b3fda
Bump handlebars from 4.7.6 to 4.7.7 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.6 to 4.7.7.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.6...v4.7.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-05 07:23:03 +07:00
Nextcloud-PR-Bot df2fea444c Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-05 04:33:46 +07:00
Nextcloud-PR-Bot efdb881372 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-04 04:32:47 +07:00
Nextcloud-PR-Bot 19b2d621d2 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-03 04:28:22 +07:00
Nextcloud-PR-Bot 110b78a64b Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-02 04:30:37 +07:00
Daniel Calviño Sánchez 9f96a47125 Add OCC command to reset rendered texts
The command is meant to be used when the fonts used to render texts
("core/fonts/NotoSans-Regular.ttf" and "core/fonts/NotoSans-Bold.ttf")
are changed (for example, to add support for other scripts). The avatar
and text file previews will be removed, so they will be generated again
with the updated font when needed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-01 20:54:43 +07:00
Daniel Calviño Sánchez ee06780029 Include additional scripts in Noto fonts
Generated avatars as well as text file previews are rendered using the
"core/fonts/NotoSans-Regular.ttf" font. The file was the standard hinted
"NotoSans-Regular.ttf" file from https://www.google.com/get/noto/.
However that file does not cover some non LGC (Latin, Greek, Cyrillic)
scripts, like Arabic, Devanagari or Hebrew, to name a few.

Markdown file previews also use "core/fonts/NotoSans-Bold.ttf", which is
in the same situation as the regular one.

Due to limitations in the TTF format it is not possible to provide a
single file for each style that includes all Noto fonts. However, it is
possible to add more scripts to the standard "NotoSans-Regular.ttf" and
"NotoSans-Bold.ttf" files (although no CJK (Chinese, Japanese, Korean)
glyph can be included due to the aforementioned limitations).

This commit replaces the standard files with an extended version created
using the Noto Tools. The build script (as well as a patch for the Noto
Tools) is also included for reference and to be able to update the font
files in the future if needed.

Due to the additional scripts added the font files are now much larger,
although this does not seem to increase the time spent rendering LGC
scripts.

Note that the file for the bold style still contains less scripts than
the regular one, as not all scripts supported by Noto have a bold
weight.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-01 19:15:01 +07:00
Roeland Jago Douma 3a75e14844 Bump the ca location
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-18 20:21:34 +07:00
dependabot-preview[bot] eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +07:00
Nextcloud-PR-Bot 8b6144aae7 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-02-17 04:31:22 +07:00
Nextcloud-PR-Bot 7ff5797227 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-02-16 04:30:43 +07:00
Nextcloud-PR-Bot 974a191381 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-02-15 04:31:27 +07:00
Nextcloud-PR-Bot abaa073923 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-02-14 04:31:01 +07:00
Nextcloud-PR-Bot 130ce14892 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-02-10 04:31:13 +07:00
Lukas Reschke d4c718acad
Add .devcontainer to file-checker.php
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-02-09 11:22:29 +07:00
dependabot-preview[bot] 4ff94fae3e
Bump karma-viewport from 1.0.7 to 1.0.8 in /build
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport) from 1.0.7 to 1.0.8.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.7...1.0.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-02-06 02:15:41 +07:00
Nextcloud-PR-Bot 3d07fa5888 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-01-30 04:37:08 +07:00
Nextcloud-PR-Bot 5c1bb96c47 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-01-29 04:38:37 +07:00
Daniel Calviño Sánchez 3aba5b27be Add integration tests for "sharing:cleanup-remote-storages" OCC command
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-01-26 11:06:33 +07:00
Nextcloud-PR-Bot 90210593d1 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-01-23 05:02:34 +07:00
dependabot-preview[bot] 56ab96cc67
[Security] Bump socket.io from 2.3.0 to 2.4.1 in /build
Bumps [socket.io](https://github.com/socketio/socket.io) from 2.3.0 to 2.4.1. **This update includes a security fix.**
- [Release notes](https://github.com/socketio/socket.io/releases)
- [Changelog](https://github.com/socketio/socket.io/blob/2.4.1/CHANGELOG.md)
- [Commits](https://github.com/socketio/socket.io/compare/2.3.0...2.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-01-20 21:39:55 +07:00
Nextcloud-PR-Bot 454ff30fb9 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-01-20 05:05:00 +07:00
Nextcloud-PR-Bot 510be67e94 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-01-13 04:59:54 +07:00
Vincent Petry 5a8f15e167
Update psalm baseline to remove obsolete stuff
As seen in CI static checks, some blocks in the baseline were not needed any
more.

This will fix static checks in CI.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-01-12 09:26:20 +07:00
Nextcloud-PR-Bot f6969d9878 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-01-09 04:53:55 +07:00
Christoph Wurst 81302f78e5
Merge pull request #24948 from nextcloud/dependabot/composer/doctrine/dbal-3.0.0
Bump doctrine/dbal from 2.12.0 to 3.0.0
2021-01-08 14:58:43 +07:00
Morris Jobke aeb32e1bc8
Merge pull request #22992 from nextcloud/password-urlencode
allow authenticating using urlencoded passwords
2021-01-08 14:34:01 +07:00
Morris Jobke 63dc2df68d
Update baseline.xml
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-08 14:21:12 +07:00
Christoph Wurst 8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +07:00
Nextcloud-PR-Bot b3cdb2e23a Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-01-08 04:53:15 +07:00
Nextcloud-PR-Bot f653e933f4 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-01-06 04:51:06 +07:00
Christoph Wurst 969d4312e2
Merge pull request #24907 from nextcloud/fix/license-headers-21-II
Update license headers
2021-01-04 11:06:30 +07:00
Roeland Jago Douma 81423a2a2f
Fix expceted psalm-ocp.xml file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-30 14:32:15 +07:00
Christoph Wurst 9ce3ea3368
Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-30 14:07:05 +07:00
Roeland Jago Douma c96bb21ab9
Merge pull request #24903 from nextcloud/enh/psalm-ocp
Add dedicated baseline for OCP
2020-12-30 13:23:25 +07:00
Roeland Jago Douma fe65f8facf
Add dedicated baseline for OCP
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-30 11:06:00 +07:00
Roeland Jago Douma 2ac0e89b05
Merge pull request #24895 from nextcloud/make-integration-tests-work-with-both-php-7.3-and-7.4
Make integration tests work with both PHP 7.3 and 7.4
2020-12-30 10:51:58 +07:00
Daniel Calviño Sánchez 28f2d0ec7a Make integration tests work with both PHP 7.3 and 7.4
The "Trashbin" and "WebDav" traits were using each other in a circular
dependency ("WebDav" -> "Sharing" -> "Provisioning" -> "BasicStructure"
-> "Trashbin" -> "WebDav"). In PHP 7.3 this worked fine, but in PHP 7.4
the fatal error "Trait 'WebDav' not found in .../Trashbin.php" was
thrown. To solve this now the "TrashBin" trait no longer explicitly uses
"WebDav".

However, due to this change, the class using "TrashBin" is now expected
to also use "WebDav". As the "Trashbin" trait was not needed by most
contexts using the "BasicStructure" trait "Trashbin" was removed from it
and added only to those contexts that actually need it.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-12-30 06:01:38 +07:00
Nextcloud-PR-Bot 4ceeaccdd9 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-12-30 04:42:04 +07:00
dependabot-preview[bot] 04a65121b7
Merge pull request #23958 from nextcloud/dependabot/npm_and_yarn/build/node-sass-5.0.0 2020-12-29 11:21:14 +07:00
Christoph Wurst 35aa34a1fd
Merge pull request #24533 from nextcloud/dependabot/composer/icewind/streams-0.7.2
Bump icewind/streams from 0.7.1 to 0.7.2
2020-12-29 11:24:37 +07:00
dependabot-preview[bot] 9e5f167d9a
Bump node-sass from 4.14.1 to 5.0.0 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 4.14.1 to 5.0.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.14.1...v5.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-12-29 10:01:34 +07:00
Christoph Wurst 73c7d0dc81
Bump icewind/streams from 0.7.1 to 0.7.2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-29 09:07:36 +07:00
Julius Härtl c7a320d880 jsunit: Run jsunit with chromium/puppeteer on github actions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-29 08:42:27 +07:00
Christoph Wurst 3570ca82cf
Update the Psalm baseline
Some issues were resolved, hence every CI run shows this diff.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-22 17:44:16 +07:00
Roeland Jago Douma adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net
Unify links to php.net
2020-12-22 09:53:31 +07:00
Christoph Wurst d89a75be0b
Update all license headers for Nextcloud 21
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +07:00
Nextcloud-PR-Bot 815b39f5bc Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-12-16 04:33:17 +07:00
dependabot-preview[bot] 78079839be
[Security] Bump ini from 1.3.5 to 1.3.7 in /build
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. **This update includes a security fix.**
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-12-10 18:12:25 +07:00
Roeland Jago Douma 3c693db0ca
Merge pull request #24605 from nextcloud/enh/share-deck
Add deck share provider support
2020-12-10 14:30:08 +07:00
Julius Härtl a0444bc69c
Merge pull request #24247 from nextcloud/bugfix/noid/ocm-providerId-string 2020-12-09 17:25:59 +07:00
Julius Härtl b8d2a00b74
Update psalm baseline
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 13:20:25 +07:00
Nextcloud-PR-Bot 59f9e7f340 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-12-09 04:31:11 +07:00
Joas Schilling 86a3b7e7bf
Merge pull request #24486 from nextcloud/feature/noid/phone-number-validation
Phone number validation and search
2020-12-08 17:05:38 +07:00
Julius Härtl b7326046c6
Update psalm baseline
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-08 16:06:13 +07:00
Roeland Jago Douma a9ee98e070
Update psalm baseline
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:05 +07:00
Joas Schilling d0750df20c
Unit tests for searching by phone number
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +07:00
Joas Schilling 46b073d7ce
Add a config for default region of phone numbers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +07:00
Joas Schilling 689e3a502d
Add an integration test for the phone search API
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +07:00
Daniel Calviño Sánchez b4b3276a5b Add integration tests for getting guest avatars
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-12-07 04:48:00 +07:00
Daniel Calviño Sánchez 1552add4ca Add integration tests for resized user avatars
Even on solid color images the resizing can cause some small artifacts
that slightly modify the color of certain pixels. Due to this now the
color comparison is no longer strict but fuzzy.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-12-07 04:48:00 +07:00
Daniel Calviño Sánchez 2cc22a06b4 Add integration tests for user avatars
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-12-07 04:47:56 +07:00
Daniel Calviño Sánchez 184742e6ff Make possible to set body in requesttoken requests in integration tests
"sendingAToWithRequesttoken" needs to be used to test some non OCS
endpoints which require the request token to be sent in the request. Now
it is possible to specify the body (or, rather, additional contents
beside the cookies and the request token) for those requests, as it will
be needed for example to upload an avatar.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-12-07 04:32:00 +07:00
Daniel Calviño Sánchez b553b43b68 Make possible to send requests as anonymous users in integration tests
Until now requests always had "auth" headers either for an admin or a
regular user, depending on the value of "currentUser". Now, if
"currentUser" starts by "anonymous" no "auth" header is sent, which
makes possible to also test requests with users not logged in.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-12-07 04:32:00 +07:00
Julius Härtl a1a4fa2ac2
Always install composer v2
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-04 10:11:02 +07:00
Christoph Wurst fbc06d39c7
Merge pull request #24429 from nextcloud/3rdparty/closure
[3rdparty] Migrate to Opis/Closure
2020-12-03 08:44:53 +07:00
Nextcloud-PR-Bot 3c606cbec3 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-12-03 04:29:05 +07:00
Morris Jobke 40ebe24960
Update psalm-baseline.xml
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 20:27:14 +07:00
Christoph Wurst 4deff37a3c
Merge pull request #23278 from nextcloud/enh/noid/user-limits
Allow subscription to indicate that a userlimit is reached
2020-12-02 18:22:13 +07:00
Morris Jobke 32f6bdf067
Merge pull request #24396 from nextcloud/dont-use-system-composer
dont use system composer for autoload checker
2020-12-02 16:15:55 +07:00
Morris Jobke d87705a894
Allow subscription to indicate that a userlimit is reached
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 15:20:03 +07:00
Robin Appelman ef016f71c3
cleanup after autoloader generation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-02 15:02:56 +07:00
Nextcloud-PR-Bot 5427acec98 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-12-01 04:28:53 +07:00
Nextcloud-PR-Bot f94741ddee Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-29 04:27:32 +07:00
Robin Appelman 3e2e694ea9
dont use system composer for autoload checker
this ensures that the same composer version is used by everyone (and ci)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-26 15:48:46 +07:00
Nextcloud-PR-Bot fda21b35c4 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-24 04:25:08 +07:00
Lukas Reschke 47ac8e0028
Add Psalm Taint Flow Analysis
This adds the Psalm Security Analysis, as described at
https://psalm.dev/docs/security_analysis/

It also adds a plugin for adding input into AppFramework.

The results can be viewed in the GitHub Security tab at
https://github.com/nextcloud/server/security/code-scanning

**Q&A:**

Q: Why do you not use the shipped Psalm version?
A: I do a lot of changes to the Psalm Taint behaviour. Using released
versions is not gonna get us the results we want.

Q: How do I improve false positives?
A: https://psalm.dev/docs/security_analysis/avoiding_false_positives/

Q: How do I add custom sources?
A: https://psalm.dev/docs/security_analysis/custom_taint_sources/

Q: We should run this on apps!
A: Yes.

Q: What will change in Psalm?
A: Quite some of the PHP core functions are not yet marked to propagate
the taint. This leads to results where the taint flow is lost. That's
something that I am currently working on.

Q: Why is the plugin MIT licensed?
A: Because its the first of its kind (based on GitHub Code Search) and
I want other people to copy it if they want to. Security is for all :)

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2020-11-20 23:12:00 +07:00
dependabot-preview[bot] 774350c610
Bump vimeo/psalm from 4.1.1 to 4.2.0
Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 4.1.1 to 4.2.0.
- [Release notes](https://github.com/vimeo/psalm/releases)
- [Commits](https://github.com/vimeo/psalm/compare/4.1.1...4.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-20 09:07:01 +07:00
Roeland Jago Douma 9163790b7c
Set frame-ancestors to none if none are filled
frame-ancestors doesn't fall back to default-src. So when we apply a
very restricted CSP we should make sure to set it to 'none' and not
leave it empty.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-18 10:13:36 +07:00
Nextcloud-PR-Bot e93a76962c Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-17 04:22:33 +07:00
Roeland Jago Douma 426dc68b45
Merge pull request #24069 from nextcloud/fix-default-internal-expiration-date
Fix default internal expiration date
2020-11-16 14:13:56 +07:00
Daniel Calviño Sánchez 28c57004dd Add integration tests for creating shares with default expiration dates
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 08:54:19 +07:00
Daniel Calviño Sánchez 4f5271acf9 Reset app configs by deleting the values instead of setting the defaults
This avoids the need to keep the default values in the integration tests
in sync with the code, and also makes possible to reset values with
"dynamic" defaults (defaults that depend on other values).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 08:54:19 +07:00
Nextcloud-PR-Bot aa967d798c Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-14 04:21:44 +07:00
Nextcloud-PR-Bot 05cd789e9d Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-13 04:22:06 +07:00
Joas Schilling e39d657e24
Merge pull request #23882 from nextcloud/tests/oracle
Run unit tests against oracle
2020-11-11 10:05:24 +07:00
Daniel Calviño Sánchez ee852d7e0e Add integration tests for default share permissions
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-11 02:31:25 +07:00
Joas Schilling 6883676ad4
Update baseline, I'm sorry
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:55:06 +07:00
Nextcloud-PR-Bot e35329176d Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-10 04:18:47 +07:00
Roeland Jago Douma c8822508de
Merge pull request #23967 from nextcloud/dependabot/composer/build/integration/behat/behat-approx-3.8.0
Update behat/behat requirement from ~3.7.0 to ~3.8.0 in /build/integration
2020-11-09 19:54:41 +07:00
Nextcloud-PR-Bot 63c68d49c7 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-08 04:26:59 +07:00
Nextcloud-PR-Bot 610c22d2ca Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-07 04:26:22 +07:00
dependabot-preview[bot] d2aeeddce7
Update behat/behat requirement in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.7.0...v3.8.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-11-07 02:40:59 +07:00
Nextcloud-PR-Bot 4c61d52879 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-06 04:25:56 +07:00
Morris Jobke 0a1f4549e7
Check InvalidArgument psalm error into baseline - PHPDoc needs to be improved
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-05 13:49:25 +07:00
Nextcloud-PR-Bot 3929dc24c9 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-04 04:24:19 +07:00
Nextcloud-PR-Bot 4bbd6ceefd Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-03 04:23:30 +07:00
Morris Jobke f8739b327a
Update psalm-baseline.xml
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-02 10:14:07 +07:00
Morris Jobke 7410489e86
Update psalm baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-30 10:49:57 +07:00
Morris Jobke f438ee40a4
Revert "[Automated] Update psalm-baseline.xml" 2020-10-30 10:36:46 +07:00
Nextcloud-PR-Bot ac8a5ca18c Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-10-30 04:18:38 +07:00
Joas Schilling 92be66cff2
Fix the expected output
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-27 09:11:36 +07:00
Joas Schilling c5d0c8ce12
Simplify the function looking for output
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-27 09:11:19 +07:00
Joas Schilling dd3d5829e7
This is not javascript
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-26 17:06:32 +07:00
Joas Schilling 46e3ea4e41
Fix undefined variable
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-26 16:37:54 +07:00
Daniel Kesselberg d08dca4ee5
Update baseline
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-10-22 14:44:38 +07:00
Nextcloud-PR-Bot 3ecfaca85f Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-10-21 04:30:21 +07:00
Nextcloud-PR-Bot 8f813c691d Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-10-20 04:29:45 +07:00
Nextcloud-PR-Bot 8005fd6f19 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-10-16 04:28:48 +07:00
Christoph Wurst 2c40d2cf45
Bump vimeo/psalm from 3.15 to 3.17.1
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-14 11:47:54 +07:00
Christoph Wurst 081e9ac47f
Use own psalm instead of a global one
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-13 17:55:37 +07:00
Nextcloud-PR-Bot 035346a5d3 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-10-13 04:28:02 +07:00
Nextcloud-PR-Bot 953c6eda28 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-10-11 04:27:09 +07:00
Nextcloud-PR-Bot 7896b20100 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-10-09 04:27:56 +07:00
Nextcloud-PR-Bot ab6f6f7149 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-10-07 04:26:43 +07:00
Nextcloud-PR-Bot c2a6893033 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-10-06 04:27:00 +07:00
Morris Jobke 482b42c4a7
Merge pull request #22891 from nextcloud/techdebt/18680/improve-ProvisioningApiMiddleware-service-logic
Improve registerService logic for ProvisioningApiMiddleware for static code analysis
2020-10-05 21:50:50 +07:00
Christoph Wurst d9015a8c94
Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +07:00
dependabot-preview[bot] 8c2fe6df0a
Bump jsdoc from 3.6.5 to 3.6.6 in /build
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.5 to 3.6.6.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.6/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.5...3.6.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-26 01:16:20 +07:00
Nextcloud-PR-Bot f7e5ba6116 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-25 04:24:37 +07:00
Daniel Calviño Sánchez 7b9a40b407 Add integration tests to check that only the given path is transferred
Until recently (it was fixed in ac2999a26a) when a path was transferred
other shares with the target user were removed, so a test was added to
ensure that it does not happen again.

Besides that a test to ensure that other files with the target user are
not transferred was added too (it did not fail before, but seemed
convenient to have that covered too :-) ).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-18 18:35:06 +07:00
Daniel Calviño Sánchez c4c602ee80 Add integration tests for transferring files of a user with a risky name
The files:transfer-ownership performs a sanitization of users with
"risky" display names (including characters like "\" or "/").

In order to allow (escaped) double quotes in the display name the
regular expression used in the "user XXX with displayname YYY exists"
step had to be adjusted.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-18 18:34:30 +07:00
Daniel Calviño Sánchez 5e143845cb Add integration test for transferring the path of a single file
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-18 18:32:23 +07:00
Nextcloud-PR-Bot 281f0d6793 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-18 04:23:58 +07:00
J0WI 68ce17e59b Unify links to php.net
Update all links to https://www.php.net/

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-09-17 17:40:04 +07:00
Morris Jobke a65b431f51
Update baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 17:02:44 +07:00
Morris Jobke c6948c2517
Update baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 16:54:10 +07:00
Morris Jobke 04a3580d19
Remove phan config - was replaced by Psalm
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 14:46:29 +07:00
Morris Jobke 1c9a898875
Merge pull request #22761 from nextcloud/extend-integration-tests-for-files-transfer-ownership-command
Extend integration tests for "files:transfer-ownership" command
2020-09-14 17:50:53 +07:00
Morris Jobke 04c174ab89
Merge pull request #22665 from nextcloud/dependabot/composer/build/integration/behat/behat-approx-3.7.0
Update behat/behat requirement from ~3.6.1 to ~3.7.0 in /build/integration
2020-09-10 12:52:31 +07:00
Daniel Calviño Sánchez 58d57b35ea Add integration tests for transferring ownership of reshares
Currently only transferring ownership of a reshare with a group to a
user in the group is possible.

When transferring ownership of a reshare with another user or with a
group to a user not in the group restoring the share fails (but the
command succeeds, it only fails for the specific files that are
reshares).

When transferring ownership of a path that is a reshare the command
fails (as when a specific path is provided the path tries to move the
file, it does not take into account reshares).

The added integration tests reflect the above behaviours.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:34:33 +07:00
Daniel Calviño Sánchez 0ce8096839 Check share ownership after transferring file ownership
The integration tests did not verify that the shares were actually
transferred between the users (or that they were removed due to being
transferred to the sharee).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:24:16 +07:00
Daniel Calviño Sánchez d3d01d6355 Check whether file exists or not after transferring ownership
The integration tests did not verify that the files were actually
transferred between the users, only that the files were downloadable.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:18:53 +07:00
Roeland Jago Douma c104c192ae
Merge pull request #22663 from nextcloud/dependabot/npm_and_yarn/build/karma-viewport-1.0.7
Bump karma-viewport from 1.0.6 to 1.0.7 in /build
2020-09-09 21:24:28 +07:00
Roeland Jago Douma fe5f8c5010
Merge pull request #22600 from nextcloud/dependabot/npm_and_yarn/build/http-proxy-1.18.1
[Security] Bump http-proxy from 1.17.0 to 1.18.1 in /build
2020-09-09 20:55:08 +07:00
Nextcloud-PR-Bot 9c57fff01f Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-09 04:23:34 +07:00
dependabot[bot] 94b228dca1
Update behat/behat requirement in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.6.1...v3.7.0)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 06:37:56 +07:00
dependabot[bot] 20e6d04a69
Bump karma-viewport from 1.0.6 to 1.0.7 in /build
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.6...1.0.7)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 06:37:47 +07:00
Christoph Wurst 1f7f93a695
Update license headers for Nextcloud 20 (again)
There are still lots of outdated headers, so time for another round of
updates.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +07:00
John Molakvoæ 54438c9d26
Merge pull request #21945 from nextcloud/fix-contact-download-picture
Changed Content-Disposition header to download Contact Photo with correct extension
2020-09-07 08:40:23 +07:00
Nextcloud-PR-Bot 14baa52a1a Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-06 04:22:33 +07:00
Jacob Neplokh e8a4feb1c6
Change Content-Disposition Header
- Make ALLOWED_CONTENT_TYPES public in order to use
- Add $fileName variable which uses "$node->getName()" to get the proper file name and "$file->getMimeType()" along with the ALLOWED_CONTENT_TYPES array in PhotoCache.php to get the proper file extension
- Make "$fileName" the name of the file in the Content-Disposition header when downloading a Contact's photo
- Add filename to the CardDAV integration image export test header
- Change headers in ImageExportPluginTest to reflect changes

Signed-off-by: Jacob Neplokh <me@jacobneplokh.com>
2020-09-05 11:46:25 +07:00
dependabot-preview[bot] 3e9359f930
[Security] Bump http-proxy from 1.17.0 to 1.18.1 in /build
Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.17.0 to 1.18.1. **This update includes a security fix.**
- [Release notes](https://github.com/http-party/node-http-proxy/releases)
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md)
- [Commits](https://github.com/http-party/node-http-proxy/compare/1.17.0...1.18.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-04 18:10:40 +07:00
Nextcloud-PR-Bot 7511885c15 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-03 04:22:57 +07:00
Julius Härtl 9dc23867c6
Use proper branch name in phpdoc builds
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-27 08:47:16 +07:00
Roeland Jago Douma b5e9f7e846
Merge pull request #22432 from nextcloud/enh/phpdoc
Add php docs build script
2020-08-26 21:18:11 +07:00
Julius Härtl 8c33bfe86b
Add php docs build script
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-26 08:32:42 +07:00
Nextcloud-PR-Bot bc7abbdb85 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-08-26 04:21:23 +07:00
Christoph Wurst 2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +07:00
Nextcloud-PR-Bot 067945ff10 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-08-21 04:21:23 +07:00
Morris Jobke d58e71f0e6
Fix psalm warnings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 21:12:15 +07:00
Morris Jobke bb8be58386
Fix psalm warnings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 18:30:48 +07:00
Morris Jobke 8381af626f
Accept psalm warning for now
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 16:46:00 +07:00
Morris Jobke 69bbbc32a1
Extend psalm baseline to ignore errors for now
One is a false positive - see https://github.com/vimeo/psalm/pull/4032

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 14:20:56 +07:00
Julien Veyssier 70d1d1997a
new weather status used in dashboard
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2020-08-20 00:21:08 +07:00
Morris Jobke d8bdb439a4
Merge pull request #22289 from nextcloud/techdebt/noid/fix-encryption-stream-invalid-scalar-arguments
Cast float to int to avoid invalid scalar argument warning
2020-08-19 22:08:15 +07:00
Morris Jobke c449d54204
Merge pull request #22304 from nextcloud/techdebt/noid/matching-param-names
Use matching parameter names form interfaces and implementations
2020-08-19 19:34:02 +07:00
Morris Jobke 4c6eb96471
Merge pull request #22280 from nextcloud/bugfix/noid/429-on-brute-force-maximum
Send "429 Too Many Requests" in case of brute force protection
2020-08-19 18:21:01 +07:00
Morris Jobke fedf9c69d9
Use matching parameter names form interfaces and implementations
Found by Psalm 3.14.1

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 18:16:35 +07:00
Morris Jobke 60be722ee8
Merge pull request #22288 from nextcloud/techdebt/noid/fix-oc_image-invalid-scalar-arguments
Cast float/char to int to avoid invalid scalar argument warning
2020-08-19 17:55:56 +07:00
Morris Jobke e93bf71369
Fix the return type of OC_Template->fetchPage() to be string only
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 16:48:06 +07:00
Morris Jobke 5ced155032
Merge pull request #22285 from nextcloud/techdebt/noid/move-to-typed-event-in-list.php
Use dispatchTyped instead of dispatch on the new event dispatcher
2020-08-18 21:29:48 +07:00
Morris Jobke a5853d7ecc
Use dispatchTyped instead of dispatch on the new event dispatcher
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 20:27:46 +07:00
Morris Jobke 560ccf5d83
Cast float to int to avoid invalid scalar argument warning
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:56:36 +07:00
Morris Jobke 27e7332a9c
Cast float/char to int to avoid invalid scalar argument warning
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:51:59 +07:00
Morris Jobke 4c4f4685dc
Update psalm baseline due to fixes in #22236
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:49:36 +07:00
Morris Jobke 42bb6cd7d7
Check only the baseline.xml and exclude the psalm.xml from the file check
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 13:01:10 +07:00
Morris Jobke c6b251ca0c
Add patches for stubs
* https://github.com/JetBrains/phpstorm-stubs/pull/893
* https://github.com/JetBrains/phpstorm-stubs/pull/894
* https://github.com/JetBrains/phpstorm-stubs/pull/895
* https://github.com/JetBrains/phpstorm-stubs/pull/896

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 13:01:10 +07:00
Morris Jobke b70792aa6a
Add stubs for gd, intl, IntlChar, ldap, redis_cluster and xsl
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 13:01:10 +07:00
Morris Jobke 4efca69f8d
Add psalm baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 12:59:17 +07:00
Daniel Kesselberg 8b3b5ae5be
Add stubs for phpseclib
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-18 08:58:19 +07:00
Daniel Kesselberg 7257793fc4
Hello psalm
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-18 08:58:19 +07:00
Morris Jobke 79fc7e78b7
Merge pull request #21138 from nextcloud/fix/noid/search-in-group-displayname-email
Search also the email and displayname in user mangement for groups
2020-08-05 16:09:00 +07:00
Morris Jobke 907d3542dc
Add integration tests for search in groups
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-05 14:14:06 +07:00
Joas Schilling 8d5f5e8f8c
Fix integration test fail
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-03 13:43:15 +07:00
dependabot-preview[bot] 8e1d334258
Bump jsdoc from 3.6.4 to 3.6.5 in /build
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.4 to 3.6.5.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.5/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.4...3.6.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-25 01:15:12 +07:00
dependabot[bot] 94ae095051
Bump lodash from 4.17.14 to 4.17.19 in /build
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.14...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>
2020-07-16 07:23:29 +07:00
Morris Jobke aed5eb55af
Merge pull request #21843 from nextcloud/debt/noid/less-verbose-translation-checker
Make translation-checker.php less verbose
2020-07-15 19:37:51 +07:00
Morris Jobke 8dd48f3dc8
Fix integration test due to new dashboard app
See #21346

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-15 14:07:59 +07:00
Daniel Kesselberg 5ffe9fc7db
Make translation-checker.php less verbose.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-15 11:29:12 +07:00
Daniel Calviño Sánchez e0fbf4d033
Add more integration tests for resharing permissions
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-07-09 11:14:44 +07:00
Morris Jobke 3333c885c0
Merge pull request #21264 from stweil/master
build: Fix some typos (most of them found by codespell)
2020-07-05 22:52:28 +07:00
Joas Schilling dc175d4ecc
Fix typo in variable name and make check more accurate
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-01 10:48:38 +07:00
Joas Schilling e2100856ad
Add another test for exact matching of a user in group restriction
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-17 12:06:50 +07:00
Christoph Wurst cdcd61d4c8
Use empty for the OCP @since checker
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-09 08:49:24 +07:00
Stefan Weil 72f853424b build: Fix two typos in function names
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2020-06-06 15:57:08 +07:00
Stefan Weil e8af52001e build: Fix some typos (most of them found by codespell)
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2020-06-06 13:03:00 +07:00
Daniel Calviño Sánchez b192c04dc2 Add integration tests for video verification
Enabling the "send password by Talk" property of shares require that
Talk is installed and enabled, so the Drone step that runs them has to
first clone the Talk repository.

When the integration tests are run on a local development instance,
however, it is not guaranteed that Talk is installed. Due to this the
"@Talk" tag was added, which ensures that any feature or scenario marked
with it will first check if Talk is installed and, if not, skip the
scenario (instead of failing).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:50:30 +07:00
Daniel Calviño Sánchez a2f80d4f4c Add integration tests for creating and updating a mail share
In most cases, when a mail share is created or updated an e-mail is sent
to the sharee, which is done by connecting to the SMTP server set in the
configuration. If the server can not be contacted then the creation or
update of the mail share fails.

To make possible to test mail shares without using a real SMTP server a
fake one has been added. The original script, which is MIT licensed, was
based on inetd, so it was slightly modified to run on its own.

In order to use it from the integration tests the "Given dummy mail
server is listening" step has to be called in the scenarios in which the
mail server is needed.

For now that is the only available step; things like checking the sent
mails, while possible (as the script can log the mails to certain file),
have not been added yet.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:50:29 +07:00
Daniel Calviño Sánchez 7817f8578b Generalize integration test steps to download last share
Note that the "last link share can be downloaded" step was kept as it
tests the "url" property specific of link shares.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +07:00
Daniel Calviño Sánchez 6e49d3bb94 Remove unused variables
The step names were adjusted accordingly.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +07:00
Roeland Jago Douma bd0a1b6e7d
Merge pull request #20586 from nextcloud/techdebt/noid/make-image-optimization.sh-better-readable
Improve build/image-optimization.sh
2020-05-21 09:48:55 +07:00
Roeland Jago Douma 108faf25c0
Update public link share permission code
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-15 08:18:03 +07:00
dependabot-preview[bot] c84a82bc0c
Bump node-sass from 4.14.0 to 4.14.1 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 4.14.0 to 4.14.1.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.14.0...v4.14.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 01:16:27 +07:00
Roeland Jago Douma d9e5925201
Merge pull request #20655 from nextcloud/dependabot/npm_and_yarn/build/node-sass-4.14.0
Bump node-sass from 4.13.0 to 4.14.0 in /build
2020-04-29 16:15:04 +07:00
Christoph Wurst cb057829f7
Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +07:00
dependabot-preview[bot] b836bcf040
Bump node-sass from 4.13.0 to 4.14.0 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 4.13.0 to 4.14.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.13.0...v4.14.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-29 08:27:58 +07:00
Morris Jobke 1738e17e20
Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare
Fix resharing of federated shares that were created out of links
2020-04-27 11:05:34 +07:00
Julius Härtl 7a9469f282
Adjust integration tests to new permissions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 16:22:48 +07:00
Roeland Jago Douma 3fc66a65f8
Revert "Update guzzlehttp/guzzle requirement from 6.5.2 to 6.5.3 in /build/integration" 2020-04-22 16:40:11 +07:00
Joas Schilling e9f0a388d9
Allow to specify a directory and skip node_modules and tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:50:26 +07:00
Joas Schilling e49b6c576d
Don't error when the directory is broken
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:33:11 +07:00
Joas Schilling f354a4f17f
FIx glob usage to avoid problems with directories that contain spaces
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:32:11 +07:00
Joas Schilling 4651ff5a50
Make the script better readable
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:30:53 +07:00
Roeland Jago Douma 792c520774
Revert "Bump karma-coverage from 2.0.1 to 2.0.2 in /build" 2020-04-19 11:21:48 +07:00
dependabot-preview[bot] a95d6463b4
Bump karma-coverage from 2.0.1 to 2.0.2 in /build
Bumps [karma-coverage](https://github.com/karma-runner/karma-coverage) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/karma-runner/karma-coverage/releases)
- [Changelog](https://github.com/karma-runner/karma-coverage/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma-coverage/compare/v2.0.1...v2.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-19 01:13:43 +07:00
dependabot-preview[bot] e650c6366f
Update guzzlehttp/guzzle requirement in /build/integration
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/6.5.3/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/6.5.2...6.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-19 01:13:23 +07:00
blizzz 8bc381f104
Merge pull request #20037 from nextcloud/fix/19127/deprecated-ldap_control_paged_result_1
do not use deprecated API for LDAP paged results
2020-04-15 15:02:51 +07:00
Joas Schilling 4e846dda4d
Allow local remotes in integration tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 08:24:18 +07:00
Arthur Schiwon 84619a5b9c
use serverControls directly with LDAP calls, fixes 19127
- adapters for PHP API version to Support PHP < 7.3
- switch to pass only one base per search
- cookie logic is moved from Access to API adapters

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-14 12:58:28 +07:00
Daniel Kesselberg 0ccaec9841
Fix jsunit tests
JSUnit tests are failing for some reason. It seems to be related to a new karma-coverage version published a few hours ago.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-14 11:55:12 +07:00
Daniel Calviño Sánchez 7440868acd Fix app not listed in provisioning integration test
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-04-13 15:07:59 +07:00
dependabot-preview[bot] e1f8666f84
Bump jsdoc from 3.6.3 to 3.6.4 in /build
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.3 to 3.6.4.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.4/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.3...3.6.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-12 01:13:41 +07:00
Christoph Wurst 1584c9ae9c
Add visibility to all methods and position of static keyword
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +07:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +07:00
Christoph Wurst 14c996d982
Use elseif instead of else if
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +07:00
Christoph Wurst bcd13296de
Make sure every file ends with an empty newline
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:11:50 +07:00
Christoph Wurst 44577e4345
Remove trailing and in between spaces
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +07:00
Christoph Wurst afbd9c4e6e
Unify function spacing to PSR2 recommendation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +07:00
Joas Schilling bbba7bc45a
Merge pull request #20321 from nextcloud/enh/noid/check-translation-for-triple-dot
Check for triple dots in translations in CI
2020-04-08 20:10:05 +07:00
Gary Kim 283b8a5e74
Check for triple dots in translations in CI
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-04-07 12:06:40 +07:00
dependabot-preview[bot] d7eac53ee1
Bump handlebars from 4.7.3 to 4.7.6 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.3 to 4.7.6.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.3...v4.7.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-05 10:57:12 +07:00
Roeland Jago Douma dbdd30d4d4
Merge pull request #20216 from nextcloud/dependabot/npm_and_yarn/build/karma-viewport-1.0.6
Bump karma-viewport from 1.0.5 to 1.0.6 in /build
2020-04-03 08:51:27 +07:00
Roeland Jago Douma 32577f2f57
Merge pull request #20209 from nextcloud/techdebt/php-cs-config
Add a shared php coding style fixer config
2020-04-01 13:25:16 +07:00
Christoph Wurst 1a9330cd69
Update the license headers for Nextcloud 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +07:00
Christoph Wurst 3eac89d448
Add shared php-cs config
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 13:45:10 +07:00
dependabot-preview[bot] aaaabd1678
Bump karma-viewport from 1.0.5 to 1.0.6 in /build
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport) from 1.0.5 to 1.0.6.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.5...1.0.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-29 01:13:34 +07:00
Christoph Wurst 463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
Remove unused imports
2020-03-27 17:14:08 +07:00
Christoph Wurst b80ebc9674
Use the short array syntax, everywhere
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +07:00
Christoph Wurst 74936c49ea
Remove unused imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +07:00
Christoph Wurst 23eb0462e5
Use lowercase true, false and null constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 21:53:04 +07:00
Roeland Jago Douma 97949109ef
Merge pull request #19368 from nextcloud/dependabot/npm_and_yarn/build/handlebars-4.7.3
Bump handlebars from 4.5.3 to 4.7.3 in /build
2020-03-24 21:47:36 +07:00
Daniel Calviño Sánchez ec63327472 Force compatible EventDispatcher version in integration tests
Nextcloud requires EventDispatcher from Symfony 4.4. Behat required
Symfony 4.x until Behat 3.5, but since Behat 3.6 it supports Symfony 5.x
too. However, as the EventDispatcher version was not restricted in the
"composer.json" file Composer installed the latest compatible version
with all the dependencies, which happened to be Symfony 5.x. To prevent
that now the EventDispatcher is explicitly limited to Symfony 4.4 only.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-03-12 10:45:23 +07:00
dependabot-preview[bot] d3d6d8de3a
Bump handlebars from 4.5.3 to 4.7.3 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.5.3 to 4.7.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.5.3...v4.7.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-10 19:14:40 +07:00
dependabot-preview[bot] cb2877abd3
Update behat/behat requirement in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.5.0...v3.6.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-12 19:28:54 +07:00
dependabot-preview[bot] 1829ee816d
Update guzzlehttp/guzzle requirement in /build/integration
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/6.3.3...6.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-09 02:14:17 +07:00
Joas Schilling e5e612a292
Merge pull request #18518 from nextcloud/security-polixy
Set up a security policy
2020-02-06 21:24:52 +07:00
dependabot-preview[bot] bf5174afe0
Bump karma-viewport from 1.0.4 to 1.0.5 in /build
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.4...1.0.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-02 02:13:24 +07:00
Ruben Barkow be506f7b29
Set up a security policy
Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de>
2020-01-21 16:25:52 +07:00
Roeland Jago Douma fc77f530d7
Don't show link shares hash in inherited share list
This adds no value at all. Just showing the text "(Shared link)" now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-15 09:21:53 +07:00
Christoph Wurst 6127c288e8 Fix license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-13 14:23:49 +07:00
John Molakvoæ (skjnldsv) edf8893479
Fix tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-12-10 23:44:17 +07:00
Christoph Wurst 5bf3d1bb38
Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +07:00
Christoph Wurst a166796378
Update license script apps
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:38 +07:00
Maxence Lange ccf7d87c11
integration tests
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
add tests on non-owner pov

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
duplicate

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
small fixes

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
removed tags

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2019-12-03 08:10:27 +07:00
Roeland Jago Douma 407c2c13ab
Merge pull request #18159 from nextcloud/tests/comments-integration
Do not call count on null
2019-12-02 08:53:02 +07:00
Julius Härtl 330cb7047e
Do not call count on null
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-11-29 09:59:35 +07:00
Roeland Jago Douma 3cda67c8b1
Fix integration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-28 10:22:05 +07:00
dependabot-preview[bot] 8a15447d63
Bump handlebars from 4.5.2 to 4.5.3 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.5.2 to 4.5.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.5.2...v4.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-24 02:12:31 +07:00
Daniel Calviño Sánchez 54f8f75f6f Accept incoming shares in integration tests
Now all incoming shares need to be explicitly accepted before being able
to use the shared file or get information about a reshare (although
getting the information of the incoming share is possible before
accepting it).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-11-20 15:47:11 +07:00
Daniel Calviño Sánchez 9004e90f5d Replace direct calls to share API with specific share steps
This makes possible to use steps that reference the last share, which
will be needed to accept pending shares.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-11-20 13:11:49 +07:00
Daniel Calviño Sánchez 847bd0f05b Remove extra spaces at the end of lines
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-11-20 13:10:35 +07:00
dependabot-preview[bot] 43b58ca30f
Bump handlebars from 4.5.1 to 4.5.2 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.5.1 to 4.5.2.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.5.1...v4.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-17 02:13:10 +07:00
dependabot-preview[bot] f166744f17
Bump handlebars from 4.4.5 to 4.5.1 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.4.5 to 4.5.1.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.5...v4.5.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-10 02:12:31 +07:00
Gary Kim f3009bc76e
Add .editorconfig to expected files
Signed-off-by: Gary Kim <gary@garykim.dev>
2019-11-08 08:28:39 +07:00
John Molakvoæ (skjnldsv) eebcf89091
Cleanup sharing leftovers
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-11-05 19:03:44 +07:00
John Molakvoæ (skjnldsv) 515171a653 Transpile also dependencies in node_modules
Some of the dependencies in node_modules, such as "p-queue", are not ES5
compatible, so they need to be transpiled to work in older browsers like
Internet Explorer 11.

Besides not excluding the dependencies for babel-loader in
"webpack.common.js" the global Babel configuration must be defined in
"babel.config.js", as in Babel 7.X, when ".babelrc.js" is used, all the
dependencies in "node_modules" are ignored (even if whitelisted in the
configuration file itself).

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-29 12:56:00 +07:00
John Molakvoæ (skjnldsv) ea6f423e2c Extend data returned when searching remote shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-29 12:55:59 +07:00
Roeland Jago Douma 11faf739c2
Merge pull request #17698 from nextcloud/dependabot/npm_and_yarn/build/node-sass-4.13.0
Bump node-sass from 4.12.0 to 4.13.0 in /build
2019-10-27 22:34:49 +07:00
dependabot-preview[bot] 64ce503bce
Bump handlebars from 4.4.3 to 4.4.5 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.4.3 to 4.4.5.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.3...v4.4.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-27 10:18:39 +07:00
dependabot-preview[bot] baeb369a67
Bump node-sass from 4.12.0 to 4.13.0 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 4.12.0 to 4.13.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.12.0...v4.13.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-27 07:47:52 +07:00
Daniel Calviño Sánchez d0b205d0dd
Add more integration tests for getting shares
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-10-26 14:22:17 +07:00
Daniel Calviño Sánchez eaa98ed343 Add integration tests for getting shares including subfiles
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-10-25 18:37:36 +07:00
Daniel Calviño Sánchez bb9814d052 Replace fully qualified name with alias
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-10-25 10:48:38 +07:00
John Molakvoæ (skjnldsv) a1480c95eb
Merge all babelrc into one file
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-17 00:06:09 +07:00
dependabot-preview[bot] 929295ac31
Bump handlebars from 4.4.2 to 4.4.3 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.4.2 to 4.4.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.2...v4.4.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-13 01:13:38 +07:00
Daniel Kesselberg 99358d70e8
Remove settings/ from phan
settings is a app now. so the directory does not exist.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-10-09 14:34:05 +07:00
dependabot-preview[bot] a0acb4b5d5
Bump handlebars from 4.4.0 to 4.4.2 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.4.0 to 4.4.2.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/v4.4.2/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.0...v4.4.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-06 01:13:11 +07:00
John Molakvoæ (skjnldsv) ff895abac0
Fix shares read permissions
A user with reshare permissions on a file is now able to get any share
of that file (just like the owner).

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-04 21:40:30 +07:00
Daniel Calviño Sánchez 6d4f4c1c70
Add assorted integration tests for shares
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-10-04 19:25:11 +07:00
Daniel Calviño Sánchez a7526d74ae
Do not expect a 200 HTTP status code when updating a share
This will be needed to test scenarios in which updating a share return a
different HTTP status code, like 401.

The assertion for the 200 HTTP status code was added in those scenarios
that tested updating a share (that is, those that were also checking the
OCS status code), but not in those in which updating a share was just a
preparatory step for the actual test (in the same way that the HTTP
status code is not checked in those tests when creating a share).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-10-04 19:25:10 +07:00
John Molakvoæ (skjnldsv) 99404bdfb3
Move sharing integration tests to their own directory
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-04 19:25:10 +07:00
John Molakvoæ (skjnldsv) ba1ba1a55e
Add helper script to run integration tests on a Docker container
Copied and adjusted from "tests/integration/run-docker.sh" in Talk; see
its commit history for further reference.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-04 19:25:10 +07:00
John Molakvoæ (skjnldsv) c2c7c2778b
Fix master testing and update eslint-config
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-10-04 06:44:21 +07:00
Roeland Jago Douma 87c7852c48
Merge pull request #17336 from nextcloud/dependabot/npm_and_yarn/build/handlebars-4.4.0
Bump handlebars from 4.2.1 to 4.4.0 in /build
2019-10-01 12:54:35 +07:00
Christoph Wurst 6b54b974f8
Use handlebars from node_modules (on CI)
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-09-30 16:20:44 +07:00
dependabot-preview[bot] 5d6b8f63fe
Bump handlebars from 4.2.1 to 4.4.0 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.2.1 to 4.4.0.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/v4.4.0/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.2.1...v4.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-30 12:46:39 +07:00
Roeland Jago Douma 9e2bb5ef36 Move oauth admin settings to initialstate
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-09-28 13:30:34 +07:00
Christoph Wurst de6940352a Move settings to an app
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-09-28 09:39:28 +07:00
dependabot-preview[bot] 086e59a0df
Bump handlebars from 4.2.0 to 4.2.1 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/v4.2.1/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.2.0...v4.2.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-22 17:59:05 +07:00
dependabot-preview[bot] 5f2f7a6def
Bump handlebars from 4.1.2 to 4.2.0 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.2.0.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.2...v4.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-08 18:14:32 +07:00
Roeland Jago Douma 1ee9122244
Fix npm audit warning in build
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-08-30 11:46:24 +07:00
dependabot-preview[bot] 88cf6e13af
[Security] Bump mixin-deep from 1.3.1 to 1.3.2 in /build
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. **This update includes a security fix.**
- [Release notes](https://github.com/jonschlinkert/mixin-deep/releases)
- [Commits](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-08-27 18:07:31 +07:00
dependabot[bot] 3eef078b4f
Bump js-yaml from 3.12.0 to 3.13.1 in /build
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.12.0 to 3.13.1.
- [Release notes](https://github.com/nodeca/js-yaml/releases)
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nodeca/js-yaml/compare/3.12.0...3.13.1)

Signed-off-by: dependabot[bot] <support@github.com>
2019-08-08 07:43:03 +07:00
dependabot-preview[bot] 0d278eddf6
[Security] Bump fstream from 1.0.11 to 1.0.12 in /build
Bumps [fstream](https://github.com/npm/fstream) from 1.0.11 to 1.0.12. **This update includes a security fix.**
- [Release notes](https://github.com/npm/fstream/releases)
- [Commits](https://github.com/npm/fstream/compare/v1.0.11...v1.0.12)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-25 14:01:22 +07:00
dependabot-preview[bot] efd6c06658
Bump jsdoc from 3.6.2 to 3.6.3 in /build
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.2 to 3.6.3.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/master/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.2...3.6.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-21 01:12:55 +07:00
dependabot-preview[bot] 7a4e9f7a81
[Security] Bump lodash from 4.17.11 to 4.17.14 in /build
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14. **This update includes security fixes.**
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.14)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-11 02:21:38 +07:00
Morris Jobke c5c14d09b1
Merge pull request #16186 from nextcloud/bugfix/noid/also-check-permissions-when-creating-a-share
Better check reshare permissions part2
2019-07-03 20:07:05 +07:00
Joas Schilling e4addbae3e
Better check reshare permissions when creating a share
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-03 14:00:13 +07:00