Commit Graph

3342 Commits (fb901b0d93da99b0a49e963a6a35fd82b7051a98)

Author SHA1 Message Date
Nextcloud bot c407bb9786
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-25 02:44:41 +07:00
Côme Chilliet efebbacca4 Add octetLength and charLength to function builder, and tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 20:35:02 +07:00
Côme Chilliet 7dc3eb1e9e Use getLengthExpression to measure field length instead of like
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 20:35:02 +07:00
Arthur Schiwon 4656753df0
do not forget DB table prefix with truncate query
- as used in LDAP's AbstractMapping::clear() method
- and in Comment's ManagerTest::setUp()
- fixes a DB Exception with Oracle

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-03-18 16:59:46 +07:00
Côme Chilliet 475a859aae
Merge pull request #31421 from nextcloud/fix/user_ldap-fix-ldap-connection-resets
user_ldap fix ldap connection resets
2022-03-17 09:13:44 +07:00
Carl Schwan 371fa1c49a
Merge pull request #31542 from nextcloud/psalm-userCounts
Fix psalm issue about userCounts
2022-03-14 11:27:43 +07:00
Carl Schwan 1bf5ab35a8 Use "use" to import namespaces
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-03-14 09:35:01 +07:00
Carl Schwan 8d7380a15d Fix psalm issue about userCounts
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-03-11 14:17:29 +07:00
Côme Chilliet ccab35f23f
Fix similar potential problems with fetchOne loops
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-08 12:10:52 +07:00
Côme Chilliet 65a866556b
Fix duplicated UUID detection when there are empty uuids
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-08 11:57:33 +07:00
Côme Chilliet df29acb343
Set $limit as int as well in Access::count private method
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-08 10:21:54 +07:00
Arthur Schiwon 16b6504cc6
code style
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-03-03 21:32:54 +07:00
Arthur Schiwon f3668f2748
be conservative when reading from fresh created column
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-03-03 21:26:18 +07:00
Côme Chilliet dab5ea958a
Fix unit tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-03 16:35:06 +07:00
Côme Chilliet 0c5bd588ed
Fix types in OCA\User_LDAP\Configuration
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-03 11:53:50 +07:00
Côme Chilliet e80eb79a1e
Remove redundant is_array check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-03 11:41:59 +07:00
Côme Chilliet fb63484ced
Improve typing in user_ldap to detect problems early
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-03 11:12:09 +07:00
Côme Chilliet 8349530fb4
Fix executeRead when connection is reset because of a timeout
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-03 10:24:07 +07:00
Nextcloud bot 2f4a675caf
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-25 02:27:19 +07:00
Nextcloud bot 6da8a6d62a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-24 02:26:36 +07:00
Nextcloud bot 67f192e906
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-22 02:29:25 +07:00
Côme Chilliet 44680b5c3b
Make it explicit that a DN can be used for ldap:check-user
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-17 10:00:25 +07:00
Côme Chilliet a6ad06f940
Improve typing in apps/user_ldap/lib/Command/CheckUser.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-17 09:58:51 +07:00
Côme Chilliet a4f96c18e9
Remove parenthesis around return in apps/user_ldap/lib/Command/CheckUser.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-17 09:58:51 +07:00
Côme Chilliet 75ce9a4832
Fix ldap:check-user method for newly created LDAP users
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-17 09:58:28 +07:00
Louis Chemineau 95478ad9e2 Fix script loading in ldap's settings
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-02-14 16:56:55 +07:00
Nextcloud bot a615d15046
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-13 02:26:57 +07:00
Vincent Petry cd1bf94181
Merge pull request #31073 from nextcloud/fix/user_ldap-fix-access-typing
Improve typing in OCA\User_LDAP\Access and reduce psalm errors
2022-02-10 17:53:58 +07:00
Côme Chilliet bcfe99cc62
Fix psalm errors in apps/user_ldap/lib/Jobs/CleanUp.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-10 10:15:00 +07:00
Côme Chilliet 9f2db6e65d
Fix ldap:update-uuid
Generators cannot be iterated with while or returned by an other
 generator, using foreach instead.
And a few other problems.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-10 10:15:00 +07:00
Arthur Schiwon 45d4c0bf66
add occ command to update UUIDs (incomplete)
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-10 10:14:59 +07:00
Arthur Schiwon 601ce05dab
allow to re-run migration step when backup DB is already created
- to heal incomplete states from broken upgrades

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-10 10:14:59 +07:00
Arthur Schiwon 71fb44953e
invalidated duplicated UUIDs prior to migration change
- in a proper setup there are no duplicated UUIDs
- not all setups are proper
- log warning to admin

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-10 10:14:58 +07:00
Côme Chilliet 77add404b1
Remove mixed type not available in PHP 7.4
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-08 14:32:23 +07:00
Côme Chilliet 5f65d5a58d
Add a comment explaining how Helper::loginName2UserName can work
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-08 14:25:09 +07:00
Côme Chilliet 2a0b2250d2
Improve typing in OCA\User_LDAP\Access and reduce psalm errors
This should avoid some PHP warning using PHP 8.1
 and help detecting type trouble early in the future.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-08 14:21:16 +07:00
Arthur Schiwon 2bf57cbab8
fix overwriting of SUCCESS and INVALID consts
- already defined in Symfony\Component\Console\Command\Command

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-03 23:12:51 +07:00
Nextcloud bot e32090f44f
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-02 02:27:10 +07:00
Nextcloud bot 9f489422b4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-22 02:26:35 +07:00
Côme Chilliet 843b20c4e8
Remove useless indexes with duplicated names on backup table
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-13 17:21:26 +07:00
Joas Schilling 61c261b1e7
Update autoloader
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-13 14:22:30 +07:00
Côme Chilliet 7e4e919408
Fix user_ldap migration for long DNs support
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-13 14:06:59 +07:00
Côme Chilliet 23845755f2
Move duplicated code to a base class for group_mapping migrations
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2022-01-13 14:06:59 +07:00
Côme Chilliet d4cabf8a84
Split dropTable and createTable in two migrations
It is not possible to drop and create the same table in one migration

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-13 14:06:58 +07:00
Côme Chilliet e64e08ecac
Fix primary key change in user_ldap migration
Use a backup table to copy the data, drop table and recreate it with
 correct primary key, then copy the data back and drop the backup table.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-13 14:06:58 +07:00
Carl Schwan 89d109a4d9
Merge pull request #30508 from nextcloud/fix/psaml-bin
Fix psalm not running
2022-01-13 09:51:04 +07:00
Nextcloud bot 094fbb9c0d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-13 02:26:35 +07:00
Carl Schwan aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-12 20:03:06 +07:00
Louis 2e1491771e
Merge pull request #30572 from nextcloud/fix/lint_warnings
Fix lint warnings
2022-01-12 15:48:36 +07:00
Louis Chemineau 14e57bf70a Replace license information to SPDX expression
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:26:40 +07:00
Louis Chemineau 9fc6cc9634 Add generic type and description when its missing
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:13:04 +07:00
Louis Chemineau d92cbf5149 Typing corrections
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:12:55 +07:00
rakekniven 2f6c7b68ab Removed obselete language files - Pt. II
For these files there are no associated languages setup at Transifex.

Fix for #30501

Related to nextcloud/docker-ci#341

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-01-10 14:07:14 +07:00
rakekniven a47d23c1e4 Removed obselete language files
Those files are remnants of old languages after renaming, mapping or deleting.

Fix for #30501

Related to https://github.com/nextcloud/docker-ci/issues/341
2022-01-09 22:01:52 +07:00
Nextcloud bot a781133437
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-07 02:28:02 +07:00
Côme Chilliet 59862f7175
Improve ldap:test-config occ command
Test a search on the base, as the settings wizard is doing.
This is to avoid the wizard saying the base is wrong and the command
 saying everything is fine.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-04 12:17:58 +07:00
Nextcloud bot 8057615ce7
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-03 02:27:36 +07:00
Nextcloud bot e027d2bec6
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-27 02:27:18 +07:00
John Molakvoæ c0cfd237ab
Merge pull request #30299 from nextcloud/fix/log_files 2021-12-20 17:27:05 +07:00
Carl Schwan 52760a95d9
Check if directoy is writable instead of possibly missing file
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-12-20 15:36:52 +07:00
John Molakvoæ b5ae67ac2a
Merge pull request #29329 from nextcloud/fix/noid/groups-unwarranted-members 2021-12-20 10:07:55 +07:00
Côme Chilliet 743267eba4
Fix LDAP related docblocks types
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-16 09:43:31 +07:00
Côme Chilliet f3dcbfe146
Fix PHP 8.1 support for user_ldap application
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-16 09:43:30 +07:00
Nextcloud bot f567f6afae
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-16 02:27:47 +07:00
Côme Chilliet 78a59c12fc
Bump user_ldap version to make sure the migration runs
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-09 17:42:44 +07:00
Côme Chilliet 57fda4414f
Add missing copyright headers in migration steps
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-09 17:42:17 +07:00
John Molakvoæ 2e869fd215
Merge pull request #29523 from nextcloud/fix/support-ldap-long-dns 2021-12-09 17:18:43 +07:00
Nextcloud bot 0e665e0646
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-08 02:28:44 +07:00
Joas Schilling 168c673755
Allow to log DB, redis and LDAP requests into files
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 22:33:41 +07:00
blizzz 84e47fb484
Merge pull request #29470 from nextcloud/fix/translit-php8
Avoid use of iconv to get rid of unicode
2021-11-29 11:37:19 +07:00
Nextcloud bot c9f96253d6
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-27 02:25:46 +07:00
Julius Härtl 388fa06695
Merge pull request #29837 from nextcloud/fix/user_ldap-check-cache 2021-11-25 16:33:52 +07:00
Nextcloud bot 9d6496a999
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-24 02:25:52 +07:00
Côme Chilliet 20dd46fcae
Merge pull request #29610 from nextcloud/fix/user_ldap-logger
Get rid of user_ldap LogWrapper and use LoggerInterface
2021-11-23 15:26:25 +07:00
Côme Chilliet 7ac895e766
Move back logger to protected in OCA\User_LDAP\User\User
It was changed to private because of a bad copy/paste.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 11:06:14 +07:00
Côme Chilliet f932766acf
Check LDAP upon user deletion instead of refusing based on cached information
This should avoid having to wait for background job to run after
 deleting a user in LDAP before being able to delete it in Nextcloud.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 10:59:13 +07:00
Côme Chilliet a35904749f
Use clearer names for variables
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:20:31 +07:00
Côme Chilliet 514324916b
Add an index for directory_uuid as well
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:20:30 +07:00
Côme Chilliet df25a6de31
Make sure that hash function returns a string
The documentation says it can return false, and even if that is highly
 unlikely for sha256, better safe than sorry.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:20:30 +07:00
Côme Chilliet 14f00208e2
Add the columns and alter the index in Version1010Date20200630192842
This is to ensure new installations do not need to go through migration
 history.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:20:30 +07:00
Côme Chilliet c4d8bd9c05
Fixes in migration step
We cannot set ldap_dn_hash column as notnull because it is empty for
 existing users before postSchemaChange is called

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:20:29 +07:00
Côme Chilliet d4c49a3a60
Put back length check to have a clear error
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:20:29 +07:00
Côme Chilliet ce5192a461
Fixed migration step for user_ldap
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:20:29 +07:00
Joas Schilling 9a1df9ddca
Fix variable names
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-23 09:19:50 +07:00
Côme Chilliet 31a503b387
Change column names to ldap_dn and ldap_dn_hash and add migration
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:19:50 +07:00
Côme Chilliet 662e3240b0
Support LDAP dns longer than 255 characters
Adds an ldap_full_dn column to store the dn, and only store a sha256
 hash in the ldap_dn which is shorter and can be indexed without
 trouble.
Migration still needs to be implemented.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:19:49 +07:00
Côme Chilliet 480056de88
Fix sanitizing regex and add a test case for uppercase in username
I did not find any test data that would fail with the previous regex,
 but still added data with uppercase to at least test that.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:10:38 +07:00
Côme Chilliet 3446d9c0b2
Ignore cache in occ ldap:check-ldap command
This avoids having to wait or reset the cache after deleting a user in
 the LDAP.
This also fixes a PHP error when running ldap:check-ldap --update on a
 deleted but cached user.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-22 16:44:27 +07:00
Côme Chilliet 26330cb774
Test cache invalidation for AbstractMapping in test suite
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-22 14:57:08 +07:00
Côme Chilliet 51ea7dc020
Make sure mapping cache is cleared when deleting a user
This avoids phantom remnants staying after user deletion

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-22 14:49:34 +07:00
Arthur Schiwon 8266f88755
fix potential unwarranted memberships in nested groups from LDAP
- the issue was present only when using PHP based resolving of nested
  group members. Normally nested members are common in AD (and Samba4) and
  are resolved per LDAP_MATCHING_RULE_IN_CHAIN by default
- resolving nested members is recursive
- when the cache entry was created it happend for intermediate groups, too,
  containing members from the parent group
- the check was added to only cache the root group with its members
- a runtime cache stores intermediate ldap read results


Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-11-19 13:07:19 +07:00
Nextcloud bot c35ad0c20d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-19 02:38:13 +07:00
Nextcloud bot 72787cdcfd
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-14 02:25:33 +07:00
Nextcloud bot 7071d056a2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-13 02:25:42 +07:00
Nextcloud bot eb7109b3f4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-12 02:22:55 +07:00
Joas Schilling 8e12ac290f
Master is now 24
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-11 10:11:09 +07:00
Côme Chilliet 651147874f
Update autoloader accordingly
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-09 15:14:58 +07:00
Côme Chilliet 6b960de47c
Get rid of LogWrapper calling deprecated logger and use LoggerInterface from PSR instead
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-09 15:11:15 +07:00
Carl Schwan dacf2e47a3
Update to composer 2.1.11
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-11-04 12:30:11 +07:00
Côme Chilliet 158e73242e
Avoid use of iconv to get rid of unicode
Using iconv for translit depends upon server configuration, locale, and
 PHP version. Using htmlentities instead to have a consistent behavior
 independent of configuration.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-28 10:30:14 +07:00
Nextcloud bot b691f30af1
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-26 02:22:53 +07:00
Nextcloud bot 7c2d8d3e82
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-23 02:22:31 +07:00
Carl Schwan a67a12cb96
Merge pull request #29240 from nextcloud/work/admin-delegation-implementation
Add support for Delegation Settings for more apps
2021-10-15 20:59:43 +07:00
Carl Schwan 719dbafd13
Add support for Delegation Settings for more apps
* This adds support for the sharing, groupware, theming and user_ldap
  app
* This adds some code who disapeared during a rebase in the initial
  delegation PR (provisioning_api)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-10-15 18:41:00 +07:00
John Molakvoæ f7a4ff4d63
Merge pull request #27217 from nextcloud/techdebt/noid/make-debugging-a-cron-job-easier 2021-10-15 11:09:23 +07:00
Côme Chilliet f9e6f2ea57
Use Psr\Log\LoggerInterface where it can easily be used in user_ldap
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-14 14:12:03 +07:00
Joas Schilling 3adc997833
Bump autoloader
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-14 09:58:49 +07:00
Côme Chilliet d189a23f43
Fix two mistakes in previous migration to LoggerInterface in OCA\User_LDAP\Access
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-14 09:24:49 +07:00
Côme Chilliet 51398d706a
Use Psr\Log\LoggerInterface in OCA\User_LDAP\Access
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-12 17:19:51 +07:00
Côme Chilliet 437048e9b6
Avoid PHP errors when the LDAP attribute is not found
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-12 12:44:26 +07:00
Vincent Petry 5a6a0b0d3b
Update app versions for 23
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-09-28 12:21:40 +07:00
blizzz e8f76b03bb
Merge pull request #28876 from nextcloud/fix/28653/ldap-long-user-group-ids
ensure that user and group IDs in LDAP's tables are also max 64chars
2021-09-24 22:53:06 +07:00
Arthur Schiwon 6ab30a669b
ensure that user and group IDs in LDAP's tables are also max 64chars
- limitation by core tables (e.g. sharing), IDs are always 64chars
- when longer group IDs were requested they are hashed (does not affect
  displaynames)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-24 17:29:29 +07:00
Vincent Petry ea20454a2b
Merge pull request #28916 from nextcloud/fix/noid/objectsid
fix caching of objectsid searches
2021-09-24 17:04:12 +07:00
Christoph Wurst a2bc7e2eec Update generated composer files to latest format
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-09-22 11:37:04 +07:00
Arthur Schiwon 7178194198
fix caching of objectsid searches
- store result when no name could be retrieved, too
- cached value is not an array, was treated wrongly

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-21 13:32:42 +07:00
Nextcloud bot 208a7b688d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-15 02:27:54 +07:00
Nextcloud bot 58891a9655
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-14 02:30:41 +07:00
Arthur Schiwon 27865d03c0
use specific email getter where necessary
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +07:00
John Molakvoæ d24929b98a
Merge pull request #28420 from nextcloud/fix/composer-2-missing-files
Add missing files for Composer v2
2021-08-15 10:25:46 +07:00
Nextcloud bot b61bb729c2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-14 02:26:43 +07:00
Christoph Wurst 6a50c4a344
Add missing files for Composer v2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-08-13 15:01:02 +07:00
Nextcloud bot a716c35888
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-10 02:31:43 +07:00
Nextcloud bot 27847a9250
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-08 02:21:43 +07:00
Nextcloud bot de68aecb05
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-06 02:26:56 +07:00
Nextcloud bot 276b8f2315
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-02 07:35:19 +07:00
Nextcloud bot 7f572c0645
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-07-15 10:37:23 +07:00
Nextcloud bot bdb5d9f418
[tx-robot] updated from transifex 2021-07-10 02:31:32 +07:00
Nextcloud bot 726f23ffd9
[tx-robot] updated from transifex 2021-07-08 02:26:46 +07:00
Nextcloud bot 4aefd04f40
[tx-robot] updated from transifex 2021-07-04 02:25:36 +07:00
Julius Härtl 3853307a6a
Merge pull request #26681 from nextcloud/techdebt/hint-exception-ocp
Move HintException to OCP
2021-07-01 08:34:55 +07:00
Nextcloud bot bb40e65e4e
[tx-robot] updated from transifex 2021-07-01 02:24:48 +07:00
Gary Kim b78f3a57d1
Migrate HintException to OCP
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 +07:00
Arthur Schiwon f62c066459
unset ldap provider when disabling user_ldap
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 15:25:00 +07:00
Arthur Schiwon bbcd8c9a68
LDAP: determine shares of offline users only when needed
- determine shares may via Sharing code result in user exists checks
- this may result in an infinite loop when user exists was called before
- the info is really only required at one occ command

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-28 12:56:37 +07:00
Nextcloud bot ac97873a17
[tx-robot] updated from transifex 2021-06-28 02:25:09 +07:00
Nextcloud bot 67851a0262
[tx-robot] updated from transifex 2021-06-27 02:25:38 +07:00
Joas Schilling 655108a3dc
Bump app version
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-24 16:08:39 +07:00
Joas Schilling 8b0448d407
Master is now 23
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-24 12:56:06 +07:00
Nextcloud bot 4158f1a848
[tx-robot] updated from transifex 2021-06-24 02:25:18 +07:00
Nextcloud bot 1977114f01
[tx-robot] updated from transifex 2021-06-23 02:26:18 +07:00
Louis Chemineau f0876a9e9d Update Autoloader
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-06-21 15:54:51 +07:00
Nextcloud bot da408dbcbd
[tx-robot] updated from transifex 2021-06-19 02:26:44 +07:00
Christoph Wurst 39f0aa5abe
Merge pull request #27515 from nextcloud/enh/noid/read-multi-value-user-attribute
Add method to read multi-value attributes from ldap
2021-06-16 15:51:09 +07:00
Daniel Kesselberg 04411df695
Add method to read multi-value attributes from ldap.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-06-16 11:35:27 +07:00
Daniel Kesselberg 33801708d2
Add return type for writeToCache
writeToCache does not return a string.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-06-15 17:03:03 +07:00
Nextcloud bot d3264df6f4
[tx-robot] updated from transifex 2021-06-10 02:32:12 +07:00
Christoph Wurst bf564e2a5a
Convert command option defaults to strings
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-09 13:25:31 +07:00
Nextcloud bot 1c97818e14
[tx-robot] updated from transifex 2021-06-09 02:26:15 +07:00
Nextcloud bot f6485f98f0
[tx-robot] updated from transifex 2021-06-08 02:26:20 +07:00
Nextcloud bot d1d4725630
[tx-robot] updated from transifex 2021-06-07 02:25:07 +07:00
John Molakvoæ (skjnldsv) 215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
Nextcloud bot 46dbc8fa98
[tx-robot] updated from transifex 2021-06-04 02:28:13 +07:00
Nextcloud bot 26f537fbec
[tx-robot] updated from transifex 2021-06-03 02:28:43 +07:00
Nextcloud bot 142d311a13
[tx-robot] updated from transifex 2021-06-02 02:28:31 +07:00
Valdnet 50e080f37f
l10n: Split sentences 2021-06-01 10:28:54 +07:00
Nextcloud bot f2101487a0
[tx-robot] updated from transifex 2021-06-01 02:28:20 +07:00
Joas Schilling 7e8ddcd38f
Merge pull request #26706 from nextcloud/Valdnet-patch-7
l10n: Spelling unification
2021-05-31 17:21:16 +07:00
Nextcloud bot accfe5b82d
[tx-robot] updated from transifex 2021-05-26 02:28:28 +07:00
Nextcloud bot 3fa2437223
[tx-robot] updated from transifex 2021-05-25 02:27:20 +07:00
Valdnet 77ca79f697
l10n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet 47037905+Valdnet@users.noreply.github.com
2021-05-21 11:50:12 +07:00
Nextcloud bot a6cb2973a9
[tx-robot] updated from transifex 2021-05-21 02:27:50 +07:00
François Freitag d887851183 Prefer string $file over 1-element array in script()
The string syntax is more obvious. There should be one (and preferably
only one) way of doing things.

Signed-off-by: François Freitag <mail@franek.fr>
2021-05-18 09:24:05 +07:00
Nextcloud bot 5ea903d824
[tx-robot] updated from transifex 2021-05-16 02:26:44 +07:00
Nextcloud bot 0df326ab20
[tx-robot] updated from transifex 2021-05-12 02:26:16 +07:00
Nextcloud bot df71883c9a
[tx-robot] updated from transifex 2021-05-09 02:25:15 +07:00
Nextcloud bot 461a975749
[tx-robot] updated from transifex 2021-05-08 02:24:54 +07:00
Nextcloud bot 6d3aef1849
[tx-robot] updated from transifex 2021-05-04 02:26:15 +07:00
Nextcloud bot f3baab3159
[tx-robot] updated from transifex 2021-04-30 02:27:46 +07:00
Nextcloud bot be4f665d2d
[tx-robot] updated from transifex 2021-04-28 02:25:44 +07:00
Arthur Schiwon 2a5473e146
do not try to search after the last page
- saves an LDAP requests in these cases
- prevents a Protocol Error logged on < 7.3 API (for backports)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-27 12:52:26 +07:00
Arthur Schiwon 5e8f43a55e
removes PagedResults adapter for PHP < 7.3
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-26 22:57:42 +07:00
Nextcloud bot 4ded8a08b7
[tx-robot] updated from transifex 2021-04-26 02:24:39 +07:00
Nextcloud bot da17db0fdc
[tx-robot] updated from transifex 2021-04-25 02:24:52 +07:00
Nextcloud bot 39764b05b1
[tx-robot] updated from transifex 2021-04-24 02:26:38 +07:00
Nextcloud bot 539c065e8e
[tx-robot] updated from transifex 2021-04-23 02:26:10 +07:00
Nextcloud bot 634b6b8b57
[tx-robot] updated from transifex 2021-04-22 02:26:21 +07:00
Roeland Jago Douma 4e39d1ce93
Merge pull request #26609 from nextcloud/Valdnet-patch-6
l10n: Improve styling
2021-04-21 19:56:41 +07:00
Joas Schilling 39e248d330
Fix LDAP unit tests
20) OCA\user_ldap\tests\Jobs\UpdateGroupsTest::testHandleKnownGroups
Trying to configure method "fetchAll" which cannot be configured because it does not exist, has not been specified, is final, or is static

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:22:52 +07:00
Nextcloud bot 8c82dd37b4
[tx-robot] updated from transifex 2021-04-19 02:26:04 +07:00
Valdnet 2445c82750
l10n: Improve styling
"Empty field" information shifted to the end of the sentence. It looks more stylistic.
2021-04-18 11:39:46 +07:00
Roeland Jago Douma 0593b039fc Move over notification to new registration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +07:00
Nextcloud bot 41216e68bf
[tx-robot] updated from transifex 2021-04-08 02:24:01 +07:00
Nextcloud bot c391e8692b
[tx-robot] updated from transifex 2021-04-07 02:24:14 +07:00
Nextcloud bot bb3ba96b37
[tx-robot] updated from transifex 2021-04-05 02:24:46 +07:00
Nextcloud bot 6f55d2e293
[tx-robot] updated from transifex 2021-04-03 02:25:32 +07:00
Morris Jobke 6a81477ffe
Merge pull request #25326 from nextcloud/ldap-factory-no-ldap
make ILDAPProviderFactory usable when there is no ldap setup
2021-03-31 21:23:23 +07:00
Robin Appelman 65b78515bd
make ILDAPProviderFactory usable when there is no ldap setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-31 15:23:33 +07:00
Johannes Leuker 9660a3fa90 Add json, yaml output options to ldap:show-config
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-31 12:36:22 +07:00
Nextcloud bot be83a32411
[tx-robot] updated from transifex 2021-03-28 02:24:04 +07:00
Nextcloud bot bb8a71266e
[tx-robot] updated from transifex 2021-03-24 02:25:07 +07:00
Nextcloud bot a81408a8e1
[tx-robot] updated from transifex 2021-03-23 02:24:02 +07:00
Nextcloud bot ae19cb168f
[tx-robot] updated from transifex 2021-03-22 02:23:45 +07:00
Nextcloud bot 8c7e246d98
[tx-robot] updated from transifex 2021-03-21 02:23:12 +07:00
Nextcloud bot cb2745a541
[tx-robot] updated from transifex 2021-03-20 02:23:44 +07:00
Joas Schilling 0d46fafd41
Merge pull request #26161 from nextcloud/bugfix/noid/improve-matching-of-phonebook-searches
Improve search results when only phonebook-matches can we autocompleted
2021-03-17 15:22:03 +07:00
Morris Jobke d011df6aa7
Merge pull request #26076 from nextcloud/enh/noid/ldap-occ-user-reset
adds ldap user:reset command
2021-03-17 14:36:18 +07:00
Arthur Schiwon 1b0355f2c6
adds ldap user:reset command
- allows to delete data of existing LDAP users, which otherwise is safe
  guarded
- ensures that the user is not being deleted on LDAP through a plugin

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-17 11:23:48 +07:00
Joas Schilling 3379e69ecc
Fix parameter types in docs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 09:51:31 +07:00
Nextcloud bot f82edda9c1
[tx-robot] updated from transifex 2021-03-15 02:23:58 +07:00
Nextcloud bot 73bf04c2f5
[tx-robot] updated from transifex 2021-03-09 02:23:53 +07:00
Nextcloud bot e8f087d7d1
[tx-robot] updated from transifex 2021-03-08 02:23:08 +07:00
Nextcloud bot c28542ef7f
[tx-robot] updated from transifex 2021-03-07 02:22:07 +07:00
Nextcloud bot 41f9fdab1c
[tx-robot] updated from transifex 2021-03-06 02:22:22 +07:00
Roeland Jago Douma 54cffefed4
Merge pull request #25660 from hosting-de/feature/add-backend-list-groups
Show group backends in occ group:list --info and group:info
2021-03-05 08:49:43 +07:00
Nextcloud bot 365d31743f
[tx-robot] updated from transifex 2021-03-04 02:22:10 +07:00
blizzz ef5389603c
Merge pull request #25860 from nextcloud/fix/noid/ldap-bind-expired
do not die after LDAP auth failed with expired acc
2021-03-02 21:34:03 +07:00
Roeland Jago Douma 19e2136963 Update autoloader files
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 16:36:21 +07:00
Arthur Schiwon 5ad08c7c84
do not die after LDAP auth failed with expired acc
- some servers return error code 53

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-01 19:20:05 +07:00
Johannes Leuker 2796ef80ff Show group backends in occ group:list --info and group:info
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-01 16:02:08 +07:00
blizzz 9cd39b0b8c
Merge pull request #25757 from nextcloud/fix/noid/ldap-cyclic-group-memberships
fix detecting cyclic group memberships
2021-03-01 12:07:59 +07:00
Nextcloud bot 65b0511d79
[tx-robot] updated from transifex 2021-02-27 02:22:23 +07:00
Nextcloud bot b4ccadea2b
[tx-robot] updated from transifex 2021-02-26 02:21:45 +07:00
Arthur Schiwon 4d33449faa
fix detecting cyclic group memberships
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-23 22:50:43 +07:00
Nextcloud bot ff54a0481b
[tx-robot] updated from transifex 2021-02-23 02:39:25 +07:00
dependabot-preview[bot] eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +07:00
Roeland Jago Douma 644e6df02e
Merge pull request #25440 from nextcloud/bugfix/noid/cache-the-user-backend-info-for-30s
Cache the user backend info for 5mins
2021-02-17 08:56:55 +07:00
Nextcloud bot 57212a99f9
[tx-robot] updated from transifex 2021-02-17 02:21:05 +07:00
Nextcloud bot 45d36ec2b2
[tx-robot] updated from transifex 2021-02-16 02:21:36 +07:00
Roeland Jago Douma 3f4ece256e Some psalm OfflineUser fixes
For #25641

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 13:36:02 +07:00
Joas Schilling 645f83121e
Cache the user backend info for 300s
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-15 10:36:08 +07:00
Nextcloud bot 361f160d0d
[tx-robot] updated from transifex 2021-02-12 02:20:18 +07:00
Nextcloud bot 26a20ed13f
[tx-robot] updated from transifex 2021-02-08 02:20:05 +07:00
Joas Schilling 9de00f3d24
This is 22
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-03 08:38:41 +07:00
Nextcloud bot e18c608cb4
[tx-robot] updated from transifex 2021-02-02 02:19:50 +07:00
Nextcloud bot 86678ba5df
[tx-robot] updated from transifex 2021-02-01 02:19:36 +07:00
Christoph Wurst 6a3321cefe
Merge pull request #25101 from nextcloud/fix/noid/ldap-known-groups
LDAP: make actually use of batch read known groups
2021-01-29 10:57:31 +07:00
Roeland Jago Douma e29f903dc4
Merge pull request #25360 from nextcloud/fix/update-autoloaders
Update all composer autoloader files
2021-01-28 20:38:22 +07:00
Arthur Schiwon 90d82b03ef
fix parameter provided as string not array
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-28 15:15:55 +07:00
Christoph Wurst 299f37c5d9
Update all composer autoloader files
The format changed between 2.0.8 and 2.0.9.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-28 14:24:34 +07:00
Nextcloud bot b2f183a26c
[tx-robot] updated from transifex 2021-01-26 02:21:31 +07:00
Nextcloud bot 48854f26a6
[tx-robot] updated from transifex 2021-01-24 02:19:46 +07:00
blizzz 939433363e
Merge pull request #25128 from nextcloud/ldapprovider-get-property
extend ILDAPProvider to allow reading arbitrairy ldap attributes for users
2021-01-22 14:31:19 +07:00
Arthur Schiwon ef0a3a92f4
silence log message
- this appears too often (in some configurations) when qualifying group
members which do not meet the criteria

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-21 17:25:44 +07:00
Robin Appelman fdc8635afb
extend ILDAPProvider to allow reading arbitrairy ldap attributes for users
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-19 16:33:58 +07:00
Nextcloud bot 91864aeb40
[tx-robot] updated from transifex 2021-01-19 02:20:43 +07:00
blizzz f9ab7575e7
Merge pull request #25036 from nextcloud/fix/noid/limitied-allowed-items-db-in_2
respect DB restrictions on number of arguments in statements and queries
2021-01-14 11:36:42 +07:00
Arthur Schiwon 21ca5d4514
silence psalm false positive
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-13 11:54:29 +07:00
Arthur Schiwon 02b703193a
really use known groups
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-12 20:52:52 +07:00
Christoph Wurst c1d4f8161b
Migrate internal classes to the OCP db col types
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +07:00
Arthur Schiwon 45e3261ad5
respect DB limits limit per statement and query
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-11 13:43:34 +07:00
Christoph Wurst 8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +07:00
Roeland Jago Douma dc89447f13
Revert "(LDAP) respect DB limits of arguments in an IN statement" 2021-01-08 10:44:32 +07:00
Arthur Schiwon 6eca8d6ae1
respect DB limits of arguments in a IN list
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-07 20:16:40 +07:00
Nextcloud bot 364b29b1e9
[tx-robot] updated from transifex 2021-01-05 02:21:26 +07:00
Christoph Wurst 9ce3ea3368
Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-30 14:07:05 +07:00
Roeland Jago Douma adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net
Unify links to php.net
2020-12-22 09:53:31 +07:00
Nextcloud bot de7c54c6ba
[tx-robot] updated from transifex 2020-12-18 02:20:09 +07:00
Christoph Wurst d89a75be0b
Update all license headers for Nextcloud 21
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +07:00
blizzz f68cab4e39
Merge pull request #24402 from nextcloud/fix/24252/ldap-ingroup-memberid
LDAP: fix inGroup for memberUid type of group memberships
2020-12-15 22:33:41 +07:00