Arthur Schiwon
d946256ff9
Merge pull request #38088 from nextcloud/fix/38053/change-display-name
...
fix(user): Can change display name
2023-05-09 11:48:10 +07:00
Louis Chemineau
b67e34f78f
Restrict EXIF extracting to a subset of formats
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-05-09 11:43:56 +07:00
Louis Chemineau
157be42a83
Prevent error on files scan if metadata exists
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-05-09 11:43:56 +07:00
Simon L
84b88c01c7
adjust wording
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-05-09 11:19:48 +07:00
Côme Chilliet
1cc1866ba3
Add back missing slash in LazyUserFolder path
...
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-05-09 10:59:31 +07:00
Simon L
6e5a307757
adjust wording for update hint when files of a specific app are not there
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-05-09 10:56:02 +07:00
Nextcloud bot
158405127b
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-09 02:19:48 +07:00
Arthur Schiwon
c7bb540d08
Merge pull request #36895 from apasov/patch-1
...
Fix json_decode expecting a string
2023-05-08 21:20:38 +07:00
Joas Schilling
598859d969
Merge pull request #38097 from nextcloud/bugfix/38087/dont-translate-when-from-and-to-are-equal
...
fix(translation): Don't use translation providers when from and to ar…
2023-05-08 09:40:22 +07:00
Joas Schilling
b1c6b940a6
Merge pull request #38102 from nextcloud/feature/noid/add-messageid-to-talk-richobject-definition
...
Add messageId to richObject definition of Talk
2023-05-08 09:26:04 +07:00
Nextcloud bot
737e79854e
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-06 02:27:44 +07:00
Christopher Ng
4e51f5224c
feat(UserMigration)!: 32-bit support
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-05-05 17:59:57 +07:00
jld3103
04d840211f
Remove version check for ancient libxml version
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-05-05 19:07:55 +07:00
Marcel Müller
484f7a6641
Add messageId to richObject definition of Talk
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2023-05-05 17:51:53 +07:00
Joas Schilling
505e467cc4
fix(translation): Don't use translation providers when from and to are the same
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-05 14:03:14 +07:00
John Molakvoæ
46459ae93f
Merge pull request #35092 from Messj1/bugfix/type-error-cert-manager-cache-path
2023-05-04 21:53:49 +07:00
Christopher Ng
4ecae83385
fix(user): Can change display name
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-05-04 11:14:49 +07:00
Côme Chilliet
6034cc6893
Make sure to never trigger files hooks on a null path
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-04 17:55:09 +07:00
Robin Appelman
f8b4e0025b
Merge pull request #37865 from nextcloud/info-file-space
...
add command to summarize space usage
2023-05-04 18:21:11 +07:00
Carl Schwan
85770f3b9f
Make it easier to debug issue #32304
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-05-04 11:11:52 +07:00
Robin Appelman
5c31c35d40
add option to list all files instead of limiting
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-04 13:10:26 +07:00
Simon L
527de8ac9d
Merge pull request #37148 from nextcloud/enh/noid/increase-imaginary-timeouts
...
increase imaginary timeouts as for big files the processing could take very long
2023-05-04 12:44:52 +07:00
Thomas Citharel
375466819e
fix(mimetype): Fix returning value when finding existing mimetype in MimeType Loader
...
Also, only return the ID from the transaction as the mimetype string is
already used from the function argument value
Fixes https://github.com/nextcloud/server/pull/35744/files#r1184644610
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-05-04 11:15:50 +07:00
Joas Schilling
b44de9ccb8
Merge pull request #38046 from nextcloud/bugfix/noid/abort-dav-requests-with-429
...
fix(dav): Also throw in basic auth requests
2023-05-04 09:06:57 +07:00
Daniel
db73534e09
Merge pull request #38016 from nextcloud/oracle-limit-workaround
...
fix: add workaround for oci and limit queries
2023-05-03 23:06:59 +07:00
Joas Schilling
b91957e3df
fix(dav): Abort requests with 429 instead of waiting
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-03 22:43:36 +07:00
Arthur Schiwon
7a7578cb86
Merge pull request #37937 from nextcloud/artonge/feat/remove_non_existing_jobs
...
Remove job from oc_jobs when the file is not findable
2023-05-03 12:51:11 +07:00
Joas Schilling
9ace8e561d
Merge pull request #38003 from nextcloud/bugfix/noid/improve-translations-api
...
Improve translations api with detecting languages
2023-05-03 11:07:30 +07:00
Louis Chemineau
8ad2f34045
Remove job from oc_jobs when the file is not findable
...
When an application is disabled, or when a background jobs is removed by the app developer, then the job won't be found. In those cases, it makes sense to remove those jobs from oc_job.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-05-03 10:39:38 +07:00
Arthur Schiwon
997efe44ff
Merge pull request #37943 from nextcloud/fix/fix-getcontent-return-type
...
Fix file_get_content signatures to make it clear it can return false
2023-05-03 10:34:51 +07:00
Arthur Schiwon
ef87dfc478
Merge pull request #33106 from nextcloud/feature/update-expire-date
...
Update expire_date column of table comments
2023-05-03 10:26:28 +07:00
Julius Härtl
3bdd770129
fix: Check for wrapped retriable exceptions
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-05-02 19:42:11 +07:00
Julius Härtl
11c5bc6a2a
fix: Wrap filesystem LockedExceptions for holding the readable path
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-05-02 19:40:27 +07:00
Côme Chilliet
f7632f2fc4
Merge pull request #32866 from nextcloud/performance/searchInGroup-displayname-cache
...
Optimize retrieving display name when searching for users in a group
2023-05-02 16:42:09 +07:00
Joas Schilling
9d6ec68b59
feat(translation): Return the detected language so clients can show more details
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-02 16:38:33 +07:00
Joas Schilling
dc67b48c28
fix(translation): Detect the language first and then ask all providers for translations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-02 16:38:33 +07:00
Simon L
4dfadcabb9
Merge pull request #38014 from nextcloud/norm-logic
...
Normalize logical operators
2023-05-02 16:27:58 +07:00
Daniel Kesselberg
eecdb62e92
fix: add workaround for oci and limit queries
...
DBAL uses a helper column "doctrine_rownum" for top-n queries
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-05-02 14:26:28 +07:00
Côme Chilliet
10296ba7e5
Fix tests, and fix Group::searchUsers to avoid duplicates
...
Also went back to searchUsers indexing the array by uid as it was the
previous behavior and the IGroup phpdoc does not say anything about the
keys.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 11:35:41 +07:00
Git'Fellow
951c5b973e
Normalize logical operators
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-05-02 10:10:02 +07:00
Robin Appelman
e7ab30f5d8
log performance events for http requests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-28 15:37:57 +07:00
Robin Appelman
f5e2b0b22f
allow storing multiple mounts for the same rootid in the mount cache
...
currently `[$userId, $rootId]` is used as the unique key for storing mounts in the mount cache,
however there are cases where the same rootid is mounted in multiple places for a user which currently leads to not all of those mounts being added to the cache.
Previously this didn't matter as the mount cache was only used to list users with access to a specific file, so a user having access to the file multiple times didn' change anything.
With 24 the mount cache is used for more cases and multiple mounts for the same id becomes relevant.
While I think there isn't a real negative effect atm besides missing the optimized path we should ensure that the mounts are properly listed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-28 15:08:08 +07:00
John Molakvoæ
20df0019f1
fix(psalm): systemtags
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-04-28 12:23:52 +07:00
Julius Härtl
a6fe9130b9
fix: Empty fallback for template creator action label
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-27 15:52:08 +07:00
Côme Chilliet
346344c153
Update version number in since and deprecated annotations
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:04:32 +07:00
Côme Chilliet
b6c17c6ce7
Clear up return types
...
usersInGroup index by int for BC, searchInGroup index by uid (string).
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:00:45 +07:00
Côme Chilliet
6385a5af36
Let OC\Group\Group handle the fallback and remove default implementation from ABackend
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:00:43 +07:00
Côme Chilliet
3c2b126eba
Make code clearer and bump @ deprecated annotations
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:00:07 +07:00
Carl Schwan
a4c599c1c9
Split new method in a new group backend interface
...
Better for backward compatibility, also move new interfaces to nc 26
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-04-27 12:00:01 +07:00
Carl Schwan
35dc223500
Optimize retrieving display name when searching for users in a group
...
This is recurrent scenario that we are searching for users and then for
each users we fetch the displayName. This is inefficient, so instead try
to do one query to fetch everything (e.g. Database backend) or use the
already existing DisplayNameCache helper.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-04-27 11:57:45 +07:00
Côme Chilliet
546d94c3ec
Fix file_get_content signatures to make it clear it can return false
...
In File::getContent, which must return a string, throw an Exception
instead of returning false.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 09:56:05 +07:00
Christopher Ng
966bc06e8d
Create new file/folder labels
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-04-27 03:20:12 +07:00
Vitor Mattos
7ab50ab010
Update expire_date column of table comments
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-04-26 11:29:56 +07:00
Daniel
81e4390e32
Merge pull request #37925 from nextcloud/feat-update-maintenance-mode-hint
...
fix: change maintenance mode info wording
2023-04-26 13:55:22 +07:00
Christoph Wurst
ea67129b64
Merge pull request #37480 from nextcloud/fix/ocp/ilogfactor-getcustomlogger-deprecation-version
...
fix(ocp): Add deprecation version to ILogFactory::getCustomLogger
2023-04-26 11:58:40 +07:00
Daniel Kesselberg
155ea6a54c
fix: change maintenance mode info wording
...
In maintenance mode the database is accessible and it's possible to execute other commands then maintenance:mode
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-04-26 11:58:37 +07:00
Nextcloud bot
278f6413c9
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-26 02:28:10 +07:00
Joas Schilling
75f17b6094
Merge pull request #37905 from nextcloud/techdebt/noid/add-attributes-for-remaining-security-annotations
...
feat(security): Add PHP \Attribute for remaining security annotations
2023-04-25 17:13:53 +07:00
Joas Schilling
ecb8b55c5c
feat(security): Add PHP \Attribute for remaining security annotations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-25 14:50:32 +07:00
Robin Appelman
d60172567f
Merge pull request #37818 from nextcloud/dav-ext-storage-log
...
debug log requests made by dav external storage/shares
2023-04-25 14:12:57 +07:00
Côme Chilliet
7250f54ca3
Merge pull request #37835 from nextcloud/feat/background-allow-parallel-runs
...
feat(BackgroundJobs): Allow preventing parallel runs for a job class
2023-04-25 12:10:43 +07:00
Joas Schilling
af214b6c13
Merge pull request #36378 from nextcloud/fix/improve-taint-analysis
...
Add missing taint analysis docblock comments, and improve escaping in…
2023-04-25 08:51:54 +07:00
Nextcloud bot
e9aefb5251
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-25 02:22:46 +07:00
Carl Schwan
b1ec7ff51f
Add missing taint analysis docblock comments, and improve escaping in some methods
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-24 17:17:53 +07:00
Marcel Klehr
524d053eb2
JobList: add debug log when hasReservedJob query fails
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-24 17:16:32 +07:00
Robin Appelman
05dc96f60d
debug log requests made by dav external storage/shares
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-24 17:13:20 +07:00
Robin Appelman
4953296b9e
Merge pull request #36857 from nextcloud/scan-repair-unencrypted-size
...
fix unencrypted_size for folders when scanning the filesystem with encryption enabled
2023-04-24 15:24:50 +07:00
Joas Schilling
89c3c31402
feat(ratelimit): Add Attributes support to rate limit middleware
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-24 12:24:48 +07:00
Christoph Wurst
dcde970bd5
Merge pull request #37816 from nextcloud/fix/events/info-to-debug-log-legacy-events
...
fix(events): Log deprecated events as debug, not info
2023-04-24 11:14:41 +07:00
Marcel Klehr
d1e4a7a750
Update autoloaders
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 13:36:47 +07:00
Marcel Klehr
5a7f023bfc
JobList#hasReservedJobs: Close cursor
...
so Joas doesn't die
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr
5608b50778
Fix BackgroundJob tests
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr
94038e0673
IParallelAwareJob: Add missing boilerplate
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr
0f3211c4e4
Add IParallelAwareJob interface
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr
6f9a3218d0
Update lib/private/BackgroundJob/JobList.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr
1296f3612e
test(BackgroundJobs): Add tests for allowParallelRuns and hasReservedJobs
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr
ef27bd6e55
fix(SpeechToText): Prevent parallel runs of TranscriptionJob
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr
c01c516323
feat(BackgroundJobs): Allow preventing parallel runs for a job class
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Robin Appelman
0ac7230b7f
Merge pull request #37820 from nextcloud/parent-storage-mtime-ignore-error
...
ignore errors while trying to update parent storage_mtime
2023-04-21 19:11:27 +07:00
Arthur Schiwon
bb4b34ff69
Read mtime of version.php only once
...
- in most cases it would read again in \OC_Util::loadVersion anyway
- remove some unused use statements
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-04-21 14:10:47 +07:00
Arthur Schiwon
7519949f37
add the server roots and version info hash to apcu prefix
...
fixes collissions when more than one instance is running on the same
system
For the memcaches we use a more complex prefix, where version and
instance ID are incorporated. We do not have this data at hand at this
point of time. But we can get the mtime of the version.php file
relatively cheap.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-04-21 14:10:46 +07:00
Robin Appelman
1bff4e23bf
Merge pull request #37525 from nextcloud/file-debug-info
...
add command for getting fileinfo for debugging
2023-04-21 14:18:05 +07:00
Robin Appelman
4cc5885615
Merge pull request #37062 from nextcloud/free-space
...
Check free space only if source exists and is dir
2023-04-21 13:55:42 +07:00
Robin Appelman
ccab101df8
Merge pull request #37596 from nextcloud/enh/type-iconfig-getter-calls
...
Use typed version of IConfig::getSystemValue as much as possible
2023-04-21 13:48:12 +07:00
Robin Appelman
4b52dafbf9
ignore errors while trying to update parent storage_mtime
...
in the worst case this should only cause an extra rescan later
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-20 17:16:03 +07:00
Côme Chilliet
b294edad80
Merge branch 'master' into enh/type-iconfig-getter-calls
...
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-04-20 16:52:38 +07:00
Côme Chilliet
e91e7bc60f
Fix TypeError in Profiler
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-20 10:43:00 +07:00
Nextcloud bot
8799098d1f
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-20 02:29:13 +07:00
Joas Schilling
fd473f89e8
Merge pull request #37674 from nextcloud/feature/speech-to-text
...
feat(SpeechToText): Add SpeechToText OCP provider API
2023-04-19 16:29:44 +07:00
Joas Schilling
ab7b63db84
fix(autoloader): Rebuild
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-19 13:45:44 +07:00
Joas Schilling
db9901a02e
Fix(docs): Fix parameter type in doc block
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-19 12:42:23 +07:00
Marcel Klehr
fbcd275acb
Context params: Make userId nullable
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-19 12:39:39 +07:00
Marcel Klehr
a2f5421fc3
SpeechToTextManager#scheduleFileTranscription: Take context params and expose them on the Transcription*Events
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-19 12:35:13 +07:00
Christoph Wurst
ce71aa9acb
fix(events): Log deprecated events as debug, not info
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-04-19 11:56:10 +07:00
Marcel Klehr
a8b27c9126
TranscriptionJob: Add owner argument to simplify filesystem setup
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-19 11:26:04 +07:00
Nextcloud bot
9db33055b2
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-19 02:28:19 +07:00
Simon L
d6f51cf943
Merge pull request #37582 from Jerome-Herbinet/patch-16
...
To be consistent with the same field's title in the list of users
2023-04-18 23:48:18 +07:00
Christoph Wurst
2c0cfd3772
feat(app-framework): Add native argument types for middleware
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-04-18 17:15:05 +07:00
Marcel Klehr
eb996cbbb0
TranscriptionJob: Ensure filesystem is setup before trying to retrieve file
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-18 16:24:06 +07:00
Marcel Klehr
ce651e53b9
Run cs:fix
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-18 16:24:06 +07:00
Jérôme Herbinet
c343569b3f
To be consistent with the list of users
...
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
2023-04-18 15:47:26 +07:00
Marcel Klehr
9649f91892
Update lib/private/SpeechToText/SpeechToTextManager.php
...
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-18 15:24:14 +07:00
Simon L
8508865eaf
Merge pull request #37772 from nextcloud/enh/30986/follow-up
...
Prevent the OpenDocument preview generator from trying to open empty files
2023-04-18 12:18:14 +07:00
Simon L
8fe22ebf60
Merge pull request #36617 from nextcloud/update/psr-container
...
chore: Update PSR container to 2.0.2
2023-04-18 11:40:12 +07:00
Simon L
5f879a705b
Merge pull request #37316 from nextcloud/fix/security/strict-cookie-check-status-codes
...
fix(security)!: Use consistent HTTP status for strict cookie checks
2023-04-18 11:39:18 +07:00
Joas Schilling
bef4cf0ad1
Fix missing import
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-18 10:01:00 +07:00
Simon L
855e7a2efb
Merge pull request #36774 from nextcloud/bugfix/noid/sabre-nodes
...
fix: always use proper path on node api when calling the view
2023-04-18 04:11:44 +07:00
Simon L
45a0fe490c
Merge pull request #37534 from Rsplwe/master
...
Adjust the value of the "max-parts" parameter of the object storage 'ListPart' interface to 1000
2023-04-18 00:16:38 +07:00
Simon L
5952a027c3
Merge pull request #37324 from nextcloud/fix/mapper-exception
...
Allow to catch `IMapperException` by implementing `Throwable`
2023-04-18 00:10:44 +07:00
Simon L
0a763820bc
Merge pull request #37676 from nextcloud/fix/auth/atomic-password-db-statements
...
fix(auth): Run token bulk update statements in atomic transaction
2023-04-17 23:48:24 +07:00
Julius Härtl
160bd75d0a
fix: Use proper path when creating node instances
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-17 23:46:52 +07:00
Simon L
85c9e75f33
Merge pull request #32314 from nextcloud/object-mkdir-logging
...
additional logging when mkdir fails for object storage
2023-04-17 23:42:08 +07:00
Simon L
5cda8f0f45
Merge pull request #35129 from Glandos/previewperf2
...
[Performance] Reuse preview directory listing
2023-04-17 20:22:39 +07:00
Simon L
d87cc208bb
Merge pull request #31286 from rotdrop/bugfix/dont-start-session-when-session-is-already-open
...
Don't call session_start() when PHP session is still or already open.
2023-04-17 20:14:53 +07:00
Ferdinand Thiessen
dc9d8c42bb
fix: Adjust console formatter code to match with Symfony type hints
...
Symfony has added type hints on the `OutputFormatterInterface`,
so we must adjust our type hints to match with Symfony.
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-04-17 18:35:10 +07:00
Christoph Wurst
a06898a2d0
fix(security)!: Use consistent HTTP status for strict cookie checks
...
Before: 503/412
Now: 412 + json body explaining the error
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-04-17 16:06:37 +07:00
Ferdinand Thiessen
bdbff2181e
fix: Allow to catch `IMapperException` by implementing `Throwable`
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-04-17 16:05:10 +07:00
Simon L
800f40b71c
fix php-lint
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 17:18:09 +07:00
Marcel Klehr
3f57725a7c
SpeechToTextManager#transcribeFile: Try next provider if one fails
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-17 16:59:46 +07:00
Marcel Klehr
47cff5d651
Update lib/public/SpeechToText/ISpeechToTextManager.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-17 16:43:43 +07:00
Marcel Klehr
b082657252
Update lib/public/SpeechToText/ISpeechToTextManager.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-17 16:43:28 +07:00
Marcel Klehr
aac6a186c1
Update lib/public/SpeechToText/ISpeechToTextManager.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-17 16:43:19 +07:00
Glandos
e542e60dbc
try to make linters happy
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:14 +07:00
Glandos
3440387f0f
gather code from small and max preview
...
use directory listing in both functions to gain 25% speed on run where
every preview already exist.
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Glandos
24c121347a
Revert 0e49b40
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Glandos
06a7e90383
improve parameter doc
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Glandos
4954bead1d
Ensure max preview image is not null
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Glandos
b6c65fee2a
php-cs-fix
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Glandos
9b4d5146d5
List preview directory only once
...
getCachedPreview used to call `getFile`, and this calls `getDirectoryListing` (or underlying function that list directory) to find the file. This was done for every preview spec.
Now, this is done only once at the beginning of the loop, and the array is just iterated when needed to find the correct entry.
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Robin Appelman
60cf0c8f5f
add command for getting fileinfo for debugging
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-17 16:23:52 +07:00
Claus-Justus Heine
45ec432492
Don't call session_start() when PHP session is still or already open.
...
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
2023-04-17 16:23:02 +07:00
Claus-Justus Heine
456679c6fb
Update lib/private/Preview/Bundled.php
...
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2023-04-17 16:19:02 +07:00
Claus-Justus Heine
b3d8363327
Prevent the OpenDocument preview generator from trying to open empty files.
...
Rationale: does not make sense, and triggers a deprecation error in
\ZipArchive.
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
2023-04-17 16:19:02 +07:00
Marcel Klehr
6e9f260348
Update lib/private/SpeechToText/SpeechToTextManager.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-17 15:49:50 +07:00
Thomas Citharel
036cd47bf4
Put Mimeloader insertion and read in the same transaction
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-04-17 13:32:02 +07:00
Marcel Klehr
3779cc3d88
SpeechToTextManager: Deduplicate transcription jobs
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-17 14:57:19 +07:00
Marcel Klehr
ad1a0d88ef
Transcription*Event: Add doc block
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-17 14:57:19 +07:00
Marcel Klehr
71523b9816
AbstractTranscriptionEvent: Add File param
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-17 14:57:19 +07:00
Varun Patil
39e805fffa
redis: use atomic operations everywhere
...
This removes a lot of acrobatics in the code and does each operation
atomically using a lua script. This also reduces several round trips
to the server, and the scripts are compiled and cached server-side.
Notably, since all operations work only on a single key (except clear,
which is broken anyway and shouldn't be used), they will continue to
function and be atomic for Redis cluster.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-04-16 14:38:56 +07:00
Nextcloud bot
6746a7aebc
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-15 02:27:32 +07:00
Julius Härtl
eecd4601ac
Merge pull request #37429 from nextcloud/object-store-rmdir
...
improve objectstore rmdir handling
2023-04-13 18:45:12 +07:00
Marcel Klehr
ad66180c34
Update lib/private/SpeechToText/SpeechToTextManager.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-13 15:17:17 +07:00
Marcel Klehr
865ebfaf72
Add missing strict_types + author + copyright
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-13 12:15:18 +07:00
Marcel Klehr
a8d3fff648
Split TranscriptionFinishedEvent into Successful and Failed events
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-13 12:12:07 +07:00
Marcel Klehr
176f1af26a
ISpeechToTextManager: Take File as input, drop $context
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-13 11:57:23 +07:00
Nextcloud bot
b1abc57c07
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-13 02:27:50 +07:00
Marcel Klehr
ef7ce88cee
ISpeechToTextProvider#transcribeFile: Pass \OCP\Files\File instead of path
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-12 16:52:11 +07:00
Christoph Wurst
5eb768ac5e
fix(auth): Run token statements in atomic transaction
...
All or nothing
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-04-12 15:55:42 +07:00
Maxence Lange
fc29b0d1b7
app type extended_authentication
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-04-12 09:34:49 +07:00
Arthur Schiwon
ec1acb92c7
Merge pull request #37617 from nextcloud/notify-self-test-error
...
handle not being able to write file for notify self-test
2023-04-11 19:43:41 +07:00
Marcel Klehr
1833d932ef
chore(coding style): Run cs:fix
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-11 15:21:08 +07:00
Marcel Klehr
a9b5d1f9da
chore(coding style): Run cs:fix
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-11 15:04:30 +07:00
Marcel Klehr
f2eb2241bb
feat(SpeechToText): Add autoload changes
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-11 15:01:11 +07:00
Marcel Klehr
317521b607
feat(SpeechToText): Add SpeechToText provider API
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-11 14:59:57 +07:00
Nextcloud bot
a19589d5c2
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-09 02:27:38 +07:00
jld3103
b153340b62
Add type hints for mappers
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-07 09:49:42 +07:00
Jan Messer
647c65a640
[BUGFIX] throw exception instead of error if unable to create file handler (only exceptions are catch)
...
Signed-off-by: Jan Messer <jan@mtec-studios.ch>
2023-04-06 23:03:49 +07:00
Jan Messer
7a443863fe
[BUGFIX] check return value and improve error handling
...
With S3 primary storage there was a problem with getting the CA bundle from the storage without having the CA bundle for the connection which causes that the CertificateManager was throwing an Error.
This commit improves the handling in CertificateManager and log unexpected behaviors.
Signed-off-by: Jan Messer <jan@mtec-studios.ch>
2023-04-06 23:03:33 +07:00
Vincent Petry
9f05eff3ef
Merge pull request #34607 from nextcloud/encryption-size-not-found
...
fix encryption wrapper filesize for non existing files
2023-04-06 18:04:44 +07:00
Robin Appelman
570b64aafc
handle not being able to write file for notify self-test
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-06 11:52:22 +07:00
Robin Appelman
03e965a513
Merge pull request #22943 from nextcloud/scanner-no-access-handling
...
improve handling of files we can't access in the scanner
2023-04-05 21:36:21 +07:00
Côme Chilliet
e63a6f5cdb
Merge pull request #27538 from nextcloud/scanner-home-not-writable-better-errors
...
better error messages if the users home is not writable during scanning
2023-04-05 17:53:42 +07:00
Côme Chilliet
8d5165e8dc
Adapt tests to config value typing
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 17:42:14 +07:00
Robin Appelman
63fc83de26
Merge pull request #33292 from nextcloud/no-profiler
...
don't hard error when trying to load profiles with no profiler registered
2023-04-05 15:57:50 +07:00
Robin Appelman
c6be96d04f
additional logging when mkdir fails for object storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-05 14:52:19 +07:00
Robin Appelman
b1f352c614
improve handling of files we can't access in the scanner
...
instead of erroring, remove the items from the cache.
this situation can be triggered if a user has access to a file but looses it afterwards
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-05 14:44:55 +07:00
Robin Appelman
54f61352f0
better error messages if the users home is not writable during scanning
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-05 13:21:30 +07:00
Côme Chilliet
426c0341ff
Use typed version of IConfig::getSystemValue as much as possible
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 12:50:08 +07:00
Côme Chilliet
8f550398c4
Merge pull request #36836 from nextcloud/fix/view-type-cleanup
...
Tidy up typing in OC\Files\View
2023-04-05 10:14:55 +07:00
Côme Chilliet
6633b4ced6
Remove unecessary fully qualified namespaces from phpdoc
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 09:13:39 +07:00
jld3103
d9f8522003
Fix types for reading and writing config values
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +07:00
Nextcloud bot
746a1e9922
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-04-05 02:30:26 +07:00
Robin Appelman
43b61d26e8
don't hard error when trying to load profiles with no profiler registered
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-04 17:24:29 +07:00
Robin Appelman
9d3c8b7e70
Merge pull request #36360 from nextcloud/new-share-existing-node
...
also set the node when re-using existing share on share create
2023-04-04 17:11:24 +07:00
Joas Schilling
9cae15d1ad
Merge pull request #37278 from nextcloud/feature/document-talk-icon-url-definition
...
Document talk icon url definition
2023-04-04 17:08:28 +07:00
Robin Appelman
5267a74027
fix type hints
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-04 17:05:45 +07:00
Robin Appelman
8c9197d65e
fix unencrypted folder size when no children with unencrypted size set are left
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-04 16:48:11 +07:00
Robin Appelman
649bed5154
fix unencrypted_size for files when scanning
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-04 16:48:11 +07:00
Robin Appelman
63fb33538c
fix unencrypted_size for folders when scanning the filesystem with encryption enabled
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-04 16:48:10 +07:00
Robin Appelman
15a6920b07
fix encryption wrapper filesize for non existing files
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-04 16:21:17 +07:00
Robin Appelman
565ee0dc81
Merge pull request #37559 from nextcloud/preview-generate-cmd
...
add command to generate a preview for a file
2023-04-04 16:06:45 +07:00
Joas Schilling
131f481a67
fix(initial-state): Log an error when initial-state can not be JSON encoded
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-04 10:54:12 +07:00
Côme Chilliet
7fdb23928f
Merge pull request #37243 from nextcloud/enh/openssl-get-rid-of-rc4
...
Getting rid of openssl_seal and rc4 in server side encryption
2023-04-04 10:38:02 +07:00
Louis
7ab44b2d28
Merge pull request #37146 from nextcloud/artonge/feat/migrate_metadata_to_value
...
Migrate metadata JSON column to new value TEXT column
2023-04-04 10:23:54 +07:00
Robin Appelman
d63fa2d991
improve objectstore rmdir handling
...
remove folder entries as they are cleared instead of in one go afterwards
otherwise they stick around if some of the child entries can't be removed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-03 18:28:29 +07:00
Robin Appelman
013eedabbd
add command to generate a preview for a file
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-03 17:30:57 +07:00
Robin Appelman
3473fa3187
also set the node when re-using existing share on share create
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-03 16:40:47 +07:00
Robin Appelman
5024f295dc
Merge pull request #36097 from nextcloud/path-prefix-optimize
...
extend path-prefix optimizer to remove all cases of path_hash= when encountering a path prefix filter
2023-04-03 16:39:49 +07:00
Rsplwe
5c6f35832c
Update lib/private/Files/ObjectStore/S3.php
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Rsplwe <i@rsplwe.com>
2023-04-03 21:59:59 +07:00
Côme Chilliet
dbc0d6a1c2
Merge pull request #37543 from nextcloud/fix/inherited-parameter-names
...
Fix inherited parameter names
2023-04-03 15:08:45 +07:00
Joas Schilling
c5339fa336
Merge pull request #37542 from nextcloud/bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing
...
feat(security): Allow to opt-out of ratelimit protection, e.g. for te…
2023-04-03 14:19:41 +07:00
Louis Chemineau
1a6709cf43
Migrate metadata as JSON to value as STRING
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-03 14:06:28 +07:00
Arthur Schiwon
84c76a89ec
Merge pull request #37520 from nextcloud/fix/noid/fix-dbal-exception-handling
...
fix DBAL exception handling in setValues
2023-04-03 11:30:14 +07:00
Côme Chilliet
5ad045619c
View needs to return an instance of OC\Files\FileInfo explicitely
...
Applications are calling methods from the class which are not from the
public interface, and which cannot be added easily to public interface
because Node interface extends FileInfo.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:35 +07:00
Côme Chilliet
0b3dad895f
More type cleanup in View and FileInfo
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:35 +07:00
Côme Chilliet
ea05544213
Fix return type of methods returning false on error
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:34 +07:00
Côme Chilliet
f974281ac9
Improve typing for fopen/toTmpFile
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:34 +07:00
Côme Chilliet
4393b96542
Remove unused method getLocalFolder
...
It’s not used and not in any OCP interface/class.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:34 +07:00
Côme Chilliet
966a3e6963
Tidy up typing in OC\Files\View
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:33 +07:00
Julius Härtl
671d2726fa
Merge pull request #36652 from nextcloud/perf/autoloading/theming-authoritative-autoloader
...
perf(autoloading): Add authoritative autoloader for theming
2023-04-03 10:38:00 +07:00