Commit Graph

3582 Commits (f6ac874dbf7d4e5cb2255f25464df214bb956ffb)

Author SHA1 Message Date
Carl Schwan 77355a8a79
Improve typing in ICommentsManager
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-06-20 10:55:26 +07:00
Carl Schwan 9725d00329
Cleanup comments code
- Fix various psalm issues
- Add as much typing as possible while preserving stable API

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-06-20 10:55:20 +07:00
Robin Appelman 53443e836f
fix type in BeforeMessageLoggedEvent
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-06-15 17:29:11 +07:00
Robin Appelman d9fa7b1e28
emit an event when a message is logged
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-06-13 18:45:48 +07:00
Christoph Wurst 08a3f37695
chore(appframework)!: Drop \OCP\AppFramework\Http\EmptyContentSecurityPolicy::allowInlineScript
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-12 10:03:59 +07:00
Git'Fellow 5b5895a130 Drop meta robots tag
Revert mistake

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-06-09 18:06:37 +07:00
Faraz Samapoor bf38c0a3d1 Refactors "strpos" calls in lib/public to improve code readability.
Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>
2023-06-05 11:14:52 +07:00
Daniel Kesselberg a2afc7b6a9
refactor: migrate OC_EventSource to dependency injection
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-03 21:42:51 +07:00
Daniel Kesselberg 3d3c49774f
chore: remove check for suhosin.executor.func.blacklist
Suhosin is/was a PHP extension.
The last release was 2015-05-21.
Suhosin does not support PHP 8.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-02 15:47:26 +07:00
Christoph Wurst 09c5f997c6
Merge pull request #38593 from nextcloud/chore/ocp/drop-util-linktopublic
chore(ocp)!: Drop \OCP\Util::linkToPublic
2023-06-02 10:23:37 +07:00
Christoph Wurst c0263b91d4
Merge pull request #38585 from nextcloud/feature/ocp/send-message-with-subject-body
feat(ocp): Allow sending emails with subject and body
2023-06-02 09:14:46 +07:00
Christoph Wurst f04ff2c6d7
chore(ocp)!: Drop \OCP\Util::linkToPublic
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 20:32:59 +07:00
Christoph Wurst 0f534936b3
fix(ocp): Mark IMessage::attachInline as @since 27
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 18:15:19 +07:00
Christoph Wurst 7f8f792558
feat(ocp): Allow sending emails with subject and body
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 18:10:05 +07:00
Joas Schilling 5b2d5767e1
fix(docs): Fix language and copy-paste class name in docs of CSP
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-30 13:39:33 +07:00
Julius Härtl 050c6d53b3
enh: Provide atomicRetry method to retry transactions if possible
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-05-16 08:13:20 +07:00
Robin Appelman 1f4dd62b4e
Merge pull request #36592 from nextcloud/groupmanager-search-typing
fix default values and type hints for GroupManager::search
2023-05-12 15:25:32 +07:00
Christoph Wurst 1381c4c157
feat(users): Store and load a user's manager
Co-Authored-By: hamza221 <hamzamahjoubi221@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-12 13:56:48 +07:00
Robin Appelman 13b06ba4e2
revert public interface back to the original types, just cast them before passing the nulls to the backends
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-11 17:30:03 +07:00
Robin Appelman 7ad3574d71
also update groupinterface and database backend
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-11 17:30:03 +07:00
Robin Appelman e4b9ecd8f2
fix default values and type hints for GroupManager::search
ints really are ints

Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-11 17:30:01 +07:00
John Molakvoæ 979f4033ca
Merge pull request #33381 from luzpaz/fix/lib-public-typos 2023-05-11 10:26:50 +07:00
Anna 9e53934498
Merge pull request #36118 from nextcloud/fix/caldav/invitation-outlook-compatibilty
Fix calendar emails to be outlook compatible
2023-05-10 12:10:42 +07:00
Simon L d55a7c619d Fix typos in lib/public subdirectory
Found via `codespell -q 3 -S l10n -L jus ./lib/public`

Signed-off-by: luz paz <luzpaz@github.com>

Update lib/public/Accounts/IAccount.php

Signed-off-by: luz paz <luzpaz@github.com>

Signed-off-by: Simon L <szaimen@e.mail.de>
Co-Authored-By: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-05-10 11:56:34 +07:00
Pytal 972b2097d0
Merge pull request #38104 from nextcloud/feat/um-32-bit 2023-05-09 08:20:41 +07:00
Christopher Ng 4e51f5224c feat(UserMigration)!: 32-bit support
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-05-05 17:59:57 +07:00
Marcel Müller 484f7a6641 Add messageId to richObject definition of Talk
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2023-05-05 17:51:53 +07:00
Daniel db73534e09
Merge pull request #38016 from nextcloud/oracle-limit-workaround
fix: add workaround for oci and limit queries
2023-05-03 23:06:59 +07:00
Joas Schilling 9ace8e561d
Merge pull request #38003 from nextcloud/bugfix/noid/improve-translations-api
Improve translations api with detecting languages
2023-05-03 11:07:30 +07:00
Arthur Schiwon 997efe44ff
Merge pull request #37943 from nextcloud/fix/fix-getcontent-return-type
Fix file_get_content signatures to make it clear it can return false
2023-05-03 10:34:51 +07:00
Côme Chilliet f7632f2fc4
Merge pull request #32866 from nextcloud/performance/searchInGroup-displayname-cache
Optimize retrieving display name when searching for users in a group
2023-05-02 16:42:09 +07:00
Joas Schilling 9d6ec68b59
feat(translation): Return the detected language so clients can show more details
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-02 16:38:33 +07:00
Daniel Kesselberg eecdb62e92
fix: add workaround for oci and limit queries
DBAL uses a helper column "doctrine_rownum" for top-n queries

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-05-02 14:26:28 +07:00
John Molakvoæ 20df0019f1
fix(psalm): systemtags
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-04-28 12:23:52 +07:00
Julius Härtl a6fe9130b9
fix: Empty fallback for template creator action label
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-27 15:52:08 +07:00
Côme Chilliet 346344c153
Update version number in since and deprecated annotations
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:04:32 +07:00
Côme Chilliet b6c17c6ce7
Clear up return types
usersInGroup index by int for BC, searchInGroup index by uid (string).

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:00:45 +07:00
Côme Chilliet 6385a5af36
Let OC\Group\Group handle the fallback and remove default implementation from ABackend
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:00:43 +07:00
Carl Schwan a4c599c1c9
Split new method in a new group backend interface
Better for backward compatibility, also move new interfaces to nc 26

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-04-27 12:00:01 +07:00
Carl Schwan 35dc223500
Optimize retrieving display name when searching for users in a group
This is recurrent scenario that we are searching for users and then for
each users we fetch the displayName. This is inefficient, so instead try
to do one query to fetch everything (e.g. Database backend) or use the
already existing DisplayNameCache helper.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-04-27 11:57:45 +07:00
Côme Chilliet 546d94c3ec
Fix file_get_content signatures to make it clear it can return false
In File::getContent, which must return a string, throw an Exception
 instead of returning false.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 09:56:05 +07:00
Christopher Ng 966bc06e8d Create new file/folder labels
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-04-27 03:20:12 +07:00
Christoph Wurst ea67129b64
Merge pull request #37480 from nextcloud/fix/ocp/ilogfactor-getcustomlogger-deprecation-version
fix(ocp): Add deprecation version to ILogFactory::getCustomLogger
2023-04-26 11:58:40 +07:00
Joas Schilling 75f17b6094
Merge pull request #37905 from nextcloud/techdebt/noid/add-attributes-for-remaining-security-annotations
feat(security): Add PHP \Attribute for remaining security annotations
2023-04-25 17:13:53 +07:00
Joas Schilling ecb8b55c5c
feat(security): Add PHP \Attribute for remaining security annotations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-25 14:50:32 +07:00
Côme Chilliet 7250f54ca3
Merge pull request #37835 from nextcloud/feat/background-allow-parallel-runs
feat(BackgroundJobs): Allow preventing parallel runs for a job class
2023-04-25 12:10:43 +07:00
Joas Schilling 89c3c31402
feat(ratelimit): Add Attributes support to rate limit middleware
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-24 12:24:48 +07:00
Marcel Klehr 5608b50778 Fix BackgroundJob tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr 94038e0673 IParallelAwareJob: Add missing boilerplate
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr 0f3211c4e4 Add IParallelAwareJob interface
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00