Commit Graph

14868 Commits (f06fdb04a30d72a3c0eb317a031f6f3c19f812d5)

Author SHA1 Message Date
Anupam Kumar bb94b17959 fix(TaskProcessing): increase error_message column length
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-09-06 18:01:56 +07:00
Git'Fellow a36738dbfc chore(storage): refactor some code portions
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

chore: revert portion

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-06 12:44:48 +07:00
Ferdinand Thiessen ba73beaac1
Merge pull request #47784 from nextcloud/fix/file-info
fix(FileInfo): correctly implement `\ArrayAccess::offsetGet`
2024-09-06 12:18:30 +07:00
Ferdinand Thiessen a96406086c fix(FileInfo): correctly implement `\ArrayAccess::offsetGet`
We are targetting PHP 8.1+, since PHP 8.0 `offsetGet` has the `mixed` types for `offset` and return value.
So this adds the types to correctly implement the interface.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:58:00 +07:00
Git'Fellow 0308001118 fix(files): Check if the target path is a descendant of the shared folder path
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: add tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests
2024-09-05 23:54:01 +07:00
Anna Larch 8af7ecb257 chore: adjust code to adhere to coding standard
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:23:38 +07:00
Louis Chemineau 843a47f12c
fix: Use sha256 to hash arguments of background jobs
This is to prevent collision as we are sometime hashing user input, yet using that hash to target the background job in the database.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-05 15:36:51 +07:00
Marcel Müller b2c2c93a03 fix(appstore): Cache apps.json also on dev instances
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-09-04 21:56:58 +07:00
Kate 09fef8f0ec
Merge pull request #47417 from nextcloud/fix/files/create-mountpoint-parents 2024-09-04 20:00:24 +07:00
John Molakvoæ 99b225f06b
Merge pull request #40164 from nextcloud/exceptionsTranslateShare 2024-09-04 09:50:49 +07:00
John Molakvoæ 8f825cbd16
Merge pull request #47155 from nextcloud/executeStatementOnDelete 2024-09-04 09:35:16 +07:00
Julius Härtl 3ca7480829 fix: Do not throw if appstore is unavailable during upgrade
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-09-04 09:31:13 +07:00
John Molakvoæ 7efd244956
Merge pull request #47675 from nextcloud/adapterQueryOpti 2024-09-04 09:15:52 +07:00
John Molakvoæ f4aa2644ee fix: adjust sharing controller exceptions case
Co-authored-by: F. E Noel Nfebe <fenn25.fn@gmail.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-09-04 09:03:45 +07:00
Git'Fellow f250643e7a fix(l10n): Translate all share exceptions
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Fix drone

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-04 09:03:45 +07:00
Stefan Cherniakov 457eaee2b3 fix(files_sharing): Add missing check for null & use bool instead of int for reminder_sent field
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
2024-09-03 17:23:31 +07:00
Stefan Cherniakov d633b9bce6 fix(files_sharing): Make share reminders more stable & fix issues
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
2024-09-03 13:37:17 +07:00
Stefan Cherniakov 5e4a166365 feat(files_sharing): reminder for link shares with expiration date
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
2024-09-03 13:37:17 +07:00
John Molakvoæ b7bd5b0012
Merge pull request #47650 from nextcloud/chore/cleanup-middleware 2024-09-03 09:21:43 +07:00
Kate 02a6f12bf9
Merge pull request #47676 from nextcloud/fix/ocp/image-interface 2024-09-02 16:11:26 +07:00
provokateurin 031166c177
fix(OCP): Fix Image interface
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-02 14:57:17 +07:00
Ferdinand Thiessen bdce5921f6
chore(IConfig): `getUsersForUserValue` is returning a list
It is returning a list of strings so adjust the return typing
to reflect this (`list<string>` instead of `array`).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-02 12:27:06 +07:00
Julius Härtl 7f0d0cf03c
Merge pull request #47640 from nextcloud/fix/migrator-replica
fix: Run migration sql as statement so that the primary db node is used
2024-09-02 10:46:24 +07:00
Git'Fellow 8e6e7976d2
fix: psalm
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-02 10:19:25 +07:00
Git'Fellow 388f2973b9
fix: psalm
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-02 10:08:08 +07:00
Git'Fellow dfcf3132dd
chore(db): Make the query more simpler to read
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-02 09:57:48 +07:00
Ferdinand Thiessen deeccd12a3
chore: fix typo in `SameSiteCookieMiddleware`
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-31 00:34:45 +07:00
Ferdinand Thiessen 92f3f7e2d2
chore: Remove unused `CsrfTokenManager` from `CSPMiddleware`
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-31 00:34:41 +07:00
Julius Härtl c3fa25a16e
fix: Run migration sql as statement so that the primary db node is used
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-30 15:45:50 +07:00
Marcel Klehr 95006d2b8e
Revert "fix(TaskProcessing): Use OCP\Server::get instead of copying methods"
This reverts commit d624c8da8f.

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
Marcel Klehr 1e896a7307
fix(TextProcessing): Don't run taskProcessing if task type is not available
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
Marcel Klehr de117d4654
fix(SpeechToTextManager): Throw TaskProcessing Task failed
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
Marcel Klehr 7be3a18f13
fix(TaskProcessing): Use OCP\Server::get instead of copying methods
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
Julien Veyssier 04edeb510d
feat(speech-to-text): SpeechToTextManager::transcribeFile calls TaskProcessingManager::runTask
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
Julien Veyssier 5ab0866341
feat(textprocessing): TextProcessingManager::runTask calls TaskProcessingManager::runTask
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
Andy Scherzinger bfb5835750
Merge pull request #47546 from nextcloud/fix/files-view-error-messages
fix: Adjust filename validation messages
2024-08-29 23:28:50 +07:00
Arthur Schiwon edaa4d1432
fix(DB): do not assume sharding is always enabled
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-08-29 19:55:10 +07:00
Arthur Schiwon 381e922085
fix(DB): set sharding parameters only when intended
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-08-29 19:12:44 +07:00
Côme Chilliet 1f46be7d69 fix(Image): Do not send empty Content-Type header
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
Côme Chilliet b778f3de0a fix(\OC\Image): Use new IAppConfig and type safe methods
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
Côme Chilliet c67e54287a fix(OC\Image): Fix all psalm spotted issues in the file
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
Côme Chilliet e8c671fa8b fix: Remove all references to OC_Image
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
Côme Chilliet 47d2cb7479 fix: Move \OC_Image to \OC\Image with the other internal classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
Julius Härtl 6d04ad829b
Merge pull request #47581 from nextcloud/fix/audit-new-node
fix: Do not fail to get internal path on NonExistingFile
2024-08-29 15:43:21 +07:00
Josh fef4295ef7
Merge pull request #47567 from nextcloud/jtr/fix-opcache-restricted-env
fix(config): Avoid error messages for restricted opcache API
2024-08-29 08:46:41 +07:00
Julius Härtl 61108882b9
fix: Do not fail to get internal path on NonExistingFile/NonExistingFolder
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-29 12:43:44 +07:00
Andy Scherzinger d404998157
Merge pull request #47515 from nextcloud/bugfix/noid/fix-migration-sorting
fix(migration): Correctly sort migrations by version number
2024-08-28 20:46:24 +07:00
Ferdinand Thiessen 17f011f7c5 fix: Also validate parent path in `verifyPath`
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +07:00
Ferdinand Thiessen 08836696e2 fix: Allow read-only filename validation to allow reading files
Needed to read files with the "Windows compatibility" feature.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +07:00
Ferdinand Thiessen 030c209d22 fix: Renaming does not need update but delete permissions
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +07:00