37d4bdce00
fix(files): do not even try to fetch a preview if èhas-preview` is false
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-14 14:22:01 +07:00
a01e85799c
Merge pull request #52802 from nextcloud/chore/oc-helper-can-exec
...
chore: deprecate \OC_Helper::canExecute
2025-05-14 12:45:25 +07:00
a53e15c971
fix: log requests exceeding the rate limiting
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-14 12:23:40 +07:00
7304756e03
test: Sort the reactions before comparing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-14 11:42:52 +07:00
1950076ca1
Merge pull request #52378 from nextcloud/transfer-external-storage
...
feat: add option to include external storage when transfering files
2025-05-14 11:10:32 +07:00
498c57f648
Merge pull request #52046 from nextcloud/bug/49834/calendar-unsharing
...
Introduce own method for calendar unsharing
2025-05-14 10:59:59 +07:00
3aae7ae305
Merge pull request #52792 from nextcloud/fix/mime-fallback-public
2025-05-14 10:51:40 +07:00
df94cceb7b
fix(db): Store last insert id before reconnect
...
During a reconnect we are losing the connection and when the
realLastInsertId call is the one triggering the reconnect, it
does not return the ID. But inside the reconnect, we were able
to save the last insert id, so calling it a second time is going
to be successful.
We can not return the result on the initial call, as we are already
way deeper in the stack performing the actual database query on
the doctrine driver.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-14 10:27:00 +07:00
b67a43764a
Merge pull request #52694 from nextcloud/fixHardcodedVersionsFolder
...
fix(files_versions): Folder should not be hardcoded
2025-05-14 10:18:07 +07:00
1ae3fa4003
chore: replace leagcy OC_Helper calls with OCP\Util
...
- Replace legacy calls with OCP\Util
- Add missing deprecation notices
- Inline implementation in OCP\Util and call it from OC_Helper
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-14 10:18:04 +07:00
0f03a892b9
Merge pull request #52782 from nextcloud/feat/log-client-side-req-id
2025-05-14 10:07:36 +07:00
85a6b0d0eb
chore: deprecate \OC_Helper::canExecute
...
replace this legacy method with just the IBinaryFinder
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-14 09:55:14 +07:00
023b98c44b
fix(dav): only consider user's principal for unsharing entries
...
Before: Find all entries in `dav_shares` with `access = 5` for the user's principal, as well as group and circle memberships.
After: Find all entries in `dav_shares` with `access = 5` solely for the user's principal.
Future support for unsharing group or circle principals could be considered as a feature enhancement.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-14 09:03:33 +07:00
c05d3fdb2e
fix(caldav): prevent unshare entry creation for owner unsharing
...
- Introduces a `unshare` method in `CalDavBackend` to handle user unshares.
- Implements check to determine if unshare entry is needed based on group/circle membership.
- Ensures `updateShares` is only used when the calendar owner manages shares.
- Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`.
Related PRs:
- https://github.com/nextcloud/server/pull/43117
- https://github.com/nextcloud/server/pull/47737
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-14 09:03:32 +07:00
a338772ddd
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-05-14 00:22:28 +07:00
2b4bfcc212
fix(log): Only log client request id if present, and at the end
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-14 00:35:21 +07:00
4c25654574
feat(log): Log the request id sent with the request
...
This should help matching client logs with server logs, hopefully.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-14 00:35:21 +07:00
43418eea5f
fix(tests): Set encryption configuration even earlier so that all users are created with private key
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
a86d917907
fix(encryption): Only prevent cache deletion if target is not object store in moveFromStorage
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
a79b5dea7c
fix(encryption): Improve Update class and event listenening
...
to avoid back&forth between path and Node object
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
2d8f6b366a
chore: Assert rename success in versionning tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
e6275f8759
fix: Preserve file id when moving from object store even if encryption wrapper is present
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
27599ef45d
fix(encryption): Fix a PHP error in Encryption Util in specific situations
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
08bff4cf4a
fix(admin_audit): Survive if file change id after rename (it should not)
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
367c877b7a
fix(tests): Avoid user login before a private key is setup
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
f6f83430a9
chore: Update psalm baseline to remove fixed issue
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
561b590c77
chore(trashbin): Fix configuration mocking in trashbin tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
14872c8040
chore(files_versions): Only mock getSystemValue method to avoid problems in files_versions tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
e35a8ed063
fix(tests): Disable encryption wrapper when it makes sense
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
9bb0721d66
fix: Fix mtime preservation when moving a directory across storages with encryption registered
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
8779ae38a4
fix(encryption): Fix filesize for part files in Encryption wrapper
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
21233b7e17
fix(tests): Remove Encryption disabling in ViewTest to avoid side effects
...
Adapt tests a bit to make them pass with Encryption wrapper registered
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
38f341c179
fix(tests): Unregister encryption modules in ViewTest to avoid side effects
...
It was clearing the hooks with the same results before
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
536ccf144c
feat(encryption): Migrate from hooks to events
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 23:37:52 +07:00
fb615ef9f8
Merge pull request #52688 from nextcloud/feat/ocp-sanitize-filenames
...
feat(FilenameValidator): allow to sanitize filenames
2025-05-13 23:35:43 +07:00
866063c198
fix: annotate possible exceptions
...
File.getContent can throw a GenericFileException since https://github.com/nextcloud/server/pull/37943 .
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-13 22:27:19 +07:00
8c68f1eeb7
Merge pull request #52778 from nextcloud/fix/noid-check-for-properties-before-processing
...
fix: check if properties exist before using them
2025-05-13 18:58:16 +07:00
1e72620169
fix: fix unjailedroot of nested jails if there are other wrappers in between
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-13 18:29:00 +07:00
0001c22668
test: add test for nested cache jail unjailedroot
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-13 18:29:00 +07:00
cd6a53ea4d
fix(files_sharing): add mime fallback to public preview too
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-13 18:28:54 +07:00
b9da9416be
Merge pull request #52785 from nextcloud/feat/file-drop-recursive
2025-05-13 18:27:19 +07:00
20c6d1a7e9
feat: Improve init a bit, and add more profiling steps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 16:08:49 +07:00
b286bca485
fix(dav): remove unnecessary plugin getHTTPMethods
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-13 16:03:20 +07:00
4495794a0b
feat(dav): allow uploading folders to public shares
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-13 16:03:20 +07:00
6cf1870322
feat(FilenameValidator): allow to sanitize filenames
...
Share the filename sanitizing with the OCP filename validator.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-13 14:14:17 +07:00
56897b6f3c
Merge pull request #52681 from nextcloud/occ-external-dependencies
...
feat: add command to check files_external dependencies
2025-05-13 11:13:24 +07:00
76696be762
chore: remove legacy migration step to remove background job
...
This is already included since Nextcloud 29, so the background job is
removed and the class does not exist anymore.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-13 10:04:35 +07:00
9255afaeab
refactor(updatenotification): use consistant patterns for on-demand class members
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-13 10:04:35 +07:00
be3cf85656
refactor(updatenotification): use constant instead of variable
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-13 10:04:35 +07:00
6e9b4eb0a8
refactor(updatenotification): add return types and fix typos
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-13 10:04:35 +07:00
John Molakvoæ (skjnldsv)
Ferdinand Thiessen
Daniel Kesselberg
Joas Schilling
Robin Appelman
John Molakvoæ
Kate
Nextcloud bot
Côme Chilliet
Côme Chilliet
Christoph Wurst