Commit Graph

39 Commits (e391e5044619ad668aa702bc2c10a810b25a363a)

Author SHA1 Message Date
Ferdinand Thiessen 591601d000
fix(theming): previews need the same file extension as their originals
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-21 19:22:45 +07:00
Ferdinand Thiessen 4dac813901
fix(theming): Ensure to only send valid URLs to backend
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-27 14:20:15 +07:00
Ferdinand Thiessen 182acb1e29
fix(template): Use `<div>` instead of `<main>` to support Vue3 apps mounting
Vue3 does not replace the element while mounting but only renders within
(replace inner HTML).
So it would result in two stacked `<main>` elements which is invalid and
an accessibility issue.
Instead we just use a `<div>` element for mounting.

For Vue2 apps this does not change anything as the whole element will be
replaced with a new `<main>` element.
For vanilla apps this will slightly decrease the accessibility as the
main landmark is now missing, but this is not a hard accessibility issue
as it would be for Vue3 apps having two main elements.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-14 09:18:43 +07:00
Louis Chemineau ebda7b45f6
chore: Update @nextcloud/cypress to v1.0.0-beta.11
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-11-25 16:22:09 +07:00
Ferdinand Thiessen d5dc6b2476
feat(theming): Allow shipped backgrounds to have a dark variant
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-12 13:00:07 +07:00
Ferdinand Thiessen 12e1c29245
test: Adjust cypress tests to use reusable POM for header navigation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-10 01:35:25 +07:00
Andy Scherzinger 5c49a54801
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-26 20:05:04 +07:00
Ferdinand Thiessen 538a04968a
fix(tests): Adjust theming test for new splitted background and primary colors
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-21 20:36:26 +07:00
skjnldsv 16b818bd1e fix(cypress): more stable navigation-bar-settings cypress tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-02-22 18:36:24 +07:00
Ferdinand Thiessen d247e237b6
fix(cypress): Adjust cypress tests for changed theming
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-06 21:25:55 +07:00
Joas Schilling ee4a7ca2ba
fix(tests): Fix flyke cypress test
This is a "Ctrl+D" instead of "Ctrl+S" fail from b2d999fd68

Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-05 16:41:40 +07:00
Ferdinand Thiessen 5d61b806d6
fix(cypress): Wait for color change in `pickRandomColor`
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-25 16:04:32 +07:00
Grigorii K. Shartsev 6df488df21 test(theming): update e2e tests after separating color button and preview
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-01-24 14:35:31 +07:00
Grigorii K. Shartsev 1112b9e9a5 fix(theming): change color button contrast on user settings
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-01-24 14:35:31 +07:00
Christopher Ng 4f5f9ae98b test(theming): Fix navigation bar tests
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-01-23 11:38:40 +07:00
Ferdinand Thiessen da346aa80e
fix(theming): Adjust dark theme to be accessible adjust cypress tests
Also fix warning text color for bright / default theme on blurry background

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-01 00:58:30 +07:00
Ferdinand Thiessen d58b41301a
fix(cypress): Adjust cypress tests that relied on version to be 28
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-24 00:57:55 +07:00
Ferdinand Thiessen 4303895565 fix(cypress): Adjust admin theming tests for new `@nextcloud/vue` release
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-14 20:01:32 +07:00
Ferdinand Thiessen b2d999fd68
fix(cypress): Do not install calendar app from app store for testing but use locally provided test app
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-12 01:13:21 +07:00
Ferdinand Thiessen 0219bfa6b5 fix(tests): Make app order Cypress tests more robust
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-31 21:56:13 +07:00
Ferdinand Thiessen 3378a73e99
fix(theming): Make changes on primary color less invasiv
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-27 12:56:23 +07:00
Ferdinand Thiessen 3676295f7b
fix(theming): Ensure all text colors have enough contrast for accessibility
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-27 12:56:23 +07:00
Ferdinand Thiessen 4e8c690dc7 fix(cypress): Fix linter errors on Cypress chains and refactor `wait-until` checker functions
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-25 15:42:15 +07:00
Ferdinand Thiessen 615a6846da
feat(theming): Allow to reset the user defined app order to the default value
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-21 03:52:25 +07:00
Ferdinand Thiessen 9697df1ea5
fix(theming): App order settings - ensure the focus is kept on button
When pressing a button for changing the app order that button should keep the focus after reordering the list.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-21 03:52:18 +07:00
Ferdinand Thiessen e9d4036389
feat(theming): Allow to configure default apps and app order in frontend settings
* Also add API for setting the value using ajax.
* Add cypress tests for app order and defaul apps

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-20 00:24:17 +07:00
John Molakvoæ 4f4074452d
Fix background removal not applying to user default theming
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-10-19 12:01:29 +07:00
John Molakvoæ a024ee1cfe
Fix background removal check
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-10-19 11:54:09 +07:00
John Molakvoæ d10c4c3f6d
Add additional no-background and custom colour test
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-10-19 11:54:09 +07:00
Ferdinand Thiessen 8d57cdcab5
fix(theming): Add `aria-pressed` attribute to active background
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-18 01:35:54 +07:00
Ferdinand Thiessen 5e9a6c1a0b fix(cypress): Fix the user theming cypress test for the new filepicker
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-26 20:56:09 +07:00
John Molakvoæ 93096a9a9b
fix(cypress): revert only toggle
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-07-06 21:27:17 +07:00
Ferdinand Thiessen 7f861980a3
fix(core): Do not invert app menu text color
* Also fixes other cypress test
* Build assets

Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-06-19 09:49:36 +07:00
Louis Chemineau fc1a16283e Reset theming in cypress test
The test in admin-settings does not reset the theming.
So when it is run before user-background, the "Default cloud background is not rendered" test fails.

This makes sure that the theming is reset before running "User default background settings"

Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-31 14:18:26 +07:00
John Molakvoæ b9906fb21e
feat(files): Quota in navigation
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-01-17 18:30:41 +07:00
John Molakvoæ 1acd42e10c
Invert header if primary is bright and background disabled
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-12-08 17:52:50 +07:00
John Molakvoæ f26ee9c69d
Faster theming tests, better colours comparison and properly follow admin theming changes
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-30 18:39:57 +07:00
John Molakvoæ a869259e41
More theming cypress tests and some fixes
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-29 11:26:27 +07:00
John Molakvoæ 064fa10ecf
Extract colour from custom background
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-29 11:23:05 +07:00