130cb05ea4
chore: remove `mbstring.func_overload` check from `checkserver()`
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-08-25 13:19:36 +07:00
12edd2b23a
fix: Deduplicate code by using DependencyAnalyzer in the AppManager
...
Was a bit more complicated than expected because of a dependency loop,
the L10N factory uses the app manager, thus the AppManager cannot depend
on I10N directly or indirectly in its constructor.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-08-18 17:09:40 +07:00
0e01bc09a9
chore: Inline OC_App::setupBackgroundJobs
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-08-18 17:09:39 +07:00
e5606d7fe3
chore: Move getAppPath and getAppWebPath implementations into AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-08-18 17:09:39 +07:00
3e01a429e7
chore: Replace last calls to OC_App::enable by IAppManager
...
Also added a few missing deprecations
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-08-18 17:09:39 +07:00
4abfd4871f
chore: Move isAppCompatible and shouldUpgrade to the app manager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-08-18 16:18:38 +07:00
410389867c
chore: Inline private method OC_App::setupLiveMigrations
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-08-18 16:15:27 +07:00
fd17555333
chore: Move OC_App::updateApp to IAppManager::upgradeApp
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-08-18 16:14:45 +07:00
d5e2432bcd
fix: resolve invalid usage of `AppConfig::getValue`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-18 13:24:18 +07:00
4fcadd630b
fix: Throw specific LoginException when the user is disabled
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-07-10 15:09:25 +07:00
edf096a09f
chore: Check if apps directory is really writable in Installer
...
...rather than checkServer.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-10 11:31:59 +07:00
12c0cfc977
fix: Move getInstallPath to Installer class
...
This method does not need a public API for now, it’s only used
internally.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-10 09:39:58 +07:00
1f5e232314
chore: Move info parsing related method from OC_App to InfoParser
...
Also fix the tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 15:57:05 +07:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +07:00
60b8384e48
Merge branch 'master' into remove-x-xss-protection
2025-06-30 21:32:22 +07:00
1d2b991bda
fix: don't create an empty file before writing the contents in OC_Util::copyr
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-06-24 16:27:27 +07:00
d8fc08d718
feat(lexicon): fix tests
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-06-24 12:10:57 +07:00
3d3c77b774
feat(lexicon): migrate keys on app update
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-06-24 12:10:57 +07:00
2b58f74cc8
Fix: Remove X-XSS-Protection use, check and recommendation
...
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: invario <67800603+invario@users.noreply.github.com>
2025-06-13 16:12:27 +07:00
c21e189850
fix: make core application bootstrapable by coordinator
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-02 15:58:54 +07:00
e143921896
feat(IUser): add `getQuotaBytes` method to get machine readable quota
...
Proper replacement for deprecated `OC_Util::getUserQuota`.
Also we still use this in some cases we can now replace, moreover it
just makes sense to have a machine readable format in the API instead of
only the human readable format which is less precise.
Alings also with `getQuota` of the quota storage, which already returned
the machine readable format.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-22 12:50:38 +07:00
22889d4f1d
chore: deprecate `OC_Helper::isReadOnlyConfigEnabled`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-17 13:18:49 +07:00
e2a331f53d
Merge pull request #52890 from nextcloud/chore/move-stream-copy-implementation
...
chore: move streamCopy implementation from `OC_Helper` to `OCP\Files`
2025-05-17 12:01:44 +07:00
3d33091d2c
chore!: remove legacy functions from `OC_Helper` deprecated before v10
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 22:57:50 +07:00
bd91db8e20
chore: deprecate OC_Helper::copyr
...
Inline it into Installer as needed.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 17:32:45 +07:00
01db539d0a
chore: move streamCopy implementation from `OC_Helper` to `OCP\Files`
...
The function was already there but called the legacy version.
So moved the implementation and migrated all usages of it.
Sadly the interface was slightly different so adjusted it to be
compatible with both legacy and the OCP one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 13:03:05 +07:00
802def31f2
chore: move implementation to non-deprecated OCP\Util from OC_Helper
...
Only moves the implementation where it was already existing and adds
more helpful deprecation messages.
This way we can in the future just remove the OC_Helper variants.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 10:56:58 +07:00
54eaad76c0
chore!(\OCP\Files): remove deprecated static `getStorage` method
...
Was deprecated since Nextcloud 14 and is not used anymore.
Removing allows us to clean the OCP psalm baseline.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 14:18:28 +07:00
b3b63020c9
Merge pull request #52812 from nextcloud/chore/oc-helper-rmdirr
2025-05-14 21:53:47 +07:00
072d4e8cba
chore: move implementation from OC legacy to OCP\Files
...
- move implementation to the OCP variant that called the legacy before
- add the missing deprecation notice
- add missing parameter to align both signatures
- use OCP\Files where this method is still used
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-14 14:55:45 +07:00
1c7e4a1ba6
Merge pull request #52801 from nextcloud/chore/oc-helper-filesize
...
chore: replace legacy OC_Helper calls with OCP\Util
2025-05-14 14:37:13 +07:00
1ae3fa4003
chore: replace leagcy OC_Helper calls with OCP\Util
...
- Replace legacy calls with OCP\Util
- Add missing deprecation notices
- Inline implementation in OCP\Util and call it from OC_Helper
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-14 10:18:04 +07:00
85a6b0d0eb
chore: deprecate \OC_Helper::canExecute
...
replace this legacy method with just the IBinaryFinder
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-14 09:55:14 +07:00
ddd7d4ed13
fix: Deprecate OC_User methods related to user backends
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-10 11:12:25 +07:00
6efd9b7511
fix: add more details in documented alternatives
...
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2025-04-08 17:56:14 +07:00
b20f74a95b
chore(legacy): Flag methods as deprecated, with appropriate replacement
...
when possible.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-07 17:05:54 +07:00
09dcc87f05
chore(legacy): Remove unused protected method in OC_Util
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-07 17:05:54 +07:00
fd59e02a24
chore(legacy): Officially deprecate OC_Util and remove non-static methods
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-07 17:05:54 +07:00
e467ea1c6a
chore(legacy): Remove deprecated OC_Util::addScript and functions depending on it
...
Deprecated since 24, currently unused.
Sadly not all related functions were officially marked as deprecated,
but all of them were unused.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-01 15:24:24 +07:00
c7037d7b38
fix: Move getAppInstalledVersions to AppConfig so that it can be used earlier
...
Call it from OC_App to make sure there is only one request to DB.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 16:20:21 +07:00
32c1e3e677
feat: Add a replacement for OC_App::getAppVersions is IAppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 14:12:17 +07:00
aac391d466
chore: Move template functions out of legacy folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +07:00
a83cae1a0e
fix: Remove multiple require_once calls for template functions
...
Only require them when include the template file instead
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +07:00
db86cf8db1
fix: skip caching lastSeenQuotaUsage for remote shares
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-03-14 10:24:34 +07:00
2cd90f8281
fix: Replace all usage of OC_Template by the new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +07:00
f19ddd5525
fix: Add missing ITemplate interface and clean code in Template class
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +07:00
71dc34c03c
fix: Deprecate OC_Template, add proper template manager instead
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +07:00
c82337f3b9
fix: incorrect types detected by updated stubs
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 19:07:39 +07:00
640dbd0b5e
fix: Fix false-positive psalm taint errors when outputting plain text
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:23 +07:00
fec865cc29
chore: Correctly flag json encoding methods as escaping html and quotes
...
Especially with JSON_HEX_TAG it’s perfectly fine to echo JSON, and we
only use it in JSON output anyway.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:07 +07:00
Josh
Côme Chilliet
Ferdinand Thiessen
Daniel Calviño Sánchez
Joas Schilling
Robin Appelman
Maxence Lange
invario
John Molakvoæ
Côme Chilliet
Daniel Kesselberg