78dcf3744d
Revert "feat: Implement Directory Check"
...
This reverts commit feae8ba16a
2025-08-05 11:18:50 +07:00
feae8ba16a
feat: Implement Directory Check
...
* Partially implements #27591
Signed-off-by: Robin Windey <ro.windey@gmail.com>
2025-08-01 09:43:59 +07:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +07:00
cd3a88805b
fix: Remove legacy hacky workaround in OCA\WorkflowEngine\Listener
...
It is not needed anymore since OCP\Util::addScript is used directly now,
and not the function "script" from template functions.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +07:00
64863c9d46
chore: Apply new rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:46:42 +07:00
f25a71806b
fix(apps): Fix wrong or missing casts
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-23 17:08:29 +07:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
c254855222
chore(db): Correctly apply query types
...
fix: psalm
fix: error
fix: add batch
fix: fatal error
fix: add batch
chore: add batch
chore: add batch
fix: psalm
fix: typo
fix: psalm
fix: return bool
fix: revert Manager
2024-10-17 09:21:07 +07:00
1a4978c4ea
chore: Apply rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-20 17:51:00 +07:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
c2fb7a72da
fix(psalm): Fix @throws annotations
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 17:18:30 +07:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
e64667df37
refactor(workflowengine): Replace security annotations with respective attributes
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-27 21:36:15 +07:00
a2a0a5afcb
fix(workflows): Fix file systemtag cache
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-10 11:55:29 +07:00
cc1686dba9
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-31 10:38:47 +07:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
8bcc2d352e
chore: Fix missing template parameter for IEventListener
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 10:57:15 +07:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
d8ffbed2c2
fix(workflows): Finish password confirmation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-16 06:25:42 +07:00
93505b2cdd
fix(workflowengine): use andWhere() not second where()
...
- an unconditional where() condition is added right before
- fixes also wrongly named methods in the Exception message
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-11-13 14:47:47 +07:00
997a1c46fb
fix(workflow): Fix "Call to a member function getUID() on null" with appdata
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-13 09:00:40 +07:00
7441ce2b11
enh(IMountManager): Add method to get MountPoint from CachedMountInfo
...
Signed-off-by: Jonas <jonas@freesources.org>
2023-10-23 20:50:24 +07:00
9193d8be40
fix(isLegitimatedForUserId): Setup mountpoints to check file access
...
This fixes workflows on groupfolders, as it will consider access to
files in groupfolders.
It also fixes false positives where access to files was limited by other
means not taken into account before, e.g. access control.
For postDelete events, check for permissions of the parent folder
instead, as the file itself no longer exists.
Fixes : nextcloud/flow_notifications#71
Signed-off-by: Jonas <jonas@freesources.org>
2023-10-23 20:47:16 +07:00
0a9371f99f
Migrate applications away from deprecated ILogger
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-21 11:57:21 +07:00
bfe42de8f8
Merge pull request #38604 from fsamapoor/replace_strpos_calls_in_workflowengine_app
...
Refactors "strpos" calls in /apps/workflowengine
2023-08-07 09:10:43 +07:00
aa039c986a
fix(workflowengine): Remove legacy event (deprecated since 17)
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-19 17:37:34 +07:00
06d80ba809
fix: Avoid failing with duplicate checks
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-07-12 16:54:13 +07:00
9d15e6e21d
Fixes "PossiblyFalseArgument" notices.
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-07-03 13:13:11 +07:00
5db241b942
Refactors "strpos" calls in /apps/workflowengine to improve code readability.
...
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-07-03 13:13:11 +07:00
efb7448cd2
workflowengine: Stop using a service alias for controller
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-06-19 09:43:44 +07:00
9ba091b348
fix(workflow): Check tag attribute
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-16 08:44:41 +07:00
5bc86dd6ac
techdebt(workflowengine): Remove transition event classes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-03 15:33:17 +07:00
15fc42966c
Also check the scope when reading operations from the database
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-23 06:13:00 +07:00
c6700150d5
Validate the scope when validating operations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-23 06:13:00 +07:00
aebf654214
perf(workflowengine): Cache query that is performed on every request
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-10 14:33:07 +07:00
83cc8202b8
remove file exists check from `cacheAndReturnMimeType`
...
the method is only called if the file exists already
a check against storing the fallback mimetype is added as a safety instead
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-12-20 13:28:40 +07:00
c5a8246742
use mimetype from cache for workflow if available
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-12-20 13:28:33 +07:00
a0f6a6545b
Use TimedJob from OCP instead of OC
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-05 10:13:34 +07:00
9ba9f9a7dc
Make sure to not pass null to DateTime::createFromFormat
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 16:23:50 +07:00
d5c23dbb9f
Move CappedMemoryCache to OCP
...
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-14 15:54:31 +07:00
30d7763edc
Use SettingsSection in workflowengine settings
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-05-31 08:38:50 +07:00
ec6b83cc18
Add stricter psalm type for CappedMemoryCache
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-12 15:06:18 +07:00
64951ec14e
Change script loading order in worflowengine
...
Fix: https://github.com/nextcloud/server/issues/31709
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-03-31 10:33:50 +07:00
ccab35f23f
Fix similar potential problems with fetchOne loops
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-08 12:10:52 +07:00
cbf9064b8e
Fix psalm issues
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 12:30:27 +07:00
695165260f
Add helper method in Wrapper
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 10:39:36 +07:00
0479fff37c
The storage is not static anymore
...
Don't call twice $cache->getId
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 10:39:36 +07:00
1f392d666a
Optimize FileSystemTags workflow for groupfolder
...
In https://github.com/nextcloud/server/pull/28774 we disabled the
caching for the groupfolder application since it worked due to the fact
that in groupfolders, getFileIds could be called with the same $cacheId
and path for actually different groupfolders.
This revert this change and instead add the folderId from the
groupFolder to the cacheId. This solve the issue of the uniqueness of
the cacheId inside GroupFolder. Downside is that we introduce
groupfolder specific implementation inside the server repo.
The seconf optimization is to not consider paths starting with
__groupfolders in executeCheck. This is due to the fact that files in
the groupfolder application call two times executeCheck one time with
the url __groupfolder/<folderId>/<path> and the other time with <path>.
The first time will always return an empty systemTags array while the
second call will return the correct system tags.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 10:39:32 +07:00
08bf47a5de
Fix RequestURL check for cli commands
...
Fix https://github.com/nextcloud/files_automatedtagging/issues/526
Fix https://github.com/nextcloud/groupfolders/issues/1855
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-11 19:45:07 +07:00
b664aad7ab
Move bundles to /dist
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-01-08 10:11:58 +07:00
Joas Schilling
Robin Windey
Ferdinand Thiessen
Côme Chilliet
provokateurin
Git'Fellow
Daniel Kesselberg
Andy Scherzinger
Arthur Schiwon
Jonas
Côme Chilliet
Julius Härtl
Faraz Samapoor
Faraz Samapoor
jld3103
Robin Appelman
Carl Schwan
Louis Chemineau
John Molakvoæ (skjnldsv)