fa84f52c3f
fix: typo
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 15:11:35 +07:00
372c9d2ee6
fix: check both CLI and value
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 15:09:29 +07:00
39f052407a
fix(setupchecks): Skip checking for OPcache if running from CLI
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 10:43:20 +07:00
8fc498fb82
fix(IntegrityCheck): Ensure the check is run if no results are available
...
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-03 11:37:49 +07:00
02983f3317
Merge pull request #46190 from nextcloud/bug/45047/skip-check-when-disk-free-space-disabled
...
fix(setupchecks): skip check when disk_free_space is disabled
2024-06-29 15:59:17 +07:00
fd9fd1b6fb
fix(setupchecks): skip check when disk_free_space is disabled
...
Make it easier to discover that the check failed because disk_free_space is disabled.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-28 13:06:49 +07:00
6601adcd6d
refactor(SetupCheck): Make mariadb and mysql version variables
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 16:22:42 +07:00
6e48ca1cf8
fix(settings): Adjust SetupCheck for supported database versions
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 16:15:16 +07:00
ea994fe8fb
fix(settings): make trailing slash for caldav/carddav redirects optional
...
#43939 moved the CalDAV/CardDAV redirect checks from the frontend to a new backend API.
Since the backend does not send an authentication header, checking for the expected response code 207 of the DAV endpoint does not work anymore, hence the URL of the last redirect is checked instead.
This URL is expected to contain a trailing slash, which was not required before, since the DAV endpoint works properly without it (when authenticated).
While a trailing slash in the redirect does no harm, it causes many setups to throw an admin panel warning, while in fact the redirects work properly. Furthermore, the proposed "/.well-known/carddav" => "/remote.php/dav/" redirect leads to double slashes, when doing a request to "/.well-known/carddav/", which seems more wrong then right.
This change makes the trailing slash optional, hence old and adjusted setups won't throw the warning anymore, and the DAV endpoint works well in both cases.
Signed-off-by: MichaIng <micha@dietpi.com>
2024-06-24 17:52:22 +07:00
e74f71b32e
feat: add setup check for needed mimetype migrations
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-18 14:46:19 +07:00
ec5b60af28
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-03 20:33:31 +07:00
ad78f7e48e
fix(caldav): automatically delete outdated scheduling objects
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-31 13:14:01 +07:00
c31d6b1fdc
Merge pull request #45262 from nextcloud/check-HttpsUrlGeneration
...
fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
2024-05-13 12:06:21 +07:00
99f89bb3de
Merge pull request #45242 from nextcloud/check-memcache-memcached
...
fix(setupCheck): Only warn when memcache present w/o memcached
2024-05-13 11:53:27 +07:00
ef320200b9
fix: Move hint about firewall issues to common helper string
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-13 09:27:19 +07:00
a5fc9b1563
Merge pull request #45272 from nextcloud/check-db-missing-indices
...
feat(SetupChecks): Refactor DatabaseHasMissingIndices
2024-05-13 07:55:39 +07:00
5b5178abe7
fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-12 18:09:36 +07:00
229e5444c9
feat(SetupChecks): Refactor DatabaseHasMissingIndices
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-11 10:29:42 +07:00
29157149c8
fix: oops vendor string embedded in version
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 +07:00
2e94ec8832
fix: only compare major version of pgsql
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 +07:00
3ce8c6d0db
fix: refactor postgresql check to match mariadb/mysql
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 +07:00
f486be8da1
fix: only compare minor mariadb version differences
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 +07:00
2abd67cc02
fix(setupChecks): update db version checks
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 +07:00
c0e395cc0d
fix(setupCheck): Only warn when memcache present w/o memcached
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-09 11:45:16 +07:00
37262c860a
fix(setupchecks): Fix opcache buffer check
...
This was broken by last codestyle update, maybe even before because of
operator precedence. Now using vars to make it readable and correct at
the same time.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:23:59 +07:00
9ef70f0c4e
feat: drop support for php 8.0
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-04-08 11:28:54 +07:00
f63c0cf921
Merge pull request #44306 from nextcloud/settings/show-indextoreplace-warning
...
fix(settings): show warning for indexToReplace as part of missing indices
2024-04-05 13:14:43 +07:00
66fad4ae93
fix(SetupChecks): Add hint about dns/firewall if `mjs` check can't run
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-04-02 18:10:22 +07:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
14addf3fdb
fix(settings): Also verify that `trusted_proxies` only contains IP addresses (with range)
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-26 14:50:57 +07:00
33a0aa6994
fix(settings): show warning for indexToReplace as part of missing indices
...
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2024-03-19 11:44:00 +07:00
6278cf181e
fix: Improve HSTS warning wording as suggested by reviewer
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-14 11:49:47 +07:00
9f819f311f
feat: Migrate HSTS check to Security headers SetupCheck
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
d7193ef65e
fix: Migrate security headers check tests and fix the SetupCheck implementation
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
310377e496
fix: Fix Security headers setup check behavior
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
1fffdf4763
fix: Fix ocm-provider setup check failure detection
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
a47a1e6249
feat: Migrate header check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
519e434573
fix(updatenotification): spread the use of new appconfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-13 02:22:11 +07:00
58f57fd13f
fix(settings): Adjust order of parameters for `runRequest`
...
Fixing invalid request to host `HEAD`.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-08 11:21:51 +07:00
1ea88a73f6
feat(settings): Migrate .well-known URL setup check to new API
...
Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-07 14:06:08 +07:00
a6a962d5a2
fix(settings): adjust source maps setup check wording and log level
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-03-06 15:11:32 +07:00
f0494e2b5a
feat(settings): add JavaScript Source Maps support `.js.map` setup check
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-03-06 11:16:10 +07:00
5794e1c9d6
Merge pull request #43906 from nextcloud/enh/migrate-ssl-url-setupcheck
...
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
2024-03-04 15:54:47 +07:00
ef2c312b18
feat(settings): Migrate data directory protection check to `SetupCheck`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-29 13:54:01 +07:00
ca246dc35c
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-29 12:21:36 +07:00
ad747ab62b
feat(settings): Migrate OCM / OCS provider tests to SetupCheck
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-27 14:52:10 +07:00
398b042af7
enh(settings): Migrate WOFF2 loading check to a SetupCheck
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-15 02:17:20 +07:00
096d66edc8
enh(settings): Add trait for setup checks that need to access the webserver using HTTP requests
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-15 02:17:16 +07:00
839ddaa354
feat: rename users to account or person
...
Replace translated text in most locations
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +07:00
8663da1e50
fix(i18n): Adapted spelling of Unicode
...
Reported at Transifex
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-01-30 16:54:21 +07:00
936c6a2928
Migrate debug mode check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 10:11:03 +07:00
3be505f9c2
Rename to "Push service" and enable on all instances to avoid trouble
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 15:23:54 +07:00
67541f21f6
Migrate fair use of free push service check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 13:05:59 +07:00
9add64f30e
Merge writable temporary space check with the s3 one, and improve
...
It will now show available space and path of both PHP and Nextcloud
temporary directories if they differ.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 11:47:30 +07:00
058f7d5664
Migrate available temp space check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 11:47:29 +07:00
10664e9529
Migrate MySQL utf8mb4 check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-23 17:34:04 +07:00
4dc224fa2c
Merge pull request #42999 from nextcloud/fix/mjs-setup-check-local
2024-01-23 15:13:24 +07:00
c43144fc7d
Remove bz2 leftover description
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:56:40 +07:00
f13b2fb103
Add missing recommended modules gmp and bcmath
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:08:59 +07:00
4c34216305
Fix description for exif PHP module
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:07:37 +07:00
ca3e1a531a
Merge gmp and bcmath module checks with the existing PHP modules setup check
...
Also add description for why each module is recommended
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:07:21 +07:00
d51522750e
Merge pull request #42821 from J0WI/rm-bz2-check
...
Remove disputed bz2 check
2024-01-22 11:11:36 +07:00
d2cb90bda2
fix(settings): Allow to connect to local address when checking for `.mjs` support
...
Also reduce the severity in case of a failed check to warning.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-21 20:20:53 +07:00
a77bab2f95
Migrate set_time_limit setup check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 12:36:53 +07:00
1334055ab8
Merge pull request #42812 from nextcloud/enh/migrate-memcached-setupcheck
...
Migrate memcached PHP module setup check to new API
2024-01-18 12:23:02 +07:00
5ad549a72f
Migrate memcached PHP module setup check to new API
...
Merged it with the other existing memcache setup check as it fits
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 09:40:43 +07:00
b09fa57c16
fix(i18n): Change cli to uppercase
...
Like all other occurences.
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-01-18 09:18:05 +07:00
46ebe16c83
Migrate Cron checks to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 10:49:19 +07:00
0483064f07
Migrate overwrite.cli.url setup check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 09:05:40 +07:00
80d58f0162
Merge pull request #41312 from nextcloud/feat/migrate-code-integrity-check
2024-01-16 09:04:24 +07:00
1cb7ccfb45
Remove disputed bz2 check
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2024-01-15 23:45:47 +07:00
24f8b04908
Remove CSRF check from code integrity rescan
...
Did not find a way to get a valid token from SetupCheck
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:48 +07:00
1c4d43923a
Use highlight rich objecttype to render links in CodeIntegrity setup check
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:48 +07:00
f06b8da249
Migrate code integrity to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:38 +07:00
c5fbd969dd
Update apps/settings/lib/SetupChecks/JavaScriptModules.php
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-10 11:58:51 +07:00
995b23e818
enh(settings): Add SetupCheck to ensure webserver correctly serves `.mjs` files
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-10 11:58:51 +07:00
3d4c4f19b4
Migrate app dir owner check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 17:37:14 +07:00
94d0399229
Improve PHP opcache setup check and reduce level in some cases
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 16:03:53 +07:00
c92fbca6e6
Fix small psalm issue
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +07:00
f6df5dae34
Remove unsupported <code> tag and use quotes instead
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +07:00
3f13a1a47e
Migrate opcache check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +07:00
26f4ec66af
feat(setupcheck): Add setup check for maintenance_window_start config
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-18 11:29:38 +07:00
95ea46c99c
Merge SQlite warning to existing SupportedDatabase setup check
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-12-07 15:45:27 +07:00
60bc97e543
Migrate away from deprecated doctrine/dbal getName function
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-28 14:08:10 +07:00
51758117a7
Migrate database pending bigint conversions check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-28 14:07:47 +07:00
9a1f5edb65
Missing things in database should be warning, not info
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +07:00
a0e365f6d2
Switch from deprecated hasPrimaryKey to getPrimaryKey function
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +07:00
1b547c7db8
Migrate missing primary key database check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +07:00
ad88c04f2d
Migrate missing index database check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +07:00
2cb1c0f2dc
Migrate missing column database check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +07:00
011390aacb
Merge pull request #41640 from nextcloud/bugfix/noid/fix-memory-limit-setup-check
...
fix(setupcheck): Fix memory limit setup check
2023-11-27 06:39:57 +07:00
318875a16e
Add quotation marks
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-23 08:43:20 +07:00
ea3865138f
Correct spelling
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-23 08:39:17 +07:00
0acd07c362
Change "brute force" to "brute-force"
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-22 14:22:47 +07:00
94e05ea919
Correct a typo
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-21 15:45:33 +07:00
519fad9206
Add quotation marks
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-21 15:40:01 +07:00
6475f2f8be
Add quotation marks
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-21 15:32:38 +07:00
f5a40c2219
Correct spelling of Brute Force
...
Correcting the spelling of "Bruteforce" to "Brute Force"
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-21 15:19:16 +07:00
4fe363f882
fix(setupcheck): Fix memory limit setup check
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-21 14:47:21 +07:00
ad372869bc
Fix tests for setupchecks
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 18:03:15 +07:00
Git'Fellow
Ferdinand Thiessen
Daniel
MichaIng
Robin Appelman
Andy Scherzinger
Anna Larch
Côme Chilliet
Julius Härtl
Josh Richards
Côme Chilliet
Richard Steinmetz
Johannes Merkel
Maxence Lange
John Molakvoæ
John Molakvoæ (skjnldsv)
Vincent Petry
rakekniven
J0WI
Joas Schilling
Joas Schilling
Valdnet