dd5ce9eaa4
fix(sharing): Move permission validation to share manager
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-31 18:21:26 +07:00
28c885dbf2
fix: Use getRelativePath method to check if node is inside folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:44:08 +07:00
e30cd2f03f
fix: Fix promotion of reshares from subsubfolders
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:44:02 +07:00
ec85a49cad
chore: Add comment to make code clearer
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:43:44 +07:00
04b6eef246
chore: Turn method description into phpdoc
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-12-19 14:43:37 +07:00
c7dbe7e71c
fix(shares): Promote reshares into direct shares when share is deleted
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:43:21 +07:00
16decdede7
fix: Tidy up code for reshare deletion
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:41:50 +07:00
024f98a8a1
fix: delete re-shares when deleting the parent share
...
Note: Removed part about fix command from original PR
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
(cherry picked from commit 42181c2f49
2024-12-19 14:39:44 +07:00
ca1e3828aa
fix(shares): Wrap exceptions from password validation to set code to 400
...
This fixes a regression that bad password returned 403 instead of 400
because of previous changes.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-12 15:38:18 +07:00
dab953970d
fix(files_sharing): Do not wrap password policy exception into a generic one
...
Let the controller access the HintException and show the error to the user.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-12 15:38:18 +07:00
0551919bce
fix(share): Ensure unique share tokens
...
- check for token collisions and retry up to three times.
- throw after 3 attempts without finding a unique token.
Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
2024-09-25 09:39:51 +07:00
9791fa278f
fix: check for correct storage class when checking for link parent
...
fixes #39123
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-16 15:17:07 +07:00
3d136e4466
fix: Add `acceptShare` as an interface
...
It was commented out because at that time no other share provider
supported the `acceptShare` method. Today it is the same no other provider
supports it, but we should make it discoverable by adding it to the public API
as an additional interface.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-30 15:25:51 +07:00
d388370c3b
feat(files_sharing): implement IShareProviderWithNotification and refactor sendMailNotification
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
f5fd6c8f08
fix(files_sharing): Store the expiration date relative to the server's timezone
...
This is needed as we want to store the difference between the server's and the user's timezones.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-26 12:49:42 +07:00
4a77fe3530
fix(dav): also return shared-with-me shares data
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 10:27:29 +07:00
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-24 13:11:22 +07:00
f5a433f946
refactor(shareManager): Use constructor property promotion
...
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-05-23 14:11:33 +07:00
59a5b4e0bd
fix(shareManager): Respect empty `expireDate` in server
...
If `expireDate` is an empty string and not `null` then the server should not set a default.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-05-23 14:11:33 +07:00
54afea4b01
Merge pull request #44460 from nextcloud/remove-non-shallow-in-folder
...
refactor: remove non-shallow getSharesInFolder
2024-05-17 17:41:25 +07:00
4c085ef129
fix: cleanup logic for getting the max reshare permissions
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-05-03 14:53:18 +07:00
ccd56672e8
refactor: remove non-shallow getSharesInFolder
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-05-01 16:46:06 +07:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
34ca6bd46a
ShareByMailProvider: getAccessList: recommended style changes
...
Signed-off-by: Adam Serbinski <adam@serbinski.com>
2024-03-21 18:25:31 +07:00
9c528d412c
ShareByMailProvider: getAccessList: add token to returned array
...
This allows the share URI to be regenerated.
Signed-off-by: Adam Serbinski <adam@serbinski.com>
2024-03-21 18:25:31 +07:00
26ae5e6dfb
ShareByMailProvider: getAccessList: return full list of recipients
...
Previously was returning only boolean true if the Node was shared
by email, or false if not. Now provides an array containing the
list of email share recipients.
Signed-off-by: Adam Serbinski <adam@serbinski.com>
2024-03-21 18:25:31 +07:00
bf71bd1305
fix(share): use share owner to confirm reshare
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-20 00:31:09 +07:00
339702e376
refactor: make share manager buildable
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-06 14:33:51 +07:00
e7a7b4a401
perf: switch places that always use the first getById result to getFirstNodeById
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-04 13:57:31 +07:00
01983d50d4
feat(share): save date and time for expiration
...
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-02-22 11:26:01 +07:00
4a509dfe8e
fix: phpunit
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:06:31 +07:00
839ddaa354
feat: rename users to account or person
...
Replace translated text in most locations
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +07:00
9af96d9f9a
feat(php,vue): Create a new parameter
...
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +07:00
24f97a57e2
fix(manager): removed dead code
...
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2023-12-18 12:29:50 +07:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
64f62f7cfd
Merge pull request #39863 from nextcloud/sharing-mask-wrapper
...
move share permission logic to storage wrapper
2023-09-04 14:05:14 +07:00
24ad2e2dc4
Use nullsafe call syntax instead of additionnal check
...
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-08-28 09:40:12 +07:00
8c9aa9a919
Set files_sharing:hide_disabled_user_shares to 'yes' to hide shares from disabled users
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-28 09:40:12 +07:00
e73889a240
cleanup di for share permissions wrapper
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-16 15:25:05 +07:00
cebf93d4d2
fix: Remove legacy dispatcher from share manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
22e033b628
feat!: Migrate Share accepted event to typed event
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
8ad94cbfda
feat!: Migrate unShare events to typed events
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
44b810bfbd
feat!: Migrate Sharing events to typed events
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:19 +07:00
c67c067ee7
fix: Move Sharing events to IEventDispatcher
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:53 +07:00
426c0341ff
Use typed version of IConfig::getSystemValue as much as possible
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 12:50:08 +07:00
d9f8522003
Fix types for reading and writing config values
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +07:00
3473fa3187
also set the node when re-using existing share on share create
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-03 16:40:47 +07:00
c0e84cb512
Add SHARE_TYPE_SCIENCEMESH
...
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
2023-03-08 16:46:55 +07:00
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
60313683e2
Fix checkpassword undocummented null parameter
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 12:38:21 +07:00
Ferdinand Thiessen
Côme Chilliet
Côme Chilliet
Luka Trovic
ernolf
Robin Appelman
skjnldsv
Louis Chemineau
Andy Scherzinger
fenn-cs
Adam Serbinski
Maxence Lange
Benjamin Gaussorgues
Vincent Petry
Baptiste Fotia
Eduardo Morales
Joas Schilling
jld3103
Michiel de Jong
Carl Schwan