57f09b642e
fix(container): Reduce general deprecation spam on all requests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-08-09 11:53:30 +07:00
8783679a49
Merge pull request #54303 from nextcloud/jtr-oc-appframework-app-cleanup
2025-08-08 10:41:51 +07:00
2f18996347
fix(container): Don't use deprecated things to set up controllers for apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-08-08 08:42:56 +07:00
17c40b9474
fix(container): Log the deprecation to the app when possible
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-08-08 08:42:55 +07:00
67c14b0f11
refactor(App): \OC\AppFramework\App clean-up
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-08-06 17:10:45 +07:00
9195987d14
refactor(AppFramework): drop unused spreed/Talk fallback
...
No longer needed from what I can tell since #20114 & nextcloud/spreed#3134
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-08-04 08:59:49 +07:00
4829ac57c1
fix: use `OCP\Server`
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-08-01 17:00:09 +07:00
14b4d0327e
fix(AppFramework): Log malformed protocol values and unify fallback behavior
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-08-01 17:00:09 +07:00
132513dbf3
fix(userconfig): duplicate core lexicon
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-07-29 10:36:44 +07:00
e89b3a0597
Merge pull request #54051 from nextcloud/fix/session/log-ephemeral-session-close
2025-07-28 08:16:32 +07:00
33bff30e1d
feat(lexicon): moving out from unstable
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-07-24 15:56:33 +07:00
084a2e8859
fix(session): log when ephemeral sessions are closed
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2025-07-23 07:52:06 +07:00
7fe272fd74
fix(Coordinator): ensure the core app is loaded first
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-17 16:59:45 +07:00
2346a528ba
fix: Tidy up middleware registration code and scope them to application container
...
This make sure that all middlewares get a logger scoped to the
application id, among other things.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:16 +07:00
3dd4ba854f
fix: Add back ContainerInterface service to DIContainer
...
Otherwise it gets resolved to \OC::$server.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:15 +07:00
2240acec7f
fix: Put back ScopedPsrLogger service
...
Cannot use an alias for this one, as it depends upon LoggerInterface so
that creates an infinite loop.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:15 +07:00
bbe766b07a
fix: Make sure Request class can be dependency injected to fix SameSiteCookieMiddleware injection
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:14 +07:00
ab310ce938
fix: Fix issues and tests in DIContainer and friends
...
Some tests related to MiddlewareDispatcher are still failing.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:14 +07:00
9913bdda90
chore: Cleanup DIContainer class
...
Also removed deprecated tag from the class as this class will not be
removed, only the interface IAppContainer and associated methods should
be removed.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:12 +07:00
0c087ece4c
Merge pull request #53740 from nextcloud/fix/properly-fail-on-invalid-json
...
Properly fail on invalid json
2025-07-03 18:00:28 +07:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +07:00
79f4e0de76
fix: Only attempt to decode JSON input if it is not an empty string
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-01 11:24:27 +07:00
e8bc35ec0a
fix(ocs): Return a proper error on JSON decoding failures
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-01 10:45:31 +07:00
87f98c88ab
chore: Rename property and type it to match its current use in Request
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-01 10:25:14 +07:00
8b0a3a774d
fix: throw a better error if we don't get an authorization header for secutity confirmation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-06-24 15:57:20 +07:00
be587def0e
fix: use correct format for expires, last-modified, and if-modified-since headers
...
Before: Sat, 10 May 2025 18:17:41 +0000
After: Sat, 10 May 2025 18:17:41 GMT
RFC: https://httpwg.org/specs/rfc9110.html#http.date
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-06-10 13:15:31 +07:00
2eed6d3a89
feat: Add a configuration toggle for lazy objects in DI
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 20:51:24 +07:00
98b2cfc416
fix: Fix several side effects of lazy ghosts
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 20:50:42 +07:00
86ff5810d7
fix: Only use Lazy objects if PHP is 8.4 or higher
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 20:49:58 +07:00
1bf41550d0
chore: Suppress psalm error
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 20:49:58 +07:00
06c062bebd
feat: Use Lazy ghosts for Dependency injection
...
This will only work with PHP 8.4, so we’ll need to put it behind a version check later.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 20:49:38 +07:00
e8370bf73a
fix: Use only enabled applications versions in the cache prefix
...
This makes sure the cached routes are updated after enabling a
previously disabled application
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-05 17:58:54 +07:00
c21e189850
fix: make core application bootstrapable by coordinator
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-02 15:58:54 +07:00
89a7778f87
test: Mock ITaskManager to remove test interactions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-29 12:20:20 +07:00
e4ed062d68
fix(RouteParser): bail out if method name contains hashtag
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 13:57:14 +07:00
63ba61487b
chore(AppFramework): Remove unused RouteConfig class and migrate tests to RouteParser
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 13:57:14 +07:00
0c56605497
fix: Fix psalm issue and update baseline
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-14 19:18:31 +07:00
20c6d1a7e9
feat: Improve init a bit, and add more profiling steps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-13 16:08:49 +07:00
7964f338dc
fix(throttler): Remove the sleep from the throttler that throws
...
The sleep is not adding benefit when it's being aborted with 429
in other cases anyway.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-02 11:27:29 +07:00
6951053c90
docs(dispatcher): Correct described return values
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-04-23 22:43:03 +07:00
92038229fa
fix: Remove support for app.php loading
...
It has been deprecated for a long time, and the last known active
application to use it (user_saml) is now migrated the modern API.
Presence of the file is still checked in order to log an error.
This behavior may be removed as well in a few versions.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-14 14:30:00 +07:00
3bff9ee3e1
fix: Use login name to check the password
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-04-02 15:50:05 +07:00
c7037d7b38
fix: Move getAppInstalledVersions to AppConfig so that it can be used earlier
...
Call it from OC_App to make sure there is only one request to DB.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 16:20:21 +07:00
c9aea8ffdf
fix(auth): Allow 2FA challenges for Ephemeral sessions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-03-18 09:52:51 +07:00
a163fa08d0
fix(login): Properly target public page with attribute
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 16:36:26 +07:00
42d752f767
Merge pull request #51116 from nextcloud/enh/noid/nullable-range
...
feat(AppFramework): extend range check to optional parameters
2025-03-04 14:23:21 +07:00
6594d7d96d
feat(AppFramework): extend range check to optional parameters
...
Now it also applies when a paramater is documtend with a pending |null,
but no further unionation is considered.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2025-02-27 19:49:04 +07:00
47bd75a052
fix(login): Also check legacy annotation for ephemeral sessions
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-27 13:12:55 +07:00
c7900de4f2
Merge pull request #51051 from nextcloud/artonge/fix/login_flow_v2_sessions_2
...
feat: Close sessions created for login flow v2
2025-02-27 08:52:00 +07:00
c6293204a2
feat: Close sessions created for login flow v2
...
Sessions created during the login flow v2 should be short lived to not leave an unexpected opened session in the browser.
This commit add a property to the session object to track its origin, and will close it as soon as possible, i.e., on the first non public page request.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-26 13:42:18 +07:00
Joas Schilling
Benjamin Gaussorgues
Josh
John Molakvoæ
Maxence Lange
Christoph Wurst
Ferdinand Thiessen
Côme Chilliet
Andy Scherzinger
Robin Appelman
Daniel Kesselberg
provokateurin
Louis Chemineau
Arthur Schiwon