Commit Graph

516 Commits (dcc6c1956ac7d6d5cf4781cb00a1055dee47d599)

Author SHA1 Message Date
Côme Chilliet dec52f6979
Migrate getenv test to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +07:00
Côme Chilliet 0c346849f3
Migrate missing PHP modules check to new API and improve it
Test all modules listed as required in our documentation

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 15:58:45 +07:00
Côme Chilliet 789ff3f414
Fix jsunit tests for SetupChecks
Tests could be simplified to test generic setup check directly with fake
 data instead of trying to mimic real steps results but for now this
 will do.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 14:46:46 +07:00
julia.kirschenheuter 7d00c7fde4 Replace password dialog with dialog from library
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-10-17 14:09:43 +07:00
Christoph Wurst 6a375ca161 refactor: Contacts menu to Vue
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-10-16 14:12:20 +07:00
Joas Schilling bed3ffb312
feat(admin): Show an error when the admin is throttled
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:40:24 +07:00
Andy Scherzinger f5c4f55576
Merge pull request #37451 from Fenn-CS/fix/36437/deprecate-php-8.0
Deprecate PHP8.0
2023-04-19 15:28:12 +07:00
Simon L 1a255379e8
Merge pull request #37766 from nextcloud/enh/noid/add-db-file-locking-check
add an admin check for db file locking
2023-04-18 13:31:57 +07:00
Simon L e2ab9bf4af address review and fix tests
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-18 11:33:53 +07:00
fenn-cs 60a710c91c Deprecate PHP8.0
PHP8.0 would stop receiving security support on 26 Nov 2023
 hence this deprecation. Next, is the eventual drop of PHP8.0 before its EOL.

This commit also updates the message type from INFO to WARNING if the php
 on file has reached its EOL.

See: https://www.php.net/supported-versions.php

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-04-17 23:45:59 +07:00
Alexander A. Klimov ff02b072ae Drop broken unit test
Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
2023-04-17 23:38:29 +07:00
Simon L 80645a591a add an admin check for db file locking
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 12:51:33 +07:00
John Molakvoæ f060e5a72f
fix(tests): update jsunit tests after dep and files update
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-04-06 15:31:37 +07:00
Ferdinand Thiessen c97137e434 fix(jsunit): Modify `OC.L10N` tests as it does not depend on `OC.` anymore
Meaning we can not stub `getLocale` but must override the document attribute instead.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-20 15:03:31 +07:00
MichaIng 5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow"
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240

Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-15 20:16:51 +07:00
Côme Chilliet d4ed1a13fd
Revert "update 64-bit check wording"
This reverts commit f5ad282418.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 15:02:54 +07:00
Christopher Ng f6aa5224c4 Focus trap contacts menu with NcHeaderMenu port
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-13 23:19:28 +07:00
Valdnet a18a95bbc9
Fix test
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-11-09 18:01:20 +07:00
szaimen f5ad282418 update 64-bit check wording
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-11-01 13:50:50 +07:00
Joas Schilling f976d372fe
Adjust tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-09-29 16:38:50 +07:00
Valdnet caac0f069d
Fix test
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-09-19 11:13:39 +07:00
Valdnet 187464a70d
Fix test
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-09-19 11:12:09 +07:00
Valdnet 58d98a3085
Fix test
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-09-19 10:39:32 +07:00
Daniel Kesselberg 700875d90d
Rewrite OC.SystemTags.getDescriptiveTag to vanilla js
For every tag a deprecation warning is emitted.
With 10k tags the ui becomes unresponsive and inspector crashed occasionally.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-09-15 17:08:04 +07:00
Simon L 4209dc7d66
Merge pull request #33475 from nextcloud/rakekniven-patch-1
l10n: Changed grammar
2022-08-31 19:34:29 +07:00
Julius Härtl aa85e1c2af
Fix jsunit failures
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-31 14:36:20 +07:00
rakekniven a1987158d7
l10n: Changed grammar
Fixed tests for #33475 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-08-11 09:29:30 +07:00
Vincent Petry 3df85205b4
Fix core tests by stubbing debounce
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-26 15:46:17 +07:00
szaimen c1b88f927e add a link to system requirements for new 64bit setup check
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
2022-07-13 22:16:42 +07:00
szaimen cf9b1082ed add a setup check for 64 bit
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-07-13 09:33:33 +07:00
MichaIng ea0e45d81e Remove legacy Internet Explorer headers
X-UA-Compatible and X-Download-Options headers are interpreted or relevant for Internet Explorer only. With the deprecation of Internet Explorer support in Nextcloud 20 and planned support removal already in Nextcloud 22, these became obsolete and are hereby removed, including their removal from setup checks.

Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-19 18:17:46 +07:00
szaimen 3c8f8bc70a fix tests
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-07 18:07:45 +07:00
MichaIng 5ac91f1cb8 Add Nextcloud docs link to OPcache recommends
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.

Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend.

Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-03 23:00:07 +07:00
szaimen 445ab85b01 add a test for wasEmailTestSuccessful
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-02-03 20:41:12 +07:00
szaimen fa1ee8f0c7 fix tests
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-02-03 20:41:12 +07:00
Louis Chemineau be968a8841 Use @nextcloud/sharing in files and files_sharing
Signed-off-by: Louis Chemineau <louis@chmn.me>

Update tests

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-26 17:58:43 +07:00
Louis Chemineau f752888d91 Fix contactmenu tests
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-18 11:03:01 +07:00
Louis Chemineau 14e57bf70a Replace license information to SPDX expression
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:26:40 +07:00
Louis Chemineau d92cbf5149 Typing corrections
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:12:55 +07:00
Vincent Petry 6aba3964d3
Fix JS tests after test lib updates
Prevent XHR during load by checking window.TESTING.
Adjust some expected values.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-10 15:08:03 +07:00
MichaIng 82c1beaacb Enhance and complement OPcache setup checks
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.

With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.

The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.

A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.

OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.

Signed-off-by: MichaIng <micha@dietpi.com>
2021-12-19 23:38:21 +07:00
Vitor Mattos e55ceb2bb1
Show warning on admin settings page
Signed-off-by: Vitor Mattos <vitor@php.rio>
2021-10-23 00:54:50 +07:00
Carl Schwan a01917510d
Merge pull request #28863 from nextcloud/Valdnet-patch-2
l10n: Correct spelling
2021-09-22 14:08:25 +07:00
Valdnet 538bfc6a94
Correct spelling in test
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-09-22 13:21:23 +07:00
Stefan d4cc22daad Issue 16719: CheckSetupController.php: bugfix: test-setup was incorrect
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +07:00
Stefan 8758b36ebb Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +07:00
Guillaume Virlet 910c208c4c fix broken js test
Signed-off-by: Guillaume Virlet <github@virlet.org>
2021-04-24 09:24:52 +07:00
Roeland Jago Douma 5ae5aae324 Fix the jsunit tests
Followup to #25874

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:30:32 +07:00
Joas Schilling db3b698fc0
Hello 2016
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-01 20:28:12 +07:00
Joas Schilling 96ae83c529
Remove HTML from setup check translations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-01 20:24:02 +07:00
Julius Härtl be38b924d1 jsunit: harden avatar tests to pass with fractional scaling of elements
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-29 08:42:34 +07:00
Julius Härtl 7f52754fe8 jsunit: Add proper lang tag to document
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-29 08:42:34 +07:00
Christoph Wurst f37e150d1c
Merge pull request #24702 from nextcloud/enhancement/well-known-handler-api
Add well known handlers API
2020-12-18 13:34:04 +07:00
Julius Härtl b9330887ca
Merge pull request #24740 from nextcloud/bugfix/24738/improve-phone-region-help
Improve hints for default_phone_region
2020-12-17 15:29:54 +07:00
Joas Schilling 15956c20c3
Improve hints for default_phone_region
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-17 09:14:21 +07:00
Christoph Wurst 6995223b1e
Add well known handlers API
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 13:13:05 +07:00
Arthur Schiwon 1995097cb8
promoted bad memory_limit setting to error as it may break updater
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-15 23:50:26 +07:00
Joas Schilling 46b073d7ce
Add a config for default region of phone numbers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +07:00
Christoph Wurst ae0a496da8
Bump jquery from 2.2.4 to 3.1.0
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-13 08:46:35 +07:00
Joas Schilling d5df033ede
Create primary keys on all tables and add a command to create the afterwards
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:36:27 +07:00
Vincent Petry f2de58db8c
Work around snap.js state mess
Snap.js is not robust enough to prevent multiple calls to open() or
close(), so we added more checks to prevent these happening even when an
animation is in progress.

Because if we let this through, snap.js will not notice that the
animation is already done (or a duplicate animation was started),
so the "transitionend" event will not fire a second time.

During an animation, snap.js sets up a setInterval() that hogs the CPU
during the animation. Since a transition doesn't always end due to the
above conditions, that CPU hogging would stay forever.

This is the best workaround so far, it seems it's not possible to cancel
that interval from the outside nor to trigger events to make it do so.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-11-02 17:31:18 +07:00
npmbuildbot[bot] 34100f1775
Compile assets
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-28 10:28:19 +07:00
Christoph Wurst eaf4724acc
Move humanFileSize and OC.getCanonicalLocale to npm packages
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-05 08:48:49 +07:00
Sergey Shliakhov 09ecf4b4eb Generate legacy image placeholder text by taking first letters
https://github.com/nextcloud/server/issues/19335
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-30 07:17:47 +07:00
Christoph Wurst 8119e0b18e
Inline usages of OCP.Toast in bundled files
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-06 17:19:57 +07:00
Joas Schilling b974dd5b73
Update new test as well
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-01 13:20:01 +07:00
Joas Schilling 720dc4e93d
Add optional column oc_comments.reference_id
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-31 10:51:15 +07:00
Roeland Jago Douma b0ea022a3e
Add basic reverseproxy misconfig detection to setupchecks
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-23 10:37:08 +07:00
John Molakvoæ (skjnldsv) 5d2c89ca6c
Fix sharing breadcrumbs
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-11-06 00:53:59 +07:00
Christoph Wurst a27a4f757d
Use @nextcloud/paths and deprecate OC helpers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-10-05 23:44:20 +07:00
Roeland Jago Douma 32587d7007
Remove the tests since the library is tested
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-10-04 19:32:12 +07:00
Victor Goff 2663fc442c adviced should be advised
Signed-off-by: Victor Goff <keeperotphones@gmail.com>
2019-08-23 07:01:45 +07:00
Daniel Calviño Sánchez abd5d10253 Add unit tests for "OC.Notification.hide()"
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-07-26 18:46:59 +07:00
Daniel Calviño Sánchez 03f2e8a10e Fix default timeouts in OC.Notification
When no timeout was given "show()" used the default timeout of
"OCP.Toast", which is 7 seconds instead of indefinitely as stated in the
documentation of "show()". "showHtml()" should also indefinitely show
the notification if no timeout is given, but due to the strict
comparison the notification was indefinitely shown only when a timeout
of 0 was explicitly given. Now both methods show the notification
indefinitely (or until it is explicitly hidden) when no timeout is
given.

The unit tests did not catch this error because "showHtml()" had no
tests (as before the move to Toastify it was called from "show()" and
thus implicitly tested), and because "show()" verified that "hide()" was
not called after some time; "hide()" is no longer called from "show()"
since "OCP.Toast" is used internally, so the test always passed even if
the notification was indeed hidden. Now the test is based on whether the
element is found or not, and explicit tests were added too for
"showHtml()".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-07-26 18:46:59 +07:00
Daniel Calviño Sánchez 14006b548e Fix mixed test for "show" and "showTemporary"
"showTemporary()" when a timeout was given was being tested along with
the "show()" tests; now there are two separate tests when a timeout is
given, one for "showTemporary()" and one for "show()".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-07-26 18:46:58 +07:00
Daniel Calviño Sánchez 2b1c80ea3f Check number of elements instead of if the jQuery object is defined
Tje jQuery object created through "$('#testArea .toastify')" will be
always defined even if no elements were found, so the check does not
really work; instead, it should be checked the number of elements found.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-07-26 18:46:51 +07:00
Daniel Calviño Sánchez 916c95758f
Rename parameter in OCP.Toast for consistency with OC.Notification
This fixes HTML messages in "OC.Notification.showTemporary" (as
"showHtml" was not set based on "isHTML"), and also makes OCP.Toast to
keep the old OC.Notification API when used directly.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-07-12 16:15:05 +07:00
Roeland Jago Douma 2c449469d3
Merge pull request #16070 from nextcloud/fix/setup-check-no-internet-no-error
Do not show a internet connectivity warning if internet access is dis…
2019-06-28 10:54:29 +07:00
Christoph Wurst 20afe94297 Do not show a internet connectivity warning if internet access is disabled
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-06-27 10:51:59 +07:00
Christoph Wurst 409acf1131
Fix js l10n registration to also work with more than one bundle
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-06-26 10:07:21 +07:00
Jan-Christoph Borchardt d14c0f2ed7
Move font from Nunito to Noto Sans
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-06-22 11:23:44 +07:00
Julius Härtl 6d848b545d
Adjust jsunit tests for new toast library
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-06-07 07:32:48 +07:00
Christoph Wurst 0f3e438f7c
Move OC.theme to the bundle and deprecate oc_defaults
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-14 11:14:29 +07:00
Christoph Wurst a5ec4a9af4
Move l10n functions to the bundle
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-13 18:42:49 +07:00
Christoph Wurst 51d49c3134
Move initCore to the bundle
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-10 13:47:21 +07:00
Morris Jobke c8f2198aa0
Remove recommendation for opcache on CLI
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-05-09 12:25:53 +07:00
Christoph Wurst 278c281cc9
Deprecate oc_current_user, fix usage and move currentUser to the bundle
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-08 09:44:51 +07:00
Christoph Wurst acf0ca1541
Move OC.appswebroots to the bundle and deprecate oc_appswebroots
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-07 14:03:14 +07:00
Christoph Wurst 249a5dbdba
Move oc_webroot, OC.webroot and OC.getRootPath() to the bundle
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-06 17:55:30 +07:00
Christoph Wurst 42be4b7765
Move oc_appconfig/OC.appConfig to the main bundle
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-06 13:36:23 +07:00
Christoph Wurst d68be1ae4d
Deprecate oc_isadmin and move OC.isUserAdmin() to the bundle
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-03 15:49:49 +07:00
Christoph Wurst 9b79aa664d
Move oc_config to the bundle
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-02 09:42:32 +07:00
Christoph Wurst e7a190179f
Change oc_config usage to OC.config
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-02 08:46:43 +07:00
Morris Jobke d40b21ac81
Merge pull request #14603 from nextcloud/fix/noid/add-setup-check-for-s3-temp-path
Show a setup warning in case S3 object storage is used as primary storage
2019-03-08 18:03:49 +07:00
Morris Jobke 060b637b70
Show a setup warning in case S3 object storage is used as primary storage
* checks for at least 50 GB of free space

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-08 13:38:39 +07:00
Julius Härtl d768634616
Fix domparser on phantomjs
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-07 10:45:47 +07:00
Julius Härtl e5162fb9af
Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-01 20:57:01 +07:00
Morris Jobke 6c7ccbecbf
Add setup check for missing UTF8MB4 on mysql
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-02-28 16:46:23 +07:00
Christoph Wurst e930a0ccbe
Search sharees on lookup server when explicitly requested by user
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-02-26 19:44:49 +07:00
Morris Jobke faef05730a
Add unit tests and provide better message
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-02-20 10:54:39 +07:00