485f3f495e
fix: Fix test by scanning group before using it
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-27 12:39:15 +07:00
11d36e7607
fix(security): Update CA certificate bundle
...
Signed-off-by: GitHub <noreply@github.com>
2025-02-26 02:31:09 +07:00
0fc355aa1e
ci(autochecks): Run some autochecks also on non-PHP files
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-21 12:12:29 +07:00
eb3c639c6b
bump behat/behat from 3.18.1 to 3.19.0 in /build/integration
...
---
updated-dependencies:
- dependency-name: behat/behat
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-02-18 14:31:46 +07:00
e757b649b7
fix: Fix psalm taint false-positives by small refactorings
...
Mostly make it clear that we trust admin input or that we correctly
escape strings.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 18:08:23 +07:00
640dbd0b5e
fix: Fix false-positive psalm taint errors when outputting plain text
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:23 +07:00
7c907223d2
fix: Fix psalm taint false-positive by escaping trusted input
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:22 +07:00
fa108d5b54
fix: Correctly tag json encoding in BaseResponse to fix false-positive
...
…in psalm taint analysis
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:22 +07:00
aac79bad9b
fix: Move config.php taint trust upstream directly in OC\Config class
...
This solves some false-positive psalm taint errors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:20 +07:00
25f38883f1
fix: Work around false-positive psalm taint error calling print_r in admin_audit
...
Same issue as var_export, print_r is listed as sink but it’s not when
using return:true. Anyway, using the logger context feature is better.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:08 +07:00
fec865cc29
chore: Correctly flag json encoding methods as escaping html and quotes
...
Especially with JSON_HEX_TAG it’s perfectly fine to echo JSON, and we
only use it in JSON output anyway.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:07 +07:00
964bc960f8
chore: Update psalm-baseline-security.xml
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 16:27:13 +07:00
007335dadf
chore(rector): Enable Nextcloud 25 set for the apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:45:39 +07:00
ee48cafd20
Merge pull request #50689 from nextcloud/fix/migrate-dav-to-events
...
fix(dav): Migrate from hooks to user events
2025-02-13 10:24:05 +07:00
747bf1a241
fix(transifex): Adjust check for translation of apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-11 07:19:46 +07:00
a4d7623ed7
chore: Update psalm baseline
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-10 14:52:18 +07:00
93c72f5675
Merge pull request #50660 from nextcloud/fix/mime-int
...
fix: make sure we process mime extensions as string
2025-02-06 16:13:27 +07:00
2a0f81da53
fix(provisioning_api): Correct limit for `editUser`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 11:58:24 +07:00
729cdf6818
fix(FediverseAction): Ensure valid fediverse links are generated
...
Harden also for existing values of the profile.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 11:58:24 +07:00
6baafd82b6
fix: make sure we process mime extensions as string
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-05 12:35:41 +07:00
73dc0f0f19
fix(sharing): Ensure download restrictions are not dropped
...
When a user receives a share with share-permissions but also with
download restrictions (hide download or the modern download permission attribute),
then re-shares of that share must always also include those restrictions.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-04 15:39:14 +07:00
8ad7350a6b
Merge pull request #50137 from nextcloud/dependabot/composer/build/integration/behat/behat-3.18.1
2025-01-30 00:11:21 +07:00
b48ee2e924
fix: Harden files scanner for invalid null access
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:08:46 +07:00
0baab8fd98
test: Reset sharing app config after test
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 16:40:50 +07:00
253f4345f1
fix(files_sharing): Respect permissions passed when creating link shares
...
Given:
User creates a link or email share with permissions=4 (create only = file drop).
Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.
Solution:
Respect what the user is requesting, create a file drop share.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 16:40:50 +07:00
2f862d1fcb
Merge pull request #50221 from nextcloud/add-integration-tests-for-moving-a-file-from-and-to-a-shared-folder
2025-01-27 17:03:04 +07:00
b59c71ccf8
test: Add integration tests for moving a file from and to a shared folder
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-01-27 14:13:07 +07:00
c1655bcde7
fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-27 12:46:15 +07:00
eea91fa1ba
fix(TemplateLayout): `core` is not an app but the server itself
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-24 15:10:23 +07:00
d3126cd1bb
fix(dav): default calendar and address book not created on first login
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-23 22:02:52 +07:00
abd3cb60fc
fix(files): more conversion tests and translate error messages
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-17 18:22:58 +07:00
2de855f0bc
Merge pull request #50162 from nextcloud/fix/improve-ldap-avatar-handling
...
Improve ldap avatar handling
2025-01-16 21:43:29 +07:00
19ce362896
chore: add file conversion integration tests
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-16 18:55:44 +07:00
a741c6cfa1
chore(psalm): Update baseline to remove fixed errors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-13 17:34:11 +07:00
f5ee945bbf
build(deps-dev): bump behat/behat in /build/integration
...
Bumps [behat/behat](https://github.com/Behat/Behat ) from 3.16.0 to 3.18.1.
- [Release notes](https://github.com/Behat/Behat/releases )
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Behat/Behat/compare/v3.16.0...v3.18.1 )
---
updated-dependencies:
- dependency-name: behat/behat
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-01-11 02:33:07 +07:00
669e6cadd6
chore(federation): cleanup SettingsController and legacy AddServerMiddleware
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-09 15:39:01 +07:00
b434750cb2
chore(federation): add trusted server auto accept integration tests
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-09 12:54:51 +07:00
b64b106c13
Merge pull request #49966 from nextcloud/block-dav-move-parent
...
fix: block moving files to it's own parent with dav
2025-01-07 10:24:06 +07:00
8953f44534
Merge pull request #50035 from nextcloud/fix/http/jsonresponse-data-type
...
fix(HTTP): Adjust JSONResponse data type
2025-01-07 06:39:14 +07:00
757076af29
fix: explicitly ignore nested mounts when transfering ownership
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-06 14:45:35 +07:00
3624923af2
fix(HTTP): Adjust JSONResponse data type
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-04 00:58:54 +07:00
9193cd664e
fix: block moving files to it's own parent with dav
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-03 15:30:20 +07:00
63f3309993
fix(logger): Prevent infinite recursion with log.condition => matches
...
When we need to check the log condition for a user matches,
there is a risk that something on the way checks the log level
and would result in an infinite loop.
So we simply check if it's a nested call and use the default
warning level in that case.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-03 10:04:51 +07:00
ec26a4449c
fix(security): Update CA certificate bundle
...
Signed-off-by: GitHub <noreply@github.com>
2025-01-01 02:33:07 +07:00
7bc8eb3007
chore: update baseline
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-27 15:18:09 +07:00
22051a73c1
feat(login): add origin check at login
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-12-05 09:51:53 +07:00
f08d053290
fix(ocm): switching to IdentityProof
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-12-04 09:30:55 +07:00
4591430c9c
feat(ocm): signing ocm requests
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-12-04 09:30:55 +07:00
dd3fa88b36
chore: check enums for since and experimental comments
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-12-02 14:30:18 +07:00
bcb8b85fc6
Merge pull request #49224 from nextcloud/build/psalm/unstable-namespace
2024-11-29 12:01:07 +07:00
dd101dd0f7
Merge pull request #49515 from nextcloud/bugfix/noid/boolean-false-in-multipart-form-data
...
fix(controller): Fix false booleans in multipart/form-data
2024-11-28 14:46:16 +07:00
2b6da9eaee
ci: Remove obsolete baseline entry
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-28 13:57:24 +07:00
d6fa2100e1
test(ExternalStorage): Send basic auth during integrations tests
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-11-28 11:12:29 +07:00
6822cf9731
fix(security): Update CA certificate bundle
...
Signed-off-by: GitHub <noreply@github.com>
2024-11-27 02:34:37 +07:00
6b383faf41
Revert "fix(dav): Always respond custom error page on exceptions"
...
This reverts commit 9992e7d439
2024-11-22 11:55:25 +07:00
65e24f7def
feat(user-prefs): IUserPreferences
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
9e327a5890
fix(apps-store): Remove apps from force-enabled state when uninstalled
...
If an app is force-enabled and then uninstalled the force-enabled state was kept.
This is now removed, so when the app should be re-installed the compatibility should be reevaluated.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-18 14:09:54 +07:00
c179e78aeb
refactor(user_ldap): Remove Application::registerRoutes() usage
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-14 11:43:46 +07:00
95766246ea
Merge pull request #49244 from nextcloud/feat/profile-app
2024-11-14 11:07:06 +07:00
158299b3d7
fix(profile): make sure the app cannot be disabled as it was in core
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-14 10:25:10 +07:00
fc0c61458e
test(integration): Correctly cleanup logs
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-14 08:12:20 +07:00
72571a19dd
build(psalm): Configure unstable namespace
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-12 11:46:13 +07:00
8e3f85111d
chore(deps-dev): Bump behat/behat in /build/integration
...
Bumps [behat/behat](https://github.com/Behat/Behat ) from 3.15.0 to 3.16.0.
- [Release notes](https://github.com/Behat/Behat/releases )
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Behat/Behat/compare/v3.15.0...v3.16.0 )
---
updated-dependencies:
- dependency-name: behat/behat
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-11-09 02:09:33 +07:00
86784ad873
ci: Bump behat/behat as well
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-30 09:04:05 +07:00
37966c645e
ci: Align integration test dependencies with 3rdaprty/
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-29 22:54:30 +07:00
6d2c63ecff
fix(settings): Do not use `null` on `string` parameter for sharing disclaimer
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 20:12:32 +07:00
f25a71806b
fix(apps): Fix wrong or missing casts
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-23 17:08:29 +07:00
61e3fa054d
build: Show the actual string
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-23 09:39:57 +07:00
f660e4c09f
build: Print RTL limited characters in translation-checker
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-22 13:03:06 +07:00
070adc1131
Merge pull request #48790 from nextcloud/refactor/apps/constructor-property-promotion
2024-10-22 12:47:45 +07:00
582af10e0b
Merge pull request #48756 from nextcloud/build/autoloader/remove-noisy-changes
2024-10-22 11:20:10 +07:00
e8426996f5
fix(psalm): Fix some newly detected issues
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
a1681b0756
chore(db): Apply query prepared statements
...
Fix: psalm
fix: bad file
fix: bug
chore: add batch
chore: add batch
chore: add batch
fix: psalm
2024-10-17 20:30:47 +07:00
c254855222
chore(db): Correctly apply query types
...
fix: psalm
fix: error
fix: add batch
fix: fatal error
fix: add batch
chore: add batch
chore: add batch
fix: psalm
fix: typo
fix: psalm
fix: return bool
fix: revert Manager
2024-10-17 09:21:07 +07:00
0528eaa71b
build(autoloader): Remove noisy changes when regenerating
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-17 09:20:36 +07:00
be80943686
chore: Update baseline after rector refactoring
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:47:38 +07:00
4ff9b3e0ce
feat(rector): Skip classes with a name too common from auto use statement
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:38:21 +07:00
28153443a5
chore(rector): Add rule to import Nextcloud classes in all files
...
We skip all files outside of OC/OCA/OCP from "use" auto-import because
it’s not always desirable to import classes when they have generic
names, so it should be the developer choice.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:38:05 +07:00
262ed0ffeb
Merge pull request #48650 from nextcloud/fix/shipped-app-version
...
fix: Shipped apps should include the Nextcloud version in the cache buster
2024-10-14 17:22:24 +07:00
980ab1f56b
fix: Shipped apps should include the Nextcloud version in the cache buster
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-14 16:04:13 +07:00
07449847e1
fix(appmanager): Fix tainted file path when loading appinfos
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-14 14:33:19 +07:00
bbc5d32c8e
fix(dav): Public WebDAV endpoint should allow `GET` requests
...
`GET` should be allowed even without Ajax header to allow downloading files,
or show files in the viewer. All other requests could be guarded, but this should not.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-09 17:10:52 +07:00
c0ffe39421
ci: Update psalm-baseline
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:26 +07:00
570a9e208f
ci: Add psalm baseline for security and make CI fail on change
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-01 00:11:07 +07:00
99d507c259
Merge pull request #48455 from nextcloud/update-phpdoc-for-folder-get
...
update docs for Folder.get and call for Folder.nodeExists
2024-09-30 23:02:53 +07:00
3db20c8b00
docs: Folder.get throws a NotPermittedException exception
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-30 19:00:36 +07:00
9be2f060f9
fix: provision api's status codes
...
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-09-30 17:19:32 +07:00
3a865813d4
fix(psalm): Update baseline
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-30 12:47:26 +07:00
0f6760c810
feat(files): Make the files download action use WebDAV zip download
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 13:18:29 +07:00
d66e16b07e
feat(dav): New `ZipFolderPlugin` which allows to download folders using GET requests
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 13:18:23 +07:00
234c44a77e
fix(l10n): Fix list of RTL languages
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-27 12:50:30 +07:00
227609a954
fix(IStorage): Use false instead of bool intersection type to match implementations
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 18:13:03 +07:00
7cdccd058f
fix(Storage): Fix IStorage return types
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 18:13:03 +07:00
06b0608c61
fix(security): Update CA certificate bundle
...
Signed-off-by: GitHub <noreply@github.com>
2024-09-25 02:30:55 +07:00
242f89afb3
ci: Restrict RTL characters to RTL languages
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 16:59:51 +07:00
8927510685
Merge pull request #48223 from nextcloud/feat/add-rector-config
...
Add rector config
2024-09-23 15:10:30 +07:00
98efa3bda8
chore(rector): Move rector.php into the build folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-23 11:58:27 +07:00
3119108654
chore(files): Remove legacy UI scripts now that everything is migrated to Vue
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-20 13:46:39 +07:00
5df5a979ef
fix(psalm): Update psalm baseline
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 17:04:21 +07:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
bfb0160950
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-09-19 02:32:53 +07:00
b24e02e5df
fix(core): profile design and pronouns support
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-18 00:15:19 +07:00
26abc86eca
feat: add profile pronouns
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-17 22:20:36 +07:00
f6c2ae298b
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-09-17 02:18:56 +07:00
f5512ca062
Merge pull request #47792 from nextcloud/chore/use-public-api-helper
2024-09-16 11:20:58 +07:00
edb9a0360e
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-09-16 02:37:08 +07:00
5ec41c0988
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-09-15 02:37:53 +07:00
a194aa543b
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-09-14 02:36:49 +07:00
ce5fd09e75
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-09-13 02:32:35 +07:00
2b5dd11d97
Merge pull request #47339 from nextcloud/fix/leave-share-instead-of-delete
...
fix: Display 'Leave share' instead of 'Delete'
2024-09-11 13:42:15 +07:00
bb37954abb
fix(files_sharing): adjust permissions from custom edit and delete check methods
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-11 13:17:42 +07:00
c1d1fe918d
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-09-10 02:35:13 +07:00
1d16bc47ff
fix(files_sharing): Handle download permission the same way for public and internal shares
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
ede38709b5
chore(files): Use public API where possible
...
This is not fixing all issues in the helper,
but at least where possible use the public methods.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-05 23:00:27 +07:00
8af7ecb257
chore: adjust code to adhere to coding standard
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:23:38 +07:00
9992e7d439
fix(dav): Always respond custom error page on exceptions
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-05 16:17:32 +07:00
f1706df367
Merge pull request #46859 from nextcloud/fix-status-check-and-saving-of-external-storages
2024-09-04 11:33:30 +07:00
bd4de5208d
fix: Fix unmodified placeholder replacing the actual value when updating
...
When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 09:46:17 +07:00
8350aef723
test: Add integration tests for saving external userglobal storages
...
As the external storage uses the Nextcloud server itself the number of
workers of the PHP process running the Nextcloud server had to be
increased. Otherwise if a request is sent for the external storage while
handling a request from the integration tests a deadlock would occur.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 09:46:17 +07:00
a30d9a7926
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-09-04 02:29:30 +07:00
6cfa388e34
Merge pull request #47596 from nextcloud/fix/test/provisioning-enabled-apps
...
fix(test): Fix provisioning enabled apps
2024-08-29 11:16:24 +07:00
faeb2f0f43
chore: Add stylelint rules to verify we only use logical properties
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-29 08:35:06 +07:00
54e6103d31
fix(test): Fix provisioning enabled apps
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-08-29 09:43:03 +07:00
e0b81410f4
chore: Add `vitest.config.ts` as expected and remove Jest config
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 17:27:22 +07:00
dd165cf53a
chore: add .git-blame-ignore-revs as expected file
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:35:40 +07:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
e817bc6d3c
Merge pull request #47356 from nextcloud/fix/add-webhook_listeners-to-shipped-apps-lists
...
chore: Add webhook_listeners to list of shipped apps
2024-08-20 22:52:52 +07:00
4f70998e35
Merge pull request #47351 from nextcloud/fix/build/update-apps
2024-08-20 20:55:52 +07:00
cd0217b2bd
fix(CI): Add a check that all server apps are translated
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-20 16:45:12 +07:00
0e3ca084c4
fix(build): Allow update-apps.sh script to work with non-master branches
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-08-20 15:33:00 +07:00
acca93e793
chore(build): Remove old Drone CI signed-off checker
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-08-20 15:10:49 +07:00
4bbcbc5206
feat: Make `ISharedStorage` public API and reuse where possible
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-12 11:42:10 +07:00
cb1b366baf
fix(dav): Ensure share properties are also set on public remote endpoint
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-12 11:28:03 +07:00
d2338abe8a
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-08-07 02:29:23 +07:00
1cc0e753fa
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-08-03 02:31:40 +07:00
a6d421e767
chore: Remove deprecated legacy search backend
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-01 12:33:18 +07:00
2d8f0b0559
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-08-01 02:31:50 +07:00
13d2b67674
Merge pull request #46834 from withbest/master
...
chore: fix some comments
2024-07-29 11:37:57 +07:00
dd08f93202
chore: fix some comments
...
Signed-off-by: withbest <seekseat@outlook.com>
2024-07-29 14:43:27 +07:00
a94249d1d5
build(psalm): Enforce named attribute arguments
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-27 22:36:18 +07:00
8c1cbaa8c3
build(deps-dev): bump guzzlehttp/guzzle in /build/integration
...
Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle ) from 7.9.1 to 7.9.2.
- [Release notes](https://github.com/guzzle/guzzle/releases )
- [Changelog](https://github.com/guzzle/guzzle/blob/7.9/CHANGELOG.md )
- [Commits](https://github.com/guzzle/guzzle/compare/7.9.1...7.9.2 )
---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-07-27 01:13:38 +07:00
4b9967f872
chore(deps-dev): bump guzzlehttp/guzzle in /build/integration
...
Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle ) from 7.8.1 to 7.9.1.
- [Release notes](https://github.com/guzzle/guzzle/releases )
- [Changelog](https://github.com/guzzle/guzzle/blob/7.9/CHANGELOG.md )
- [Commits](https://github.com/guzzle/guzzle/compare/7.8.1...7.9.1 )
---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-07-20 01:13:01 +07:00
725736a754
chore(integration): add file request tests
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-19 07:35:51 +07:00
7878f1ceea
fix: drop outdated handlebar comments template
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-18 20:15:39 +07:00
54c700bc74
Merge branch 'master' into support-direct-appapi-requests
2024-07-16 20:42:51 +07:00
696ece2f52
feat: webhooks_listeners app support for sending direct requests to ExApps using AppAPI.
...
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2024-07-16 19:36:43 +07:00
9b84831c8d
fix(files_sharing): adjust IAttributes API and files_versions
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
2d8b64957c
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-07-12 02:25:57 +07:00
a229723b8c
feat: Add new forbidden filename options to Capabilities
...
Allow clients to access the new filename validation options
and make frontend name validation possible.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-11 13:31:54 +07:00
abd8708a96
ci(psalm): update baseline
...
prefer to keep this check as PublicEmitter should be dropped sooner or
later
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-07-10 13:48:03 +07:00
074d10cc09
fix(security): Update CA certificate bundle
...
Signed-off-by: GitHub <noreply@github.com>
2024-07-03 02:19:46 +07:00
4680bc47c2
Merge pull request #46048 from nextcloud/automated/noid/master-update-psalm-baseline
...
[master] Update psalm-baseline.xml
2024-06-24 09:58:08 +07:00
5ef451f409
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-06-24 02:27:17 +07:00
957a00b9de
chore: remove chunking-v1
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-19 16:57:42 +07:00
52171610c8
chore: Switch order of license texts in `.license` files
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-18 17:28:23 +07:00
d67eb8ce4e
chore: Adjust SPDX tool to multiple line licenses instead of `AND` chained
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-18 16:55:14 +07:00
4ca19639fa
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-06-17 02:26:44 +07:00
876beec5a7
chore: Add webpack plugin to properly extract licenses used in compiled assets
...
This will create proper extracted license information for assets and stores it in `fist/file.js.license`.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-16 19:06:52 +07:00
bcbef7aaa8
Update build/npm-post-build.sh
...
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2024-06-14 08:53:02 +07:00
daa1646b3d
chore: Adjust post-build script to add license files for sourcemaps on build
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-14 07:30:16 +07:00
dc9df43214
ci: Migrate CalDAVTester CI scripts to GitHub
...
We can finally shut of drone workers.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:20:37 +07:00
1e04619675
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-06 22:53:41 +07:00
91227c908b
Merge branch 'master' into refactor/OC-Server-getHTTPClientService
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-05-30 14:21:45 +07:00
4bd9bc7b06
feat(files): Use receiving users language for the ownership transfer target folder
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-29 20:19:58 +07:00
e07a190641
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-27 14:53:40 +07:00
d41d885713
test(Sharing): Integration test for no expiration set date for share
...
- Verify that explicitly sending empty `expireDate` param to server overwrite default
and sets not expiry date, if non is enforced.
- Update tests to avoid converting empty string to date.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-05-23 14:11:34 +07:00
1f7e2ba599
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-13 17:41:36 +07:00
0d52697f8f
fix: revert rename changes
...
see #45250
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-10 19:16:41 +07:00
3a161f74fb
fix: move SPDX info of generated files to dep5 definition
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-10 11:07:54 +07:00
789dfacc7c
chore(build): Add changed file set on root level
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-10 11:07:53 +07:00
1df96b0417
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-10 11:07:50 +07:00
9d60ec59aa
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-05-07 02:26:18 +07:00
4d021da4e2
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-05-02 02:19:52 +07:00
8b829fe18a
build(deps-dev): bump phpunit/phpunit in /build/integration
...
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit ) from 9.6.18 to 9.6.19.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases )
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/9.6.19/ChangeLog-9.6.md )
- [Commits](https://github.com/sebastianbergmann/phpunit/compare/9.6.18...9.6.19 )
---
updated-dependencies:
- dependency-name: phpunit/phpunit
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-04-30 13:26:28 +07:00
78e346208c
chore: Update baseline to include new 3rdparty psalm errors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:38:47 +07:00
b44e46e688
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-04-22 02:18:46 +07:00
1a6079e041
chore(tests): Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-04-17 02:19:37 +07:00
8177fc8aac
chore: Use stubs from PHP 8.1
...
Directly copied stubs for php ext folder from PHP-8.1 branch
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-09 10:01:47 +07:00
b70180a5e4
chore: Add 3rdparty error to baseline. Also removed fixed errors.
...
The CDATA stuff comes from a psalm new version, nothing to worry about,
both syntax are equivalent.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-08 11:29:09 +07:00
ce5820fd05
Merge pull request #43808 from nextcloud/automated/noid/master-update-psalm-baseline
...
[master] Update psalm-baseline.xml
2024-04-05 14:40:03 +07:00
5c8baa52b9
fix: Update psalm baseline to ignore `setKey` being internal of `phpseclib`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-05 12:32:40 +07:00
1043c70f00
chore: Update psalm baseline
...
Co-authored-by: GitHub <noreply@github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-04 23:23:11 +07:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
bee4aab575
build(deps-dev): bump phpunit/phpunit in /build/integration
...
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit ) from 9.6.17 to 9.6.18.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases )
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/9.6.18/ChangeLog-9.6.md )
- [Commits](https://github.com/sebastianbergmann/phpunit/compare/9.6.17...9.6.18 )
---
updated-dependencies:
- dependency-name: phpunit/phpunit
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-03-23 03:16:05 +07:00
1aa84ccf0b
fix(security): Update CA certificate bundle
...
Signed-off-by: GitHub <noreply@github.com>
2024-03-12 02:11:07 +07:00
53ef6c5f71
feat(dav): update a principal's schedule-default-calendar-URL
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-02-28 14:51:10 +07:00
0d7efc79e4
chore(deps-dev): bump phpunit/phpunit in /build/integration
...
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit ) from 9.6.16 to 9.6.17.
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/9.6.17/ChangeLog-9.6.md )
- [Commits](https://github.com/sebastianbergmann/phpunit/compare/9.6.16...9.6.17 )
---
updated-dependencies:
- dependency-name: phpunit/phpunit
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-02-24 16:19:41 +07:00
dce69154ba
enh(sharing): enable unsharing for sharees for DAV shares (addressbooks and calendars)
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-02-15 18:01:12 +07:00
9a87442827
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-02-15 02:22:14 +07:00
887c061fc8
fix(OCP): Check for typos in "deprecated"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-14 20:50:07 +07:00
132887a670
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-02-10 02:19:27 +07:00
3c42a3e3db
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-02-06 02:14:41 +07:00
3b8e3e7300
chore: Update psalm baseline
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-05 11:15:15 +07:00
ee829a302f
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2024-02-05 11:15:15 +07:00
52cc18efc0
fix(tests): Ensure ldap server can be reached in integration tests on GitHub Actions and other improvments
...
* Run integration tests for every pull request
* Also print docker logs of service containers (ldap, redis)
* Ensure consistent `datadir` for test assertions
* Test openldap features separatly
* Only the LDAP tests rely on `/dev/shm` while `federated.feature` rely on real directory access
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-26 13:53:34 +07:00
34ea298843
Fix "Creation of dynamic property CommandLineContext::$…BaseUrl is deprecated in CommandLineContext.php on line 41"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-26 13:53:32 +07:00
cc4e2f9e38
Reduce the output on github CI
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-26 13:53:32 +07:00
d7e249874e
Ensure the testing app is enabled
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-26 13:53:31 +07:00
a1e9c6f71d
Remove library that is unmaintained since 2015 and was merged in the behat core
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-26 13:53:31 +07:00
Côme Chilliet
nextcloud-command
Joas Schilling
dependabot[bot]
Côme Chilliet
John Molakvoæ
Ferdinand Thiessen
skjnldsv
Kate
Daniel Calviño Sánchez
Richard Steinmetz
Arthur Schiwon
Stephan Orbaugh
Joas Schilling
Robin Appelman
provokateurin
Benjamin Gaussorgues
Maxence Lange
Daniel Kesselberg
Louis Chemineau
Git'Fellow
Hamza Mahjoubi
Anna Larch
Andy Scherzinger
Julius Härtl
withbest
Alexander Piskun
fenn-cs