6ef5958007
Fix AppSettingsController.php overwriting currentLanguage
...
Fix for CurrentLanguage being overwritten by currentVersion thus breaking App-View
Signed-off-by: 1 Man Projects <reed@1manprojects.de>
2023-12-05 20:24:35 +07:00
51758117a7
Migrate database pending bigint conversions check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-28 14:07:47 +07:00
1b547c7db8
Migrate missing primary key database check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +07:00
ad88c04f2d
Migrate missing index database check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +07:00
2cb1c0f2dc
Migrate missing column database check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +07:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
0107c7ea24
Migrate Forwarded For Headers check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 11:36:42 +07:00
fe8b5d47ae
Migrate Bruteforce Throttle check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-13 16:26:59 +07:00
7495236034
Migrate memory_limit check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-13 15:55:46 +07:00
00d3856b92
Revert "Migrate code integrity to SetupCheck API"
...
This reverts commit aa2d315d95d37b48752d0e92d0ce79913be1d4f1.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:04 +07:00
0fd5ed9854
Migrate 32bit check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +07:00
ac3da13b38
Migrate Freetype check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +07:00
086d3ceecc
Migrate code integrity to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +07:00
147b29fca2
Migrate Randomness secure check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +07:00
ddd13a90d8
Migrate memcache check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:02 +07:00
6911dc30e6
Migrated both file locking checks to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +07:00
f9770b8ef2
Remove duplicate fileinfo PHP module check
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +07:00
3c75075eba
Migrate database transaction level check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +07:00
5957a2bf6b
Migrate email test to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +07:00
506f3961ec
Remove duplicated ReadOnlyConfig setup check
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +07:00
dec52f6979
Migrate getenv test to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +07:00
d0ed5ea2f3
Merge pull request #40889 from nextcloud/feat/check-for-more-php-modules
...
Check for more php modules
2023-10-26 19:13:28 +07:00
2b7f78fc2e
Merge pull request #40326 from nextcloud/enh/text-to-image-api
...
Implement TextToImage OCP API
2023-10-26 15:53:30 +07:00
db8e57a727
Don't duplicate notification warning
...
Ref https://github.com/nextcloud/notifications/pull/1699
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-26 09:46:28 +07:00
1bdf952fde
Make sure that OC interfaces returns OC interfaces for backward compatibility
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-23 11:08:23 +07:00
9787f9dba0
enh(Text2Image): Add AI settings section to text2image
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-10-22 11:10:24 +07:00
0c346849f3
Migrate missing PHP modules check to new API and improve it
...
Test all modules listed as required in our documentation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 15:58:45 +07:00
efa2dfa641
Add OCP interface for SetupCheckManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:02 +07:00
bd37067821
Migrate InternetConnectivity check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:01 +07:00
05cb1415e1
Merge setupchecks from new API into old UI
...
This will allow migrating checks to the new API without touching the UI
for now.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:01 +07:00
8bfa0935b4
Migrate NeedsSystemAddressBookSync to new ISetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:00 +07:00
a4618cfea0
Move existing setup checks to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:00 +07:00
c71e47f5c3
Progress
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-10-19 11:43:58 +07:00
eb1d612d96
Add api to register setup checks
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-10-19 11:43:58 +07:00
e5b11ced4a
address review
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-10-06 16:22:02 +07:00
6439fdf5b6
Move inline docs to online documentation
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-10-05 15:42:47 +07:00
dd3cd29224
Merge pull request #39175 from shdehnavi/settings_app_users_controller_square_bracket_syntax
...
use square bracket syntax to modify array
2023-09-27 20:31:11 +07:00
c2d45cb172
Add single status code descriptions for OpenAPI
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-09-27 08:05:21 +07:00
0a9371f99f
Migrate applications away from deprecated ILogger
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-21 11:57:21 +07:00
56419d94f8
enh(db): provide database providers via API
...
To avoid leaking internals (OC), wrap the getDatabasePlatform and provide the
associated constants
fixes https://github.com/nextcloud/server/issues/30877
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-19 11:56:44 +07:00
7f11ee8c4a
fix(CardDAV): only run upgrade sync if 1000 users or less
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-26 17:21:50 +07:00
bed3ffb312
feat(admin): Show an error when the admin is throttled
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:40:24 +07:00
93f0399a92
fix(memcache): Fix comparison of Memcache configs to classes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-16 16:05:50 +07:00
487f5963a1
Use Server::get instead of new to avoid troubles with encryption constructors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-08 09:14:16 +07:00
f72f3f7df4
AI admin settings: strict_types
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-08-02 12:37:35 +07:00
a840e8c6e5
AI admin settings: Add save mechanism
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-08-02 12:37:35 +07:00
fc9780a41d
First pass at ai admin settings
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-08-02 12:37:35 +07:00
ab70bbd3ff
fix(db)!: Remove private legacy event because we can not keep it
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:35 +07:00
bd0a149a4f
feat(dispatcher): Add typed event for "db:add-missing-primary-keys"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:32 +07:00
2eded24eff
feat(dispatcher): Add typed event for "db:add-missing-columns"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:32 +07:00
0411cc64aa
Merge pull request #38606 from fsamapoor/replace_strpos_calls_in_settings_app
...
Refactors "strpos" calls in /apps/settings
2023-07-24 12:52:21 +07:00
925bcebcb6
feat: Add public event for missing indices
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-07-14 13:11:22 +07:00
da7062b939
settings: Add OpenAPI spec
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-10 17:06:32 +07:00
8850c66ab8
use square bracket syntax to modify array
...
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-07-05 21:36:45 +07:00
8778f2912f
Merge branch 'master' into replace_strpos_calls_in_settings_app
...
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-12 16:52:06 +07:00
c93be182dc
Merge pull request #38543 from fsamapoor/use_null_coalescing_operator
...
Uses "Null Coalescing Operator" to improve code readability.
2023-06-12 09:42:43 +07:00
ff0b3feb2e
Refactors "strpos" calls in /apps/settings to improve code readability.
...
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-05 14:39:40 +07:00
5a23b429dd
feat: remove check for OpenSSL 1.0.1d and 1.0.2b
...
OpenSSL 1.0.1d: 2013-02-05
OpenSSL 1.0.2b: 2015-06-11
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-04 18:44:47 +07:00
716a659468
Uses "Null Coalescing Operator" to improve code readability.
...
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-05-31 14:51:52 +07:00
f5c4f55576
Merge pull request #37451 from Fenn-CS/fix/36437/deprecate-php-8.0
...
Deprecate PHP8.0
2023-04-19 15:28:12 +07:00
60a710c91c
Deprecate PHP8.0
...
PHP8.0 would stop receiving security support on 26 Nov 2023
hence this deprecation. Next, is the eventual drop of PHP8.0 before its EOL.
This commit also updates the message type from INFO to WARNING if the php
on file has reached its EOL.
See: https://www.php.net/supported-versions.php
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-04-17 23:45:59 +07:00
80645a591a
add an admin check for db file locking
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 12:51:33 +07:00
d9f8522003
Fix types for reading and writing config values
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +07:00
35ea5025dd
check-setup: recommend exif extension
...
JPEG previews are not correctly oriented when exif is not enabled
along with other issues. There's no easy way to discover this either.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-03-24 18:30:37 +07:00
0cfbe54a5a
Create headings for settings pages
...
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-03-07 17:51:19 +07:00
7e725c5d94
Check for opcache.file_cache_only=1
...
which disables shared memory based OPcache with disk file cache used only, if enabled. In this case, "opcache.memory_consumption" and others do not apply, so show the correct performance recommendation to enable memory cache.
Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-15 18:55:50 +07:00
dde5c46a3e
Migrate to Symfony Mailer
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-02 10:30:06 +07:00
03390ee791
Fix interned strings buffer check if 0 free bytes
...
With #32902 it was meant to be avoided to recommend raising the interned strings buffer size above a quarter of the total OPcache size. This works as long as there is at least 1 byte free, but does not apply if the buffer is filled completely.
This commit switches the conditions so that the interned strings buffer size must be smaller than a quarter of the total OPcache size for the warning to be shown. That the buffer must be either filled completely or by more than 90% remains untouched.
Signed-off-by: MichaIng <micha@dietpi.com>
2023-01-23 08:55:35 +07:00
7ebbb6b2ca
Remove workarounds specific to 7.4
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:08 +07:00
b4a29644cc
Add a const for the max user password length
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-04 11:23:43 +07:00
7f44a66296
Fix case sensitivity of email when saving settings
...
Otherwise we detect a email change all the time and since email are
immutable in ldap this prevent updating other fields.
Related: https://github.com/nextcloud/server/pull/33813
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-12-16 17:47:42 +07:00
0cc50aff49
Add section-id and section-type data attributes to settings <li> navigation items
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-12-05 12:19:21 +07:00
8dcd992ad4
Merge pull request #34940 from nextcloud/feat/add-mastodon
...
Add mastodon and reorganize profile info section
2022-11-22 17:47:04 +07:00
3559334fec
Help pages: set window title for sidebar sections
...
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2022-11-22 09:31:28 +07:00
d1209d8302
Rename mastodon to fediverse
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 08:40:12 +07:00
86d9626901
Add mastodon personal info field
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-21 16:28:56 +07:00
c2cb790532
Merge pull request #34745 from nextcloud/optimize-show-apps
...
Extract $ignoreMaxApps from array_map callback in AppSettingsController
2022-11-21 15:20:11 +07:00
73c5591f68
Merge pull request #35024 from nextcloud/deprecate/php74
...
Deprecate PHP7.4
2022-11-14 20:35:54 +07:00
abaa3ef61b
Merge pull request #34485 from michaelkuhn/hasBigIntConversionPendingColumns-files_trash
...
Fix hasBigIntConversionPendingColumns missing files_trash
2022-11-11 17:09:26 +07:00
75a1721d7d
Deprecate PHP7.4
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-10 09:56:32 +07:00
f9e9cd270d
Limit-number-of-concurrent-preview-generations
...
Signed-off-by: Bowen Ding <dbw9580@live.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-11-05 16:03:01 +07:00
3eab7ca3d4
Extract $ignoreMaxApps from array_map callback in AppSettingsController
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-10-22 20:03:02 +07:00
9a205bdc84
Fix hasBigIntConversionPendingColumns missing files_trash
...
The two tables seem to have gone out of sync, causing the web interface
to miss `files_trash.auto_id` not being a bigint.
Signed-off-by: Michael Kuhn <github@ikkoku.de>
2022-10-09 13:37:05 +07:00
4207b80141
Harden some PHP functions
...
To avoid things like https://github.com/nextcloud/server/issues/26034
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-10-04 13:22:03 +07:00
cd21caf846
Merge pull request #34067 from nextcloud/timm2k-patch-1
...
Convert file_metadata.id from int(11) to bigint(20)
2022-09-15 14:03:30 +07:00
da01494a37
Add accessibility entry in user menu
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-09-14 15:05:35 +07:00
0c407b58db
Update CheckSetupController.php
...
file_metadata.id needs to be bigint(20).
Signed-off-by: timm2k <timm2k@gmx.de>
2022-09-14 10:10:12 +07:00
2397ea7219
Merge branch 'master' into fix/setting/accessibility-title
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-02 12:05:51 +07:00
9689f734e8
Merge pull request #33429 from nextcloud/port-password-vue
...
Port password settings to vue
2022-08-31 20:47:25 +07:00
60c42914d8
Port password settings to vue
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-31 17:42:36 +07:00
955b6bb82e
add a way to open the admin settings overview directly
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-08-30 15:46:09 +07:00
1a781ccf56
Fix opening Help page throws Exception
...
- Commit 458c2fa297
2022-08-24 18:55:34 +07:00
cf9b1082ed
add a setup check for 64 bit
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-07-13 09:33:33 +07:00
f99a06c89a
Don't allow setting password bigger than 469 characters
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-05 11:47:25 +07:00
f8bebb62ca
do not display the buffer_size info if the size is already set to a certain threshold
...
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
2022-06-17 22:15:28 +07:00
dfe7243338
l10n: Delete apostrophe
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-06-07 16:41:38 +07:00
1bc6fb2c58
l10n: Change to a capital letter
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-06-03 09:34:15 +07:00
046d5451b1
Improve accessibility of the title of the settings
...
Before every setting page had the same title and this is causing issues
for screenreaders since they can't differenciate the title of page. Now
a new variable is available for apps to declare the page subtitle.
This new variable is implemented for the settings app and while at it I
added a bit more type hinting to the stuff I touched :)
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-16 22:47:37 +07:00
8a2cf5bb68
Do not dispatch postSetPassword when setPassword fails
...
Also Improve error message when setPassword fails
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-05 17:21:23 +07:00
d2830612d0
l10n: Improve grammar
...
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-04-27 08:19:19 +07:00
4511bd4bf6
Merge pull request #30950 from nextcloud/enh/opcache-recommends-translation
...
Add OPcache recommendations to Transifex
2022-03-24 17:56:09 +07:00
a0c7798c7d
Limit the length of app password names
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-23 10:47:56 +07:00
31606c9861
Add OPcache recommendations to Transifex
...
Fixes: https://github.com/nextcloud/server/issues/30941
Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-22 10:42:51 +07:00
3a0b934f84
Merge pull request #31430 from nextcloud/enh/31429/improve-overwrite-cli-url-check
...
Validate `overwrite.cli.url` to be a url in setup check
2022-03-10 12:40:59 +07:00
4191a178dd
improve overwrite cli url setup check
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-09 22:26:00 +07:00
23e8ae15aa
Merge pull request #31470 from nextcloud/enh/13099/allow-disable-imagick-warning
2022-03-08 08:53:12 +07:00
7dca146b58
allow to disable the imagick warning
...
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
2022-03-07 17:35:12 +07:00
d5574cf189
allow adding protocol to domains in 'connectivity_check_domains' config
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-03-07 14:13:11 +07:00
3980322621
Merge pull request #31267 from nextcloud/enh/docs-link-for-opcache-recommends
...
Add Nextcloud docs link to OPcache recommends
2022-03-04 01:24:10 +07:00
5ac91f1cb8
Add Nextcloud docs link to OPcache recommends
...
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.
Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend.
Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-03 23:00:07 +07:00
f63eb4261f
Fix permittedPath comparison
...
Signed-off-by: Mickey Knox <mickey@netfreaks.org>
2022-03-02 22:38:11 +07:00
7c8a901b84
Cleanup admin settings js files
...
* Move admin.js to webpack, so that this use the bundled jquery files
instead of the deprecated window.$ Also fixing formatting
* Remove log.js that seems to be from a time where logreader was bundled
with server and I couldn't find an usage of it anymore
* Fix recent regression in rebuild navigation function (now not depending on
jquery anymore and bundled by webpack).
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-17 17:52:03 +07:00
b28aa52b28
Setup warning for invalid LDAP user or group UUIDs.
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-10 10:15:01 +07:00
84cf39f582
show if the mail server settings are not set or verified
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-02-03 20:16:35 +07:00
79cdb565dc
Avoid zero division in setup checks
...
Fixes: https://github.com/nextcloud/server/issues/30532
Signed-off-by: MichaIng <micha@dietpi.com>
2022-01-11 10:26:57 +07:00
82c1beaacb
Enhance and complement OPcache setup checks
...
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.
With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.
The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.
A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.
OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.
Signed-off-by: MichaIng <micha@dietpi.com>
2021-12-19 23:38:21 +07:00
19d070850b
Make sure trusted_proxies is an array
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +07:00
e55ceb2bb1
Show warning on admin settings page
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2021-10-23 00:54:50 +07:00
facb50ebcc
fix appstoreenabled check in Fetcher so it's coherent with AppSettingsController
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-10-18 12:39:43 +07:00
4b8f8c5203
Deprecate PHP7.3 for Nextcloud 23
...
* 7.3 reaches EOL shortly after the release of 23.0.0
* Nextcloud 24 will require PHP7.4
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-18 09:15:54 +07:00
664bd5802f
add 'supported'-label to all supported apps, also if they are not downloaded yet
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2021-10-06 22:17:50 +07:00
6958d8005a
Add admin privilege delegation for admin settings
...
This makes it possible for selected groups to access some settings
pages.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-09-29 21:43:31 +07:00
eb46011680
Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually
...
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +07:00
8758b36ebb
Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable
...
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +07:00
27865d03c0
use specific email getter where necessary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +07:00
07ccccecad
Only recommand for php-sodium on >= PHP 7.4
...
This is because php-sodium will solve the missing PASSWORD_ARGON2I
constant problem only on >= php 7.4, previously argon2 wasn't part of
the standard extension and was disabled on Centos/RHEL.
So installing php-sodium on php 7.2 for example wouldn't hide the
message. Tested on Fedora with php 7.4, Centos 7 with php 7.2,
Centos 8 with php 7.2 and openSUSE with php 7.4.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-08-06 14:22:09 +07:00
43e41ca532
Merge pull request #28259 from nextcloud/work/carl/sodium-check
...
Check that php was compiled with argon2 support or that the php-sodium extensions is installed
2021-07-30 17:34:10 +07:00
8e51a5feda
Check that php was compiled with argon2 support or that the php-sodium
...
extensions is installed
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-07-30 15:11:55 +07:00
416d10f76c
refs #21045 add app config to disable unlimited quota and to set max quota
...
avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed
avoid getting/setting/displaying unlimited default quota if not allowed
implement tests for unlimited quota restrictions
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-29 19:31:36 +07:00
b78f3a57d1
Migrate HintException to OCP
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 +07:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
9c6b01abeb
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-02 17:49:32 +07:00
847ed37afc
do not use private AccountManager in UsersController
...
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-25 14:35:38 +07:00
4a2775a442
Harden apptoken check
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-17 16:05:45 +07:00
aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid
...
Validate the website field input to be a valid URL
2021-04-26 13:56:01 +07:00
67dd087ce4
Fix deleting properties of user settings when not given explicitly
...
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +07:00
ac0c18327e
Fix TypeError when "email" is not given in the controller request
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +07:00
a7431817b9
Respect additional user settings not covered by the controller
...
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.
Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).
This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +07:00
8cae515daa
Use constants from interface rather than class
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +07:00
d80cc76ee7
Validate the website field input to be a valid URL
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 16:34:13 +07:00
bd2e6309b5
Merge pull request #25605 from nextcloud/trusted-proxy-warning-localhost
...
dont show trusted proxy warning when the proxy and remote are both localhost
2021-04-01 13:27:26 +07:00
5d14fd4396
Make extra user profile fields always editable
...
The fields for phone number, address, website and twitter are now
editable regardless whether federated sharing and the lookup server
are enabled or not.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +07:00
61ed57b757
Rename some parameters and methods to make the API more clear
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 20:30:29 +07:00
07095fd122
Also clear the knownUser when changing via the settings endpoint
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 19:37:10 +07:00
2afa1c5739
Merge pull request #25862 from nextcloud/techdept/psalm/some_loggers
...
Move away some ILoggers
2021-03-02 15:01:44 +07:00
38f761f25f
Move away some ILoggers
...
Makes psalm happier
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 10:47:25 +07:00
3d0dff0d2b
Fix lying docblocks
...
* typed the return
* removed unneeded temp variable
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 16:48:04 +07:00
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +07:00
bd8b1786c5
Some psalm fixes in the settings app
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 10:00:35 +07:00
7d8e9baa77
Revert "use the configured forwarded headers for the setup check"
2021-02-13 18:03:32 +07:00
1 Man Projects
Côme Chilliet
Joas Schilling
Côme Chilliet
Joas Schilling
Marcel Klehr
Carl Schwan
Simon L
Christoph Wurst
jld3103
Anna Larch
Daniel
Julius Härtl
Hamid Dehnavi
Faraz Samapoor
Andy Scherzinger
fenn-cs
Varun Patil
julia.kirschenheuter
MichaIng
Thomas Citharel
Robin Appelman
Christoph Wurst
Michael Kuhn
acsfer
Vincent Petry
timm2k
Arthur Schiwon
Valdnet
Louis Chemineau
rakekniven
John Molakvoæ
Julien Veyssier
Mickey Knox
Vitor Mattos
Bjoern Schiessle
Stefan
Gary Kim
John Molakvoæ (skjnldsv)
Roeland Jago Douma
Daniel Calviño Sánchez
Roeland Jago Douma
dependabot-preview[bot]