Commit Graph

19213 Commits (db625f01b3fdafacd2e4d110eaaa6efb69cd6eb9)

Author SHA1 Message Date
MichaIng e250aef6b4
Merge pull request #29416 from nextcloud/backport/27440/stable21
[stable21] Handle files with `is_file` instead of `file_exists`
2021-10-30 00:19:35 +07:00
Carl Schwan 00a9b0c1db Fix permissions when copying from ObjectStorage
Make sure that when a user copy a file from a directory they don't have
all permissions to a directory where they have more permissions, the
permissions are correctly set to the one from the parent taget folder.

This was caused by the ObjectStoreStorage::copyFromStorage using
the jailed storage and cache entry instead of the unjailed one like other
storages (the local one).
Steps to reproduce

+ Use object storage
+ Create a groupfolder with one group having full permission and another one
  who can just read files.
+ With an user who is in the second group, copy a file from the groupfolder to
  the home folder of this user.
+ The file in the home folder of the user will be read only and can't be deleted
  even though it is in their home folder and they are the owner. In oc_filecache,
  the permissions stored for this file are 1 (READ)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-10-28 12:55:53 +07:00
Robin Appelman 99ba96524e
more reliable return value for Watcher::checkUpdate
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-26 14:45:08 +07:00
Robin Appelman f18a76fec9
s3 external storage listing rework
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-26 14:41:46 +07:00
Nextcloud bot c89eaec9e4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-26 02:23:16 +07:00
Nextcloud bot 082d429c6e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-25 02:22:42 +07:00
MichaIng a17529b483
Merge pull request #29399 from nextcloud/backport/29378/stable21
[stable21] Make the route name error more helpful
2021-10-23 20:12:44 +07:00
acsfer eea1c23719 Handle files with is_file instead of file_exists
Should fix things like `fread(): read of 8192 bytes failed with errno=21 Is a directory`
2021-10-23 09:28:25 +07:00
Nextcloud bot a87643a9e0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-23 02:22:54 +07:00
Christoph Wurst 48d97fa865 Make the route name error more helpful
As a developer I have no clue what "Invalid route name" means. If the
exception gives me a hint I might find it easier to figure out why my
route triggers this error.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-22 20:38:58 +07:00
Vincent Petry a080c08d64
Merge pull request #29367 from nextcloud/backport/29362/stable21
[stable21] Fix security issues when copying groupfolder with advanced ACL
2021-10-22 09:56:21 +07:00
Nextcloud bot 884fcf0227
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-22 02:22:17 +07:00
Carl Schwan ec8b2a90e6 Fix security issues when copying groupfolder with advanced ACL
Using advanced ACL, it is possible that an user has access to a
directory but not to a subdirectory, so the copying use
Common::copyFromStorage instead of Local::copyFromStorage.

Fix https://github.com/nextcloud/groupfolders/issues/1692

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-10-21 16:34:46 +07:00
John Molakvoæ 6b0bdf192c
Merge pull request #29289 from nextcloud/backport/28768/stable21 2021-10-21 09:32:32 +07:00
Nextcloud bot 8a5317cbfe
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-21 02:24:37 +07:00
Nextcloud bot 8191ee34f2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-20 02:43:22 +07:00
John Molakvoæ 1493321401
Merge pull request #29182 from nextcloud/backport/29028/stable21 2021-10-19 11:11:20 +07:00
Joas Schilling 2f6bd56c93
Fix app upgrade
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-19 08:47:52 +07:00
acsfer f57bbaf146 Simplify :) 2021-10-18 08:02:44 +07:00
acsfer aeb0ad8cea Replace `file_exists()` method by `is_file()` 2021-10-18 08:02:44 +07:00
acsfer 0c1ccde7d2 Get `filesize()` if `file_exists()`
Should make sense.
2021-10-18 08:02:44 +07:00
Daniel 1ea652d611
Merge pull request #29159 from nextcloud/backport/24185/stable21
[stable21] Properly handle folder deletion on external s3 storage
2021-10-15 11:36:56 +07:00
MichaIng d2a71ca010
Merge pull request #29203 from nextcloud/backport/26688/stable21
[stable21] Add proper message to created share not found
2021-10-14 15:08:10 +07:00
Joas Schilling 7aa440b51d
Merge pull request #29197 from nextcloud/backport/29020/stable21
[stable21] Keep group restrictions when reenabling apps after an update
2021-10-13 22:24:18 +07:00
Joas Schilling 7f4b3fb68d
Keep group restrictions when reenabling apps after an update
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-13 14:12:32 +07:00
Joas Schilling fd4ff58d62
Fix translated app details
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-13 13:32:30 +07:00
John Molakvoæ (skjnldsv) d578d780e4 Default message for ShareNotFound exception
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-10-13 09:44:52 +07:00
John Molakvoæ (skjnldsv) 098d918baf Add proper message to created share not found
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-10-13 09:44:51 +07:00
Vincent Petry e229cd3d53
Merge pull request #29130 from nextcloud/backport/27886/stable21
[stable21] Keep pw based auth tokens valid when pw-less login happens
2021-10-13 08:39:27 +07:00
Vincent Petry 5735a55509
Merge pull request #29080 from nextcloud/path-prefix-filter-21
[21] generate a better optimized query for path prefix search filters
2021-10-13 08:37:28 +07:00
Robin Appelman 916a838873
[21] generate a better optimized query for path prefix search filters
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-12 15:55:57 +07:00
Bjoern Schiessle 1237d64bdb add 'supported'-label to all supported apps, also if they are not downloaded yet
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2021-10-12 11:47:33 +07:00
Vincent Petry 2bf6270ef5
Merge pull request #29037 from Hinyka/stable21
[stable21] Fix Lots of Error: file_exists(): open_basedir restriction in effect
2021-10-12 09:11:18 +07:00
Julius Härtl e59f90d6ba
Merge pull request #29134 from nextcloud/backport/28907/stable21 2021-10-11 22:23:14 +07:00
MichaIng 6039a43d13
Merge pull request #29164 from nextcloud/backport/29062/stable21
[stable21] Don't further setup disabled users when logging in with apache
2021-10-11 14:38:52 +07:00
Joas Schilling e3f59fe201
Don't further setup disabled users when logging in with apache
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-11 13:11:45 +07:00
Julius Härtl b2566e3dda Tokens without password should not trigger changed password invalidation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-11 09:33:18 +07:00
Julius Härtl df3ed040e4 Make sure that a empty directory can still be deleted when copied from another storage
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-11 08:01:08 +07:00
Daniel Kesselberg b77b1d6bbd
explicitly close source stream on encryption storage
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-10-08 14:30:27 +07:00
Daniel Kesselberg 98d3836650
explicitly close source stream on local storage
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-10-08 14:30:27 +07:00
Vincent Petry 9722bb5c54
Fix psalm issue in Encryption stream
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-10-08 12:15:04 +07:00
Tobias Assmann 4a174617eb
add spaces around operators
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
2021-10-08 08:08:28 +07:00
Tobias Assmann 4fd1b09a60
draft to prevent the invalidation of pw based authn tokens on a pw less login
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
2021-10-08 08:08:28 +07:00
Nextcloud bot 8c0fadce29
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-07 02:25:52 +07:00
Julien Veyssier 1bf46f6610 consider some config keys under 'objectstore_multibucket' as sensitive
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-10-06 07:52:40 +07:00
Daniel ee8edd308d
Merge pull request #29075 from nextcloud/bp-28473
[stable21] Fix path of file_get_contents
2021-10-06 08:46:18 +07:00
Nextcloud bot 308b48a6a5
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-06 02:21:20 +07:00
acsfer cd7eb98912
Fix path of file_get_contents 2021-10-04 21:10:53 +07:00
Julius Härtl f82c4d31ba
Merge pull request #28730 from nextcloud/backport/27540/stable21 2021-10-04 16:51:02 +07:00
Nextcloud bot 124a63e77e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-04 02:26:40 +07:00