Commit Graph

19609 Commits (da8a2e1d67508b2f3114cb95a2fad02b577b4920)

Author SHA1 Message Date
szaimen 4570bb4f65 Admin Audit - Sharing: createShare - report the full path
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-22 14:20:05 +07:00
John Molakvoæ f14b8aa34b
Merge pull request #27888 from nextcloud/fix/redis-auth 2021-07-22 12:47:26 +07:00
John Molakvoæ (skjnldsv) 6e00fe8c26
Properly support RedisCluster
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-07-22 07:42:26 +07:00
Lukas Reschke 63b4450141
Merge pull request #28082 from nextcloud/improve-exception-serializer
Sanitize more functions from the encryption app
2021-07-21 16:19:21 +07:00
Lukas Reschke b3ddc09895 Sanitize more functions from the encryption app
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-07-21 11:18:35 +07:00
Julius Härtl b6a24f87a5
Merge pull request #28077 from nextcloud/heicPerformance 2021-07-21 10:27:19 +07:00
tobiasKaminsky f62ec2b47c
Disable HEIC image preview provider for performance concerns
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-07-21 09:14:20 +07:00
John Molakvoæ (skjnldsv) ed10d85ff3
Support redis user password auth and tls encryption
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-07-20 17:57:33 +07:00
Daniel Kesselberg 74fa8f3f84
Mask password for Redis and RedisCluster on connection failure
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-07-19 19:52:25 +07:00
Tobias Assmann ee049a159b prevent the invalidation of pw based authn tokens on a pw less login
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
2021-07-16 14:31:06 +07:00
Joas Schilling f86f594a3a
Merge pull request #27860 from J0WI/alphanumeric-rnd
Introduce ISecureRandom::CHAR_ALPHANUMERIC
2021-07-16 12:46:20 +07:00
Nextcloud bot 7f572c0645
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-07-15 10:37:23 +07:00
Julius Härtl 3e67637a4a
Merge pull request #26463 from Worteks/fix-s3proxy 2021-07-14 23:32:05 +07:00
blizzz 5a22b0ac67
Merge pull request #27884 from nextcloud/enh/cloud-id-local
Allow to get a local cloud id without going through the contacts manager
2021-07-14 23:18:51 +07:00
Julius Härtl 7179002600
Allow to get a local cloud id without going through the contacts manager
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-14 16:08:05 +07:00
Julius Härtl 59f0fc0e2b
Merge pull request #27761 from nextcloud/bugfix/noid/also-hide-group-from-direct-match
Also hide group from direct matches
2021-07-14 13:07:00 +07:00
Julius Härtl f43c2b45d8
Directly return cloud id from user
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-14 09:52:15 +07:00
Julius Härtl e1f644a2ae
Merge pull request #27631 from yan12125/php8-fix-error-reporting 2021-07-13 08:52:18 +07:00
Julius Härtl 3860dad9ea
Merge pull request #26481 from ghost/fdroid 2021-07-13 08:49:59 +07:00
Julius Härtl 0031152de1
Merge pull request #27852 from nextcloud/bugfix/noid/allow-casting-query-functions 2021-07-13 08:48:49 +07:00
Chih-Hsuan Yen 16c4991db6
Correctly skip suppressed errors in PHP 8.0
Applies the suggested transformation mentioned in
https://www.php.net/manual/en/migration80.incompatible.php,

> The @ operator will no longer silence fatal errors (E_ERROR,
> E_CORE_ERROR, E_COMPILE_ERROR, E_USER_ERROR, E_RECOVERABLE_ERROR,
> E_PARSE). Error handlers that expect error_reporting to be 0 when
> @ is used, should be adjusted to use a mask check instead

The new code still works on PHP 7, as error_reporting() already
returns 0 when diagnostics are suppressed.

This fixes https://github.com/nextcloud/server/issues/25807 in PHP 8.0.
For PHP 7.x, https://github.com/nextcloud/server/pull/22243 suppresses
the E_NOTICE message from the second session_start() call with the error
suppression operator @, and thus those E_NOTICE messages are still
logged in PHP 8.0.

See also https://github.com/nextcloud/server/issues/25806

Signed-off-by: Chih-Hsuan Yen <yan12125@gmail.com>
2021-07-13 13:23:03 +07:00
Lukas Reschke 6a07acf144 Regenerate autoloader file
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-07-12 15:12:36 +07:00
Lukas Reschke 84d9b17dc7
Check for !== false instead
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-07-12 15:06:30 +07:00
Lukas Reschke 28359571de Remove Flysystem storage class
This seems unused as per https://github.com/nextcloud/server/issues/27768
and may allow us to get rid of one more dependency.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-07-12 13:21:06 +07:00
Lukas Reschke b0cef8827d Check if dns_get_record returns non-false
`dns_get_record` can return false which results in exceptions such as
the ones shown in https://github.com/nextcloud/server/issues/27870.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-07-12 13:15:20 +07:00
Nextcloud bot bdb5d9f418
[tx-robot] updated from transifex 2021-07-10 02:31:32 +07:00
Nextcloud bot c2f62ee0b8
[tx-robot] updated from transifex 2021-07-09 02:26:17 +07:00
J0WI 3b656446af Introduce ISecureRandom::CHAR_ALPHANUMERIC
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-07-08 15:11:31 +07:00
Nextcloud bot 726f23ffd9
[tx-robot] updated from transifex 2021-07-08 02:26:46 +07:00
Joas Schilling aae16c21e6
Allow casting query functions as well
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-07-07 14:20:24 +07:00
Sanpi 81c272a8a5 Fixes recursion count incrementation
Signed-off-by: Sanpi <sanpi@homecomputing.fr>
2021-07-07 12:00:00 +07:00
J0WI b344ff1a67 Refactor getEncryptionModule routine 2021-07-06 19:20:32 +07:00
kesselb 9f04a7c71e
Merge pull request #27801 from nextcloud/enh/noid/hardening-dns-pin-middleware
Ignore subdomain for soa queries
2021-07-06 18:55:25 +07:00
kesselb 5e7206d23a
Merge pull request #27818 from nextcloud/fix/locking-cache-check
Fix in locking cache check
2021-07-06 18:53:51 +07:00
Nextcloud bot 17e58f5056
[tx-robot] updated from transifex 2021-07-06 02:26:02 +07:00
MichaIng 0304eea58d
Fix in locking cache check
The intention obviously was to check whether $lockingCacheClass is defined, and existing class, and available. It was however checked whether the $distributedCacheClass is an existing class, which would have caused an exception already in the previous distributed cache check.

Signed-off-by: MichaIng <micha@dietpi.com>
2021-07-05 23:11:13 +07:00
Christoph Wurst 26efbe982e
Merge pull request #27794 from nextcloud/fix/clarify-lazy-event-listener-container
Clarify that lazy event listeners are built from the server container
2021-07-05 21:13:53 +07:00
Daniel Kesselberg b6530e5e82
Ignore subdomain for soa queries
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-07-05 20:29:06 +07:00
Pytal 04441d5012
Merge pull request #27767 from nextcloud/enh/20515/maintenance-mode-info
Improve maintenance mode info
2021-07-05 10:44:10 +07:00
Lukas Reschke 8037a4be57
Merge pull request #27799 from nextcloud/bug/26425/check-return-encrypt
Throw exception if encrypting the data failed.
2021-07-05 18:53:32 +07:00
John Molakvoæ b396aee333
Merge pull request #27758 from nullspoon/fix-dns-pinning 2021-07-05 17:37:51 +07:00
Christoph Wurst a6a31bb419
Clarify that lazy event listeners are built from the server container
Ref https://github.com/nextcloud/server/issues/27793

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-07-05 12:11:54 +07:00
Daniel Kesselberg 0a15043f69
Throw exception if encrypting the data failed.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-07-05 10:23:16 +07:00
Daniel Kesselberg c91bb98e5c
Check that pdo is installed
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-07-05 09:49:05 +07:00
HouraisanNEET 0ba0189260 Add F-Droid
Signed-off-by: HouraisanNEET <HouraisanNEET@users.noreply.github.com>
2021-07-04 21:44:55 +07:00
Aaron Ball 484913dc31
Fix DnsPinMiddleware resolve pinning bug
Libcurl expects the value of the CURLOPT_RESOLVE configurations to be an
array of strings, those strings containing a comma delimited list of
resolved IPs for each host:port combination.

The original code here does create that array with the host:port:ip
combination, but multiple ips for a single host:port result in
additional array entries, rather than adding them to the end of the
string with a comma. Per the libcurl docs, the `CURLOPT_RESOLVE` array
entries should match the syntax `host:port:address[,address]`.

This creates a function-scoped associative array which uses `host:port`
as the key (which are supposed to be unique and this ensures that), and
the value is an array containing IP strings (ipv4 or ipv6). Once the
associative array is populated, it is then set to the CURLOPT_RESOLVE
array, imploding the ip arrays using a comma delimiter so the array
syntax matches the expected by libcurl.

Note that this reorders the "foreach ip" and "foreach port" loops.
Rather than looping over ips then ports, we now loop over ports then
ips, since ports are part of the unique host:port map, and multiple ips
can exist therein.

Signed-off-by: Aaron Ball <nullspoon@oper.io>
2021-07-02 16:08:44 +07:00
Robin Appelman 9884344230
dont include folder being search in in the results
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-07-02 16:32:25 +07:00
szaimen 37ff07b9e1 Improve maintenance mode info
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-02 13:54:33 +07:00
Joas Schilling af03f5d516
Also hide group from direct matches
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-07-02 09:47:42 +07:00
blizzz 7589d5a176
Merge pull request #27533 from Rid/master
Fix scanner mistaking socket files for directories
2021-07-01 17:36:06 +07:00
blizzz 62675eb5c2
Merge pull request #27586 from nextcloud/bugfi/noid/objectstore-checksum
Reset checksum when writing files to object store
2021-07-01 17:30:54 +07:00
Daniel Rudolf 15a445f743
Move UtilTest::testDefaultApps() to UrlGeneratorTest
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 16:26:55 +07:00
Daniel Rudolf e16bf707aa
Fix UtilTest::testDefaultApps()
Oh wow... This definitly was no best practice... 😒

Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 16:00:29 +07:00
Daniel Rudolf a43de10d1e
Add RedirectToDefaultAppResponse::__construct() annotations
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 15:35:09 +07:00
Daniel Rudolf e478db9161
Deprecate RedirectToDefaultAppResponse
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 15:13:08 +07:00
Daniel Rudolf 2c7186a15f
Remove \OC::$server->getURLGenerator() usage
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 15:12:15 +07:00
Julius Härtl 3853307a6a
Merge pull request #26681 from nextcloud/techdebt/hint-exception-ocp
Move HintException to OCP
2021-07-01 08:34:55 +07:00
Nextcloud bot bb40e65e4e
[tx-robot] updated from transifex 2021-07-01 02:24:48 +07:00
Gary Kim b78f3a57d1
Migrate HintException to OCP
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 +07:00
Daniel Rudolf 0df68f0697
Remove unused imports
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-06-30 16:48:22 +07:00
Daniel Rudolf 12059eb65b
Add IUrlGenerator::linkToDefaultPageUrl()
Replaces the deprecated \OC_Util::getDefaultPageUrl() and makes this API public.

Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-06-30 16:20:57 +07:00
Arthur Schiwon 12e4484dba
ensure that factoryClass exisits before instantiation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 15:09:27 +07:00
blizzz f99a895047
Merge pull request #27700 from nextcloud/deprecate-remote
Deprecate OCP\Remote
2021-06-30 11:21:12 +07:00
Maxime Besson 388a458cd5 fix(proxy): use accessor
Signed-off-by: Maxime Besson <maxime.besson@worteks.com>
2021-06-30 09:25:04 +07:00
Arthur Schiwon ad0a11b2bf
cleanup
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 01:03:44 +07:00
Arthur Schiwon 506227b509
adjust internal data handling logic to fix store and load
- format as stored previously in oc_accounts table is kept

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:48:01 +07:00
Arthur Schiwon c7bf4295cc
adjust email verification checker
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:47:36 +07:00
Arthur Schiwon d64411e9df
fix code style
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:45:49 +07:00
Arthur Schiwon 3d6ffd3da2
adjust verification state updater method
- also fixes scope of internal methods

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:42:42 +07:00
Arthur Schiwon af3fdbea7b
make AccountManager actually write multi value properties
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:12 +07:00
Arthur Schiwon 638c04d6e0
accounts event handler to use eventdispatcher, DI and Accounts API
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:11 +07:00
Arthur Schiwon d109d4f581
prov api to be able to edit multivalue properties
- adding as usual
- deleting and scope setting via additional endpoint

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:11 +07:00
Arthur Schiwon 13818005a3
prov api reports additional emails on getUser
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:10 +07:00
Vincent Petry 8535340d9a
Revert "First attempt to check against core routes before loading all app routes"
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-06-29 17:54:30 +07:00
Lukas Reschke a423aae522 Deprecate OCP\Remote
This is unused.

Fixes https://github.com/nextcloud/server/issues/25780

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-28 16:36:32 +07:00
Nextcloud bot ac97873a17
[tx-robot] updated from transifex 2021-06-28 02:25:09 +07:00
Nextcloud bot 67851a0262
[tx-robot] updated from transifex 2021-06-27 02:25:38 +07:00
Nextcloud bot 1cf04c8b6f
[tx-robot] updated from transifex 2021-06-26 02:25:44 +07:00
Julius Härtl 99013d4bc7
Merge pull request #27668 from nextcloud/fix/harden-context-registration-app-missing
Harden bootstrap context registrations when apps are missing
2021-06-25 18:42:46 +07:00
Christoph Wurst 80dd0b9418
Harden bootstrap context registrations when apps are missing
It's not expected that an app would be unavailable when the app
container is created but when services are registered, but Sentry tells
me on Nextcloud 21 there is an edge case where this can happen.
Therefore this patch hardens the code a bit to log a meaningful error
message and skipping the next code instead of logging a php notice for
the undefined index and an exception for calling a method on null.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-25 11:40:35 +07:00
John Molakvoæ e35ed31b31
Merge pull request #27663 from nextcloud/fix/unshift-crash-reporters-break-loop
Unshift crash reports when they are loaded, to break the recusion
2021-06-25 08:29:28 +07:00
Nextcloud bot 95447d0152
[tx-robot] updated from transifex 2021-06-25 02:25:29 +07:00
Christoph Wurst 35a9ad0d78
Unshift crash reports when they are loaded, to break the recusion
If, for whatever reason, during the loading of a crash reporter a new
log entry is generated, then the lazy loading mechanism will be invoked
*again* while it's already executed. This doesn't result in an endless
recursion, but means that the crash reporters will be built and
registered many times. This then means any further log entry will be
logged x times instead of once.

Unshift makes sure to take the class off the registration list right
away, so another invokation of the same method won't try to do the same
job.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-24 15:31:49 +07:00
Nextcloud bot 4158f1a848
[tx-robot] updated from transifex 2021-06-24 02:25:18 +07:00
Pytal 9ed379da22
Merge pull request #27635 from nextcloud/fix/datetime-constants
Fix usage of DateTime constants
2021-06-23 09:56:28 +07:00
Lukas Reschke 19a84512d6
Merge pull request #27628 from nextcloud/security-txt
Add security.txt
2021-06-23 15:49:51 +07:00
Christoph Wurst 6d5cfe0c66
Move DateTime::RFC2822 to DateTimeInterface::2822
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-23 15:30:43 +07:00
Christoph Wurst 770881d5d6
Move DateTime::ATOM to DateTimeInterface::ATOM
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-23 15:28:07 +07:00
Lukas Reschke a70fd1bad1
Merge pull request #26344 from J0WI/fs-early-root
Return early if path is root
2021-06-23 15:21:56 +07:00
Lukas Reschke 65742695d1 Rebuild autoloader
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-23 13:59:48 +07:00
Lukas Reschke 25ab4059c6 Add security.txt
Ref https://securitytxt.org

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-23 13:58:47 +07:00
blizzz ee7a484284
Merge pull request #26346 from J0WI/clean-auth-regex
Cleaner removePassword regex
2021-06-23 11:20:19 +07:00
Nextcloud bot 1977114f01
[tx-robot] updated from transifex 2021-06-23 02:26:18 +07:00
szaimen 858f578f84 mail-template - don't show hyphen if slogan is empty
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-06-22 13:43:12 +07:00
Nextcloud bot 25b4f11fd5
[tx-robot] updated from transifex 2021-06-22 02:26:59 +07:00
Louis Chemineau 3f6d3dc307 Fix typing error in AppFetcher.php
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-06-21 16:31:24 +07:00
Julius Härtl 21db463bc9
Reset checksum when writing files to object store
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-21 12:04:49 +07:00
Nextcloud bot 61a31dcdd7
[tx-robot] updated from transifex 2021-06-20 02:27:02 +07:00
Nextcloud bot da408dbcbd
[tx-robot] updated from transifex 2021-06-19 02:26:44 +07:00
Christoph Wurst 365819c305
Merge pull request #27544 from nextcloud/chore/phase-out-controller-reflector
Phase out the controller reflector
2021-06-18 15:02:21 +07:00
Julius Härtl bdb1525c16
Merge pull request #27540 from nextcloud/getstoragerootid-failed-storage
handle case where storage can't be created in getStorageRootId
2021-06-18 14:17:41 +07:00
Morris Jobke 38edc6fdec
Merge pull request #27532 from nextcloud/fix/noid/properly-cleanup-webauthn-user-deletion
Properly cleanup entries of WebAuthn on user deletion
2021-06-18 12:52:05 +07:00
Morris Jobke dbed0ce680
Properly cleanup entries of WebAuthn on user deletion
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-06-18 09:42:32 +07:00
Nextcloud bot 3b70e44f2a
[tx-robot] updated from transifex 2021-06-18 02:26:57 +07:00
Christoph Wurst e49f1e4319
Phase out the controller reflector
1) PHP8 attributes will soon replace phpdoc annotations
2) Most of the class was never meant to be used by an app but internally

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-17 18:21:19 +07:00
Christoph Wurst b73f40eabb
Merge pull request #24318 from nextcloud/techdebt/noid/remove-oc_user-getDisplayName
Use proper methods for display name retrieval
2021-06-17 18:17:28 +07:00
Robin Appelman 8520717b4f
handle case where storage can't be created in getStorageRootId
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-17 14:32:38 +07:00
blizzz eec792446d
Merge pull request #26939 from nextcloud/enh/app-icon-notification-bubble
Let apps toggle an unread counter on app icons
2021-06-17 13:33:31 +07:00
Rid 0469acfb20 Fix scanner mistaking socket files for directories
Signed-off-by: Rid <rid@cylo.io>
2021-06-17 11:44:44 +07:00
Morris Jobke 095418493e
Use proper methods for display name retrieval
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-06-17 10:19:07 +07:00
Nextcloud bot 78bfaeaa0e
[tx-robot] updated from transifex 2021-06-17 02:25:48 +07:00
Lukas Reschke f8add9d82f
Merge pull request #22628 from Sp1l/simplify-htaccess-rewrites
Coalesce RewriteCond lines in .htaccess
2021-06-16 19:35:29 +07:00
John Molakvoæ c04e0d1db9
Merge pull request #27098 from nextcloud/fix/noid/missing-key-in-addInfo
force 'name' key in array
2021-06-16 17:13:45 +07:00
Julius Härtl a94236483e
Let apps toggle an unread counter on app icons
Co-authored-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-16 17:12:56 +07:00
Morris Jobke 4c93249514
Merge pull request #26319 from nextcloud/files_external_app.php
Move files_external to IBootstrap and remove some deprecated stuff in the process
2021-06-16 17:12:14 +07:00
Joas Schilling cebfe4ba0e
Merge pull request #27190 from nextcloud/bugfix/noid/deduplicate-translation
Deduplicate translations and fix double .
2021-06-16 16:50:19 +07:00
Morris Jobke ff8cfbb24e
Merge pull request #27529 from nextcloud/fix/25950/default-product-name
Fix default product name for old themes
2021-06-16 16:49:08 +07:00
Morris Jobke f6108acea4
Fix default product name for old themes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-06-16 15:52:49 +07:00
Christoph Wurst 39f0aa5abe
Merge pull request #27515 from nextcloud/enh/noid/read-multi-value-user-attribute
Add method to read multi-value attributes from ldap
2021-06-16 15:51:09 +07:00
Robin Appelman 1052feabed
remove depricated methods from MountConfig
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-16 13:55:19 +07:00
Julius Härtl c0474ba364
Use product name in places where it is appropriate rather than the instance name
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-16 11:42:53 +07:00
Julius Härtl 4673b54a2c
Add dedicated product name to OCP\Defaults
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-16 11:36:56 +07:00
Daniel Kesselberg 04411df695
Add method to read multi-value attributes from ldap.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-06-16 11:35:27 +07:00
Julius Härtl 51add75e51
Merge pull request #26430 from nextcloud/enh/dashboard-api 2021-06-16 11:34:46 +07:00
Julius Härtl 6b60495d82
Merge pull request #27514 from nextcloud/fix/share_activity
Fix share activity dispatch
2021-06-16 11:34:12 +07:00
Louis Chemineau be42a13235 Fix share activity dispatch
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-06-16 10:11:54 +07:00
Julius Härtl 08899c8b3b
Update autoloader
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-15 21:36:25 +07:00
Julien Veyssier e15270cbb9
implement dashboard API for clients, new WidgetItem class, new IAPIWidget interface
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-06-15 21:34:00 +07:00
Robin Appelman 362cb2a11f
inject SearchBuilder
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:23:08 +07:00
Robin Appelman 66e10718c6
split of query building bits from searchhelper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:40 +07:00
Robin Appelman f938daa6e4
update tests and fix some edge cases around new search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:36 +07:00
Robin Appelman 27e50b24aa
some cleanup and documentation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:32 +07:00
Robin Appelman 5d1d53c42e
perform file search in a single query
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:29 +07:00
Robin Appelman 9774fb1573
use searchoperation for storage filter instead of db expression
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:25 +07:00
Robin Appelman e198dc1b20
rework search api to allow searching on multiple caches at once
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:22 +07:00
Nextcloud bot da1586d2d0
[tx-robot] updated from transifex 2021-06-13 02:26:07 +07:00
Nextcloud bot 291bc01c19
[tx-robot] updated from transifex 2021-06-12 02:27:01 +07:00
Morris Jobke c0e1238676
Merge pull request #27451 from nextcloud/enh/log-exception
Move exception logging to separate field
2021-06-10 10:10:48 +07:00
Robin Appelman 581cbdc20c
[3rdparty] streams-0.7.4
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-10 07:58:32 +07:00
Julius Härtl e536b7bbcc
Move exception logging to separate field
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-10 07:35:51 +07:00
blizzz bb2b946c51
Merge pull request #27430 from nextcloud/fix/feedback_response_check
Correctly check the reception of a remote feedback
2021-06-09 20:46:05 +07:00
Louis Chemineau ebf35fb38a Correctly check the reception of a remote feedback
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-06-09 15:37:18 +07:00
Nextcloud bot 1c97818e14
[tx-robot] updated from transifex 2021-06-09 02:26:15 +07:00
Christoph Wurst 745543d8c0
Merge pull request #27306 from nextcloud/enh/noid/set-local-domain-for-swiftmailer
Set local domain for swiftmailer
2021-06-08 15:43:39 +07:00
blizzz 662ab937e0
Merge pull request #27189 from nextcloud/feat/26866/account-collection-properties
Extend Accounts with multivalue properties (PropertyCollection)
2021-06-08 14:25:18 +07:00
Nextcloud bot f6485f98f0
[tx-robot] updated from transifex 2021-06-08 02:26:20 +07:00
Morris Jobke 2ae60b42ab
Merge pull request #26494 from rigrig/fix-php8-deprecations
Fix some php 8 warnings
2021-06-07 23:30:59 +07:00
Nextcloud bot d1d4725630
[tx-robot] updated from transifex 2021-06-07 02:25:07 +07:00
Nextcloud bot fdb2b07803
[tx-robot] updated from transifex 2021-06-06 02:26:01 +07:00
John Molakvoæ (skjnldsv) 215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
Arthur Schiwon 35d5395089
psalm happiness
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

psalm happiness

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-04 19:57:00 +07:00
Joas Schilling b4b2947248
Deduplicate translations and fix double .
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-04 09:47:17 +07:00
Nextcloud bot 46dbc8fa98
[tx-robot] updated from transifex 2021-06-04 02:28:13 +07:00
Arthur Schiwon 8ec640d14a
adjust property type declaration
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 21:07:59 +07:00
Arthur Schiwon 2701c3e7dc
fix code style
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:54:25 +07:00
Arthur Schiwon 44827e37c0
allow interacting with IAccountPropertyCollections
- in fact the API could be done in a nicer way and it might be possible to
  work without IAccountPropertyCollection, but only with the
  IAccountProperties.
- To keep it simple at first and not overengineer the blunt attempt is
  followed
- If necessary helpful in the further cause of development adjustements or
  extensions can be done quickly with this base


Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:49 +07:00
Arthur Schiwon 0bade27479
add IAccountPropertyCollection with implementation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:49 +07:00
Arthur Schiwon 839bff1641
deal with property collections when fetching users (with update)
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:49 +07:00
Arthur Schiwon 956bfba2e2
refactor validators and sanitizers
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:48 +07:00
Arthur Schiwon fb79350d3e
extend AccountManager API with collection const
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:42 +07:00
Nextcloud bot 26f537fbec
[tx-robot] updated from transifex 2021-06-03 02:28:43 +07:00
blizzz 0bbb195af1
Merge pull request #27354 from nextcloud/escape-download-response
Escape filename in Content-Disposition
2021-06-02 21:15:25 +07:00
John Molakvoæ 949102c031
Merge pull request #27088 from nextcloud/fix/27074/removing-apps
Allow removing apps with app store disabled
2021-06-02 21:10:05 +07:00
blizzz aa40bdea0f
Merge pull request #24295 from nextcloud/perf/noid/router
First attempt to check against core routes before loading all app routes
2021-06-02 21:03:29 +07:00
Lukas Reschke 377514aad1 Escape filename in Content-Disposition
We should escape all occurences of ' and \ in here.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-02 19:22:17 +07:00
Julius Härtl 4b1576e978
First attempt to check against core routes before loading all app routes
Most of the time we will find a matching route in either the loaded ones
matched on the URL or in the core ones. Therfore we can attempt to try
those first and only load all app routes if no match was found by the
Symfony URLMatcher.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-02 17:57:04 +07:00
Valdnet 9c6b01abeb
l10n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-02 17:49:32 +07:00
Bernard Spil f78420702c
Coalesce RewriteCond lines in .htaccess
And escape some '.' where not yet escaped
2021-06-02 17:32:33 +07:00
John Molakvoæ d0cf20cc51
Merge pull request #26792 from nextcloud/user-delete-cleanup-files
better cleanup of user files on user deletion
2021-06-02 17:02:00 +07:00
Joas Schilling 6578a93463
Merge pull request #27053 from nextcloud/bugfix/noid/dont-throw-when-comments-is-disabled
Don't throw when comments is disabled
2021-06-02 15:40:51 +07:00
Lukas Reschke 5438e00276
Merge pull request #27329 from nextcloud/propagate-throttle-state-for-baseresponse
Propagate throttling on OCS response
2021-06-01 21:40:41 +07:00
Lukas Reschke 09503b0269
Merge pull request #27316 from nextcloud/bugfix/noid/getNumberOfUnreadCommentsForObjects
Fix populating the array and closing the cursors
2021-06-01 21:01:01 +07:00
Christoph Wurst 84584959b0
Merge pull request #27328 from nextcloud/fix/noid/UserLoggedInEvent-apache-auth
emit UserLoggedInEvent on apache auth
2021-06-01 17:38:41 +07:00
Daniel Kesselberg 2b60587a2f
Add mbstring as dependency
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-06-01 15:43:08 +07:00
Lukas Reschke 09abcfadfa Propagate throttling on OCS response
The BaseResponse converter did not take over any throttling state from the DataResponse.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-01 14:15:23 +07:00
Arthur Schiwon 6ac4eafcf9
emit UserLoggedInEvent on apache auth
- post_login OC_Hook is barely used or listened to

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-01 13:59:40 +07:00
Christoph Wurst b29c3aa03f
Merge pull request #25658 from nextcloud/dav-respect-disallow-sharing-with-groups
Dav respect disallow sharing with groups
2021-06-01 12:07:29 +07:00
Joas Schilling c0c5340f4e
Fix populating the array and closing the cursors
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-01 09:15:34 +07:00
Daniel Kesselberg 747325fc43
Set local domain for swiftmailer transport
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-05-31 15:04:00 +07:00
Nextcloud bot 9e596dd0cf
[tx-robot] updated from transifex 2021-05-31 02:35:25 +07:00
Nextcloud bot 719430559f
[tx-robot] updated from transifex 2021-05-30 02:24:58 +07:00
Richard de Boer 7990f95558 Check whether output buffering is active before turning it off
Before we just turned it off and @suppressed the error if ob was not active.
In PHP 8 this error is no longer suppressed, so try to not cause it at all.

Signed-off-by: Richard de Boer <git@tubul.net>
2021-05-29 14:14:52 +07:00
Richard de Boer a0d265b0b1 Fix a usort comparison function returning a boolean instead of an integer
PHP 8 shows deprecation warnings about this, see #25806

Signed-off-by: Richard de Boer <git@tubul.net>
2021-05-29 14:14:52 +07:00
Richard de Boer f23d057ad9 Fix functions taking optional parameters before required ones
PHP 8 shows deprecation warnings about this, see #25806
Removes the "default" values, as they actually are required parameters anyway.

Signed-off-by: Richard de Boer <git@tubul.net>
2021-05-29 14:14:52 +07:00
Morris Jobke 77d6611fa0
Merge pull request #27199 from nextcloud/fix/26683/use-noreply-as-share-email
Use noreply@ as email address for share emails
2021-05-28 13:40:12 +07:00
Morris Jobke fb7899135e
Merge pull request #27187 from Simounet/fix/comments-query-oracle-limit-compliance
Fix Oracle query limit compliance in Comments
2021-05-28 11:19:36 +07:00
Morris Jobke dc9bdd4f39
Use noreply@ as email address for share emails
Fixes #26683

Before it used the instance name, which a) doesn't make sense to randomly guess email addresses and b) could contain characters that are not allowed in email addresses like spaces.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-05-28 11:13:24 +07:00
Simounet a50eba16ad
Fix Oracle query limit compliance in Comments
Signed-off-by: Simounet <contact@simounet.net>
2021-05-28 08:48:01 +07:00
blizzz 6f063c2ee9
Merge pull request #25770 from nextcloud/fix/25742/cli-cache-backend-recursion
Don't allow executing cli if cache backend is unavailable
2021-05-27 17:56:11 +07:00
kesselb 222ac93774
Merge pull request #27117 from nextcloud/fix/add-exception-doc-to-qbmapper
Add DB exception '@throws' tag to QBMapper PHPDoc
2021-05-26 17:11:49 +07:00
Anna Larch 8fcb3f33c8 Add DB exception throws tag to QBMapper PHPDoc
Signed-off-by: Anna Larch <anna@nextcloud.com>
2021-05-26 15:12:41 +07:00
Joas Schilling e4b5645883
Also make other shares listen to the "Allow sharing with groups"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-26 11:19:58 +07:00
Richard Steinmetz 0f949eaeb1
Don't allow executing cli if cache backend is unavailable
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2021-05-26 11:02:26 +07:00
Nextcloud bot accfe5b82d
[tx-robot] updated from transifex 2021-05-26 02:28:28 +07:00
Morris Jobke 6ed728d76c
Merge pull request #27043 from nextcloud/storage-info-include-external
fix return value of getStorageInfo when 'quota_include_external_storage' is enabled
2021-05-25 21:57:23 +07:00
blizzz 1b47886abb
Merge pull request #27035 from nextcloud/techdebt/26866/userscontroller-accountmanager-api
do not use private AccountManager in UsersController
2021-05-25 21:22:37 +07:00
Morris Jobke 3d1c78647e
Merge pull request #23065 from TomG736/FixEmptyDisplayName
Fix null displayname crash as described in #21885
2021-05-25 21:13:00 +07:00
kesselb 1b21b173e6
Merge pull request #27104 from nextcloud/properly-name-execute
[Quick Review] executeUpdate is also deprecated
2021-05-25 20:44:51 +07:00
Lukas Reschke 4e7b82169c executeUpdate is also deprecated
Ref 1089ad5d9e/lib/private/DB/QueryBuilder/QueryBuilder.php (L312-L323)

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-05-25 20:25:44 +07:00
Lukas Reschke a521ed874c Remove unused constants
No calls in all of GitHub as per https://sourcegraph.com/search?q=USER_AGENT_OWNCLOUD_&patternType=literal

Deprecation has also been years ago.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-05-25 19:01:48 +07:00