b21a399d1a
fix: implement sharding compatible cleanup for various bits
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:27:14 +07:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
a8bdd4f99b
feat(preview): move previews for imaginary pdf to own class ImaginaryPDF
...
Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-07-25 17:01:01 +07:00
5ea972922b
fix: explicitly filter for storageid in preview cleanup job
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-23 14:41:15 +07:00
37454eb200
feat: log file id and path when extracting the mp3 cover fails
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-07-04 10:55:31 +07:00
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-24 13:11:22 +07:00
4286660983
fix: Extend SVG reference check
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-05-16 10:01:33 +07:00
bd6989d365
Merge pull request #44710 from nextcloud/pulsejet/imagick-check-type
...
fix(preview): check mime type before processing with Imagick
2024-05-15 22:13:05 +07:00
672923f0a6
fix: Fix newly spotted psalm issues, add exhaustive typed magic properties for LDAP classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:23:58 +07:00
4ab40e355f
fix(preview): check mime type before processing with Imagick
...
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2024-04-08 10:22:17 +07:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
6f4d0fe79c
Lower failed movie preview to info
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-02-03 18:52:05 +07:00
c4f4c5a3fb
Merge pull request #41067 from Murena-SAS/preview-folder-deletes
...
Fix for previews not being generated sometimes
2024-01-18 11:46:12 +07:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
c9dc377ebc
Merge pull request #41395 from nextcloud/hello-emf
...
feat: add preview provider for emf files based on office
2023-11-16 19:48:06 +07:00
ef5f7d0a90
Us strpos() only
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-11-15 00:04:25 +07:00
53b84732a3
Check for open_basedir before reading /proc
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-11-15 00:04:25 +07:00
475dd60354
fix: use png as preview right away
...
The initial office preview implementation converted an office document with LibreOffice to PDF, used ImageMagick to extract the first page as JPEG, and passed it OC_Image.
https://github.com/nextcloud/server/pull/10198 changed the implementation to use PNG rather than PDF. OC_Image can use a PNG as a preview right away, so the ImageMagick step is unnecessary.
The registration code was updated to not ask ImageMagick if PDF is supported, as PDFs are no longer used to create office document previews.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-11-13 22:00:45 +07:00
b5241d5220
feat: allow multiple libreoffice invocations
...
LibreOffice only allows one invocation per user profile.[^1]
The office provider set the user profile to /tmp/owncloud-instanceid and therefore only one invocation per instance is allowed. This was introduced a while ago, yet it's unclear if this was intentionally or just a side effect.[^2]
The limitation on one invocation leads to the situation that the preview generation only works for a couple of files if you upload a whole folder of emf or word files.
This commit removes the limitation by using a new user profile for each preview. That's done by using instance id plus file id as postfix for getTemporaryFolder.
This has some drawbacks:
- Overload protection: If you upload 100 emf files, you may end up with 100 LibreOffice invocations. Though, you can use preview_concurrency_new to limit the number of previews that can be generated concurrently when php-sysvsem is available.
- New profile: I assume it takes a few bits to generate a fresh LibreOffice user profile. It appears that there is no way to ask LibreOffice to not create a profile and just work with the defaults. The profile will be cleaned after use by our temp manager.
- Remove the configuration option preview_office_cl_parameters: This is not strictly necessary yet, but if you set the configuration option, the generated path for the user profile is also missing. The configuration option is not well documented (e.g., it's unclear that the last option needs to be --outdir) and actually, there should be no reason to change it after all.
[^1]: https://wiki.documentfoundation.org/UserProfile
[^2]: https://github.com/owncloud/core/pull/9784
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-11-13 21:46:31 +07:00
aa48a5f94f
feat: add preview provider for emf files based on office
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-11-13 12:35:54 +07:00
b681cf735a
address review
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-11-03 15:27:17 +07:00
531f5d1e4f
fix semaphore guarding
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-11-03 11:47:12 +07:00
d1169af129
Use \Throwable instead
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-11-01 16:55:19 +07:00
624986a6d5
Catch Imaginary processing errors
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-11-01 16:55:19 +07:00
974e86e618
Don't pass invalid streams to Imaginary
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Update Imaginary.php
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Update Imaginary.php
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-10-25 21:58:46 +07:00
1d767ebff5
Check if the node has a null ID before deleting in preview watcher
...
Signed-off-by: Akhil <akhil@e.email>
2023-10-23 20:32:15 +07:00
da2aad598e
also remove function
...
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
2023-10-02 10:54:36 +07:00
b2d105e7ec
Generate all preview sizes for Imaginary
...
A follow up on https://github.com/nextcloud/server/pull/40670
Based on discussions here: https://github.com/nextcloud/server/issues/38911#issuecomment-1741819188
This fixes the case were not all previews are generated, for example in the activity view: https://github.com/nextcloud/server/issues/38911#issuecomment-1738886106
Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
2023-09-30 20:08:35 +07:00
80abec668b
feat: Imaginary WebP support
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-09-02 09:30:37 +07:00
52590a762f
feat(files): add uploader
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-09-01 14:35:40 +07:00
28725c46a8
feat: redirect to the mime icon if no preview available
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-17 18:56:38 +07:00
46dfb84bca
log imaginary errors as info to not spam the server logs
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-08-09 16:10:27 +07:00
4f7de8ed60
fix!: Remove legacy event dispatching Symfony's GenericEvent
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:51 +07:00
14719110b9
chore: Replace \OC::$server->query with \OCP\Server::get in /lib
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-07-06 15:21:22 +07:00
3757f390c3
feat: replace id3parser with mp3info
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-28 14:58:59 +07:00
440f882322
feat: add width, height, crop and mode to BeforePreviewFetchedEvent
...
user_usage_report keeps a counter for files read.
The app uses
- OC_Filesystem::read hook
- Event listener (the legacy one) for IPreview::EVENT
Request for previews do not trigger the hook, hence the additional event listener.
The thumbnails for a list or grid view should not count, so we need the width and height.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-23 16:27:35 +07:00
9f1d497a0b
Merge pull request #38261 from fsamapoor/replace_strpos_calls_in_lib_private
...
Refactors "strpos" calls in lib/private to improve code readability.
2023-06-01 23:10:00 +07:00
0670ae607b
fix: catch errors in id3parser library
...
We use a forked version of getID3 to read embedded images from mp3 files to use them as previews.
If the library is unable to extract a image or fails on something different we should handle it properly.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-05-28 17:01:23 +07:00
c71a3065a7
Allow to specify an imaginary key
...
Signed-off-by: JanisPlayer <54918417+JanisPlayer@users.noreply.github.com>
2023-05-22 22:19:51 +07:00
6608f84a46
Merge pull request #36692 from nextcloud/throw-exception-to-avoid-division-by-zero
...
fix(preview-generator): Throw exception before dividing by zero when generating previews
2023-05-17 00:14:42 +07:00
e7cc7653b8
Refactors "strpos" calls in lib/private to improve code readability.
...
Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>
2023-05-15 15:17:19 +07:00
d55a7c619d
Fix typos in lib/public subdirectory
...
Found via `codespell -q 3 -S l10n -L jus ./lib/public`
Signed-off-by: luz paz <luzpaz@github.com>
Update lib/public/Accounts/IAccount.php
Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: Simon L <szaimen@e.mail.de>
Co-Authored-By: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-05-10 11:56:34 +07:00
527de8ac9d
Merge pull request #37148 from nextcloud/enh/noid/increase-imaginary-timeouts
...
increase imaginary timeouts as for big files the processing could take very long
2023-05-04 12:44:52 +07:00
b294edad80
Merge branch 'master' into enh/type-iconfig-getter-calls
...
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-04-20 16:52:38 +07:00
8508865eaf
Merge pull request #37772 from nextcloud/enh/30986/follow-up
...
Prevent the OpenDocument preview generator from trying to open empty files
2023-04-18 12:18:14 +07:00
800f40b71c
fix php-lint
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 17:18:09 +07:00
e542e60dbc
try to make linters happy
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:14 +07:00
3440387f0f
gather code from small and max preview
...
use directory listing in both functions to gain 25% speed on run where
every preview already exist.
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
24c121347a
Revert 0e49b40
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
06a7e90383
improve parameter doc
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Robin Appelman
Daniel Kesselberg
ernolf
Andy Scherzinger
Joas Schilling
Joas Schilling
Côme Chilliet
Varun Patil
Git'Fellow
Arthur Schiwon
Christoph Wurst
Simon L
Akhil
Daniel Hansson
JanisPlayer
John Molakvoæ
Christoph Wurst
Faraz Samapoor
Côme Chilliet
Glandos