Commit Graph

681 Commits (d92bf388b1c553ecd6bfb2a7400b990dcafe9c54)

Author SHA1 Message Date
Lucas Azevedo 5af683d2c4 Namespace user auth token commands
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
2023-08-24 11:42:30 +07:00
Lucas Azevedo ca101b2dbe Filter out sensitive fields in user:auth-tokens
PublicKeyToken::jsonSerialize() already explicitly lists allowed fields,
we are adding a second guard here to be on the safe side.

Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
2023-08-24 11:20:35 +07:00
Lucas Azevedo 7d05d1f604 Add missing return types
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
2023-08-24 00:11:59 +07:00
Lucas Azevedo 651044ce17 feat: Add user:delete-auth-token command
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
2023-08-23 20:56:52 +07:00
Lucas Azevedo eed32112c5 feat: Add user:auth-tokens command
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
2023-08-23 20:56:17 +07:00
Joas Schilling 124588d4a6
fix: Make bypass function public API
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:40:24 +07:00
Joas Schilling b2fd283a30
feat(OCC): Add a command to get the bruteforce state of an IP
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:36:05 +07:00
Joas Schilling ab70bbd3ff
fix(db)!: Remove private legacy event because we can not keep it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:35 +07:00
Joas Schilling 86310a35b2
fix(db): Move missing core indices to typed event
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:34 +07:00
Joas Schilling 00d483585b
fix: Add options to support all used features by core
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:34 +07:00
Joas Schilling f73f14207c
fix(db): Move missing core columns to typed event
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:33 +07:00
Joas Schilling 77c2b169a5
fix(db): Move missing core primary keys to typed event
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:33 +07:00
Joas Schilling bd0a149a4f
feat(dispatcher): Add typed event for "db:add-missing-primary-keys"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:32 +07:00
Joas Schilling 2eded24eff
feat(dispatcher): Add typed event for "db:add-missing-columns"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:32 +07:00
Julius Härtl 2601db240f
Merge pull request #39389 from nextcloud/enh/add-missing-indices-event 2023-07-14 14:21:39 +07:00
Julius Härtl 925bcebcb6
feat: Add public event for missing indices
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-07-14 13:11:22 +07:00
Arthur Schiwon e5160e0c1c
fix(db): no hardcoded table prefix is expected
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-13 23:34:39 +07:00
Faraz Samapoor faaa8cc4e1 Update core/Command/TwoFactorAuth/Cleanup.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-24 23:14:23 +07:00
Faraz Samapoor 6e33efa543 Update core/Command/TwoFactorAuth/Enable.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-24 23:14:23 +07:00
Faraz Samapoor 34e8887ddb Update core/Command/TwoFactorAuth/Disable.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-24 23:14:23 +07:00
Faraz Samapoor 9bd9c09aae Update core/Command/TwoFactorAuth/State.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-24 23:14:23 +07:00
Faraz Samapoor 116b8c68a6 Update core/Command/TwoFactorAuth/Enforce.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-24 23:14:23 +07:00
Faraz Samapoor cb8850dc8f Update core/Command/Check.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-24 23:14:23 +07:00
Faraz Samapoor 0db0572626 Adds constructor to the Based class.
Based on:
https://github.com/nextcloud/server/pull/38775#discussion_r1227641788

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-24 23:14:23 +07:00
Faraz Samapoor c01129947e Uses PHP8's constructor property promotion.
in core/Command and /TwoFactorAuth classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-24 23:14:23 +07:00
Louis cbebc50987
Merge pull request #38771 from fsamapoor/constructor_property_promotion_in_core_command_part7
Uses PHP8's constructor property promotion core/Command/Info, /Integrity, and /Preview
2023-06-22 14:09:06 +07:00
Marcel Klehr fcf1c3033b fix(systemtags): Add missing systemtags index
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-06-21 15:20:30 +07:00
Louis 358ce60b10
Merge pull request #38762 from fsamapoor/constructor_property_promotion_in_core_command_part1
Uses PHP8's constructor property promotion in core/Command/Encryption
2023-06-20 18:56:39 +07:00
Louis 6d33356ede
Merge pull request #38768 from fsamapoor/constructor_property_promotion_in_core_command_part5
Uses PHP8's constructor property promotion in core/Command/Config and Group
2023-06-20 17:49:32 +07:00
Faraz Samapoor 90035e98c1 Update core/Command/Encryption/DecryptAll.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-20 16:24:46 +07:00
Faraz Samapoor 9c2abae59c Update core/Command/Encryption/EncryptAll.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-20 16:24:46 +07:00
Faraz Samapoor bcfbcbb91c Moves single constructor parameters to new lines.
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-20 16:24:46 +07:00
Faraz Samapoor 2ace19fc54 Fixes php-cs error.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-20 16:24:46 +07:00
Faraz Samapoor f9a9ad50c3 Uses PHP8's constructor property promotion in core/Command/Encryption classes.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-20 16:24:46 +07:00
Côme Chilliet 5063bf37ed
Merge pull request #38774 from fsamapoor/constructor_property_promotion_in_core_command_part8
Uses PHP8's constructor property promotion in core/Command/Log, /Security, and /SystemTag
2023-06-20 10:12:52 +07:00
Faraz Samapoor b590059c26 Moves single constructor parameters to new lines.
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-20 09:30:21 +07:00
Faraz Samapoor c0a5bdea5e Uses PHP8's constructor property promotion.
in core/Command/Info, /Integrity, and /Preview classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-20 09:30:21 +07:00
Faraz Samapoor 51aae7866c Moves single constructor parameters to new lines.
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-20 09:29:50 +07:00
Faraz Samapoor 3519689d50 Uses PHP8's constructor property promotion in core/Command/Config and core/Command/Group classes.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-20 09:29:50 +07:00
Louis d9bf410762
Merge pull request #38769 from fsamapoor/constructor_property_promotion_in_core_command_part6
Uses PHP8's constructor property promotion core/Command/App,/Background, and /Broadcast
2023-06-19 21:09:24 +07:00
Faraz Samapoor f63c52a396 Moves single constructor parameters to new lines.
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 17:44:48 +07:00
Faraz Samapoor d83944fd10 Uses PHP8's constructor property promotion.
in core/Command/Log, /Security, and /SystemTag classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 17:44:48 +07:00
Louis 81bb3362b2
Merge pull request #38767 from fsamapoor/constructor_property_promotion_in_core_command_part4
Uses PHP8's constructor property promotion in core/Command/Maintenance
2023-06-19 17:43:12 +07:00
Louis 98ea74bb40
Merge pull request #38764 from fsamapoor/constructor_property_promotion_in_core_command_part2
Uses PHP8's constructor property promotion in core/Command/Db classes.
2023-06-19 17:27:10 +07:00
Faraz Samapoor cda0f74e0b Moves single constructor parameters to new lines.
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:27 +07:00
Faraz Samapoor ea844ca5fb Uses PHP8's constructor property promotion.
in core/Command/App, /Background, and /Broadcast classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:27 +07:00
Faraz Samapoor d60bedfeee Moves single constructor parameters to new lines.
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:22 +07:00
Faraz Samapoor ec63264153 Uses PHP8's constructor property promotion in core/Command/Maintenance classes.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:22 +07:00
Faraz Samapoor 1e8ec53b8c Update core/Command/Db/ConvertType.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-19 12:55:15 +07:00
Faraz Samapoor 73d7c45ae1 Update core/Command/Db/ConvertFilecacheBigInt.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-19 12:55:15 +07:00
Faraz Samapoor d34cafc58c Update core/Command/Db/Migrations/MigrateCommand.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-19 12:55:15 +07:00
Faraz Samapoor f1a19a10fc Update core/Command/Db/Migrations/StatusCommand.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-19 12:55:15 +07:00
Faraz Samapoor b5cbba7fc1 Uses PHP8's constructor property promotion in core/Command/Db classes.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:15 +07:00
Faraz Samapoor 9dc4efc52a Moves single constructor parameters to new lines.
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:10 +07:00
Faraz Samapoor 99f117146d Uses PHP8's constructor property promotion in core/Command/User classes.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:10 +07:00
Julius Härtl 095b43f396
feat: Add occ user:sync-account-data for updating oc_accounts information from user backends
This can be useful in cases where the state between user backend and
oc_accounts has become inconsistent.

Usually the account data is updated once the change on the user backend
is detected. Potential leftovers from older bugs
(https://github.com/nextcloud/user_saml/pull/582) might though never get
updated. This could lead to the contacts menu never showing the correct
display name. The contacts menu is read from the system address book,
which is only updated from oc_accounts.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-06-09 17:30:24 +07:00
Christoph Wurst cf6e2fa1b7
chore: Drop \OC_App::getAppVersion
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:26 +07:00
Arthur Schiwon 0fca8238dd
Merge pull request #37665 from fsamapoor/patch-2
Refactors Command/Encryption/Enable.php to improve code readability.
2023-05-23 20:56:18 +07:00
Robin Appelman 9d2d3d482b
Merge pull request #38148 from nextcloud/file-info-etag
also show file etag in file info
2023-05-11 13:21:48 +07:00
John Molakvoæ 0048071438
Merge pull request #38069 from nextcloud/list-supported-db 2023-05-09 17:16:26 +07:00
Robin Appelman cdcd6f2872
also show file etag in file info
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-09 14:56:37 +07:00
Robin Appelman cd3e7fd1b0
list supported databases when provided db isn't supported
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-04 14:43:48 +07:00
Robin Appelman 5c31c35d40
add option to list all files instead of limiting
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-04 13:10:26 +07:00
Robin Appelman 2b4bd02be9
add command to summarize space usage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-04 13:10:25 +07:00
Côme Chilliet f7632f2fc4
Merge pull request #32866 from nextcloud/performance/searchInGroup-displayname-cache
Optimize retrieving display name when searching for users in a group
2023-05-02 16:42:09 +07:00
Robin Appelman db43d90387
add new index in repair step instead of on-migrate
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-28 15:08:08 +07:00
Côme Chilliet 876c162df8
Use the searchDisplayName recommended method in user:list
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 15:25:13 +07:00
Robin Appelman 6d9f785afb
Merge pull request #37622 from nextcloud/group-list-numeric-userid
fix output for group:list command with numeric user ids
2023-04-24 17:14:11 +07:00
Robin Appelman c5dfa1cb79
validate that folder size sums to children
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-17 16:23:52 +07:00
Robin Appelman 60cf0c8f5f
add command for getting fileinfo for debugging
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-17 16:23:52 +07:00
Faraz Samapoor 8f4b20aaa1
Refactors core/Command/Encryption/Enable.php to improve code readability.
Improves the readability of the "execute" method by using early returns and reducing the code indentation.

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-04-11 09:29:44 +07:00
Robin Appelman b89621e8da
fix output for group:list command with numeric user ids
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-06 16:31:39 +07:00
Robin Appelman 013eedabbd
add command to generate a preview for a file
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-03 17:30:57 +07:00
Louis Chemineau bda66f9fb6 Add parent index on filecache
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-03-20 15:02:23 +07:00
Joas Schilling ff2c397c23
Merge pull request #36862 from nextcloud/bugfix/typo
Fix typo that added a letter to migration template
2023-02-26 22:22:33 +07:00
Vitor Mattos fd4c53f311 Fix typo that added a letter to migration template
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-02-25 12:48:22 +07:00
Joas Schilling e0251ea24e
Fail the repair command when an error happened
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-23 16:57:52 +07:00
Côme Chilliet d00422b812
Fix computerFileSize when called with a string without unit
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:30 +07:00
sodimel 5e18ffa89d FIX: This fill finish -> This will finish
Signed-off-by: sodimel <corentin@244466666.xyz>
2023-01-26 21:05:01 +07:00
Côme Chilliet 3f231d68d7
Merge pull request #36271 from nextcloud/fix/fix-codestyle
Fix codestyle using codesniffer
2023-01-20 15:26:17 +07:00
Christoph Wurst 473c546b5c
Merge pull request #36264 from nextcloud/fix/occ/repair-command-comment-formatting
fix(occ): Fix comment formatting of maintenance:repair command
2023-01-20 13:12:43 +07:00
Côme Chilliet f5c361cf44
composer run cs:fix
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
Côme Chilliet 90b955b1e9
Attempt to fix errors in Repair command tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:09 +07:00
Christoph Wurst a8bad3a98f
fix(occ): Fix comment formatting of maintenance:repair command
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-20 10:00:41 +07:00
Christoph Wurst d42d8b79e0
Merge pull request #36162 from nextcloud/fix/php82/string-var-interpolation
fix(PHP8.2): Fix deprecated string interpolation syntax
2023-01-19 18:05:44 +07:00
Vincent Petry a25645648e
Merge pull request #36123 from nextcloud/user-settings-normalize-uid
normalize userid in user:setting
2023-01-19 17:45:01 +07:00
Christoph Wurst 2e66acfab8
fix(PHP8.2): Fix deprecated string interpolation syntax
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-19 13:10:02 +07:00
Simon L 06a572ff55
Merge pull request #27492 from cyclops8456/feature/24301-remove-can-install-on-occ-maintenance-install
Remove the CAN_INSTALL file when occ maintenance:install is complete
2023-01-18 19:53:02 +07:00
Robin Appelman 975becb22e
normalize userid in user:setting
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-01-12 17:33:03 +07:00
Côme Chilliet d74044f634
Fix API breakage by using a new method instead
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-12 17:18:59 +07:00
Côme Chilliet 679682c186
Use a Generator for job list to fix background-job:list command
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-10 18:20:31 +07:00
Alex Harpin 644df591b1 Rename canInstallExists method and add new method for removal
Rename canInstallExists to shouldRemoveCanInstallFile to cover removal of this file for non-git channels and logging any failure to remove it.

Add new method to detect if this file exists during web based installation.

Signed-off-by: Alex Harpin <development@landsofshadow.co.uk>
2023-01-10 11:59:06 +07:00
Alex Harpin d5b52ddd21 Log a warning to CLI install command if CAN_INSTALL is not removed
Log a warning for the CLI install command if the CAN_INSTALL file still exists at the end of the installation.  This matches the warning logged by the web installer.

Signed-off-by: Alex Harpin <development@landsofshadow.co.uk>
2023-01-10 11:59:06 +07:00
Joas Schilling c8160a6150
Merge pull request #35873 from leegarrett/35830_lgarrett
Implement occ status command via return codes v2 (Fixes: #35704)
2023-01-04 09:51:12 +07:00
Joas Schilling 2c1a811e27
No output by default when --exit-code is used
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-03 15:43:25 +07:00
Joas Schilling 8e1f742355
Print output also with status code
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-03 12:47:58 +07:00
Lee Garrett fba906e34a Implement occ status command via return codes (Fixes: #35704)
Running `./occ status -e` will produce any output. However, it will:

exit 0 during normal operation,
exit 1 when in maintenance mode,
exit 2 when `./occ upgrade` is needed.

Signed-off-by: Lee Garrett <lgarrett@rocketjump.eu>
2023-01-03 10:58:07 +07:00
Côme Chilliet 9430899f16
Fix psalm issues related to signature changes from PHP 8.0
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-29 12:36:34 +07:00
Julius Härtl 1da6c21036
Show version from appinfo on occ app:list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-11 14:45:11 +07:00
Robin Appelman 7dc8e6a014
fix repairing non user shares when repairing all shares
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 17:13:52 +07:00
Robin Appelman b66779711f
split repairing into two stages to prevent long open transaction
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 17:13:44 +07:00
Robin Appelman 8012c85d3e
update shares directly in db
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 17:13:41 +07:00
Vincent Petry 1be1c23c05
More verbose output for repair share ownership cmd
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-08 17:13:37 +07:00
Robin Appelman 3d68a526e7
move share owner repair to occ command
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 17:13:33 +07:00
Louis e4d3344076
Merge pull request #32859 from nextcloud/bug/31973/array-key-might-be-empty
Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39
2022-10-11 11:15:05 +07:00
Roeland Jago Douma aaf9b9c4fd
properly typehint generated migrations
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2022-10-09 21:26:16 +07:00
timm2k 6ff58d30b4
Update ConvertFilecacheBigInt.php
Signed-off-by: timm2k <timm2k@gmx.de>
2022-09-14 10:15:16 +07:00
Côme Chilliet 9a29025534
Parameter of RepairAdvanceEvent is actually an increment, not a step id
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:26:31 +07:00
Côme Chilliet 652ab6da3f
Surround cli output with appropriate xml tags
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:18:53 +07:00
Côme Chilliet 5cfdf9b9ee
Add void return types to callables
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:15:49 +07:00
Côme Chilliet a2a7150d6d
Migrate Repair events to OCP\EventDispatcher\Event
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:15:48 +07:00
Côme Chilliet a83a8f0dde
Migrate Migrator::executeSql to OCP\EventDispatcher\Event
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:13:47 +07:00
Côme Chilliet 5aac997d44
Remove listeners of \OC\DB\Migrator::checkTable which is never emitted
See commit a2f3077ee8 from PR #24384

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:13:47 +07:00
Côme Chilliet 4f260dce6e
Moving to string key for arguments of GenericEvent in Repair
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:13:46 +07:00
Côme Chilliet 4ba30d40cf
Switch to string keys for argument of GenericEvent for OC\DB\Migrator
It seems checkTable is actually never dispatched?

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:13:46 +07:00
Adam Blakey a676a67b9e Fixed logic issue where checking for wrong option
Signed-off-by: Adam Blakey <adam@blakey.family>
2022-08-15 21:59:16 +07:00
Adam Blakey e9fb7a2885 added --enabled and --disabled options to occ app:list
Signed-off-by: Adam Blakey <adam@blakey.family>
2022-08-15 18:11:17 +07:00
Carl Schwan f8b13ecd60
Merge pull request #32363 from nextcloud/cleanup/remove-long-deprecated-classes
Remove OCP\App and OCP\BackgroundJob
2022-08-08 17:05:11 +07:00
Marcel Klehr 047cc708d4 DB mounts table: Add index for mount_provider_class
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2022-08-01 14:27:34 +07:00
Carl Schwan 458c2fa297
Remove OCP\App and OCP\BackgroundJob
Both deprecated since NC 23

IAppManager is the replacement for OCP\App unfortunately it can't be
dependency injected in classes used by the installed otherwise the
database connection is initialised too early

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-01 09:46:40 +07:00
Côme Chilliet cc89da26c6 Fix background-job:execute command for QueuedJob instances
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
Côme Chilliet 3920fc1ef2 Format the datetime for last run in ATOM format
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
Côme Chilliet 0cc39d185c Use symfony console table to render the job list properly
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
Côme Chilliet 868d748dbf Code cleaning of Background/ListCommand
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
Côme Chilliet 3d01179907 Add command to list jobs
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
Daniel Kesselberg 6f3ab2fc9b
Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-06-28 15:45:41 +07:00
Daniel Kesselberg fb8d54ef72
Fix undefined when no tags
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-06-28 15:44:08 +07:00
Carl Schwan fbae6ffa98 Fix importing float value
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-23 12:08:42 +07:00
Carl Schwan b70c6a128f Update core to PHP 7.4 standard
- Typed properties
- Port to LoggerInterface

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 22:18:06 +07:00
Joas Schilling 106d5f9c5c
Merge pull request #32196 from nextcloud/bugfix/noid/fix-strict-comparison
Fix strict comparison
2022-05-02 08:19:10 +07:00
Côme Chilliet b865722ac0
Remove deprecated occ app:check-code command
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-28 15:08:01 +07:00
Joas Schilling 60801d8b1c
Fix strict comparison
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-27 20:31:40 +07:00
Joas Schilling 2ffcc08332
Fix type fixing
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-25 16:49:23 +07:00
Joas Schilling 7ee982005a
Give hints on correct migration versioning
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-25 16:21:25 +07:00
Julius Härtl 7fbd93b2ad
Additional index on oc_preferences to make sure that gettingh values without a user filter is fast
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-04-19 12:37:36 +07:00
Joas Schilling cfd2e8cc20
Allow to autocomplete user and group ids in commands
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-08 11:54:44 +07:00
blizzz 835e28d0b2
Merge pull request #31661 from nextcloud/enh/user_ldap-add-command-to-unmap-groups
Add ldap:reset-group command to unmap groups from LDAP
2022-04-05 10:57:33 +07:00
Christoph Wurst 498d3aea06
Merge pull request #31687 from nextcloud/enhancement/passwordless-app-passwords
Allow app passwords without login password for occ user:add-app-password
2022-04-04 11:46:17 +07:00
Côme Chilliet 77bdad84c2 Add ldap:reset-group command to unmap groups from LDAP
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-01 12:18:02 +07:00
Côme Chilliet 9191ca43ce
Merge pull request #31735 from nextcloud/fix/noid/mig-generator-copyright
migration generator also includes copyright section
2022-03-29 16:49:43 +07:00
Côme Chilliet 765999f454
Merge pull request #31609 from nextcloud/fix/migrate-away-from-ilogger
Migrate from ILogger to LoggerInterface in lib/private
2022-03-29 09:39:38 +07:00
Arthur Schiwon ee006563ae
migration generator also includes copyright section
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-03-28 15:35:17 +07:00
Côme Chilliet ea23523c70
Adapt more code to migration to LoggerInterface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:25 +07:00
Louis Chemineau 970fb7ce65 Don't create cards_abiduri it if already exists
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-03-24 10:42:22 +07:00
Christoph Wurst 515235163c
Allow app passwords without login password for occ user:add-app-password
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-03-23 18:47:33 +07:00
Joas Schilling ab29a67a32
Allow creating app passwords without validating the user's password again
Aparently the idea behind the command was exactly to do this.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-14 13:30:59 +07:00
Joas Schilling db1c2a5375
Merge pull request #31511 from nextcloud/bugfix/noid/allow-installing-unstable-versions
Allow installing unstable app versions based on channel and with `--allow-unstable` just like on updates
2022-03-11 14:26:30 +07:00
Joas Schilling a4111d4846
Allow installing unstable versions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 16:10:25 +07:00
Joas Schilling 50ccf7e2cf
Validate the password before generating an apptoken
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 15:52:01 +07:00
Joas Schilling f98044ddce
Trigger an event to log an activity when an administrator generates an app password
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 15:25:22 +07:00
Christoph Wurst c1000fe344
Merge pull request #31304 from nextcloud/feature/dry_run_for_add_indices
Add --dry-run option for add-missing-* cmd
2022-02-28 09:59:40 +07:00
Louis Chemineau 405c5eb813 Add --dry-run option for db:add-missing-* cmd
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-02-24 16:42:08 +07:00
Carl Schwan db6927ee05 Improve performance when converting between DBs
Use a transaction when doing multiple inserts increase the writing
speed.

Ref: https://stackoverflow.com/a/68495887

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-16 18:28:06 +07:00
Julius Härtl 415294e345
Add index for direct editing cleanup job
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-07 09:25:27 +07:00
Côme Chilliet 071ceff7e2
Fixes occ user:info when the user never logged in
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-27 16:33:24 +07:00
Côme Chilliet b0e6a10263
Use the new function in user:setting occ command
instead of direct database queries

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-24 11:16:44 +07:00
Vincent Petry 14c60b10d0
Merge pull request #30275 from nextcloud/bugfix/noid/add-version-of-disabled-apps-when-available
Add version of disabled apps when available
2022-01-14 11:59:25 +07:00
Carl Schwan 6312c0df69
Check style update
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 00:19:07 +07:00
Carl Schwan aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-12 20:03:06 +07:00
Christoph Wurst ed84f07784
Add missing index for propertypath only queries against properties
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-12-23 15:51:50 +07:00
Joas Schilling a376aa6c61
Add version of disabled apps when available
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-15 09:08:14 +07:00
John Molakvoæ 5a766ef004
Allow to delete non-migrated previews instead of moving them
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-12-09 17:34:45 +07:00
Joas Schilling 536a812de4
Add an index for selecting the next job
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 23:57:40 +07:00
Côme Chilliet 113756db30
Fix ArrayAccess and JsonSerializable return types
First round of modifications for PHP 8.1

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:56 +07:00
Christoph Wurst 781ec814e6
Do not print verbose info about app updates if there are none
This is cosmetical but if you have a large number of apps installed then
you'll see a wall of text during the server and app upgrade when it
tries to update each app via the app store. In may cases nothing will be
updated. For those boring cases we can hide the verbose info, but show
when occ is run with -v. Any actual update will still print a few lines.
Those are the important ones for the admin.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-11-18 09:11:22 +07:00
Robin Appelman 5155f2b0c5
Merge pull request #28541 from nextcloud/path-prefix-index2
add a prefix index to filecache.path, attempt 2
2021-10-19 14:41:23 +07:00
Joas Schilling 0a812a1c09
Adjust namespace and print a message when the job was skipped
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-14 09:57:16 +07:00
Joas Schilling 9cd9f4b4bc
Move queries to the joblist
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-14 09:57:16 +07:00
Joas Schilling e2a7482b49
Add a command to show info about a background job and force-execute it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-14 09:57:16 +07:00
Robin Appelman 695326534c
disable path prefix index on postgresql for now
having the index work properly for the queries we need it for requires some additional options which dbal does not support at the momement.
to prevent making it harder to add the correct index later on we don't create the index for now on postgresql

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-08 18:39:22 +07:00
Robin Appelman abd6b354ac
add a prefix index to filecache.path
The reason that `filecache.path` hasn't had an index added is the mysql limitation of ~1kb for indexeded fields,
which is to small for the `path`, however mysql supports indexing only the first N bytes of a column instead of the entire column,
allowing us to add an index even if the column is to long.

Because the index doesn't cover the entire column it can't be used in all situations where a normal index would be used, but it does cover the `path like 'folder/path/%'` queries that are used in various places.

Sqlite and Postgresql don't support prefix indexes, but they also don't have the 1kb limit and DBAL handles the differences in index creation.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-08 18:38:25 +07:00
Robin Appelman 6502dfae34
add better index for finding unindexed paths
for the following query 'SELECT "path" FROM "oc_filecache" WHERE ("storage" = $storage) AND ("size" < 0) ORDER BY "fileid" DESC LIMIT 1;'

currently the database will in some cases decide to priorize the sort by fileid over the filter when picking what index to use, resulting in a much slower query.

by creating an index that allows first sorting by fileid and also filter by storage and size this case will be greatly sped up

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-07 16:11:49 +07:00
Carl Schwan 59174cfa7c
Merge pull request #28492 from nextcloud/bugfix/occ-status
Align occ status with status.php
2021-09-30 17:45:22 +07:00
Arthur Schiwon 27865d03c0
use specific email getter where necessary
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +07:00
Julius Härtl 3b6be67719
Align occ status with status.php
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-08-26 22:36:26 +07:00
Julius Härtl d201dc2c93
Add active user count to occ user:report
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-08-19 16:22:20 +07:00
John Molakvoæ (skjnldsv) edeb8a5739
Add storage info to `user:info` command
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-08-18 08:38:49 +07:00
Joas Schilling 5390d3194f
Make integrity commands verbose
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-07-08 21:21:57 +07:00
Christoph Wurst 770881d5d6
Move DateTime::ATOM to DateTimeInterface::ATOM
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-23 15:28:07 +07:00
Louis Chemineau f40150b758 Fix typing error
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-06-21 14:14:37 +07:00
Christoph Wurst bf564e2a5a
Convert command option defaults to strings
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-09 13:25:31 +07:00
Christoph Wurst 932a385c56
Merge pull request #27429 from nextcloud/bug/26085/wrong-data-add-order-by
Don't pass a column object to addOrderBy
2021-06-09 09:12:03 +07:00
Daniel Kesselberg 11cacf63f8
Fix #26085
addOrderBy expects a order expression. For the migration scenario we have column objects. Column objects are not supported by quoteColumnName yet.

A column object as order expression is most likely an edgy thing when migration database information.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-06-08 16:30:44 +07:00
John Molakvoæ (skjnldsv) 215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
Valdnet 9c6b01abeb
l10n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-02 17:49:32 +07:00
John Molakvoæ 8b0ce8c8a1
Merge pull request #27099 from nextcloud/bugfix/noid/make-user-report-scale 2021-05-26 15:18:41 +07:00
Joas Schilling f9b407d0c9
Make user:report command scale
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-26 11:33:09 +07:00
Morris Jobke 726d01843e
Merge pull request #26600 from hosting-de/feature/occ-tags
Add commands to manage tags via OCC
2021-05-25 16:54:06 +07:00
Johannes Leuker d606799ee2 Add commands to manage tags via OCC
list, add, delete, edit

Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-05-25 11:29:32 +07:00
Bjoern Schiessle da21e86a07 use the UID as loginName and not the display name.
Otherwise the app password will not work for users with a display name different to the UID.

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2021-05-11 20:38:54 +07:00
Joas Schilling 167efa19d7
Fix psalm errors
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +07:00
Joas Schilling df47445c01
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +07:00
Roeland Jago Douma 14ee17e5c5
Revert "add a prefix index to filecache.path" 2021-04-08 10:09:13 +07:00
John Molakvoæ b9907df702
Merge pull request #26252 from Maxopoly/master
Add force option to app install command
2021-04-07 10:09:48 +07:00
Roeland Jago Douma 9fd29173cf
Merge pull request #26281 from hosting-de/fix/email
Change my email address
2021-03-26 09:59:35 +07:00
Morris Jobke 3388758d04
Remove event listener to udpate events that are not present anymore
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-25 09:01:09 +07:00
Morris Jobke ab48d5e8cb
Cleanup unneeded code around database.xml
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-24 22:15:44 +07:00
Joas Schilling bb0c50717c
Bye bye database.xml
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-24 20:04:12 +07:00
Johannes Leuker e9ca59ef0a Change my email address
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-24 15:13:56 +07:00
Maxopoly 1f93721097 Add force option to app install command
Signed-off-by: Maxopoly <max@dermax.org>
2021-03-22 23:49:13 +07:00