Commit Graph

141 Commits (c6dd592d60d30fe28cb7ebd9e271ef244ee42fdf)

Author SHA1 Message Date
Carl Schwan 3c9b937e28
refactor(comment): Port away from deprecated event comment constant
Create new events to replace deprecated CommentsEvent constant and use
them when creating CommentsEvents.

On the listener side, we can't yet use these events as deck still send
the old events.

Also fixes some issues reported by psalm level 3 on the comment app.

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-12-04 17:38:53 +07:00
Joas Schilling d332091105
fix(comments): Don't throw type error when no itemType or itemId is given
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-10-09 16:35:16 +07:00
Carl Schwan aa1f5312a5 refactor: Remove legacy search provider
Last usage was in the comment app

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-01 13:36:25 +07:00
provokateurin 6a12fbc4f3
refactor: Run rector
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-09-27 18:52:58 +07:00
Daniel Kesselberg a37ed05b8f
fix(comments): use showFile route to reference files with a matching comment
The files.view.index route with dir and scrollto is deprecated and
opening the actual does not work anymore.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-09-03 10:58:52 +07:00
Daniel Kesselberg e80d89b7a1
Revert "fix(comments): use showFile route to reference files with a matching comment"
This reverts commit 317cd25497.
2025-09-02 21:34:49 +07:00
Daniel Kesselberg 317cd25497
fix(comments): use showFile route to reference files with a matching comment
The files.view.index route with dir and scrollto is deprecated and
opening the actual does not work anymore.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-09-02 21:34:03 +07:00
Ferdinand Thiessen 5981b7eb51
chore: apply new CSFixer rules
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +07:00
provokateurin f3bed2c340
fix(comments): Fix activity rich subject parameters
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-17 06:23:40 +07:00
Côme Chilliet 64863c9d46
chore: Apply new rector configuration to apps folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:46:42 +07:00
Côme Chilliet a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +07:00
provokateurin 381077028a
refactor(apps): Use constructor property promotion when possible
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
Joas Schilling 096f893d46
fix(activity): Update more activity providers to use new exceptions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 12:31:59 +07:00
provokateurin 9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
Anna Larch 1ce46c1fca refactor: move to new activity exception
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-17 12:06:24 +07:00
Daniel Kesselberg af6de04e9e
style: update codestyle for coding-standard 1.2.3
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
Andy Scherzinger 014fcb0131
Merge pull request #45950 from nextcloud/chore/remove-depreacted-search
chore: Remove deprecated legacy search backend
2024-08-01 13:56:09 +07:00
Julius Härtl a6d421e767
chore: Remove deprecated legacy search backend
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-01 12:33:18 +07:00
skjnldsv 80231e60aa fix(activity): regroup Files and spltit sharing activity
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-01 11:03:24 +07:00
provokateurin bec0653d2a
refactor(comments): Replace security annotations with respective attributes
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-25 13:14:45 +07:00
Julius Härtl 9713dd3fa9
chore: Move comments event handler to use proper event dispatcher
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-06-26 18:13:07 +07:00
Joas Schilling 8130968a35
feat(notifications): Migrate server INotifiers to new exceptions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-25 11:56:24 +07:00
Andy Scherzinger 9d4b944098
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-27 20:11:22 +07:00
Côme Chilliet ec5133b739 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
Vincent Petry 839ddaa354
feat: rename users to account or person
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +07:00
Côme Chilliet 8bcc2d352e chore: Fix missing template parameter for IEventListener
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 10:57:15 +07:00
provokateurin b64ab5fba8
refactor: Migrate IgnoreOpenAPI attributes to OpenAPI
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-01-18 16:14:17 +07:00
Ferdinand Thiessen 529dcc3f23
chore(comments): Drop dead code from comments app
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-12 14:42:11 +07:00
Joas Schilling aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
Ferdinand Thiessen db2fec1cec
feat(comments): Use activity tab to mount comments sidebar section if available
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-16 11:54:52 +07:00
Hamid Dehnavi 92b75bc798 Make adjustments based on the review
Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-28 09:16:03 +07:00
Hamid Dehnavi 878288004e Refactor comments app
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-28 09:16:03 +07:00
John Molakvoæ (skjnldsv) a5a8655beb fix: avoid side-effect imports
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2023-09-21 12:40:42 +07:00
jld3103 8f0a35e13f
comments: Ignore endpoints in OpenAPI
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-09-04 20:23:24 +07:00
Joas Schilling c3bc575d99
fix(comments): Emit CommentsEntityEvent as typed event
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-18 16:19:01 +07:00
jld3103 58746575dc
comments: Add OpenAPI spec
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-10 09:20:14 +07:00
Côme Chilliet fc3ac4d974
Merge pull request #38605 from fsamapoor/replace_strpos_calls_in_comments_app
Refactors "strpos" calls in /apps/comments
2023-06-29 10:32:08 +07:00
Carl Schwan 9725d00329
Cleanup comments code
- Fix various psalm issues
- Add as much typing as possible while preserving stable API

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-06-20 10:55:20 +07:00
jld3103 4cd07d79a7
comments: Stop using a service alias for controller
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-06-19 08:12:25 +07:00
Faraz Samapoor 7e33e59730 Refactors "strpos" calls in /apps/comments to improve code readability.
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-12 09:45:12 +07:00
Côme Chilliet d9151ff35c Get rid of all useless calls to setParsedSubject now that setRichSubject is able to do it
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-29 14:36:29 +07:00
Joas Schilling 71065f5fd5
Merge pull request #33615 from nextcloud/perf/noid/user-displayname-cache-for-activity-providers
Use user name cache in activity providers
2022-08-19 12:28:44 +07:00
Joas Schilling 7e11778190
Use user name cache in activity providers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-19 10:48:32 +07:00
Joas Schilling ae67eba84b
Use user displayname cache for comment mentions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-19 10:23:16 +07:00
Carl Schwan fa266165d6 Modernize comments app
* Use php 7.4 typed properties
* More typed methods (and replace existing php doc in some cases)
* query -> get for Container

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-03-16 13:14:15 +07:00
John Molakvoæ (skjnldsv) 87d0904b6f
Split common vendor chunk
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-01-08 10:14:50 +07:00
Valdnet 2881e4beb3
l10n: Correct spelling
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-12-15 17:20:03 +07:00
John Molakvoæ (skjnldsv) 215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
Roeland Jago Douma 0593b039fc Move over notification to new registration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +07:00
Roeland Jago Douma 8988406789 Move comments to initial state
* Do not extend the jssettings
* Just use the proper intial state
* Use it in the js code as well

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 20:31:56 +07:00