84749d53a9
Refactor lib/private/App
...
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2024-02-23 15:53:41 +07:00
e69ca0632a
Refactor `OC\Server::getEventLogger`
...
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-02-23 15:49:01 +07:00
55eb6048fa
Refactor `OC\Server::getTrustedDomainHelper`
...
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-02-23 15:45:40 +07:00
f461c79c58
Refactor `OC\Server::getAppFetcher`
...
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-02-23 15:43:46 +07:00
cc3c7c24a1
set a default and max ttl for redis keys
...
having infinite TTL can lead to leaked keys as the prefix changes with version upgrades
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-23 15:41:51 +07:00
6ad335e229
Fix location of the profiler data
...
This prevents collision with an user who could be named 'profiler'
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2024-02-23 15:30:18 +07:00
747aeded9d
fix xml ocs response for serializable objects
...
Signed-off-by: sualko <klaus@jsxc.org>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-02-23 14:49:22 +07:00
01983d50d4
feat(share): save date and time for expiration
...
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-02-22 11:26:01 +07:00
df6175ccb1
feat(AppFramework): Add Route attribute
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-02-21 12:07:50 +07:00
66e7056c5e
fix(Routing): Only use lowercase names for registering and matching routes
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-02-21 12:07:50 +07:00
b7527af8be
Merge branch 'master' into bugfix/fixed-get-filename-in-fileinfo
2024-02-21 11:18:00 +07:00
fd679e2018
fix(notifications): Help finding missing notifications by logging it
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-20 16:03:42 +07:00
c98b0462e3
fix(admin role): fix old and wrong way to determine whether user is admin
...
- fixes Settings knowing who is an admin of non-local group backend groups
- obsoletes and removes a little old, deprecated code
- double checks proper parameter type on Group\Manager::isAdmin
- also fixes legacy OC_User code to check whether user is an admin
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-02-19 18:57:22 +07:00
b104306367
Merge branch 'master' into bugfix/fixed-get-filename-in-fileinfo
2024-02-19 20:29:30 +07:00
1bc8129623
Merge pull request #43339 from nextcloud/fix/42588/remove-redundant-indices
...
fix(db): remove redundant indices in properties
2024-02-19 15:20:07 +07:00
827cda8599
Merge pull request #43637 from nextcloud/mb-convert-fix
...
Move away from deprecated utf8_encode() on PHP 8.2+
2024-02-19 15:11:11 +07:00
1c085a96eb
Fixes for getting the file name in the cases when the file name key is received, but it is empty
...
Signed-off-by: hopleus <hopleus@gmail.com>
2024-02-19 16:25:43 +07:00
d52ebaa7cd
Merge pull request #43297 from nextcloud/fix/db/dirty-read-cool-off
...
fix(db): Let dirty writes cool off
2024-02-19 10:53:05 +07:00
1f46e4b854
fix(db): Let dirty writes cool off
...
We can assume that after a few seconds a read will be clean again.
This is helpful for false warnings in long running processes.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-19 10:13:24 +07:00
82af5cc592
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-02-19 00:19:00 +07:00
21e8aadc1f
fix(db): remove redundant indices in properties
...
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2024-02-18 21:02:42 +07:00
85f28856cf
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-02-18 00:19:47 +07:00
d753d04760
Move away from deprecated utf_encode() on PHP 8.2+
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-02-17 21:37:34 +07:00
0ed6d3032d
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-02-17 00:19:03 +07:00
bb87232882
Merge pull request #40555 from nextcloud/query-optimize-distribute
...
optimize query pattern used by storage filter
2024-02-16 11:24:35 +07:00
3890aa54be
add some comments for the distributive operation and add another test
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-16 10:59:33 +07:00
fcfd530d2e
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-02-16 00:19:11 +07:00
1c87cee5ad
add extra flatten step to improve "or eq" -> "in" optimization
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-15 17:55:44 +07:00
63ffaab95e
fix types + autoloader
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-15 17:55:43 +07:00
7ca516773f
add a search query step to split IN statements that are to large for oci
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-15 17:55:43 +07:00
2dcd0a8759
hopefully improve propagation of 'path eq hash' hint into 'in' statements
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-15 17:55:42 +07:00
2e14a7a4a6
optimize query pattern used by storage filter
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-15 17:55:40 +07:00
9f38aabc06
Merge pull request #43552 from nextcloud/bugfix/noid/rfc7239-compatible-proxy-handling
...
fix(request): Handle reverse proxy setting a port in Forwarded-For
2024-02-15 15:29:47 +07:00
cf17a20835
fix(db): Give dirty read exception a message
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-15 09:14:47 +07:00
3b0a9e6639
fix(OCP): Add since tag to all constants
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-15 08:06:43 +07:00
c83a657652
Merge pull request #43355 from nextcloud/feat/ocp-link-reference-provider
...
feat: Migrate LinkReferenceProvider to OCP
2024-02-15 11:26:10 +07:00
8cebd2b7c0
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-02-15 00:20:01 +07:00
42be7a5d74
fix(OCP): Add since tag for all constants
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-14 20:50:08 +07:00
f14949218c
fix(settings): Deprecate old things for real
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-14 20:50:07 +07:00
2232753b99
add hasListeners()
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-14 14:02:28 +07:00
696ed4a125
fix(CS): Fix coding style
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-14 15:38:15 +07:00
7329b83f92
feat: Migrate LinkReferenceProvider to OCP
...
This would be useful to eleminate the need for using this OC class
when an app dev wants to implement a custom reference provider
for the web client but wants to fall back on opengraph for mobile
clients.
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-02-14 18:22:19 +07:00
6580bef319
Use the STT provider's exception message in the RuntimeException that will be caught by upper contexts
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-02-14 13:23:37 +07:00
9a299ed60b
exit log() early if no crashreporter registered
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-14 09:40:21 +07:00
3fb1674251
Merge pull request #43461 from nextcloud/fix/get-rid-of-getlogger
...
chore: Migrate away from OC::$server->getLogger
2024-02-14 10:47:22 +07:00
fea2277b63
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-02-14 00:19:31 +07:00
524ed97d62
fix: replace `Account name` by `Login`
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:08:10 +07:00
4a509dfe8e
fix: phpunit
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:06:31 +07:00
9593f4d6f9
fix: openapi
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:06:31 +07:00
839ddaa354
feat: rename users to account or person
...
Replace translated text in most locations
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +07:00
c0ce272e9c
chore: Migrate away from OC::$server->getLogger
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-13 17:32:30 +07:00
c4684089a8
fix(request): Fix regex handling and coding-style
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-13 16:51:13 +07:00
ffcadf25d4
fix(request): Handle reverse proxy setting a port in Forwarded-For
...
Signed-off-by: Mikael Peigney <Mika56@users.noreply.github.com>
2024-02-13 16:51:13 +07:00
6434ce96c9
Add timezone getter to ITimeFactory
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-02-13 13:29:06 +07:00
fd04f058c8
Merge pull request #43542 from nextcloud/fix/db/long-transaction-exception-message
...
fix(db): Unify long transaction log/exception message
2024-02-13 10:13:14 +07:00
56640c7fdd
Merge pull request #39889 from nextcloud/cache-di
2024-02-13 09:40:02 +07:00
aef28e191a
fix(db): Unify long transaction log/exception message
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-13 08:17:49 +07:00
be260d2171
Merge branch 'master' into enh/speech-to-text-provider-with-userid
2024-02-13 09:56:30 +07:00
162537916b
fix missing return statement, inline return
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-02-12 20:47:33 +07:00
c1fc1b29bc
Merge pull request #43424 from nextcloud/enh/noid/debug-on-lazy-appconfig-loading
...
enh(appconfig): debug logs on lazy loadConfig
2024-02-12 18:12:54 +07:00
592012034e
Merge pull request #43370 from nextcloud/test-iappconfig
...
[IAppConfig] new tests
2024-02-12 18:09:13 +07:00
e9d97a568f
use OCP\Server
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-12 16:39:00 +07:00
809e0fe923
fix phpdoc
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-12 13:23:36 +07:00
3e58a2501f
use exception for cleaner Trace
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-12 12:53:46 +07:00
61f58e8043
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-02-12 00:19:03 +07:00
2b1057721a
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-02-11 00:19:34 +07:00
b03199e1cb
Merge pull request #42991 from nextcloud/lowToInfo
...
Lower failed movie preview generation logs to level info
2024-02-10 13:46:27 +07:00
786894f15c
Fix typo in var
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-02-09 14:41:26 +07:00
e50c176428
also improe cache ci for shared cache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-09 14:00:26 +07:00
7a91abb439
improve di performance for cache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-09 13:28:30 +07:00
963721330f
only get the path for the users cached mount info when we use it
...
most of the time we shouldn't need it so we can save joining on the filecache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-09 09:50:43 +07:00
a37b6c7e5f
fix!: Remove deprecated `RegisterWidgetEvent`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-09 01:34:03 +07:00
303e2febc7
Merge pull request #43387 from nextcloud/fix/migrate-away-from-ilogger-in-jobs
2024-02-08 18:27:44 +07:00
8fd2289058
Merge pull request #43357 from nextcloud/enh/41253/fix-occ-upgrade
...
fix(migration): Make naming constraint fail softer on updates
2024-02-08 18:27:39 +07:00
cdf7840d00
Merge pull request #43454 from nextcloud/fix/cleanup-cron-php
...
Cleanup cron.php method calls
2024-02-08 16:21:02 +07:00
898df41de9
Revert "Merge branch 'master' of github.com:nextcloud/server"
...
This reverts commit d9d60238c7ba3fdb0cdc
2024-02-08 15:31:19 +07:00
cf6a0e0833
chore: Deprecate OC_App::loadApps and add missing return type in Server
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 14:34:01 +07:00
e78e27187a
chore: Delete deprecated internal Job classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 10:28:29 +07:00
65981f99bf
chore: Migrate away from internal Job classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 10:28:29 +07:00
166773879b
fix!: Migrate jobs away from deprecated interfaces
...
BREAKING CHANGE: Removed ILogFactory::getCustomLogger deprecated method
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 10:28:29 +07:00
487c33f479
fix(migration): Make naming constraint fail softer on updates
...
Only on installation we want to break hard, so that all developers notice
the bugs when installing the app on any database or CI, and can work on
fixing their migrations before releasing a version incompatible with Postgres.
In case of updates we might be running on production instances and the
administrators being faced with the error would not know how to resolve it
anyway. This can also happen with instances, that had the issue before the
current update, so we don't want to make their life more complicated
than needed.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-07 20:45:51 +07:00
70a229da50
redundant condition
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-07 12:24:57 +07:00
2122a81419
fix getAllValues() to filter values based on prefix
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-07 12:24:57 +07:00
ae8d6b6b69
debug lazy loadConfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-07 08:35:00 +07:00
bea8bf9032
Merge pull request #43317 from nextcloud/fix/contacts-name
2024-02-07 10:23:22 +07:00
5ea69768b0
Merge pull request #41015 from nextcloud/background-scan-catch-storage-error
...
continue background scanning different storages if one fails
2024-02-07 10:06:32 +07:00
414a4caa65
Merge pull request #43361 from nextcloud/fix/add-missing-phpdoc-template-parameters
...
chore: Add missing ArrayAccess template parameters
2024-02-06 15:11:50 +07:00
67a3ab48b5
Merge pull request #43131 from nextcloud/fix/files/cache-wrapper-no-partial-cache-entry-formatting
...
fix(files): Don't attempt to format a partial cache entry
2024-02-06 13:51:51 +07:00
f73f966c98
chore: Add missing ArrayAccess template parameters
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-06 10:24:41 +07:00
8ba2cd4a07
returns non lazy value while searching for lazy
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-06 00:00:58 +07:00
f910baf9f7
Merge pull request #43275 from nextcloud/enh/noid/no-exception-on-missing-key-updatelazy-updatesensitie
...
return false on AppConfigUnknownKeyException
2024-02-05 16:21:02 +07:00
d97567a7fd
chore: Add references to phpdoc deprecation notice for IL10N
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-02-05 11:16:04 +07:00
b2e9e0fa0d
chore: Replace OC::$server->getL10N by OCP\Util::getL10N in lib and some apps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-05 11:16:04 +07:00
961ccee5f6
Make it clear in the deprecation comment that DI is preferred
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-05 11:16:04 +07:00
1332078be1
Use OCP\Util::getL10N instead of OC::$server->getL10N
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-05 11:16:04 +07:00
6f4d0fe79c
Lower failed movie preview to info
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-02-03 18:52:05 +07:00
2c8aee8f99
fix(ContactsStore): Sanitize user ID given to guest avatar route
...
It is not allowed to use slashes within path parameters, so they would need to be encoded.
But URL encoded slashes are not suported by Apache, so instead replace slash with space.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-03 11:32:51 +07:00
8a4bd3b932
Merge pull request #40981 from nextcloud/fix/object-storage-user
...
fix(objectstorage): cleanup HomeObjectStoreStorage
2024-02-02 20:57:01 +07:00
30798eb6c2
refactor(objectstorage): cleanup types
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-02-02 14:59:21 +07:00
3be3dbdb3b
refactor(objectstorage): move $user property from ObjectStoreStorage class to HomeObjectStoreStorage
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-02-02 14:59:21 +07:00
4c618c4bf1
fix(objectstorage): cleanup HomeObjectStoreStorage
...
Fix invalid signature for getUser() method and change occurences of OC\User\User for OCP\IUser
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-02-02 14:59:20 +07:00
860caa0849
make failure to load app commands non-fatal
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-02 13:47:17 +07:00
1b2e503e7f
return false on AppConfigUnknownKeyException
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-01 21:51:17 +07:00
b838237f82
Merge pull request #43132 from nextcloud/enh/41755/update-appframework-api
...
sync with new OCP\IAppConfig
2024-02-01 19:51:47 +07:00
edaa436345
add key location to info:file output
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-01 15:32:33 +07:00
4993dac98f
Merge pull request #43203 from nextcloud/fix/cleanup-register-command-with-di
...
Use Dependency Injection in register_commands.php
2024-02-01 14:44:07 +07:00
2bfb6fc731
fix: Make Repair object injectable and fix BackgroundRepair test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-01 09:49:32 +07:00
e1d7328bb2
adding test
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-31 21:13:32 +07:00
51fa22dc26
fix psalm
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-31 21:13:32 +07:00
86835ee899
sync with new OCP\IAppConfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-31 21:13:32 +07:00
3066687c7d
Merge branch 'master' into background-scan-catch-storage-error
2024-01-31 19:42:58 +07:00
b777304a77
also updated parent etags when a changed etag is detected during scanning
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-31 18:06:18 +07:00
e14bceb63f
dont reuse etag for folders marked explicitly unscanned
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-31 18:05:09 +07:00
a6f879e154
dav: fix wrong decoding of pluses in URLs
...
PHP's urldecode function does not decode URLs according to RFC 3986, but
according to the HTML 4.01 query parameter
encoding. This results in pluses being wrongly decoded to spaces even
though they should not be decoded at all.
Use rawurldecode instead, which follows RFC 3986 properly.
This fixes an issue where files on DAV shares containing pluses were
incorrectly decoded to spaces.
Fixes : #15849
Signed-off-by: Lorenz Brun <lorenz@brun.one>
2024-01-31 13:26:04 +07:00
7dc5a91f71
Merge pull request #38173 from arawa/feature/37677/exclude-some-groups-from-sharing-with-users
...
New core setting : shareapi_only_share_with_group_members_exclude_gro…
2024-01-31 13:24:47 +07:00
6594360638
Merge pull request #42933 from nextcloud/fix/db/dirty-read-on-primary
...
fix(db): Execute dirty reads on the primary node
2024-01-31 10:55:05 +07:00
9af96d9f9a
feat(php,vue): Create a new parameter
...
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +07:00
6c49e9c68a
Revert "switching to new IAppConfig"
...
This reverts commit c693c58d25
2024-01-30 18:37:09 +07:00
c693c58d25
switching to new IAppConfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-30 18:33:50 +07:00
ceff16bbf9
chore: Fix DI for integrity checker before installation
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 16:31:05 +07:00
0e1931754a
chore: use DI for \OC\Repair
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 16:07:02 +07:00
c1d67cc614
chore: Fix DI for Encryption\DecryptAll command
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 16:03:17 +07:00
52f3616254
Merge pull request #43194 from nextcloud/fix/fix-psalm-missing-template-parameter
2024-01-30 15:24:42 +07:00
97152de9bf
fix(db): Execute dirty reads on the primary node
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-30 12:17:39 +07:00
e0053e1c06
Merge pull request #43185 from nextcloud/feat/db/dirty-queries-production
...
feat(db): Make dirty query logging available in production
2024-01-30 12:05:49 +07:00
6533431c36
Merge pull request #43191 from nextcloud/fix/use-di-for-setup-class
2024-01-30 11:10:52 +07:00
8bcc2d352e
chore: Fix missing template parameter for IEventListener
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 10:57:15 +07:00
911ab393c0
feat(db): Make dirty query logging available in production
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-30 10:31:03 +07:00
1f6279fa76
Merge pull request #43031 from nextcloud/fix/fix-throw-phpdoc-in-setupresult
2024-01-29 22:10:53 +07:00
85978593fe
Merge pull request #42794 from nextcloud/fix/invalid-trusted-proxies
...
fix(Request): Catch exceptions in `isTrustedProxy`
2024-01-29 16:19:51 +07:00
67e3ecef98
chore: Cleanup Installer class as well
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 16:10:31 +07:00
ccc66e912b
fix: Use DI for Setup class and move away from deprecated methods
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 15:28:00 +07:00
a2eacf4487
Document throwing behavior of SetupResult upon invalid rich object
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 14:14:17 +07:00
3749c2c79b
Merge pull request #42930 from nextcloud/fix/6914/overwritecond
...
Fix: config param 'overwritecondaddr' not working
2024-01-29 09:56:56 +07:00
f36a9d09f2
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-28 00:19:08 +07:00
30ad530814
code style: ommited space, reverted [code review]
2024-01-27 15:11:26 +07:00
446ecbc454
fixing bug #6914 : Config Param 'overwritecondaddr' not working
...
- just ignoring/removing extra parameter 'protocol' as suggested by
blizzz
Signed-off-by: Pavel Kryl <pavel@kryl.eu>
2024-01-27 15:11:26 +07:00
7620d230df
fix(Request): Catch exceptions in `isTrustedProxy`
...
The function fails if the configured trusted proxies contain invalid characters and the underlying IpUtils will throw.
But as it is used by `getRemoteAddress` which is used by logging / templating, thrown errors are not reported but silently fail with error 500.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-27 14:59:51 +07:00
764f34c4f6
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-27 00:19:36 +07:00
7e5303bec7
fix(files): Don't attempt to format a partial cache entry
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-25 19:30:38 +07:00
8362025643
better indexes
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-24 20:01:56 +07:00
8c777145f2
Merge pull request #42597 from nextcloud/perf/s3-mkdir-update-size
...
perf: Avoid updating the folder size if we know the size difference
2024-01-23 19:39:28 +07:00
582ec1294a
fix(apps): Fix type information of app manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-23 09:55:06 +07:00
033a654389
Merge pull request #42929 from nextcloud/fix/db/transacted-read-not-dirty
...
fix(db): Do not log transacted reads as dirty read
2024-01-23 09:34:20 +07:00
03774ad77c
Merge pull request #42971 from nextcloud/fix/auth/login-email-password-login-name-mismatch
...
fix(auth): Fix logging in with email and app password
2024-01-22 10:41:48 +07:00
af313a79e8
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-21 00:19:16 +07:00
7f2fdd8843
fix(auth): Fix logging in with email, password and login name mismatch
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-19 19:29:41 +07:00
3cf66ae156
Add "-i" to sendmail's pipe
...
Signed-off-by: FedericoHeichou <federicoheichou@gmail.com>
2024-01-19 17:08:01 +07:00
9f6df9171b
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-19 00:19:27 +07:00
ab0d7c007d
fix(db): Remove very verbose dirty query logs
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-18 18:33:07 +07:00
f54b08c224
fix(db): Do not log transacted reads as dirty read
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-18 13:37:36 +07:00
c4f4c5a3fb
Merge pull request #41067 from Murena-SAS/preview-folder-deletes
...
Fix for previews not being generated sometimes
2024-01-18 11:46:12 +07:00
0e40457b86
Merge pull request #42847 from nextcloud/fix/42843/exception-on-their-own
...
exceptions on their own
2024-01-18 09:59:36 +07:00
e42f511412
Merge pull request #42860 from nextcloud/jr/fix/i42858
...
Update ContactsStore: Avoid exceptions on empties
2024-01-17 10:39:16 +07:00
0492e0f1d4
Revert "add key location to info:file output"
...
This reverts commit 7bf82fc312
2024-01-17 17:53:37 +07:00
7bf82fc312
add key location to info:file output
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-17 17:47:01 +07:00
72e0618f20
fix(session): Avoid two useless authtoken DB queries for every anonymous request
...
Co-Authored-By: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-17 09:17:23 +07:00
36e0b02712
Update ContactsStore: Avoid exceptions on empties
...
Fixes #42858 and makes things more robust
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-01-16 23:57:58 +07:00
db8636ac1a
exceptions on their own
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-16 12:48:27 +07:00
addd678682
returns default on exception
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-16 12:35:24 +07:00
fdd38b46e3
Merge pull request #41755 from nextcloud/enh/noid/lazyconfig
...
Lazy grouping within IAppConfig
2024-01-16 08:39:13 +07:00
85849767f2
Merge pull request #42806 from nextcloud/bugfix/noid/only-send-subscription-key-to-our-appstore
2024-01-16 10:16:05 +07:00
80d58f0162
Merge pull request #41312 from nextcloud/feat/migrate-code-integrity-check
2024-01-16 09:04:24 +07:00
587057b0ed
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-16 00:18:51 +07:00
94fe48c998
small fixes
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-15 15:45:13 +07:00
6daea857ab
fixes
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
d
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-15 15:45:13 +07:00
f7d0c74b10
lazy AppConfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-15 15:45:13 +07:00
57a30e9bbe
fix(appstore): Only send subscription keys to valid appstores
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-15 15:39:45 +07:00
d481515081
Improve validator output in case of invalid RichObject
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:48 +07:00
32bf74af16
Merge pull request #42768 from nextcloud/errorToWarn
...
(dashboard): Lower error to warning log message
2024-01-15 11:38:05 +07:00
083a9d8fb2
Merge pull request #42670 from nextcloud/enh/noid/occ-background-job-delete
...
occ background-job:delete
2024-01-15 09:36:36 +07:00
53ad3a58ab
Lower to info
...
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-01-15 09:29:22 +07:00
243d352b26
result of build/autoloaderchecker.sh
...
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2024-01-15 10:35:09 +07:00
913f62982e
Merge branch 'master' into enh/speech-to-text-provider-with-userid
2024-01-15 10:32:25 +07:00
cdf9d94423
Adds new exception to check for the availability of the index.
...
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-01-15 10:36:02 +07:00
2845071854
Refactors lib/private/FullTextSearch.
...
Mainly using PHP8's constructor property promotion.
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-01-15 10:36:02 +07:00
d01f9e5fd5
Lower error to warning
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-01-14 22:45:48 +07:00
156013a711
introduce IProviderWithUserId
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2024-01-14 22:44:37 +07:00
ea7f1f9ecd
move setting of userId before provider execution
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-01-14 20:44:43 +07:00
13588c7566
Introduce ISpeechToTextProviderWithUserId
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-01-14 18:47:40 +07:00
296096e069
fix: Add reconnect check in case of timeouts on the db side
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-12 14:38:01 +07:00
cc75294eb6
perf: Avoid updating the folder size if we know the size difference
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-12 14:21:08 +07:00
c17c42a0b2
feat: First attempt to track dirty tables after writes and switch back to replicas if reads go to other tables
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
debug: error log
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-12 11:02:50 +07:00
3e60092b7d
feat: Add logging for transaction time
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-12 11:02:50 +07:00
bd3df759fb
occ background-job:delete
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-11 23:17:57 +07:00
2df26608ef
Merge pull request #42649 from nextcloud/enh/machine-translation-provider-with-id
2024-01-11 21:50:50 +07:00
f789732922
Merge pull request #42640 from nextcloud/fix/fix-authentication-exceptions-2
...
Always catch OCP versions of authentication exceptions
2024-01-11 18:51:43 +07:00
a526a382bf
Import OCP IToken as OCPIToken to avoid a name clash in lib/private
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 15:45:14 +07:00
6fc224dfce
Document new throw possibility in SetupResult
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:03:55 +07:00
a78abd84ce
Validate rich objects passed to SetupResult
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:03:55 +07:00
f34865eb4e
Add RichObject support for SetupChecks descriptions
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:03:55 +07:00
37a6e15f87
Use OCP version of IToken in AppPasswordCreatedEvent
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +07:00
8fc39aeb1c
Use IToken from OCP instead of OC
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +07:00
95ea6188dc
Suppress or fix psalm errors related to InvalidTokenException
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +07:00
eee9f1eec4
Always catch OCP versions of authentication exceptions
...
And always throw OC versions for BC
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +07:00
477630ed78
Merge branch 'master' into enh/machine-translation-provider-with-id
2024-01-11 13:27:13 +07:00
cfd1cc54c1
Merge pull request #42658 from nextcloud/bugfix/42530/mark-more-configs-as-sensitive
...
fix(systemreport): Mark more configs as sensitive
2024-01-11 12:33:45 +07:00
a6513336b4
fix(autoloaders)
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-11 09:32:30 +07:00
970eb692d1
fix(coding style)
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-10 16:15:06 +07:00
1db8888f99
enh(OCP\Translation): Introduce ITranslationProviderWithUserId
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-10 16:00:24 +07:00
Hamid Dehnavi
Andrew Summers
Robin Appelman
Carl Schwan
Klaus
Benjamin Gaussorgues
provokateurin
hopleus
Joas Schilling
Arthur Schiwon
Johannes
Git'Fellow
hopleus
Christoph Wurst
Christoph Wurst
Nextcloud bot
Johannes Merkel
Joas Schilling
Anupam Kumar
Maxence Lange
Julien Veyssier
F. E Noel Nfebe
John Molakvoæ
Vincent Petry
Côme Chilliet
Mikael Peigney
Anna Larch
John Molakvoæ
Alexander Piskun
Andrey Borysenko
Ferdinand Thiessen
Côme Chilliet
Simon L
Louis Chemineau
Thomas Citharel
Lorenz Brun
Baptiste Fotia
Pavel Kryl
Julius Härtl
FedericoHeichou
Pytal
Josh
Alexander Piskun
Faraz Samapoor
Marcel Klehr