1d43f6b4a9
Merge pull request #53714 from Mark-PAS/master
...
Only attempt $result array access if array not empty.
2025-07-14 11:25:27 +07:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +07:00
b04760af6e
Only attempt $result array access if array not empty.
...
Signed-off-by: Mark <mark@perkinsadministrationservices.com.au>
2025-07-01 07:44:20 +07:00
f48e5aa1f3
fix(user_ldap): Switch to OCP\IAppConfig and fix Helper constructor calls
...
Using OCP\AppFramework\Services\IAppConfig is not possible because the
Helper is queried from places outside of the application DI container
(ajax pages, tests, other applications through ILDAPProviderFactory…)
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-10 16:08:52 +07:00
bc7309ca1c
fix(user_ldap): Store the list of used configuration prefixed in appconfig
...
This avoids getting all keys from appconfig, which was triggering
loading of lazy configuration on all requests.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-10 16:08:45 +07:00
6da579fb1d
fix(user_ldap): Harmonize parameter obfuscation and serialization accross logging methods
...
Debug log, profiler and ldap debug log had a different logic for
sanitizing of parameters, aligning them.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-06-02 11:47:56 +07:00
78a175fc74
refactor: Apply rector refactorings
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-14 15:29:02 +07:00
1ae3fa4003
chore: replace leagcy OC_Helper calls with OCP\Util
...
- Replace legacy calls with OCP\Util
- Add missing deprecation notices
- Inline implementation in OCP\Util and call it from OC_Helper
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-14 10:18:04 +07:00
1eb9000b0d
fix(LDAP): inlcude ldapExpertUsernameAttr in general attribute list
...
fixes corner cases in which an LDAP record might be loaded and used,
where the user is still not mapped - and then this information is
missing though expected.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2025-04-17 17:00:31 +07:00
0cf4f3cc71
fix: Replace all usages of OC_User backend method calls by IUserManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-10 11:29:21 +07:00
5211448940
fix(l10n): put placeholder like string into variable
...
Otherwise this is wrongly handled by our translation community.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-07 18:39:40 +07:00
f033ef7c18
fix: Migrate all uses of OCP\Template to OCP\Template\ITemplateManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +07:00
4fe518a57b
Merge pull request #51096 from nextcloud/fix/noid/ldap-setopt-for-disabling-certcheck
...
fix(LDAP): use ldap_set_option over putenv to disable cert check
2025-03-06 13:00:08 +07:00
71759bf856
feat: Add bases and gidNumber attribute to ldap:test-user-settings output
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-04 10:05:50 +07:00
939a8d5ea5
fix(LDAP): use ldap_set_option over putenv to disable cert check
...
the putenv option was not working reliable anymore anyway
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2025-03-03 12:53:24 +07:00
7facae6b83
fix: remove caching in fetchListOfGroups
...
When using nested groups without a memberof overlay, then fetchListOfGroups is called from getGroupsByMember without applying the group filter.
In some setups, the "unfiltered" result is then written back to the group mapping table. That might cause random "An administrator removed you from group" activities.
I was unable to replicate it locally, but we got the feedback that the random activities stopped with the patch applied.
Ref: https://github.com/nextcloud/server/issues/42195
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-02-27 12:02:44 +07:00
095ab4419e
fix(l10n): Improve english source strings
...
- No leading/trailing whitespace
- Use asci single quote
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-26 09:54:32 +07:00
36d756ab0f
fix(user_ldap): Check that all user and group bases are in the global one
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-25 22:18:18 +07:00
0d35a3df02
fix(user_ldap): Add missing use in ajax endpoint and fix L10N injection
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-25 22:18:18 +07:00
7629d4df17
feat(user_ldap): Improve error detail when saving an incorrect configuration
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-25 22:18:18 +07:00
64863c9d46
chore: Apply new rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:46:42 +07:00
7fa117dd0f
feat(user_ldap): Add a --clearcache option to ldap:test-user-settings
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-30 15:07:15 +07:00
e094602311
fix(user_ldap): Remove redundant if check
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-30 13:47:09 +07:00
1098ef3b69
feat(user_ldap): Add command test-user-settings to test LDAP user settings
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-30 11:55:43 +07:00
e55806b546
feat(user_ldap): upstream common code into Proxy class and add public getters for backends
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-30 11:49:58 +07:00
de77415c70
fix(user_ldap): Do not map groups we do not know if they match filter
...
When nesting is enabled, filterValidGroups is supposed to check for each
groups if it actually exist, because it may not be visible to
Nextcloud. So in this codepath we disable automapping of groups.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-27 14:51:51 +07:00
0815aa0591
fix(LDAP): also log why the connection to main server failed
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2025-01-24 18:55:10 +07:00
2de855f0bc
Merge pull request #50162 from nextcloud/fix/improve-ldap-avatar-handling
...
Improve ldap avatar handling
2025-01-16 21:43:29 +07:00
e187e4e87f
feat(updatenotification): Add a limit to user count from LDAP so save performances
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-14 12:26:24 +07:00
12d1d1d389
fix(user_ldap): Remove now unused class FilesystemHelper
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-13 17:12:19 +07:00
e75dd1fc92
fix(user_ldap): Strong type User class and fix most type issues
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-13 17:12:19 +07:00
40920ddb77
fix(user_ldap): Always update avatar from LDAP when we have the data
...
Should be at login, in sync job, and when running ldap:check-user --update
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-13 16:23:26 +07:00
d2f118f147
chore(user_ldap): Improve typing in user_ldap User class
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-13 16:01:39 +07:00
c0cb8ec7d4
chore(user_ldap): Rename avatar setting method to a more suited name
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-13 15:54:48 +07:00
486f0eda71
fix(user_ldap): retrieve from LDAP first "email shaped" value instead of first value
...
Signed-off-by: Thatoo <Thatoo@users.noreply.github.com>
2024-11-20 16:55:44 +07:00
77114fb327
fix(OpenAPI): Adjust array syntax to avoid ambiguities
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-05 09:58:11 +07:00
e8426996f5
fix(psalm): Fix some newly detected issues
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
a1681b0756
chore(db): Apply query prepared statements
...
Fix: psalm
fix: bad file
fix: bug
chore: add batch
chore: add batch
chore: add batch
fix: psalm
2024-10-17 20:30:47 +07:00
c254855222
chore(db): Correctly apply query types
...
fix: psalm
fix: error
fix: add batch
fix: fatal error
fix: add batch
chore: add batch
chore: add batch
fix: psalm
fix: typo
fix: psalm
fix: return bool
fix: revert Manager
2024-10-17 09:21:07 +07:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:40:25 +07:00
51d9d63a01
chore: Use more gender neutral language
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-14 13:59:24 +07:00
54ec472d9a
fix(BackgroundJobs): Adjust intervals and time sensitivities
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-08 11:26:53 +07:00
8927510685
Merge pull request #48223 from nextcloud/feat/add-rector-config
...
Add rector config
2024-09-23 15:10:30 +07:00
1a4978c4ea
chore: Apply rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-20 17:51:00 +07:00
606241caeb
chore(legacy): Introduce public version ct plass and drop version methods from OC_Util
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-20 14:53:34 +07:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
5cce140701
chore: Remove deprecated `ILogger` logging functions
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:37:06 +07:00
26abc86eca
feat: add profile pronouns
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-17 22:20:36 +07:00
c2fb7a72da
fix(psalm): Fix @throws annotations
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 17:18:30 +07:00
Joas Schilling
Ferdinand Thiessen
Mark
Côme Chilliet
provokateurin
Arthur Schiwon
Daniel Kesselberg
Joas Schilling
Thatoo
Git'Fellow
Côme Chilliet
Julius Knorr
John Molakvoæ (skjnldsv)