443c48aefb
feat(files_sharing): add `new file request` option
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
6136112be1
docs(ShareApiController): Correct note about expiry date timezone
...
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-07-01 13:53:18 +07:00
f5fd6c8f08
fix(files_sharing): Store the expiration date relative to the server's timezone
...
This is needed as we want to store the difference between the server's and the user's timezones.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-26 12:49:42 +07:00
1e04619675
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-06 22:53:41 +07:00
c8a90f04b7
fix(ShareApiClients): Maintain meaning of `''` and null for share api clients
...
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-05-29 12:36:26 +07:00
59a5b4e0bd
fix(shareManager): Respect empty `expireDate` in server
...
If `expireDate` is an empty string and not `null` then the server should not set a default.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-05-23 14:11:33 +07:00
490f545006
fix(sharing): Don't change the type of the controller argument
...
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-18 14:31:45 +07:00
ec8a0a6267
fix(shareApiController): avoid duplicated expiryDate operations
...
`expireDate` can be set once and used anywhere needed, the current implementation,
duplicates this behavior which leads to `parseDate` receiving an a date object it
parsed and returend earlier in the createShare method.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-04-18 02:01:13 +07:00
9a0913afdc
refactor(shareApiController): use contrusctor property promotion & DI logger
...
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-04-18 02:01:08 +07:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
e7a7b4a401
perf: switch places that always use the first getById result to getFirstNodeById
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-04 13:57:31 +07:00
3f269782aa
Merge pull request #43428 from nextcloud/feat/share-expiration-with-time
2024-02-26 10:07:41 +07:00
311d1d2306
fix truncated circleId returned from Share API
2024-02-23 14:43:31 +07:00
01983d50d4
feat(share): save date and time for expiration
...
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-02-22 11:26:01 +07:00
3fb1674251
Merge pull request #43461 from nextcloud/fix/get-rid-of-getlogger
...
chore: Migrate away from OC::$server->getLogger
2024-02-14 10:47:22 +07:00
839ddaa354
feat: rename users to account or person
...
Replace translated text in most locations
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +07:00
c0ce272e9c
chore: Migrate away from OC::$server->getLogger
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-13 17:32:30 +07:00
cc3a2c351a
fix(share): use user timezone to parse share expiration date
...
If an user in UTC+1 try to create a share at 00:00, it's day D for him, but
D-1 for the server (UTC).
This fix aims to apply the correct offset
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-01-09 17:28:11 +07:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
755de1e0b5
refactor: Rename OpenAPI type aliases to their namespaces
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-11-02 11:37:15 +07:00
c2d45cb172
Add single status code descriptions for OpenAPI
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-09-27 08:05:21 +07:00
c6806684d2
files_sharing: Add OpenAPI spec
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-31 16:58:49 +07:00
f5f142d31b
fix: adjust testing
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-07-11 13:52:28 +07:00
6f54f72bb4
feat(sharing): add sharing overview view
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-07-11 13:52:27 +07:00
d2efd0e03c
displayname on federated shares
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-06-28 09:28:03 +07:00
12e3594299
Refactors "strpos" calls in /apps/files_sharing to improve code readability.
...
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-02 20:08:40 +07:00
6b53e4b13a
Mutualize expireDate handling when creating and updating a share
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-27 16:26:24 +07:00
86b17e2248
Update apps/files_sharing/lib/Controller/ShareAPIController.php
...
Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2023-04-18 12:08:38 +07:00
eaaeb32074
fix(l10n): Fixed grammar
...
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2023-04-18 12:08:38 +07:00
c0e84cb512
Add SHARE_TYPE_SCIENCEMESH
...
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
2023-03-08 16:46:55 +07:00
a7abe2c35a
Honor permissions of new link share via OCS API
...
The API currently overrides the supplied permissions with "read only"
when a file is shared via link. It allows to update the permissions
later, however.
This keeps the default to "read only" but honors the permissions
supplied by API call if any.
Signed-off-by: Jan-Philipp Litza <jpl@plutex.de>
2022-12-06 16:00:20 +07:00
0de71a73e5
Merge pull request #34502 from nextcloud/fix/correct-attribute-resharing
...
Propagate attributes when resharing
2022-10-20 17:03:02 +07:00
c6b8a3bec3
Fix permission not being int
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 12:37:46 +07:00
53e408f76a
Fix exception getCode type
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 12:36:50 +07:00
3a11128e6c
Fix type when getting appconfig with int
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 12:36:05 +07:00
9eb67ad57d
More flexible date validation
...
Fix #34542
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-11 23:02:10 +07:00
8e3f21d9ed
Small progress with fixing unit tests
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-11 14:00:15 +07:00
cf39885b53
Propagate attributes when resharing
...
When updating a share, load the node from the initiator instead of the
owner similar to how this is done when creating the share.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-10 17:06:29 +07:00
610bbaed68
includeTags -> include_tags
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-09-28 13:17:56 +07:00
5b3fb7a8ff
Update apps/files_sharing/lib/Controller/ShareAPIController.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
2022-09-21 08:28:03 +07:00
ebd28ef9e0
Show include tags on single share
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-09-19 11:36:52 +07:00
4a4a3874da
Add includeTags to /share/id
2022-09-19 11:11:09 +07:00
02d55eb90f
Merge pull request #33941 from nextcloud/fix/public-sharing
...
Only normalize data in public shares and not crud
2022-09-15 16:43:01 +07:00
7ded5a769b
Only normalize data in public shares and not crud
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-08 14:51:28 +07:00
9d26671f05
Fix typos in apps/ subdirectory
...
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`
Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-05 12:59:54 +07:00
7b723813ce
Multiple fixes
...
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
wrapper)
- Fix resharing
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-31 19:37:59 +07:00
ab1a20522b
Enforcing permission during resharing
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-28 16:54:13 +07:00
bbb5043c07
Inherit hide download from share attributes
...
When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:54:13 +07:00
54a0d8fe64
Don't reset share attributes when not specified
...
When not specified in the OCS call, don't reset the share attributes.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:23 +07:00
03b1791cca
Fix share attribute related tests + code style
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
9493f86de3
Fix share controller to accept share attributes alone
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
a95c19e14b
Add share attributes + prevent download permission
...
Makes it possible to store download permission
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
148498bba5
Merge pull request #32741 from nextcloud/Valdnet-patch-2
...
l10n: Delete apostrophe
2022-06-10 15:54:14 +07:00
50badb3fb6
Various improvements related to the recent implementation of temporary passwords
...
for mail shares:
1- Changes style of "forgot password?" and "Back" button
2- Adds information about share password's expiration time in the emails sent.
3- Shows password expiration time in the Share menu
4- Fixes an issue when the message "Password expires..." would be shown for non email share types (which don't have temporary passswords)
5- At share's creation, password should only be sent when it's a permanent one
See also https://github.com/nextcloud/server/issues/31952
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-08 11:29:19 +07:00
dfe7243338
l10n: Delete apostrophe
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-06-07 16:41:38 +07:00
f5c8fa4f11
Properly reset pw expiration
...
When requesting a new password for share by mail link, now we correctly
reset the expiration date.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-13 15:46:30 +07:00
c6a5c07041
Adds a "Request password" button to the public share authentication page for shares
...
of type TYPE_EMAIL, when the "video verification" checkbox isn't checked. Users accessing
non-anonymous public shares (TYPE_EMAIL shares) can now request a temporary password themselves.
- Creates a migration step for the files_sharing app to add the 'password_expiration_time'
attribute to the oc_shares table.
- Makes share temporary passwords' expiration time configurable via a system value.
- Adds a system config value to allow permanent share passwords
-Fixes a typo in a comment in apps/files_sharing/src/components/SharingEntryLink.vue
See https://github.com/nextcloud/server/issues/31005
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
2022-04-11 21:58:24 +07:00
1ceb6cdb38
Merge pull request #31684 from nextcloud/user-share-permissions-merge
...
take permissions from multiple paths into account for share permissions
2022-04-05 17:37:46 +07:00
278b13155a
take permissions from multiple paths into account for share permissions
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-31 16:47:35 +07:00
47f1ba6ea6
Merge pull request #31240 from nextcloud/Valdnet-patch-3
...
l10n: Add a dot
2022-03-31 14:57:25 +07:00
1e487c2a09
l10n: Spelling unification in Transifex.
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-03-18 10:14:34 +07:00
522d9c1d1f
l10n: Delete dot
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-02-17 15:03:53 +07:00
c72718c61b
l10n: Add a dot
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-02-17 14:07:51 +07:00
da435b1e67
Support CRUD share permissions
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-02-15 11:54:17 +07:00
d49ad7ea47
Limit more contact searches
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-08 18:58:54 +07:00
5116bf146f
Allow to pass note when creating a share and send it with directly in the share mail when set
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-12-03 10:17:02 +07:00
27865d03c0
use specific email getter where necessary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +07:00
0c27faf711
Update "Sending password by Nextcloud Talk failed" sentence
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-07 13:39:57 +07:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
9749968308
l10n: Unify spelling
...
Spelling unification in Nextcloud applications.
2021-05-20 09:22:08 +07:00
6f31d20f3d
Merge pull request #26580 from castillo92/patch-2
...
Fix casing of exception string
2021-05-18 09:29:45 +07:00
505863c55e
l10n: Change to a capital letter
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-27 12:38:28 +07:00
12948aa217
Update ShareAPIController.php
...
Change to capital letters in an abbreviation.
Signed-off-by: castillo92 javiercizquierdo@gmail.com
2021-04-16 08:56:20 +07:00
8680bafc5c
Implement expiration date for federated shares
...
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:00 +07:00
f99876997a
Remove duplicated query for email shares
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 06:50:47 +07:00
100d5d9a47
Add labels to mail shares
...
Now the email is shown on a second line if a label is set.
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:34:09 +07:00
6997344931
Log exceptions when creating share
...
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.
In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 12:00:41 +07:00
988b9f49c5
Fix invalid check after constructing DateTime
...
We construct an object. Either that works on not.But the result can't be
false.
Found by psalm
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 16:32:34 +07:00
24d436cb60
Remove unneeded casts that were found by Psalm
...
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521 )
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-11 13:14:41 +07:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +07:00
102402bfcb
Show unique displayname context in the user share list entries
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:14:59 +07:00
c4ea37b8a1
Address minor comments
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 15:51:41 +07:00
f3150f29a7
Introduce deck share type to ShareAPIController
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 13:20:24 +07:00
28252594a2
circleId too short in some request
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2020-11-13 08:59:22 +07:00
89f7e2ab64
Indicate preview availability in share api responses
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2020-10-13 14:12:42 +07:00
7e6f04490e
Merge pull request #22393 from nextcloud/fix/license-headers-20
...
Update the license headers for Nextcloud 20
2020-08-24 22:03:00 +07:00
6d576a9100
Fix missing FN from federated contact
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-24 15:15:32 +07:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +07:00
565ccb08cd
Merge pull request #22109 from nextcloud/feature/20931/followup-1
2020-08-17 22:13:45 +07:00
5b26487f14
Expose status via Collaborators API
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-14 17:04:52 +07:00
6f8147b18f
Fix some MissingDocblockType or InvalidDocblock warnings.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-14 15:10:48 +07:00
a2cedcefee
Add user input for link share labels
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-07-14 10:02:17 +07:00
37f231333f
Fix reference to wrong class name
...
\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 01:41:06 +07:00
ef34f72167
Have share permissions on link shares if it is enabled
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-15 08:18:03 +07:00
a26ca1e638
Do not filter id matching userId on non-user-share shares
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 21:36:46 +07:00
ff20da637e
Fix federated link sharing permissions
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-04 11:48:11 +07:00
d466a7b808
Allow to navigate to others with access from the sidebar
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-29 17:53:35 +07:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +07:00
5646f7c761
Link shares have reshare permission if outgoing federated shares are enabled
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-21 14:35:29 +07:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +07:00
skjnldsv
fenn-cs
Louis Chemineau
Andy Scherzinger
Joas Schilling
Côme Chilliet
Robin Appelman
Benjamin Gaussorgues
Aragon Gouveia
Vincent Petry
jld3103
Maxence Lange
Faraz Samapoor
rakekniven
Michiel de Jong
Jan-Philipp Litza
Carl Schwan
tobiasKaminsky
luz paz
Joas Schilling
Cyrille Bollu
Valdnet
Simon L
Louis
Julius Härtl
Arthur Schiwon
Morris Jobke
castillo92
Daniel Calviño Sánchez
Roeland Jago Douma
Christoph Wurst
Richard Steinmetz
Roeland Jago Douma
John Molakvoæ
Georg Ehrke
Daniel Kesselberg
Gary Kim