Commit Graph

1794 Commits (b9ab00a59e2d906fdb43eaaea37eb7a4a9cc8a13)

Author SHA1 Message Date
Maxence Lange 33bff30e1d feat(lexicon): moving out from unstable
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-07-24 15:56:33 +07:00
Ferdinand Thiessen 74ff1c64f0
Merge pull request #53979 from nextcloud/fix/settings-share-folder
fix(files_sharing): ensure share folder exists in the settings
2025-07-17 23:16:31 +07:00
Ferdinand Thiessen a18e61a1e5
feat(files_sharing): add config option for extending link-share permissions
This allows the admin to control the behavior whether link shares with
READ permissions should be extended to also gain SHARE permissions,
allowing users (public share receivers) to add the share to their cloud.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-17 16:59:36 +07:00
Ferdinand Thiessen f3857f705d
fix(files_sharing): ensure share folder exists in the settings
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-16 18:23:12 +07:00
Côme Chilliet 90a2c77abf
fix: Use Server::get in files_sharing DeletedShareAPIController
In this case we do not want the application DI container because we are
 requesting classes from other applications, so it’s better to ask the
 server container. We use \OCP\Server::get for this.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:15 +07:00
Côme Chilliet ab310ce938
fix: Fix issues and tests in DIContainer and friends
Some tests related to MiddlewareDispatcher are still failing.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:14 +07:00
Robin Appelman aa15f9d16d
chore: run rector
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-07-01 22:45:52 +07:00
Ferdinand Thiessen 5981b7eb51
chore: apply new CSFixer rules
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +07:00
John Molakvoæ bd00b75b29
Merge pull request #53671 from nextcloud/fix/read-only-share-download 2025-07-01 15:11:06 +07:00
provokateurin 8e580f8548
fix(files_sharing): Hide own reshares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-01 08:23:53 +07:00
skjnldsv 9806a9830c feat(files_sharing): allow viewing files with download disabled
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-26 11:47:53 +07:00
nfebe 1f8a2307bd fix: Set public link upload email notification to opt-in
This now sets `isDefaultEnabled` to false. This makes email notifications for file uploads
to public links disabled by default (opt-in) for users.

This addresses concerns about new notifications being enabled by
default for existing users, leading to unexpected emails.

Related: https://github.com/nextcloud/server/pull/46945

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-06-17 13:57:13 +07:00
skjnldsv bf3ce79abd feat(files_sharing): show Account menu on public pages
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-11 16:43:53 +07:00
Ferdinand Thiessen 495c364268
chore: use consistent casing for header names (required by openAPI)
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-06-09 19:24:26 +07:00
Ferdinand Thiessen 60ccc85e76
fix(files_sharing): show note, label and list of uploaded files on file drop
This was missing from the Vue migration of the public share view:
- Show the note as the description of the file drop
- Show the label as the heading of the file drop if available
- Show list of uploaded files for verification

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-26 15:11:36 +07:00
Louis a48bc55e2a
Merge pull request #52810 from nextcloud/artonge/feat/do_not_require_samesite_strict_cookie_on_public.php 2025-05-22 10:30:16 +07:00
Louis Chemineau ec1db0c32a
fix: Replace the deprecated direct download link with the public DAV endpoint
Follow-up of #48098

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-05-21 16:01:54 +07:00
Joas Schilling 9637fe6474
Revert "fix(files_sharing): Filter own shares that are reshares" 2025-05-19 17:16:39 +07:00
provokateurin 7c6602cd8d
fix(files_sharing): Filter own shares that are reshares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-19 08:18:16 +07:00
Ferdinand Thiessen 4a9dc6c64d
refactor: move tag handling from files handler to files_sharing
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 13:09:03 +07:00
Côme Chilliet 42f45030ff
Merge pull request #52817 from nextcloud/chore/deps/rector-2.0
chore(deps): Update rector to ^2.0
2025-05-14 19:19:27 +07:00
Andy Scherzinger 14f79829f3
Merge pull request #52775 from nextcloud/nested-jail-root
fix unjailedroot of nested jails if there are other wrappers in between
2025-05-14 17:36:55 +07:00
provokateurin 78a175fc74
refactor: Apply rector refactorings
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-14 15:29:02 +07:00
Robin Appelman 1e72620169 fix: fix unjailedroot of nested jails if there are other wrappers in between
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-13 18:29:00 +07:00
John Molakvoæ (skjnldsv) cd6a53ea4d fix(files_sharing): add mime fallback to public preview too
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2025-05-13 18:28:54 +07:00
Robin Appelman 1228cfd3a2
Merge pull request #52133 from nextcloud/no-shared-direct-download
fix: disable direct download for shares
2025-05-08 15:14:11 +07:00
Maxence Lange cc96782177 fix(share): assume download enabled on federated share
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-05-06 14:48:28 +07:00
nfebe f471bd292f fix(files_sharing): Move `ConfigLexicon` to Config dir, update sharing input
- Fix autoloading for new `ConfigLexicon`
- Ensure that sharing input in sharing tab respect `show-federated-shares-as-internal`:
This is important, because when federated shares are shown as internal the users should add them from the internal shares section

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-05-06 14:28:01 +07:00
Maxence Lange 4c241d4f4b refactor: use config lexicon
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-05-06 14:28:01 +07:00
nfebe 1c50329fdb feat(files_sharing): Add toggle for federated share display area
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-05-06 14:28:01 +07:00
Kate 206aac5b5b
Merge pull request #52128 from nextcloud/shared-target-verify-cache-fix 2025-05-06 15:25:09 +07:00
skjnldsv bcc8de0c9d fix(files_sharing): bring back owner and ownerDisplayName initial state
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-29 21:25:47 +07:00
Ferdinand Thiessen 47d1afbb7f
revert: do not unify `hide-download` and `prevent-download` permissions
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-16 20:38:20 +07:00
Ferdinand Thiessen a799d8dccf
fix(files_sharing): do not show download button if `hide-download` is enabled
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-16 20:38:20 +07:00
John Molakvoæ 50dcbdeec6
fix(files_sharing): adjust rate limit share creation to 20 over 10 minutes
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-04-15 10:32:47 +07:00
skjnldsv 338ab64365
fix(files_sharing): rate limit share creation 10 times per 10 minutes
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-15 08:45:25 +07:00
Robin Appelman fb3e60862f
fix: disable direct download for shares
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-04-11 17:42:21 +07:00
Robin Appelman 1185b5ee35
fix: don't return other mounts from share mount provider
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-04-11 14:20:21 +07:00
skjnldsv 70218dc0a4 fix(files_sharing): fix share creation error handling
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-09 14:52:42 +07:00
Robin Appelman bcbf0e76a7
fix: more optimized caching for share target verification
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-04-08 16:42:01 +07:00
Robin Appelman b9723eaa22
feat: remove share status from share:list as it doesn't seem to contain usefull info at the moment
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-03-28 16:47:10 +07:00
Robin Appelman c573867fff
feat: add command to list shares
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-03-28 16:47:09 +07:00
Robin Appelman 2e9222a29a
feat: add getParentId to ICacheEntry
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-03-28 16:47:07 +07:00
Côme Chilliet a32875d402 fix(files_sharing): Use session id as part of cache key to avoid concurrency issues
If several people are watching and seeking the same video file we do not
 want the cache key to be the same or it would flood activity again.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +07:00
Côme Chilliet ec5ac0957a fix(files_sharing): Set higher priority for listeners that may abort the request
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +07:00
Côme Chilliet a3c531c31e fix: Avoid triggering several activities for Range request on the same file
Avoids flooding activities when someone browse a video in the web player.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +07:00
Côme Chilliet a39bee57d9 fix: Fix download activity for folders
Remove duplicate activity publishing from share controller download,
 listen to BeforeZipCreatedEvent to publish activity for folders, and
 cache folders activity to avoid sending activity for each file in the
 folder.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +07:00
Côme Chilliet 12ce8c0ef0 fix(sharing): Publish activity for download by public link
Even if dav endpoint is now used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +07:00
Marcel Klehr b464469bc1 perf(sharing): Use oc_share.{item_type, share_type} IN instead of OR equals
to improve performance by using the db index

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-03-25 09:42:06 +07:00
Luka Trovic d7f885b1cb fix(files_sharing): skip expiration notify for invalid share record
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2025-03-17 12:59:06 +07:00