Commit Graph

5892 Commits (b6326db3dcd5d66e7af02c33bcb35eba4c1306f4)

Author SHA1 Message Date
Louis Chemineau bea982dfd5 fix(blurhash): Use preview API to generate the previews
This allows to benefit from all the checks done by the preview API.
This also use the newly introduced `cacheResult` argument to limit disk usage.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-05-06 12:19:35 +07:00
Joas Schilling cf4e784818 fix(navigation): Fix default app entry registered as closure
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-28 14:54:35 +07:00
nfebe 73c447027e refactor: Thumbnail Generator logging and tests
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-04-24 08:49:16 +07:00
Maxence Lange e82cdba53f fix(federation): allows equal signs in federation id
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-04-23 19:23:52 +07:00
Ferdinand Thiessen 1be7c65047
Merge pull request #52233 from nextcloud/backport/52223/stable31
[stable31] feat(security): add configurable IPv6 subnet for BFP and throttling
2025-04-23 13:54:15 +07:00
nfebe 84469a42af feat: add logging to preview generation
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-04-22 23:43:58 +07:00
Joas Schilling 9821d3d20a
Merge pull request #52256 from nextcloud/backport/52224/stable31
[stable31] fix(usermanager): Don't throw when checking if a too long user id is an existing user
2025-04-21 14:20:18 +07:00
Joas Schilling c34a5d2f6e fix(usermanager): Don't throw when checking if a too long user id is an existing user
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-17 14:55:12 +07:00
Ferdinand Thiessen dada9b5c1c fix(mail): use matching text color for primary elements
when we use the default primary as background color we have to use the
default primary text color as well.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-17 10:43:58 +07:00
Benjamin Gaussorgues a8bcff1388 feat(ip): add configurable IPv6 subnet for BFP and throttling
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-04-17 07:03:46 +07:00
Louis Chemineau 27ed921ad5 fix: Transfer ownership with S3 as primary
When using S3 as primary storage, transferring ownership with the `--move` option fail with the following error:

`SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '8-45b963397aa40d4a0063e0d85e4fe7a1' for key 'fs_storage_path_hash'`

The `--move` option moves the entire home folder from one account to another.
The error means that the move failed because the destination folder already exist in `oc_filecache`.

- With S3 as primary storage, folders only exists as entries in `oc_filecache`.
- With S3 as primary storage, `moveFromStorage(...)` only moves the cache entry, as nothing needs to be moved on disk. This cache move does not delete potentially pre-existing destination folder.
- With Local storage, `moveFromStorage(...)` calls `rename(...)` which delete pre-existing folder.

- `transfer(...)`: 687a4d9ac7/apps/files/lib/Service/OwnershipTransferService.php (L112)
- `oneTimeUserSetup(...)`: 687a4d9ac7/lib/private/Files/SetupManager.php (L261-L262)
- `mkdir(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L91-L135)
- `moveFromStorage(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L635-L636)

Delete pre-existing folder in `moveFromStorage(...)`

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-04-16 10:19:17 +07:00
Joas Schilling 0c3c61c4be
Merge pull request #52068 from nextcloud/backport/52066/stable31
[stable31] fix(federation): Don't load the addressbook when resolving a cloud ID
2025-04-11 13:44:22 +07:00
John Molakvoæ e75f3df9a1
Merge pull request #52078 from nextcloud/backport/52075/stable31 2025-04-11 13:29:53 +07:00
Joas Schilling a9d126a219
fix(federation): Fix returning "no display name" after cache result
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-11 12:32:23 +07:00
Joas Schilling 878c4d5597
fix(federation): Don't load the addressbook when resolving a cloud ID
Instead we delay the lookup of the display name until it is actually used

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-11 12:32:22 +07:00
Oleksander Piskun 9543f9822a fix(taskprocessing): use the event for AppAPI to get list of AI providers
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
2025-04-11 07:59:40 +07:00
skjnldsv f81ef274dd fix(files_sharing): fix share creation error handling
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-09 15:22:32 +07:00
Joas Schilling 8c460c9f58
Revert "refactor(RichObjectStrings): Only log error if key or value is not string in validator"
This reverts commit 23a61a2b42.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-09 08:29:43 +07:00
provokateurin 23a61a2b42 refactor(RichObjectStrings): Only log error if key or value is not string in validator
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-04-08 11:17:10 +07:00
Benjamin Gaussorgues fffde28b51 feat(ip): use larger IPv6 range by default
Some providers assign `/48` IPv6 blocks instead of `/64` so it sounds safer
to use this mask by default.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-04-08 09:16:13 +07:00
Ferdinand Thiessen 00580b369e
fix: ensure enabled themes are set on the template
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-04 09:23:45 +07:00
Christoph Wurst 81a8e83bf8 fix(session): Only mark sessions of permanent tokens as app passwords
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2025-04-03 08:10:56 +07:00
Christoph Wurst dfb0b38acc perf(cron): Delay (re)checking timed jobs
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2025-03-31 15:33:59 +07:00
Julius Knorr deafe47b98 test: Adapt tests to properly use valid email addresses
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-28 22:37:07 +07:00
Ferdinand Thiessen ef1a73a8dc fix(IFilenameValidator): correctly handle case insensitivity
- forbidden names and forbidden base names are case **insensitive**
  so we need to check all lowercase here.
- add test that config value is also read case insensitive.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-28 20:54:23 +07:00
Julius Knorr 1642cd1ff1 fix: Do not build encrypted password if there is none
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-28 15:18:27 +07:00
SebastianKrupinski d977d50151 fix: add event status and participant status
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-03-28 04:34:44 +07:00
Git'Fellow e5d62aeec7 fix(database): Cast users count to integer
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-03-25 11:57:42 +07:00
Hamza Mahjoubi 7e6801a9af fix(cardav): only show useres from enabled addressBooks in contacts menu
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2025-03-19 23:46:57 +07:00
provokateurin 4f27d82471
fix(RichObjectStrings): Make exception messages for invalid parameters more useful for debugging
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-17 06:46:12 +07:00
Ferdinand Thiessen 324582729a
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:54:06 +07:00
Ferdinand Thiessen aa7300b53d
fix(lookup-server): do not query data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:39:33 +07:00
provokateurin b42d26b42f refactor(TempManager): Simplify and unify implementations and remove legacy behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-03 15:25:00 +07:00
Robin Appelman ea678c0280 feat: support migrating an instance to sharding
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-25 21:43:54 +07:00
Andy Scherzinger 55b8a6ba13
Merge pull request #50941 from nextcloud/backport/50053/stable31
[stable31] fix: Change UserAgent to *cloud
2025-02-25 18:37:15 +07:00
Ferdinand Thiessen 06ddb7aff6 refactor: convert sanitize account properties repair step to background job
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:23:20 +07:00
Ferdinand Thiessen 29e5e8a31b fix: Optimize repair step performance
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:23:20 +07:00
Ferdinand Thiessen e9c4c59998 fix: validate account properties as a repair step
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:23:20 +07:00
Johannes Endres 76d4138736 fix: Change UserAgent to *cloud
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
2025-02-21 09:30:10 +07:00
skjnldsv 63d9a11575 fix: make sure we process mime extensions as string
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-09 21:09:12 +07:00
Ferdinand Thiessen e550ad7bbe
fix(FediverseAction): Ensure valid fediverse links are generated
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 15:46:15 +07:00
Ferdinand Thiessen ac1a448765
fix(AccountManager): Sanitize social media handles
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 15:46:15 +07:00
Louis Chemineau a56cff70e1 fix: Exclude non accepted shares when computing access list
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-30 09:18:41 +07:00
Andy Scherzinger c99c135520
Merge pull request #50508 from nextcloud/backport/50436/stable31
[stable31] fix: Harden files scanner for invalid null access
2025-01-28 23:52:39 +07:00
Ferdinand Thiessen 26c93519f2 fix: Harden files scanner for invalid null access
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 19:49:03 +07:00
Ferdinand Thiessen 0f298e1db1 fix(sharing): Move permission validation to share manager
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 17:26:28 +07:00
Andy Scherzinger bae32be74d
Merge pull request #50468 from nextcloud/backport/50234/stable31
[stable31] fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
2025-01-27 18:14:06 +07:00
Dario Mehlich 72a43a17f5 fix(preview): Filter for folders in cleanup old preview job
Fixes #35936.
When running `OC\Preview\BackgroundCleanupJob`, the main iteration loop
in `run()` expects a folder, however, `getOldPreviewLocations()`
currently does not filter by mimetype and therefore can yield a
non-folder entry which causes an Exception when constructing the Folder
impl.
Filtering for `httpd/unix-directory`, as `getNewPreviewLocations()`
already does, fixes this issue.

Signed-off-by: Dario Mehlich <d.mehlich@gmail.com>
2025-01-27 15:11:26 +07:00
Joas Schilling 77fddb8f23 fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-27 13:21:36 +07:00
Marcel Klehr c88c2216ae fix(taskprocessing): Fix tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-25 13:08:19 +07:00