Commit Graph

1604 Commits (b5291bfd4480497e706fee7c0ff48bbc8d2db3ee)

Author SHA1 Message Date
Côme Chilliet da9b6e376d fix(tests): Sort activities by id to get the last one
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +07:00
Côme Chilliet 140aba1f16 feat: Add context and test steps for activity in sharing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +07:00
Côme Chilliet a57f694e8d feat: add integration test for sharing activity
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +07:00
provokateurin 95df189595
feat(openapi): Generate merged spec for all apps
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-24 16:38:17 +07:00
provokateurin 3732be59fd
fix(build): Also fail OpenAPI generation for untracked specs
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-24 16:18:02 +07:00
Côme Chilliet 5ed5bef1ba chore: Update OCP baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +07:00
Ferdinand Thiessen 92795b2091
chore(test): use consistent tabs for indention in behat tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 20:59:08 +07:00
John Molakvoæ 4df9ab4033
Merge pull request #51403 from nextcloud/chore/drop-jsdoc
chore(dev-deps): Drop dependency on jsdoc
2025-03-12 08:48:25 +07:00
Ferdinand Thiessen 251a19d6ea
chore(dev-deps): Drop dependency on jsdoc
It is not used anymore and it yields not usable documentation anymore.
This is a leftover from like 11 years ago.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 18:36:41 +07:00
Ferdinand Thiessen 00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +07:00
Côme Chilliet 253628ad5a fix: Fix psalm issues and add missing methods to ITemplate interface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +07:00
Côme Chilliet 71dc34c03c fix: Deprecate OC_Template, add proper template manager instead
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +07:00
Louis Chemineau c2f2f21673
feat: Support deleting metadata from WebDAV
The `$value` will be `null` if the update is wrapped inside a `<d:remove>...</d:remove>` block.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-04 12:34:11 +07:00
Stephan Orbaugh 3bc3d03048
Merge pull request #51000 from nextcloud/fix/federatedfilesharing/group-cleanup
fix(FederatedShareProvider): Delete external shares when groups are deleted or users removed from a group
2025-03-03 16:29:10 +07:00
Kate a9a839c40f
Merge pull request #51194 from nextcloud/refactor/tempmanager
refactor(TempManager): Simplify and unify implementations and remove legacy behavior
2025-03-03 16:17:34 +07:00
provokateurin eaa1b54d98
build(integration): Disable password_policy app
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-03 12:51:39 +07:00
provokateurin dd47daa4a8
fix(Share20): Convert broken hooks to IEventListener
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-03 12:49:01 +07:00
provokateurin 8acfc0f0f2
refactor(TempManager): Simplify and unify implementations and remove legacy behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-03 11:11:12 +07:00
Ferdinand Thiessen c82337f3b9
fix: incorrect types detected by updated stubs
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 19:07:39 +07:00
Ferdinand Thiessen 0be4239c41
chore: Update php intl stub for PHP 8.0+
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 19:06:44 +07:00
Côme Chilliet 485f3f495e
fix: Fix test by scanning group before using it
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-27 12:39:15 +07:00
nextcloud-command 11d36e7607 fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
2025-02-26 02:31:09 +07:00
Joas Schilling 0fc355aa1e
ci(autochecks): Run some autochecks also on non-PHP files
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-21 12:12:29 +07:00
dependabot[bot] eb3c639c6b bump behat/behat from 3.18.1 to 3.19.0 in /build/integration
---
updated-dependencies:
- dependency-name: behat/behat
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-18 14:31:46 +07:00
Côme Chilliet e757b649b7
fix: Fix psalm taint false-positives by small refactorings
Mostly make it clear that we trust admin input or that we correctly
 escape strings.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 18:08:23 +07:00
Côme Chilliet 640dbd0b5e
fix: Fix false-positive psalm taint errors when outputting plain text
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:23 +07:00
Côme Chilliet 7c907223d2
fix: Fix psalm taint false-positive by escaping trusted input
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:22 +07:00
Côme Chilliet fa108d5b54
fix: Correctly tag json encoding in BaseResponse to fix false-positive
…in psalm taint analysis

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:22 +07:00
Côme Chilliet aac79bad9b
fix: Move config.php taint trust upstream directly in OC\Config class
This solves some false-positive psalm taint errors

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:20 +07:00
Côme Chilliet 25f38883f1
fix: Work around false-positive psalm taint error calling print_r in admin_audit
Same issue as var_export, print_r is listed as sink but it’s not when
 using return:true. Anyway, using the logger context feature is better.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:08 +07:00
Côme Chilliet fec865cc29
chore: Correctly flag json encoding methods as escaping html and quotes
Especially with JSON_HEX_TAG it’s perfectly fine to echo JSON, and we
 only use it in JSON output anyway.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:07 +07:00
Côme Chilliet 964bc960f8
chore: Update psalm-baseline-security.xml
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 16:27:13 +07:00
Côme Chilliet 007335dadf
chore(rector): Enable Nextcloud 25 set for the apps folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:45:39 +07:00
Côme Chilliet ee48cafd20
Merge pull request #50689 from nextcloud/fix/migrate-dav-to-events
fix(dav): Migrate from hooks to user events
2025-02-13 10:24:05 +07:00
Joas Schilling 747bf1a241
fix(transifex): Adjust check for translation of apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-11 07:19:46 +07:00
Côme Chilliet a4d7623ed7 chore: Update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-10 14:52:18 +07:00
John Molakvoæ 93c72f5675
Merge pull request #50660 from nextcloud/fix/mime-int
fix: make sure we process mime extensions as string
2025-02-06 16:13:27 +07:00
Ferdinand Thiessen 2a0f81da53
fix(provisioning_api): Correct limit for `editUser`
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 11:58:24 +07:00
Ferdinand Thiessen 729cdf6818
fix(FediverseAction): Ensure valid fediverse links are generated
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 11:58:24 +07:00
skjnldsv 6baafd82b6 fix: make sure we process mime extensions as string
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-05 12:35:41 +07:00
Ferdinand Thiessen 73dc0f0f19
fix(sharing): Ensure download restrictions are not dropped
When a user receives a share with share-permissions but also with
download restrictions (hide download or the modern download permission attribute),
then re-shares of that share must always also include those restrictions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-04 15:39:14 +07:00
dependabot[bot] 8ad7350a6b
Merge pull request #50137 from nextcloud/dependabot/composer/build/integration/behat/behat-3.18.1 2025-01-30 00:11:21 +07:00
Ferdinand Thiessen b48ee2e924
fix: Harden files scanner for invalid null access
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:08:46 +07:00
Ferdinand Thiessen 0baab8fd98
test: Reset sharing app config after test
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 16:40:50 +07:00
Ferdinand Thiessen 253f4345f1
fix(files_sharing): Respect permissions passed when creating link shares
Given:
User creates a link or email share with permissions=4 (create only = file drop).

Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.

Solution:
Respect what the user is requesting, create a file drop share.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 16:40:50 +07:00
Kate 2f862d1fcb
Merge pull request #50221 from nextcloud/add-integration-tests-for-moving-a-file-from-and-to-a-shared-folder 2025-01-27 17:03:04 +07:00
Daniel Calviño Sánchez b59c71ccf8 test: Add integration tests for moving a file from and to a shared folder
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-01-27 14:13:07 +07:00
Joas Schilling c1655bcde7
fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-27 12:46:15 +07:00
Ferdinand Thiessen eea91fa1ba
fix(TemplateLayout): `core` is not an app but the server itself
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-24 15:10:23 +07:00
Richard Steinmetz d3126cd1bb
fix(dav): default calendar and address book not created on first login
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-23 22:02:52 +07:00