Commit Graph

22093 Commits (b2f01b72fe402ca3ee8d0059ff266d1893d53d21)

Author SHA1 Message Date
Robin Appelman e81fdfefab
Merge pull request #38568 from rawtaz/fix-redis-empty-password
redis: Do not try to authenticate with non-string password/user
2023-06-01 22:11:55 +07:00
Christoph Wurst f04ff2c6d7
chore(ocp)!: Drop \OCP\Util::linkToPublic
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 20:32:59 +07:00
Christoph Wurst 0f534936b3
fix(ocp): Mark IMessage::attachInline as @since 27
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 18:15:19 +07:00
Christoph Wurst 7f8f792558
feat(ocp): Allow sending emails with subject and body
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 18:10:05 +07:00
Leo R. Lundgren c52aaa3647 redis: Do not try to authenticate with non-string password/user
Signed-off-by: Leo R. Lundgren <leo@finalresort.org>
2023-06-01 13:08:57 +07:00
Christoph Wurst 999aec366a
chore: Drop \OC_App::getSettingsNavigation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:27 +07:00
Christoph Wurst 167763d312
chore: Drop \OC_App::getNavigation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:27 +07:00
Christoph Wurst e76d525a43
chore: Drop \OC_App::getAppInfo
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:27 +07:00
Christoph Wurst cf6e2fa1b7
chore: Drop \OC_App::getAppVersion
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:26 +07:00
Joas Schilling 90a628d23d
Merge pull request #38514 from nextcloud/bump/giggsey/libphonenumber-for-php_to_lite-version
chore(libphonenumber): Bump giggsey/libphonenumber-for-php to giggsey…
2023-05-31 17:57:46 +07:00
Joas Schilling 56ece0c6f3
Merge pull request #38552 from nextcloud/chore/drop-oc-defaults-getlogoclaim
chore!: Drop \OC_Defaults::getLogoClaim
2023-05-31 17:33:56 +07:00
Joas Schilling f0238fa0a2
Merge pull request #38551 from nextcloud/chore/drop-oc-app-isenabled
chore!: Drop \OC_App::isEnabled
2023-05-31 16:50:50 +07:00
Robin Appelman 496a8d2b80
Merge pull request #38468 from nextcloud/log-cert-list-errors
log failures to read certificates during listing
2023-05-31 16:16:15 +07:00
Joas Schilling 4809e8d9a9
fix(CI): Satisfy psalm by removing a now obsolete type check
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-31 15:42:15 +07:00
Christoph Wurst 9a89e9086f
chore!: Drop \OC_Defaults::getLogoClaim
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-31 15:17:20 +07:00
Christoph Wurst dd2d50471e
chore!: Drop \OC_App::isEnabled
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-31 15:06:25 +07:00
Robin Appelman 223612b15a
log failures to read certificates during listing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-31 14:40:45 +07:00
Christoph Wurst 3d1acca1f3
chore(app): Do not clear unused cache key
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-30 17:48:20 +07:00
Joas Schilling 5b2d5767e1
fix(docs): Fix language and copy-paste class name in docs of CSP
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-30 13:39:33 +07:00
Simon L 1e1e2fec64
Merge pull request #38496 from nextcloud/preview-mp3-catch-errors
fix: catch errors in id3parser library
2023-05-30 10:51:33 +07:00
Nextcloud bot 45d7cee7f8
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-30 00:17:33 +07:00
Daniel Kesselberg 0670ae607b
fix: catch errors in id3parser library
We use a forked version of getID3 to read embedded images from mp3 files to use them as previews.

If the library is unable to extract a image or fails on something different we should handle it properly.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-05-28 17:01:23 +07:00
Nextcloud bot fa23698c23
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-28 00:17:29 +07:00
Nextcloud bot eaff926732
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-27 00:17:51 +07:00
Joas Schilling ef93bb926c
fix(dav): Fix avatar size in system address book
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-26 10:03:58 +07:00
Julius Härtl 9453c2d40d fix: execute throws docrine exceptions not our wrapped ones
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-05-26 06:56:55 +07:00
Nextcloud bot 7d9d99d5e6
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-26 00:18:10 +07:00
Simon L f29aa2997e
Merge pull request #38429 from tanganellilore/fix_delete_user_syslink
Fix deletion of User when system link are used in him user folder
2023-05-26 01:12:34 +07:00
John Molakvoæ 7d06dc3474 fix: better error message on missing user files dir
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-05-25 20:31:14 +07:00
Côme Chilliet 47bb12b226
Fix autoloaders
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-25 11:40:40 +07:00
Arthur Schiwon b2e34267cd
Merge pull request #38415 from nextcloud/object-store-init-root
don't always check if we need to setup the object store root
2023-05-24 13:06:14 +07:00
F. E Noel Nfebe 4220442fa1
Merge pull request #37458 from Fenn-CS/fix/37424/better-501-error-logging
Avoid db connections when logging db connection errors
2023-05-24 08:46:03 +07:00
Lorenzo Tanganelli 6b55e92e33
invert elseif on rmdir for local storage
Signed-off-by: Lorenzo Tanganelli <lorenzo.tanganelli@hotmail.it>
2023-05-24 08:22:50 +07:00
Nextcloud bot 294035f523
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-24 00:17:47 +07:00
Robin Appelman cc0ad25c98
don't always check if we need to setup the object store root
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-23 17:44:40 +07:00
Côme Chilliet 285c42ab14
Fix user tests, avoid setting enabled state to the same value
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-23 17:18:19 +07:00
Robin Windey 1dcc8559cf
Log to error_log in fatal case
Signed-off-by: Robin Windey <ro.windey@gmail.com>
2023-05-23 17:11:52 +07:00
Côme Chilliet 3af1ab2b2a
Add user enabled state backend feature
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-23 11:25:03 +07:00
Louis c8e85a4ecf
Merge pull request #38365 from JanisPlayer/patch-3
add imaginary_key
2023-05-22 23:39:26 +07:00
JanisPlayer c71a3065a7 Allow to specify an imaginary key
Signed-off-by: JanisPlayer <54918417+JanisPlayer@users.noreply.github.com>
2023-05-22 22:19:51 +07:00
fenn-cs d0fc159975 Avoid db connection when logging db connection errors
`\OC\Log\LogDetails::logDetails` depends on `\OC_App::getAppVersions()`
which makes a database connection causing the logger to break when the database
service is unavaiable.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-05-22 15:17:04 +07:00
Nextcloud bot 30e445773d
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-22 00:17:43 +07:00
Nextcloud bot 96f0118312
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-21 00:17:10 +07:00
Nextcloud bot 1c1c9075c1
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-20 00:17:12 +07:00
Simon L 3d2d1c171e
Merge pull request #37758 from nextcloud/redis-atomic
redis: use atomic operations everywhere
2023-05-19 23:29:24 +07:00
Nextcloud bot b24bb42ef7
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-18 00:17:49 +07:00
Faraz Samapoor fa31c707c0
Update TemplateLayout.php
https://github.com/nextcloud/server/pull/38261#discussion_r1196711637

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-05-17 20:41:05 +07:00
Faraz Samapoor 9f6f4b105f
Update Detection.php
The latter implies the former.

https://github.com/nextcloud/server/pull/38261#discussion_r1196708412

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-05-17 20:37:35 +07:00
Simon L 6608f84a46
Merge pull request #36692 from nextcloud/throw-exception-to-avoid-division-by-zero
fix(preview-generator): Throw exception before dividing by zero when generating previews
2023-05-17 00:14:42 +07:00
Simon L 3f786781ef
Merge pull request #31001 from takahiro-blab/master
Fixed 'overwritewebroot' not work with 'overwritecondaddr'.
2023-05-16 23:32:15 +07:00
Julius Härtl 6f43ab82fd
fix: Throw early when a service cannot be found in the app container
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-05-16 20:32:39 +07:00
Simon L 2bd08c8198
Merge pull request #38030 from nextcloud/enh/retry-transaction
Wrapper method to easily retry deadlock exceptions
2023-05-16 11:53:30 +07:00
Simon L d293293cda Fixed bug which 'overwritewebroot' does not work with 'overwritecondaddr'.
Signed-off-by: Takahiro Nagai <78393959+takahiro-blab@users.noreply.github.com>
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-05-16 11:39:39 +07:00
Simon L 48521d67e1
Merge pull request #38143 from nextcloud/fix/generated-avatars-cache
Fix generated avatars cache
2023-05-16 11:37:49 +07:00
Simon L ab848244fe
Merge pull request #38065 from nextcloud/fix-result-mimetype-loader
fix(mimetype): Fix returning value when finding existing mimetype in MimeType Loader
2023-05-16 11:30:13 +07:00
Joas Schilling 5e02def3f4
Merge pull request #38274 from nextcloud/bugfix/noid/reach-max-delay-in-afterController
fix(middleware): Also abort the request when reaching max delay in af…
2023-05-16 11:07:04 +07:00
Julius Härtl 050c6d53b3
enh: Provide atomicRetry method to retry transactions if possible
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-05-16 08:13:20 +07:00
Nextcloud bot 816c33c391
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-16 02:28:27 +07:00
jld3103 2a19753cf7
Clear generated avatar caches
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-05-15 18:18:21 +07:00
jld3103 e294045223
Properly clear cached avatars
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-05-15 18:18:21 +07:00
Côme Chilliet 8362eea14e
Merge pull request #38196 from nextcloud/fix/fix-32bits-freespace-and-sizes
Get rid of more int casts in file size manipulations
2023-05-15 17:05:46 +07:00
Joas Schilling 3a6bc7aba2
fix(middleware): Also abort the request when reaching max delay in afterController
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:20:19 +07:00
Faraz Samapoor e7cc7653b8 Refactors "strpos" calls in lib/private to improve code readability.
Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>
2023-05-15 15:17:19 +07:00
Côme Chilliet ae525e1935
Fix return types in phpdoc
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-15 12:24:42 +07:00
Côme Chilliet 3bf19f76e6
Merge pull request #32961 from nextcloud/more-debug-lazyuserfolder
Make it easier to debug issue #32304
2023-05-15 11:42:06 +07:00
Julius Härtl 0ebb00d01d
fix: Do not attempt to use l10n files as sources for combined js files
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-05-15 08:29:05 +07:00
Nextcloud bot 8bdb50fd50
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-15 02:28:25 +07:00
Nextcloud bot d454fe4b8c
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-14 02:27:40 +07:00
Julius Härtl e18f97fc95
Merge pull request #37709 from nextcloud/bugfix/deadlock 2023-05-13 13:13:04 +07:00
Julius Härtl 8cab1d73ac
Merge pull request #37621 from nextcloud/enh/lock-readable-path 2023-05-13 13:11:37 +07:00
Nextcloud bot 701e409c4c
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-13 02:27:57 +07:00
Robin Appelman 1f4dd62b4e
Merge pull request #36592 from nextcloud/groupmanager-search-typing
fix default values and type hints for GroupManager::search
2023-05-12 15:25:32 +07:00
Christoph Wurst 1381c4c157
feat(users): Store and load a user's manager
Co-Authored-By: hamza221 <hamzamahjoubi221@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-12 13:56:48 +07:00
John Molakvoæ 174c226c28
Merge pull request #38207 from nextcloud/fix/jsresourcelocator-l10n-handling 2023-05-12 10:47:46 +07:00
Nextcloud bot b85c2dab27
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-12 02:28:13 +07:00
Ferdinand Thiessen 31c01fa3da fix(JSResourceLocator): Handle missing translations silently
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-05-11 18:22:24 +07:00
John Molakvoæ 4a86487859
fix: getGroups limit check syntax
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2023-05-11 17:30:04 +07:00
Robin Appelman 13b06ba4e2
revert public interface back to the original types, just cast them before passing the nulls to the backends
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-11 17:30:03 +07:00
Robin Appelman 7ad3574d71
also update groupinterface and database backend
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-11 17:30:03 +07:00
Robin Appelman e4b9ecd8f2
fix default values and type hints for GroupManager::search
ints really are ints

Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-11 17:30:01 +07:00
Côme Chilliet a90581b405
Get rid of more int casts in file size manipulations
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-11 12:46:16 +07:00
John Molakvoæ 979f4033ca
Merge pull request #33381 from luzpaz/fix/lib-public-typos 2023-05-11 10:26:50 +07:00
Arthur Schiwon b6c034ac57
Merge pull request #37961 from nextcloud/poc/noid/systemtags-perf
SystemTags endpoint to return tags used by a user with meta data
2023-05-11 10:16:03 +07:00
John Molakvoæ db02684008
Merge pull request #37691 from nextcloud/object-store-background-scan 2023-05-11 08:15:41 +07:00
Varun Patil c6cee282b3 redis: move lua scripts to class and add type hints
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-05-10 17:37:02 +07:00
Robin Appelman 2ea41dab93
repair -1 folder sizes for object store background scan
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-10 19:33:26 +07:00
Arthur Schiwon df662f50bd
refactor: remove where specification from SELECT getter
- search constraints are now fully in control of
  SystemTagsInFilesDetector::detectAssignedSystemTagsIn(), avoids
  duplication of a WHERE statement

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-05-10 18:48:06 +07:00
Anna 9e53934498
Merge pull request #36118 from nextcloud/fix/caldav/invitation-outlook-compatibilty
Fix calendar emails to be outlook compatible
2023-05-10 12:10:42 +07:00
Simon L d55a7c619d Fix typos in lib/public subdirectory
Found via `codespell -q 3 -S l10n -L jus ./lib/public`

Signed-off-by: luz paz <luzpaz@github.com>

Update lib/public/Accounts/IAccount.php

Signed-off-by: luz paz <luzpaz@github.com>

Signed-off-by: Simon L <szaimen@e.mail.de>
Co-Authored-By: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-05-10 11:56:34 +07:00
Nextcloud bot 46bb952ba5
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-10 02:31:27 +07:00
Arthur Schiwon dbfd2f936a
refactor: remove SystemTag logic from Folder into QuerySearchHelper
- adds OC\SystemTag\SystemTagsInFilesDetector where the search logic is
  moved to

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-05-09 23:51:52 +07:00
Arthur Schiwon 2489a2d63a
feat: specify media type via url path: systemtags-current/$mediaType
- only the media part of the mime type can be search, but not the full
  mime type. It can be added, should it become necessary.
- thus fixes previously hardcoded selector for image/ types
- also fixes a return type hint
- adds a return type hint

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-05-09 23:51:51 +07:00
Arthur Schiwon 6bff6a5667
PoC: SystemTags endpoint to return tags used by a user with meta data
Target case is photos app: when visiting the tags category, all systemtags
of the whole cloud are retrieved. In subequent steps the next tag is
requested until the browser view is filled with tag tiles (i.e. previews
are requested just as well).

With this approach, we incorpoate the dav search and look for user related
tags that are used by them, and already returns the statistics (number of
files tagged with the respective tag) as well as a file id for the purpose
to load the preview. This defaults to the file with the highest id.

Call:
curl -s -u 'user:password' \
  'https://my.nc.srv/remote.php/dav/systemtags-current' \
  -X PROPFIND -H 'Accept: text/plain' \
  -H 'Accept-Language: en-US,en;q=0.5'  -H 'Depth: 1' \
  -H 'Content-Type: text/plain;charset=UTF-8' \
  --data @/home/doe/request-systemtag-props.xml

With request-systemtag-props.xml:
<?xml version="1.0" encoding="UTF-8"?>
<d:propfind xmlns:d="DAV:">
        <d:prop xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns">
                <oc:id/>
                <oc:display-name/>
                <oc:user-visible/>
                <oc:user-assignable/>
                <oc:can-assign/>
                <nc:files-assigned/>
                <nc:reference-fileid/>
        </d:prop>
</d:propfind>

Example output:
  …
  <d:response>
    <d:href>/master/remote.php/dav/systemtags/84</d:href>
    <d:propstat>
      <d:prop>
        <oc:id>84</oc:id>
        <oc:display-name>Computer</oc:display-name>
        <oc:user-visible>true</oc:user-visible>
        <oc:user-assignable>true</oc:user-assignable>
        <oc:can-assign>true</oc:can-assign>
        <nc:files-assigned>42</nc:files-assigned>
        <nc:reference-fileid>924022</nc:reference-fileid>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>
  <d:response>
    <d:href>/remote.php/dav/systemtags/97</d:href>
    <d:propstat>
      <d:prop>
        <oc:id>97</oc:id>
        <oc:display-name>Bear</oc:display-name>
        <oc:user-visible>true</oc:user-visible>
        <oc:user-assignable>true</oc:user-assignable>
        <oc:can-assign>true</oc:can-assign>
        <nc:files-assigned>1</nc:files-assigned>
        <nc:reference-fileid>923422</nc:reference-fileid>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>
  …

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-05-09 23:51:48 +07:00
Côme Chilliet 185fe5378b
Merge pull request #36893 from nextcloud/fix/avoid-file-events-on-null-path
Make sure to never trigger files hooks on a null path
2023-05-09 17:44:14 +07:00
Louis 20edd4b5ca
Merge pull request #38140 from nextcloud/enh/noid/adjust-wording-update-hint
adjust wording for update hint when files of a specific app are not there
2023-05-09 17:35:03 +07:00
John Molakvoæ 31302c4528
Merge pull request #38095 from nextcloud/artonge/fix/file_metadata_scan 2023-05-09 17:28:47 +07:00
Pytal 972b2097d0
Merge pull request #38104 from nextcloud/feat/um-32-bit 2023-05-09 08:20:41 +07:00
Robin Appelman 904fdf3aa3
Merge pull request #37838 from nextcloud/event-logger-http
log performance events for http requests
2023-05-09 17:15:27 +07:00
Arthur Schiwon d946256ff9
Merge pull request #38088 from nextcloud/fix/38053/change-display-name
fix(user): Can change display name
2023-05-09 11:48:10 +07:00
Louis Chemineau b67e34f78f Restrict EXIF extracting to a subset of formats
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-05-09 11:43:56 +07:00
Louis Chemineau 157be42a83 Prevent error on files scan if metadata exists
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-05-09 11:43:56 +07:00
Simon L 84b88c01c7 adjust wording
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-05-09 11:19:48 +07:00
Côme Chilliet 1cc1866ba3
Add back missing slash in LazyUserFolder path
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-05-09 10:59:31 +07:00
Simon L 6e5a307757 adjust wording for update hint when files of a specific app are not there
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-05-09 10:56:02 +07:00
Nextcloud bot 158405127b
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-09 02:19:48 +07:00
Arthur Schiwon c7bb540d08
Merge pull request #36895 from apasov/patch-1
Fix json_decode expecting a string
2023-05-08 21:20:38 +07:00
Joas Schilling 598859d969
Merge pull request #38097 from nextcloud/bugfix/38087/dont-translate-when-from-and-to-are-equal
fix(translation): Don't use translation providers when from and to ar…
2023-05-08 09:40:22 +07:00
Joas Schilling b1c6b940a6
Merge pull request #38102 from nextcloud/feature/noid/add-messageid-to-talk-richobject-definition
Add messageId to richObject definition of Talk
2023-05-08 09:26:04 +07:00
Nextcloud bot 737e79854e
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-05-06 02:27:44 +07:00
Christopher Ng 4e51f5224c feat(UserMigration)!: 32-bit support
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-05-05 17:59:57 +07:00
jld3103 04d840211f
Remove version check for ancient libxml version
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-05-05 19:07:55 +07:00
Marcel Müller 484f7a6641 Add messageId to richObject definition of Talk
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2023-05-05 17:51:53 +07:00
Joas Schilling 505e467cc4
fix(translation): Don't use translation providers when from and to are the same
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-05 14:03:14 +07:00
John Molakvoæ 46459ae93f
Merge pull request #35092 from Messj1/bugfix/type-error-cert-manager-cache-path 2023-05-04 21:53:49 +07:00
Christopher Ng 4ecae83385 fix(user): Can change display name
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-05-04 11:14:49 +07:00
Côme Chilliet 6034cc6893 Make sure to never trigger files hooks on a null path
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-04 17:55:09 +07:00
Robin Appelman f8b4e0025b
Merge pull request #37865 from nextcloud/info-file-space
add command to summarize space usage
2023-05-04 18:21:11 +07:00
Carl Schwan 85770f3b9f Make it easier to debug issue #32304
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-05-04 11:11:52 +07:00
Robin Appelman 5c31c35d40
add option to list all files instead of limiting
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-04 13:10:26 +07:00
Simon L 527de8ac9d
Merge pull request #37148 from nextcloud/enh/noid/increase-imaginary-timeouts
increase imaginary timeouts as for big files the processing could take very long
2023-05-04 12:44:52 +07:00
Thomas Citharel 375466819e
fix(mimetype): Fix returning value when finding existing mimetype in MimeType Loader
Also, only return the ID from the transaction as the mimetype string is
already used from the function argument value

Fixes https://github.com/nextcloud/server/pull/35744/files#r1184644610

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-05-04 11:15:50 +07:00
Joas Schilling b44de9ccb8
Merge pull request #38046 from nextcloud/bugfix/noid/abort-dav-requests-with-429
fix(dav): Also throw in basic auth requests
2023-05-04 09:06:57 +07:00
Daniel db73534e09
Merge pull request #38016 from nextcloud/oracle-limit-workaround
fix: add workaround for oci and limit queries
2023-05-03 23:06:59 +07:00
Joas Schilling b91957e3df
fix(dav): Abort requests with 429 instead of waiting
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-03 22:43:36 +07:00
Arthur Schiwon 7a7578cb86
Merge pull request #37937 from nextcloud/artonge/feat/remove_non_existing_jobs
Remove job from oc_jobs when the file is not findable
2023-05-03 12:51:11 +07:00
Joas Schilling 9ace8e561d
Merge pull request #38003 from nextcloud/bugfix/noid/improve-translations-api
Improve translations api with detecting languages
2023-05-03 11:07:30 +07:00
Louis Chemineau 8ad2f34045 Remove job from oc_jobs when the file is not findable
When an application is disabled, or when a background jobs is removed by the app developer, then the job won't be found. In those cases, it makes sense to remove those jobs from oc_job.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-05-03 10:39:38 +07:00
Arthur Schiwon 997efe44ff
Merge pull request #37943 from nextcloud/fix/fix-getcontent-return-type
Fix file_get_content signatures to make it clear it can return false
2023-05-03 10:34:51 +07:00
Arthur Schiwon ef87dfc478
Merge pull request #33106 from nextcloud/feature/update-expire-date
Update expire_date column of table comments
2023-05-03 10:26:28 +07:00
Julius Härtl 3bdd770129
fix: Check for wrapped retriable exceptions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-05-02 19:42:11 +07:00
Julius Härtl 11c5bc6a2a
fix: Wrap filesystem LockedExceptions for holding the readable path
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-05-02 19:40:27 +07:00
Côme Chilliet f7632f2fc4
Merge pull request #32866 from nextcloud/performance/searchInGroup-displayname-cache
Optimize retrieving display name when searching for users in a group
2023-05-02 16:42:09 +07:00
Joas Schilling 9d6ec68b59
feat(translation): Return the detected language so clients can show more details
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-02 16:38:33 +07:00
Joas Schilling dc67b48c28
fix(translation): Detect the language first and then ask all providers for translations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-02 16:38:33 +07:00
Simon L 4dfadcabb9
Merge pull request #38014 from nextcloud/norm-logic
Normalize logical operators
2023-05-02 16:27:58 +07:00
Daniel Kesselberg eecdb62e92
fix: add workaround for oci and limit queries
DBAL uses a helper column "doctrine_rownum" for top-n queries

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-05-02 14:26:28 +07:00
Côme Chilliet 10296ba7e5
Fix tests, and fix Group::searchUsers to avoid duplicates
Also went back to searchUsers indexing the array by uid as it was the
 previous behavior and the IGroup phpdoc does not say anything about the
 keys.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 11:35:41 +07:00
Git'Fellow 951c5b973e
Normalize logical operators
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-05-02 10:10:02 +07:00
Robin Appelman e7ab30f5d8
log performance events for http requests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-28 15:37:57 +07:00
Robin Appelman f5e2b0b22f
allow storing multiple mounts for the same rootid in the mount cache
currently `[$userId, $rootId]` is used as the unique key for storing mounts in the mount cache,
however there are cases where the same rootid is mounted in multiple places for a user which currently leads to not all of those mounts being added to the cache.

Previously this didn't matter as the mount cache was only used to list users with access to a specific file, so a user having access to the file multiple times didn' change anything.

With 24 the mount cache is used for more cases and multiple mounts for the same id becomes relevant.
While I think there isn't a real negative effect atm besides missing the optimized path we should ensure that the mounts are properly listed

Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-28 15:08:08 +07:00
John Molakvoæ 20df0019f1
fix(psalm): systemtags
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-04-28 12:23:52 +07:00
Julius Härtl a6fe9130b9
fix: Empty fallback for template creator action label
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-27 15:52:08 +07:00
Côme Chilliet 346344c153
Update version number in since and deprecated annotations
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:04:32 +07:00
Côme Chilliet b6c17c6ce7
Clear up return types
usersInGroup index by int for BC, searchInGroup index by uid (string).

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:00:45 +07:00
Côme Chilliet 6385a5af36
Let OC\Group\Group handle the fallback and remove default implementation from ABackend
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:00:43 +07:00
Côme Chilliet 3c2b126eba
Make code clearer and bump @ deprecated annotations
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:00:07 +07:00
Carl Schwan a4c599c1c9
Split new method in a new group backend interface
Better for backward compatibility, also move new interfaces to nc 26

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-04-27 12:00:01 +07:00
Carl Schwan 35dc223500
Optimize retrieving display name when searching for users in a group
This is recurrent scenario that we are searching for users and then for
each users we fetch the displayName. This is inefficient, so instead try
to do one query to fetch everything (e.g. Database backend) or use the
already existing DisplayNameCache helper.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-04-27 11:57:45 +07:00
Côme Chilliet 546d94c3ec
Fix file_get_content signatures to make it clear it can return false
In File::getContent, which must return a string, throw an Exception
 instead of returning false.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 09:56:05 +07:00
Christopher Ng 966bc06e8d Create new file/folder labels
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-04-27 03:20:12 +07:00