1395a53602
Refactor `OC\Server::getSecureRandom`
...
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2023-08-29 21:32:40 +07:00
f80282a5ed
Refactor `OC\Server::getL10NFactory`
...
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2023-08-29 21:30:42 +07:00
4536029589
Refactor `OC\Server::getHTTPClientService`
...
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2023-08-29 21:30:01 +07:00
eab46bdfe6
feat: add switch to disable dns pinning
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-29 18:03:54 +07:00
8d1a3daa3f
Allow ext storage Local to go unavailable
...
Whenever an external storage of type Local points at a non-existing
directory, process this as a StorageNotAvailable instead of returning
404.
This makes desktop clients ignore the folder instead of deleting it when
it becomes unavailable.
The code change was limited to external storages to avoid issues during
setup and with the default home storage.
Signed-off-by: Vincent Petry <pvince81@yahoo.fr>
2023-08-29 11:04:31 +07:00
6f520f2304
Merge pull request #40026 from lhsazevedo/auth-token-commands
...
feat: Add auth token list and delete commands
2023-08-29 08:57:07 +07:00
79bc6ba06c
Merge branch 'master' into auth-token-commands
2023-08-28 12:25:01 +07:00
25309bcb45
techdebt(DI): Use public IThrottler interface which exists since Nextcloud 25
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-28 15:50:45 +07:00
066f6ef16c
Stop sending deprecated Pragma header
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-08-28 15:11:22 +07:00
fd0de0a2d1
Fix tests, add test for the new feature
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-28 09:40:12 +07:00
bd37607fc0
chore: Remove unused FilePickerContext from behat tests
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-26 20:56:09 +07:00
771a7b92cc
Add tests for occ user:auth-tokens:delete
...
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
2023-08-25 02:27:41 +07:00
124588d4a6
fix: Make bypass function public API
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:40:24 +07:00
fd9b2d488e
feat: Expose if the own IP is allowed to bypass bruteforce protection
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:36:04 +07:00
a95800c647
feat(security): Add a bruteforce protection backend base on memcache
...
Similar to the ratelimit backend
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:36:03 +07:00
2ace681a2a
Download and enable all
...
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Download and enable all
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
npm run build
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
2023-08-18 22:51:12 +07:00
b6c3507aa0
only determine quota_include_external_storage once for quota wrapper
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-18 14:25:28 +07:00
74c2f61cbd
chore: remove outdated acceptance tests
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-17 19:55:36 +07:00
266fb31180
fix(tests): preview phpunit
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-17 18:58:21 +07:00
998b3a2581
feat(f2v): migrate Files
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-17 18:56:37 +07:00
271e63e41c
Convert isset ternary to null coalescing operator
...
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-08-17 01:36:50 +07:00
e73889a240
cleanup di for share permissions wrapper
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-16 15:25:05 +07:00
5b37d6d9ff
tests: Add test for CacheEntry getters
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-16 14:00:21 +07:00
f57c12b14e
Fix various deprecation warnings in tests on PHP 8.3
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-14 18:13:12 +07:00
ee756579a7
Fix setting static property in tests on PHP 8.3
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-14 16:27:56 +07:00
9fb08f506f
Merge pull request #38082 from nextcloud/allow-wasm-unsafe-eval-in-csp
...
Allow "wasm-unsafe-eval" in CSP
2023-08-11 14:04:49 +07:00
41f2d912d2
Allow "wasm-unsafe-eval" in CSP
...
If a page has a Content Security Policy header and the `script-src` (or
`default-src`) directive does not contain neither `wasm-unsafe-eval` nor
`unsafe-eval` loading and executing WebAssembly is blocked in the page
(although it is still possible to load and execute WebAssembly in a
worker thread).
Although the Nextcloud classes to manage the CSP already supported
allowing `unsafe-eval` this affects not only WebAssembly, but also the
`eval` operation in JavaScript.
To make possible to allow WebAssembly execution without allowing
JavaScript `eval` this commit adds support for allowing
`wasm-unsafe-eval`.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2023-08-10 02:38:41 +07:00
d56e2aad74
test: remove broken steps from files acceptance test
...
The acceptance tests using the recent view fail since the vue migration.
`And I open the details view for "welcome.txt"`
Is looking for a row in the filelist with a span having the class nametext, matching the file name "welcome.txt" and button inside having the class action-menu.
The markup for the files list looks very different after the vue migration and therefor the test is failing.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-09 20:58:29 +07:00
f099aa2714
Merge branch 'master' into fix/llm-migration-not-executed
2023-08-07 13:26:39 +07:00
f62711d2ae
Fix TextProcessing test for 32bit
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-08-07 12:03:11 +07:00
3bd8f8c1db
Merge pull request #39705 from nextcloud/fix/noid/adjust-integrity-test-for-updated-mime-mappings
...
fix: adjust test for font icon
2023-08-04 10:42:08 +07:00
44b4c16a09
Merge pull request #39605 from nextcloud/bugfix/noid/final-events-cleanup
...
fix!: Final round of moving to IEventDispatcher
2023-08-04 10:39:57 +07:00
e0c8d58dd1
fix: adjust test for font icon
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-04 00:01:25 +07:00
0098af3b98
fix: missing argument for TextProcessing Manager
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-03 00:33:00 +07:00
e457572f6b
fix: Acceptance tests adjusted to find new style sidebar tabs
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-02 15:21:34 +07:00
38480fda3c
feat(files_external): migrate to vue
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-01 16:38:06 +07:00
b9e2f494a1
chore!: Remove legacy SymfonyAdapter
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:22 +07:00
cebf93d4d2
fix: Remove legacy dispatcher from share manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
8ad94cbfda
feat!: Migrate unShare events to typed events
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
44b810bfbd
feat!: Migrate Sharing events to typed events
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:19 +07:00
68fc9b48c2
feat!: Migrate AccountManager event to typed event
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:19 +07:00
7e790a3297
JobTest: Remove outdated tests
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-28 11:12:32 +07:00
3d8fd2d99e
cs:fix
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-28 11:12:32 +07:00
449a731375
Add test for ParallelAwareJob
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-28 11:12:32 +07:00
030e8d8916
fix: Align doc type with creation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 23:13:38 +07:00
80f79e170d
fix!: Remove symfony EventDispatcherInterface from Group
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 23:13:37 +07:00
ad12a740cb
fix!: Remove symfony EventDispatcherInterface from User
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 23:13:37 +07:00
6b7221756c
Merge pull request #39571 from nextcloud/bugfix/noid/move-lib-to-IEventDispatcher
...
Move lib/ events to IEventDispatcher where possible
2023-07-27 18:59:42 +07:00
68eecca4d4
chore: update expected results for CLDR 42
...
Punic 3.8.0 / CLDR 42 added a narrow no-break space unicode character for the time formats and a new default pattern for datetime.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-27 13:57:02 +07:00
06248cda0a
chore: update expected timezone from GMT+0 to UTC
...
Punic 3.2.0 added support for timezone translations and returns UTC instead of GMT+0 now.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-27 13:57:02 +07:00
c67c067ee7
fix: Move Sharing events to IEventDispatcher
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:53 +07:00
44a0a62107
fix: Move Node HookConnecter events to IEventDispatcher
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:53 +07:00
6953e14580
fix: Move SystemTags events to IEventDispatcher
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +07:00
dac31ad101
fix!: Remove legacy event dispatching Symfony's GenericEvent from 2FA Manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +07:00
1b387bb341
fix!: Remove legacy event dispatching Symfony's GenericEvent from AdditionalScripts
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +07:00
5bb6a7804f
fix: Move AppManager events to IEventDispatcher
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:51 +07:00
4f7de8ed60
fix!: Remove legacy event dispatching Symfony's GenericEvent
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:51 +07:00
7548e62181
Merge pull request #39506 from nextcloud/techdebt/39488/ensure-index-name-uniqueness
...
feat(db): Ensure that index names are unique across the database
2023-07-24 14:44:37 +07:00
b80692d323
fix(tests): Adjust unit tests to outline the schema is checked twice now
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-21 12:17:36 +07:00
7c80d66ee5
Merge pull request #38854 from nextcloud/enh/llm-api
2023-07-21 11:20:31 +07:00
e9b8a34cce
Merge pull request #39264 from nextcloud/feat/add-instance-category
...
Add instance category while checking new updates
2023-07-21 11:04:32 +07:00
31f1354777
Add instance category while checking new updates
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-07-18 15:39:23 +07:00
3b057600d0
fix: Correctly add `module` content type to script tags when scripts with versions are used
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-07-18 13:10:37 +07:00
ffe27ce14c
Massive refactoring: Turn LanguageModel OCP API into TextProcessing API
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-14 16:00:31 +07:00
d5ee076017
Merge pull request #39329 from nextcloud/feat/phpunit-for-css-generated-file
...
fix: also run phpunit on `apps/theming/css` modified files
2023-07-13 17:58:26 +07:00
c988d782eb
Merge pull request #39331 from nextcloud/feature/openapi/core
...
core: Add OpenAPI spec
2023-07-13 15:36:51 +07:00
1be836273d
core: Add OpenAPI spec
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-13 07:24:15 +07:00
faf2b2339d
test(settings): Users table
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-07-12 21:35:55 +07:00
8faa1a4fe7
fix(acceptance): UsersSettingsContext
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-07-12 21:35:55 +07:00
48e47c6a46
fix: also run phpunit on `apps/theming/css` modified files
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-07-12 09:25:39 +07:00
2c6f32cb28
feat(request): Allow to match the client version with the IRequest::USER_AGENT_* regex
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-11 07:35:50 +07:00
bf2dcd67f3
LLM OCP API: Change Tests to use EventDispatcher mock
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
d56286b8ac
LLM OCP API: s/getAvailableTasks/getAvailableTaskClasses/
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
c568c4a464
Add test for task cleanup
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
20cb9935ca
Fix tests
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
ebc7631544
Add preliminary tests
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
05aa39d777
Fix event names of 2FA related typed events
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-03 14:25:01 +07:00
97683a5b66
fix(settings): Migrate away from deprecated `NcPopoverMenu`
...
* Replace popover menu with `NcActions`
* Deduplicate user actions code between `UserRow` and `UserRowSimple`
* Fix user action to cover whole row heigh to prevent dropdown from shining through the actions
* Fix user action popover to be overlayed by current edited row actions
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-06-30 11:38:11 +07:00
b0001c6010
Add template types to responses
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-06-30 09:33:29 +07:00
5e81a9e53d
fix: Add cypress test for changing password in the users list
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-06-29 00:08:21 +07:00
3fba4c5529
Replace plain input fields with NcTextField fields and NcMultiSelect fields with NcSelect fields
...
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-06-28 21:53:12 +07:00
ec6728d710
feat(HTTPClient): Provide wrapped access to Guzzle's asyncRequest()
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-27 15:53:57 +07:00
9751303182
Merge pull request #38679 from nextcloud/feat/add-spec-to-preview-fetched-event
...
feat: add width, height, crop and mode to BeforePreviewFetchedEvent
2023-06-26 13:53:27 +07:00
783f1b9a2a
Merge pull request #38775 from fsamapoor/constructor_property_promotion_in_core_command_part9
...
Uses PHP8's constructor property promotion in core/Command and /
2023-06-26 10:38:06 +07:00
f7183c9dcf
Merge pull request #38958 from nextcloud/enh/noid/use-getsystemvalue-mailer
...
use getsystemvalue-functions in Mailer.php
2023-06-26 10:23:29 +07:00
fd0e2f711a
Fixes testcase error.
...
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-24 23:14:23 +07:00
e7cbaf3ee3
Clean-up some remaining readdir calls with undesirable false evaluation potential
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2023-06-24 15:37:06 +07:00
17515995fa
Merge pull request #38625 from nextcloud/fix/noid/querysearchehelper-narrow-type
...
fix: expect interface, not a specific implementation
2023-06-24 00:13:43 +07:00
1cb81ae625
try to fix tests
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-06-23 17:12:45 +07:00
440f882322
feat: add width, height, crop and mode to BeforePreviewFetchedEvent
...
user_usage_report keeps a counter for files read.
The app uses
- OC_Filesystem::read hook
- Event listener (the legacy one) for IPreview::EVENT
Request for previews do not trigger the hook, hence the additional event listener.
The thumbnails for a list or grid view should not count, so we need the width and height.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-23 16:27:35 +07:00
a3fe1adb03
Merge pull request #38917 from nextcloud/bugfix/talk-9558/plural-issue-with-some-language-locale-combinations
...
fix(l10n): Fix plural issue with different locale and language
2023-06-22 09:17:48 +07:00
84ff000767
enh(a11y): New user modal
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-06-21 11:12:40 +07:00
f6ac874dbf
chore: ugly type juggling
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 16:53:20 +07:00
f8e697ce4d
feat: prepare jest upgrade and ts testing
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 09:08:04 +07:00
ab8205fd35
fix(l10n): Fix plural issue with different locale and language
...
We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-21 07:14:56 +07:00
7f4651637a
Allow stdClass in XML responses
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-06-13 11:44:47 +07:00
08a3f37695
chore(appframework)!: Drop \OCP\AppFramework\Http\EmptyContentSecurityPolicy::allowInlineScript
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-12 10:03:59 +07:00
ffa30ce89b
Merge pull request #38524 from nextcloud/chore/app/clear-unused-cache-key
...
chore(app): Do not clear unused cache key
2023-06-05 17:48:44 +07:00
a2afc7b6a9
refactor: migrate OC_EventSource to dependency injection
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-03 21:42:51 +07:00
6d076c1ee9
fix(dispatcher): Migrate to OCP event dispatcher before symfony/event-dispatcher upgrade
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-02 08:08:24 +07:00
e76d525a43
chore: Drop \OC_App::getAppInfo
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:27 +07:00
cf6e2fa1b7
chore: Drop \OC_App::getAppVersion
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:26 +07:00
315f7f286f
chore: Drop app code checker test data
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-31 14:57:57 +07:00
3d1acca1f3
chore(app): Do not clear unused cache key
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-30 17:48:20 +07:00
94e1a429e5
Revert "Fix table view"
...
This reverts commit cb852ef6
2023-05-25 11:49:24 +07:00
3d2d1c171e
Merge pull request #37758 from nextcloud/redis-atomic
...
redis: use atomic operations everywhere
2023-05-19 23:29:24 +07:00
48521d67e1
Merge pull request #38143 from nextcloud/fix/generated-avatars-cache
...
Fix generated avatars cache
2023-05-16 11:37:49 +07:00
5e02def3f4
Merge pull request #38274 from nextcloud/bugfix/noid/reach-max-delay-in-afterController
...
fix(middleware): Also abort the request when reaching max delay in af…
2023-05-16 11:07:04 +07:00
2a19753cf7
Clear generated avatar caches
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-05-15 18:18:21 +07:00
3a6bc7aba2
fix(middleware): Also abort the request when reaching max delay in afterController
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:20:19 +07:00
33385d7ecb
fix(tests): Adjust unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:12:14 +07:00
174c226c28
Merge pull request #38207 from nextcloud/fix/jsresourcelocator-l10n-handling
2023-05-12 10:47:46 +07:00
31c01fa3da
fix(JSResourceLocator): Handle missing translations silently
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-05-11 18:22:24 +07:00
cb852ef63b
Fix table view
...
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-05-11 16:36:37 +07:00
db02684008
Merge pull request #37691 from nextcloud/object-store-background-scan
2023-05-11 08:15:41 +07:00
c6cee282b3
redis: move lua scripts to class and add type hints
...
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-05-10 17:37:02 +07:00
2ea41dab93
repair -1 folder sizes for object store background scan
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-10 19:33:26 +07:00
904fdf3aa3
Merge pull request #37838 from nextcloud/event-logger-http
...
log performance events for http requests
2023-05-09 17:15:27 +07:00
b91957e3df
fix(dav): Abort requests with 429 instead of waiting
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-03 22:43:36 +07:00
7fcf42ad3f
Merge pull request #38024 from nextcloud/fix/fix-32bits-ci
...
Fix 32bits ci
2023-05-03 10:34:04 +07:00
ef87dfc478
Merge pull request #33106 from nextcloud/feature/update-expire-date
...
Update expire_date column of table comments
2023-05-03 10:26:28 +07:00
e252182d80
Put back file cleanups, and remove dead code in tests/lib/Template/JSResourceLocatorTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 16:24:28 +07:00
adf743b141
Remove the array_pop failing tests on 32bit CI
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 16:09:37 +07:00
10296ba7e5
Fix tests, and fix Group::searchUsers to avoid duplicates
...
Also went back to searchUsers indexing the array by uid as it was the
previous behavior and the IGroup phpdoc does not say anything about the
keys.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 11:35:41 +07:00
e7ab30f5d8
log performance events for http requests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-28 15:37:57 +07:00
b6c17c6ce7
Clear up return types
...
usersInGroup index by int for BC, searchInGroup index by uid (string).
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:00:45 +07:00
35dc223500
Optimize retrieving display name when searching for users in a group
...
This is recurrent scenario that we are searching for users and then for
each users we fetch the displayName. This is inefficient, so instead try
to do one query to fetch everything (e.g. Database backend) or use the
already existing DisplayNameCache helper.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-04-27 11:57:45 +07:00
5ed6722dd2
Cover expire_date with unit tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-04-26 13:21:08 +07:00
75f17b6094
Merge pull request #37905 from nextcloud/techdebt/noid/add-attributes-for-remaining-security-annotations
...
feat(security): Add PHP \Attribute for remaining security annotations
2023-04-25 17:13:53 +07:00
ecb8b55c5c
feat(security): Add PHP \Attribute for remaining security annotations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-25 14:50:32 +07:00
7250f54ca3
Merge pull request #37835 from nextcloud/feat/background-allow-parallel-runs
...
feat(BackgroundJobs): Allow preventing parallel runs for a job class
2023-04-25 12:10:43 +07:00
06d6cf4ebc
JobListTest: Fix JobList constructor call
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-24 19:07:13 +07:00
6148c5e0a1
Update tests/lib/BackgroundJob/DummyJobList.php
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-24 12:35:52 +07:00
89c3c31402
feat(ratelimit): Add Attributes support to rate limit middleware
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-24 12:24:48 +07:00
a0c722ad69
Run cs:Fix
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
5608b50778
Fix BackgroundJob tests
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
281c8047b6
JobListTest: clearJobsList before testHasReservedJobs
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
56cb5d1d13
fix(tests): Remove duplicated method
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
1296f3612e
test(BackgroundJobs): Add tests for allowParallelRuns and hasReservedJobs
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
b294edad80
Merge branch 'master' into enh/type-iconfig-getter-calls
...
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-04-20 16:52:38 +07:00
b62c49f1e0
Merge pull request #37795 from nextcloud/techdebt/noid/improve-ci
...
fix(CI): Disable unstable test until someone can have a look at it
2023-04-18 21:07:38 +07:00
2c0cfd3772
feat(app-framework): Add native argument types for middleware
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-04-18 17:15:05 +07:00
6ac8052896
fix(CI): Disable unstable test until someone can have a look at it
...
Passes locally 100% and on CI 50% of the time
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-18 13:59:35 +07:00
8fe22ebf60
Merge pull request #36617 from nextcloud/update/psr-container
...
chore: Update PSR container to 2.0.2
2023-04-18 11:40:12 +07:00
d9c81f56ad
tests: Adapt node related unit tests mocks to required root view
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-17 23:46:52 +07:00
160bd75d0a
fix: Use proper path when creating node instances
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-17 23:46:52 +07:00
dc9d8c42bb
fix: Adjust console formatter code to match with Symfony type hints
...
Symfony has added type hints on the `OutputFormatterInterface`,
so we must adjust our type hints to match with Symfony.
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-04-17 18:35:10 +07:00
384a1d34a8
adapt test to new workflow
...
getDirectoryListing should return all files
getFile is not called anymore
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
0375c9866c
add test to verify redis lua script hashes
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-17 16:18:48 +07:00
b153340b62
Add type hints for mappers
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-07 09:49:42 +07:00
5b3900e849
fix(tests): acceptance
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-04-06 15:43:30 +07:00
1ac7a3f107
Merge pull request #37595 from jtrees/add-some-tests-to-lost-controller
...
Add some tests for input trimming in LostController.php
2023-04-06 11:12:52 +07:00
8d5165e8dc
Adapt tests to config value typing
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 17:42:14 +07:00
a4032a3800
Add some tests for input trimming in LostController.php
...
Signed-off-by: Joshua Trees <me@jtrees.io>
2023-04-05 12:15:38 +07:00
8f550398c4
Merge pull request #36836 from nextcloud/fix/view-type-cleanup
...
Tidy up typing in OC\Files\View
2023-04-05 10:14:55 +07:00
d9f8522003
Fix types for reading and writing config values
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +07:00
131f481a67
fix(initial-state): Log an error when initial-state can not be JSON encoded
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-04 10:54:12 +07:00
7ab44b2d28
Merge pull request #37146 from nextcloud/artonge/feat/migrate_metadata_to_value
...
Migrate metadata JSON column to new value TEXT column
2023-04-04 10:23:54 +07:00
c5339fa336
Merge pull request #37542 from nextcloud/bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing
...
feat(security): Allow to opt-out of ratelimit protection, e.g. for te…
2023-04-03 14:19:41 +07:00
1a6709cf43
Migrate metadata as JSON to value as STRING
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-03 14:06:28 +07:00
4393b96542
Remove unused method getLocalFolder
...
It’s not used and not in any OCP interface/class.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:34 +07:00
966a3e6963
Tidy up typing in OC\Files\View
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:33 +07:00
454281af03
feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-03 09:06:45 +07:00
997c2a2a79
fix DBAL exception handling in setValues
...
This seems to be a left over after abstracting DBAL. Nowadays,
IQueryBuilder::executeStatement() only throws a \OCP\DB\Exception, where
previously original DBAL exceptions where thrown. These are now wrapped,
the orignal classes are now mapped to a reason.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-31 17:01:17 +07:00
4f8e916585
Add label for logo link
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-03-29 13:36:45 +07:00
346054f854
Fix tests
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-03-28 09:41:04 +07:00
8b4d49cf50
Merge pull request #36057 from nextcloud/feat/esm-js-scripts
2023-03-22 09:17:28 +07:00
633ea018af
Fix BackgroundCleanupJobTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:21:44 +07:00
bfc37afed3
Merge pull request #36928 from nextcloud/techdebt/noid/bruteforce-protection-attribute
...
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
2023-03-16 19:33:13 +07:00
a30d7c51d3
Merge pull request #37227 from nextcloud/h1-dav-brute-force-protection
...
chore: use local variable for remote address
2023-03-15 15:11:53 +07:00
37cfccabc1
unit tests for Manager::invalidateTokensOfUser
...
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2023-03-14 17:13:30 +07:00
71328107da
Merge pull request #37029 from nextcloud/fix/chunk-objectids-in-systemtagobjectmapper
...
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
2023-03-13 22:10:47 +07:00
9b1d7794a8
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
...
This avoids crashing on Oracle with more than 1000 objects
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-13 17:36:10 +07:00
f1751c4428
Introduced app enable/disable/update typed events
...
OCP\App\ManagerEvent is depreciated since 22 without a replacement
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-03-13 11:52:57 +07:00
39c1b6f49f
chore(tests): add tests for handleLoginFailed
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-03-10 18:04:39 +07:00
2b49861679
Add a debug message when throttling without defining
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-08 12:09:22 +07:00
e839eb9b5c
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-08 12:09:22 +07:00
b4f51fe728
fix(CI): Fix acceptance test password field selector after @nextcloud/vue lib update
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-07 09:34:47 +07:00
c297f8ee96
feat(appframework): ⌚ Make ITimeFactory extend \PSR\Clock\ClockInterface
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-03 15:37:13 +07:00
de64c96a67
Merge pull request #36941 from nextcloud/bugfix/prevent-error-with-oracle-database
...
Split the comments ids by chunks
2023-03-03 12:37:15 +07:00
289fadfd50
Merge pull request #36803 from nextcloud/fix/sqlite-comments
...
[db]: Remove not supported column comments for SQLite
2023-03-02 12:10:19 +07:00
e9295f739e
Split the comments ids by chunks
...
Split the comments ids by chunks to prevent error with Oracle database
that can't do a query with more than 1000 parameters.
https://github.com/nextcloud/spreed/issues/8287
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-03-01 13:08:17 +07:00
0b966ab200
Merge pull request #36471 from nextcloud/fix/theming-keep-images
2023-03-01 09:54:49 +07:00
1785a80754
tests(db): Add test case to ensure column comments work
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-28 10:39:13 +07:00
4f7d77406d
Fix SystemTagManagerTest#createTag test
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 14:40:33 +07:00
889caf4632
Update tests/lib/SystemTag/SystemTagManagerTest.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 14:22:41 +07:00
8151b1b8b0
fix(SystemTagManager): Truncate overlong tag names
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 12:55:10 +07:00
b642137c65
feat(OC/Template): Add `type="module"` for ES6 scripts
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +07:00
00e041b907
feat(template): Allow `JSResourceLocator` to find ES6 scripts
...
Enable module js (ES6) support on the `JSResourceLocator`.
This changes `JSResourceLocator` to look for `.mjs` files first
to allow applications to provide a fallback `.js` for older Nextcloud versions.
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +07:00
98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call"
2023-02-21 07:36:43 +07:00
61b9ba28e4
Add webp and large jpg test assets
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-20 13:11:19 +07:00
614981ae9a
feat(directediting): Allow opening by file id
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-20 12:16:34 +07:00
5d4efb4d5f
Do not set up filesystem on every call
...
Also remove old Oc_FileChunking logis that produced GC- collectable chunks
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-02-17 19:18:37 +07:00
47bc024885
Revert the token scope to not end up with storing the user used in the session
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 10:18:18 +07:00
90d2cb09b1
Merge pull request #36396 from nextcloud/fix/cors
2023-02-17 09:42:08 +07:00
f655f83c84
fix(CORS): CORS should only be bypassed on `PublicPage` if not logged in to prevent CSRF attack vectors
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-16 22:55:18 +07:00
98b998a2de
Merge pull request #36735 from nextcloud/fix/32635/fix-vcf-contacts
...
fix the contacts-menu vcf-contact avatars
2023-02-16 14:01:19 +07:00
b38d2daede
fix the contacts-menu vcf-contact avatars
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-15 23:16:43 +07:00
5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow"
...
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240
Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-15 20:16:51 +07:00
a705132c8d
Merge pull request #36656 from nextcloud/route-instrumentation
2023-02-14 10:12:19 +07:00
b911da3e1e
DI for Router
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-13 22:51:14 +07:00
936f634069
Merge pull request #36643 from nextcloud/fs-setup-instrimuntion
...
more filesystem setup performance instrumentation
2023-02-13 14:37:57 +07:00
91d5f6a826
more filesystem setup performance instrumentation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-10 11:11:13 +07:00
c77998209f
Port user menu to Vue
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-02-09 17:54:59 +07:00
a81d8ecef5
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-09 16:15:47 +07:00
08802ad13f
Merge pull request #36566 from nextcloud/mount-find-by-numeric-id
2023-02-08 20:04:57 +07:00
dcfc96f0cc
Merge pull request #36417 from nextcloud/fix/psr-container
...
Make the container fully fulfill PSR container interface
2023-02-07 20:38:19 +07:00
9f3dbb699a
fix tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-07 15:50:10 +07:00
892e6c642a
Skip buggy tests for 32bits CI
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:33 +07:00
77c8c9c805
Improve error output on failed Router test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:31 +07:00
94ecae4ade
Add helper to cast to int|float, fix MemoryInfo on 32bits
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
0f8c34cdc6
Fix filesize return type error in ViewTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
5cfab229db
Improve test failure output for RouterTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
2d8e696c24
Add apcu and ffmpeg to have less skipped tests
...
Also exclude test groups which rely on a service
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:28 +07:00
59578817f5
Merge pull request #36489 from nextcloud/bugfix/noid/brute-force-protection-password-reset
...
Add bruteforce protection to password reset page
2023-02-06 22:12:25 +07:00
ba8a50c059
fix: Throw `NotFoundExceptionInterface` to fulfill PSR container interface if class not found
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-06 14:16:35 +07:00
875e6cf7e6
fix(CI): Adjust expected result
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-06 11:26:38 +07:00
88d116ba84
fix(client-login-flow): Handle missing stateToken gracefully
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-02-06 09:42:15 +07:00
47880b143d
Remove failing test that works with mocks only anyway
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-02 18:06:31 +07:00
dde5c46a3e
Migrate to Symfony Mailer
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-02 10:30:06 +07:00
1a655e88d9
use php8.0 images
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-01-31 15:44:12 +07:00
c246edece6
tests(oci): Test where statement on longtext column
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
test: try with just passing the type to eq which should also cast
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-01-31 11:57:54 +07:00
2f3007205d
Merge pull request #35160 from nextcloud/artonge/feat/version_naming_backend
...
Allow to name a version
2023-01-30 10:40:49 +07:00
959e2aaa17
fix(tests): Fix method name in unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-30 09:12:50 +07:00
20e00cdf17
feat(app-framework): Add UseSession attribute to replace annotation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-27 09:40:35 +07:00
8d9af3e262
feat(app-framework): Add support for global middlewares
...
This allows apps to register middlewares that always register, not just
for the app's own requests
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-26 11:54:28 +07:00
d8b479752d
Fix hookconnector tests
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
907ff68bfc
perf(app-framework): Make the app middleware registration lazy
...
Before this patch, app middlewares were registered on the dispatcher for
every app loaded in a Nextcloud process. With the patch, only
middlewares belonging to the same app of a dispatcher instance are
loaded.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-25 09:27:24 +07:00
0236c9e8cd
Port files sharing selector
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-24 17:40:17 +07:00
003cc2b45a
Fix tests failures (number of calls differed with last rebase)
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-24 09:38:20 +07:00
a23cd7b961
Fix a bunch of deprecation in the phpunit for core
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-01-24 09:34:09 +07:00
1c099c7f17
Fix broken user:setting command unit test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-23 07:01:22 +07:00
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
89dbc629ff
Fix integrity check
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-20 11:22:11 +07:00
de68fc6347
Update test file for mimetypes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:11 +07:00
b22b6431d2
Fix gzip mimetype mapping
...
PHP now detects it as application/gzip and not application/x-gzip anymore
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:11 +07:00
7ebbb6b2ca
Remove workarounds specific to 7.4
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:08 +07:00
1e2441ff6b
Disable unreliable acceptance tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-19 09:21:33 +07:00
20fcfb5739
feat(app framework)!: Inject services into controller methods
...
Usually Nextcloud DI goes through constructor injection. This has the
implication that each instance of a class builds the full DI tree. That
is the injected services, their services, etc. Occasionally there is a
service that is only needed for one controller method. Then the DI tree
is build regardless if used or not.
If services are injected into the method, we only build the DI tree if
that method gets executed.
This is also how Laravel allows injection.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-18 14:00:38 +07:00
f22101d421
Fix login loop if login CSRF fails and user is not logged in
...
If CSRF fails but the user is logged in that they probably logged in in
another tab. This is fine. We can just redirect.
If CSRF fails and the user is also not logged in then something is
fishy. E.g. because Nextcloud contantly regenrates the session and the
CSRF token and the user is stuck in an endless login loop.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-18 09:39:17 +07:00
dbfe7b1816
Merge pull request #36073 from nextcloud/fix/fix-background-job-list
...
Use a Generator for job list to fix background-job:list command
2023-01-16 11:10:10 +07:00
f6aa5224c4
Focus trap contacts menu with NcHeaderMenu port
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-13 23:19:28 +07:00
238e9cf3a8
feat(CI): Enforce colored output for acceptance tests on drone CI
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-13 11:31:13 +07:00
d74044f634
Fix API breakage by using a new method instead
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-12 17:18:59 +07:00
75fca38e66
Fix BackgroundJob list tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-12 11:40:18 +07:00
7271ec7acf
spaces are allowed in userids
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-01-10 13:25:27 +07:00
42d9e087fb
Remove unused legacy ajax/list.php in files app
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-01-09 15:18:37 +07:00
18164ae516
Merge pull request #33898 from nextcloud/fix/authtoken-password-update
...
PublickKeyTokenProvider: Fix password update routine with password hash
2023-01-05 08:01:47 +07:00
97e33c2bd4
Fix unit tests of the ActionProviderStore
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-04 16:17:43 +07:00
8eca26012f
Show local time in avatar menu
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-04 11:09:58 +07:00
adfe367106
PublickKeyTokenProvider: Fix password update routine with password hash
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-01-04 08:30:53 +07:00
4dc0957164
refactor AutoSubmittedValue to Headers\AutoSubmitted and adding
...
header name to constants
Signed-off-by: Bennet Becker <dev@bennet.cc>
2023-01-03 15:15:35 +07:00
411467af57
fix static-analysis error and formatting code
...
Signed-off-by: Bennet Becker <dev@bennet.cc>
2022-12-23 21:48:52 +07:00
c1c6d215c7
fix getAutoSubmitted return type and adding unit tests
...
Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
2022-12-23 19:26:49 +07:00
bfb3b2af9f
increase preview_max_memory and make it easier to debug
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2022-12-22 09:52:46 +07:00
e2285acd04
Update behat and friends
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-12-21 15:27:59 +07:00
7dcd6eb561
Merge branch 'master' into add-scim-json-support
...
Signed-off-by: Stanimir Bozhilov <stanimir.bozhilov.1998@gmail.com>
2022-12-19 09:07:38 +07:00
ae6fe874ed
Merge pull request #35780 from nextcloud/fix/http-dispatcher-double-parameter-cast
...
Fix missing cast of double controller parameters
2022-12-16 16:18:35 +07:00
6737deabbf
Merge pull request #35784 from nextcloud/chore/strict-login-controller
...
Make the LoginController strict
2022-12-16 16:16:31 +07:00
138deec333
chore: Make the LoginController strict
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-15 10:52:28 +07:00
b6dd1a1d7b
fix(app framework): Fix missing cast of double controller parameters
...
``settype`` allows 'double' as alias of 'float'.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-15 09:33:52 +07:00
81f2857f34
check if params given to API are really an array
...
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-15 13:45:22 +07:00
fb2fb0d2d5
Revert "Copy to clipboard with button instead of link"
...
This reverts commit 4ffc022c8b
2022-12-14 00:57:57 +07:00
2f7a1fca5f
Merge pull request #34477 from nextcloud/bugfix/noid/sharee-recommendations-show-group-id
...
Show group name instead of group id as recommendation
2022-12-09 22:39:28 +07:00
4bcaeb6c2c
Drop 3rdparty root since it is unused and adjust tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 23:55:32 +07:00
306d7829b5
Cache available languages locally
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 22:32:06 +07:00
87e638b1f8
Merge pull request #35649 from nextcloud/bugfix/object-storage-master-key-enc
...
Update the unencrypted file size when closing streams
2022-12-07 22:03:13 +07:00
3c8fb59fa4
Merge pull request #35620 from nextcloud/fix/fix-calendar-imip-tests
2022-12-07 20:39:41 +07:00
59ae6e9dd6
Also update the unencrypted size of files when creating them with empty content
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 19:12:06 +07:00
4a3f3beb0b
use bruteforce protection on all methods wrapped by PublicShareMiddleware
...
if an invalid token is provided or when share password is wrong
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2022-12-07 13:24:50 +07:00
7cf1dec842
Fix errors in calendar tests saying function handleIMipMessage does not exists on ICreateFromString
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-06 13:52:13 +07:00
1821712615
Merge pull request #35596 from nextcloud/fix/move-to-ocp-timedjob
...
Use TimedJob from OCP instead of OC
2022-12-06 12:14:43 +07:00
ee06261b82
Fix codestyle in modified files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-05 16:08:40 +07:00
30560d3165
Merge branch 'master' into tests/fix-phpunit-warnings
...
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2022-12-05 12:03:39 +07:00
578648a062
Adapt tests to new job constructors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-05 10:41:13 +07:00
a4d0700bf2
Fix test image default quality
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2022-12-04 14:51:33 +07:00
a869259e41
More theming cypress tests and some fixes
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-29 11:26:27 +07:00
7c4ceb444c
Add group display name cache
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-11-28 11:52:55 +07:00
4ffc022c8b
Copy to clipboard with button instead of link
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-24 23:50:54 +07:00
20da3d081e
Add label to sharing search field
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-23 02:04:18 +07:00
e35bcc9381
Fix tests
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 10:06:19 +07:00
d1f2e5e967
Increase the fair-use push limit to 1.000 users
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-18 15:39:23 +07:00
d27a39271e
getAppValue expects string
...
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2022-11-17 08:03:05 +07:00
0f3150cff7
Tests adjustement
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2022-11-16 11:01:32 +07:00
68363f6944
Fix some more problems with tests under PHP 8.2
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 16:02:24 +07:00
324126888e
Add Union types for properties in tests/lib/Encryption/Keys/StorageTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 09:29:35 +07:00
0f7e56b3b3
Fix syntax in VerificationTokenTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 09:25:56 +07:00
c79a6b3f62
Fix errors from PHP 8.2 testing
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 17:08:21 +07:00
70e2217d1c
Fix dynamic properties and other problems in tests for PHP 8.2
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 16:14:35 +07:00
4bf1f4e484
Merge pull request #35093 from nextcloud/nickvergessen-patch-1
...
Run integration tests on 3rdparty bump
2022-11-14 09:45:55 +07:00
9dd0d0ba57
Run integration tests on 3rdparty bump
...
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2022-11-11 07:54:26 +07:00
9d0e79f10d
Fix PublicKeyTokenProviderTest import and mock
...
* IDBConnection import missing
* Atomic doesn't need a mock
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-10 15:40:35 +07:00
908b7aa70a
Attempt to fix CalendarImpl tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-09 16:37:34 +07:00
2a684f6741
Fix some phpunit test warnings
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-09 16:37:34 +07:00
f9e9cd270d
Limit-number-of-concurrent-preview-generations
...
Signed-off-by: Bowen Ding <dbw9580@live.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-11-05 16:03:01 +07:00
5c4a66f0c1
Merge pull request #34775 from nextcloud/bugfix/noid/mailer-set-to
...
Do not throw errors when invalid setTo email is provided
2022-11-04 18:24:55 +07:00
fd036f774f
Do not throw errors when invalid setTo email is provided
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-03 16:59:12 +07:00
2e83a21cd2
Merge pull request #34678 from pulsejet/patch-jpeg
...
Interlace all output JPEG
2022-11-03 16:11:03 +07:00
8a2e52e7f8
Merge pull request #34330 from nextcloud/fix/fix-contacts-test-php8
...
Fix ContactsStoreTests under PHP 8.2
2022-11-03 14:55:06 +07:00
ac92d00da8
Merge pull request #32565 from nextcloud/chore/modernize-error-handler
...
Modernize the error handler
2022-11-03 14:42:51 +07:00
052dcdebe8
Refactor the ErrorHandler into a dynamic class
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-02 09:49:37 +07:00
8aea25b5b9
Add remote host validation API
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-10-31 16:13:28 +07:00
4a2bbc7af9
Rewrite admin theming in Vue
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-28 00:18:47 +07:00
d007088cf5
Merge pull request #34847 from nextcloud/refactor/local-address-checker-method-capitalization
...
Rename LocalAddressChecker methods to lower case
2022-10-27 15:57:58 +07:00
07e94eca6f
Emit typed event when preview is requested
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-27 14:31:33 +07:00
d4b9b010b0
Rename LocalAddressChecker methods to lower case
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-10-27 13:24:28 +07:00
0d9c1510ca
Fix ContactsStoreTests under PHP 8.2
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-26 20:03:49 +07:00
3357c8e783
test disabling write check
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-10-26 18:45:59 +07:00
aec8dce61a
Merge pull request #34788 from nextcloud/bugfix/noid/preview-attributes
2022-10-26 15:11:01 +07:00
298d2b9b58
Skip general login with email for non-valid addresses and LDAP
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-26 12:30:25 +07:00
48917e718e
Interlace all output JPEG
...
Progressive images are both smaller and faster to load.
Signed-off-by: Varun Patil <radialapps@gmail.com>
2022-10-25 09:40:20 +07:00
8629d8e44f
Check share attributes on preview endpoints
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-25 11:35:31 +07:00
11108e8032
Revert "fix external storages access"
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-10-23 22:36:34 +07:00
304c1b9b61
Merge pull request #33087 from nextcloud/fix/30282/external-storages
...
fix external storages access
2022-10-23 10:42:46 +07:00
2d98cd1daf
Add config and fix selenium
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-19 10:04:51 +07:00
1cb0c2ac52
Fix LostController test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-18 14:49:02 +07:00
c671466422
Merge pull request #34379 from nextcloud/fix/transactional-session-token-renewal
...
Run session token renewals in a database transaction
2022-10-18 11:19:33 +07:00
d29332469a
Merge pull request #34609 from nextcloud/enh/noid/always-enable-theming
...
set theming app to alwaysEnabled
2022-10-18 10:13:56 +07:00
c5922e67d3
Run session token renewals in a database transaction
...
The session token renewal does
1) Read the old token
2) Write a new token
3) Delete the old token
If two processes succeed to read the old token there can be two new tokens because
the queries were not run in a transaction. This is particularly problematic on
clustered DBs where 1) would go to a read node and 2) and 3) go to a write node.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-10-18 08:28:22 +07:00
1d17a0843a
set theming app to alwaysEnabled
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-10-17 17:51:39 +07:00
9919116716
Merge pull request #31499 from nextcloud/bugfix/empty-secret
...
Add fallback routines for empty secret cases
2022-10-17 16:02:58 +07:00
d77e832223
Fix tests
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-14 16:18:40 +07:00
b28757fddc
Merge pull request #34437 from nextcloud/feat/theming-default-system-value
...
Use default system primary
2022-10-13 19:57:28 +07:00
db831359d3
Allow to pick custom colour
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-10-13 12:13:39 +07:00
799f660df0
Make CI green again
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-13 11:13:13 +07:00
e674087ebf
Adjust unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-12 16:03:57 +07:00
60ee874485
Remove long depreated AppFramework/Db/Mapper
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2022-10-10 08:18:32 +07:00
7d024bc337
Merge pull request #32635 from andyxheli/patch-3
...
Fix User profile picture when performing the search
2022-10-05 10:36:43 +07:00
7044191eb6
Use brand color for background only and keep accessible color as color primary
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-05 06:19:08 +07:00
ae6a7c88a0
Update ContactsStoreTest.php
...
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
2022-10-03 09:17:27 +07:00
ca958de7e9
Merge pull request #33566 from nextcloud/fopen-not-found-rescan
...
trigger a rescan when trying to fopen a file that exists in cache but not on disk
2022-10-01 21:47:26 +07:00
a4c2aeef45
Merge pull request #34329 from nextcloud/fix/cleanup-long-time-deprecated-stuff
...
Remove some constants and functions which have been long deprecated
2022-10-01 17:55:31 +07:00
910c774b35
Merge pull request #34038 from nextcloud/fix/migrate-TagMapper-to-QBMapper
...
Migrate TagMapper to QBMapper instead of deprecated Mapper
2022-09-30 16:46:42 +07:00
4123eeeaa3
Fix ContactsManagerTest test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-30 13:20:04 +07:00
5347fb02dc
Remove some constants and functions which have been long deprecated
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-30 13:20:03 +07:00
92a5a8f075
Cleanup tags and Share component
...
- Port to LoggerInterface
- Use IDBConnection and IQueryBuilder instead of raw SQL and OC_DB
- Use IEventListener instead of hooks
- Remove the now unused OC_DB and OC_DB_StatementWrapper legacy utils
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-29 15:15:28 +07:00
1de0b10751
add test for trying to fopen a file which no longer exists on disk
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-29 10:27:32 +07:00
295d03869e
Fix various theming bugs
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-28 17:12:56 +07:00
de23ff38ff
Move avatar clearing in the background
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-26 15:26:31 +07:00
46c10c77e1
Fix the JSON content type regex to match all MIME types
...
Signed-off-by: Stanimir Bozhilov <stanimir@audriga.com>
2022-09-26 11:51:44 +07:00
a133a8a9d7
remove getDefaultInstallationBundle
...
- because all apps are shipped now it was returning an empty result
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-22 15:11:39 +07:00
a7af25e1d9
remove InstallCoreBundle repair step
...
- core bundle was empty and thus removed
- all former apps installed this way are shipped
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-22 13:24:06 +07:00
759eaee5ed
remove Core Bundle
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-22 13:20:37 +07:00
f7d51a39cf
Add unit tests for application/scim+json content type
...
Signed-off-by: Stanimir Bozhilov <stanimir@audriga.com>
2022-09-20 16:19:05 +07:00
31117fa7c7
Fix tests for nested v4 in v6
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-20 12:46:22 +07:00
c083f77e4e
Harden tests for local IP detection in URLs
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-20 12:14:33 +07:00
4efd0be525
Inform ServerTest that TagMapper now uses QBMapper
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-19 10:01:49 +07:00
d39f047af2
Merge pull request #34072 from nextcloud/enh/noid/default-enabled-2
...
set defaultEnabled in shipped.json
2022-09-15 22:03:12 +07:00
d8961ed10f
fix using FSEEK_END with SeekableHttpStream to get file size
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-15 17:23:16 +07:00
1998ac7b06
Increase timeout for apps management
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-09-15 17:11:14 +07:00
da01494a37
Add accessibility entry in user menu
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-09-14 15:05:35 +07:00
bc9a488046
Update avatars on update
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-09 14:23:41 +07:00
eac54c4660
Merge pull request #33788 from nextcloud/improve-recent
...
Improve getting recent files performance
2022-09-08 16:19:41 +07:00
c77cc80fcc
Merge pull request #33906 from nextcloud/fix/fix-calendar-tests-getTimestamp
...
Fix Calendar tests mocking a non-existant method.
2022-09-08 12:42:03 +07:00
e3a52ce13e
Fix iMIP tests
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-09-08 02:26:46 +07:00
417f46e467
Merge pull request #33600 from nextcloud/lazy-quota
...
get quota for user only when needed
2022-09-07 18:10:33 +07:00
43d1aa38df
More cleaning up of the login component
...
- Move css in scopped vue components
- Port to NcNoteCard all the warning messages
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-06 15:20:29 +07:00
98c525a91a
Fix trying to use MockBuilder instead of Mock
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-06 09:05:36 +07:00
0b37d89893
Fix Calendar tests mocking a non-existant method.
...
There is no ITimeFactory::getTimestamp method, only getTime
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-05 18:09:49 +07:00
67551f379f
Filter out old files when trying to get recent files
...
Only do so when asking for less than 100 files and having an offset
equal to 0.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-05 12:53:32 +07:00
6132b6a4ae
Merge pull request #33790 from nextcloud/Valdnet-patch-2
...
l10n: Spelling unification
2022-09-02 17:01:52 +07:00
b31c92e6f5
fix tests
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-09-02 16:07:13 +07:00
bd91c56539
get quota for user only when needed
...
always apply the wrapper but have the wrapper get the quota lazily only when an operation where quota is applied is performed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-01 19:32:24 +07:00
92925233ec
Maximize browser window before running the tests
...
By the default the browser window is not maximized, but opened with a
size of 1050x978px. In the Files app, when the navigation bar and the
side bar are both open, with the previous design that width caused the
file name to be very very narrow, but still clickable. However, with the
updated design the file name is too narrow and no longer clickable,
which breaks several acceptance tests that descend into subfolders. To
solve that now the browser window is maximized before running the tests,
which makes the window wide enough (1360px) to show the file name and
make it clickable.
This commit also removes a step to close the sidebar that was recently
added to address the problem mentioned above in a previous pull request.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-09-01 14:15:43 +07:00
76b0947022
Wait for the new user form to be visible
...
Before it was checked if the new user form was visible, but it was not
waited for it. It seems that it can happen that the new user form is in
the DOM, and therefore found, but not visible yet when the tests run,
which caused them to (randomly) fail. Due to that now it is explicitly
waited until it is visible, rather than assuming that it is visible as
soon as it appears in the DOM.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-09-01 14:15:43 +07:00
6dac33ee56
Adjust theming acceptance tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-09-01 14:15:43 +07:00
3ae439710e
Merge pull request #33764 from nextcloud/cloudid-cache
...
cache cloud id data in CloudIdManager
2022-09-01 13:27:12 +07:00
67ecd72972
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-31 20:54:39 +07:00
b0f6ca0e0d
Merge pull request #33756 from nextcloud/enh/noid/admin-settings-directly
...
add a way to open the admin settings overview directly
2022-08-31 17:56:11 +07:00
1626a56dda
adjusts tests for CloudIdManager
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-31 15:47:00 +07:00
0c90474296
add a better icon for personal settings
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-08-31 15:37:48 +07:00
17ee17cdbf
fix tests
...
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-08-31 14:35:13 +07:00
ac2d885899
Adjust acceptance tests to changes in app menu
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-08-31 12:57:16 +07:00
f56ecf9242
Merge pull request #33640 from nextcloud/fix/fix-symfony-event-typing
...
Port Repair and Migrator events to IEventDispatcher
2022-08-30 14:47:05 +07:00
6f80fe6ada
Remove deprecated at matcher from tests/lib
...
Only 15 warnings left in there
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-29 16:36:40 +07:00
791e021455
Remove deprecated at matcher in Updater/VersionCheckTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-29 15:11:18 +07:00
e5731b3c30
Fix BackgroundRepairTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:15:48 +07:00
5d313da709
Fix RepairTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:15:48 +07:00
a83a8f0dde
Migrate Migrator::executeSql to OCP\EventDispatcher\Event
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:13:47 +07:00
2911dffd5e
Merge pull request #33516 from nextcloud/update-nextcloud-vue-6.0.0-beta.2
...
Bump @nextcloud/vue to 6.0.0-beta.4 and related
2022-08-25 13:29:36 +07:00
9b5569ff74
Merge pull request #33668 from nextcloud/tests/fix-session-middleware
...
Fix SessionMiddlewareTest and cover new case with reopening
2022-08-25 11:00:35 +07:00
ede9ac2a75
Adjust acceptance test selectors
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-25 09:54:44 +07:00
83b1415906
Only pass parent if paths match
...
As the user folder might be initialized by the root from two levels
down the hierarchy, passing this as a parent only works if the path matches
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-24 22:20:32 +07:00
b2d6435737
Avoid extra query for the parent node if we can pass it along
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-24 22:20:32 +07:00
bd7ab89d2a
Merge pull request #33593 from nextcloud/improve-binary-caching
...
Move findBinaryFinder and isFunctionEnabled away from OC_Helper
2022-08-24 13:09:55 +07:00
64a7489958
Fix SessionMiddlewareTest and cover new case with reopening
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-24 10:36:57 +07:00
9b8ca9ad1f
Move findBinaryFinder and isFunctionEnabled away from OC_Helper
...
findBinaryFinder is now a service that is still private but with some
minor optimization (remove the hasKey check).
isFunctionEnabled is now in OCP\Util
Both function are still keep but all internal usage in nextcloud/server
were migrated to the new usage, so that we can remove it in 26
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-23 19:44:04 +07:00
b888c61463
Merge pull request #33047 from nextcloud/fix/ijob-logger-deprecated
...
Deprecated ILogger from IJob
2022-08-23 16:55:42 +07:00
4ca4b02793
Support iMIP invitations from Mail
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-08-22 22:10:12 +07:00
a2d145734a
Merge pull request #33565 from nextcloud/debt/remove_todo_push_service_fairuse
...
Remove time check in isFairUseOfFreePushService
2022-08-17 14:14:03 +07:00
312b719acf
Merge pull request #32943 from nextcloud/unencrypted-size-revert-interface-changes
...
Revert interface changes from "store unencrypted size in the unencrypted_size column"
2022-08-17 11:36:16 +07:00
227c766f16
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-17 11:25:18 +07:00
2360d880fa
Merge pull request #33540 from nextcloud/mount-provider-migration
...
fix updating cached mounts that didn't have their mount provider set previously
2022-08-17 10:41:31 +07:00
082432e01c
Merge pull request #33551 from nextcloud/scanner-dont-update-same-size
...
don't update the folder size if we know it hasn't changed
2022-08-17 09:21:30 +07:00
1850d0ae96
cleanup scannertest a bit
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-16 13:56:51 +07:00
1374cbee3e
store unencrypted size in the unencrypted_size column
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-16 13:54:26 +07:00
887952b4f4
add tests for cached mount provider migration
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-16 13:47:43 +07:00
5e375d9092
Revert "store unencrypted size in the unencrypted_size column"
...
This reverts commit 8238582e59
2022-08-16 12:07:14 +07:00
6e0123a1d0
Revert "add case statement to sql function builder"
...
This reverts commit 2a68819a67
2022-08-16 12:07:13 +07:00
51b9847fad
Merge branch 'master' into display-name-cache-public
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-15 15:28:30 +07:00
d95557e429
Merge pull request #33415 from nextcloud/fix/integration-test-notif
...
Fix integration tests
2022-08-08 17:06:57 +07:00
f8b13ecd60
Merge pull request #32363 from nextcloud/cleanup/remove-long-deprecated-classes
...
Remove OCP\App and OCP\BackgroundJob
2022-08-08 17:05:11 +07:00
49334e4d9c
Fix many tests and warnings
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-08 17:03:51 +07:00
48d9c4d2b0
Port existing server code to new interface
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-08 17:03:19 +07:00
cbd5cef2cc
Merge pull request #33398 from nextcloud/enh/noid/sensitive-methods-apps
...
allow apps to specify methods carrying sensitive parameters
2022-08-05 14:09:55 +07:00
7e7dcdaf17
Merge pull request #33435 from nextcloud/fix/remove-at-matchers-in-tests
...
Remove at matchers from tests in oauth2 and tests/Test
2022-08-04 09:58:26 +07:00
09362eaeaa
Support specifying IPv6 proxies in CIDR notation
...
Previously, it was not possible to use CIDR notation for IPv6 proxies
in the trusted_proxies parameter of config.php [1]. This patch adds
support for that.
[1]: https://docs.nextcloud.com/server/24/admin_manual/configuration_server/reverse_proxy_configuration.html#defining-trusted-proxies
Signed-off-by: Simon Leiner <simon@leiner.me>
2022-08-02 17:36:47 +07:00
9475cc02b2
Merge pull request #32958 from nextcloud/fix/noid/permission-update-allow-public-uploads
2022-08-02 16:49:27 +07:00
539162ba8b
Remove at matchers from tests in:
...
* apps/oauth2
* tests/Test/Repair/Owncloud
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-02 15:27:52 +07:00
acc68e9f93
fix share manager tests
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-08-02 01:35:10 +07:00
cb271b759e
Fix dynamic property creations in test files
...
This fixes warnings in PHP 8.2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-01 15:07:53 +07:00
a24ed79f85
Fix integration tests
...
The html tags changed in the notification apps, adapt selector to the
new state
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-01 12:38:19 +07:00
458c2fa297
Remove OCP\App and OCP\BackgroundJob
...
Both deprecated since NC 23
IAppManager is the replacement for OCP\App unfortunately it can't be
dependency injected in classes used by the installed otherwise the
database connection is initialised too early
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-01 09:46:40 +07:00
f74e89bde5
Merge pull request #32482 from nextcloud/enh/noid/share-attributes
...
Add share attributes + prevent download permission
2022-08-01 09:44:31 +07:00
952acd4d27
Merge pull request #33225 from nextcloud/fix/handle-one-time-passwords
...
Handle one time password better
2022-07-29 12:26:52 +07:00
6941c91531
add unit test for ExceptionSerializer
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-29 12:07:41 +07:00
03b1791cca
Fix share attribute related tests + code style
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
a95c19e14b
Add share attributes + prevent download permission
...
Makes it possible to store download permission
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
702445ba3b
Handle one time password better
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-28 14:26:25 +07:00
253118298d
Redesign guest pages for better accessibility
...
- Use white box and put content on it
- Improve focus indicator
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-27 10:43:21 +07:00
525cf58735
Adjust acceptance tests to changes in sharing tab
...
The name of the user shared with is now marked with a "span" rather than
with "h5".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-07-26 15:13:18 +07:00
b4353c4651
Merge pull request #33320 from nextcloud/bugfix/noid/remove-files-duplicate-dom-ids
...
Replace files app ids to classes
2022-07-26 12:21:13 +07:00
7615536977
Merge pull request #33031 from nextcloud/fix/improve-local-ip-detection
...
Improve local IP detection
2022-07-26 11:39:32 +07:00
bb2557c389
Replace files app ids to classes
...
Replaced ids to classes for the following:
- #filestable -> .files-filestable
- #fileList -> .files-fileList
- #controls -> .files-controls
- #emptycontent -> .emptyfilelist.emptycontent
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-26 10:19:19 +07:00
bbe15b4b43
Merge pull request #33129 from nextcloud/fix-reading-blob-as-resources
...
Fix reading blob data as resource
2022-07-25 17:56:03 +07:00
7a0648757a
Delete comments that expired now
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-07-25 11:30:20 +07:00
1d30fb7852
Fix reading blob data as resource
...
PostgreSQL returns data as resource when using IQueryBuilder::PARAM_LOB
(which is used for QBMapper).
Previously we just converted this resource using settype, which produced
things like "Resource id #14" instead of the actual resource data.
Now we read the stream correctly if the returned data is a resource
See context at #22472
Fixes #22439
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-07-25 09:45:47 +07:00
b3b6f2d581
fix Controller tests
...
- added pageTitle in code was missing in expectations
- fixed warnings of superflouos parameter
- fixed wrong type of mock
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-22 22:15:41 +07:00
6c3c7a5e4d
Merge pull request #32981 from nextcloud/typing/carl/simplefs
...
Add typing to SimpleFS
2022-07-18 12:34:11 +07:00
19a36b58a6
Add typing to SimpleFS
...
- Fix putContent sometimes return a bool and sometimes nothing
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-14 17:20:51 +07:00
d5c23dbb9f
Move CappedMemoryCache to OCP
...
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-14 15:54:31 +07:00
c20d34b2ca
Merge pull request #32552 from nextcloud/enh/improve-job-handling-commands
...
Improve job handling through occ
2022-07-12 16:04:57 +07:00
0386f4270b
Fix DummyJobList typing
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-12 14:27:02 +07:00
c5ffd7ce32
Use Symfony IpUtils to check for local IP ranges
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-12 12:09:05 +07:00
16b5e6bc7f
Merge pull request #32973 from nextcloud/cleanup/avatar-code
...
Cleanup avatar related code
2022-07-11 11:56:39 +07:00
50a7f612d9
Fix DummyJobList class used by tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
74ebb72622
Merge pull request #33110 from nextcloud/feat/handle-onetime-password-large
...
Handle one time password and very large passwords
2022-07-08 19:54:05 +07:00
ec5cbdeb7f
Make Color class public
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-05 14:44:44 +07:00
1c23c029af
Handler large passwords
...
For passwords bigger than 250 characters, use a bigger key since the
performance impact is minor (around one second to encrypt the password).
For passwords bigger than 470 characters, give up earlier and throw
exeception recommanding admin to either enable the previously enabled
configuration or use smaller passwords.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-05 11:37:14 +07:00
cdf3b60555
Handle one time passwords
...
This adds an option to disable storing passwords in the database. This
might be desirable when using single use token as passwords or very
large passwords.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-05 11:25:44 +07:00
2ad53742f2
fix external storages access
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-07-01 22:52:10 +07:00
d722a0c12a
Adjust fake manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-01 16:38:58 +07:00
198224bf7a
Allow to expire comments of multiple objects with one call
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-01 15:59:29 +07:00
d6e35dfe2c
use blueprint from repo
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-30 15:52:33 +07:00
64bff27c99
Merge pull request #32960 from nextcloud/fix/avoid-using-undeclared-properties
...
Fix PHP 8.2 warnings about undeclared properties
2022-06-28 12:05:16 +07:00
0fe7064fc4
Merge pull request #32998 from nextcloud/fix/setting_name
...
Rename setting name to reduce its length
2022-06-27 11:58:54 +07:00
347ca20f4e
Rename setting name to reduce its length
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-27 11:04:17 +07:00
4722baf970
Merge pull request #32863 from nextcloud/feature/add-comments-expire-date
...
Add comments expire date
2022-06-24 10:28:13 +07:00
812016d626
Cleanup avatar related code
...
- Move event listener to new event handling
- Add typing almost everywhere
- Fix inconsistent interface parameter
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-22 16:11:42 +07:00
cf5452e633
Merge pull request #32242 from nextcloud/fix-logging-data-array
...
Fix logging data context to file
2022-06-21 18:49:08 +07:00
1bd5222224
Fix PHP 8.2 warnings about undeclared properties
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-21 16:17:52 +07:00
53eafc0cb7
Merge pull request #32868 from nextcloud/fix/replace-opis-closure-by-laravel-fork
...
Replace opis/closure by laravel/serializable-closure
2022-06-21 12:21:32 +07:00
fd8f2aff09
Merge pull request #32901 from nextcloud/fix/remove-at-matcher-in-lib-tests
...
Remove at matcher uses in tests/lib
2022-06-21 11:45:00 +07:00
95f0cb2a2a
Add a test about unserializing data from opis/closure serialization
...
We need to be able to unserialize data from before upgrade.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-20 17:34:29 +07:00
3be1217c04
Follow the most common pattern used in project
...
```
git grep strval|wc -l
32
git grep "(string)"|wc -l
481
```
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-06-20 11:46:13 +07:00
6a1510f8ee
Remove some more at matchers in tests/lib
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-20 10:53:06 +07:00
c1f054a9e0
Fix email shares not being shown to other users
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2022-06-17 17:31:26 +07:00
8b2b5946e6
make placeholder a const for reuse
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:38:29 +07:00
891c10d09d
fix overwriting original vars when logging
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:36:58 +07:00
09a5947a6d
add serializer test
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:36:58 +07:00
c7e1c36362
Remove at matcher uses in tests/lib
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-16 17:43:17 +07:00
c59b0c2ff7
Add comments expire date
...
https://github.com/nextcloud/spreed/pull/7327
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-06-15 11:58:29 +07:00
ad10cd5f65
Merge pull request #32813 from nextcloud/debt/noid/check-for-3rdparty-updates
...
Run php tests when 3rdparty changed
2022-06-14 12:34:55 +07:00
4f230877e9
Merge pull request #32853 from nextcloud/fix/update-acceptance-composer-lock
...
Update dependencies in acceptance tests composer.lock
2022-06-13 13:55:47 +07:00
8809de1eef
Merge pull request #31966 from nextcloud/unencrypted-size
...
store unencrypted size in the unencrypted_size column
2022-06-13 11:55:37 +07:00
5cce1b92ff
Update dependencies in acceptance tests composer.lock
...
It should allow to run them on PHP>=8.0 with a recent phpunit.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-13 10:24:42 +07:00
abe5ff3654
Make LostController use IInitialState and LoggerInterface
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-10 16:41:41 +07:00
6283d14fa6
Modernize the LostControllerTest test
...
Remove some depreciated at() calls
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-10 16:41:41 +07:00
44e13848a1
Add password reset typed events
...
These hooks are only used in the Encryption app from what I can see.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-06-10 16:41:41 +07:00
17a12bf617
Run php tests when 3rdparty changed
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-06-10 14:20:43 +07:00
6e3d668436
Keep non default protocol in cloud id
...
When there is no protocol on the cloud id, we assume it's https://
But this means that when an http:// server currently sends an OCM
invite to another server, the protocol is striped and the remote
instance will try to talk back to https:// which might not be available.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-09 15:23:05 +07:00
e76d8bb901
Merge pull request #32697 from nextcloud/fix/get-avatar-authz
2022-06-08 16:27:31 +07:00
7c50dd888e
Test all scopes
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-07 23:57:21 +07:00
7455cd9dd7
Fix get avatar authorization
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-07 23:57:21 +07:00
50ed84fe17
Simlify tests for integrity check on modified mimetype lists
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-06-07 21:54:27 +07:00
8238582e59
store unencrypted size in the unencrypted_size column
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-02 16:07:00 +07:00
2a68819a67
add case statement to sql function builder
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-02 15:52:12 +07:00
b212e8dcc9
Add unit tests for encryption's isSystemWideMountPoint
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-06-01 18:10:59 +07:00
0726271504
Merge pull request #32371 from nextcloud/fix-31952
...
More meaningfull message when a public authenticated share's password is wrong or has expired.
2022-06-01 09:04:11 +07:00
4a790fedf0
More meaningfull message when a public authenticated share's password is wrong or has expired
...
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
2022-05-31 17:26:58 +07:00
699f259c45
Merge pull request #32667 from nextcloud/followup/32655/fix-tests
...
Fix unit tests
2022-05-31 11:30:51 +07:00
279e06a80f
Merge pull request #32587 from nextcloud/bugfix/noid/improve-jsconfighelper
...
Improve JSConfigHelper code quality a bit
2022-05-31 10:29:30 +07:00
c2af3667dc
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-31 10:23:52 +07:00
3901a93c72
Use JSON_THROW_ON_ERROR instead of custom error handling
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-05-30 19:17:49 +07:00
0886437f2c
Merge pull request #32591 from nextcloud/fix/node-test
...
Fix node tests ci
2022-05-30 17:00:27 +07:00
1164c762eb
Merge pull request #31948 from nextcloud/core-cleanup-74
...
Update core to PHP 7.4 standard
2022-05-30 14:37:37 +07:00
f9efc410fa
Restore old behaviour of sending flase for not found apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-30 12:41:35 +07:00
623293c2dd
Fix node tests ci
...
- Update jest snapshot
- Fix importing 3rdparty vue components
- Disable temporarely tests using nextcloud-vue/Button
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-30 10:54:45 +07:00
8951f069fe
Require a recent phpunit version in integration and acceptance
...
Otherwise build with PHP>8 will fail as PHPUnit 6 does not support it
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-24 18:54:29 +07:00
8d599c3410
Merge pull request #32378 from nextcloud/fix/psalm-userbackend
...
Fix psalm issues related to the user backend
2022-05-23 11:41:21 +07:00
b70c6a128f
Update core to PHP 7.4 standard
...
- Typed properties
- Port to LoggerInterface
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 22:18:06 +07:00
9ec0cb0a90
Fix psalm issues related to the user backend
...
- Reflect the actual return value returned by the implementation in the
the interface. E.g. IUser|bool -> IUser|false
- Remove $hasLoggedIn parameter from private countUser implementation.
Replace the two call with the equivalent countSeenUser
- getBackend is nuallable, add this to the interface
- Use backend interface to make psalm happy about call to undefined
methods. Also helps with getting rid at some point of the old
implementActions
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 17:14:58 +07:00
18dd460720
Merge pull request #26813 from nextcloud/feature/files-search-tags
...
Files: Extend search to also cover tags
2022-05-18 10:58:02 +07:00
6d6662ec68
expose displayname cache trough a public interface
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-05-18 03:47:34 +07:00
f755ee0868
Files: Extend search to also cover tags
...
fixes #326
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2022-05-17 21:05:09 +07:00
4d26a9afa0
Allow to tweak default scopes for accounts
...
Close #6582
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-16 22:54:51 +07:00
07f17d01cc
Merge pull request #32306 from nextcloud/fix/migrate-phpunit-configuration
...
Migrate phpunit configuration to new format
2022-05-16 20:44:00 +07:00
fd576b568c
Merge pull request #32305 from nextcloud/bugfix/32302/fix-browser-agent-trimming
...
Fix user agent trimming on installation
2022-05-16 11:20:46 +07:00
6084d691b0
Merge pull request #32375 from nextcloud/bugfix/noid/show-user-account-on-grant-loginflow-step
...
Show user account on grant loginflow step
2022-05-16 11:18:22 +07:00
40b9769d4d
Extend tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-16 10:33:30 +07:00
85758a4f70
Merge pull request #31662 from nextcloud/modernize-contactmenu
2022-05-13 20:14:31 +07:00
b8a7ab9941
Fix jsunit
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-13 16:13:01 +07:00
9a9409e315
Remove SCSSCacher
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-13 16:10:45 +07:00
9fcf531154
Merge pull request #30863 from nextcloud/performance/saving-user-profile-info
...
Minor optimizations for saving user personal information
2022-05-13 12:56:39 +07:00
fe33e9c08c
Merge pull request #32250 from nextcloud/cleanup/cappedmemorycache
2022-05-13 08:27:28 +07:00
eef973e85b
Minor optimizations for saving user personal information
...
* Remove double hook: the OC_User::changeUser triggers an
OC\AccountManager::userUpdated and the app is already listening to this
signal in its Application definition
* Make createCard not check if an card exists if we already checked
previously. We also don't try to get the card if the user is disabled
as we don't use the card in this case
We this change we go from 100 DB requests to 80 DB requests when saving
an user email address.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
(cherry picked from commit c6fd482edf33214a9ad4787e4cac278f871fa7c8)
2022-05-12 21:02:52 +07:00
23771f0587
Merge pull request #32077 from nextcloud/cleanup/lock
...
Cleanup lock related code
2022-05-12 20:57:38 +07:00
232322fe06
Modernize contacts menu
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-12 18:31:59 +07:00
fcae6a68c3
Cleanup lock related code
...
- Port to QueryBuilder
- Improve the doc a bit
- Add type hinting
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-12 15:09:58 +07:00
ec6b83cc18
Add stricter psalm type for CappedMemoryCache
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-12 15:06:18 +07:00
01dbd22c9c
Validate requested length is random string generator
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-05-12 13:58:18 +07:00
3c6253f965
Remove old legacy SvgController and IconsCacher
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-10 23:24:07 +07:00
a953401999
Migrate phpunit configuration to new format
...
Fixes:
Warning: Your XML configuration validates against a deprecated schema.
Suggestion: Migrate your XML configuration using "--migrate-configuration"!
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-09 11:51:14 +07:00
7b3e2217de
Fix user agent trimming on installation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-09 08:36:34 +07:00
0284c0f717
Merge pull request #32276 from nextcloud/fix/ldap_error_handling
...
Do not dispatch postSetPassword when setPassword fails
2022-05-05 20:19:28 +07:00
7718c9776c
Merge pull request #32113 from nextcloud/bugfix/noid/fix-csp-merging-bools
...
Add CSP policy merge priority for booleans
2022-05-05 17:26:48 +07:00
8a2cf5bb68
Do not dispatch postSetPassword when setPassword fails
...
Also Improve error message when setPassword fails
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-05 17:21:23 +07:00
d3efd40a24
Merge pull request #32259 from nextcloud/adjust-acceptance-tests-to-changes-in-notifications-markup
...
Adjust acceptance tests to changes in notifications markup
2022-05-05 09:21:00 +07:00
24e25a6b64
Merge pull request #32249 from nextcloud/bugfix/noid/fix-missing-subline-info
...
Expose shareWithDisplayNameUnique also on autocomplete endpoint
2022-05-05 09:20:45 +07:00
3c451f8357
Adjust acceptance tests to changes in notifications markup
...
Since nextcloud/notifications#1178 each notification in the list is a
"<li>" rather than a "<div>".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-05-03 23:16:24 +07:00
290697b08f
Merge pull request #32220 from nextcloud/feature/add-tests-to-validate-emojis
...
Include more emoji chars to test and fixes after include it
2022-05-03 16:08:19 +07:00
6e4d721278
Expose shareWithDisplayNameUnique also on autocomplete endpoint
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-03 12:51:23 +07:00
1e7d924c61
Fix logging data context to file
...
It was only logged when an exception was provided or when using
logData (which is not being much used).
We make sure the interpolated parameters are not logged.
Only tested with file write logger, but shouldn't work differently.
Crash reporters always had the context.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-02 19:29:35 +07:00
459202d54c
Merge pull request #31752 from nextcloud/fix/remove-still-more-ilogger
...
Move away from deprecated ILogger
2022-05-02 10:15:10 +07:00
cefcd55994
Include more emoji chars to test and fixes after include it
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-04-29 14:00:57 +07:00
8184e356f4
Remove test for removed class SearchResultSorter
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-28 14:56:26 +07:00
902476fa20
Extract the EmojiService from user status and add an OCP interface
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-28 07:09:44 +07:00
a4cd9fd37c
Add a unit test for translation with trailing colon
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-26 11:05:19 +07:00
59e0402691
Merge pull request #32069 from nextcloud/cleanup/allconfig-sql
...
Cleanup AllConfig
2022-04-25 18:56:15 +07:00
0b27b9e658
Get not only time-sensitive next job from list but any
...
Before the change webcron used to select
**only** time-sensitive tasks.
Signed-off-by: Kirill Popov <kirill.s.popov@gmail.com>
2022-04-24 21:55:53 +07:00
8bbdd9ea0c
Cleanup AllConfig
...
- Port to QueryBuilder
- More typing when possible
- Import classes with 'use'
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-22 16:03:29 +07:00
05a33ad713
Fix acceptance
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 19:00:29 +07:00
3c75a99267
Phpunit
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 19:00:28 +07:00
efb432865f
Fix test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-20 13:08:31 +07:00
7817845538
Add a metadata service to store file metadata
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-13 14:06:29 +07:00
cd95fce105
Merge pull request #31932 from nextcloud/feat/ignore_second_dn
...
Add settings to ignore second display name in search
2022-04-13 09:52:38 +07:00
37f1c8640e
Add settings to ignore second display name in search
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-12 17:27:59 +07:00
d70d90702f
Merge pull request #31907 from nextcloud/enh/noid/tag-remote-as-globalscale
...
confirm user is internal to globalscale
2022-04-12 11:10:36 +07:00
10eafd70c8
confirm user is internal to globalscale
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2022-04-12 09:11:05 +07:00
c6a5c07041
Adds a "Request password" button to the public share authentication page for shares
...
of type TYPE_EMAIL, when the "video verification" checkbox isn't checked. Users accessing
non-anonymous public shares (TYPE_EMAIL shares) can now request a temporary password themselves.
- Creates a migration step for the files_sharing app to add the 'password_expiration_time'
attribute to the oc_shares table.
- Makes share temporary passwords' expiration time configurable via a system value.
- Adds a system config value to allow permanent share passwords
-Fixes a typo in a comment in apps/files_sharing/src/components/SharingEntryLink.vue
See https://github.com/nextcloud/server/issues/31005
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
2022-04-11 21:58:24 +07:00
151c800397
allow reusing known folder info when getting directory contents
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-06 14:40:34 +07:00
b8b4d247b4
Merge pull request #31194 from nextcloud/feat/allow-to-exclude-groups-from-password-enforcement
...
Allow to disable password policy enforcement for selected groups
2022-04-06 10:13:23 +07:00
a29251e02d
Allow to disable password policy enforcement for selected groups
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-05 17:04:17 +07:00
754603a04e
dont needlessly resolve path when getting internalPath/storage from Node
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-04 15:40:24 +07:00
135bdb3d58
Merge pull request #30823 from nextcloud/work/profiler
...
Built-in profiler
This adds the required API for collecting information about requests. This information
can then be displayed with the new 'profiler' app.
2022-04-04 12:56:37 +07:00
7d272c54d0
Add a built-in profiler inside Nextcloud
...
The webui is provided by a seperate application named profiler
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-04 10:28:26 +07:00
d3d53494d4
Merge pull request #31750 from nextcloud/fix/ci-should-fail-on-deprecation-warnings
...
Convert deprecation warnings to exception in phpunit
2022-04-01 14:11:41 +07:00
18c013d8fc
Add CSP policy merge priority for booleans
...
When two booleans conflict when merging CSP policies, true will win.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-01 13:56:34 +07:00
dd357d7f9b
Merge pull request #31679 from nextcloud/bugfix/noid/ensure-string-columns-to-be-maximum-of-4000
...
Ensure string column limit of 4.000 characters
2022-03-31 11:37:43 +07:00
cba4d85d9b
Convert deprecation warnings to exception in php unit
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-29 21:48:35 +07:00
Andrew Summers
Daniel Kesselberg
Vincent Petry
Joas Schilling
Lucas Azevedo
Joas Schilling
Git'Fellow
Côme Chilliet
Ferdinand Thiessen
Jérôme Herbinet
Robin Appelman
John Molakvoæ
Hamid Dehnavi
Daniel Calviño Sánchez
Julien Veyssier
Marcel Klehr
Benjamin Gaussorgues
jld3103
Christopher Ng
julia.kirschenheuter
Côme Chilliet
Simon L
Faraz Samapoor
Josh Richards
Arthur Schiwon
Christoph Wurst
John Molakvoæ
Varun Patil
Carl Schwan
Vitor Mattos
Julius Härtl
Ferdinand Thiessen
Glandos
Joshua Trees
Louis
Louis Chemineau
Artur Neumann
Thomas Citharel
Anna Larch
MichaIng
Maxence Lange
Vincent Petry
Bennet Becker
Bennet Becker
Stanimir Bozhilov
J0WI
Christoph Wurst
Varun Patil
Roeland Jago Douma
Andy Xheli
Stanimir Bozhilov
Simon Leiner
Julien Veyssier
Richard Steinmetz
Pytal
Cyrille Bollu
Kirill Popov