b926df4730
fix: Adapt notifications and activity tests to new DI dependency
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 15:28:09 +07:00
8ca6fcace7
fix(Storage): Document getOwner() can return false
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 10:10:50 +07:00
b9fb1db0f8
Merge pull request #48009 from nextcloud/fix/remove-references-to-deprected-storage-interface
...
fix: Remove OCP\Files\Storage interface deprecated since version 9
2024-09-16 20:50:38 +07:00
ede0c26b78
Merge pull request #46480 from nextcloud/fix/mailer-binaryfinder-fallback
...
fix(Mailer): Fix sendmail binary fallback
2024-09-16 18:18:14 +07:00
a165d8f978
chore: Fix encryption test use statement
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:38 +07:00
22822d5e9b
fix: Fix other uses of removed Storage interface
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:36 +07:00
801733e523
fix: Remove OCP\Files\Storage interface deprecated since version 9
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:10:48 +07:00
d9c5512878
Merge pull request #46140 from nextcloud/fix-nc-env-inclusion
...
fix(config): Add missing handling for `envCache` in `getKeys()`
2024-09-16 16:55:13 +07:00
87aa1267a8
fix(Mailer): Fix sendmail binary fallback
...
feat: add debug logging to sendmail binary finder
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-09-16 15:20:29 +07:00
13088b745a
Merge branch 'master' into fix-nc-env-inclusion
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-16 15:13:29 +07:00
9597072ada
perf(ObjectStoreStorage): Improve (slow) move on same object bucket
...
This commit fixes the issue #47856 . When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.
The behavior improves a lot with https://github.com/nextcloud/server/pull/46013 . However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
2024-09-16 15:11:09 +07:00
7fbd518452
feat: Make `CheckServerResponseTrait` public and provide as `OCP\SetupCheck\CheckServerResponseTrait`
...
This trait is used by other apps for creating setup checks,
so we should provide it instead apps using private API.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-16 14:58:21 +07:00
ff0cab5956
Merge pull request #47852 from nextcloud/sharding-code-fixes
2024-09-16 11:39:58 +07:00
8a32881633
Merge pull request #48008 from nextcloud/fix/entity/strict-types
2024-09-16 11:08:35 +07:00
d46f271b1f
Merge pull request #48049 from nextcloud/refactor/void-tests
...
refactor: Add void return type to PHPUnit test methods
2024-09-16 00:11:41 +07:00
6892500405
Merge pull request #48046 from nextcloud/refactor/self-class-reference
...
refactor: Replace __CLASS__ with ::class references
2024-09-15 23:01:22 +07:00
49dd79eabb
refactor: Add void return type to PHPUnit test methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 22:32:31 +07:00
1ee833efab
refactor: Replace __CLASS__ with ::class references
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 21:40:55 +07:00
6c36c54dc6
feat(db): switch from settype to casts
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-15 19:26:58 +07:00
247b1dd70e
fix(Entity): Fix magic setter call for custom strong typed setters
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:14:54 +07:00
81df2d2c12
feat(PsrLoggerAdapter): Allow to use `Psr\Log\LogLevel` for `log` method
...
There is the `Psr\Log\LogLevel` class defining loglevel constants,
to be fully compatible we should at least support those logging levels.
Moreover this is the last part that was still required from `ILogger` interface,
as we did not have alternatives for the loglevel constants.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-14 17:35:11 +07:00
bcb4e781a4
Merge pull request #47927 from nextcloud/fix/migrate-away-from-oc_app
...
Migrate away from OC_App to IAppManager
2024-09-13 17:44:38 +07:00
dfa994ef28
Merge pull request #47865 from nextcloud/admin_audit/enh/move-to-event-listeners-v2
...
Move admin_audit to proper event listeners v2
2024-09-13 16:21:44 +07:00
7a16d01ea7
chore(tests): Fix Router test by mocking AppManager methods correctly
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:26:36 +07:00
76f2bc0bfc
fix: Replace OC_App::getAllApps with a method in AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:44 +07:00
7ed583cb8e
chore: Migrate cleanAppId and getAppPath calls to IAppManager from OC_App
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:43 +07:00
dcd97e1234
fix(config): Throw PreconditionException always when it didn't match
...
Previously even when the precondition did not match, the call "passed"
when the after value was the expected one. This however can lead to
race conditions, duplicate code excutions and other things.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-13 09:20:08 +07:00
b6c286640f
Merge pull request #47685 from nextcloud/fix/move-apihelper-to-oc-namespace
...
fix: Move OC_API into \OC\ApiHelper in standard namespace
2024-09-12 14:34:07 +07:00
38e0a89972
fix: Add whiteboard to education and public sector bundle
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-12 09:13:42 +07:00
d0a827a684
fix(RichObjectStrings/Validator): Validate key value types of rich object parameters
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-10 16:36:33 +07:00
c2150bd079
feat: Add mimetype into BeforePreviewFetchedEvent event
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-09-10 14:05:06 +07:00
da59fd4389
fix: misc code fixes around db sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-09 16:59:59 +07:00
d5e98cd190
fix(NavigationManager): Skip invalid default navigation entries
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +07:00
70ed08daf1
refactor(AppManager): Deprecated default apps handling
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +07:00
b0baaaed9d
feat(NavigationManager): Add default entries handling
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +07:00
359bbce3af
chore: Adapt tests to OC_API refactoring
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +07:00
0308001118
fix(files): Check if the target path is a descendant of the shared folder path
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: fix tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: add tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: tests
2024-09-05 23:54:01 +07:00
8af7ecb257
chore: adjust code to adhere to coding standard
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:23:38 +07:00
09fef8f0ec
Merge pull request #47417 from nextcloud/fix/files/create-mountpoint-parents
2024-09-04 20:00:24 +07:00
78e09b5a0a
fix: share manager tests translation string
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-09-04 09:03:45 +07:00
4d2556d4cf
refactor(IMenuAction): Make public menu actions use the new Vue UI
...
This removes custom rendering code an replaces it with the declarative menu actions.
Also adjust the template to allow the Vue UI to mount.
Custom entries still are possible.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-03 16:07:49 +07:00
92f3f7e2d2
chore: Remove unused `CsrfTokenManager` from `CSPMiddleware`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-31 00:34:41 +07:00
41e3bde40c
fix(TaskProcessing): Fix namespace of TaskProcessingTest.php
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
03b3d03b46
fix(taskprocessing): fix tests
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
bfb5835750
Merge pull request #47546 from nextcloud/fix/files-view-error-messages
...
fix: Adjust filename validation messages
2024-08-29 23:28:50 +07:00
b71c539b5c
test(phpunit): skip sharding tests on 32bit
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-08-29 20:18:35 +07:00
80d7d867bd
fix(tests): Fix ImageTest test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
e8c671fa8b
fix: Remove all references to OC_Image
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
030c209d22
fix: Renaming does not need update but delete permissions
...
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +07:00
2574cbfa61
chore: Apply php:cs recommendations
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-28 10:44:18 +07:00
b21a399d1a
fix: implement sharding compatible cleanup for various bits
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:27:14 +07:00
382d102d22
test: fix share provider tests for sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +07:00
ddbeb4cac9
test: mark share test cleanup as running across all shards
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +07:00
62f8b6517f
feat: implement distributing partitioned queries over multiple shards
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +07:00
f5b3486744
feat: add option to automatically partition queries by specific tables
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:18:53 +07:00
c58bdbf378
fix: delay calculating global cache prefix untill a cache is created
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:18:52 +07:00
81c6c24cd5
fix: Adjust filename validation messages
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-27 23:12:24 +07:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
8b60df1600
perf: delay getting (sub)admin status for user in the security middleware untill we need it
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-23 15:26:40 +07:00
127cacdd19
feat(Security): Allow setting password context for validation and generation
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-22 19:16:50 +07:00
ebfbe99652
fix(files): Create non-existent parents of mountpoints
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-08-22 12:04:31 +07:00
c3ad469750
Merge pull request #47259 from nextcloud/memcache-ncad
...
feat: add negative compare-and-delete to imemcache
2024-08-21 17:19:04 +07:00
e1caa198e3
ci: Skip flaky test on PHP 8.3
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-21 13:13:12 +07:00
b9cc7bcec7
fix: `FilenameValidator::isForbidden` should only check forbidden files
...
And not forbidden basenames as this is used for different purposes.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-21 04:16:14 +07:00
20dbb6c7e8
feat: add negative compare-and-delete to imemcache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-20 19:34:28 +07:00
2ec68b1eb9
refactor(Log): Use new in initializer instead of constructor body
...
PHP 8.1 allows us to now move the `new` into the initializer,
this makes the code a bit nicer (and 3 lines shorter).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-17 18:38:28 +07:00
d35c4eb911
Merge branch 'master' into jr-readdir-false-false
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-08-16 10:53:50 +07:00
3e409fd342
Merge pull request #43573 from nextcloud/HolgerHees-fix-csp-nonce-handling
...
Fix for ignored `CSP_NONCE` in ContentSecurity Header
2024-08-13 17:53:30 +07:00
5100e3152d
feat(auth): Clean-up unused auth tokens and wipe tokens
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-08-13 12:39:11 +07:00
2916e5df7e
feat: Provide CSP nonce as `<meta>` element
...
This way we use the CSP nonce for dynamically loaded scripts.
Important to notice: The CSP nonce must NOT be injected in `content` as
this can lead to value exfiltration using e.g. side-channel attacts (CSS selectors).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 10:32:44 +07:00
009761be58
test: Adjust tests for CSP nonce
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 10:06:32 +07:00
1cfc25d08c
fix(tests): Adapt tests to change of DefaultShareProvider constructor
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-12 15:20:21 +07:00
0563757ea4
fix(SetupCheck): Properly check public access to data directory
...
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.
For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.
¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 22:08:42 +07:00
2b38d6ae7e
fix(session): Log when session_* calls are slow
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-08-07 09:02:10 +07:00
db28aa8cd1
fix(files_sharing): show proper share not found error message
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-06 16:25:10 +07:00
c221090c86
fix: unify bundle naming
...
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-08-06 11:14:07 +07:00
9af6184af6
chore: delete repair step for 8y old oc_mounts issue
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-02 17:21:54 +07:00
a6d421e767
chore: Remove deprecated legacy search backend
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-01 12:33:18 +07:00
18c0bcb2da
Merge pull request #46476 from nextcloud/enh/noid/migration-attributes
...
Migration Attributes
2024-07-30 15:54:56 +07:00
710a69b4b5
feat(log): Allow to combine log.conditions to only log (app&user)
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-30 13:18:09 +07:00
21f558b12b
Merge pull request #46379 from nextcloud/fix/folder-search-owner
...
fix: `OCP\Files\Node\Folder::search` was not setting the owner
2024-07-30 13:04:15 +07:00
ad490c963b
feat(migration-attributes): tests
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-07-29 12:44:52 +07:00
9d1705259c
fix(AppFramework): Allow requests with OCS-APIRequest header to pass CSRF checks
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-25 17:31:49 +07:00
799ee8fd51
feat(TaskProcessing): Implement enums and default values
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-25 10:10:31 +07:00
57ed738af2
Merge pull request #46644 from nextcloud/cast-bigint
...
fix: cast to bigint on postgresql
2024-07-24 20:39:04 +07:00
7266a9ef33
Merge pull request #46418 from nextcloud/artonge/feat/user_admin_delegation
...
feat(users): Add users and group management to admin delegation
2024-07-24 11:15:54 +07:00
fc0b694d37
feat: mail provider backend
...
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-23 16:20:36 +07:00
16c184e2cb
fix: cast to bigint on postgresql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-23 14:41:13 +07:00
dff8815449
feat(users): Add support for admin delegation for users and groups management
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-22 17:17:35 +07:00
fffc784769
feat(taskprocessing): add support for webhooks (http or AppAPI) in the task processing API
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-07-22 11:34:29 +07:00
9ed2d3e495
Merge pull request #46571 from nextcloud/chore/migrate-to-filenamevalidator
...
refactor: Migrate some legacy and core functions to `IFilenameValidator`
2024-07-22 10:40:50 +07:00
c2a571e435
Merge pull request #46473 from nextcloud/feat/restrict_admin_to_ips
...
feat(security): restrict admin actions to IP ranges
2024-07-22 10:10:42 +07:00
9716b0d735
refactor: Migrate some legacy and core functions to `IFilenameValidator`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-19 19:41:46 +07:00
7395211c1a
Merge pull request #46605 from nextcloud/bugfix/noid/test-more-oracle-versions
...
fix(deps): Deprecate functionality deprecated by doctrine and test on more oracle versions
2024-07-19 16:40:49 +07:00
047479ccf9
feat(security): Add public API to allow validating IP Ranges and checking for "in range"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +07:00
202e5b1e95
feat(security): restrict admin actions to IP ranges
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +07:00
a3c3eab09c
Merge pull request #46368 from nextcloud/fix/task-processing
...
TaskProcessing follow-up
2024-07-19 12:38:30 +07:00
f6238d35bd
fix(test): Make the test less flaky
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:16 +07:00
eeb6ddb176
fix(db): Deprecate `IExpressionBuilder::or()` and `IExpressionBuilder::and()` without parameters
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:16 +07:00
829f2b9bc7
fix(db): Promote the use of `getDatabaseProvider` to reduce the impage of removed upstream platforms
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:14 +07:00
Côme Chilliet
provokateurin
Côme Chilliet
Robin Appelman
Josh
Christoph Fiehe
Ferdinand Thiessen
John Molakvoæ
Kate
Anna
Christoph Wurst
Joas Schilling
Julius Knorr
Thomas Citharel
Git'Fellow
Marcel Klehr
Julien Veyssier
Andy Scherzinger
Arthur Schiwon
Louis Chemineau
Daniel Kesselberg
skjnldsv
Jérôme Herbinet
Stephan Orbaugh
Maxence Lange
SebastianKrupinski
Joas Schilling
Benjamin Gaussorgues