1a6709cf43
Migrate metadata as JSON to value as STRING
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-03 14:06:28 +07:00
4393b96542
Remove unused method getLocalFolder
...
It’s not used and not in any OCP interface/class.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:34 +07:00
966a3e6963
Tidy up typing in OC\Files\View
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:33 +07:00
454281af03
feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-03 09:06:45 +07:00
997c2a2a79
fix DBAL exception handling in setValues
...
This seems to be a left over after abstracting DBAL. Nowadays,
IQueryBuilder::executeStatement() only throws a \OCP\DB\Exception, where
previously original DBAL exceptions where thrown. These are now wrapped,
the orignal classes are now mapped to a reason.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-31 17:01:17 +07:00
4f8e916585
Add label for logo link
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-03-29 13:36:45 +07:00
8b4d49cf50
Merge pull request #36057 from nextcloud/feat/esm-js-scripts
2023-03-22 09:17:28 +07:00
633ea018af
Fix BackgroundCleanupJobTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:21:44 +07:00
bfc37afed3
Merge pull request #36928 from nextcloud/techdebt/noid/bruteforce-protection-attribute
...
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
2023-03-16 19:33:13 +07:00
a30d7c51d3
Merge pull request #37227 from nextcloud/h1-dav-brute-force-protection
...
chore: use local variable for remote address
2023-03-15 15:11:53 +07:00
37cfccabc1
unit tests for Manager::invalidateTokensOfUser
...
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2023-03-14 17:13:30 +07:00
71328107da
Merge pull request #37029 from nextcloud/fix/chunk-objectids-in-systemtagobjectmapper
...
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
2023-03-13 22:10:47 +07:00
9b1d7794a8
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
...
This avoids crashing on Oracle with more than 1000 objects
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-13 17:36:10 +07:00
f1751c4428
Introduced app enable/disable/update typed events
...
OCP\App\ManagerEvent is depreciated since 22 without a replacement
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-03-13 11:52:57 +07:00
39c1b6f49f
chore(tests): add tests for handleLoginFailed
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-03-10 18:04:39 +07:00
2b49861679
Add a debug message when throttling without defining
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-08 12:09:22 +07:00
e839eb9b5c
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-08 12:09:22 +07:00
c297f8ee96
feat(appframework): ⌚ Make ITimeFactory extend \PSR\Clock\ClockInterface
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-03 15:37:13 +07:00
de64c96a67
Merge pull request #36941 from nextcloud/bugfix/prevent-error-with-oracle-database
...
Split the comments ids by chunks
2023-03-03 12:37:15 +07:00
289fadfd50
Merge pull request #36803 from nextcloud/fix/sqlite-comments
...
[db]: Remove not supported column comments for SQLite
2023-03-02 12:10:19 +07:00
e9295f739e
Split the comments ids by chunks
...
Split the comments ids by chunks to prevent error with Oracle database
that can't do a query with more than 1000 parameters.
https://github.com/nextcloud/spreed/issues/8287
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-03-01 13:08:17 +07:00
1785a80754
tests(db): Add test case to ensure column comments work
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-28 10:39:13 +07:00
4f7d77406d
Fix SystemTagManagerTest#createTag test
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 14:40:33 +07:00
889caf4632
Update tests/lib/SystemTag/SystemTagManagerTest.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 14:22:41 +07:00
8151b1b8b0
fix(SystemTagManager): Truncate overlong tag names
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 12:55:10 +07:00
b642137c65
feat(OC/Template): Add `type="module"` for ES6 scripts
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +07:00
00e041b907
feat(template): Allow `JSResourceLocator` to find ES6 scripts
...
Enable module js (ES6) support on the `JSResourceLocator`.
This changes `JSResourceLocator` to look for `.mjs` files first
to allow applications to provide a fallback `.js` for older Nextcloud versions.
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +07:00
98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call"
2023-02-21 07:36:43 +07:00
614981ae9a
feat(directediting): Allow opening by file id
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-20 12:16:34 +07:00
5d4efb4d5f
Do not set up filesystem on every call
...
Also remove old Oc_FileChunking logis that produced GC- collectable chunks
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-02-17 19:18:37 +07:00
47bc024885
Revert the token scope to not end up with storing the user used in the session
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 10:18:18 +07:00
90d2cb09b1
Merge pull request #36396 from nextcloud/fix/cors
2023-02-17 09:42:08 +07:00
f655f83c84
fix(CORS): CORS should only be bypassed on `PublicPage` if not logged in to prevent CSRF attack vectors
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-16 22:55:18 +07:00
98b998a2de
Merge pull request #36735 from nextcloud/fix/32635/fix-vcf-contacts
...
fix the contacts-menu vcf-contact avatars
2023-02-16 14:01:19 +07:00
b38d2daede
fix the contacts-menu vcf-contact avatars
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-15 23:16:43 +07:00
5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow"
...
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240
Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-15 20:16:51 +07:00
a705132c8d
Merge pull request #36656 from nextcloud/route-instrumentation
2023-02-14 10:12:19 +07:00
b911da3e1e
DI for Router
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-13 22:51:14 +07:00
936f634069
Merge pull request #36643 from nextcloud/fs-setup-instrimuntion
...
more filesystem setup performance instrumentation
2023-02-13 14:37:57 +07:00
91d5f6a826
more filesystem setup performance instrumentation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-10 11:11:13 +07:00
a81d8ecef5
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-09 16:15:47 +07:00
08802ad13f
Merge pull request #36566 from nextcloud/mount-find-by-numeric-id
2023-02-08 20:04:57 +07:00
dcfc96f0cc
Merge pull request #36417 from nextcloud/fix/psr-container
...
Make the container fully fulfill PSR container interface
2023-02-07 20:38:19 +07:00
9f3dbb699a
fix tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-07 15:50:10 +07:00
892e6c642a
Skip buggy tests for 32bits CI
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:33 +07:00
77c8c9c805
Improve error output on failed Router test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:31 +07:00
94ecae4ade
Add helper to cast to int|float, fix MemoryInfo on 32bits
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
0f8c34cdc6
Fix filesize return type error in ViewTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
5cfab229db
Improve test failure output for RouterTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
2d8e696c24
Add apcu and ffmpeg to have less skipped tests
...
Also exclude test groups which rely on a service
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:28 +07:00
ba8a50c059
fix: Throw `NotFoundExceptionInterface` to fulfill PSR container interface if class not found
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-06 14:16:35 +07:00
47880b143d
Remove failing test that works with mocks only anyway
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-02 18:06:31 +07:00
dde5c46a3e
Migrate to Symfony Mailer
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-02 10:30:06 +07:00
c246edece6
tests(oci): Test where statement on longtext column
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
test: try with just passing the type to eq which should also cast
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-01-31 11:57:54 +07:00
2f3007205d
Merge pull request #35160 from nextcloud/artonge/feat/version_naming_backend
...
Allow to name a version
2023-01-30 10:40:49 +07:00
959e2aaa17
fix(tests): Fix method name in unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-30 09:12:50 +07:00
20e00cdf17
feat(app-framework): Add UseSession attribute to replace annotation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-27 09:40:35 +07:00
8d9af3e262
feat(app-framework): Add support for global middlewares
...
This allows apps to register middlewares that always register, not just
for the app's own requests
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-26 11:54:28 +07:00
d8b479752d
Fix hookconnector tests
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
907ff68bfc
perf(app-framework): Make the app middleware registration lazy
...
Before this patch, app middlewares were registered on the dispatcher for
every app loaded in a Nextcloud process. With the patch, only
middlewares belonging to the same app of a dispatcher instance are
loaded.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-25 09:27:24 +07:00
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
b22b6431d2
Fix gzip mimetype mapping
...
PHP now detects it as application/gzip and not application/x-gzip anymore
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:11 +07:00
7ebbb6b2ca
Remove workarounds specific to 7.4
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:08 +07:00
20fcfb5739
feat(app framework)!: Inject services into controller methods
...
Usually Nextcloud DI goes through constructor injection. This has the
implication that each instance of a class builds the full DI tree. That
is the injected services, their services, etc. Occasionally there is a
service that is only needed for one controller method. Then the DI tree
is build regardless if used or not.
If services are injected into the method, we only build the DI tree if
that method gets executed.
This is also how Laravel allows injection.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-18 14:00:38 +07:00
dbfe7b1816
Merge pull request #36073 from nextcloud/fix/fix-background-job-list
...
Use a Generator for job list to fix background-job:list command
2023-01-16 11:10:10 +07:00
d74044f634
Fix API breakage by using a new method instead
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-12 17:18:59 +07:00
75fca38e66
Fix BackgroundJob list tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-12 11:40:18 +07:00
7271ec7acf
spaces are allowed in userids
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-01-10 13:25:27 +07:00
42d9e087fb
Remove unused legacy ajax/list.php in files app
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-01-09 15:18:37 +07:00
18164ae516
Merge pull request #33898 from nextcloud/fix/authtoken-password-update
...
PublickKeyTokenProvider: Fix password update routine with password hash
2023-01-05 08:01:47 +07:00
97e33c2bd4
Fix unit tests of the ActionProviderStore
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-04 16:17:43 +07:00
8eca26012f
Show local time in avatar menu
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-04 11:09:58 +07:00
adfe367106
PublickKeyTokenProvider: Fix password update routine with password hash
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-01-04 08:30:53 +07:00
4dc0957164
refactor AutoSubmittedValue to Headers\AutoSubmitted and adding
...
header name to constants
Signed-off-by: Bennet Becker <dev@bennet.cc>
2023-01-03 15:15:35 +07:00
411467af57
fix static-analysis error and formatting code
...
Signed-off-by: Bennet Becker <dev@bennet.cc>
2022-12-23 21:48:52 +07:00
c1c6d215c7
fix getAutoSubmitted return type and adding unit tests
...
Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
2022-12-23 19:26:49 +07:00
bfb3b2af9f
increase preview_max_memory and make it easier to debug
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2022-12-22 09:52:46 +07:00
7dcd6eb561
Merge branch 'master' into add-scim-json-support
...
Signed-off-by: Stanimir Bozhilov <stanimir.bozhilov.1998@gmail.com>
2022-12-19 09:07:38 +07:00
ae6fe874ed
Merge pull request #35780 from nextcloud/fix/http-dispatcher-double-parameter-cast
...
Fix missing cast of double controller parameters
2022-12-16 16:18:35 +07:00
b6dd1a1d7b
fix(app framework): Fix missing cast of double controller parameters
...
``settype`` allows 'double' as alias of 'float'.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-15 09:33:52 +07:00
81f2857f34
check if params given to API are really an array
...
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-15 13:45:22 +07:00
2f7a1fca5f
Merge pull request #34477 from nextcloud/bugfix/noid/sharee-recommendations-show-group-id
...
Show group name instead of group id as recommendation
2022-12-09 22:39:28 +07:00
4bcaeb6c2c
Drop 3rdparty root since it is unused and adjust tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 23:55:32 +07:00
306d7829b5
Cache available languages locally
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 22:32:06 +07:00
87e638b1f8
Merge pull request #35649 from nextcloud/bugfix/object-storage-master-key-enc
...
Update the unencrypted file size when closing streams
2022-12-07 22:03:13 +07:00
3c8fb59fa4
Merge pull request #35620 from nextcloud/fix/fix-calendar-imip-tests
2022-12-07 20:39:41 +07:00
59ae6e9dd6
Also update the unencrypted size of files when creating them with empty content
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 19:12:06 +07:00
4a3f3beb0b
use bruteforce protection on all methods wrapped by PublicShareMiddleware
...
if an invalid token is provided or when share password is wrong
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2022-12-07 13:24:50 +07:00
7cf1dec842
Fix errors in calendar tests saying function handleIMipMessage does not exists on ICreateFromString
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-06 13:52:13 +07:00
1821712615
Merge pull request #35596 from nextcloud/fix/move-to-ocp-timedjob
...
Use TimedJob from OCP instead of OC
2022-12-06 12:14:43 +07:00
ee06261b82
Fix codestyle in modified files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-05 16:08:40 +07:00
30560d3165
Merge branch 'master' into tests/fix-phpunit-warnings
...
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2022-12-05 12:03:39 +07:00
578648a062
Adapt tests to new job constructors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-05 10:41:13 +07:00
a4d0700bf2
Fix test image default quality
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2022-12-04 14:51:33 +07:00
7c4ceb444c
Add group display name cache
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-11-28 11:52:55 +07:00
e35bcc9381
Fix tests
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 10:06:19 +07:00
d1f2e5e967
Increase the fair-use push limit to 1.000 users
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-18 15:39:23 +07:00
d27a39271e
getAppValue expects string
...
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2022-11-17 08:03:05 +07:00
0f3150cff7
Tests adjustement
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2022-11-16 11:01:32 +07:00
68363f6944
Fix some more problems with tests under PHP 8.2
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 16:02:24 +07:00
324126888e
Add Union types for properties in tests/lib/Encryption/Keys/StorageTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 09:29:35 +07:00
0f7e56b3b3
Fix syntax in VerificationTokenTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 09:25:56 +07:00
c79a6b3f62
Fix errors from PHP 8.2 testing
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 17:08:21 +07:00
70e2217d1c
Fix dynamic properties and other problems in tests for PHP 8.2
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 16:14:35 +07:00
9d0e79f10d
Fix PublicKeyTokenProviderTest import and mock
...
* IDBConnection import missing
* Atomic doesn't need a mock
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-10 15:40:35 +07:00
908b7aa70a
Attempt to fix CalendarImpl tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-09 16:37:34 +07:00
2a684f6741
Fix some phpunit test warnings
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-09 16:37:34 +07:00
f9e9cd270d
Limit-number-of-concurrent-preview-generations
...
Signed-off-by: Bowen Ding <dbw9580@live.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-11-05 16:03:01 +07:00
5c4a66f0c1
Merge pull request #34775 from nextcloud/bugfix/noid/mailer-set-to
...
Do not throw errors when invalid setTo email is provided
2022-11-04 18:24:55 +07:00
fd036f774f
Do not throw errors when invalid setTo email is provided
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-03 16:59:12 +07:00
2e83a21cd2
Merge pull request #34678 from pulsejet/patch-jpeg
...
Interlace all output JPEG
2022-11-03 16:11:03 +07:00
8a2e52e7f8
Merge pull request #34330 from nextcloud/fix/fix-contacts-test-php8
...
Fix ContactsStoreTests under PHP 8.2
2022-11-03 14:55:06 +07:00
ac92d00da8
Merge pull request #32565 from nextcloud/chore/modernize-error-handler
...
Modernize the error handler
2022-11-03 14:42:51 +07:00
052dcdebe8
Refactor the ErrorHandler into a dynamic class
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-02 09:49:37 +07:00
8aea25b5b9
Add remote host validation API
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-10-31 16:13:28 +07:00
d007088cf5
Merge pull request #34847 from nextcloud/refactor/local-address-checker-method-capitalization
...
Rename LocalAddressChecker methods to lower case
2022-10-27 15:57:58 +07:00
07e94eca6f
Emit typed event when preview is requested
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-27 14:31:33 +07:00
d4b9b010b0
Rename LocalAddressChecker methods to lower case
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-10-27 13:24:28 +07:00
0d9c1510ca
Fix ContactsStoreTests under PHP 8.2
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-10-26 20:03:49 +07:00
3357c8e783
test disabling write check
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-10-26 18:45:59 +07:00
298d2b9b58
Skip general login with email for non-valid addresses and LDAP
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-26 12:30:25 +07:00
48917e718e
Interlace all output JPEG
...
Progressive images are both smaller and faster to load.
Signed-off-by: Varun Patil <radialapps@gmail.com>
2022-10-25 09:40:20 +07:00
11108e8032
Revert "fix external storages access"
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-10-23 22:36:34 +07:00
304c1b9b61
Merge pull request #33087 from nextcloud/fix/30282/external-storages
...
fix external storages access
2022-10-23 10:42:46 +07:00
c671466422
Merge pull request #34379 from nextcloud/fix/transactional-session-token-renewal
...
Run session token renewals in a database transaction
2022-10-18 11:19:33 +07:00
d29332469a
Merge pull request #34609 from nextcloud/enh/noid/always-enable-theming
...
set theming app to alwaysEnabled
2022-10-18 10:13:56 +07:00
c5922e67d3
Run session token renewals in a database transaction
...
The session token renewal does
1) Read the old token
2) Write a new token
3) Delete the old token
If two processes succeed to read the old token there can be two new tokens because
the queries were not run in a transaction. This is particularly problematic on
clustered DBs where 1) would go to a read node and 2) and 3) go to a write node.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-10-18 08:28:22 +07:00
1d17a0843a
set theming app to alwaysEnabled
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-10-17 17:51:39 +07:00
9919116716
Merge pull request #31499 from nextcloud/bugfix/empty-secret
...
Add fallback routines for empty secret cases
2022-10-17 16:02:58 +07:00
d77e832223
Fix tests
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-10-14 16:18:40 +07:00
e674087ebf
Adjust unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-12 16:03:57 +07:00
60ee874485
Remove long depreated AppFramework/Db/Mapper
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2022-10-10 08:18:32 +07:00
7d024bc337
Merge pull request #32635 from andyxheli/patch-3
...
Fix User profile picture when performing the search
2022-10-05 10:36:43 +07:00
ae6a7c88a0
Update ContactsStoreTest.php
...
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
2022-10-03 09:17:27 +07:00
ca958de7e9
Merge pull request #33566 from nextcloud/fopen-not-found-rescan
...
trigger a rescan when trying to fopen a file that exists in cache but not on disk
2022-10-01 21:47:26 +07:00
a4c2aeef45
Merge pull request #34329 from nextcloud/fix/cleanup-long-time-deprecated-stuff
...
Remove some constants and functions which have been long deprecated
2022-10-01 17:55:31 +07:00
910c774b35
Merge pull request #34038 from nextcloud/fix/migrate-TagMapper-to-QBMapper
...
Migrate TagMapper to QBMapper instead of deprecated Mapper
2022-09-30 16:46:42 +07:00
4123eeeaa3
Fix ContactsManagerTest test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-30 13:20:04 +07:00
5347fb02dc
Remove some constants and functions which have been long deprecated
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-30 13:20:03 +07:00
92a5a8f075
Cleanup tags and Share component
...
- Port to LoggerInterface
- Use IDBConnection and IQueryBuilder instead of raw SQL and OC_DB
- Use IEventListener instead of hooks
- Remove the now unused OC_DB and OC_DB_StatementWrapper legacy utils
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-29 15:15:28 +07:00
1de0b10751
add test for trying to fopen a file which no longer exists on disk
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-29 10:27:32 +07:00
de23ff38ff
Move avatar clearing in the background
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-26 15:26:31 +07:00
46c10c77e1
Fix the JSON content type regex to match all MIME types
...
Signed-off-by: Stanimir Bozhilov <stanimir@audriga.com>
2022-09-26 11:51:44 +07:00
a133a8a9d7
remove getDefaultInstallationBundle
...
- because all apps are shipped now it was returning an empty result
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-22 15:11:39 +07:00
759eaee5ed
remove Core Bundle
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-22 13:20:37 +07:00
f7d51a39cf
Add unit tests for application/scim+json content type
...
Signed-off-by: Stanimir Bozhilov <stanimir@audriga.com>
2022-09-20 16:19:05 +07:00
31117fa7c7
Fix tests for nested v4 in v6
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-20 12:46:22 +07:00
c083f77e4e
Harden tests for local IP detection in URLs
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-20 12:14:33 +07:00
4efd0be525
Inform ServerTest that TagMapper now uses QBMapper
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-19 10:01:49 +07:00
d8961ed10f
fix using FSEEK_END with SeekableHttpStream to get file size
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-15 17:23:16 +07:00
da01494a37
Add accessibility entry in user menu
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-09-14 15:05:35 +07:00
bc9a488046
Update avatars on update
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-09 14:23:41 +07:00
eac54c4660
Merge pull request #33788 from nextcloud/improve-recent
...
Improve getting recent files performance
2022-09-08 16:19:41 +07:00
c77cc80fcc
Merge pull request #33906 from nextcloud/fix/fix-calendar-tests-getTimestamp
...
Fix Calendar tests mocking a non-existant method.
2022-09-08 12:42:03 +07:00
e3a52ce13e
Fix iMIP tests
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-09-08 02:26:46 +07:00
417f46e467
Merge pull request #33600 from nextcloud/lazy-quota
...
get quota for user only when needed
2022-09-07 18:10:33 +07:00
98c525a91a
Fix trying to use MockBuilder instead of Mock
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-06 09:05:36 +07:00
0b37d89893
Fix Calendar tests mocking a non-existant method.
...
There is no ITimeFactory::getTimestamp method, only getTime
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-09-05 18:09:49 +07:00
67551f379f
Filter out old files when trying to get recent files
...
Only do so when asking for less than 100 files and having an offset
equal to 0.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-05 12:53:32 +07:00
6132b6a4ae
Merge pull request #33790 from nextcloud/Valdnet-patch-2
...
l10n: Spelling unification
2022-09-02 17:01:52 +07:00
b31c92e6f5
fix tests
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-09-02 16:07:13 +07:00
bd91c56539
get quota for user only when needed
...
always apply the wrapper but have the wrapper get the quota lazily only when an operation where quota is applied is performed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-09-01 19:32:24 +07:00
3ae439710e
Merge pull request #33764 from nextcloud/cloudid-cache
...
cache cloud id data in CloudIdManager
2022-09-01 13:27:12 +07:00
67ecd72972
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-31 20:54:39 +07:00
1626a56dda
adjusts tests for CloudIdManager
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-31 15:47:00 +07:00
0c90474296
add a better icon for personal settings
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-08-31 15:37:48 +07:00
17ee17cdbf
fix tests
...
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-08-31 14:35:13 +07:00
f56ecf9242
Merge pull request #33640 from nextcloud/fix/fix-symfony-event-typing
...
Port Repair and Migrator events to IEventDispatcher
2022-08-30 14:47:05 +07:00
6f80fe6ada
Remove deprecated at matcher from tests/lib
...
Only 15 warnings left in there
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-29 16:36:40 +07:00
791e021455
Remove deprecated at matcher in Updater/VersionCheckTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-29 15:11:18 +07:00
e5731b3c30
Fix BackgroundRepairTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:15:48 +07:00
5d313da709
Fix RepairTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:15:48 +07:00
a83a8f0dde
Migrate Migrator::executeSql to OCP\EventDispatcher\Event
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:13:47 +07:00
9b5569ff74
Merge pull request #33668 from nextcloud/tests/fix-session-middleware
...
Fix SessionMiddlewareTest and cover new case with reopening
2022-08-25 11:00:35 +07:00
83b1415906
Only pass parent if paths match
...
As the user folder might be initialized by the root from two levels
down the hierarchy, passing this as a parent only works if the path matches
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-24 22:20:32 +07:00
b2d6435737
Avoid extra query for the parent node if we can pass it along
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-24 22:20:32 +07:00
bd7ab89d2a
Merge pull request #33593 from nextcloud/improve-binary-caching
...
Move findBinaryFinder and isFunctionEnabled away from OC_Helper
2022-08-24 13:09:55 +07:00
64a7489958
Fix SessionMiddlewareTest and cover new case with reopening
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-24 10:36:57 +07:00
9b8ca9ad1f
Move findBinaryFinder and isFunctionEnabled away from OC_Helper
...
findBinaryFinder is now a service that is still private but with some
minor optimization (remove the hasKey check).
isFunctionEnabled is now in OCP\Util
Both function are still keep but all internal usage in nextcloud/server
were migrated to the new usage, so that we can remove it in 26
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-23 19:44:04 +07:00
b888c61463
Merge pull request #33047 from nextcloud/fix/ijob-logger-deprecated
...
Deprecated ILogger from IJob
2022-08-23 16:55:42 +07:00
4ca4b02793
Support iMIP invitations from Mail
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-08-22 22:10:12 +07:00
a2d145734a
Merge pull request #33565 from nextcloud/debt/remove_todo_push_service_fairuse
...
Remove time check in isFairUseOfFreePushService
2022-08-17 14:14:03 +07:00
312b719acf
Merge pull request #32943 from nextcloud/unencrypted-size-revert-interface-changes
...
Revert interface changes from "store unencrypted size in the unencrypted_size column"
2022-08-17 11:36:16 +07:00
227c766f16
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-17 11:25:18 +07:00
2360d880fa
Merge pull request #33540 from nextcloud/mount-provider-migration
...
fix updating cached mounts that didn't have their mount provider set previously
2022-08-17 10:41:31 +07:00
082432e01c
Merge pull request #33551 from nextcloud/scanner-dont-update-same-size
...
don't update the folder size if we know it hasn't changed
2022-08-17 09:21:30 +07:00
1850d0ae96
cleanup scannertest a bit
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-16 13:56:51 +07:00
1374cbee3e
store unencrypted size in the unencrypted_size column
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-16 13:54:26 +07:00
887952b4f4
add tests for cached mount provider migration
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-16 13:47:43 +07:00
5e375d9092
Revert "store unencrypted size in the unencrypted_size column"
...
This reverts commit 8238582e59
2022-08-16 12:07:14 +07:00
6e0123a1d0
Revert "add case statement to sql function builder"
...
This reverts commit 2a68819a67
2022-08-16 12:07:13 +07:00
51b9847fad
Merge branch 'master' into display-name-cache-public
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-15 15:28:30 +07:00
f8b13ecd60
Merge pull request #32363 from nextcloud/cleanup/remove-long-deprecated-classes
...
Remove OCP\App and OCP\BackgroundJob
2022-08-08 17:05:11 +07:00
49334e4d9c
Fix many tests and warnings
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-08 17:03:51 +07:00
48d9c4d2b0
Port existing server code to new interface
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-08 17:03:19 +07:00
cbd5cef2cc
Merge pull request #33398 from nextcloud/enh/noid/sensitive-methods-apps
...
allow apps to specify methods carrying sensitive parameters
2022-08-05 14:09:55 +07:00
09362eaeaa
Support specifying IPv6 proxies in CIDR notation
...
Previously, it was not possible to use CIDR notation for IPv6 proxies
in the trusted_proxies parameter of config.php [1]. This patch adds
support for that.
[1]: https://docs.nextcloud.com/server/24/admin_manual/configuration_server/reverse_proxy_configuration.html#defining-trusted-proxies
Signed-off-by: Simon Leiner <simon@leiner.me>
2022-08-02 17:36:47 +07:00
9475cc02b2
Merge pull request #32958 from nextcloud/fix/noid/permission-update-allow-public-uploads
2022-08-02 16:49:27 +07:00
acc68e9f93
fix share manager tests
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-08-02 01:35:10 +07:00
cb271b759e
Fix dynamic property creations in test files
...
This fixes warnings in PHP 8.2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-01 15:07:53 +07:00
458c2fa297
Remove OCP\App and OCP\BackgroundJob
...
Both deprecated since NC 23
IAppManager is the replacement for OCP\App unfortunately it can't be
dependency injected in classes used by the installed otherwise the
database connection is initialised too early
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-01 09:46:40 +07:00
f74e89bde5
Merge pull request #32482 from nextcloud/enh/noid/share-attributes
...
Add share attributes + prevent download permission
2022-08-01 09:44:31 +07:00
952acd4d27
Merge pull request #33225 from nextcloud/fix/handle-one-time-passwords
...
Handle one time password better
2022-07-29 12:26:52 +07:00
6941c91531
add unit test for ExceptionSerializer
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-07-29 12:07:41 +07:00
03b1791cca
Fix share attribute related tests + code style
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
a95c19e14b
Add share attributes + prevent download permission
...
Makes it possible to store download permission
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
702445ba3b
Handle one time password better
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-28 14:26:25 +07:00
7615536977
Merge pull request #33031 from nextcloud/fix/improve-local-ip-detection
...
Improve local IP detection
2022-07-26 11:39:32 +07:00
bbe15b4b43
Merge pull request #33129 from nextcloud/fix-reading-blob-as-resources
...
Fix reading blob data as resource
2022-07-25 17:56:03 +07:00
7a0648757a
Delete comments that expired now
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-07-25 11:30:20 +07:00
1d30fb7852
Fix reading blob data as resource
...
PostgreSQL returns data as resource when using IQueryBuilder::PARAM_LOB
(which is used for QBMapper).
Previously we just converted this resource using settype, which produced
things like "Resource id #14" instead of the actual resource data.
Now we read the stream correctly if the returned data is a resource
See context at #22472
Fixes #22439
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-07-25 09:45:47 +07:00
6c3c7a5e4d
Merge pull request #32981 from nextcloud/typing/carl/simplefs
...
Add typing to SimpleFS
2022-07-18 12:34:11 +07:00
19a36b58a6
Add typing to SimpleFS
...
- Fix putContent sometimes return a bool and sometimes nothing
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-14 17:20:51 +07:00
d5c23dbb9f
Move CappedMemoryCache to OCP
...
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-14 15:54:31 +07:00
c20d34b2ca
Merge pull request #32552 from nextcloud/enh/improve-job-handling-commands
...
Improve job handling through occ
2022-07-12 16:04:57 +07:00
0386f4270b
Fix DummyJobList typing
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-12 14:27:02 +07:00
c5ffd7ce32
Use Symfony IpUtils to check for local IP ranges
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-12 12:09:05 +07:00
16b5e6bc7f
Merge pull request #32973 from nextcloud/cleanup/avatar-code
...
Cleanup avatar related code
2022-07-11 11:56:39 +07:00
50a7f612d9
Fix DummyJobList class used by tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-07-11 09:46:23 +07:00
74ebb72622
Merge pull request #33110 from nextcloud/feat/handle-onetime-password-large
...
Handle one time password and very large passwords
2022-07-08 19:54:05 +07:00
ec5cbdeb7f
Make Color class public
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-05 14:44:44 +07:00
1c23c029af
Handler large passwords
...
For passwords bigger than 250 characters, use a bigger key since the
performance impact is minor (around one second to encrypt the password).
For passwords bigger than 470 characters, give up earlier and throw
exeception recommanding admin to either enable the previously enabled
configuration or use smaller passwords.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-05 11:37:14 +07:00
cdf3b60555
Handle one time passwords
...
This adds an option to disable storing passwords in the database. This
might be desirable when using single use token as passwords or very
large passwords.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-05 11:25:44 +07:00
2ad53742f2
fix external storages access
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-07-01 22:52:10 +07:00
d722a0c12a
Adjust fake manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-01 16:38:58 +07:00
198224bf7a
Allow to expire comments of multiple objects with one call
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-01 15:59:29 +07:00
64bff27c99
Merge pull request #32960 from nextcloud/fix/avoid-using-undeclared-properties
...
Fix PHP 8.2 warnings about undeclared properties
2022-06-28 12:05:16 +07:00
0fe7064fc4
Merge pull request #32998 from nextcloud/fix/setting_name
...
Rename setting name to reduce its length
2022-06-27 11:58:54 +07:00
347ca20f4e
Rename setting name to reduce its length
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-27 11:04:17 +07:00
4722baf970
Merge pull request #32863 from nextcloud/feature/add-comments-expire-date
...
Add comments expire date
2022-06-24 10:28:13 +07:00
812016d626
Cleanup avatar related code
...
- Move event listener to new event handling
- Add typing almost everywhere
- Fix inconsistent interface parameter
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-22 16:11:42 +07:00
cf5452e633
Merge pull request #32242 from nextcloud/fix-logging-data-array
...
Fix logging data context to file
2022-06-21 18:49:08 +07:00
1bd5222224
Fix PHP 8.2 warnings about undeclared properties
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-21 16:17:52 +07:00
53eafc0cb7
Merge pull request #32868 from nextcloud/fix/replace-opis-closure-by-laravel-fork
...
Replace opis/closure by laravel/serializable-closure
2022-06-21 12:21:32 +07:00
fd8f2aff09
Merge pull request #32901 from nextcloud/fix/remove-at-matcher-in-lib-tests
...
Remove at matcher uses in tests/lib
2022-06-21 11:45:00 +07:00
95f0cb2a2a
Add a test about unserializing data from opis/closure serialization
...
We need to be able to unserialize data from before upgrade.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-20 17:34:29 +07:00
3be1217c04
Follow the most common pattern used in project
...
```
git grep strval|wc -l
32
git grep "(string)"|wc -l
481
```
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-06-20 11:46:13 +07:00
6a1510f8ee
Remove some more at matchers in tests/lib
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-20 10:53:06 +07:00
c1f054a9e0
Fix email shares not being shown to other users
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2022-06-17 17:31:26 +07:00
8b2b5946e6
make placeholder a const for reuse
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:38:29 +07:00
891c10d09d
fix overwriting original vars when logging
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:36:58 +07:00
09a5947a6d
add serializer test
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-06-16 18:36:58 +07:00
c7e1c36362
Remove at matcher uses in tests/lib
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-16 17:43:17 +07:00
c59b0c2ff7
Add comments expire date
...
https://github.com/nextcloud/spreed/pull/7327
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-06-15 11:58:29 +07:00
8809de1eef
Merge pull request #31966 from nextcloud/unencrypted-size
...
store unencrypted size in the unencrypted_size column
2022-06-13 11:55:37 +07:00
6e3d668436
Keep non default protocol in cloud id
...
When there is no protocol on the cloud id, we assume it's https://
But this means that when an http:// server currently sends an OCM
invite to another server, the protocol is striped and the remote
instance will try to talk back to https:// which might not be available.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-09 15:23:05 +07:00
e76d8bb901
Merge pull request #32697 from nextcloud/fix/get-avatar-authz
2022-06-08 16:27:31 +07:00
7c50dd888e
Test all scopes
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-07 23:57:21 +07:00
7455cd9dd7
Fix get avatar authorization
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-07 23:57:21 +07:00
50ed84fe17
Simlify tests for integrity check on modified mimetype lists
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-06-07 21:54:27 +07:00
8238582e59
store unencrypted size in the unencrypted_size column
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-02 16:07:00 +07:00
2a68819a67
add case statement to sql function builder
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-06-02 15:52:12 +07:00
b212e8dcc9
Add unit tests for encryption's isSystemWideMountPoint
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-06-01 18:10:59 +07:00
699f259c45
Merge pull request #32667 from nextcloud/followup/32655/fix-tests
...
Fix unit tests
2022-05-31 11:30:51 +07:00
279e06a80f
Merge pull request #32587 from nextcloud/bugfix/noid/improve-jsconfighelper
...
Improve JSConfigHelper code quality a bit
2022-05-31 10:29:30 +07:00
c2af3667dc
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-31 10:23:52 +07:00
3901a93c72
Use JSON_THROW_ON_ERROR instead of custom error handling
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-05-30 19:17:49 +07:00
1164c762eb
Merge pull request #31948 from nextcloud/core-cleanup-74
...
Update core to PHP 7.4 standard
2022-05-30 14:37:37 +07:00
f9efc410fa
Restore old behaviour of sending flase for not found apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-30 12:41:35 +07:00
8d599c3410
Merge pull request #32378 from nextcloud/fix/psalm-userbackend
...
Fix psalm issues related to the user backend
2022-05-23 11:41:21 +07:00
b70c6a128f
Update core to PHP 7.4 standard
...
- Typed properties
- Port to LoggerInterface
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 22:18:06 +07:00
9ec0cb0a90
Fix psalm issues related to the user backend
...
- Reflect the actual return value returned by the implementation in the
the interface. E.g. IUser|bool -> IUser|false
- Remove $hasLoggedIn parameter from private countUser implementation.
Replace the two call with the equivalent countSeenUser
- getBackend is nuallable, add this to the interface
- Use backend interface to make psalm happy about call to undefined
methods. Also helps with getting rid at some point of the old
implementActions
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 17:14:58 +07:00
18dd460720
Merge pull request #26813 from nextcloud/feature/files-search-tags
...
Files: Extend search to also cover tags
2022-05-18 10:58:02 +07:00
6d6662ec68
expose displayname cache trough a public interface
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-05-18 03:47:34 +07:00
f755ee0868
Files: Extend search to also cover tags
...
fixes #326
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2022-05-17 21:05:09 +07:00
4d26a9afa0
Allow to tweak default scopes for accounts
...
Close #6582
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-16 22:54:51 +07:00
fd576b568c
Merge pull request #32305 from nextcloud/bugfix/32302/fix-browser-agent-trimming
...
Fix user agent trimming on installation
2022-05-16 11:20:46 +07:00
85758a4f70
Merge pull request #31662 from nextcloud/modernize-contactmenu
2022-05-13 20:14:31 +07:00
9a9409e315
Remove SCSSCacher
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-13 16:10:45 +07:00
9fcf531154
Merge pull request #30863 from nextcloud/performance/saving-user-profile-info
...
Minor optimizations for saving user personal information
2022-05-13 12:56:39 +07:00
fe33e9c08c
Merge pull request #32250 from nextcloud/cleanup/cappedmemorycache
2022-05-13 08:27:28 +07:00
eef973e85b
Minor optimizations for saving user personal information
...
* Remove double hook: the OC_User::changeUser triggers an
OC\AccountManager::userUpdated and the app is already listening to this
signal in its Application definition
* Make createCard not check if an card exists if we already checked
previously. We also don't try to get the card if the user is disabled
as we don't use the card in this case
We this change we go from 100 DB requests to 80 DB requests when saving
an user email address.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
(cherry picked from commit c6fd482edf33214a9ad4787e4cac278f871fa7c8)
2022-05-12 21:02:52 +07:00
23771f0587
Merge pull request #32077 from nextcloud/cleanup/lock
...
Cleanup lock related code
2022-05-12 20:57:38 +07:00
232322fe06
Modernize contacts menu
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-12 18:31:59 +07:00
fcae6a68c3
Cleanup lock related code
...
- Port to QueryBuilder
- Improve the doc a bit
- Add type hinting
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-12 15:09:58 +07:00
ec6b83cc18
Add stricter psalm type for CappedMemoryCache
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-12 15:06:18 +07:00
01dbd22c9c
Validate requested length is random string generator
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-05-12 13:58:18 +07:00
3c6253f965
Remove old legacy SvgController and IconsCacher
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-10 23:24:07 +07:00
7b3e2217de
Fix user agent trimming on installation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-05-09 08:36:34 +07:00
7718c9776c
Merge pull request #32113 from nextcloud/bugfix/noid/fix-csp-merging-bools
...
Add CSP policy merge priority for booleans
2022-05-05 17:26:48 +07:00
290697b08f
Merge pull request #32220 from nextcloud/feature/add-tests-to-validate-emojis
...
Include more emoji chars to test and fixes after include it
2022-05-03 16:08:19 +07:00
1e7d924c61
Fix logging data context to file
...
It was only logged when an exception was provided or when using
logData (which is not being much used).
We make sure the interpolated parameters are not logged.
Only tested with file write logger, but shouldn't work differently.
Crash reporters always had the context.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-05-02 19:29:35 +07:00
459202d54c
Merge pull request #31752 from nextcloud/fix/remove-still-more-ilogger
...
Move away from deprecated ILogger
2022-05-02 10:15:10 +07:00
cefcd55994
Include more emoji chars to test and fixes after include it
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-04-29 14:00:57 +07:00
8184e356f4
Remove test for removed class SearchResultSorter
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-28 14:56:26 +07:00
902476fa20
Extract the EmojiService from user status and add an OCP interface
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-28 07:09:44 +07:00
a4cd9fd37c
Add a unit test for translation with trailing colon
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-26 11:05:19 +07:00
59e0402691
Merge pull request #32069 from nextcloud/cleanup/allconfig-sql
...
Cleanup AllConfig
2022-04-25 18:56:15 +07:00
0b27b9e658
Get not only time-sensitive next job from list but any
...
Before the change webcron used to select
**only** time-sensitive tasks.
Signed-off-by: Kirill Popov <kirill.s.popov@gmail.com>
2022-04-24 21:55:53 +07:00
8bbdd9ea0c
Cleanup AllConfig
...
- Port to QueryBuilder
- More typing when possible
- Import classes with 'use'
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-22 16:03:29 +07:00
efb432865f
Fix test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-20 13:08:31 +07:00
7817845538
Add a metadata service to store file metadata
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-13 14:06:29 +07:00
cd95fce105
Merge pull request #31932 from nextcloud/feat/ignore_second_dn
...
Add settings to ignore second display name in search
2022-04-13 09:52:38 +07:00
37f1c8640e
Add settings to ignore second display name in search
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-12 17:27:59 +07:00
d70d90702f
Merge pull request #31907 from nextcloud/enh/noid/tag-remote-as-globalscale
...
confirm user is internal to globalscale
2022-04-12 11:10:36 +07:00
10eafd70c8
confirm user is internal to globalscale
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2022-04-12 09:11:05 +07:00
c6a5c07041
Adds a "Request password" button to the public share authentication page for shares
...
of type TYPE_EMAIL, when the "video verification" checkbox isn't checked. Users accessing
non-anonymous public shares (TYPE_EMAIL shares) can now request a temporary password themselves.
- Creates a migration step for the files_sharing app to add the 'password_expiration_time'
attribute to the oc_shares table.
- Makes share temporary passwords' expiration time configurable via a system value.
- Adds a system config value to allow permanent share passwords
-Fixes a typo in a comment in apps/files_sharing/src/components/SharingEntryLink.vue
See https://github.com/nextcloud/server/issues/31005
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
2022-04-11 21:58:24 +07:00
151c800397
allow reusing known folder info when getting directory contents
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-06 14:40:34 +07:00
b8b4d247b4
Merge pull request #31194 from nextcloud/feat/allow-to-exclude-groups-from-password-enforcement
...
Allow to disable password policy enforcement for selected groups
2022-04-06 10:13:23 +07:00
a29251e02d
Allow to disable password policy enforcement for selected groups
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-05 17:04:17 +07:00
754603a04e
dont needlessly resolve path when getting internalPath/storage from Node
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-04 15:40:24 +07:00
135bdb3d58
Merge pull request #30823 from nextcloud/work/profiler
...
Built-in profiler
This adds the required API for collecting information about requests. This information
can then be displayed with the new 'profiler' app.
2022-04-04 12:56:37 +07:00
7d272c54d0
Add a built-in profiler inside Nextcloud
...
The webui is provided by a seperate application named profiler
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-04 10:28:26 +07:00
18c013d8fc
Add CSP policy merge priority for booleans
...
When two booleans conflict when merging CSP policies, true will win.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-01 13:56:34 +07:00
dd357d7f9b
Merge pull request #31679 from nextcloud/bugfix/noid/ensure-string-columns-to-be-maximum-of-4000
...
Ensure string column limit of 4.000 characters
2022-03-31 11:37:43 +07:00
765999f454
Merge pull request #31609 from nextcloud/fix/migrate-away-from-ilogger
...
Migrate from ILogger to LoggerInterface in lib/private
2022-03-29 09:39:38 +07:00
129bae62d4
Ensure string column limit of 4.000 characters
...
https://docs.oracle.com/en/database/oracle/oracle-database/19/refrn/datatype-limits.html#GUID-963C79C9-9303-49FE-8F2D-C8AAF04D3095
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-25 12:44:51 +07:00
bfd09a0669
Avoid select with no FROM clause for Oracle in tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 20:35:02 +07:00
efebbacca4
Add octetLength and charLength to function builder, and tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 20:35:02 +07:00
3546cfba1c
Fix more ILogger related problems from tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:27 +07:00
1809386862
Fix codestyle
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:27 +07:00
61f7f13bd8
Migrate from ILogger to LoggerInterface where needed in the tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:26 +07:00
367be7c55f
Allow reactions also with other combined emojis
...
Honerful copying the EmojiService from UserStatus for now
I think this should be put into a decent place and then reused,
but I couldn't find somethin short term before beta1
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-24 15:13:09 +07:00
d683e0d3d1
Automatically cut the token name on the first level
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-23 21:38:53 +07:00
343476f54f
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-23 11:00:34 +07:00
89e293d3fd
Test disabled for now due to multiple reasons
...
see https://github.com/nextcloud/server/pull/31580#issuecomment-1069182234 for details
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-22 17:07:48 +07:00
0acd4b5f82
Merge pull request #31235 from nextcloud/techdebt/noid/extract-request-id
...
Extract request id handling to dedicated class so it can be injected without DB dependency
2022-03-22 12:08:45 +07:00
108abd77ed
Add profile default setting for admin
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 02:55:12 +07:00
1fc0b4320c
Add global profile toggle config
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 02:55:12 +07:00
2d9d0702f0
Add method to set all account properties from json
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-17 16:33:19 +07:00
a99d33c72d
Discard duplicate collection name from account serialization
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-17 04:27:39 +07:00
04a4562a01
Merge pull request #31513 from nextcloud/techdebt/noid/enforce-primary-keys
...
Enforce primary keys as they are required to be performant in MySQL c…
2022-03-15 10:53:11 +07:00
21f96308c4
Overwrite the channel
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 16:16:30 +07:00
01e2a26749
Fix unit tests
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-03-10 14:19:48 +07:00
1970d3dc9a
Add a test for primary keys
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 14:04:04 +07:00
bd03dd37be
Allow to set a strict-dynamic CSP through the API
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-03-09 15:10:27 +07:00
917c74e214
type fixes
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:16 +07:00
d81713e5c1
simplify setup of circular SetupManager<->Manager
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:09 +07:00
22875bf367
move logic to decide what to setup to setupmanager
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:03 +07:00
1c468129af
adjust tests to new fs setup
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:29:59 +07:00
8b22a463e9
Merge pull request #31266 from nextcloud/root-setup-mountprovider
...
move root mount setup to mountproviders
2022-03-04 13:44:05 +07:00
821a0dc875
Merge pull request #31387 from nextcloud/fix/common-main-core-script-order
2022-03-04 14:37:41 +07:00
58d516b509
Make sure common and main core scripts are loaded first
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-03-04 10:22:56 +07:00
2dd96fe8da
Fix tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-28 11:24:41 +07:00
eede608c0e
Add event logging to app loading
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-28 11:24:41 +07:00
d08d0ebdda
skip localstorage dependend user test when not using local user storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-25 16:33:11 +07:00
8b7c8447a0
move root mount setup to mountproviders
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-24 17:21:42 +07:00
cfb7923e08
store mountprovider for each mount in the mounts table
...
this enabled more fine grained filesystem setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-23 18:02:33 +07:00
d078d53683
Fix tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-23 11:01:58 +07:00
cc6653e45c
Adjust and add unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-23 11:01:58 +07:00
cb252c5591
Add Transactional trait for atomic DB operations
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-17 09:58:41 +07:00
e485451eed
Add test
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-02-11 23:34:25 +07:00
2673775f6e
fix fs cache test user setup
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:28 +07:00
cd7a217c29
Merge pull request #31007 from nextcloud/enhancement/bootstrap-calendar-resource-room-backend-registration
...
Move calendar resource/room backend registration to IBootstrap
2022-02-09 10:25:03 +07:00
b765f79368
Allow apps to specify if their background job can be delayed
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-07 13:54:54 +07:00
9a656e5b35
Move calendar resource/room backend registration to IBootstrap
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-07 12:51:42 +07:00
82f602e857
Merge pull request #30354 from nextcloud/enhancement/talk-api
...
Add a Talk API for OCP
2022-02-04 09:54:13 +07:00
2f2538a57a
Merge pull request #30888 from nextcloud/comments-interface
...
Update ICommentsManager with reaction methods
2022-02-04 09:38:04 +07:00
2c356d0852
Add a Talk API for OCP
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-04 08:53:18 +07:00
8ec7c5c8ae
Update ICommentsManager with reaction methods
...
Fix psalm errors
Reorder methods and remove return null
Use best pattern on docblock
Goals: update https://github.com/ChristophWurst/nextcloud_composer/ with reaction methods.
The script
https://github.com/ChristophWurst/nextcloud_composer/blob/master/build.sh
only get lib/public classes
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-02-03 12:52:18 +07:00
c712987878
send request id in response header
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-01 14:24:01 +07:00
e8c66d0f89
Merge pull request #30794 from nextcloud/techdebt/noid/allow-to-get-comments-with-verb
...
Allow to get comments with a given set of verbs
2022-01-28 16:41:42 +07:00
429380337f
Fix fake manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 14:02:34 +07:00
7bb01b6ccc
Refactor and fixes on tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:40:29 +07:00
b9f74584a1
Fix check after change from string to mb_string
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:41 +07:00
189f9f96ce
Limit the summary and sort it afterwards
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:39 +07:00
f7cd995612
Order the reaction summary, improvements on validations
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:39 +07:00
1ce894a50c
Disable reactions if database don't support utf8mb4
...
Fix column size
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:37 +07:00
52affa9ddd
Skip if dont support 4 bytes UTF8
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:07 +07:00
b6d9e0542d
Fix column size to work with Oracle. Add unit tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 +07:00
425b5cf081
Add unit tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 +07:00
afe5b6dd8a
Prevent query error when use subquery
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 +07:00
89d109a4d9
Merge pull request #30508 from nextcloud/fix/psaml-bin
...
Fix psalm not running
2022-01-13 09:51:04 +07:00
b1048864f0
Merge pull request #30600 from nextcloud/fix/30595/idn-email-share
...
Fix idn emails not working in shares
2022-01-13 09:24:26 +07:00
6312c0df69
Check style update
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 00:19:07 +07:00
7ecb65f725
Add check before sending email that email address is valid
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-11 20:59:44 +07:00
2bc0749cb6
Merge pull request #30588 from nextcloud/bugfix/noid/fix-unset-scopes
2022-01-11 10:12:11 +07:00
c47406ad3c
Merge pull request #30291 from nextcloud/image-memory-limit
...
Prevent loading images that would require too much memory.
2022-01-11 13:35:56 +07:00
172be810b8
Fix test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-11 12:54:41 +07:00
d3d65e5c88
Prevent loading images that would require too much memory.
...
For most image formats, the header specifies the width/height.
PHP allocates an image object from that size, even if the actual
image data is much smaller. This image object size is not limited
by the limit configured in PHP.
The memory limit can be configured through "config.php" setting
"preview_max_memory" and defaults to 128 MBytes which should be
enough for most images without filling up all memory.
Signed-off-by: Joachim Bauch <bauch@struktur.de>
2022-01-11 11:44:38 +07:00
25ade6218a
Streamline reseting of private static properties
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 10:29:25 +07:00
92e60caa86
Revert "Streamline reseting of private static properties"
...
This reverts commit e50121d4c0
2022-01-10 18:42:07 +07:00
e50121d4c0
Streamline reseting of private static properties
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-10 17:34:48 +07:00
447cd553b6
Reset $scriptDeps in tests
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-08 10:15:48 +07:00
55986382e8
Merge pull request #30378 from nextcloud/feature/accept-multiple-args-on-concat
...
Accept multipe args on concat
2022-01-07 12:16:46 +07:00
f732cf1b04
Unit tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-07 09:54:41 +07:00
19a3656fd9
Fix email verification
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-01-06 23:47:42 +07:00
773c407965
Merge pull request #29921 from nextcloud/feature/noid/allow-to-count-commments-with-multiple-verbs
...
Allow to count comments with multiple verbs
2022-01-05 13:44:07 +07:00
03abaaaee5
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-05 11:53:33 +07:00
977d8479e3
Merge pull request #30393 from nextcloud/feature/add-group-concat-aggregator-function
...
Add group_concat aggregator function
2022-01-04 17:34:37 +07:00
46ad6fa3c7
Add a test with integer
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-04 09:15:17 +07:00
43fa2d5c8c
Test with real data
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-03 21:43:51 +07:00
fb6a9f308d
Add unit test
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-03 21:41:38 +07:00
7b9fea85b6
Add unit test and orderBy parameter
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-03 12:45:00 +07:00
491bd6260c
Sort app scripts topologically by its dependencies
...
Implement a proper topological sorting algorithm. Based on the
implementation by https://github.com/marcj/topsort.php
Logs an error in case a circular dependency is detected.
Fixes : #30278
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-12-29 16:40:05 +07:00
d73fe0ccd9
Merge pull request #29879 from nextcloud/bugfix/noid/sharing-enumeration-addressbooks
2021-12-21 08:11:04 +07:00
8dd119402a
Improve unit testing for Util::addScript() and Util::getScript()
...
Instead of checking for a predefined order of the scripts, test the
logic: core first, dependencies before their children, no duplicates and
all scripts still listed.
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-12-20 11:40:17 +07:00
ec4fff20e8
Avoid Deprecation warning from Zip tests on PHP 8.1
...
It is not allowed anymore to open an empty file as a new zip archive.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-16 09:58:40 +07:00
e053feb5db
Fix PHP deprecation warning in File/ViewTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-16 09:43:32 +07:00
2fe8042fff
Add integration tests for email completion
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-12-08 09:08:54 +07:00
791d57051a
Adapt tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-12-02 21:13:07 +07:00
6b3c703794
Merge pull request #29735 from nextcloud/background-scan-one-by-one
...
find users for background scan one by one
2021-12-02 17:09:43 +07:00
e95745c074
fix tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-12-02 17:43:16 +07:00
6d33d75be1
Remove unused imports
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-02 14:51:44 +07:00
617528312a
Fix last tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-02 10:39:49 +07:00
3e20cffc86
More test fixing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 22:38:57 +07:00
c6ae53096c
More test fixing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 22:17:19 +07:00
9f00179037
More unit test adjustments
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 21:40:14 +07:00
a8866b0253
Fix tests
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-12-01 19:53:24 +07:00
d384edc9c6
add method to shorten a string to given byte size to Utils
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-11-26 16:21:40 +07:00
fd487c1a43
Merge pull request #29432 from nextcloud/fix/support-php-8.1
...
Support PHP 8.1 - First batch
2021-11-23 15:41:20 +07:00
cd72045433
Make mock config return default value to fix warnings
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:29:00 +07:00
25fa0b8acd
Fix TempManager test errors about passing null to is_dir
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:29:00 +07:00
065531570d
Fix Encryption tests on PHP 8.1
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:59 +07:00
bb9c099e42
Fix FolderTest calls to Mountpoint constructor with wrong type
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:59 +07:00
3a1b3745eb
Fix DateTime constructor calls with null
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:58 +07:00
bc3acfc957
Fix test class names
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:57 +07:00
66bdda568a
Fix Guzzle function calls
...
Since 1.7.0 and 2.0 these functions are turned into static methods.
See https://github.com/guzzle/psr7#upgrading-from-function-api
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:57 +07:00
113756db30
Fix ArrayAccess and JsonSerializable return types
...
First round of modifications for PHP 8.1
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:56 +07:00
f01ad7b8d8
Improve normalizer detecting IPv4 inside of IPv6
...
The subnet for an IPv4 address inside of IPv6 is now returned in its
IPv4 form.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-22 16:46:25 +07:00
7e08a4ab15
Fix getting subnet of ipv4 mapped ipv6 addresses
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-22 14:10:11 +07:00
c42a890126
Merge pull request #29622 from nextcloud/feat/objectstore_multibucket-shift
...
Implement multibucket shift for ObjectStore
2021-11-19 17:26:44 +07:00
c92a0e4152
Normalize directory entries in Encoding wrapper
...
Directory entry file names are now normalized in getMetaData(),
getDirectoryContents() and opendir().
This makes the scanner work properly as it assumes pre-normalized names.
In case the names were not normalized, the scanner will now skip the
entries and display a warning when applicable.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-17 09:43:25 +07:00
e9b414fbe3
OC_Util: Add fallbacks to check if current locale is UTF8
...
Using escapeshellcmd to get current locale causes error
if the function is disabled.
Add fallbacks to prevent the error.
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-16 00:40:52 +07:00
25f15f86a9
Add check whether escapeshellcmd behaves the same as basename
...
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-15 18:33:50 +07:00
455bff5c17
Fix missing setlocale with php 8
...
When php version = 8, basename('§') does not bug even if LC_ALL is non-UTF-8 locale.
This cause OC_Util::isSetLocaleWorking() to skip setlocale("C.UTF-8").
Fix it by using escapeshellcmd instead of basename.
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
2021-11-14 09:18:59 +07:00
265c2c125c
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-12 15:01:56 +07:00
6ab2feaa54
Implement multibucket shift for ObjectStore
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-11-11 15:09:28 +07:00
3b91e4cc48
Add unit test for share enumeration method
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 14:42:57 +07:00
fa036b2001
Move common logic to share manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 10:10:53 +07:00
58b6f35522
Enable Avatar tests as well for PHP>=8
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-10-28 17:49:32 +07:00
23a4e17bd1
Revert "Do not run image tests on php8"
...
This reverts commit d690f90928
2021-10-28 17:49:21 +07:00
c42f5bc5f6
Add an OCP for trusted domain helper
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-28 10:24:16 +07:00
f4e4a85fcf
Merge pull request #27440 from nextcloud/is-file-handle
2021-10-23 11:18:52 +07:00
a06001e085
Merge pull request #29363 from nextcloud/fair-use-push
2021-10-23 10:53:22 +07:00
b578a1e8b5
Fair use of push notifications
...
We want to keep offering our push notification service for free, but large
users overload our infrastructure. For this reason we have to rate-limit the
use of push notifications. If you need this feature, consider setting up your
own push server or using Nextcloud Enterprise.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-23 00:54:50 +07:00
e26d6f080b
fix populating account array with missing default values
...
- both $userData and $defaultUserData have numeric indices
- each element contains at least the name and other fields
- appending the missing data array is sufficient
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-10-22 23:05:43 +07:00
dae769d082
Update Tests
2021-10-22 12:16:11 +07:00
2be0eda47c
Merge pull request #29220 from nextcloud/s3-external-list
2021-10-22 12:06:05 +07:00
c98039c1df
Merge pull request #26725 from nextcloud/fix-federated-scope-not-shown-when-public-addressbook-upload-is-disabled
2021-10-22 11:52:56 +07:00
0a35937662
Merge pull request #26347 from J0WI/clean-path-regex
2021-10-22 11:42:30 +07:00
7e3b6e7088
Merge pull request #29344 from nextcloud/dependabot/composer/doctrine/dbal-3.1.3
2021-10-22 11:35:02 +07:00
7dd7256cfe
Prevent duplicate auth token activity updates
...
The auth token activity logic works as follows
* Read auth token
* Compare last activity time stamp to current time
* Update auth token activity if it's older than x seconds
This works fine in isolation but with concurrency that means that
occasionally the same token is read simultaneously by two processes and
both of these processes will trigger an update of the same row.
Affectively the second update doesn't add much value. It might set the
time stamp to the exact same time stamp or one a few seconds later. But
the last activity is no precise science, we don't need this accuracy.
This patch changes the UPDATE query to include the expected value in a
comparison with the current data. This results in an affected row when
the data in the DB still has an old time stamp, but won't affect a row
if the time stamp is (nearly) up to date.
This is a micro optimization and will possibly not show any significant
performance improvement. Yet in setups with a DB cluster it means that
the write node has to send fewer changes to the read nodes due to the
lower number of actual changes.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-22 09:32:22 +07:00
130ab63ca1
Bump doctrine/dbal from 3.0.0 to 3.1.3
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-22 09:03:45 +07:00
0bef570fe9
Merge pull request #29256 from nextcloud/fix/noid/harmonize-appstoreenabled-check
...
Fix appstoreenabled check
2021-10-21 12:42:14 +07:00
f24e8212c3
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-21 09:27:12 +07:00
7f1dc52a66
Change origin field to appId
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-20 14:47:28 +07:00
5e23800a95
Do not remove current user on findOne
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-10-20 11:53:45 +07:00
873e8e219c
Add appName to contactsmenu action API
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-10-20 11:53:45 +07:00
309354852f
Profile backend
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-10-19 04:59:35 +07:00
7215148a24
Add new account properties
...
- New properties
- Organisation
- Role
- Headline
- Biography
- Profile Enabled property
- Fix errors with building default account properties
- Fix L10N factory method `getLanguage` not public error
- Update tests
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-10-19 04:44:40 +07:00
294b218895
ci
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-15 15:35:12 +07:00
f7a4ff4d63
Merge pull request #27217 from nextcloud/techdebt/noid/make-debugging-a-cron-job-easier
2021-10-15 11:09:23 +07:00
b6a3ba136c
Merge pull request #29235 from nextcloud/feat/appstore/enterprise
2021-10-15 11:06:32 +07:00
67baaaaff9
Merge pull request #29231 from nextcloud/fix/calendar-providers-instances
...
Build instances of the calendar providers before using them
2021-10-14 19:29:34 +07:00
c75a12c154
Build instances of the calendar providers before using them
...
What we get from the registration context are only the class names. We
still have to load the classes before we can use them.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-14 16:06:51 +07:00
1f76423500
Send the subscription key to the appstore requests
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-10-14 14:48:45 +07:00
acbe4b46c3
Merge pull request #29157 from nextcloud/enh/opendocument
2021-10-14 12:58:34 +07:00
9cd9f4b4bc
Move queries to the joblist
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-14 09:57:16 +07:00
811d0cd1b5
Merge pull request #29135 from nextcloud/feat/appstore-filtering
...
Allow to filter apps from the appstore
2021-10-14 09:50:37 +07:00
a58d1e6b06
Add Public Calendar Provider
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-14 08:22:24 +07:00
2f38781c96
Fix integrity checker tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-13 18:10:37 +07:00
1a6bac5874
Allow to whitelist apps from the apsptore
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2021-10-13 11:13:33 +07:00
e163d199d8
Merge pull request #29015 from nextcloud/enhancement/l10n-factory-find-generic-language
...
Add L10n factory method for generic language heuristics
2021-10-13 10:58:07 +07:00
5b727fc7da
Add L10n factory method for generic language heuristics
...
The existing `findLanguage` method tries its best to find the best
language for the current users. For some tasks we don't want this but
rather determine the most generic language for *another* user, e.g. when
the current user trigger an email notifiaction to someone else. In this
case the current user's language is a bad guess in many multi-language
environments.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-13 09:57:21 +07:00
3487aeeb1f
Add integration tests for group
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-10-12 14:05:38 +07:00
9187e986e1
Merge pull request #28907 from nextcloud/bug/noid/close-stream-local
...
explicitly close source stream on local / encryption storage
2021-10-08 10:02:01 +07:00
d68f028251
Merge pull request #27733 from PhrozenByte/enhancement/noid/IURLGenerator-linkToDefaultPageUrl
2021-10-05 13:06:59 +07:00
6958d8005a
Add admin privilege delegation for admin settings
...
This makes it possible for selected groups to access some settings
pages.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-09-29 21:43:31 +07:00
9161f6ca4a
Remove tests that just prove mocked calls and don't actually validate anything useful
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-09-27 14:24:48 +07:00
cab44b6311
Run oci tests against phpunit9/php8
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-09-27 14:24:05 +07:00
e60a829b42
explicitly close source stream on local storage
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-09-21 17:41:59 +07:00
024881dbd3
Add email addresses to contacts menu
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-09-15 16:58:44 +07:00
0dcc5c0e9f
Merge pull request #28728 from nextcloud/add-database-backend-limiter
...
Add database ratelimiting backend
2021-09-13 13:07:37 +07:00
27865d03c0
use specific email getter where necessary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +07:00
4461b9e870
enable the user to set a primary (notification) email address (backend)
...
- specific getters and setters on IUser and implementation
- new notify_email field in provisioning API
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:04 +07:00
a20de15b43
add a job to clean up expired verification tokens
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 14:03:35 +07:00
aacaad2a3f
implement verification for additional mails
...
- mails added by (sub)admins are automatically verified
- provisioning_api controller as verification endpoint
- IAccountProperty gets a locallyVerified property
- IPropertyCollection gets a method to fetch an IAccountProperty by value
- an remove equivalent was already present
- AccountManager always initiates mail verification on update if necessary
- add core success template for arbitrary title and message
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 14:03:35 +07:00
19cc757531
move verification token logic out of lost password controller
...
- to make it reusable
- needed for local email verification
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 14:03:29 +07:00
6337bb3f59
Adjust tests
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-06 17:46:02 +07:00
378cc922c4
Adjust logic to store period instead of current timestamp
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-09-06 17:31:36 +07:00
3866f388b1
Refactor writeObject to only use MultipartUpload when required
...
Signed-off-by: Bernd Rederlechner <Bernd.Rederlechner@t-systems.com>
Co-authored-by: Julius Härtl <jus@bitgrid.net>
2021-08-20 17:02:25 +07:00
83b39d6111
Add missing scope to test
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-08-18 19:05:33 +07:00
7c76e85dde
Use IURLGenerator function to get value of `\OC::$WEBROOT` global
...
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2021-08-16 10:56:47 +07:00
11169c86f8
Tests update
2021-08-15 12:23:29 +07:00
67e6468b9e
Merge pull request #28220 from nextcloud/get-by-id-multiple-mounts-single-storage
2021-08-09 19:27:23 +07:00
a1d6189dfa
Fix UrlGeneratorTest
...
And again... 😒
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-08-05 13:55:35 +07:00
aa455e71d9
Merge branch 'master' into enhancement/noid/IURLGenerator-linkToDefaultPageUrl
2021-08-04 18:52:55 +07:00
b768cade2b
Fix UrlGeneratorTest
...
Again... 😒
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-08-04 18:52:53 +07:00
416d10f76c
refs #21045 add app config to disable unlimited quota and to set max quota
...
avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed
avoid getting/setting/displaying unlimited default quota if not allowed
implement tests for unlimited quota restrictions
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-29 19:31:36 +07:00
db7ffb0bf9
Merge pull request #28175 from nextcloud/jail-search-root
2021-07-29 09:27:53 +07:00
5c2e7c7d28
fix Folder->getById() when a single storage is mounted multiple times
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-07-28 17:21:04 +07:00
4d5e8bcb99
add test for searching within a "root jail"
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-07-28 17:11:12 +07:00
b31c08e536
Merge pull request #28075 from nextcloud/enh/noid/admin_audit-report-full-path
...
Admin Audit - Sharing: createShare - report the full path
2021-07-26 12:35:48 +07:00
858d846999
Let memory limit set in tests fit the used amount
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-22 17:05:29 +07:00
4570bb4f65
Admin Audit - Sharing: createShare - report the full path
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-22 14:20:05 +07:00
7179002600
Allow to get a local cloud id without going through the contacts manager
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-14 16:08:05 +07:00
11d21e5f5c
Add a unit test to check for casting a IQueryFunction
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-07-07 14:19:24 +07:00
415d704959
Merge pull request #27198 from nextcloud/tests/run-s3-tests
...
Run s3 tests again
2021-07-05 11:52:48 +07:00
1e5962ae98
Fix UrlGeneratorTest::testGetDefaultPageUrlWithDefaultApps()
...
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 16:39:26 +07:00
15a445f743
Move UtilTest::testDefaultApps() to UrlGeneratorTest
...
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 16:26:55 +07:00
e16bf707aa
Fix UtilTest::testDefaultApps()
...
Oh wow... This definitly was no best practice... 😒
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-07-01 16:00:29 +07:00
b78f3a57d1
Migrate HintException to OCP
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 +07:00
12059eb65b
Add IUrlGenerator::linkToDefaultPageUrl()
...
Replaces the deprecated \OC_Util::getDefaultPageUrl() and makes this API public.
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
2021-06-30 16:20:57 +07:00
3f44fd00e2
Run s3 tests again
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-30 14:30:04 +07:00
506227b509
adjust internal data handling logic to fix store and load
...
- format as stored previously in oc_accounts table is kept
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:48:01 +07:00
c7bf4295cc
adjust email verification checker
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:47:36 +07:00
3d6ffd3da2
adjust verification state updater method
...
- also fixes scope of internal methods
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:42:42 +07:00
af3fdbea7b
make AccountManager actually write multi value properties
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:12 +07:00
638c04d6e0
accounts event handler to use eventdispatcher, DI and Accounts API
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:11 +07:00
13818005a3
prov api reports additional emails on getUser
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:10 +07:00
9ed379da22
Merge pull request #27635 from nextcloud/fix/datetime-constants
...
Fix usage of DateTime constants
2021-06-23 09:56:28 +07:00
6d5cfe0c66
Move DateTime::RFC2822 to DateTimeInterface::2822
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-23 15:30:43 +07:00
770881d5d6
Move DateTime::ATOM to DateTimeInterface::ATOM
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-06-23 15:28:07 +07:00
ee7a484284
Merge pull request #26346 from J0WI/clean-auth-regex
...
Cleaner removePassword regex
2021-06-23 11:20:19 +07:00
a94236483e
Let apps toggle an unread counter on app icons
...
Co-authored-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-16 17:12:56 +07:00
66e10718c6
split of query building bits from searchhelper
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:40 +07:00
f938daa6e4
update tests and fix some edge cases around new search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:36 +07:00
e198dc1b20
rework search api to allow searching on multiple caches at once
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:22 +07:00
89c534858e
Merge pull request #27414 from francoisfreitag/test-at-2
...
Rewrite LegacyHelperTest without $this->at()
2021-06-08 22:07:16 +07:00
745543d8c0
Merge pull request #27306 from nextcloud/enh/noid/set-local-domain-for-swiftmailer
...
Set local domain for swiftmailer
2021-06-08 15:43:39 +07:00
662ab937e0
Merge pull request #27189 from nextcloud/feat/26866/account-collection-properties
...
Extend Accounts with multivalue properties (PropertyCollection)
2021-06-08 14:25:18 +07:00
ff2382e5a4
CI: more flexible assertions
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-07 23:41:04 +07:00
21762a1e94
Rewrite LegacyHelperTest without $this->at()
...
The at() matcher has been deprecated. It will be removed in PHPUnit 10.
Please refactor your test to not rely on the order in which methods are
invoked.
Signed-off-by: François Freitag <mail@franek.fr>
2021-06-07 21:43:30 +07:00
181aab416a
Fix warnings about logException
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-04 10:57:09 +07:00
44827e37c0
allow interacting with IAccountPropertyCollections
...
- in fact the API could be done in a nicer way and it might be possible to
work without IAccountPropertyCollection, but only with the
IAccountProperties.
- To keep it simple at first and not overengineer the blunt attempt is
followed
- If necessary helpful in the further cause of development adjustements or
extensions can be done quickly with this base
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:49 +07:00
0bade27479
add IAccountPropertyCollection with implementation
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:49 +07:00
afea57352b
update unit tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-03 20:49:49 +07:00
377514aad1
Escape filename in Content-Disposition
...
We should escape all occurences of ' and \ in here.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-02 19:22:17 +07:00
d0cf20cc51
Merge pull request #26792 from nextcloud/user-delete-cleanup-files
...
better cleanup of user files on user deletion
2021-06-02 17:02:00 +07:00
747325fc43
Set local domain for swiftmailer transport
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-05-31 15:04:00 +07:00
1c0d975654
Make dav respect disallowing sharing with groups
...
Closes #25390
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2021-05-26 11:19:59 +07:00
847ed37afc
do not use private AccountManager in UsersController
...
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-25 14:35:38 +07:00
f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share
...
Add option to exclude groups from creating link shares
2021-05-21 15:35:39 +07:00
1627eb45bb
l10n: Fix test
2021-05-20 09:26:38 +07:00
35b910cf8e
Merge pull request #26322 from nextcloud/recent-search
...
Use file search for recent files and optimize getting share types
2021-05-18 09:44:08 +07:00
ee3dc57cbd
Merge pull request #26626 from J0WI/strict-security
...
Make Security module strict
2021-05-18 08:43:13 +07:00
0ab5b3e265
Merge pull request #26679 from nextcloud/bugfix/noid/fix-unauthorized-ocs-status-in-provisioning
...
Fix unauthorized OCS status in provisioning
2021-05-13 23:39:20 +07:00
b1dca57a1c
load share settings from the share manager in more places
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:28 +07:00
b6c6527705
Fix unauthorized OCS status in provisioning
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 08:16:07 +07:00
8413ed9475
allow to set valid scopes only in AccountProperty
...
the auto-fallback to v2-local is removed as well to react on wrong input
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 01:31:15 +07:00
ed2d02d5f1
better cleanup of user files on user deletion
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-27 20:29:51 +07:00
99f0b10421
Merge pull request #26591 from nextcloud/techdebt/noid/less-ilogger
...
Less ILogger
2021-04-27 15:38:12 +07:00
48c50277a9
Merge pull request #26718 from nextcloud/bugfix/noid/fix-ratelimit-template
...
Fix ratelimit template
2021-04-27 15:18:02 +07:00
c52a026f55
Merge pull request #26572 from nextcloud/bugfix/noid/throw-401-when-authentication-is-provided-and-invalid
...
Throw "401 Unauthenticated" when authentication is provided but invalid
2021-04-27 14:37:28 +07:00
df47445c01
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +07:00
174f4dd043
Fix ratelimit template
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:55:34 +07:00
aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid
...
Validate the website field input to be a valid URL
2021-04-26 13:56:01 +07:00
012f791c8f
Merge pull request #26375 from nextcloud/techdebt/noid/symfony-component-translation-pluralization-rules-is-deprecated
...
"Symfony\Component\Translation\PluralizationRules" is deprecated
2021-04-22 21:20:16 +07:00
d80cc76ee7
Validate the website field input to be a valid URL
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 16:34:13 +07:00
4ed296db9f
Fix Authentication test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 15:36:34 +07:00
effb7dc8ba
set mimetype for objects uploaded to object storages
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-21 15:25:58 +07:00
0d5f4edc22
adjust tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-21 14:09:07 +07:00
2a11713337
Update CredentialsManagerTest.php
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-21 08:33:10 +07:00
9e8690d912
Merge pull request #26654 from nextcloud/bugfix/noid/fix-security-credentials-manager-test
...
Fix security credentials manager test
2021-04-20 22:03:52 +07:00
5ee9e1f784
Move 2FA registration to IBootstrap
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 21:01:16 +07:00
7f70f3e182
Fix support tests
...
2) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #0 (35, 15, 2, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist
3) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #1 (35, 45, 15, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist
4) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #2 (35, 45, 5, true)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist
5) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #3 (35, 45, 55, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist
Had to use the Database user backend, as using multiple interfaces is deprecated:
https://github.com/sebastianbergmann/phpunit/issues/3955
> This functionality should be deprecated as "having to use it" is almost always a symptom of bad design.
> More importantly, though, the support for the creation of test doubles that implement multiple interfaces
> resulted in code that is hard to maintain.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:36:15 +07:00
c6978bac80
Fix security credentials manager test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 17:04:24 +07:00
79ebc7f24c
Fix test by defining plurals
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:43 +07:00
5a514a9a41
Correctly replace all PHP placeholders with the parameters
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:05 +07:00
92ca49d21d
save a whitespace today
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 14:03:01 +07:00
f8d1ee5cfa
ignore mail shares of related remote share results
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 14:02:35 +07:00
ca7b37ce5a
Make Security module strict
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-19 17:31:12 +07:00
751be29c73
Merge pull request #26555 from nextcloud/techdebt/noid/run-migrator-tests-on-OCI
...
Run migrator tests on OCI
2021-04-19 08:57:41 +07:00
808e589035
Allow registering NotifierServices trough IBootstrap
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +07:00
1670d00452
Integer 0 is not stored as Null and therefor works
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-16 09:57:27 +07:00
8b4ecdcc88
Test that oracle throws on EmptyValues in a NotNull columns
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-16 09:57:27 +07:00
e88bad4b0a
Run migrator tests on OCI
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-16 09:57:27 +07:00
b5ffca00f7
Fix unit test
...
* Fix namespace
* Fix test
Was broken after https://github.com/nextcloud/server/pull/26529
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 09:47:52 +07:00
af61486aea
Separate settings for remote share expiration
...
Added separate settings for default and enforced expiration date for
remote shares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +07:00
789bb0d0ac
Merge pull request #26266 from nextcloud/future-proof-networking
...
Improve networking checks
2021-04-12 12:42:33 +07:00
e5a4236e68
Increase subnet matcher
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-07 12:28:59 +07:00
4b4971ab52
Merge pull request #24966 from nextcloud/jknockaert-patch-1
...
avoid fread on directories and unencrypted files
2021-04-06 13:45:10 +07:00
9dab851931
Adjust test
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:37:47 +07:00
5f3abffe6f
Improve networking checks
...
Whilst we currently state that SSRF is generally outside of our threat model, this is something where we should invest to improve this.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:37:47 +07:00
5fb909faa5
Merge pull request #24055 from nextcloud/bugfix/noid/enfore-no-notnull-for-boolean-to-store-false
...
Enforce no notnull for boolean to store false
2021-04-01 18:30:26 +07:00
37591f05dc
Get the parent directory before creating a file from a template
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:48:21 +07:00
f9d4fa2d38
Rename the method to match what it does
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:18 +07:00
3696ef5b96
Don't allow Notnull for boolean columns
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:17 +07:00
2212a67fbc
Merge pull request #25961 from nextcloud/enh/events/2fa_provider
...
Add real events for enabled 2fa providers for users
2021-03-30 23:13:36 +07:00
f3738eeff7
Merge pull request #25280 from nextcloud/explicit-file-permissions
...
Set umask before operations that create local files
2021-03-30 21:55:50 +07:00
be3ae9a44b
gracefully handle deleteFromSelf when share is already gone
...
- handling race conditions
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-30 12:59:40 +07:00
8d3fdf24c8
Merge pull request #26353 from nextcloud/techdebt/noid/make-testcase-class-compatible-with-phpunit-9.5
...
Make Testcase class compatible with phpunit-9.5
2021-03-29 10:47:37 +07:00
cd35a5c71d
Make Testcase class compatible with phpunit-9.5
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-29 09:43:08 +07:00
d58d6199d9
Cleaner normalizePath regex
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-03-27 21:29:28 +07:00
5f468c0248
Cleaner removePassword regex
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-03-27 18:42:58 +07:00
cc54f718f5
Add known user check in avatar when v2-private scope
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:10 +07:00
bb008be28a
Added PlaceholderAvatar with own cached images
...
When avatar scope is private, the PlaceholderAvatar is used to deliver a
placeholder avatar based on the user's initials.
This was implemented as a separate class for now to avoid messing with
the existing UserAvatar implementation and its generated vs
non-generated logic.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +07:00
b73df5846c
Add property scope tests for AccountManager
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +07:00
278a73789e
Map old account scope properties to new names
...
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +07:00
b81a1c1bdb
Add new v2-private account scope
...
Added new v2-private account manager scope that restricts the scope
further by excluding public link access.
Avatars with v2-private account scope are now showing the guest avatar
instead of the real avatar.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:05 +07:00
ab48d5e8cb
Cleanup unneeded code around database.xml
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-24 22:15:44 +07:00
e5dc1a8085
Set umask before operations that create local files
...
this solves issues where "other php stuff" is messing with the umask
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 14:52:31 +07:00
1c074e7602
Merge pull request #26198 from nextcloud/unified-search-node
...
Handle limit offset and sorting in files search
2021-03-22 21:48:51 +07:00
3c5cf825b3
Add real events for enabled 2fa providers for users
...
* Shiny new events
* Listener to still emit the old event
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-22 20:57:10 +07:00
15767643f2
Fix sharebymail tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:47 +07:00
f99876997a
Remove duplicated query for email shares
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 06:50:47 +07:00
bfe3712372
handle ordering in folder search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 16:07:54 +07:00
76170a58eb
Log and continue when failing to update encryption keys during for individual files
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-19 14:12:07 +07:00
feed42dd6d
folder filtering in sql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 13:41:00 +07:00
1286848731
Merge pull request #23718 from nextcloud/already-shared-error-message
...
expand 'path is already shared' error message
2021-03-19 13:39:22 +07:00
de713967c0
cleanup fileinfo creation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 13:35:37 +07:00
7bf5adb1fa
Merge pull request #26200 from nextcloud/bugfix/26197/fix-expiration-validation-confusion
...
Update user share must use correct expiration validation
2021-03-19 10:51:21 +07:00
bd229e7548
handle limit and offset in folder file search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 17:38:31 +07:00
50e374c12f
only require user to be set in a query that handles tags
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 17:16:28 +07:00
a9e3d2a10f
Update user share must use correct expiration validation
...
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.
To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-18 17:12:28 +07:00
9e3775618b
log full expection during repair step
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:17 +07:00
a2f3077ee8
Skip db migration simulation for core schema changes
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-17 21:08:22 +07:00
0d46fafd41
Merge pull request #26161 from nextcloud/bugfix/noid/improve-matching-of-phonebook-searches
...
Improve search results when only phonebook-matches can we autocompleted
2021-03-17 15:22:03 +07:00
cf434d5107
Also limit to user group in case enumeration is enabled for groups and phonenumbers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 11:20:30 +07:00
Louis Chemineau
Côme Chilliet
Joas Schilling
Arthur Schiwon
Christopher Ng
Julius Härtl
Joas Schilling
Artur Neumann
Côme Chilliet
Thomas Citharel
Daniel Kesselberg
Vitor Mattos
Ferdinand Thiessen
Marcel Klehr
Anna Larch
Louis
Simon L
MichaIng
Robin Appelman
Christoph Wurst
Vincent Petry
Bennet Becker
Bennet Becker
Stanimir Bozhilov
Julien Veyssier
J0WI
Carl Schwan
John Molakvoæ
Git'Fellow
Christoph Wurst
Varun Patil
John Molakvoæ
Roeland Jago Douma
Andy Xheli
Stanimir Bozhilov
Simon Leiner
Julien Veyssier
Richard Steinmetz
Pytal
Kirill Popov
Maxence Lange
Cyrille Bollu
Joachim Bauch
Jonas Meurer
Naoto Kobayashi
acsfer
Lukas Reschke
Bernd Rederlechner
Daniel Calviño Sánchez
Daniel Rudolf
Gary Kim
François Freitag
Morris Jobke
Valdnet
Roeland Jago Douma